Re: [xml] Global error (xmlLastError) not cleaned up if xmlCleanupParser() is called on a different thread!

2014-06-10 Thread Martin Ba
On 09.06.2014 16:19, Daniel Veillard wrote: On Thu, Apr 10, 2014 at 01:27:30PM +0200, Martin Ba wrote: Hi all! It would appear that when you have a scenario like this + + + + // Thread 1: xmlInitParser(); // ... // anything that sets the last error, e.g.: xmlReadFile("file isn't there", NULL,

Re: [xml] [BUG+FIX] valid.c erroneously ignores a validation error if no error callback set

2014-06-10 Thread Daniel Veillard
Ah, right ! Fixed upstream and bug updated, thanks ! Daniel On Fri, Feb 21, 2014 at 06:20:32PM +0100, Stefan Behnel wrote: > Hi, > > valid.c contains this code: > >2636 if ((ctxt != NULL) && (ctxt->error != NULL)) { >2637 xmlErrValidNode(ctxt, attr->parent, XML_DTD_ID_REDEFINED

Re: [xml] Global error (xmlLastError) not cleaned up if xmlCleanupParser() is called on a different thread!

2014-06-10 Thread Daniel Veillard
On Tue, Jun 10, 2014 at 09:50:13AM +0200, Martin Ba wrote: > On 09.06.2014 16:19, Daniel Veillard wrote: > >On Thu, Apr 10, 2014 at 01:27:30PM +0200, Martin Ba wrote: > >>Hi all! > >> > >>It would appear that when you have a scenario like this > >> > >>+ + + + > >>// Thread 1: > >>xmlInitParser();

Re: [xml] Global error (xmlLastError) not cleaned up if xmlCleanupParser() is called on a different thread!

2014-06-10 Thread Alex Bligh
On 10 Jun 2014, at 09:14, Daniel Veillard wrote: >> * For this specific case (error cleanup), I strongly believe that the >> problem could be corrected without affecting either the API or ABI, but I >> don't have time to investigate more since the workaround `xmlResetLastError` >> does work OK fo

Re: [xml] Global error (xmlLastError) not cleaned up if xmlCleanupParser() is called on a different thread!

2014-06-10 Thread Daniel Veillard
On Tue, Jun 10, 2014 at 09:38:48AM +0100, Alex Bligh wrote: > > On 10 Jun 2014, at 09:14, Daniel Veillard wrote: > > >> * For this specific case (error cleanup), I strongly believe that the > >> problem could be corrected without affecting either the API or ABI, but I > >> don't have time to inve

Re: [xml] Global error (xmlLastError) not cleaned up if xmlCleanupParser() is called on a different thread!

2014-06-10 Thread Alex Bligh
Daniel, >> FWIW last time this all came up (possibly my fault) I was going to send >> you a patch, >> >> What that would have done was: >> >> a) provide 2 new calls: >> xmlContextPtr xmlNewContext() >> xmlFreerContext(xmlContextPtr ctx) >> >> b) make these two increment a static variable, a

Re: [xml] [BUG] [PATCH] --postvalid broken after CVE-2014-0191 fix

2014-06-10 Thread Alexey Neyman
Hi Daniel, Your patch works for me, thanks! One more thing you missed though: s/parsed/parameter/ in the copy-pasted comment :) Regards, Alexey. On Monday, June 09, 2014 07:06:02 am Daniel Veillard wrote: > Pong, sorry, but was distracted with other things and I accumulated > feedback from di