https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
Guido Falsi changed:
What|Removed |Added
Assignee|ports-b...@freebsd.org |xfce@FreeBSD.org
CC|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
--- Comment #4 from Guido Falsi ---
I forgot I have another question for you:
I see the github repo you pint to is a fork of another repo.
What's the difference?
Why the fork is to be preferred?
--
You are receiving this mail because:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
--- Comment #5 from Quentin Baker ---
(In reply to Guido Falai from comment #3)
No rush, I understand. I honestly was a bit surprised it had someone already
looking at the ticket. And yes, feel free to add my name and email as currently
sho
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
--- Comment #6 from Guido Falsi ---
(In reply to Quentin Baker from comment #5)
Thanks for the feedback.
Getting the sources from xfce own gitlab instance would be "more official", so
a better choice, eventually I'll see if it can be done
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
--- Comment #7 from Quentin Baker ---
(In reply to Guido Falsi from comment #6)
Sure. If you think its worth doing, I can mess around with the USE_GITLAB use
fields and file a report if I can see why its failing.
--
You are receiving this
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
--- Comment #8 from Guido Falsi ---
(In reply to Quentin Baker from comment #7)
In the while I noticed some issues by skimming you submission patch:
instead of doing:
DISTVERSION=v0.3.0
you should use:
PORTVERSION=0.3.0
DISTVER
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
Quentin Baker changed:
What|Removed |Added
Attachment #227025|0 |1
is obsolete|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
--- Comment #10 from Quentin Baker ---
(In reply to Guido Falsi from comment #8)
I have added an updated patch that alphabetizes the USE/USES fields and expands
the pkg-desc.
The LDFLAGS line comes from the suggestion of implementation by
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257692
Quentin Baker changed:
What|Removed |Added
Attachment #227093|0 |1
is obsolete|
