Re: [Xen-devel] [PATCH v2 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-06 Thread Boris Ostrovsky
On 06/06/2018 04:14 AM, Oleksandr Andrushchenko wrote: > On 06/04/2018 11:12 PM, Boris Ostrovsky wrote: >> On 06/01/2018 07:41 AM, Oleksandr Andrushchenko wrote: >> @@ -121,8 +146,27 @@ static void gntdev_free_map(struct grant_map *map) >>   if (map == NULL) >>    

Re: [Xen-devel] [PATCH v2 6/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-06 Thread Boris Ostrovsky
On 06/06/2018 05:06 AM, Oleksandr Andrushchenko wrote: > On 06/04/2018 11:49 PM, Boris Ostrovsky wrote: >> On 06/01/2018 07:41 AM, Oleksandr Andrushchenko wrote: >> +struct gntdev_dmabuf_export_args { >> +    int dummy; >> +}; >> >> Please define the full s

Re: [Xen-devel] [PATCH v2 7/9] xen/gntdev: Implement dma-buf export functionality

2018-06-06 Thread Boris Ostrovsky
On 06/06/2018 08:10 AM, Oleksandr Andrushchenko wrote: > On 06/05/2018 01:07 AM, Boris Ostrovsky wrote: >> On 06/01/2018 07:41 AM, Oleksandr Andrushchenko wrote: >> + >> +static struct sg_table * >> +dmabuf_exp_ops_map_dma_buf(struct dma_buf_attachment *atta

Re: [Xen-devel] [PATCH v2 9/9] xen/gntdev: Expose gntdev's dma-buf API for in-kernel use

2018-06-06 Thread Boris Ostrovsky
On 06/06/2018 08:46 AM, Oleksandr Andrushchenko wrote: > On 06/05/2018 01:36 AM, Boris Ostrovsky wrote: >> On 06/01/2018 07:41 AM, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Allow creating grant device context for use by kernel mod

Re: [Xen-devel] [PATCH v2 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-07 Thread Boris Ostrovsky
(Stefano, question for you at the end) On 06/07/2018 02:39 AM, Oleksandr Andrushchenko wrote: > On 06/07/2018 12:19 AM, Boris Ostrovsky wrote: >> On 06/06/2018 04:14 AM, Oleksandr Andrushchenko wrote: >>> On 06/04/2018 11:12 PM, Boris Ostrovsky wrote: >>>> On

[Xen-devel] [PATCH v2 6/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-07 Thread Boris Ostrovsky
On 06/07/2018 03:17 AM, Oleksandr Andrushchenko wrote: > On 06/07/2018 12:32 AM, Boris Ostrovsky wrote: >> On 06/06/2018 05:06 AM, Oleksandr Andrushchenko wrote: >>> On 06/04/2018 11:49 PM, Boris Ostrovsky wrote: >>>>> diff --git a/drivers/xen/gntdev.c b

Re: [Xen-devel] [PATCH v2 7/9] xen/gntdev: Implement dma-buf export functionality

2018-06-07 Thread Boris Ostrovsky
On 06/07/2018 04:44 AM, Oleksandr Andrushchenko wrote: > On 06/07/2018 12:48 AM, Boris Ostrovsky wrote: >> On 06/06/2018 08:10 AM, Oleksandr Andrushchenko wrote: >>> On 06/05/2018 01:07 AM, Boris Ostrovsky wrote: >>>> On 06/01/2018 07:41 AM, Oleksandr Andrushchenko

Re: [Xen-devel] [PATCH v2 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-08 Thread Boris Ostrovsky
On 06/08/2018 01:59 PM, Stefano Stabellini wrote: >    @@ -325,6 +401,14 @@ static int map_grant_pages(struct grant_map *map)    map->unmap_ops[i].handle = map->map_ops[i].handle;    if (use_ptemod)    map->kunmap

Re: [Xen-devel] [PATCH] xen/netfront: raise max number of slots in xennet_get_responses()

2018-06-11 Thread Boris Ostrovsky
showed no > more messages "too many slots" and throughput was as high as with the > kernel-xen based guest system). > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky I wonder also whether netfront_tx_slot_available() is meant to be return (queue->tx

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644 index ..e0939387278d --- /dev/null +++ b/include/xen/mem-reservation.h @@ -0,0 +1,64 @@ +/* SPDX-L

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: One more thing: please add a comment here saying that frames array is array of PFNs (in Xen granularity), which is what XENMEM_populate_physmap requires. And remove (or update to name the actual call you are making) the corresponding c

Re: [Xen-devel] [PATCH v3 4/9] xen/grant-table: Allow allocating buffers suitable for DMA

2018-06-12 Thread Boris Ostrovsky
. Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Boris Ostrovsky with a small nit below --- drivers/xen/Kconfig | 13 ++ drivers/xen/grant-table.c | 97 +++ include/xen/grant_table.h | 18 3 files changed, 128 insertions

Re: [Xen-devel] [PATCH v3 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-12 Thread Boris Ostrovsky
ng the device with dummy DMA ops. +* Fix this call of_dma_configure() with a NULL node to set "Fix this by calling ..." I think. +* default DMA ops. + */ + of_dma_configure(priv->dma_dev, NULL); +#endif pr_debug("priv %p\n", priv); return 0;

Re: [Xen-devel] [PATCH v3 6/9] xen/gntdev: Make private routines/structures accessible

2018-06-12 Thread Boris Ostrovsky
+}; With that fixed, Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v3 7/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index a09db23e9663..e82660d81d7e 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -48,6 +48,9 @@ #include #include "gntdev-common.h" +#ifdef CONFIG_XEN_GNTDEV

Re: [Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko 1. Create a dma-buf from grant references provided by the foreign domain. By default dma-buf is backed by system memory pages, but by providing GNTDEV_DMA_FLAG_XXX flags it can also be created as

Re: [Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-12 Thread Boris Ostrovsky
On 06/12/2018 09:42 AM, Oleksandr Andrushchenko wrote: int gntdev_dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 fd) { - return -EINVAL; + struct gntdev_dmabuf *gntdev_dmabuf; + struct dma_buf_attachment *attach; + struct dma_buf *dma_buf; + + gntdev_

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644

Re: [Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 05:04 AM, Oleksandr Andrushchenko wrote: > On 06/13/2018 06:14 AM, Boris Ostrovsky wrote: >> >> >> On 06/12/2018 09:42 AM, Oleksandr Andrushchenko wrote: >> >>>   int gntdev_dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 >

Re: [Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 07:57 AM, Oleksandr Andrushchenko wrote: > On 06/13/2018 05:58 AM, Boris Ostrovsky wrote: >> >> >> On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: >>> >>> + >>> +static struct gntdev_dmabuf * >>> +dmabuf_exp_w

Re: [Xen-devel] [PATCH v3 0/9] xen: dma-buf support for grant device

2018-06-14 Thread Boris Ostrovsky
On 06/14/2018 02:47 AM, Oleksandr Andrushchenko wrote: > Hi, Boris! > > It seems that I have resolved all the issues now which > were mainly cleanup and code movement and 5 of 9 patches > already have r-b's. Do you, as the primary reviewer of the > series, think I can push (hopefully) the final ver

Re: [Xen-devel] [PATCH v2] scsi: xen-scsifront: add error handling for xenbus_printf

2018-06-14 Thread Boris Ostrovsky
On 06/14/2018 12:08 PM, Zhouyang Jia wrote: > When xenbus_printf fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling xenbus_printf. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix dereferencing before checking > --- >

Re: [Xen-devel] [PATCH] xen: add error handling for xenbus_printf

2018-06-14 Thread Boris Ostrovsky
On 06/11/2018 11:44 PM, Zhouyang Jia wrote: > When xenbus_printf fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling xenbus_printf. > > Signed-off-by: Zhouyang Jia > --- > drivers/xen/manage.c | 17 ++--- > 1 fil

Re: [Xen-devel] [PATCH v2] xen: add error handling for xenbus_printf

2018-06-15 Thread Boris Ostrovsky
On 06/14/2018 07:34 PM, Zhouyang Jia wrote: > When xenbus_printf fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling xenbus_printf. > > Signed-off-by: Zhouyang Jia Reviewed-by: Boris Ostrovsky (I wasn&#

Re: [Xen-devel] [PATCH] xen: add new hypercall buffer mapping device

2018-06-15 Thread Boris Ostrovsky
On 06/15/2018 09:17 AM, Juergen Gross wrote: > +static int privcmd_buf_mmap(struct file *file, struct vm_area_struct *vma) > +{ > + struct privcmd_buf_private *file_priv = file->private_data; > + struct privcmd_buf_vma_private *vma_priv; > + unsigned int count = vma_pages(vma); > +

Re: [Xen-devel] [PATCH v4 3/9] xen/balloon: Share common memory reservation routines

2018-06-15 Thread Boris Ostrovsky
oding. > Create a dedicated file for the shared code and export corresponding > symbols for other kernel modules. > > Signed-off-by: Oleksandr Andrushchenko > Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-de

Re: [Xen-devel] [PATCH v4 7/9] xen/gntdev: Add initial support for dma-buf UAPI

2018-06-15 Thread Boris Ostrovsky
pport. > > Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-15 Thread Boris Ostrovsky
e treated as >error. > > 3. Make gntdev's common code and structures available to dma-buf. > > Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v4 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-15 Thread Boris Ostrovsky
all references to an imported buffer, so it can be >released by the owner. This is only valid for buffers created with >IOCTL_GNTDEV_DMABUF_IMP_TO_REFS. > > Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Boris Ostrovsky ___

Re: [Xen-devel] [PATCH v4 5/9] xen/gntdev: Allow mappings for DMA buffers

2018-06-15 Thread Boris Ostrovsky
On 06/15/2018 02:50 AM, Oleksandr Andrushchenko wrote: > On 06/15/2018 09:46 AM, Juergen Gross wrote: >> On 15/06/18 08:32, Oleksandr Andrushchenko wrote: >>> Please note, that this will need a change (attached) while >>> applying to the mainline kernel because of API changes [1]. >>> >>> Unfortuna

Re: [Xen-devel] [PATCH v2] xen: add new hypercall buffer mapping device

2018-06-18 Thread Boris Ostrovsky
kernel and just mapped into user space. Marked as > VM_IO the user mapping will not be subject to page migration et al. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject

Re: [Xen-devel] Dom0 Failing to Boot with Recent Linux Kernels (Spectre Mitigations)

2018-06-19 Thread Boris Ostrovsky
On 06/19/2018 05:30 PM, Brian Woods wrote: I'm currently seeing an issue where when booting from a recent Linux kernel without nospec_store_bypass_disable. There's a NULL pointer having to do with a lock. I put some printks in and it seems that in arch/x86/kernel/process.c that speculative_st

Re: [Xen-devel] Dom0 Failing to Boot with Recent Linux Kernels (Spectre Mitigations)

2018-06-20 Thread Boris Ostrovsky
On 06/20/2018 02:17 AM, Juergen Gross wrote: > On 20/06/18 05:31, Boris Ostrovsky wrote: >> >> On 06/19/2018 05:30 PM, Brian Woods wrote: >>> I'm currently seeing an issue where when booting from a recent Linux >>> kernel without nospec_store_bypass_disable.

Re: [Xen-devel] Dom0 Failing to Boot with Recent Linux Kernels (Spectre Mitigations)

2018-06-20 Thread Boris Ostrovsky
On 06/20/2018 10:27 AM, Boris Ostrovsky wrote: > On 06/20/2018 02:17 AM, Juergen Gross wrote: >> On 20/06/18 05:31, Boris Ostrovsky wrote: >>> On 06/19/2018 05:30 PM, Brian Woods wrote: >>>> I'm currently seeing an issue where when booting from

Re: [Xen-devel] [PATCH] x86/xen: add call of speculative_store_bypass_ht_init() to pv paths

2018-06-21 Thread Boris Ostrovsky
to be called on each cpu for > pv guests, too. > > Reported-by: Brian Woods > Fixes: 1f50ddb4f4189243c05926b842dc1a0332195f31 ("x86/speculation: Handle HT > correctly on AMD") > Cc: > Signed-off-by: Juergen Gross >

[Xen-devel] [PATCH] xen: Remove unnecessary BUG_ON from __unbind_from_irq()

2018-06-21 Thread Boris Ostrovsky
is really no reason for the BUG_ON (xen_free_irq() can operate on unbound irqs) we can remove it. Reported-by: Ben Hutchings Signed-off-by: Boris Ostrovsky Cc: sta...@vger.kernel.org --- drivers/xen/events/events_base.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/xen/events/eve

Re: [Xen-devel] [PATCH 06/10] x86/paravirt: introduce new config option PARAVIRT_XXL

2018-08-10 Thread Boris Ostrovsky
On 08/10/2018 07:52 AM, Juergen Gross wrote: > A large amount of paravirt ops is used by Xen PV guests only. Add a new > config option PARAVIRT_XXL which is selected by XEN_PV. Later we can > put the Xen PV only paravirt ops under the PARACVIRT_XXL umbrella. What does "XXL" stand for? My immediate

Re: [Xen-devel] [PATCH v3 13/17] x86/xen: enable Hygon support to Xen

2018-08-11 Thread Boris Ostrovsky
On 08/11/2018 09:29 AM, Pu Wen wrote: > To make Xen work correctly on Hygon platforms, reuse AMD's Xen support > code path and add vendor check for Hygon along with AMD. > > Signed-off-by: Pu Wen > --- > arch/x86/xen/pmu.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) >

Re: [Xen-devel] [PATCH v3 13/17] x86/xen: enable Hygon support to Xen

2018-08-12 Thread Boris Ostrovsky
On 08/12/2018 04:55 AM, Juergen Gross wrote: > On 11/08/18 16:34, Boris Ostrovsky wrote: >> On 08/11/2018 09:29 AM, Pu Wen wrote: >> >>> >>> bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err) >>> { >>> - if (boot_

Re: [Xen-devel] [PATCH] x86/Xen: mark xen_setup_gdt() __init

2018-08-15 Thread Boris Ostrovsky
On 07/02/2018 09:54 AM, Juergen Gross wrote: > On 25/06/18 12:34, Jan Beulich wrote: >> Its only caller is __init, so to avoid section mismatch warnings when a >> compiler decides to not inline the function marke this function so as >> well. Take the opportunity and also make the function actually

Re: [Xen-devel] [PATCH RESEND] xen/mcelog: eliminate redundant setting of interface version

2018-08-15 Thread Boris Ostrovsky
On 07/02/2018 09:52 AM, Juergen Gross wrote: > On 25/06/18 12:19, Jan Beulich wrote: >> This already gets done in HYPERVISOR_mca(). >> >> Signed-off-by: Jan Beulich > Reviewed-by: Juergen Gross > Applied to for-linus-4.19. -boris ___ Xen-devel maili

Re: [Xen-devel] [PATCH] x86/Xen: further refine add_preferred_console() invocations

2018-08-15 Thread Boris Ostrovsky
On 07/02/2018 10:38 AM, Juergen Gross wrote: > On 25/06/18 12:45, Jan Beulich wrote: >> As the sequence of invocations matters, add "tty" only after "hvc" when >> a VGA console is available (which is often the case for Dom0, but hardly >> ever for DomU). >> >> Signed-off-by: Jan Beulich > Reviewed

Re: [Xen-devel] Ping: [PATCH] xen/ACPI: don't upload Px/Cx data for disabled processors

2018-08-15 Thread Boris Ostrovsky
On 08/15/2018 03:55 AM, Rafael J. Wysocki wrote: > On Wed, Aug 15, 2018 at 8:44 AM Jan Beulich wrote: > On 25.06.18 at 12:17, wrote: >>> This is unnecessary and triggers a warning in the hypervisor. >>> >>> Often systems have more processor entries in their ACPI tables than are >>> actually i

Re: [Xen-devel] [PATCH v3 13/17] x86/xen: enable Hygon support to Xen

2018-08-16 Thread Boris Ostrovsky
On 08/16/2018 09:29 AM, Pu Wen wrote: > On 2018/8/12 21:26, Boris Ostrovsky wrote: >> On 08/12/2018 04:55 AM, Juergen Gross wrote: >>> On 11/08/18 16:34, Boris Ostrovsky wrote: >>>> On 08/11/2018 09:29 AM, Pu Wen wrote: >>>>>   bool pmu_msr_r

Re: [Xen-devel] linux-next: manual merge of the akpm-current tree with the xen-tip tree

2018-08-17 Thread Boris Ostrovsky
On 08/15/2018 08:05 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 30 Jul 2018 19:02:10 +1000 Stephen Rothwell > wrote: >> Today's linux-next merge of the akpm-current tree got a conflict in: >> >> drivers/xen/gntdev.c >> >> between commit: >> >> 1d3145675538 ("xen/gntdev: Make private rou

Re: [Xen-devel] [PATCH RESEND] x86/xen: enable early use of set_fixmap in 32-bit Xen PV guest

2018-08-20 Thread Boris Ostrovsky
On 08/20/2018 11:24 AM, Juergen Gross wrote: > Commit 7b25b9cb0dad83 ("x86/xen/time: Initialize pv xen time in > init_hypervisor_platform()") moved the mapping of the shared info area > before pagetable_init(). This breaks booting as 32-bit PV guest as the > use of set_fixmap isn't possible at this

Re: [Xen-devel] [PATCH] xen: remove unused hypercall functions

2018-08-20 Thread Boris Ostrovsky
On 08/20/2018 09:03 AM, Juergen Gross wrote: > Remove Xen hypercall functions which are used nowhere in the kernel. > > Signed-off-by: Juergen Gross > --- Applied to for-linus-19b. -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org http

Re: [Xen-devel] [PATCH] x86/xen: remove unused function xen_auto_xlated_memory_setup()

2018-08-20 Thread Boris Ostrovsky
On 08/20/2018 09:02 AM, Juergen Gross wrote: > xen_auto_xlated_memory_setup() is a leftover from PVH V1. Remove it. > > Signed-off-by: Juergen Gross > Applied to for-linus-19b. -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://

Re: [Xen-devel] [PATCH RESEND] x86/xen: enable early use of set_fixmap in 32-bit Xen PV guest

2018-08-20 Thread Boris Ostrovsky
On 08/20/2018 11:24 AM, Juergen Gross wrote: > Commit 7b25b9cb0dad83 ("x86/xen/time: Initialize pv xen time in > init_hypervisor_platform()") moved the mapping of the shared info area > before pagetable_init(). This breaks booting as 32-bit PV guest as the > use of set_fixmap isn't possible at this

Re: [Xen-devel] [PATCH v4 12/16] x86/xen: enable Hygon support to Xen

2018-08-20 Thread Boris Ostrovsky
PMC MSRs, > they are alias of the counters(0-3). > > In this version of kernel Hygon use the lagacy and safe versions of MSR > access. It works fine when VPMU enabled in Xen on Hygon platforms by > testing with perf. > > Signed-off-

Re: [Xen-devel] [PATCH] x86/svm: Fixes to OS Visible Workaround handling

2018-08-21 Thread Boris Ostrovsky
tched values. The guests view of > osvw_length also needs clipping at 64 as we only offer one status register (To > date, 5 is the maximum index defined AFAICT). Avoid opencoding max(). Reviewed-by: Boris Ostrovsky We should probably emit a warning when MSR_AMD_OSVW_ID_LENGTH reports mor

Re: [Xen-devel] [PATCH] xen/gntdev: fix up blockable calls to mn_invl_range_start

2018-08-23 Thread Boris Ostrovsky
s well. > > Once we are there we can remove the stale TODO. The lock has to be > sleepable because we wait for completion down in gnttab_unmap_refs_sync. > > Fixes: 93065ac753e4 ("mm, oom: distinguish blockable mode for mmu notifiers") > Cc: Boris Ostrovsky > Cc: J

Re: [Xen-devel] [PATCH] xen/gntdev: fix up blockable calls to mn_invl_range_start

2018-08-23 Thread Boris Ostrovsky
On 08/23/2018 09:51 AM, Michal Hocko wrote: > On Thu 23-08-18 22:44:07, Tetsuo Handa wrote: >> On 2018/08/23 21:07, Michal Hocko wrote: >>> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c >>> index 57390c7666e5..e7d8bb1bee2a 100644 >>> --- a/drivers/xen/gntdev.c >>> +++ b/drivers/xen/gntde

Re: [Xen-devel] [PATCH] xen-netfront: wait xenbus state change when load module manually

2018-08-24 Thread Boris Ostrovsky
On 08/24/2018 07:26 AM, Juergen Gross wrote: > On 24/08/18 13:12, Jiri Slaby wrote: >> On 07/30/2018, 10:18 AM, Xiao Liang wrote: >>> On 07/29/2018 11:30 PM, David Miller wrote: From: Xiao Liang Date: Fri, 27 Jul 2018 17:56:08 +0800 > @@ -1330,6 +1331,11 @@ static struct net_dev

Re: [Xen-devel] [PATCH v2 01/23] x86: change name of parameter for various invlpg functions

2018-08-27 Thread Boris Ostrovsky
On 08/26/2018 08:19 AM, Wei Liu wrote: > They all incorrectly named a parameter virtual address while it should > have been linear address. > > Requested-by: Andrew Cooper AMD SDM doesn't make distinction between linear and virtual addresses so I wonder why this was requested. -boris

Re: [Xen-devel] [PATCH v2 0/2] x86/xen: avoid 32-bit writes to PTEs in PV PAE guests

2018-08-27 Thread Boris Ostrovsky
On 08/21/2018 11:37 AM, Juergen Gross wrote: > While the hypervisor emulates plain writes to PTEs happily, this is > much slower than issuing a hypercall for PTE modifcations. And writing > a PTE via two 32-bit write instructions (especially when clearing the > PTE) will result in an intermediate L

Re: [Xen-devel] [PATCH V2] xen: export device state to sysfs

2018-08-28 Thread Boris Ostrovsky
On 08/28/2018 10:56 AM, Joe Jin wrote: > Export device state to sysfs to allow for easier get device state. > > Signed-off-by: Joe Jin > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: Konrad Rzeszutek Wilk > --- > Documentation/ABI/stable/sysfs-bus-xen-backend | 9

Re: [Xen-devel] [PATCH V2] xen: export device state to sysfs

2018-08-28 Thread Boris Ostrovsky
On 08/28/2018 01:14 PM, Joe Jin wrote: > On 8/28/18 9:53 AM, Boris Ostrovsky wrote: >> On 08/28/2018 10:56 AM, Joe Jin wrote: >>> Export device state to sysfs to allow for easier get device state. >>> >>> Signed-off-by: Joe Jin >>> Cc: Boris Ost

Re: [Xen-devel] [PATCH] x86/xen: remove redundant variable save_pud

2018-08-28 Thread Boris Ostrovsky
On 08/28/2018 12:10 PM, Colin King wrote: > From: Colin Ian King > > Variable save_pud is being assigned but is never used hence it is > redundant and can be removed. > > Cleans up clang warning: > variable 'save_pud' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King

Re: [Xen-devel] [PATCH v2] SVM: limit GIF=0 region

2018-08-28 Thread Boris Ostrovsky
for the duration of time being in guest context. > However, SPEC_CTRL_ENTRY_FROM_HVM wants to be carried out with EFLAGS.IF > clear. > > Suggested-by: Andrew Cooper > Signed-off-by: Jan Beulich Reviewed-by: Boris Ostrovsky _

Re: [Xen-devel] Problems booting 32-bit PV; just me or more widespread?

2018-08-30 Thread Boris Ostrovsky
On 08/29/2018 08:51 PM, Andy Smith wrote: > Hi, > > I'm sorry this is a long email, but I wanted to explain everything > that I have tried, because it seems like quite a few different > versions of 32-bit upstream Linux kernel no longer boot as PV guest > and I'm surprised I am the first to encount

Re: [Xen-devel] [PATCH 7/7] x86/hvm: Drop hvm_{vmx,svm} shorthands

2018-08-30 Thread Boris Ostrovsky
s structs/unions. I don't know whether we have any for vmx/svm, but I thought I'd mention this just in case. Other than that, for SVM bits in patches 3,4,6 and 7 Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xen

Re: [Xen-devel] [PATCH 7/7] x86/hvm: Drop hvm_{vmx,svm} shorthands

2018-08-30 Thread Boris Ostrovsky
On 08/30/2018 07:11 PM, Boris Ostrovsky wrote: > On 08/28/2018 01:39 PM, Andrew Cooper wrote: >> By making {vmx,svm} in hvm_vcpu into an anonymous union (consistent with >> domain side of things), the hvm_{vmx,svm} defines can be dropped, and all >> code >> refer to

Re: [Xen-devel] [PATCH v2 01/23] x86: change name of parameter for various invlpg functions

2018-09-04 Thread Boris Ostrovsky
1. in volume 2). However, if others think linear is a better term to use, that's fine too. Acked-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] Problems booting 32-bit PV; just me or more widespread?

2018-09-04 Thread Boris Ostrovsky
On 09/02/2018 08:32 PM, Andy Smith wrote: > > This one should work though as it's their netboot installer: > > > http://archive.ubuntu.com/ubuntu/dists/bionic/main/installer-i386/current/images/netboot/xen/ > > When I do xl create with this one (direct kernel boot), I get this > crash in the x

Re: [Xen-devel] [PATCH v2] xen: avoid crash in disable_hotplug_cpu

2018-09-06 Thread Boris Ostrovsky
On 09/06/2018 02:37 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga946

Re: [Xen-devel] [PATCH] xen/manage: don't complain about an empty value in control/sysrq node

2018-09-06 Thread Boris Ostrovsky
On 09/06/2018 07:26 AM, Vitaly Kuznetsov wrote: > When guest receives a sysrq request from the host it acknowledges it by > writing '\0' to control/sysrq xenstore node. This, however, make xenstore > watch fire again but xenbus_scanf() fails to parse empty value with "%c" > format string: > > sysr

Re: [Xen-devel] [PATCH] xen/balloon: add runtime control for scrubbing ballooned out pages

2018-09-06 Thread Boris Ostrovsky
On 09/06/2018 11:33 AM, Marek Marczykowski-Górecki wrote: > Scrubbing pages on initial balloon down can take some time, especially > in nested virtualization case (nested EPT is slow). When HVM/PVH guest is > started with memory= significantly lower than maxmem=, all the extra > pages will be scrub

Re: [Xen-devel] [PATCH v2] xen: avoid crash in disable_hotplug_cpu

2018-09-06 Thread Boris Ostrovsky
On 09/06/2018 04:31 PM, Olaf Hering wrote: > Am Thu, 6 Sep 2018 14:45:57 -0400 > schrieb Boris Ostrovsky : > >> On 09/06/2018 02:37 AM, Olaf Hering wrote: >>> The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: >>> This happens because handle

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Boris Ostrovsky
On 09/07/2018 02:30 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga946

Re: [Xen-devel] [PATCH] xen/netfront: fix waiting for xenbus state change

2018-09-07 Thread Boris Ostrovsky
when netback_changed() is called. > > Fixes: 822fb18a82aba ("xen-netfront: wait xenbus state change when load > module manually") > Cc: #4.18 > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky ___ Xen-devel mail

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-07 Thread Boris Ostrovsky
On 09/07/2018 10:31 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga946

Re: [Xen-devel] [PATCH v2] x86: use VMLOAD for PV context switch

2018-09-10 Thread Boris Ostrovsky
On 09/10/2018 10:03 AM, Jan Beulich wrote: > Having noticed that VMLOAD alone is about as fast as a single of the > involved WRMSRs, I thought it might be a reasonable idea to also use it > for PV. Measurements, however, have shown that an actual improvement can > be achieved only with an early pre

Re: [Xen-devel] [PATCH] SVM: limit GIF=0 region

2018-09-10 Thread Boris Ostrovsky
for the duration of time being in guest context. > However, SPEC_CTRL_ENTRY_FROM_HVM wants to be carried out with EFLAGS.IF > clear. > > Note regarding the main STGI placement: It could be moved further up, > but at present SPEC_CTRL_EXIT_TO_HVM is not NMI/#MC-safe. > > Suggested-

Re: [Xen-devel] [PATCH v2] x86: use VMLOAD for PV context switch

2018-09-11 Thread Boris Ostrovsky
On 9/11/18 3:54 AM, Jan Beulich wrote: On 10.09.18 at 23:56, wrote: >> On 09/10/2018 10:03 AM, Jan Beulich wrote: >>> Having noticed that VMLOAD alone is about as fast as a single of the >>> involved WRMSRs, I thought it might be a reasonable idea to also use it >>> for PV. Measurements, howe

Re: [Xen-devel] [PATCH v3] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Boris Ostrovsky
On 9/11/18 7:25 AM, Juergen Gross wrote: > > Reviewed-by: Juergen Gross So is it v3 or v4, you gave R-b for both. (I slightly prefer v3, but either is fine). -boris ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org

Re: [Xen-devel] [PATCH v2] x86: use VMLOAD for PV context switch

2018-09-11 Thread Boris Ostrovsky
On 9/11/18 10:38 AM, Jan Beulich wrote: On 11.09.18 at 16:17, wrote: >> On 9/11/18 3:54 AM, Jan Beulich wrote: >> On 10.09.18 at 23:56, wrote: On 09/10/2018 10:03 AM, Jan Beulich wrote: > Having noticed that VMLOAD alone is about as fast as a single of the > involved WRMSRs,

Re: [Xen-devel] [PATCH v3] xen/balloon: add runtime control for scrubbing ballooned out pages

2018-09-11 Thread Boris Ostrovsky
On 9/7/18 12:49 PM, Marek Marczykowski-Górecki wrote: > Scrubbing pages on initial balloon down can take some time, especially > in nested virtualization case (nested EPT is slow). When HVM/PVH guest is > started with memory= significantly lower than maxmem=, all the extra > pages will be scrubbed

Re: [Xen-devel] [PATCH v4] xen: avoid crash in disable_hotplug_cpu

2018-09-11 Thread Boris Ostrovsky
On 9/7/18 10:31 AM, Olaf Hering wrote: > The command 'xl vcpu-set 0 0', issued in dom0, will crash dom0: > > BUG: unable to handle kernel NULL pointer dereference at 02d8 > PGD 0 P4D 0 > Oops: [#1] PREEMPT SMP NOPTI > CPU: 7 PID: 65 Comm: xenwatch Not tainted 4.19.0-rc2-1.ga9462db-

[Xen-devel] [PATCH] x86/EISA: Don't probe EISA bus for Xen PV guests

2018-09-11 Thread Boris Ostrovsky
For unprivileged Xen PV guests this is normal memory and ioremap will not be able to properly map it. While at it, since ioremap may return NULL, add a test for pointer's validity. Reported-by: Andy Smith Signed-off-by: Boris Ostrovsky --- arch/x86/kernel/eisa.c | 10 -- 1

Re: [Xen-devel] [PATCH] x86/EISA: Don't probe EISA bus for Xen PV guests

2018-09-11 Thread Boris Ostrovsky
On 9/11/18 4:20 PM, Thomas Gleixner wrote: > On Tue, 11 Sep 2018, Boris Ostrovsky wrote: > >> For unprivileged Xen PV guests this is normal memory and ioremap will >> not be able to properly map it. >> >> While at it, since ioremap may return NULL, add a test for poi

[Xen-devel] [PATCH RESEND] tpm: Restore functionality to xen vtpm driver.

2018-09-13 Thread Boris Ostrovsky
the release in which multi-page xenbus support was introduced. Daniel De Graaf formulated the fix by code inspection after the regression point was located. Signed-off-by: Dr. Greg Wettstein [boris: fixed commit message formatting] Signed-off-by: Boris Ostrovsky Cc: sta...@vger.kernel.org # v

[Xen-devel] [PATCH v2] tpm: Restore functionality to xen vtpm driver.

2018-09-13 Thread Boris Ostrovsky
xed commit message formatting, added Fixes tag] Signed-off-by: Boris Ostrovsky Cc: sta...@vger.kernel.org # v4.1+ --- drivers/char/tpm/xen-tpmfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront.c index 911475d368

Re: [Xen-devel] [PATCH] xen: fix GCC warning and remove duplicate EVTCHN_ROW/EVTCHN_COL usage

2018-09-13 Thread Boris Ostrovsky
On 9/13/18 1:13 AM, Juergen Gross wrote: > On 13/09/18 03:13, Josh Abraham wrote: >> This patch removes duplicate macro useage in events_base.c. >> >> It also fixes gcc warning: >> variable ‘col’ set but not used [-Wunused-but-set-variable] >> >> Signed-off-by: Joshua Abraham > Reviewed-by: Juerge

Re: [Xen-devel] [PATCH 1/6] xenbus: prepare data structures and parameter for xenwatch multithreading

2018-09-16 Thread Boris Ostrovsky
On 9/14/18 3:34 AM, Dongli Zhang wrote: + +struct mtwatch_info { + /* +* The mtwatch_domain is put on both a hash table and a list. +* domain_list is used to optimize xenbus_watch un-registration. +* +* The mtwatch_domain is removed from domain_hash (with

Re: [Xen-devel] [PATCH 2/6] xenbus: implement the xenwatch multithreading framework

2018-09-16 Thread Boris Ostrovsky
On 9/14/18 3:34 AM, Dongli Zhang wrote: + +/* Running in the context of default xenwatch kthread. */ +void mtwatch_create_domain(domid_t domid) +{ + struct mtwatch_domain *domain; + + if (!domid) { + pr_err("Default xenwatch thread is for dom0\n"); + ret

Re: [Xen-devel] [PATCH v2] tpm: Restore functionality to xen vtpm driver.

2018-09-17 Thread Boris Ostrovsky
On 9/16/18 3:25 PM, Jarkko Sakkinen wrote: > On Thu, Sep 13, 2018 at 05:25:51PM -0400, Boris Ostrovsky wrote: >> From: "Dr. Greg Wettstein" >> >> Functionality of the xen-tpmfront driver was lost secondary to >> the introduction of xenbus mult

Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute

2018-09-17 Thread Boris Ostrovsky
On 9/16/18 7:43 AM, Pasi Kärkkäinen wrote: > Hi, > > On Mon, Dec 18, 2017 at 12:32:11PM -0500, Boris Ostrovsky wrote: >> On 12/18/2017 02:36 AM, Jan Beulich wrote: >>>>>> On 15.12.17 at 20:52, wrote: >>>>>>> +static int pcistub_device_reset(

Re: [Xen-devel] [PATCH 1/6] xenbus: prepare data structures and parameter for xenwatch multithreading

2018-09-17 Thread Boris Ostrovsky
On 9/16/18 9:20 PM, Dongli Zhang wrote: > Hi Boris, > > On 09/17/2018 04:17 AM, Boris Ostrovsky wrote: >> >> On 9/14/18 3:34 AM, Dongli Zhang wrote: >> >>> + >>> +struct mtwatch_info { >>> +/* >>> + * The mtwatch_domain is

Re: [Xen-devel] [PATCH 2/6] xenbus: implement the xenwatch multithreading framework

2018-09-17 Thread Boris Ostrovsky
On 9/16/18 9:48 PM, Dongli Zhang wrote: > Hi Boris, > > On 09/17/2018 05:20 AM, Boris Ostrovsky wrote: >> >> On 9/14/18 3:34 AM, Dongli Zhang wrote: >>> + >>> +/* Running in the context of default xenwatch kthread. */ >>> +void mtwatch_cre

Re: [Xen-devel] [PATCH 3/6] xenbus: dispatch per-domU watch event to per-domU xenwatch thread

2018-09-17 Thread Boris Ostrovsky
On 9/14/18 3:34 AM, Dongli Zhang wrote: > > +static int xs_watch_insert_event(struct xs_watch_event *event, domid_t domid) > +{ > + struct mtwatch_domain *domain; > + int ret = -1; -ENODEV maybe? -boris > + > + rcu_read_lock(); > + > + domain = mtwatch_find_domain(domid); > +

Re: [Xen-devel] [PATCH v2] tpm: Restore functionality to xen vtpm driver.

2018-09-17 Thread Boris Ostrovsky
On 9/17/18 5:19 PM, Jarkko Sakkinen wrote: > On Mon, Sep 17, 2018 at 09:54:37AM -0400, Boris Ostrovsky wrote: >> On 9/16/18 3:25 PM, Jarkko Sakkinen wrote: >>> On Thu, Sep 13, 2018 at 05:25:51PM -0400, Boris Ostrovsky wrote: >>>> From: "Dr. Greg Wettstein&q

[Xen-devel] [PATCH v3] tpm: Restore functionality to xen vtpm driver.

2018-09-17 Thread Boris Ostrovsky
Wettstein [boris: Updated commit message, added Fixes tag] Signed-off-by: Boris Ostrovsky Cc: sta...@vger.kernel.org # v4.1+ --- drivers/char/tpm/xen-tpmfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/xen-tpmfront.c b/drivers/char/tpm/xen-tpmfront

Re: [Xen-devel] [PATCH v3] x86: use VMLOAD for PV context switch

2018-09-18 Thread Boris Ostrovsky
tween > measuring immediately around the calls to svm_load_segs() and measuring > immediately inside the function. Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen: issue warning message when out of grant maptrack entries

2018-09-18 Thread Boris Ostrovsky
On 9/18/18 5:32 AM, Juergen Gross wrote: > When a driver domain (e.g. dom0) is running out of maptrack entries it > can't map any more foreign domain pages. Instead of silently stalling > the affected domUs issue a rate limited warning in this case in order > to make it easier to detect that situat

Re: [Xen-devel] [PATCH] xen: issue warning message when out of grant maptrack entries

2018-09-18 Thread Boris Ostrovsky
On 9/18/18 1:17 PM, Juergen Gross wrote: > > The loop is running until the end, so i == count for the call of kmap_ops(). OK, so I can't read code. Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenprojec

Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute

2018-09-18 Thread Boris Ostrovsky
On 9/18/18 5:32 AM, George Dunlap wrote: > >> On Sep 18, 2018, at 8:15 AM, Pasi Kärkkäinen wrote: >> >> Hi, >> >> On Mon, Sep 17, 2018 at 02:06:02PM -0400, Boris Ostrovsky wrote: >>> What about the toolstack changes? Have they been accepted? I vaguely >

Re: [Xen-devel] [PATCH] xen: issue warning message when out of grant maptrack entries

2018-09-19 Thread Boris Ostrovsky
On 9/18/18 1:17 PM, Juergen Gross wrote: > On 18/09/18 19:03, Boris Ostrovsky wrote: >> On 9/18/18 5:32 AM, Juergen Gross wrote: >>> When a driver domain (e.g. dom0) is running out of maptrack entries it >>> can't map any more foreign domain pages. Instead of si

Re: [Xen-devel] [PATCH v2] xen: issue warning message when out of grant maptrack entries

2018-09-19 Thread Boris Ostrovsky
er to detect that situation. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH] xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code

2018-09-20 Thread Boris Ostrovsky
On 7/13/18 4:41 AM, Juergen Gross wrote: > On 12/07/18 19:27, Boris Ostrovsky wrote: >> Otherwise we may leak kernel stack for events that sample user >> registers. >> >> Reported-by: Mark Rutland >> Signed-off-by: Boris Ostrovsky >> Cc: sta...@vger.

<    1   2   3   4   5   6   7   8   9   10   >