block types. Turns out abstracting too much was
> rather confusing and not helpful. Properly document them.
>
>Notes:
>- I wanted to convert the enum of types into a named enum but this
> provoked all kinds of different errors. For now, I am d
:
>+ * The type of memory block was not further specified when adding the
>+ * memory block.
>+ *
>+ * MEMORY_BLOCK_BOOT:
>+ * This memory block was added during boot by the basic system. No
>+ * specific device driver takes care of this memory block. This memory
>+ * block type is onlined automatically by the kernel during boot and might
>+ * later be managed by a different device driver, in which case the type
>+ * might change.
>+ */
>+enum {
>+ MEMORY_BLOCK_NONE = 0,
>+ MEMORY_BLOCK_UNSPECIFIED,
>+ MEMORY_BLOCK_BOOT,
>+};
>+
> /* These states are exposed to userspace as text strings in sysfs */
> #define MEM_ONLINE (1<<0) /* exposed to userspace */
> #define MEM_GOING_OFFLINE (1<<1) /* exposed to userspace */
>--
>2.17.2
--
Wei Yang
Help you, Help me
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
t;Cc: Michal Hocko
>Cc: Dan Williams
>Cc: "Kirill A. Shutemov"
>Cc: Oscar Salvador
>Cc: Nicholas Piggin
>Cc: Stephen Rothwell
>Cc: Christophe Leroy
>Cc: "Jonathan Neusch??fer"
>Cc: Mauricio Faria de Oliveira
>Cc: Vasily Gorbik
>Cc: Arun KS
e to keep it in here.
>
Yes, this make sense to me now.
>(and I think at least for now it makes sense to not squash patch 1 and
>2, to easier discuss the new user interface/concept introduced in this
>patch).
>
>Thanks!
>
>--
>
>Thanks,
>
>David / dhildenb
On Thu, Oct 11, 2018 at 6:05 PM Vlastimil Babka wrote:
>
> On 10/10/18 6:56 PM, Arun KS wrote:
> > On 2018-10-10 21:00, Vlastimil Babka wrote:
> >> On 10/5/18 10:10 AM, Arun KS wrote:
> >>> When free pages are done with higher order, time spend on
> >>> coalescing pages by buddy allocator can be r
for
hotpluged memory? So we make them all in IORESOURCE_SYSRAM_XXX family?
>
>Cc: Andrew Morton
>Cc: Michal Hocko
>Cc: Dan Williams
>Cc: Jason Gunthorpe
>Cc: Kees Cook
>Cc: Ard Biesheuvel
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Cc: Wei Yang
>Cc: Eric Biederman
>Cc:
es Cook
>Cc: Ard Biesheuvel
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Cc: Wei Yang
>Signed-off-by: David Hildenbrand
>---
> include/linux/ioport.h | 4 ++--
> kernel/resource.c | 49 --
> mm/memory_hotplug.c| 22 +-
es Cook
>Cc: Ard Biesheuvel
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Cc: Wei Yang
>Signed-off-by: David Hildenbrand
>---
> include/linux/ioport.h | 4 ++--
> kernel/resource.c | 49 --
> mm/memory_hotplug.c| 22 +-
Srinivasan"
>Cc: Haiyang Zhang
>Cc: Stephen Hemminger
>Cc: Wei Liu
>Cc: Boris Ostrovsky
>Cc: Juergen Gross
>Cc: Stefano Stabellini
>Cc: Roger Pau Monné
>Cc: Julien Grall
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Cc: Wei Yang
>Signed-off-by:
was done for
>
>#define devm_release_mem_region(dev, start, n) \
> __devm_release_region(dev, &iomem_resource, (start), (n))
>
What I prefer is remove iomem_resource from the parameter list. Just use is in
the function body.
For the example you listed, __release_region() would
On Tue, Sep 15, 2020 at 11:15:53AM +0200, David Hildenbrand wrote:
>On 15.09.20 11:06, Wei Yang wrote:
>> On Tue, Sep 15, 2020 at 09:35:30AM +0200, David Hildenbrand wrote:
>>>
>>>>> static int __ref try_remove_memory(int nid, u64 start, u64 size)
>>>
licable.
>
Looks good to me.
Reviewed-by: Wei Yang
>Suggested-by: Wei Yang
>Cc: Andrew Morton
>Cc: Michal Hocko
>Cc: Dan Williams
>Cc: Jason Gunthorpe
>Cc: Kees Cook
>Cc: Ard Biesheuvel
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Cc: Wei Yang
>Signed-off-by:
On Wed, Sep 16, 2020 at 12:03:20PM +0200, David Hildenbrand wrote:
>On 16.09.20 12:02, Wei Yang wrote:
>> On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hildenbrand wrote:
>>> "mem" in the name already indicates the root, similar to
>>> release_mem_region() a
On Wed, Sep 16, 2020 at 02:16:25PM +0200, David Hildenbrand wrote:
>On 16.09.20 14:10, Wei Yang wrote:
>> On Wed, Sep 16, 2020 at 12:03:20PM +0200, David Hildenbrand wrote:
>>> On 16.09.20 12:02, Wei Yang wrote:
>>>> On Wed, Sep 16, 2020 at 09:30:41AM +0200, David Hil
>Cc: Juergen Gross
>Cc: Stefano Stabellini
>Cc: Roger Pau Monné
>Cc: Julien Grall
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Signed-off-by: David Hildenbrand
Reviewed-by: Wei Yang
>---
> include/linux/ioport.h | 4 +++
> include/linux/memory_hotplug.h
: Andrew Morton
>Cc: Michal Hocko
>Cc: Boris Ostrovsky
>Cc: Juergen Gross
>Cc: Stefano Stabellini
>Cc: Roger Pau Monné
>Cc: Julien Grall
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Signed-off-by: David Hildenbrand
Reviewed-by: Wei Yang
>---
> drivers/xen/
ew Morton
>Cc: Michal Hocko
>Cc: "K. Y. Srinivasan"
>Cc: Haiyang Zhang
>Cc: Stephen Hemminger
>Cc: Wei Liu
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Signed-off-by: David Hildenbrand
Reviewed-by: Wei Yang
>---
> drivers/hv/hv_balloon.c | 2 +-
> 1
Andrew Morton
>Cc: Michal Hocko
>Cc: Dan Williams
>Cc: Michael S. Tsirkin
>Cc: Jason Wang
>Cc: Pankaj Gupta
>Cc: Baoquan He
>Signed-off-by: David Hildenbrand
Reviewed-by: Wei Yang
>---
> drivers/virtio/virtio_mem.c | 3 ++-
> 1 file changed, 2 insertions(+
e type - should
>be good enough for internal purposes.
>
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>Cc: Wei Yang
>Cc: Oscar Salvador
>Cc: Mike Rapoport
>Signed
figurable by the
>instance triggering undo of isolation (e.g., alloc_contig_range(),
>memory onlining, memory offlining).
>
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>Cc: Wei Yang
>Cc: Oscar Sal
he changed page isolation
>behavior (which I doubt), we can always make this configurable by the
>instance triggering undo of isolation (e.g., alloc_contig_range(),
>memory onlining, memory offlining).
>
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
nset_migratetype_isolate() is used in
__offline_pages if my understanding is correct. How does it contribute on
online_pages?
>
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>Cc: Wei Yang
>Cc: Oscar Salvado
gt;So while vmemmap on hotplugged memory would tackle some part of the issue,
>there are cases where this approach is better, and there are even benefits
>when combining both.
While everything changes with shuffle.
>
>Thanks!
>
>David
>
>>
>> I was about to give it a new respin now that thw hwpoison stuff has been
>> settled.
>>
>> [1] https://patchwork.kernel.org/cover/11059175/
>>
--
Wei Yang
Help you, Help me
On Fri, Sep 18, 2020 at 09:27:23AM +0200, David Hildenbrand wrote:
>On 18.09.20 04:07, Wei Yang wrote:
>> On Wed, Sep 16, 2020 at 08:34:09PM +0200, David Hildenbrand wrote:
>>> __putback_isolated_page() already documents that pages will be placed to
>>> the tail of the
>onlining a bunch of blocks as zone_movable first and only later convert to
>zone_normal in a controlled way when existing normal zone becomes depeted?
>
To be honest, David's approach is easy to understand for me.
And I don't see some negative effect.
>I guess it's an issue that the e.g. 128M block onlines are so disconnected from
>each other it's hard to employ a strategy that works best for e.g. a whole
>bunch
>of GB onlined at once. But I noticed some effort towards new API, so maybe that
>will be solved there too?
>
>> Thanks!
>>
>> David
>>
>>>
>>> I was about to give it a new respin now that thw hwpoison stuff has been
>>> settled.
>>>
>>> [1] https://patchwork.kernel.org/cover/11059175/
>>>
>>
--
Wei Yang
Help you, Help me
o
>> be placed to the tail of the freelist.
>>
>> Cc: Andrew Morton
>> Cc: Alexander Duyck
>> Cc: Mel Gorman
>> Cc: Michal Hocko
>> Cc: Dave Hansen
>> Cc: Vlastimil Babka
>> Cc: Wei Yang
>> Cc: Oscar Salvador
>> Cc: M
e type - should
>be good enough for internal purposes.
>
>Reviewed-by: Alexander Duyck
>Reviewed-by: Vlastimil Babka
>Reviewed-by: Oscar Salvador
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
&g
hen undoing isolation of larger ranges, and after
>free_contig_range().
>
>Reviewed-by: Alexander Duyck
>Reviewed-by: Oscar Salvador
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>Cc: We
gt;
>This change results in all pages getting onlined via online_pages() to
>be placed to the tail of the freelist.
>
>Reviewed-by: Oscar Salvador
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>C
uffle after a sequence of generic_online_page() calls in the
>relevant callers.
>
>Reviewed-by: Vlastimil Babka
>Reviewed-by: Oscar Salvador
>Cc: Andrew Morton
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>Cc: W
>Cc: Alexander Duyck
>Cc: Mel Gorman
>Cc: Michal Hocko
>Cc: Dave Hansen
>Cc: Vlastimil Babka
>Cc: Wei Yang
>Cc: Oscar Salvador
>Cc: Mike Rapoport
>Signed-off-by: David Hildenbrand
Reviewed-by: Wei Yang
>---
> mm/memory_hotplug.c | 11 ---
> 1 fi
On Tue, Sep 29, 2020 at 12:12:14PM +0200, David Hildenbrand wrote:
>On 29.09.20 11:18, Wei Yang wrote:
>> On Mon, Sep 28, 2020 at 08:21:08PM +0200, David Hildenbrand wrote:
>>> Page isolation doesn't actually touch the pages, it simply isolates
>>> pageblocks
Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable()
>never fail")
>Link: https://github.com/ClangBuiltLinux/linux/issues/1159
>Signed-off-by: Nathan Chancellor
Reviewed-by: Wei Yang
>---
>
>Presumably, this will be squashed but I included a fixes tag
>
and that commit shouldn't have changed the condition when
>> building the zonelist, but just the ones in the allocation paths.
>
>In regard to kswapd, that is currently being worked on via
>
>https://lkml.kernel.org/r/20220329010901.1654-2-richard.weiy...@gmail.com
>
Thanks, David
Do you think it is the right time to repost the original fix?
>--
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
pgdat->node_zones + zone_type;
>> -if (managed_zone(zone)) {
>> +if (populated_zone(zone)) {
>> zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>> check_highest_zone(zone_type);
>> }
>
>Let's see if we have to find another way to properly handle fadump.
>
>Acked-by: David Hildenbrand
Ok, I see the point.
Reviewed-by: Wei Yang
>
>--
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
35 matches
Mail list logo
