On Thu, 04 Apr 2019 14:42:44 +0200,
Juergen Gross wrote:
>
> On 04/04/2019 14:38, Oleksandr Andrushchenko wrote:
> > From: Oleksandr Andrushchenko
> >
> > This fixes the regression introduced while moving to Xen shared
> > buffer implementation.
> >
> > Fixes: 58f9d806d16a ("ALSA: xen-front: Us
d bits,
Reviewed-by: Takashi Iwai
I suppose the whole patchset will be taken through xen or other tree?
thanks,
Takashi
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On Mon, 16 Apr 2018 08:24:49 +0200,
Oleksandr Andrushchenko wrote:
> --- /dev/null
> +++ b/sound/xen/Kconfig
> @@ -0,0 +1,10 @@
> +# ALSA Xen drivers
> +
> +config SND_XEN_FRONTEND
> + tristate "Xen para-virtualized sound frontend driver"
> + depends on XEN && SND_PCM
Please do select SND_
On Mon, 16 Apr 2018 08:24:51 +0200,
Oleksandr Andrushchenko wrote:
> +static irqreturn_t evtchnl_interrupt_req(int irq, void *dev_id)
> +{
> + struct xen_snd_front_evtchnl *channel = dev_id;
> + struct xen_snd_front_info *front_info = channel->front_info;
> + struct xensnd_resp *resp;
>
On Tue, 24 Apr 2018 16:29:15 +0200,
Oleksandr Andrushchenko wrote:
>
> On 04/24/2018 05:20 PM, Takashi Iwai wrote:
> > On Mon, 16 Apr 2018 08:24:51 +0200,
> > Oleksandr Andrushchenko wrote:
> >> +static irqreturn_t evtchnl_interrupt_req(int irq, void *dev
On Tue, 24 Apr 2018 16:58:43 +0200,
Oleksandr Andrushchenko wrote:
>
> On 04/24/2018 05:35 PM, Takashi Iwai wrote:
> > On Tue, 24 Apr 2018 16:29:15 +0200,
> > Oleksandr Andrushchenko wrote:
> >> On 04/24/2018 05:20 PM, Takashi Iwai wrote:
> >>> On Mon, 16 A
On Wed, 25 Apr 2018 10:26:34 +0200,
Oleksandr Andrushchenko wrote:
>
> On 04/24/2018 07:23 PM, Oleksandr Andrushchenko wrote:
> > On 04/24/2018 06:02 PM, Takashi Iwai wrote:
> >> On Tue, 24 Apr 2018 16:58:43 +0200,
> >> Oleksandr Andrushchenko wrote:
> >>
ving a few
> false-positives.
>
> Signed-off-by: Mauro Carvalho Chehab
For sound stuff, feel free to take my ack (if it's not too late):
Acked-by: Takashi Iwai
thanks,
Takashi
___
Xen-devel mailing list
Xen-devel@lists.xenproject.
On Mon, 14 May 2018 08:27:36 +0200,
Oleksandr Andrushchenko wrote:
>
> From: Oleksandr Andrushchenko
>
> Please note: this patch series depends on [3].
>
> This patch series adds support for Xen [1] para-virtualized
> sound frontend driver. It implements the protocol from
> include/xen/interfac
On Mon, 14 May 2018 08:27:40 +0200,
Oleksandr Andrushchenko wrote:
> --- /dev/null
> +++ b/sound/xen/xen_snd_front_shbuf.c
> @@ -0,0 +1,193 @@
> +// SPDX-License-Identifier: GPL-2.0 OR MIT
> +
> +/*
> + * Xen para-virtual sound device
> + *
> + * Copyright (C) 2016-2018 EPAM Systems Inc.
> + *
> +
On Tue, 15 May 2018 07:46:38 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/14/2018 11:28 PM, Takashi Iwai wrote:
> > On Mon, 14 May 2018 08:27:40 +0200,
> > Oleksandr Andrushchenko wrote:
> >> --- /dev/null
> >> +++ b/sound/xen/xen_snd_front_shbuf.c
> >
On Mon, 05 Feb 2018 09:24:58 +0100,
Oleksandr Andrushchenko wrote:
>
> From: Oleksandr Andrushchenko
>
> Hi, all!
>
> Foreword
>
>
> This change is aimed to add support for explicit back and front
> synchronization during playback and capture in response to comments
> raised during up
On Tue, 06 Mar 2018 12:25:07 +0100,
Oleksandr Andrushchenko wrote:
>
> On 03/06/2018 12:52 PM, Takashi Iwai wrote:
> > On Mon, 05 Feb 2018 09:24:58 +0100,
> > Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko
> >>
> >> Hi, all!
&g
On Tue, 06 Mar 2018 13:05:16 +0100,
Oleksandr Andrushchenko wrote:
>
> On 03/06/2018 01:32 PM, Takashi Iwai wrote:
> > On Tue, 06 Mar 2018 12:25:07 +0100,
> > Oleksandr Andrushchenko wrote:
> >> On 03/06/2018 12:52 PM, Takashi Iwai wrote:
> >>> On Mon, 05 F
On Tue, 06 Mar 2018 14:30:05 +0100,
Oleksandr Andrushchenko wrote:
>
> On 03/06/2018 02:52 PM, Takashi Iwai wrote:
> > On Tue, 06 Mar 2018 13:05:16 +0100,
> > Oleksandr Andrushchenko wrote:
> >> On 03/06/2018 01:32 PM, Takashi Iwai wrote:
> >>> On Tue, 06 M
On Tue, 06 Mar 2018 15:13:13 +0100,
Oleksandr Andrushchenko wrote:
>
> On 03/06/2018 03:48 PM, Takashi Iwai wrote:
> > On Tue, 06 Mar 2018 14:30:05 +0100,
> > Oleksandr Andrushchenko wrote:
> >> On 03/06/2018 02:52 PM, Takashi Iwai wrote:
> >>> On Tue, 06 M
On Tue, 06 Mar 2018 15:48:53 +0100,
Oleksandr Andrushchenko wrote:
>
> > And, now an open question for XEN comes: what kind of restriction
> > should be applied to the frontend. Obviously it depends on the
> > backend, so there must be some communication, and the restriction must
> >>
On Tue, 06 Mar 2018 17:04:41 +0100,
Oleksandr Andrushchenko wrote:
>
> If we decide to negotiate the parameters, then it can't be done
> at .open stage as well, as at this moment we don't know stream
> parameters yet, e.g. we don't know the number of channels, PCM
> format etc.
Hi,
sorry for the long latency.
On Wed, 07 Mar 2018 09:49:24 +0100,
Oleksandr Andrushchenko wrote:
>
> > Suppose that we negotiate from the frontend to the backend like
> >
> > int query_hw_param(int parm, int *min_p, int *max_p);
> >
> > so that you can call like
> > err = query_hw_para
On Tue, 13 Mar 2018 12:49:00 +0100,
Oleksandr Andrushchenko wrote:
>
> So, I tried to make a POC to stress the protocol changes and see
> what implementation of the HW parameter negotiation would look like.
>
> Please find protocol changes at [1]:
> - add XENSND_OP_HW_PARAM_QUERY request to read/
On Tue, 13 Mar 2018 18:31:55 +0100,
Oleksandr Andrushchenko wrote:
>
> On 03/13/2018 06:31 PM, Takashi Iwai wrote:
> > On Tue, 13 Mar 2018 12:49:00 +0100,
> > Oleksandr Andrushchenko wrote:
> >> So, I tried to make a POC to stress the protocol changes and see
> &g
On Mon, 19 Mar 2018 08:22:19 +0100,
Oleksandr Andrushchenko wrote:
>
> From: Oleksandr Andrushchenko
>
> Hello, all!
>
> In order to provide explicit synchronization between backend and
> frontend the following changes are introduced in the protocol:
> - bump protocol version to 2
> - add new
On Wed, 21 Mar 2018 08:15:36 +0100,
Oleksandr Andrushchenko wrote:
>
> On 03/20/2018 10:22 PM, Takashi Iwai wrote:
> > On Mon, 19 Mar 2018 08:22:19 +0100,
> > Oleksandr Andrushchenko wrote:
> >> From: Oleksandr Andrushchenko
> >>
> >> Hello
On Tue, 15 May 2018 08:02:08 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/15/2018 09:01 AM, Takashi Iwai wrote:
> > On Tue, 15 May 2018 07:46:38 +0200,
> > Oleksandr Andrushchenko wrote:
> >> On 05/14/2018 11:28 PM, Takashi Iwai wrote:
> >>> On Mon, 14 M
On Thu, 17 May 2018 08:26:16 +0200,
Takashi Iwai wrote:
>
> On Tue, 15 May 2018 08:02:08 +0200,
> Oleksandr Andrushchenko wrote:
> >
> > On 05/15/2018 09:01 AM, Takashi Iwai wrote:
> > > On Tue, 15 May 2018 07:46:38 +0200,
> > > Oleksandr Andrushchen
On Mon, 28 May 2018 00:49:03 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:32, Colin King wrote:
> > From: Colin Ian King
> >
> > The negative error return from the call to to_sndif_format is being
> > assigned to an unsigned 8 bit integer and hence the check for a negative
> > va
On Mon, 28 May 2018 00:42:12 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On May 28 2018 06:23, Colin King wrote:
> > From: Colin Ian King
> >
> > The error for a -ve value in ret is redundant as all previous
> > assignments to ret have an associated -ve check and hence it
> > is impossible for re
On Tue, 29 May 2018 07:48:51 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/28/2018 06:59 PM, Arnd Bergmann wrote:
> > gcc-8 warns that pcm_instance->name is not necessarily terminated correctly
> > if the input is more than 80 characters long or lacks a termination byte
> > itself:
> >
> > In fu
On Wed, 30 May 2018 13:14:58 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/30/2018 01:36 PM, Dan Carpenter wrote:
> > kfree() doesn't accept error pointers so I've set "str" to NULL on these
> > paths.
> >
> > Fixes: fd3b36045c2c ("ALSA: xen-front: Read sound driver configuration from
> > Xen s
On Thu, 31 May 2018 08:44:39 +0200,
Oleksandr Andrushchenko wrote:
>
> On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> > We want the loop to exit when "to" is set to zero, but in the current
> > code it's set to -1. Also I tweaked the indenting so it doesn't look
> > like we're passing "--to" to x
On Wed, 19 Sep 2018 23:47:10 +0200,
Nick Simonov wrote:
>
> snd_pcm_ops are not supposed to change. So mark the
> non-const structs as const. Also, refine indentation
> to ncrease readability.
>
> Signed-off-by: Nick Simonov
Applied now, thanks.
Takashi
__
On Fri, 21 Sep 2018 07:47:38 +0200,
Nick Simonov wrote:
>
> snd_pcm_ops are not supposed to change. So mark the
> non-const structs as const. Also, refine indentation
> to increase readability.
>
> Signed-off-by: Nick Simonov
> ---
> Changes v2:
> - Fix typo in commit description, ncrease to inc
On Fri, 21 Sep 2018 11:21:35 +0200,
Nick Simonov wrote:
>
> On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote:
> > On Fri, 21 Sep 2018 07:47:38 +0200,
> > Nick Simonov wrote:
> > >
> > > snd_pcm_ops are not supposed to change. So mark the
> >
On Thu, 22 Nov 2018 11:02:30 +0100,
Oleksandr Andrushchenko wrote:
>
> @@ -214,12 +221,19 @@ static void stream_clear(struct
> xen_snd_front_pcm_stream_info *stream)
> stream->out_frames = 0;
> atomic_set(&stream->hw_ptr, 0);
> xen_snd_front_evtchnl_pair_clear(stream->evt_pair);
On Thu, 27 Jun 2019 18:58:53 +0200,
Colin King wrote:
>
> From: Colin Ian King
>
> Shifting the integer value 1 is evaluated using 32-bit
> arithmetic and then used in an expression that expects a 64-bit
> value, so there is potentially an integer overflow. Fix this
> by using the BIT_ULL macro
HD-audio driver does release and re-acquire the interrupt
after disabling MSI when something goes wrong, and pci_intx() call
above is a part of that procedure. So, it can rewrite the
res->orig_intx to another value by retry without MSI. And after the
driver removal, it'll lead to another state.
In anyway, as it doesn't change the current behavior, feel free to
take my ack for now:
Acked-by: Takashi Iwai
thanks,
Takashi
On Thu, 24 Oct 2024 10:02:59 +0200,
Philipp Stanner wrote:
>
> On Wed, 2024-10-23 at 17:03 +0200, Takashi Iwai wrote:
> > On Wed, 23 Oct 2024 15:50:09 +0200,
> > Philipp Stanner wrote:
> > >
> > > On Tue, 2024-10-22 at 16:08 +0200, Takashi Iwai wrote:
> &
On Wed, 30 Oct 2024 23:17:37 +0100,
Bjorn Helgaas wrote:
>
> On Tue, Oct 15, 2024 at 08:51:10PM +0200, Philipp Stanner wrote:
> > @Driver-Maintainers: Your driver might be touched by patch "Remove
> > devres from pci_intx()". You might want to take a look.
> >
> > Changes since the RFC [1]:
> >
On Wed, 23 Oct 2024 15:50:09 +0200,
Philipp Stanner wrote:
>
> On Tue, 2024-10-22 at 16:08 +0200, Takashi Iwai wrote:
> > On Tue, 15 Oct 2024 20:51:12 +0200,
> > Philipp Stanner wrote:
> > >
> > > pci_intx() is a hybrid function which can sometimes be ma
On Fri, 25 Oct 2024 10:37:57 +0200,
Philipp Stanner wrote:
>
> On Thu, 2024-10-24 at 17:43 +0200, Takashi Iwai wrote:
> > On Thu, 24 Oct 2024 10:02:59 +0200,
> > Philipp Stanner wrote:
> > >
> > > On Wed, 2024-10-23 at 17:03 +0200, Takashi Iwai wrote:
> &
On Thu, 01 Dec 2022 14:22:12 +0100,
Oliver Neukum wrote:
>
> On 01.12.22 14:03, Ricardo Ribalda wrote:
>
> Hi,
>
> > This patchset does not modify this behaviour. It simply fixes the
> > stall for kexec().
> >
> > The patch that introduced the stall:
> > 83bfc7e793b5 ("ASoC: SOF: core: unregi
On Sun, 02 Jun 2024 01:26:04 +0200,
li...@treblig.org wrote:
>
> From: "Dr. David Alan Gilbert"
>
> 'alsa_sndif_hw_param' has been unused since the original
> commit 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound
> driver").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilber
On Thu, 27 Jul 2023 23:53:24 +0200,
Justin Stitt wrote:
>
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on its destination buffer argument which is
> _not_ always the ca
roject.org
===
Takashi Iwai (24):
ALSA: pcm: Add copy ops with universal sockptr_t
ALSA: core: Add memory copy helpers between sockptr and iomem
ALSA: dummy: Convert to generic PCM copy ops
ALSA: gus: Convert to generic PCM copy ops
ALSA: emu8000: Convert to generic PCM copy ops
ALSA: es1938:
This patch converts the xen frontend driver code to use the new
unified PCM copy callback. It's a straightforward conversion from
*_user() to *_sockptr() variants.
Cc: Oleksandr Andrushchenko
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Takashi Iwai
---
sound/xen/xen_snd_front_a
On Mon, 31 Jul 2023 19:20:54 +0200,
Mark Brown wrote:
>
> On Mon, Jul 31, 2023 at 05:46:54PM +0200, Takashi Iwai wrote:
>
> > this is a patch set to clean up the PCM copy ops using sockptr_t as a
> > "universal" pointer, inspired by the recent patch from Andy
&
On Mon, 31 Jul 2023 21:40:20 +0200,
Mark Brown wrote:
>
> On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
>
> > > It really feels like we ought to rename, or add an alias for, the type
> > > if we're going to start usin
On Tue, 01 Aug 2023 19:51:39 +0200,
Andy Shevchenko wrote:
>
> On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote:
> > On Mon, 31 Jul 2023 21:40:20 +0200,
> > Mark Brown wrote:
> > > On Mon, Jul 31, 2023 at 09:30:29PM +0200, Takashi Iwai wrot
hehab
Cc: Oleksandr Andrushchenko
Cc: Olivier Moysan
Cc: Srinivas Kandagatla
Cc: linux-me...@vger.kernel.org
Cc: xen-devel@lists.xenproject.org
===
Takashi Iwai (25):
iov_iter: Export import_ubuf()
ALSA: pcm: Add copy ops with iov_iter
ALSA: core: Add memory copy helpers between iov_ite
sandr Andrushchenko
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Takashi Iwai
---
sound/xen/xen_snd_front_alsa.c | 55 +++---
1 file changed, 10 insertions(+), 45 deletions(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
Cc: Lars-Peter Clausen
Cc: Mark Brown
Cc: Mauro Carvalho Chehab
Cc: Oleksandr Andrushchenko
Cc: Olivier Moysan
Cc: Srinivas Kandagatla
Cc: linux-me...@vger.kernel.org
Cc: xen-devel@lists.xenproject.org
===
Takashi Iwai (25):
iov_iter: Export import_ubuf()
ALSA: pcm: Add copy ops w
henko
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Takashi Iwai
---
sound/xen/xen_snd_front_alsa.c | 56 +++---
1 file changed, 11 insertions(+), 45 deletions(-)
diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index db91745
Ariadne Conill
> Cc: sta...@vger.kernel.org
> Cc: xen-devel@lists.xenproject.org
> Cc: alsa-de...@alsa-project.org
> Cc: Takashi Iwai
The relevant code has been largely rewritten for 6.12, so please check
the behavior with sound.git tree for-next branch. I guess the same
issue should
On Sat, 07 Sep 2024 12:38:50 +0200,
Andrew Cooper wrote:
>
> On 07/09/2024 8:46 am, Takashi Iwai wrote:
> > On Fri, 06 Sep 2024 20:42:09 +0200,
> > Ariadne Conill wrote:
> >> This patch attempted to work around a DMA issue involving Xen, but
> >> ca
On Mon, 09 Sep 2024 22:02:08 +0200,
Elliott Mitchell wrote:
>
> On Sat, Sep 07, 2024 at 11:38:50AM +0100, Andrew Cooper wrote:
> > On 07/09/2024 8:46 am, Takashi Iwai wrote:
> > > On Fri, 06 Sep 2024 20:42:09 +0200,
> > > Ariadne Conill wrote:
> > >>
nel.org/20240906184209.25423-1-ariadne@ariadne.space
Cc: Ariadne Conill
Signed-off-by: Takashi Iwai
---
sound/core/memalloc.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
index f3ad9f85adf1..1d931c24fa35 1006
On Thu, 12 Sep 2024 11:56:21 +0200,
Christoph Hellwig wrote:
>
> On Sat, Sep 07, 2024 at 11:38:50AM +0100, Andrew Cooper wrote:
> > Individual subsystems ought not to know or care about XENPV; it's a
> > layering violation.
>
> Agreed.
>
> > If the main APIs don't behave properly, then it probab
On Mon, 16 Sep 2024 09:24:42 +0200,
Christoph Hellwig wrote:
>
> On Mon, Sep 16, 2024 at 09:16:58AM +0200, Takashi Iwai wrote:
> > Yes, all those are really ugly hacks and have been already removed for
> > 6.12. Let's hope everything works as expected with it.
>
>
On Mon, 16 Sep 2024 09:37:07 +0200,
Christoph Hellwig wrote:
>
> On Mon, Sep 16, 2024 at 09:30:11AM +0200, Takashi Iwai wrote:
> > On Mon, 16 Sep 2024 09:24:42 +0200,
> > Christoph Hellwig wrote:
> > >
> > > On Mon, Sep 16, 2024 at 09:16:58AM +0200, Takashi Iw
59 matches
Mail list logo
