Re: [Xen-devel] [PATCH v2 28/35] xen/arm32: head: Document enable_mmu()

2019-07-30 Thread Stefano Stabellini
On Mon, 22 Jul 2019, Julien Grall wrote: > Document the behavior and the main registers usage within enable_mmu(). > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Patch added > --- > xen/arch/arm/arm32/head

Re: [Xen-devel] [PATCH v2 29/35] xen/arm32: head: Move assembly switch to the runtime PT in secondary CPUs path

2019-07-30 Thread Stefano Stabellini
On Mon, 22 Jul 2019, Julien Grall wrote: > The assembly switch to the runtime PT is only necessary for the > secondary CPUs. So move the code in the secondary CPUs path. > > While this is definitely not compliant with the Arm Arm as we are > switching between two differents set of page-tables with

Re: [Xen-devel] [PATCH v2 30/35] xen/arm32: head: Don't setup the fixmap on secondary CPUs

2019-07-30 Thread Stefano Stabellini
CPU boot and secondary CPUs boot. Additionally, the > call to setup_fixmap() is removed from secondary CPUs boot. > > Lastly, take the opportunity to replace load from literal pool with the > new macro mov_w. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini

Re: [Xen-devel] [PATCH v2 19/35] xen/arm32: head: Add a macro to move an immediate constant into a 32-bit register

2019-07-30 Thread Stefano Stabellini
> > The memory access can be avoided by using movw/movt instructions. > > A new macro is introduced to move an immediate constant into a 32-bit > register without a memory load. Follow-up patches will make use of it. > > Signed-off-by: Julien Grall That's i

Re: [Xen-devel] [PATCH v2 32/35] xen/arm32: head: Rework and document setup_fixmap()

2019-07-30 Thread Stefano Stabellini
slot */ > -1: > +#endif Patch is OK. However, the 1: should be removed in the previous patch "xen/arm32: head: Don't setup the fixmap on secondary CPUs", where we took away the beq. Reviewed-by: Stefano Stabellini > /* Map fixmap into boot_second */ >

Re: [Xen-devel] [PATCH v2 33/35] xen/arm32: head: Rework and document launch()

2019-07-30 Thread Stefano Stabellini
On Mon, 22 Jul 2019, Julien Grall wrote: > Boot CPU and secondary CPUs will use different entry point to C code. At > the moment, the decision on which entry to use is taken within launch(). > > In order to avoid using conditional instruction and make the call > clearer, launch() is reworked to ta

Re: [Xen-devel] [PATCH v2 34/35] xen/arm32: head: Setup HTTBR in enable_mmu() and add missing isb

2019-07-30 Thread Stefano Stabellini
On Mon, 22 Jul 2019, Julien Grall wrote: > At the moment, HTTBR is setup in create_page_tables(). This is fine as > it is called by every CPUs. > > However, such assumption may not hold in the future. To make change > easier, the HTTBR is not setup in enable_mmu(). > > Take the opportunity to add

Re: [Xen-devel] [PATCH v2 35/35] xen/arm: Zero BSS after the MMU and D-cache is turned on

2019-07-30 Thread Stefano Stabellini
fixmap as zero_bss() will print a message when earlyprintk is > enabled. > > [1] linux/Documentation/arm64/booting.txt > [2] linux/Documentation/arm/Booting > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > > Changes in v2: >

Re: [Xen-devel] [PATCH v2 33/35] xen/arm32: head: Rework and document launch()

2019-07-31 Thread Stefano Stabellini
On Tue, 30 Jul 2019, Julien Grall wrote: > On 30/07/2019 22:21, Stefano Stabellini wrote: > > On Mon, 22 Jul 2019, Julien Grall wrote: > >> Boot CPU and secondary CPUs will use different entry point to C code. At > >> the moment, the decision on which entry to

Re: [Xen-devel] [PATCH 14/17] xen/arm64: head: Remove ID map as soon as it is not used

2019-07-31 Thread Stefano Stabellini
On Tue, 30 Jul 2019, Julien Grall wrote: > Hi Stefano, > > On 7/30/19 6:33 PM, Stefano Stabellini wrote: > > On Thu, 27 Jun 2019, Julien Grall wrote: > > > On 6/27/19 7:55 PM, Stefano Stabellini wrote: > > > > On Mon, 10 Jun 20

[Xen-devel] [PATCH v2] 9pfs has a QEMU backend

2019-08-06 Thread Stefano Stabellini
ng forward. Signed-off-by: Stefano Stabellini --- Changes in v2: - add in-code comment - improve commit message --- tools/libxl/libxl_internal.h | 1 + tools/libxl/libxl_types_internal.idl | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_

Re: [Xen-devel] [PATCH v3 3/6] xen/arm: keep track of reserved-memory regions

2019-08-06 Thread Stefano Stabellini
On Wed, 10 Jul 2019, Julien Grall wrote: > Hi, > > On 7/8/19 8:02 PM, Oleksandr wrote: > > On 22.06.19 02:56, Stefano Stabellini wrote: > > I have tested this series and got the same behavior as with V2 [1]. > > > > The "non-reserved-memory" node in my

Re: [Xen-devel] [PATCH v3 5/6] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-06 Thread Stefano Stabellini
On Tue, 9 Jul 2019, Oleksandr wrote: > > On 22.06.19 02:56, Stefano Stabellini wrote: > > Hi, Stefano > > > Don't allow reserved-memory regions to be remapped into any guests, > > until reserved-memory regions are properly supported in Xen. For now, > > do

Re: [Xen-devel] [PATCH v3 3/6] xen/arm: keep track of reserved-memory regions

2019-08-06 Thread Stefano Stabellini
On Wed, 10 Jul 2019, Julien Grall wrote: > Hi, > > On 6/22/19 12:56 AM, Stefano Stabellini wrote: > > As we parse the device tree in Xen, keep track of the reserved-memory > > regions as they need special treatment (follow-up patches will make use > > of the stored i

Re: [Xen-devel] [PATCH v3 6/6] xen/arm: add reserved-memory regions to the dom0 memory node

2019-08-06 Thread Stefano Stabellini
On Wed, 10 Jul 2019, Julien Grall wrote: > Hi Stefano, > > On 6/22/19 12:56 AM, Stefano Stabellini wrote: > > Reserved memory regions are automatically remapped to dom0. Their device > > tree nodes are also added to dom0 device tree. However, the dom0 memory > > node i

[Xen-devel] [PATCH v4 2/7] xen/arm: make process_memory_node a device_tree_node_func

2019-08-06 Thread Stefano Stabellini
if nr_banks is reached. Signed-off-by: Stefano Stabellini --- Changes in v4: - return error if there is no reg propery, remove printk - return error if nr_banks is reached Changes in v3: - improve commit message - check return value of process_memory_node Changes in v2: - new --- xen/arch/arm

[Xen-devel] [PATCH v4 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-06 Thread Stefano Stabellini
Don't allow reserved-memory regions to be remapped into any guests, until reserved-memory regions are properly supported in Xen. For now, do not call iomem_permit_access for them. Signed-off-by: Stefano Stabellini --- Changes in v4: - compare the parent name with reserved-memory

[Xen-devel] [PATCH v4 7/7] xen/arm: add reserved-memory regions to the dom0 memory node

2019-08-06 Thread Stefano Stabellini
take a struct meminfo * instead of a kernel_info. Call it twice for dom0, once to create the first regular memory node, and the second time to create a second memory node with the ranges covering reserved-memory regions. Also, make a small code style fix in make_memory_node. Signed-off-by: Stefano

[Xen-devel] [PATCH v4 1/7] xen/arm: extend device_tree_for_each_node

2019-08-06 Thread Stefano Stabellini
, 0, 0, 0 triggers the old behavior. We need this change because in follow-up patches we want to be able to use reuse device_tree_for_each_node to call a function for each children nodes of a provided node. Signed-off-by: Stefano Stabellini --- Changes in v4: - add address_cells and size_cells

[Xen-devel] [PATCH v4 0/7] reserved-memory in dom0

2019-08-06 Thread Stefano Stabellini
14:36:14 -0700) Stefano Stabellini (7): xen/arm: extend device_tree_for_each_node xen/arm: make process_memory_node a device_tree_node_func xen/arm: keep track of reserved-memory regions xen/arm

[Xen-devel] [PATCH v4 3/7] xen/arm: keep track of reserved-memory regions

2019-08-06 Thread Stefano Stabellini
the max number of reserved memory regions to avoid accidentally mapping any portions of them into a VM. Signed-off-by: Stefano Stabellini --- Changes in v4: - depth + 1 in process_reserved_memory_node - pass address_cells and size_cells to device_tree_for_each_node - pass struct meminfo * instead

[Xen-devel] [PATCH v4 4/7] xen/arm: early_print_info print reserved_mem

2019-08-06 Thread Stefano Stabellini
Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Signed-off-by: Stefano Stabellini --- Changes in v4: - new patch --- xen/arch/arm/bootfdt.c | 9 - 1 file changed, 8 insertions(+), 1 deletion

[Xen-devel] [PATCH v4 5/7] xen/arm: handle reserved-memory in consider_modules and dt_unreserved_regions

2019-08-06 Thread Stefano Stabellini
reserved-memory regions overlap with memory nodes. The overlapping memory is reserved-memory and should be handled accordingly: consider_modules and dt_unreserved_regions should skip these regions the same way they are already skipping mem-reserve regions. Signed-off-by: Stefano Stabellini Acked

Re: [Xen-devel] [PATCH v3 1/5] xen: add a p2mt parameter to map_mmio_regions

2019-08-06 Thread Stefano Stabellini
/map_regions_p2mt. Also add an ASSERT to > > check that only p2m_mmio_* types are passed to it. > > > > Also fix the style of the comment on top of map_mmio_regions since we > > are at it. > > > > Signed-off-by: Stefano Stabellini > > CC: jbeul...@su

[Xen-devel] [PATCH] xen/arm: unbreak arm64 build

2019-08-06 Thread Stefano Stabellini
Commit 4941bfbf11eae05c92aa3242e353d173974ce7bf "xen/arm64: macros: Introduce an assembly macro to alias x30" moved lr .reqx30 to macros.h, and started to use "lr" in head.S. However, it didn't add an #include macros.h to head.S. This commit fixes it

Re: [Xen-devel] [PATCH v3 1/5] xen: add a p2mt parameter to map_mmio_regions

2019-08-06 Thread Stefano Stabellini
On Wed, 10 Jul 2019, Julien Grall wrote: > Hi Stefano, > > The Arm code looks good to me. One comment below. Should I take it as a acked-by? > On 6/19/19 12:20 AM, Stefano Stabellini wrote: > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > > index e28ea

Re: [Xen-devel] [PATCH v3 2/5] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy

2019-08-06 Thread Stefano Stabellini
On Wed, 10 Jul 2019, Julien Grall wrote: > Hi, > > On 6/19/19 12:20 AM, Stefano Stabellini wrote: > > Reuse the existing padding field to pass memory policy information. On > > Arm, the caller can specify whether the memory should be mapped as > > Device-nGnRE (Device

Re: [Xen-devel] [PATCH v3 2/5] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy

2019-08-06 Thread Stefano Stabellini
On Wed, 19 Jun 2019, Jan Beulich wrote: > >>> On 19.06.19 at 01:20, wrote: > > --- a/tools/libxc/xc_domain.c > > +++ b/tools/libxc/xc_domain.c > > @@ -2070,6 +2070,7 @@ int xc_domain_memory_mapping( > > domctl.cmd = XEN_DOMCTL_memory_mapping; > > domctl.domain = domid; > > domctl.u.

[Xen-devel] [PATCH v4 5/6] libxl/xl: add memory policy option to iomem

2019-08-06 Thread Stefano Stabellini
libxl to libxc value conversion in per-arch functions so that we can return error for x86 parameters on Arm architectures and vice versa. Signed-off-by: Stefano Stabellini CC: ian.jack...@eu.citrix.com CC: wei.l...@citrix.com --- Changes in v4: - ARM -> Arm - libxl__memory_policy_to

[Xen-devel] [PATCH v4 3/6] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy

2019-08-06 Thread Stefano Stabellini
0 in libxc. On Arm, map Device-nGnRE as p2m_mmio_direct_dev (as it is already done today) and WB cacheable memory as p2m_mmio_direct_c. On x86, there is just one policy which is the default. Signed-off-by: Stefano Stabellini CC: jbeul...@suse.com CC: andrew.coop...@citrix.com --- Changes in v4

[Xen-devel] [PATCH v4 6/6] xen/arm: clarify the support status of iomem configurations

2019-08-06 Thread Stefano Stabellini
iomem settings fall under the broader category of "Non-PCI device passthrough": they are not security supported. Make it clearer. Signed-off-by: Stefano Stabellini CC: t...@xen.org CC: konrad.w...@oracle.com CC: Julien Grall CC: jbeul...@suse.com CC: andrew.coop...@citrix.com CC

[Xen-devel] [PATCH v4 1/6] xen/arm: introduce p2m_is_mmio

2019-08-06 Thread Stefano Stabellini
Add a p2m_is_mmio macro for easy checkings. Signed-off-by: Stefano Stabellini --- xen/include/asm-arm/p2m.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h index 03f2ee75c1..31902317da 100644 --- a/xen/include/asm-arm/p2m.h +++ b

[Xen-devel] [PATCH v4 0/6] iomem memory policy

2019-08-06 Thread Stefano Stabellini
36be38da2f540aefbfb3d14076b835fc4f852aaf: xen/arm: clarify the support status of iomem configurations (2019-08-06 17:15:00 -0700) Stefano Stabellini (6): xen/arm: introduce p2m_is_mmio xen: add a p2mt parameter to map_mmio_regions

[Xen-devel] [PATCH v4 4/6] libxc: introduce xc_domain_mem_map_policy

2019-08-06 Thread Stefano Stabellini
behavior. We could extend xc_domain_memory_mapping, but QEMU makes use of it, so it is easier and less disruptive to introduce a new libxc function and change the implementation of xc_domain_memory_mapping to call into it. Signed-off-by: Stefano Stabellini CC: ian.jack...@eu.citrix.com CC: wei.l

[Xen-devel] [PATCH v4 2/6] xen: add a p2mt parameter to map_mmio_regions

2019-08-06 Thread Stefano Stabellini
. Signed-off-by: Stefano Stabellini CC: jbeul...@suse.com CC: andrew.coop...@citrix.com --- Changes in v4: - rename __map_mmio_regions to map_mmio_region - use p2m_is_mmio Changes in v3: - code style - introduce __map_mmio_regions on x86 - fix comment style on top of map_mmio_regions - add an assert

[Xen-devel] [PATCH v2] xen/arm: unbreak arm64 build for older toolchains

2019-08-07 Thread Stefano Stabellini
add an #include macros.h to head.S. This commit fixes it. The lack of alias breaks the build with gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu. The alias was added later to binutiles 2.29 in 2017. Signed-off-by: Stefano Stabellini --- Changes in v2: - improve commit message diff --git a/xen/ar

[Xen-devel] dom0less + sched=null => broken in staging

2019-08-07 Thread Stefano Stabellini
Hi Dario, George, Dom0less with sched=null is broken on staging, it simply hangs soon after Xen is finished loading things. My impression is that vcpus are not actually started. I did a git bisection and it pointed to: commit d545f1d6c2519a183ed631cfca7aff0baf29fde5 (refs/bisect/bad) Author: Dari

Re: [Xen-devel] [PATCH 4/5] xen/arm: use the physical number of gic lines for boot domains

2019-08-07 Thread Stefano Stabellini
On Tue, 15 Jan 2019, Julien Grall wrote: > Hi Stefano, > > On 1/3/19 7:07 PM, Stefano Stabellini wrote: > > On Mon, 24 Dec 2018, Julien Grall wrote: > > > Hi, > > > > > > On 12/5/18 5:28 PM, Stefano Stabellini wrote: > > > > We don't hav

Re: [Xen-devel] [PATCH 5/5] xen/arm: add dom0less device assignment info to docs

2019-08-07 Thread Stefano Stabellini
On Tue, 15 Jan 2019, Julien Grall wrote: > On 1/3/19 10:07 PM, Stefano Stabellini wrote: > > On Mon, 24 Dec 2018, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 12/5/18 5:28 PM, Stefano Stabellini wrote: > > > > Signed-off-by: Stefano Stabell

Re: [Xen-devel] [PATCH 2/5] xen/arm: assign devices to boot domains

2019-08-07 Thread Stefano Stabellini
On Tue, 15 Jan 2019, Julien Grall wrote: > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > > > index cc6b464..d48f77e 100644 > > > > --- a/xen/arch/arm/domain_build.c > > > > +++ b/xen/arch/arm/domain_build.c > > > > @@ -2094,6 +2094,88 @@ static int __init construc

Re: [Xen-devel] [PATCH v4 0/7] reserved-memory in dom0

2019-08-08 Thread Stefano Stabellini
On Thu, 8 Aug 2019, Volodymyr Babchuk wrote: > Hi Stefano, > > Stefano Stabellini writes: > > > Hi all, > > > > Looks like you are not using add_maintainer.pl or your MAINTAINERS file > is out of date. In any case I'm not getting CC'ed and I'm mis

Re: [Xen-devel] [PATCH 2/5] xen/arm: assign devices to boot domains

2019-08-08 Thread Stefano Stabellini
On Thu, 8 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 07/08/2019 23:46, Stefano Stabellini wrote: > > On Tue, 15 Jan 2019, Julien Grall wrote: > > > > > > diff --git a/xen/arch/arm/domain_build.c > > > > > > b/xen/arch/arm/domai

Re: [Xen-devel] [PATCH 5/5] xen/arm: add dom0less device assignment info to docs

2019-08-08 Thread Stefano Stabellini
On Thu, 8 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 07/08/2019 22:01, Stefano Stabellini wrote: > > On Tue, 15 Jan 2019, Julien Grall wrote: > > > On 1/3/19 10:07 PM, Stefano Stabellini wrote: > > > > On Mon, 24 Dec 2018, Julien Grall wrote: > >

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-08 Thread Stefano Stabellini
On Thu, 8 Aug 2019, George Dunlap wrote: > On 8/7/19 7:22 PM, Stefano Stabellini wrote: > > Hi Dario, George, > > > > Dom0less with sched=null is broken on staging, it simply hangs soon > > after Xen is finished loading things. My impression is that vcpus are > >

[Xen-devel] [PATCH v3 6/6] xen/arm: add dom0less device assignment info to docs

2019-08-08 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini --- Changes in v3: - add nr_spis - change description of interrupts and interrupt-parent Changes in v2: - device tree fragment loaded in cacheable memory - rename multiboot,dtb to multiboot,device-tree - rename "path" to "xen,path" - add

[Xen-devel] [PATCH v3 2/6] xen/arm: copy dtb fragment to guest dtb

2019-08-08 Thread Stefano Stabellini
w is taken from tools/libxl/libxl_arm.c. Note that it is OK to take LGPL 2.1 code and including it into a GPLv2 code base. The result is GPLv2 code. Signed-off-by: Stefano Stabellini Changes in v3: - switch to using device_tree_for_each_node for the copy Changes in v2: - add a note abou

[Xen-devel] [PATCH v3 1/6] xen/arm: introduce handle_interrupts

2019-08-08 Thread Stefano Stabellini
Move the interrupt handling code out of handle_device to a new function so that it can be reused for dom0less VMs later. Signed-off-by: Stefano Stabellini --- Changes in v3: - add patch The diff is hard to read but I just moved the interrupts related code from handle_devices to a new function

[Xen-devel] [PATCH v3 0/6] dom0less device assignment

2019-08-08 Thread Stefano Stabellini
) Stefano Stabellini (6): xen/arm: introduce handle_interrupts xen/arm: copy dtb fragment to guest dtb xen/arm: assign devices to boot domains xen/arm: handle "multiboot,device-tree" compatible nodes xen/arm: introdu

[Xen-devel] [PATCH v3 4/6] xen/arm: handle "multiboot, device-tree" compatible nodes

2019-08-08 Thread Stefano Stabellini
Detect "multiboot,device-tree" compatible nodes. Add them to the bootmod array as BOOTMOD_GUEST_DTB. In kernel_probe, find the right BOOTMOD_GUEST_DTB and store a pointer to it in dtb_bootmodule. Signed-off-by: Stefano Stabellini --- Changes in v2: - rename BOOTMOD_DTB to BOOTMOD

[Xen-devel] [PATCH v3 3/6] xen/arm: assign devices to boot domains

2019-08-08 Thread Stefano Stabellini
interrupt call handle_interrupts, which is shared with the existing dom0 path. Add a interrupt-parent property automatically to the guest device tree when the interrupt-parent should be the GIC. Copy over the interrupt property from the host device tree node. Signed-off-by: Stefano Stabell

[Xen-devel] [PATCH v3 5/6] xen/arm: introduce nr_spis

2019-08-08 Thread Stefano Stabellini
just like for dom0. Given that dom0less VMs are meant for static partitioning scenarios where the number of VMs is very low, increased memory overhead should not be a problem, and it is possible to minimizing it by using "nr_spis". Signed-off-by: Stefano Stabellini --- Changes in

Re: [Xen-devel] [PATCH] xen/page_alloc: Keep away MFN 0 from the buddy allocator

2019-08-09 Thread Stefano Stabellini
his is a specific to the allocator, the MFN 0 is removed in the common > code > to cater all the architectures (current and future). > > Reported-by: Jeff Kubascik > Signed-off-by: Julien Grall I could reproduce the problem and I confirm that this patch fixes it: Acked

Re: [Xen-devel] [PATCH] xen/page_alloc: Keep away MFN 0 from the buddy allocator

2019-08-09 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Stewart Hildebrand wrote: > On Friday, August 9, 2019 9:39 AM, Jan Beulich wrote: > >On 09.08.2019 14:14, Julien Grall wrote: > >> Combining of buddies happens only such that the resulting larger buddy > >> is still order-aligned. To cross a zone boundary while merging, the > >

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-09 Thread Stefano Stabellini
On Fri, 9 Aug 2019, Dario Faggioli wrote: > On Wed, 2019-08-07 at 11:22 -0700, Stefano Stabellini wrote: > > Hi Dario, George, > > > > Dom0less with sched=null is broken on staging, it simply hangs soon > > after Xen is finished loading things. My impression is that

Re: [Xen-devel] [PATCH v4 4/7] xen/arm: early_print_info print reserved_mem

2019-08-09 Thread Stefano Stabellini
On Wed, 7 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 06/08/2019 22:49, Stefano Stabellini wrote: > > Improve early_print_info to also print the banks saved in > > bootinfo.reserved_mem. Print them right after RESVD, increasing the same > > index. > > >

Re: [Xen-devel] [PATCH v4 3/7] xen/arm: keep track of reserved-memory regions

2019-08-09 Thread Stefano Stabellini
On Wed, 7 Aug 2019, Julien Grall wrote: > On 06/08/2019 22:49, Stefano Stabellini wrote: > > static void __init process_multiboot_node(const void *fdt, int node, > > const char *name, > >

Re: [Xen-devel] [PATCH v4 2/7] xen/arm: make process_memory_node a device_tree_node_func

2019-08-09 Thread Stefano Stabellini
On Wed, 7 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 06/08/2019 22:49, Stefano Stabellini wrote: > > Change the signature of process_memory_node to match > > device_tree_node_func. Thanks to this change, the next patch will be > > able to use device

Re: [Xen-devel] [PATCH v4 1/7] xen/arm: extend device_tree_for_each_node

2019-08-09 Thread Stefano Stabellini
On Wed, 7 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 06/08/2019 22:49, Stefano Stabellini wrote: > > Add new parameters to device_tree_for_each_node: node, depth, > > address_cells, size_cells. > > address_cells (resp. size_cells) are named address_cells_p (r

Re: [Xen-devel] [PATCH v4 3/7] xen/arm: keep track of reserved-memory regions

2019-08-09 Thread Stefano Stabellini
On Wed, 7 Aug 2019, Julien Grall wrote: > Hi Stefano, > > On 06/08/2019 22:49, Stefano Stabellini wrote: > > As we parse the device tree in Xen, keep track of the reserved-memory > > regions as they need special treatment (follow-up patches will make use > >

Re: [Xen-devel] [PATCH v4 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-09 Thread Stefano Stabellini
On Thu, 8 Aug 2019, Volodymyr Babchuk wrote: > Hi Stefano, > > Stefano Stabellini writes: > > > Don't allow reserved-memory regions to be remapped into any guests, > > until reserved-memory regions are properly supported in Xen. For now, > > do no

[Xen-devel] [PATCH v5 5/7] xen/arm: handle reserved-memory in consider_modules and dt_unreserved_regions

2019-08-12 Thread Stefano Stabellini
reserved-memory regions overlap with memory nodes. The overlapping memory is reserved-memory and should be handled accordingly: consider_modules and dt_unreserved_regions should skip these regions the same way they are already skipping mem-reserve regions. Signed-off-by: Stefano Stabellini Acked

[Xen-devel] [PATCH v5 7/7] xen/arm: add reserved-memory regions to the dom0 memory node

2019-08-12 Thread Stefano Stabellini
take a struct meminfo * instead of a kernel_info. Call it twice for dom0, once to create the first regular memory node, and the second time to create a second memory node with the ranges covering reserved-memory regions. Also, make a small code style fix in make_memory_node. Signed-off-by: Stefano

[Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func

2019-08-12 Thread Stefano Stabellini
. Let the caller deal with the error. Signed-off-by: Stefano Stabellini --- Changes in v5: - return -ENOENT if address_cells or size_cells are not properly set Changes in v4: - return error if there is no reg propery, remove printk - return error if nr_banks is reached Changes in v3: - improve

[Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node

2019-08-12 Thread Stefano Stabellini
need this change because in follow-up patches we want to be able to use reuse device_tree_for_each_node to call a function for each children nodes of a provided node and the node itself. Signed-off-by: Stefano Stabellini --- Changes in v5: - go back to v3 - code style improvement in acpi/boot.c

[Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions

2019-08-12 Thread Stefano Stabellini
the max number of reserved memory regions to avoid accidentally mapping any portions of them into a VM. Signed-off-by: Stefano Stabellini --- Changes in v5: - remove unneeded cast - remove unneeded strlen check - don't pass address_cells, size_cells, depth to device_tree_for_each_node Chang

[Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem

2019-08-12 Thread Stefano Stabellini
Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Since we are at it, also switch the existing RESVD print to use unsigned int. Signed-off-by: Stefano Stabellini --- Changes in v5: - switch to unsigned

Re: [Xen-devel] [PATCH v4 3/7] xen/arm: keep track of reserved-memory regions

2019-08-12 Thread Stefano Stabellini
On Sat, 10 Aug 2019, Julien Grall wrote: > On Fri, 9 Aug 2019, 23:21 Stefano Stabellini, wrote: > On Wed, 7 Aug 2019, Julien Grall wrote: > > Hi Stefano, > > > > On 06/08/2019 22:49, Stefano Stabellini wrote: > > > As we parse the

Re: [Xen-devel] [PATCH v4 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-12 Thread Stefano Stabellini
On Mon, 12 Aug 2019, Julien Grall wrote: > On 09/08/2019 23:56, Stefano Stabellini wrote: > > On Thu, 8 Aug 2019, Volodymyr Babchuk wrote: > > > Hi Stefano, > > > > > > Stefano Stabellini writes: > > > > > > > Don't allow reserve

[Xen-devel] [PATCH v5 0/7] reserved-memory in dom0

2019-08-12 Thread Stefano Stabellini
) Stefano Stabellini (7): xen/arm: pass node to device_tree_for_each_node xen/arm: make process_memory_node a device_tree_node_func xen/arm: keep track of reserved-memory regions xen/arm: early_print_info print

Re: [Xen-devel] [PATCH] xen/arm: setup: Add Xen as boot module before printing all boot modules

2019-08-12 Thread Stefano Stabellini
t module before > calling boot_fdt_info(). With that, the function will print Xen module > information along with all the other modules. > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > xen/arch/arm/setup.c | 12 ++-- > 1 file changed, 6 insertions(+),

[Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-12 Thread Stefano Stabellini
to a domU. Signed-off-by: Stefano Stabellini --- Changes in v5: - fix check condition - use strnicmp - return error - improve commit message Changes in v4: - compare the parent name with reserved-memory - use dt_node_cmp Changes in v3: - new patch --- xen/arch/arm/domain_build.c

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-13 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Dario Faggioli wrote: > On Fri, 2019-08-09 at 11:30 -0700, Stefano Stabellini wrote: > > On Fri, 9 Aug 2019, Dario Faggioli wrote: > > > Can you help me with this, e.g., by providing some more info and, > > > if > > > possible, lo

Re: [Xen-devel] dom0less + sched=null => broken in staging

2019-08-14 Thread Stefano Stabellini
On Wed, 14 Aug 2019, Dario Faggioli wrote: > On Tue, 2019-08-13 at 14:14 -0700, Stefano Stabellini wrote: > > On Tue, 13 Aug 2019, Dario Faggioli wrote: > > > > > > I am attaching an updated debug patch, with an additional printk > > > when > > >

Re: [Xen-devel] [PATCH V2 2/6] iommu/arm: Add ability to handle deferred probing request

2019-08-14 Thread Stefano Stabellini
On Wed, 14 Aug 2019, Julien Grall wrote: > Hi Oleksandr, > > On 13/08/2019 13:35, Oleksandr wrote: > > > > On 12.08.19 22:46, Julien Grall wrote: > > > Hi Oleksandr, > > > > Hi, Julien > > > > > > > > > > On 8/12/19 1:01 PM, Oleksandr wrote: > > > > On 12.08.19 14:11, Julien Grall wrote: > >

Re: [Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node

2019-08-14 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Julien Grall wrote: > Hi, > > On 8/12/19 11:28 PM, Stefano Stabellini wrote: > > Add a new parameter to device_tree_for_each_node: node, the node to > > start the search from. Passing 0 triggers the old behavior. > > > > Set min_depth to

Re: [Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node

2019-08-14 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Volodymyr Babchuk wrote: > Hi Stefano, > > Stefano Stabellini writes: > > > Add a new parameter to device_tree_for_each_node: node, the node to > > start the search from. Passing 0 triggers the old behavior. > > > > Set min_depth to depth

Re: [Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem

2019-08-14 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Julien Grall wrote: > Hi, > > On 8/13/19 3:28 PM, Volodymyr Babchuk wrote: > > > > Stefano Stabellini writes: > > > > > Improve early_print_info to also print the banks saved in > > > bootinfo.reserved_mem. Print them right

Re: [Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func

2019-08-14 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Volodymyr Babchuk wrote: > > @@ -162,6 +156,10 @@ static void __init process_memory_node(const void > > *fdt, int node, > > bootinfo.mem.bank[bootinfo.mem.nr_banks].size = size; > > bootinfo.mem.nr_banks++; > > } > > + > > +if ( bootinfo.mem.nr_banks

Re: [Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-14 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Julien Grall wrote: > On 8/13/19 3:34 PM, Volodymyr Babchuk wrote: > > > > Stefano Stabellini writes: > > > > > Don't allow reserved-memory regions to be remapped into any unprivileged > > > guests, until reserved-memory regions

Re: [Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func

2019-08-14 Thread Stefano Stabellini
On Tue, 13 Aug 2019, Julien Grall wrote: > On 8/12/19 11:28 PM, Stefano Stabellini wrote: > > Change the signature of process_memory_node to match > > device_tree_node_func. Thanks to this change, the next patch will be > > able to use device_tree_for_each_node to call proce

[Xen-devel] [PATCH v6 7/8] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-15 Thread Stefano Stabellini
to a domU. Signed-off-by: Stefano Stabellini --- Changes in v6: - compare against "/reserved-memory/" Changes in v5: - fix check condition - use strnicmp - return error - improve commit message Changes in v4: - compare the parent name with reserved-memory - use dt_node_cmp Chang

[Xen-devel] [PATCH v6 2/8] xen/arm: make process_memory_node a device_tree_node_func

2019-08-15 Thread Stefano Stabellini
. Let the caller deal with the error. Add a printk when device tree parsing fails. Signed-off-by: Stefano Stabellini --- Changes in v6: - fix out of space check - bring back printk when address_cells or size_cells are not properly set - return -EINVAL in that case (different from reg missing) - add

[Xen-devel] [PATCH v6 4/8] xen/arm: fix indentation in early_print_info

2019-08-15 Thread Stefano Stabellini
No functional changes. Signed-off-by: Stefano Stabellini --- xen/arch/arm/bootfdt.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index f23ebaa188..a70a739bb0 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch

[Xen-devel] [PATCH v6 0/8] reserved-memory in dom0

2019-08-15 Thread Stefano Stabellini
) Stefano Stabellini (8): xen/arm: pass node to device_tree_for_each_node xen/arm: make process_memory_node a device_tree_node_func xen/arm: keep track of reserved-memory regions xen/arm: fix indentation in

[Xen-devel] [PATCH v6 3/8] xen/arm: keep track of reserved-memory regions

2019-08-15 Thread Stefano Stabellini
the max number of reserved memory regions to avoid accidentally mapping any portions of them into a VM. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v6: - use dt_node_cmp - add acked-by Changes in v5: - remove unneeded cast - remove unneeded strlen check - don't

[Xen-devel] [PATCH v6 5/8] xen/arm: early_print_info print reserved_mem

2019-08-15 Thread Stefano Stabellini
Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Since we are at it, also switch the existing RESVD print to use unsigned int. Signed-off-by: Stefano Stabellini Reviewed-by: Volodymyr Babchuk Acked-by

[Xen-devel] [PATCH v6 6/8] xen/arm: handle reserved-memory in consider_modules and dt_unreserved_regions

2019-08-15 Thread Stefano Stabellini
reserved-memory regions overlap with memory nodes. The overlapping memory is reserved-memory and should be handled accordingly: consider_modules and dt_unreserved_regions should skip these regions the same way they are already skipping mem-reserve regions. Signed-off-by: Stefano Stabellini Acked

[Xen-devel] [PATCH v6 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-15 Thread Stefano Stabellini
as an argument. Clarify the change in the comment on top of the function. Signed-off-by: Stefano Stabellini --- Changes in v6: - fix code style - don't call func() on the first node Changes in v5: - go back to v3 - code style improvement in acpi/boot.c - improve comments and commit message

[Xen-devel] [PATCH v6 8/8] xen/arm: add reserved-memory regions to the dom0 memory node

2019-08-15 Thread Stefano Stabellini
take a struct meminfo * instead of a kernel_info. Call it twice for dom0, once to create the first regular memory node, and the second time to create a second memory node with the ranges covering reserved-memory regions. Also, make a small code style fix in make_memory_node. Signed-off-by: Stefano

Re: [Xen-devel] [PATCH v6 7/8] xen/arm: don't iomem_permit_access for reserved-memory regions

2019-08-16 Thread Stefano Stabellini
On Fri, 16 Aug 2019, Julien Grall wrote: > On 16/08/2019 00:36, Stefano Stabellini wrote: > > Don't allow reserved-memory regions to be remapped into any unprivileged > > guests, until reserved-memory regions are properly supported in Xen. For > > now, do not call i

Re: [Xen-devel] [PATCH v6 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-16 Thread Stefano Stabellini
On Fri, 16 Aug 2019, Julien Grall wrote: > Hi, > > On 16/08/2019 00:36, Stefano Stabellini wrote: > > Add a new parameter to device_tree_for_each_node: node, the node to > > start the search from. Passing 0 triggers the old behavior. > > Here you say 0 tr

Re: [Xen-devel] [PATCH v6 2/8] xen/arm: make process_memory_node a device_tree_node_func

2019-08-16 Thread Stefano Stabellini
On Fri, 16 Aug 2019, Julien Grall wrote: > Hi, > > On 16/08/2019 00:36, Stefano Stabellini wrote: > > Change the signature of process_memory_node to match > > device_tree_node_func. Thanks to this change, the next patch will be > > able to use device_tree_for_each_node

Re: [Xen-devel] [PATCH v6 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-19 Thread Stefano Stabellini
On Mon, 19 Aug 2019, Julien Grall wrote: > On 8/17/19 1:29 AM, Stefano Stabellini wrote: > > On Fri, 16 Aug 2019, Julien Grall wrote: > > > Hi, > > > > > > On 16/08/2019 00:36, Stefano Stabellini wrote: > > > > Add a new parameter to device_tree_fo

[Xen-devel] [PATCH v7 5/8] xen/arm: early_print_info print reserved_mem

2019-08-19 Thread Stefano Stabellini
Improve early_print_info to also print the banks saved in bootinfo.reserved_mem. Print them right after RESVD, increasing the same index. Since we are at it, also switch the existing RESVD print to use unsigned int. Signed-off-by: Stefano Stabellini Reviewed-by: Volodymyr Babchuk Acked-by

[Xen-devel] [PATCH v7 3/8] xen/arm: keep track of reserved-memory regions

2019-08-19 Thread Stefano Stabellini
the max number of reserved memory regions to avoid accidentally mapping any portions of them into a VM. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v6: - use dt_node_cmp - add acked-by Changes in v5: - remove unneeded cast - remove unneeded strlen check - don't

[Xen-devel] [PATCH v7 0/8] reserved-memory in dom0

2019-08-19 Thread Stefano Stabellini
) Stefano Stabellini (8): xen/arm: pass node to device_tree_for_each_node xen/arm: make process_memory_node a device_tree_node_func xen/arm: keep track of reserved-memory regions xen/arm: fix indentation in

[Xen-devel] [PATCH v7 4/8] xen/arm: fix indentation in early_print_info

2019-08-19 Thread Stefano Stabellini
No functional changes. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- xen/arch/arm/bootfdt.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 0a01963b0e..eb3dc13b06 100644 --- a/xen/arch/arm

[Xen-devel] [PATCH v7 1/8] xen/arm: pass node to device_tree_for_each_node

2019-08-19 Thread Stefano Stabellini
with depth > 0. Don't call func() on the parent node passed as an argument. Clarify the change in the comment on top of the function. The current callers pass the root node as argument: it is OK to skip the root node because no relevant properties are in it, only subnodes. Signed-off-by:

[Xen-devel] [PATCH v7 8/8] xen/arm: add reserved-memory regions to the dom0 memory node

2019-08-19 Thread Stefano Stabellini
take a struct meminfo * instead of a kernel_info. Call it twice for dom0, once to create the first regular memory node, and the second time to create a second memory node with the ranges covering reserved-memory regions. Also, make a small code style fix in make_memory_node. Signed-off-by: Stefano

[Xen-devel] [PATCH v7 2/8] xen/arm: make process_memory_node a device_tree_node_func

2019-08-19 Thread Stefano Stabellini
. Let the caller deal with the error. Add a printk when device tree parsing fails. Signed-off-by: Stefano Stabellini --- Changes in v7: - use -EINVAL as return in case size is 0 Changes in v6: - fix out of space check - bring back printk when address_cells or size_cells are not properly set

<    1   2   3   4   5   6   7   8   9   10   >