Re: [Xen-devel] [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells

2017-11-29 Thread Stefano Stabellini
df > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > > This was discovered debugging DT generated by GRUB on ACPI-only > platform. I am not aware of any DT relying on that for now, but it > would still be nice to be compliant with the spec

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-01 Thread Stefano Stabellini
that can't be the result of a prior operation. > > Take the opportunity and also correct the order of argument checks: > We shouldn't accept zero-length elements with unknown bits set in "op". > Also constify cache_flush()'s first parameter. > > Reported-b

Re: [Xen-devel] [PATCH 2/2] gnttab: improve GNTTABOP_cache_flush locking

2017-12-01 Thread Stefano Stabellini
ff-by: Jan Beulich Reviewed-by: Stefano Stabellini > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -786,10 +786,10 @@ static int _set_status(unsigned gt_versi > return _set_status_v2(domid, readonly, mapflag, shah, act, status); > } > > -s

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-01 Thread Stefano Stabellini
On Mon, 27 Nov 2017, Volodymyr Babchuk wrote: > This is follow-up to our conversation during community call. > You asked me to send OP-TEE mediator as a patch, so we can > discuss it in the mailing list. So, there it is. I squashed > two patches into one and skipped patches that we already > discus

Re: [Xen-devel] [RFC PATCH 01/31] cpufreq: move cpufreq.h file to the xen/include/xen location

2017-12-01 Thread Stefano Stabellini
ists.xen.org/archives/html/xen-devel/2014-11/msg00938.html > > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Oleksandr Tyshchenko > CC: Jan Beulich > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Julien Grall Reviewed-by: Stefano Stabellini > --- > MA

Re: [Xen-devel] [RFC PATCH 02/31] pm: move processor_perf.h file to the xen/include/xen location

2017-12-01 Thread Stefano Stabellini
ists.xen.org/archives/html/xen-devel/2014-11/msg00934.html > > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Oleksandr Tyshchenko > CC: Jan Beulich > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Julien Grall Reviewed-by: Stefano Stabellini > --- >

Re: [Xen-devel] [RFC PATCH 03/31] pmstat: move pmstat.c file to the xen/drivers/pm/stat.c location

2017-12-01 Thread Stefano Stabellini
ists.xen.org/archives/html/xen-devel/2014-11/msg00935.html > > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Oleksandr Tyshchenko > CC: Jan Beulich > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Julien Grall Reviewed-by: Stefano Stabellini > --- > M

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-01 Thread Stefano Stabellini
en.org/archives/html/xen-devel/2014-11/msg00942.html > > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Oleksandr Tyshchenko > CC: Jan Beulich > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Julien Grall > --- > xen/arch/x86/Kconfig | 1 + >

Re: [Xen-devel] [RFC PATCH 05/31] pmstat: make pmstat functions more generalizable

2017-12-01 Thread Stefano Stabellini
not being available? > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Oleksandr Tyshchenko > CC: Jan Beulich > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Julien Grall > --- > xen/drivers/pm/stat.c| 8 +++- > xen/include/xen/pmstat.h | 2 ++ &g

Re: [Xen-devel] [RFC PATCH 07/31] xenpm: Clarify xenpm usage

2017-12-01 Thread Stefano Stabellini
C: Ian Jackson > > CC: Wei Liu > > CC: Stefano Stabellini > > CC: Julien Grall > > --- > > tools/misc/xenpm.c | 6 +++--- > > Acked-by: Wei Liu Acked-by: Stefano Stabellini ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-01 Thread Stefano Stabellini
a rebased version of the original patch: > https://lists.xen.org/archives/html/xen-devel/2014-11/msg00932.html > > Signed-off-by: Oleksandr Dmytryshyn > Signed-off-by: Oleksandr Tyshchenko > CC: Jan Beulich > CC: Andrew Cooper > CC: Stefano Stabellini > CC: Julien Grall

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Volodymyr Babchuk wrote: > Hi Julien, > > > On Mon, Dec 04, 2017 at 04:27:14PM +, Julien Grall wrote: > > [...] > > >>= Error checking / DOS protection = > > >> > > >>We need powerful checks on arguments passed by the caller and evaluated > > >>by the mediator. > > >> > >

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Volodymyr Babchuk wrote: > > = Xen command forwarding = > > > > In the code below, it looks like Xen is forwarding everything to OP-TEE. > > Are there some commands Xen should avoid forwarding? Should we have a > > whitelist or a blacklist? > My code implements whitelists (at l

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-04 Thread Stefano Stabellini
On Sat, 2 Dec 2017, Oleksandr Tyshchenko wrote: > On Sat, Dec 2, 2017 at 3:06 AM, Stefano Stabellini > wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > >> From: Oleksandr Dmytryshyn > >> > >> This settings is not needed for some architectures.

Re: [Xen-devel] [RFC PATCH 05/31] pmstat: make pmstat functions more generalizable

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > Hi Stefano > > On Sat, Dec 2, 2017 at 3:21 AM, Stefano Stabellini > wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > >> From: Oleksandr Dmytryshyn > >> > >> ACPI-specific parts are mo

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-04 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > Hi, Stefano > > On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stabellini > wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > >> From: Oleksandr Dmytryshyn > >> > >> First implementation of the

Re: [Xen-devel] [RFC PATCH 09/31] xen/device-tree: Add dt_property_for_each_string macros

2017-12-04 Thread Stefano Stabellini
them down for copyright reasons): Signed-off-by: Stephen Warren Signed-off-by: Linus Walleij With those: Acked-by: Stefano Stabellini > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall > --- > xen/common/device_tree.c | 18 +

Re: [Xen-devel] [RFC PATCH 10/31] xen/device-tree: Add dt_property_read_u32_index helper

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This is a port from Linux. > > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall Same here: please original signed-off-bys and also name of the property in

Re: [Xen-devel] [RFC PATCH 12/31] xen/device-tree: Add dt_property_read_string_helper and friends

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This is a port from Linux. > > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall Same here > --- > xen/common/device_tree.c | 27 +++

Re: [Xen-devel] [RFC PATCH 11/31] xen/device-tree: Add dt_property_count_elems_of_size helper

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This is a port from Linux. > > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall Same here > --- > xen/common/device_tree.c | 20

Re: [Xen-devel] [RFC PATCH 13/31] xen/arm: Add driver_data field to struct device

2017-12-04 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall Acked-by: Stefano Stabellini > --- > xen/include/asm-arm/device.h | 1 + > 1 file changed, 1 insertion(

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-04 Thread Stefano Stabellini
s" > > Signed-off-by: Volodymyr Babchuk > CC: Stefano Stabellini > CC: Julien Grall > --- > xen/arch/arm/arm32/Makefile | 1 + > xen/arch/arm/arm32/smc.S| 32 > xen/arch/arm/arm64/Makefile | 1 + > xen/arch/a

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Volodymyr Babchuk wrote: > Hi Stefano, > > On Mon, Dec 04, 2017 at 06:30:13PM -0800, Stefano Stabellini wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > > > From: Volodymyr Babchuk > > > > > > Existing SMC wrapp

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefano Stabellini > diff --git a/drivers/xen/pvcalls-front.c b/drive

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Stefano Stabellini
ect to the backend") > Signed-off-by: Dan Carpenter Reviewed-by: Stefano Stabellini > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index 40caa92bff33..d1e1d8d2b9d5 100644 > --- a/drivers/xen/pvcalls-front.c > +++ b/drivers/xen/pvcalls-front.c

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi Ian, > > On 05/12/17 18:28, Ian Jackson wrote: > > This drops the dependency on Stefano's personal git tree. > > The osstest output branch remains unmoved. > > > > CC: Stefano Stabellini > > CC:

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-05 Thread Stefano Stabellini
rrect the order of argument checks: > >> We shouldn't accept zero-length elements with unknown bits set in "op". > >> Also constify cache_flush()'s first parameter. > >> > >> Reported-by: Jann Horn > >> Signed-off-by: Jan Beulich &

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > >> Another question is second_max_freq. As I understand, it is highest > >> non-turbo frequency calculated by framework to limit target frequency > >> when > >> turbo mode "is disabled". And Xen assumes that second_max_freq is > >> always P1 if turb

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > Hi Stefano > > On Tue, Dec 5, 2017 at 12:46 AM, Stefano Stabellini > wrote: > > On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > >> Hi, Stefano > >> > >> On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stab

Re: [Xen-devel] [RFC PATCH 22/31] xen/arm: Add Xen changes to SCPI protocol

2017-12-05 Thread Stefano Stabellini
bing it. > > Include "wrappers.h" which contains all required things the direct > ported code relies on. > > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall As far as drivers ported from Linux go, this looks pretty clean in terms

Re: [Xen-devel] [RFC PATCH 27/31] cpufreq: hack: perf->states isn't a real guest handle on ARM

2017-12-05 Thread Stefano Stabellini
o see. Although "perf->states" > looks like a guest handle it is not a real handle and we can't use > copy_from_guest() over it. As only scpi-cpufreq sets XEN_PX_DATA flag > use it as an indicator to do memcpy. > > Signed-off-by: Oleksandr Tyshchenko > CC

Re: [Xen-devel] [RFC PATCH 29/31] xen/arm: Introduce CPUFreq Interface component

2017-12-05 Thread Stefano Stabellini
ol, convert these capabilities >into PM data the CPUFreq framework expects to see followed by >uploading it. > > Signed-off-by: Oleksandr Tyshchenko > CC: Stefano Stabellini > CC: Julien Grall > --- > xen/arch/arm/cpufreq/cpufreq_if.c | 522 > +++

Re: [Xen-devel] [RFC PATCH 00/31] CPUFreq on ARM

2017-12-05 Thread Stefano Stabellini
Hi Oleksandr, I just wanted to tell you that the patch series is very well organized and the patches very nicely split. Thank you! - Stefano On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Hi, all. > > The purpose of this RFC patch series is to add CPUFreq s

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi all, > > Even though it is an Arm failure, I have CCed x86 folks to get feedback on the > approach. I have a WIP branch I could share if that interest people. > > Few months ago, we noticed an heisenbug on jobs run by osstest on the > cubietrucks (see

Re: [Xen-devel] [PATCH for-next 01/16] xen/arm: raw_copy_to_guest_helper: Rename flush_dcache to flags

2017-12-05 Thread Stefano Stabellini
n Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/guestcopy.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/guestcopy.c b/xen/arch/arm/guestcopy.c > index 4ee07fcea3..2620e659b4 100644 > --- a/xen/arch/arm/guestcopy.c

Re: [Xen-devel] [PATCH for-next 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > All the helpers within arch/arm/guestcopy.c are doing the same things: > copy data from/to the guest. > > At the moment, the logic is duplicated in each helpers making more > difficult to implement new variant. > > The first step for the consolidation is

Re: [Xen-devel] [PATCH for-next 03/16] xen/arm: Extend copy_to_guest to support copying from guest VA and use it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The only differences between copy_to_guest (formerly called > raw_copy_to_guest_helper) and raw_copy_from_guest is: > - The direction of the memcpy > - The permission use for translating the address > > Extend copy_to_guest to support copying from

Re: [Xen-devel] [PATCH for-next 04/16] xen/arm: Extend copy_to_guest to support zeroing guest VA and use it

2017-12-05 Thread Stefano Stabellini
ear_guest using copy_to_guest. > > Signed-off-by: Julien Grall Aside from the usual question about vaddr_t: Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/guestcopy.c | 41 +++-- > 1 file changed, 11 insertions(+), 30 deletions(-) > > d

Re: [Xen-devel] [PATCH for-next 05/16] xen/arm: guest_copy: Extend the prototype to pass the vCPU

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Currently, guest_copy assumes the copy will only be done for the current > vCPU. A follow-up patch will require to use a different vCPU. > > So extend the prototype to pass the vCPU. > > Signed-off-by: Julien Grall Reviewed-by:

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The only differences between copy_to_guest and access_guest_memory_by_ipa are: > - The latter does not support copying data crossing page boundary > - The former is copying from/to guest VA whilst the latter from > guest PA > > copy_to_guest c

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Stefano Stabellini wrote: > On Thu, 23 Nov 2017, Julien Grall wrote: > > The only differences between copy_to_guest and access_guest_memory_by_ipa > > are: > > - The latter does not support copying data crossing page boundary > > - The form

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Hi Andrew, > > On 23/11/17 18:49, Andrew Cooper wrote: > > On 23/11/17 18:32, Julien Grall wrote: > > > This new function will be used in a follow-up patch to copy data to the > > > guest > > > using the IPA (aka guest physical address) and then clean the

Re: [Xen-devel] [PATCH for-next 08/16] xen/arm: kernel: Rework kernel_zimage_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The function kernel_zimage is dealing with IPA but uses gvirt_to_maddr to > do the translation. This is currently working fine because the stage-1 MMU > is disabled. > > Furthermore, the function is implementing its own copy to guest resulting > in code d

Re: [Xen-devel] [PATCH for-next 08/16] xen/arm: kernel: Rework kernel_zimage_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Stefano Stabellini wrote: > On Thu, 23 Nov 2017, Julien Grall wrote: > > The function kernel_zimage is dealing with IPA but uses gvirt_to_maddr to > > do the translation. This is currently working fine because the stage-1 MMU > > is disabled. > > &g

Re: [Xen-devel] [PATCH for-next 09/16] xen/arm: domain_build: Rework initrd_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
lting > in code duplication and making more difficult to update the logic in > page-tables (such support for Populate On Demand). > > The new copy_to_guest_phys_flush_dcache could be used here by temporarily > mapping the full initrd in the virtual space. > > Signed-off-by:

Re: [Xen-devel] [PATCH for-next 10/16] xen/arm: domain_build: Use copy_to_guest_phys_flush_dcache in dtb_load

2017-12-05 Thread Stefano Stabellini
_phys_flush_dcache. This also result to a slightly more > comprehensible code. > > Signed-off-by: Julien Grall Yes definitely an improvement Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/domain_build.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletio

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-06 Thread Stefano Stabellini
On Wed, 6 Dec 2017, Jan Beulich wrote: > >>> On 05.12.17 at 21:48, wrote: > > You are right. We need to define a new struct for internal usage, for > > example: > > > > struct xen_processor_performance_internal { > > uint32_t flags; /* flag for Px sub info type */ > > uint32_t platfor

Re: [Xen-devel] [RFC PATCH 29/31] xen/arm: Introduce CPUFreq Interface component

2017-12-06 Thread Stefano Stabellini
On Wed, 6 Dec 2017, Oleksandr Tyshchenko wrote: > >> +perf->platform_limit = platform_limit; > >> +perf->shared_type = CPUFREQ_SHARED_TYPE_ANY; > >> +perf->domain_info.domain = cpumask_first(mask); > >> +perf->domain_info.num_processors = cpumask_weight(mask); > >> + > >> +/* It

Re: [Xen-devel] [PATCH for-next 11/16] xen/arm: p2m: Rename p2m_flush_tlb and p2m_flush_tlb_sync

2017-12-07 Thread Stefano Stabellini
order to get more easily some code ported > from x86 P2M or even to shared with. > > For p2m_flush_tlb_sync, the 'force' was added because the TLBs are > flush unconditionally. A follow-up patch will add an helper to flush > TLBs only in certain cases. > > Signed-off-

Re: [Xen-devel] [PATCH for-next 12/16] xen/arm: p2m: Introduce p2m_tlb_flush_sync, export it and use it

2017-12-07 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Multiple places in the code requires to flush the TLBs wonly when ^ only Aside from this Reviewed-by: Stefano Stabellini > p2m->need_flush is set. > > Rather than open-coding

Re: [Xen-devel] [PATCH for-next 13/16] xen/arm: p2m: Fold p2m_tlb_flush into p2m_force_tlb_flush_sync

2017-12-07 Thread Stefano Stabellini
t; > This seems a bit pointless but would allow to have a single API for > flushing and avoid misusage in the P2M code. > > So update p2m_alloc_table to use p2m_force_tlb_flush_sync and fold > p2m_tlb_flush in p2m_force_tlb_flush_sync. > > Signed-off-by: Julien Grall Reviewed

Re: [Xen-devel] [PATCH for-next 14/16] xen/arm: traps: Remove the field gva from mmio_info_t

2017-12-07 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > mmio_info_t is used to gather information in order do emulation a ^ of a Aside from this Reviewed-by: Stefano Stabellini > region. Guest virtual address is unlikely to be a

Re: [Xen-devel] [PATCH for-next 15/16] xen/arm: traps: Move the definition of mmio_info_t in try_handle_mmio

2017-12-07 Thread Stefano Stabellini
o_info_t is now filled by > try_handle_mmio. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/traps.c | 31 +-- > 1 file changed, 17 insertions(+), 14 deletions(-) > > diff --git a/xen/arch/arm/traps.c b/

Re: [Xen-devel] [PATCH for-next 16/16] xen/arm: traps: Merge do_trap_instr_abort_guest and do_trap_data_abort_guest

2017-12-07 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The two helpers do_trap_instr_abort_guest and do_trap_data_abort_guest > are used trap stage-2 abort. While the former is only handling prefetch > abort and the latter data abort, they are very similarly and does not > warrant to have separate helpers. >

Re: [Xen-devel] [PATCH] xen/arm64: head.S: Introduce macro to load the physical address of a symbol

2017-12-07 Thread Stefano Stabellini
acro to replace all the current opencoded version. > > Note that most of comments associated to the code changed have been > removed because the code is now self-explanatory. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > ---

Re: [Xen-devel] [PATCH] xen/arm: Remove unused fixmap slots

2017-12-07 Thread Stefano Stabellini
On Thu, 7 Dec 2017, Julien Grall wrote: > There are quite a few fixmap slots that have not been used for a while. > Remove them. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > xen/include/asm-arm/config.h | 9 ++--- > 1 file changed, 2 inser

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-07 Thread Stefano Stabellini
On Wed, 6 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 12/06/2017 01:22 AM, Stefano Stabellini wrote: > > On Thu, 23 Nov 2017, Julien Grall wrote: > > > The only differences between copy_to_guest and access_guest_memory_by_ipa > > > are: > > >

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Bail out if gicv3_cpu_init fail

2017-12-07 Thread Stefano Stabellini
ss. As the rest of the code (e.g gicv3_hyp_init) relies on > system register, it is better to bail out directly. > > This will save time on debugging early boot issue on GICv3 platform. > > Signed-off-by: Julien Grall This is good: Reviewed-by: Stefano Stabellini Do we also

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 07/12/17 23:01, Stefano Stabellini wrote: > > On Wed, 6 Dec 2017, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 12/06/2017 01:22 AM, Stefano Stabellini wrote: > > > > On Th

Re: [Xen-devel] [PATCH] xen/arm: gic-v3: Bail out if gicv3_cpu_init fail

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 07/12/17 23:05, Stefano Stabellini wrote: > > On Wed, 6 Dec 2017, Julien Grall wrote: > > > From: Julien Grall > > > > > > When system registers are not

Re: [Xen-devel] [PATCH] xen/arm: Surround HSR_SYSREG macro value with ()

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi, > > Ping? > > Cheers, > > On 29/11/17 17:46, Julien Grall wrote: > > The value of the macro HCR_SYSREG is not surrounded by (). This means > > the behavior may change depend on how it is used. > > > > Thanksfully recent GCC will issue a warning for

Re: [Xen-devel] [PATCH] xen/arm: bootfdt: Use proper default for #address-cells and #size-cells

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > Hi, > > On 29/11/17 18:12, Stefano Stabellini wrote: > > On Wed, 29 Nov 2017, Julien Grall wrote: > > > Per the device-tree specific [1], when the property #address-cells > > > and #size-cells are not present, th

Re: [Xen-devel] [PATCH v2 03/10] ARM: VGIC: move gic_remove_irq_from_queues()

2017-12-08 Thread Stefano Stabellini
ara > Reviewed-by: Stefano Stabellini I committed the first three patches > --- > xen/arch/arm/gic.c | 9 - > xen/arch/arm/vgic-v3-its.c | 4 ++-- > xen/arch/arm/vgic.c| 11 ++- > xen/include/asm-arm/gic.h | 1 - > xen/include/asm-a

Re: [Xen-devel] [PATCH v2 04/10] ARM: VGIC: streamline gic_restore_pending_irqs()

2017-12-08 Thread Stefano Stabellini
On Thu, 7 Dec 2017, Andre Przywara wrote: > In gic_restore_pending_irqs() we push our pending virtual IRQs into the > list registers. This function is called once from a GIC context and once > from a VGIC context. Refactor the calls so that we have only one callsite > from the VGIC context. This wi

Re: [Xen-devel] [PATCH v2 05/10] ARM: VGIC: split gic.c to observe hardware/virtual GIC separation

2017-12-08 Thread Stefano Stabellini
> To improve abstraction, move the VGIC functions into a separate file, > so that gic.c does what is says on the tin. > > Signed-off-by: Andre Przywara Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/Makefile | 1 + &g

Re: [Xen-devel] [PATCH v2 06/10] ARM: VGIC: split up gic_dump_info() to cover virtual part separately

2017-12-08 Thread Stefano Stabellini
a Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/domain.c | 1 + > xen/arch/arm/gic-vgic.c | 11 +++ > xen/arch/arm/gic.c| 12 > xen/include/asm-arm/gic.h | 1 + > 4 files changed, 13 insertions(+), 12 deletions(-) > > diff --git

Re: [Xen-devel] [PATCH v2 10/10] ARM: VGIC: rework gicv[23]_update_lr to not use pending_irq

2017-12-08 Thread Stefano Stabellini
rom gic-v[23].c. > > Signed-off-by: Andre Przywara Reviewed-by: Stefano Stabellini > --- > xen/arch/arm/gic-v2.c | 14 +++--- > xen/arch/arm/gic-v3.c | 12 ++-- > xen/arch/arm/gic-vgic.c | 3 ++- > xen/include/asm-arm/gic.h | 4 ++-- > xen/in

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > On 06/12/17 12:27, Julien Grall wrote: > > On 12/06/2017 01:26 AM, Stefano Stabellini wrote: > > > On Thu, 23 Nov 2017, Julien Grall wrote: > > > > Hi Andrew, > > > > > > > > On 23/11/17 18:49, An

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-08 Thread Stefano Stabellini
On Fri, 8 Dec 2017, Julien Grall wrote: > On 8 Dec 2017 22:26, "Stefano Stabellini" wrote: > On Fri, 8 Dec 2017, Julien Grall wrote: > > On 06/12/17 12:27, Julien Grall wrote: > > > On 12/06/2017 01:26 AM, Stefano Stabellini wrote: > >

Re: [Xen-devel] [Qemu-devel] [PATCH] xen/pt: Set is_express to avoid out-of-bounds write

2017-12-08 Thread Stefano Stabellini
here: > #0 0x7ff596a94bb8 in __interceptor_calloc > (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xd9bb8) > #1 0x7ff57da66580 in g_malloc0 > (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x50580) > #2 0x55e0fdda7d3d in device_set_realized hw/core/qdev.c:914 > [...] > > Signed

Re: [Xen-devel] [RFC] xen/arm: Suspend to RAM Support in Xen for ARM

2017-12-11 Thread Stefano Stabellini
On Wed, 9 Aug 2017, Mirela Simonovic wrote: > This document contains our draft proposal for implementing "suspend to RAM" > support for ARM in Xen, as discussed during the last Xen ARM community call. > It covers the basic suspend to RAM mechanism based on ARM PSCI standard, > that would allow indi

Re: [Xen-devel] [PATCH v3 for-next 1/4] xen/arm: domain_build: Clean-up insert_11_bank

2017-12-11 Thread Stefano Stabellini
On Wed, 1 Nov 2017, Julien Grall wrote: > - Remove spurious () > - Add missing spaces > - Turn 1 << to 1UL << > - Rename spfn to smfn and switch to mfn_t > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > > Cc: Ste

Re: [Xen-devel] [PATCH v3 for-next 2/4] xen/arm32: mm: Rework is_xen_heap_page to avoid nameclash

2017-12-11 Thread Stefano Stabellini
t; > Fix it by renaming the local variable _mfn to mfn_. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > > Cc: Stefano Stabellini > > Changes in v3: > - Fix typo in the commit message > --- > xen/include/asm-arm/mm

Re: [Xen-devel] [PATCH v3 for-next 4/4] xen: Convert __page_to_mfn and __mfn_to_page to use typesafe MFN

2017-12-11 Thread Stefano Stabellini
the callers are now switched to _mfn(domain_page_to_mfn(...)). > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > > Andrew suggested to drop IS_VALID_PAGE in xen/tmem_xen.h. His comment > was: > > "/sigh This is tautological. The definition of a "valid

Re: [Xen-devel] [PATCH v3 for-next 0/4] xen: Convert __page_to_mfn and _mfn_to_page to use typesafe MFN

2017-12-11 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Jan Beulich wrote: > >>> On 09.11.17 at 16:48, wrote: > > On 09/11/17 15:47, Jan Beulich wrote: > > On 09.11.17 at 16:39, wrote: > >>> What I meant is you would replace the 4 occurrences by > >>> mfn_to_page(_mfn(...)). If you are happy with that, then fine. > >> > >> Oh,

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-11 Thread Stefano Stabellini
On Tue, 12 Dec 2017, Julien Grall wrote: > Hi Stefano, > > On 12/08/2017 10:43 PM, Stefano Stabellini wrote: > > On Fri, 8 Dec 2017, Julien Grall wrote: > > > On 8 Dec 2017 22:26, "Stefano Stabellini" wrote: > > >On Fri, 8 Dec 2017, Julien Gr

Re: [Xen-devel] [v2 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-12 Thread Stefano Stabellini
hat for now, only > copying to guest virtual address is supported. Follow-up patches will > extend the support. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Use vaddr_t > - Use uint64_t for addr in copy_gues

Re: [Xen-devel] [v2 03/16] xen/arm: Extend copy_to_guest to support copying from guest VA and use it

2017-12-12 Thread Stefano Stabellini
to support copying from guest VA by adding using a > bit in the flags to tell the direction of the copy. > > Lastly, reimplement raw_copy_from_guest using copy_to_guest. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v2: >

Re: [Xen-devel] [v2 04/16] xen/arm: Extend copy_to_guest to support zeroing guest VA and use it

2017-12-12 Thread Stefano Stabellini
ear_guest using copy_to_guest. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v3: > - Use vaddr_t > --- > xen/arch/arm/guestcopy.c | 41 +++-- > 1 file changed, 11 insertions(+), 30 dele

Re: [Xen-devel] [v2 05/16] xen/arm: guest_copy: Extend the prototype to pass the vCPU

2017-12-12 Thread Stefano Stabellini
n > for copying from a guest domain (ipa case) in the future. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Encapsulate the vCPU in an union. > - Rework the commit message > --- > xen/arch/arm/guest

Re: [Xen-devel] [v2 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-12 Thread Stefano Stabellini
o extend the use of it, it is now possible > to copy data crossing page boundary. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v2: > - Rework the patch after the interface changes in the previous > patch. >

Re: [Xen-devel] [v2 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-12 Thread Stefano Stabellini
On Tue, 12 Dec 2017, Julien Grall wrote: > This new function will be used in a follow-up patch to copy data to the guest > using the IPA (aka guest physical address) and then clean the cache. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- >

Re: [Xen-devel] [v2 16/16] xen/arm: traps: Merge do_trap_instr_abort_guest and do_trap_data_abort_guest

2017-12-12 Thread Stefano Stabellini
rate helpers. > > For instance, merging the both will make easier to maintain stage-2 abort > handling. So consolidate the two helpers in a new helper > do_trap_stage2_abort. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > --- > Changes in v

Re: [Xen-devel] [PATCH] xen/efi: Fix build with clang-5.0

2017-12-13 Thread Stefano Stabellini
> Spotted by Travis. > > Signed-off-by: Andrew Cooper Reviewed-by: Stefano Stabellini > --- > CC: Jan Beulich > CC: Stefano Stabellini > CC: Julien Grall > > For future discussion, Why are these implementations not inline? Why are we > being special

[Xen-devel] [PULL 3/6] xenfb: Use Input Handlers directly

2017-12-14 Thread Stefano Stabellini
mapping, and supporting documention. Signed-off-by: Owen Smith Reviewed-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/display/xenfb.c | 274 ++--- 1 file changed, 137 insertions(+), 137 deletions

[Xen-devel] [PULL 1/6] xen-disk: use an IOThread per instance

2017-12-14 Thread Stefano Stabellini
instance in the log. Signed-off-by: Paul Durrant Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/block/trace-events | 7 +++ hw/block/xen_disk.c | 53 --- 2 files changed, 53 insertions(+), 7 deletions(-) diff --git a

[Xen-devel] [PULL 4/6] xenfb: Add [feature|request]-raw-pointer

2017-12-14 Thread Stefano Stabellini
Owen Smith Reviewed-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/display/xenfb.c | 47 ++- 1 file changed, 30 insertions(+), 17 deletions(-) diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index ed06e

[Xen-devel] [PULL 2/6] ui: generate qcode to linux mappings

2017-12-14 Thread Stefano Stabellini
From: Owen Smith Use keycodedb to generate a qcode to linux mapping Signed-off-by: Owen Smith Reviewed-by: Gerd Hoffmann Signed-off-by: Stefano Stabellini --- Makefile | 1 + include/ui/input.h | 3 +++ ui/input-keymap.c | 1 + 3 files changed, 5 insertions(+) diff --git a

[Xen-devel] [PULL 0/6] xen-20171214-tag

2017-12-14 Thread Stefano Stabellini
The following changes since commit 0a0dc59d27527b78a195c2d838d28b7b49e5a639: Update version for v2.11.0 release (2017-12-13 14:31:09 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20171214-tag for you to fetch changes up to 2e63e

[Xen-devel] [PULL 6/6] xen/pt: Set is_express to avoid out-of-bounds write

2017-12-14 Thread Stefano Stabellini
/libglib-2.0.so.0+0x50580) #2 0x55e0fdda7d3d in device_set_realized hw/core/qdev.c:914 [...] Signed-off-by: Simon Gaiser Acked-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index

[Xen-devel] [PULL 5/6] xenfb: activate input handlers for raw pointer devices

2017-12-14 Thread Stefano Stabellini
. HVM xen_kbdfront can incorrectly scale absolute coordinates when the display resolution is not 800x600. Signed-off-by: Owen Smith Reviewed-by: Gerd Hoffmann Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/display/xenfb.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [Xen-devel] [PATCH V2] arm: xen: mm: use __GPF_DMA32 for arm64

2019-08-30 Thread Stefano Stabellini
+ Juergen, Boris On Fri, 30 Aug 2019, Christoph Hellwig wrote: > Can we take a step back and figure out what we want to do here? > > AFAICS this function allocates memory for the swiotlb-xen buffer, > and that means it must be <= 32-bit addressable to satisfy the DMA API > guarantees. That means

Re: [Xen-devel] [PATCH 02/11] xen/arm: consolidate page-coherent.h

2019-09-09 Thread Stefano Stabellini
On Thu, 5 Sep 2019, Christoph Hellwig wrote: > Shared the duplicate arm/arm64 code in include/xen/arm/page-coherent.h. > > Signed-off-by: Christoph Hellwig Reviewed-by: Stefano Stabellini > --- > arch/arm/include/asm/xen/page-coherent.h | 75 > arch

Re: [Xen-devel] [PATCH 01/11] xen/arm: use dma-noncoherent.h calls for xen-swiotlb cache maintainance

2019-09-09 Thread Stefano Stabellini
On Thu, 5 Sep 2019, Christoph Hellwig wrote: > Copy the arm64 code that uses the dma-direct/swiotlb helpers for DMA > on-coherent devices. > > Signed-off-by: Christoph Hellwig This is much better and much more readable. Reviewed-by: Stefano Stabellini > --- > arch/arm/in

Re: [Xen-devel] [PATCH V2] arm: xen: mm: use __GPF_DMA32 for arm64

2019-09-11 Thread Stefano Stabellini
On Wed, 11 Sep 2019, Peng Fan wrote: > > Subject: Re: [PATCH V2] arm: xen: mm: use __GPF_DMA32 for arm64 > > > > + Juergen, Boris > > > > On Fri, 30 Aug 2019, Christoph Hellwig wrote: > > > Can we take a step back and figure out what we want to do here? > > > > > > AFAICS this function allocates

Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

2019-09-12 Thread Stefano Stabellini
On Wed, 11 Sep 2019, Volodymyr Babchuk wrote: > > Julien Grall writes: > > > One line in process_multiboot_node() is using hard tab rather than soft > > tab. So fix it! > > > > Signed-off-by: Julien Grall > Reviewed-by: Volodymyr Ba

Re: [Xen-devel] [PATCH] xen/arm: setup: Relocate the Device-Tree later on in the boot

2019-09-12 Thread Stefano Stabellini
eap allocator decides where to put it. > > > > Lastly, the device-tree is not going to be used for ACPI system. So > > there are no need to relocate it and can just be discarded. > > > > Signed-off-by: Julien Grall > Reviewed-by: Volodymyr Babchuk Acked-by: Ste

Re: [Xen-devel] [PATCH] xen/arm32: setup: Give a xenheap page to the boot allocator

2019-09-19 Thread Stefano Stabellini
On Tue, 17 Sep 2019, Julien Grall wrote: > After commit 6e3e771203 "xen/arm: setup: Relocate the Device-Tree later on > in the boot", the boot allocator will not receive any xenheap page (i.e. > mapped page) on Arm32. > > However, the boot allocator implicitely rely on having the first page > alre

Re: [Xen-devel] [[PATCH for-4.13]] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-09-19 Thread Stefano Stabellini
On Tue, 17 Sep 2019, Julien Grall wrote: > The current implementations of xen_{map, unmap}_table() expect > {map, unmap}_domain_page() to be usable. Those helpers are used to > map/unmap page tables while update Xen page-tables. > > Since commit 022387ee1a "xen/arm: mm: Don't open-code Xen PT upda

Re: [Xen-devel] [PATCH] xen/arm: iommu: Panic if not all IOMMUs are initialized

2019-09-19 Thread Stefano Stabellini
e correctly all the IOMMUs."); > > > > Please add "\n" > > > You can add: > > Tested-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini I added the "\n", fixed a typo in the commit message, and committed the patch.

  1   2   3   4   5   6   7   8   9   10   >