Re: [Xen-devel] [Qemu-devel] [PATCH] qemu: include generated files with <> and not ""

2018-03-20 Thread Stefan Weil
Am 20.03.2018 um 02:54 schrieb Michael S. Tsirkin: > QEMU coding style at the moment asks for all non-system > include files to be used with #include "foo.h". > However this rule actually does not make sense and > creates issues for when the included file is generated. > > In C, include "file" mea

Re: [Xen-devel] [Qemu-ppc] [PATCH] qemu: include generated files with <> and not ""

2018-03-21 Thread Stefan Weil
Am 21.03.2018 um 14:08 schrieb Michael S. Tsirkin: > It still leaves us with a host of problems e.g. the problem of stale > headers in the source directory. There have already been suggestions in the past to forbid in-tree builds. Would it help if configure would refuse to run from the root source

Re: [Xen-devel] [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument

2020-02-18 Thread Stefan Weil
Am 18.02.20 um 14:20 schrieb Philippe Mathieu-Daudé: > This commit was produced with the included Coccinelle script > scripts/coccinelle/as-rw-const.patch. > > Inspired-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: <20200218112457.22712-1-peter.mayd...@linaro.org> [

Re: [Xen-devel] [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument

2020-02-18 Thread Stefan Weil
Am 18.02.20 um 19:49 schrieb Peter Maydell: > I think that we should fix the inconsistency where these functions > all take "uint8_t* buf": > > - address_space_rw() > - address_space_read() > - address_space_write() > - address_space_write_rom() > - cpu_physical_memory_rw() > - cpu_memory_rw

Re: [Xen-devel] [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument

2020-02-18 Thread Stefan Weil
Am 18.02.20 um 19:59 schrieb Stefan Weil: > Indeed, fixing such inconsitencies would be good. s/inconsitencies/inconsistencies/ :-) ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH 1/6] disas: add G_GNUC_PRINTF to gstring_printf

2022-12-19 Thread Stefan Weil
Am 19.12.22 um 14:02 schrieb Daniel P. Berrangé: Signed-off-by: Daniel P. Berrangé --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index 94d3b45042..31df8f5b89 100644 --- a/disas.c +++ b/disas.c @@ -239,6 +239,7 @@ void target_disas(FILE *out, CPUState *cpu,