Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > diff --git a/xen/arch/ppc/include/asm/Makefile > b/xen/arch/ppc/include/asm/Makefile > index ece7fa66dd..df4c1ebb08 100644 > --- a/xen/arch/ppc/include/asm/Makefile > +++ b/xen/arch/ppc/include/asm/Makefile > @@ -1,3 +1,4 @@ > # SPDX-Lic

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 1:46 PM, Oleksii wrote: > On Mon, 2023-11-27 at 15:31 +0100, Jan Beulich wrote: >> On 27.11.2023 15:13, Oleksii Kurochko wrote: >>> --- a/xen/arch/ppc/include/asm/irq.h >>> +++ b/xen/arch/ppc/include/asm/irq.h >>> @@ -3,7 +3,9 @@ >>> #define __ASM_PPC_IRQ_H__ >>> >>> #i

Re: [PATCH v4 03/14] xen/asm-generic: introduce generic hypercall.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > Introduce an empty generic hypercall.h for archs which don't > implement it. > > Drop PPC's hypercall.h and switch to generic one instead. Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 04/14] xen/asm-generic: introduce generic header iocap.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > iocap.h is common for Arm, PPC and RISC-V architectures thereby > it was moved to asm-generic. > > Also Arm and PPC were switched to asm-generic version of iocap.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 05/14] xen/asm-generic: introduce stub header

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common for Arm, PPC and RISC-V thereby it > is moved to asm-generic. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 06/14] xen/asm-generic: introduce generic header percpu.h

2023-11-28 Thread Shawn Anastasio
PC implementation of this will need to be fixed (this was also the case before your patch in PPC's current percpu.h but it was conspicuously missing a TODO comment). In any case, Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 07/14] xen/asm-generic: introduce generalized hardirq.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common through archs thereby it is moved > to asm-generic. > > Arm and PPC were switched to asm generic verstion of hardirq.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 08/14] xen/asm-generic: introduce generic div64.h header

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > All archs have the do_div implementation for BITS_PER_LONG == 64 > so do_div64.h is moved to asm-generic. > > x86 and PPC were switched to asm-generic version of div64.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 09/14] xen/asm-generic: introduce generic header altp2m.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between several archs so it is > moved to asm-generic. > > Arm and PPC were switched to asm-generic version of altp2m.h. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-28 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > The header is shared between several archs so it is > moved to asm-generic. > > Signed-off-by: Oleksii Kurochko > Acked-by: Jan Beulich . > --- > Changes in V4: > - Removed the double blank line. > - Added Acked-by: Jan Beulich . > -

Re: [PATCH v4 02/14] xen/asm-generic: introduce generic device.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:49 AM, Oleksii wrote: > On Tue, 2023-11-28 at 15:28 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/irq.h >>> b/xen/arch/ppc/include/asm/irq.h >>&g

Re: [PATCH v4 10/14] xen/asm-generic: introduce stub header monitor.h

2023-11-29 Thread Shawn Anastasio
On 11/29/23 6:39 AM, Oleksii wrote: > Hi Shawn, > > On Tue, 2023-11-28 at 16:21 -0600, Shawn Anastasio wrote: >> Hi Oleksii, >> >> On 11/27/23 8:13 AM, Oleksii Kurochko wrote: >>> diff --git a/xen/arch/ppc/include/asm/Makefile >>> b/xen/arch/

Re: [PATCH v4 11/14] xen/asm-generic: introduce stub header numa.h

2023-11-29 Thread Shawn Anastasio
helpers are using it. */ extern mfn_t first_valid_mfn; This should probably be changed to generic/GENERIC as you've done elsewhere in the series. In any case, Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-29 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v4 12/14] xen/asm-generic: introduce stub header softirq.h

2023-11-29 Thread Shawn Anastasio
Hi Oleksii, On 11/27/23 8:13 AM, Oleksii Kurochko wrote: > is common between Arm, PPC and RISC-V so it is > moved to asm-generic. > > Drop Arm and PPC's softirq.h and use asm-generic version instead. > Acked-by: Shawn Anastasio Thanks, Shawn

[PATCH 2/3] xen/ppc: mm-radix: Replace debug printing code with printk

2023-12-01 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/xen

[PATCH 3/3] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime

2023-12-01 Thread Shawn Anastasio
supported value (on POWER9). Signed-off-by: Shawn Anastasio --- xen/arch/ppc/mm-radix.c | 167 +++- 1 file changed, 96 insertions(+), 71 deletions(-) diff --git a/xen/arch/ppc/mm-radix.c b/xen/arch/ppc/mm-radix.c index de181cf6f1..fae5ebfdcc 100644 --- a/xen/arch/ppc

[PATCH 0/3] Early Boot Allocation on Power

2023-12-01 Thread Shawn Anastasio
Process Table instead of the minimal one that was previously used to keep the Xen binary size small. Thanks, Shawn Anastasio (3): xen/ppc: Enable Boot Allocator xen/ppc: mm-radix: Replace debug printing code with printk xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime xen

[PATCH 1/3] xen/ppc: Enable Boot Allocator

2023-12-01 Thread Shawn Anastasio
Adapt arm's earlyfdt parsing code to ppc64 and enable Xen's early boot allocator. Routines for parsing arm-specific devicetree nodes (e.g. multiboot) were excluded, reducing the overall footprint of code that was copied. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile

Re: [PATCH v2 07/39] xen/riscv: introduce arch-riscv/hvm/save.h

2023-12-07 Thread Shawn Anastasio
On 12/5/23 9:59 AM, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >> --- a/xen/include/public/hvm/save.h >> +++ b/xen/include/public/hvm/save.h >> @@ -91,6 +91,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); >> #include "../arch-arm/hvm/save.h" >> #elif defined(__powe

Re: [PATCH] smp: move cpu_is_offline() definition

2023-12-13 Thread Shawn Anastasio
Beulich > Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH 1/3] xen/ppc: Enable Boot Allocator

2023-12-14 Thread Shawn Anastasio
Hi Julien, Thank you for the feedback. Most of your points will be addressed by following your suggestion of moving ARM's bootfdt.c to common, but I wanted to respond with a few points of clarification. On 12/1/23 5:23 PM, Julien Grall wrote: > * fdt_get_mem_rsv_paddr(), this is part of the DT is

Re: [PATCH 0/3] Early Boot Allocation on Power

2023-12-14 Thread Shawn Anastasio
Hi Jan, On 12/4/23 1:58 AM, Jan Beulich wrote: > A standalone patch with this title was sent earlier. What's their > interrelation? > I had intended to prefix this patch with 'RESEND' to clarify that it is the same as the one previously sent, but seem to have forgotten. My apologies! In any case

[PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk

2023-12-14 Thread Shawn Anastasio
Now that we have common code building, there's no need to keep the old itoa64+debug print function in mm-radix.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/mm-radix.c | 58 + 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/xen

[PATCH v2 3/7] xen/common: Move Arm's bootfdt to common

2023-12-14 Thread Shawn Anastasio
Move Arm's bootfdt.c to xen/common so that it can be used by other device tree architectures like PPC and RISCV. Only a minor change to conditionalize a call to a function only available on EFI-supporting targets was made to the code itself. Suggested-by: Julien Grall Signed-off-by:

[PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-14 Thread Shawn Anastasio
Introduce setup.h to asm-generic based off of ARM's to define all stubs necessary to compile bootfdt.c Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 + xen/arch/ppc/include/asm/setup.h | 6 -- xen/include/asm-generic/setup.h

[PATCH v2 7/7] xen/ppc: mm-radix: Allocate Partition and Process Tables at runtime

2023-12-14 Thread Shawn Anastasio
supported value (on POWER9). Also bump the number of static LVL2/3 PD frames to tolerate cases where the boot allocator returns an address outside of the range of the LVL2 frame used for Xen. Signed-off-by: Shawn Anastasio --- Changes in v2: - Bump LVL2/3 PD count to 3 to avoid running out in case the

[PATCH v2 5/7] xen/ppc: Enable bootfdt and boot allocator

2023-12-14 Thread Shawn Anastasio
erved memory region, as is the case on PPC when booted directly from skiboot. Also includes a minor change to record Xen's correct position on PPC where Xen relocates itself to at the entrypoint. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 - xen/arch/ppc/i

[PATCH v2 4/7] xen/device-tree: Fix bootfdt.c to tolerate 0 reserved regions

2023-12-14 Thread Shawn Anastasio
. Signed-off-by: Shawn Anastasio --- xen/common/device-tree/bootfdt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/device-tree/bootfdt.c b/xen/common/device-tree/bootfdt.c index ae9fa1e3d6..796ac01c18 100644 --- a/xen/common/device-tree/bootfdt.c +++ b/xen

[PATCH v2 0/7] Early Boot Allocation on Power

2023-12-14 Thread Shawn Anastasio
ables, instead of statically allocating them like was previously done. Among other things, switching to run-time allocation allows us to allocate a full-sized Process Table instead of the minimal one that was previously used to keep the Xen binary size small. Thanks, Shawn Shawn Anastasio (7): xe

[PATCH v2 1/7] xen/asm-generic: Introduce generic static-shmem.h

2023-12-14 Thread Shawn Anastasio
Introduce static-shmem.h to asm-generic as a prerequisite for moving ARM's bootfdt.c into xen/common. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/include/asm/Makefile | 1 + xen/include/asm-generic/static-shmem.h | 12 2 files changed, 13 insertions(+) create mode 1

Re: [PATCH v2 2/7] xen/asm-generic: Introduce generic setup.h

2023-12-20 Thread Shawn Anastasio
Hi Jan, On 12/20/23 5:09 AM, Jan Beulich wrote: > On 15.12.2023 03:43, Shawn Anastasio wrote: >> Introduce setup.h to asm-generic based off of ARM's to define all >> stubs necessary to compile bootfdt.c >> >> Signed-off-by: Shawn Anastasio >> --- >&

Re: [PATCH v2 3/7] xen/common: Move Arm's bootfdt to common

2023-12-20 Thread Shawn Anastasio
On 12/20/23 2:09 AM, Jan Beulich wrote: > On 19.12.2023 19:29, Julien Grall wrote: >> On 19/12/2023 17:03, Jan Beulich wrote: >>> On 15.12.2023 03:43, Shawn Anastasio wrote: >>>> --- a/xen/arch/arm/bootfdt.c >>>> +++ b/xen/common/device-tree/bootfdt.c &g

Re: [PATCH v3 07/34] xen/asm-generic: introdure nospec.h

2024-01-05 Thread Shawn Anastasio
Hi Oleksii, On 12/22/23 9:12 AM, Oleksii Kurochko wrote: > The header is similar between Arm, PPC, and RISC-V, > so it has been moved to asm-generic. > > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v6 7/9] xen: ifdef inclusion of in

2024-01-05 Thread Shawn Anastasio
h > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v6 8/9] xen/asm-generic: ifdef inclusion of

2024-01-05 Thread Shawn Anastasio
ctions from which > aren't available in case of !CONFIG_MEM_ACCESS. > > Suggested-by: Jan Beulich > Signed-off-by: Oleksii Kurochko Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v2] NUMA: no need for asm/numa.h when !NUMA

2024-01-08 Thread Shawn Anastasio
f asm/numa.h dependent upon NUMA=y. > > Drop the no longer applicable "implement NUMA support" comments - in a > !NUMA section this simply makes no sense. > > Signed-off-by: Jan Beulich Acked-by: Shawn Anastasio Thanks, Shawn

Re: [PATCH v2 4/7] xen/device-tree: Fix bootfdt.c to tolerate 0 reserved regions

2024-01-11 Thread Shawn Anastasio
Hi Julien On 1/9/24 12:14 PM, Julien Grall wrote: > (+ Stefano) > > Hi Shawn, > > On 15/12/2023 02:43, Shawn Anastasio wrote: >> The early_print_info routine in bootfdt.c incorrectly stores the result >> of a call to fdt_num_mem_rsv() in an unsigned int, which resul

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-11 Thread Shawn Anastasio
Hi Oleksii, On 12/22/23 9:13 AM, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - add SPDX > - drop unneeded for now p2m types. > - return false in all functions implemented with BUG() inside. > - update the commit message > --- > Changes in V2: > - Nothin

[PATCH v2] xen/arm: bootfdt: Harden handling of malformed mem reserve map

2024-01-11 Thread Shawn Anastasio
return code for an error and calling panic(). Signed-off-by: Shawn Anastasio --- v2: - panic() if the fdt_num_mem_rsv() call fails - Reword commit message to clarify that the error condition can only be triggered by a malformed device tree - Rebase to standalone patch instead of a part of

Re: [PATCH v2 5/7] xen/ppc: Enable bootfdt and boot allocator

2024-01-17 Thread Shawn Anastasio
Hi Julien, On 12/20/23 7:49 AM, Julien Grall wrote: > Hi, > > On 15/12/2023 02:44, Shawn Anastasio wrote: >> diff --git a/xen/common/device-tree/bootfdt.c >> b/xen/common/device-tree/bootfdt.c >> index 796ac01c18..7ddfcc7e2a 100644 >> --- a/xen/common/device-t

Re: [PATCH v2 6/7] xen/ppc: mm-radix: Replace debug printing code with printk

2024-01-17 Thread Shawn Anastasio
Hi Jan, On 12/20/23 5:48 AM, Jan Beulich wrote: > On 15.12.2023 03:44, Shawn Anastasio wrote: >> Now that we have common code building, there's no need to keep the old >> itoa64+debug print function in mm-radix.c >> >> Signed-off-by: Shawn Anastasio &g

Re: Ping: [PATCH v5 6/8] PPC: switch entry point annotations to common model

2024-01-22 Thread Shawn Anastasio
gt; > The other architectures have been at least partly switched; would be nice > for PPC to follow suit. May I ask for an ack (or otherwise here), please? > Sorry for the delay. Acked-by: Shawn Anastasio > Thanks, Jan Thanks, Shawn

Re: [PATCH] xen/*/asm-offset: Fix bad copy&paste from x86

2024-01-30 Thread Shawn Anastasio
u Monné > CC: Wei Liu > CC: Stefano Stabellini > CC: Julien Grall > CC: Volodymyr Babchuk > CC: Bertrand Marquis > CC: Michal Orzel > CC: Bob Eshleman > CC: Alistair Francis > CC: Connor Davis > CC: Shawn Anastasio > > Why does PPC have a local copy of ilo

Re: [PATCH v2 2/6] xen/ppc: address violations of MISRA C:2012 Rule 11.8.

2024-02-26 Thread Shawn Anastasio
Hi Stefano, Sorry for the delay on this. Acked-by: Shawn Anastasio Best, Shawn On 2/23/24 5:19 PM, Stefano Stabellini wrote: > Shawn, > > I am thinking of committing this, if you disagree please say something > in the next couple of days > > > On Tue, 19 Dec 2023,

Re: [PATCH v6 1/3] xen: introduce Kconfig function alignment option

2024-02-26 Thread Shawn Anastasio
Hi Roger, On 2/7/24 8:55 AM, Roger Pau Monne wrote: > And use it to replace CODE_ALIGN in assembly. This allows to generalize the > way the code alignment gets set across all architectures. > > No functional change intended. > > Signed-off-by: Roger Pau Monné Acked-b

Re: [PATCH v2] xen/lib: introduce generic find next bit operations

2024-02-27 Thread Shawn Anastasio
Hi Oleksii, On 2/20/24 9:20 AM, Oleksii wrote: > Hi Shawn, > > Could you please take a look at the patch and PPC-related changes ( > xen/arch/ppc/include/asm/bitops.h )? > Hi Oleksii, Sorry for the delay. This all looks good to me: Acked-by: Shawn Anastasio >

Re: [PATCH] xen/{RISCV,PPC}/xen.lds: Delete duplicate _erodata definitions

2024-03-05 Thread Shawn Anastasio
Hi Andrew, On 3/5/24 6:21 AM, Andrew Cooper wrote: > This is bad copy/paste from somewhere. Retain the second _erodata symbol, > which follows the Build ID, and matches the other architectures. > > No functional change. > > Signed-off-by: Andrew Cooper For the PPC part

Re: [PATCH v3 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

2023-08-22 Thread Shawn Anastasio
On 8/14/23 8:09 AM, Jan Beulich wrote: > On 10.08.2023 00:48, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/ppc64/head.S >> +++ b/xen/arch/ppc/ppc64/head.S >> @@ -17,6 +17,33 @@ ENTRY(start) >> addis %r2, %r12, .TOC.-1b@ha >> addi%r2, %r2, .TOC.-1

Re: [PATCH v3 3/3] xen/ppc: Implement initial Radix MMU support

2023-08-22 Thread Shawn Anastasio
On 8/14/23 8:27 AM, Jan Beulich wrote: > On 10.08.2023 00:48, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/page.h >> @@ -0,0 +1,181 @@ >> +#ifndef _ASM_PPC_PAGE_H >> +#define _ASM_PPC_PAGE_H >> + >> +#include >> + >

[PATCH v4 0/3] xen/ppc: Add early Radix MMU support

2023-08-22 Thread Shawn Anastasio
address is 0x0, we are able to run at the correct address both before and after the MMU is enabled. Additionally, as the Radix MMU was only added in ISA 3.0 (POWER9), this series also drops support for POWER8 for now, to avoid having a non-working build configuration in-tree. Thanks, Shawn Shawn

[PATCH v4 2/3] xen/ppc: Relocate kernel to physical address 0 on boot

2023-08-22 Thread Shawn Anastasio
start execution at XEN_VIRT_START after the copy since hardware will ignore the top 4 address bits when operating in Real Mode (MMU off). Signed-off-by: Shawn Anastasio --- v4: - Don't re-use stack pointer register (%r1) for non-stack-related purposes in head.S v3: no changes. v2:

[PATCH v4 1/3] xen/ppc: Bump minimum target ISA to 3.0 (POWER9)

2023-08-22 Thread Shawn Anastasio
In preparation for implementing ISA3+ Radix MMU support, drop ISA 2.07B from the supported ISA list to avoid having a non-working configuration in tree. It can be re-added at a later point when Hash MMU support is added. Signed-off-by: Shawn Anastasio --- v4: no changes. v3: no changes. v2: no

[PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-08-22 Thread Shawn Anastasio
Add code to construct early identity-mapped page tables as well as the required process and partition tables to enable the MMU. Signed-off-by: Shawn Anastasio --- v4: - (page.h) Drop *_SHIFT constants in page.h and include shift directly in corresponding *_MASK constant instead

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-08-23 Thread Shawn Anastasio
On 8/23/23 9:04 AM, Jan Beulich wrote: > On 23.08.2023 01:03, Shawn Anastasio wrote: >> Add code to construct early identity-mapped page tables as well as the >> required process and partition tables to enable the MMU. >> >> Signed-off-by: Shawn Anastasio > >

Re: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions

2023-08-23 Thread Shawn Anastasio
On 8/8/23 5:27 AM, Jan Beulich wrote: > On 03.08.2023 01:03, Shawn Anastasio wrote: >> --- a/xen/arch/ppc/mm-radix.c >> +++ b/xen/arch/ppc/mm-radix.c >> @@ -266,3 +266,47 @@ void __init setup_initial_pagetables(void) >> /* Turn on the MMU */ >> enable_mm

[PATCH v2 1/8] xen/common: Add missing #includes treewide

2023-08-23 Thread Shawn Anastasio
A few files treewide depend on defininitions in headers that they don't include. This works when arch headers end up including the required headers by chance, but broke on ppc64 with only minimal/stub arch headers. Signed-off-by: Shawn Anastasio --- v2: - (xen/domain.h) Drop include in

[PATCH v2 6/8] xen/ppc: Define bug frames table in linker script

2023-08-23 Thread Shawn Anastasio
Define the bug frames table in ppc's linker script as is done by other architectures. Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich --- v2: Add extra space to fix alignment of newly added lines xen/arch/ppc/xen.lds.S | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v2 3/8] xen/ppc: Implement atomic.h

2023-08-23 Thread Shawn Anastasio
Implement atomic.h for PPC, based off of the original Xen 3.2 implementation. Signed-off-by: Shawn Anastasio --- v2: - Fix style of asm block constraints to include required spaces - Fix macro local variable naming (use trailing underscore instead of leading) - Drop unnecessary parens

[PATCH v2 2/8] xen/ppc: Add public/arch-ppc.h

2023-08-23 Thread Shawn Anastasio
Signed-off-by: Shawn Anastasio --- v2: - Drop full license text in favor of SPDX header - Fix include guard naming (s/PPC64/PPC/g) - Use __aligned__ instead of aligned keyword - Fix macro naming conventions (use trailing underscore) - Drop unused MEMORY_PADDING, TRAP_INSTR definitions

[PATCH v2 0/8] ppc: Enable full Xen build

2023-08-23 Thread Shawn Anastasio
PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info() https://lists.xen.org/archives/html/xen-devel/2023-08/msg00887.html - [PATCH] move max_page and total_pages to common code https://lists.xen.org/archives/html/xen-devel/2023-08/msg00874.html Shawn Anastasio (8): xen/c

[PATCH v2 8/8] xen/ppc: Enable full Xen build

2023-08-23 Thread Shawn Anastasio
Bring ppc's Makefile and arch.mk in line with arm and x86 to disable the build overrides and enable the full Xen build. Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich --- xen/arch/ppc/Makefile | 16 +++- xen/arch/ppc/arch.mk | 3 --- 2 files changed, 15 insertions(

[PATCH v2 5/8] xen/ppc: Define minimal stub headers required for full build

2023-08-23 Thread Shawn Anastasio
Additionally, change inclusion of asm/ headers to corresponding xen/ ones throughout arch/ppc now that they work. Signed-off-by: Shawn Anastasio --- v2: - Use BUG_ON("unimplemented") instead of BUG() for unimplemented functions to make searching easier. - (altp2m.h) Drop Intel

[PATCH v2 7/8] xen/ppc: Add stub function and symbol definitions

2023-08-23 Thread Shawn Anastasio
Add stub function and symbol definitions required by common code. If the file that the definition is supposed to be located in doesn't already exist yet, temporarily place its definition in the new stubs.c Signed-off-by: Shawn Anastasio --- v2: - Use BUG_ON("unimplemented")

[PATCH v2 4/8] xen/ppc: Implement bitops.h

2023-08-23 Thread Shawn Anastasio
- PPC32-specific code paths dropped - Formatting completely re-done to more closely line up with Xen. Including 4 space indentation. Signed-off-by: Shawn Anastasio --- v2: - Clarify changes from Linux implementation in commit message - Use PPC_ATOMIC_{ENTRY,EXIT}_BARRIER macros from inst

Re: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions

2023-08-25 Thread Shawn Anastasio
On 8/25/23 4:10 AM, Jan Beulich wrote: > On 23.08.2023 20:39, Shawn Anastasio wrote: >> On 8/8/23 5:27 AM, Jan Beulich wrote: >>> On 03.08.2023 01:03, Shawn Anastasio wrote: >>>> +int map_pages_to_xen(unsigned long virt, >>>> + mfn_

Re: [PATCH v2 6/8] xen/ppc: Define bug frames table in linker script

2023-08-30 Thread Shawn Anastasio
On 8/30/23 8:03 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> Define the bug frames table in ppc's linker script as is done by other >> architectures. >> >> Signed-off-by: Shawn Anastasio >> Acked-by: Jan Beulich > > If I&

Re: [PATCH v2 3/8] xen/ppc: Implement atomic.h

2023-08-31 Thread Shawn Anastasio
On 8/29/23 8:43 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/atomic.h >> @@ -0,0 +1,390 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * PowerPC64 atomic operation

Re: [PATCH v2 3/8] xen/ppc: Implement atomic.h

2023-08-31 Thread Shawn Anastasio
On 8/31/23 12:47 PM, Shawn Anastasio wrote: > On 8/29/23 8:43 AM, Jan Beulich wrote: >> On 23.08.2023 22:07, Shawn Anastasio wrote: >>> +#de

Re: [PATCH v2 4/8] xen/ppc: Implement bitops.h

2023-08-31 Thread Shawn Anastasio
On 8/29/23 8:59 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> Implement bitops.h, based on Linux's implementation as of commit >> 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc. Though it is based off of >> Linux's implementation, this code diverg

Re: [PATCH v2 5/8] xen/ppc: Define minimal stub headers required for full build

2023-08-31 Thread Shawn Anastasio
On 8/30/23 5:49 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/altp2m.h >> @@ -0,0 +1,25 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +#ifndef __ASM_PPC_ALTP2M_H__ >> +#define

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-09-01 Thread Shawn Anastasio
On 8/23/23 12:36 PM, Shawn Anastasio wrote: > On 8/23/23 9:04 AM, Jan Beulich wrote: >> On 23.08.2023 01:03, Shawn Anastasio wrote: >>> Add code to construct early identity-mapped page tables as well as the >>> required process and partition tables to enable the MMU. &

[PATCH v3 4/5] xen/ppc: Add stub function and symbol definitions

2023-09-01 Thread Shawn Anastasio
Add stub function and symbol definitions required by common code. If the file that the definition is supposed to be located in doesn't already exist yet, temporarily place its definition in the new stubs.c Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich --- v3: - (stubs.c) Drop ack

[PATCH v3 0/5] ppc: Enable full Xen build

2023-09-01 Thread Shawn Anastasio
following patches are merged: - [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info() https://lists.xen.org/archives/html/xen-devel/2023-08/msg00887.html - [PATCH] move max_page and total_pages to common code https://lists.xen.org/archives/html/xen-devel/2023-08/msg00874.h

[PATCH v3 1/5] xen/ppc: Implement atomic.h

2023-09-01 Thread Shawn Anastasio
Implement atomic.h for PPC, based off of the original Xen 3.2 implementation. Signed-off-by: Shawn Anastasio --- v3: - Drop full copyright text headers - Drop unnecessary spaces after casts - const-ize write_atomic_size - Don't use GNU 0-length array extension in read_atomic - Us

[PATCH v3 2/5] xen/ppc: Implement bitops.h

2023-09-01 Thread Shawn Anastasio
- PPC32-specific code paths dropped - Formatting completely re-done to more closely line up with Xen. Including 4 space indentation. Signed-off-by: Shawn Anastasio --- v3: - Fix style of inline asm blocks. - Fix underscore-prefixed macro parameters/variables - Use __builtin_popcount f

[PATCH v3 5/5] xen/ppc: Enable full Xen build

2023-09-01 Thread Shawn Anastasio
Bring ppc's Makefile and arch.mk in line with arm and x86 to disable the build overrides and enable the full Xen build. Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich --- xen/arch/ppc/Makefile | 16 +++- xen/arch/ppc/arch.mk | 3 --- 2 files changed, 15 insertions(

[PATCH v3 3/5] xen/ppc: Define minimal stub headers required for full build

2023-09-01 Thread Shawn Anastasio
Additionally, change inclusion of asm/ headers to corresponding xen/ ones throughout arch/ppc now that they work. Signed-off-by: Shawn Anastasio --- v3: - Drop procarea.h - Add SPDX headers to all headers touched or added by this patch - (altp2m.h) Use ASSERT_UNREACHABLE for function that

Re: [PATCH v4 3/3] xen/ppc: Implement initial Radix MMU support

2023-09-05 Thread Shawn Anastasio
On 9/5/23 5:01 AM, Jan Beulich wrote: > On 23.08.2023 01:03, Shawn Anastasio wrote: >> Add code to construct early identity-mapped page tables as well as the >> required process and partition tables to enable the MMU. >> >> Signed-off-by: Shawn Anastasio > >

Re: [PATCH v3 0/5] ppc: Enable full Xen build

2023-09-05 Thread Shawn Anastasio
On 9/5/23 11:07 AM, Jan Beulich wrote: > On 01.09.2023 20:25, Shawn Anastasio wrote: >> Hello all, >> >> This patch series performs all of the additions necessary to drop the >> build overrides for PPC and enable the full Xen build. Except in cases >> where co

[PATCH 0/2] ppc: Drop support for QEMU pseries

2023-09-05 Thread Shawn Anastasio
version of QEMU than is available in the bullseye repository. Thanks, Shawn Shawn Anastasio (2): automation: Switch ppc64le tests to PowerNV machine type xen/ppc: Drop support for pseries/OpenFirmware .../build/debian/bullseye-ppc64le.dockerfile | 37 +- automation/gitlab-ci/test.yaml

[PATCH 2/2] xen/ppc: Drop support for pseries/OpenFirmware

2023-09-05 Thread Shawn Anastasio
Since QEMU's PowerNV support has matured to the point where it is now suitable for development, drop support for booting on the paravirtualized pseries machine type and its associated interfaces. Signed-off-by: Shawn Anastasio --- xen/arch/ppc/Makefile | 1 - xen/arch/ppc/boot

[PATCH 1/2] automation: Switch ppc64le tests to PowerNV machine type

2023-09-05 Thread Shawn Anastasio
Run ppc64le tests with the PowerNV machine type (bare metal) instead of the paravirtualized pseries machine. This requires a more modern version of QEMU than is present in debian bullseye's repository, so update the dockerfile to build QEMU from source. Signed-off-by: Shawn Anas

Re: [PATCH v3 0/5] ppc: Enable full Xen build

2023-09-05 Thread Shawn Anastasio
On 9/5/23 4:02 PM, Shawn Anastasio wrote: > On 9/5/23 11:07 AM, Jan Beulich wrote: >> On 01.09.2023 20:25, Shawn Anastasio wrote: >> Another thing I wanted to ask: Would it be possible to configure >> whatever mail client you use for sending patches to send plain ASCII or >

Re: [PATCH 2/2] xen/ppc: Drop support for pseries/OpenFirmware

2023-09-06 Thread Shawn Anastasio
On 9/6/23 1:44 AM, Jan Beulich wrote: > On 05.09.2023 23:46, Shawn Anastasio wrote: >> Since QEMU's PowerNV support has matured to the point where it is >> now suitable for development, drop support for booting on the >> paravirtualized pseries machine type and its ass

[PATCH v2 1/2] automation: Switch ppc64le tests to PowerNV machine type

2023-09-06 Thread Shawn Anastasio
roken by 74b725a64d80 ('xen/ppc: Implement initial Radix MMU support') which resulted in CI failures. In preparation for removing pseries support entirely, switch the CI infrastructure to the PowerNV machine type. Signed-off-by: Shawn Anastasio --- .../build/debian/bullseye-ppc64le.d

[PATCH v2 2/2] xen/ppc: Drop support for pseries/OpenFirmware

2023-09-06 Thread Shawn Anastasio
Radix MMU support'), and since there is little practical value in continuing to support pseries as a target, just drop support for it entirely. Signed-off-by: Shawn Anastasio Fixes: 74b725a64d80 ('xen/ppc: Implement initial Radix MMU support') --- xen/arch/ppc/Makefile | 1

[PATCH v2 0/2] ppc: Drop support for QEMU pseries

2023-09-06 Thread Shawn Anastasio
y. Thanks, Shawn -- v2: Add Fixes: tag to patch 2, add references to broken state of pseries Shawn Anastasio (2): automation: Switch ppc64le tests to PowerNV machine type xen/ppc: Drop support for pseries/OpenFirmware .../build/debian/bullseye-ppc64le.dockerfile | 37 +- automation

[PATCH v3 2/2] xen/ppc: Drop support for pseries/OpenFirmware

2023-09-07 Thread Shawn Anastasio
Radix MMU support'), and since there is little practical value in continuing to support pseries as a target, just drop support for it entirely. Fixes: 74b725a64d80 ('xen/ppc: Implement initial Radix MMU support') Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich --- xen/arch/ppc

[PATCH v3 1/2] automation: Switch ppc64le tests to PowerNV machine type

2023-09-07 Thread Shawn Anastasio
roken by 74b725a64d80 ('xen/ppc: Implement initial Radix MMU support') which resulted in CI failures. In preparation for removing pseries support entirely, switch the CI infrastructure to the PowerNV machine type. Signed-off-by: Shawn Anastasio --- v3: Use test-artifact for custom QEMU bu

[PATCH v3 0/2] ppc: Drop support for QEMU pseries

2023-09-07 Thread Shawn Anastasio
y. Thanks, Shawn -- v3: Build QEMU as test-artifact v2: Add Fixes: tag to patch 2, add references to broken state of pseries Shawn Anastasio (2): automation: Switch ppc64le tests to PowerNV machine type xen/ppc: Drop support for pseries/OpenFirmware .../build/debian/bullseye-ppc64le.dockerf

Re: [PATCH v3 1/5] xen/ppc: Implement atomic.h

2023-09-07 Thread Shawn Anastasio
On 9/5/23 9:58 AM, Jan Beulich wrote: > On 01.09.2023 20:25, Shawn Anastasio wrote: >> +static inline atomic_t atomic_compareandswap(atomic_t old, atomic_t new, >> + atomic_t *v) >> +{ >> +atomic_t rc; >> +r

Re: [PATCH v3 2/5] xen/ppc: Implement bitops.h

2023-09-07 Thread Shawn Anastasio
On 9/5/23 10:19 AM, Jan Beulich wrote: > On 01.09.2023 20:25, Shawn Anastasio wrote: >> Implement bitops.h, based on Linux's implementation as of commit >> 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc. Though it is based off of >> Linux's implementation, this code diverg

Re: [PATCH v2 1/2] automation: Switch ppc64le tests to PowerNV machine type

2023-09-08 Thread Shawn Anastasio
On 9/6/23 7:41 PM, Stefano Stabellini wrote: > On Wed, 6 Sep 2023, Shawn Anastasio wrote: >> Run ppc64le tests with the PowerNV machine type (bare metal) instead of >> the paravirtualized pseries machine. This requires a more modern version >> of QEMU than is present

Re: [PATCH v3 3/5] xen/ppc: Define minimal stub headers required for full build

2023-09-08 Thread Shawn Anastasio
On 9/5/23 10:52 AM, Jan Beulich wrote: > On 01.09.2023 20:25, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/device.h >> @@ -0,0 +1,53 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +#ifndef __ASM_PPC_DEVICE_H__ >> +#de

[PATCH v4 5/5] xen/ppc: Enable full Xen build

2023-09-08 Thread Shawn Anastasio
Bring ppc's Makefile and arch.mk in line with arm and x86 to disable the build overrides and enable the full Xen build. Signed-off-by: Shawn Anastasio Reviewed-by: Jan Beulich --- xen/arch/ppc/Makefile | 16 +++- xen/arch/ppc/arch.mk | 3 --- 2 files changed, 15 insertions(

[PATCH v4 4/5] xen/ppc: Add stub function and symbol definitions

2023-09-08 Thread Shawn Anastasio
Add stub function and symbol definitions required by common code. If the file that the definition is supposed to be located in doesn't already exist yet, temporarily place its definition in the new stubs.c Signed-off-by: Shawn Anastasio Acked-by: Jan Beulich --- v4: No changes

[PATCH v4 0/5] ppc: Enable full Xen build

2023-09-08 Thread Shawn Anastasio
drop (Arm) arch_dump_shared_mem_info() https://lists.xen.org/archives/html/xen-devel/2023-08/msg00887.html - [PATCH] move max_page and total_pages to common code https://lists.xen.org/archives/html/xen-devel/2023-08/msg00874.html Shawn Anastasio (5): xen/ppc: Implement atomic.h xen/ppc:

[PATCH v4 2/5] xen/ppc: Implement bitops.h

2023-09-08 Thread Shawn Anastasio
- PPC32-specific code paths dropped - Formatting completely re-done to more closely line up with Xen. Including 4 space indentation. - Use GCC's __builtin_popcount* for hweight* implementation Signed-off-by: Shawn Anastasio --- v4: - Mention __builtin_popcount impelmentation of hwei

[PATCH v4 1/5] xen/ppc: Implement atomic.h

2023-09-08 Thread Shawn Anastasio
Implement atomic.h for PPC, based off of the original Xen 3.2 implementation. This implementation depends on some functions that are not yet defined (notably __cmpxchg), so it can't yet be used. Signed-off-by: Shawn Anastasio --- v4: - Clarify dependency on __cmpxchg which doesn&

<    1   2   3   4   >