[PATCH v2] xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent

2022-04-20 Thread SeongJae Park
: SeongJae Park Signed-off-by: Maximilian Heyne Acked-by: Roger Pau Monné --- Changes from v1 (https://lore.kernel.org/xen-devel/20220301144628.2858-1...@kernel.org/) - Add Acked-by from Roger Documentation/ABI/testing/sysfs-driver-xen-blkback | 4 ++-- Documentation/ABI/testing/sysfs-driver-xen

[PATCH] xen-blk{back,front}: Update contact points for buffer_squeeze_duration_ms and feature_persistent

2022-03-01 Thread SeongJae Park
: SeongJae Park Signed-off-by: Maximilian Heyne --- Documentation/ABI/testing/sysfs-driver-xen-blkback | 4 ++-- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b

Re: “Backend has not unmapped grant” errors

2022-08-24 Thread SeongJae Park
Hello, On Wed, 24 Aug 2022 08:02:40 +0200 Juergen Gross wrote: > > [-- Attachment #1.1.1: Type: text/plain, Size: 4312 bytes --] > > On 24.08.22 02:20, Marek Marczykowski-Górecki wrote: > > FWIW, I hit this issue twice already in this week CI run, while it never > > happened before. The differ

Re: “Backend has not unmapped grant” errors

2022-08-24 Thread SeongJae Park
+ Roger On Wed, 24 Aug 2022 17:44:42 + SeongJae Park wrote: > Hello, > > On Wed, 24 Aug 2022 08:02:40 +0200 Juergen Gross wrote: > > > > > [-- Attachment #1.1.1: Type: text/plain, Size: 4312 bytes --] > > > > On 24.08.22 02:20, Marek Marczykowski-G

[PATCH 1/2] xen-blkback: Advertise feature-persistent as user requested

2022-08-25 Thread SeongJae Park
feature. [1] https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f...@suse.com/ Fixes: e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter when connect") Cc: # 5.10.x Reported-by: Marek Marczykowski-Górecki Suggested-by: Juergen Gross Si

[PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-25 Thread SeongJae Park
pport of the feature. [1] https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f...@suse.com/ Fixes: 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when connect") Cc: # 5.10.x Reported-by: Marek Marczykowski-Górecki Suggested-by: Juergen Gross Signed-

[PATCH 0/2] xen-blk{front,back}: Advertise feature-persistent as user requested

2022-08-25 Thread SeongJae Park
's support of the feature. [1] https://lore.kernel.org/xen-devel/bd818aba-4857-bc07-dc8a-e9b2f8c5f...@suse.com/ SeongJae Park (2): xen-blkback: Advertise feature-persistent as user requested xen-blkfront: Advertise feature-persistent as user requested drivers/block/xen-blkback/common.h

Re: “Backend has not unmapped grant” errors

2022-08-25 Thread SeongJae Park
Hi Juergen, Thank you for the quick and nice reply! On Thu, 25 Aug 2022 08:20:33 +0200 Juergen Gross wrote: > [...] > > Could you please send it as two proper patches (one for each driver) with > the correct "Fixes:" tags? Sure, just posted: https://lore.kernel.org/xen-devel/20220825161511.

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread SeongJae Park
Hi Max, On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote: > On Thu, Aug 25, 2022 at 04:15:11PM +0000, SeongJae Park wrote: > > > > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter > > when connect") made blkback t

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread SeongJae Park
On Fri, 26 Aug 2022 21:20:39 + SeongJae Park wrote: > Hi Max, > > On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote: > > > On Thu, Aug 25, 2022 at 04:15:11PM +0000, SeongJae Park wrote: > > > > > > Commit e94c6101e151 ("xen-blkback: Apply

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-26 Thread SeongJae Park
On Fri, 26 Aug 2022 21:20:39 + SeongJae Park wrote: > Hi Max, > > On Fri, 26 Aug 2022 14:26:58 + Maximilian Heyne wrote: > > > On Thu, Aug 25, 2022 at 04:15:11PM +0000, SeongJae Park wrote: > > > > > > Commit e94c6101e151 ("xen-blkback: Apply

Re: [PATCH 1/2] xen-blkback: Advertise feature-persistent as user requested

2022-08-31 Thread SeongJae Park
Hi Pratyush, On Wed, 31 Aug 2022 15:47:50 + Pratyush Yadav wrote: > Hi, > > On 25/08/22 04:15PM, SeongJae Park wrote: > > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter > > when connect") made blkback to advertise its sup

Re: [PATCH 2/2] xen-blkfront: Advertise feature-persistent as user requested

2022-08-31 Thread SeongJae Park
Hi Pratyush, On Wed, 31 Aug 2022 15:50:45 + Pratyush Yadav wrote: > On 25/08/22 04:15PM, SeongJae Park wrote: > > Commit e94c6101e151 ("xen-blkback: Apply 'feature_persistent' parameter > > when connect") made blkback to advertise its support of the persis

[PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent

2022-08-31 Thread SeongJae Park
This patchset fixes misuse of the 'feature-persistent' advertisement semantic (patches 1 and 2), and the wrong timing of the 'feature_persistent' value caching, which made persistent grants feature always disabled. SeongJae Park (3): xen-blkback: Advertise feature-persistent as user r

[PATCH v2 1/3] xen-blkback: Advertise feature-persistent as user requested

2022-08-31 Thread SeongJae Park
commit fixes the misuse of the semantic by making blkback saves the parameter value in a separate place and advertises the support based on only the saved value. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Suggested-by: Jue

[PATCH v2 2/3] xen-blkfront: Advertise feature-persistent as user requested

2022-08-31 Thread SeongJae Park
commit fixes the misuse of the semantic by making blkfront saves the parameter value in a separate place and advertises the support based on only the saved value. Fixes: 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent grants") Cc: # 5.10.x Suggested-by: Jue

[PATCH v2 3/3] xen-blkfront: Cache feature_persistent value before advertisement

2022-08-31 Thread SeongJae Park
that the persistent grants feature becomes always disabled. This commit fixes the issue by making the blkfront does parmeter caching just before the advertisement. Fixes: 402c43ea6b34 ("xen-blkfront: Apply 'feature_persistent' parameter when connect") Cc: # 5.10.x Reported-by:

Re: [PATCH v2 0/3] xen-blk{front,back}: Fix the broken semantic and flow of feature-persistent

2022-08-31 Thread SeongJae Park
On Wed, 31 Aug 2022 16:58:21 + SeongJae Park wrote: > Changes from v1 > (https://lore.kernel.org/xen-devel/20220825161511.94922-1...@kernel.org/) > - Fix the wrong feature_persistent caching position of blkfront > - Set blkfront's feature_persistent field setting with simple

[PATCH for-stable-5.10.y] xen-blkfront: Cache feature_persistent value before advertisement

2022-09-06 Thread SeongJae Park
' parameter when connect") Cc: # 5.10.x Reported-by: Marek Marczykowski-Górecki Signed-off-by: SeongJae Park Tested-by: Marek Marczykowski-Górecki Reviewed-by: Juergen Gross Link: https://lore.kernel.org/r/20220831165824.94815-4...@kernel.org Signed-off-by: Juergen Gross --- This

[PATCH v2] xen-blkback: fix persistent grants negotiation

2022-07-14 Thread SeongJae Park
y 'connect_ring()' later, this should be called before 'connect_ring()' and therefore this should be the right and safe place to do the caching. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-o

Re: [PATCH v2] xen-blkback: fix persistent grants negotiation

2022-07-15 Thread SeongJae Park
l.org/xen-devel/20220121102309.27802-1...@kernel.org/ Thanks, SJ > > [1] > https://lore.kernel.org/xen-devel/20220106091013.126076-1-mhe...@amazon.de/ > [2] https://lore.kernel.org/xen-devel/20220714224410.51147-1...@kernel.org/ > > Best regards, > Andrii > > On Fri, Jul

[PATCH 2/2] xen-blkfront: Apply 'feature_persistent' parameter when connect

2022-07-15 Thread SeongJae Park
any confusion due to inconsistent behavior of same-named parameters. Cc: # 5.10.x Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- drivers/block/xen-blkfront.c| 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v3 0/2] Fix persistent grants negotiation with a behavior change

2022-07-15 Thread SeongJae Park
el.org/xen-devel/20220106091013.126076-1-mhe...@amazon.de/) - Avoid the behavioral change (https://lore.kernel.org/xen-devel/20220121102309.27802-1...@kernel.org/) - Rebase on latest xen/tip/linux-next - Re-work by SeongJae Park - Cc stable@ Maximilian Heyne (1): xen, blkback: fix persist

[PATCH 1/2] xen, blkback: fix persistent grants negotiation

2022-07-15 Thread SeongJae Park
dates the document. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: Maximilian Heyne Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +- drivers/block/xen-blkback/xenbus.c

Re: [PATCH v3 0/2] Fix persistent grants negotiation with a behavior change

2022-07-15 Thread SeongJae Park
Hi all, On Fri, 15 Jul 2022 17:55:19 + SeongJae Park wrote: > The first patch of this patchset fixes 'feature_persistent' parameter > handling in 'blkback' to respect the frontend's persistent grants > support always. The fix makes a behavioral chang

Re: [PATCH v3 0/2] Fix persistent grants negotiation with a behavior change

2022-07-15 Thread SeongJae Park
Hi all, On Fri, 15 Jul 2022 18:12:26 + SeongJae Park wrote: > Hi all, > > On Fri, 15 Jul 2022 17:55:19 + SeongJae Park wrote: > > > The first patch of this patchset fixes 'feature_persistent' parameter > > handling in 'blkback' to respect

[PATCH v4 2/3] xen-blkback: Apply 'feature_persistent' parameter when connect

2022-07-15 Thread SeongJae Park
ct, so that the previous workflow can work again as expected. [1] https://lore.kernel.org/xen-devel/CAJwUmVB6H3iTs-C+U=v-pwJB7-_ZRHPxHzKRJZ22xEPW7z8a=g...@mail.gmail.com/ Reported-by: Andrii Chepurnyi Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")

[PATCH v4 3/3] xen-blkfront: Apply 'feature_persistent' parameter when connect

2022-07-15 Thread SeongJae Park
g...@mail.gmail.com/ Fixes: 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- drivers/block/xen-blkfront.c| 4 +--- 2 fil

[PATCH v4 1/3] xen-blkback: fix persistent grants negotiation

2022-07-15 Thread SeongJae Park
y 'connect_ring()' later, this should be called before 'connect_ring()' and therefore this should be the right and safe place to do the caching. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: Maximili

[PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent'

2022-07-15 Thread SeongJae Park
-mhe...@amazon.de/) - Avoid the behavioral change (https://lore.kernel.org/xen-devel/20220121102309.27802-1...@kernel.org/) - Rebase on latest xen/tip/linux-next - Re-work by SeongJae Park - Cc stable@ Maximilian Heyne (1): xen-blkback: Apply 'feature_persistent' parameter when connect

Re: [PATCH linux-next] drivers/xen/xenbus/xenbus_client.c: fix bugon.cocci warnings

2021-08-24 Thread SeongJae Park
From: SeongJae Park On Tue, 24 Aug 2021 23:24:51 -0700 CGEL wrote: > From: Jing Yangyang > > Use BUG_ON instead of a if condition followed by BUG. > > Generated by: scripts/coccinelle/misc/bugon.cocci > > Reported-by: Zeal Robot > Signed-off-by: Jing Yangyang Re

Re: [PATCH] xen, blkback: fix persistent grants negotiation

2022-01-06 Thread SeongJae Park
From: SeongJae Park On Thu, 6 Jan 2022 09:10:13 + Maximilian Heyne wrote: > Given dom0 supports persistent grants but the guest does not. > Then, when attaching a block device during runtime of the guest, dom0 > will enable persistent grants for this newly attached blo

Re: [PATCH] xen, blkback: fix persistent grants negotiation

2022-01-21 Thread SeongJae Park
On Tue, 11 Jan 2022 13:26:50 +0100 "Roger Pau Monné" wrote: > On Tue, Jan 11, 2022 at 11:50:32AM +, Durrant, Paul wrote: > > On 11/01/2022 11:11, Roger Pau Monné wrote: > > > On Thu, Jan 06, 2022 at 09:10:13AM +, Maximilian Heyne wrote: > > > > Given dom0 supports persistent grants but t

[PATCH] xen/xenbus: document will_handle argument for xenbus_watch_path()

2024-01-12 Thread SeongJae Park
warnings that reported by kernel test robot. Add the documentation to fix it. Fixes: 2e85d32b1c86 ("xen/xenbus: Add 'will_handle' callback support in xenbus_watch_path()") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202401121154.fi8jdgu

<    1   2