Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Roman Gushchin
On Thu, Sep 01, 2022 at 06:37:20PM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 03:27:27PM -0700, Roman Gushchin wrote: > > On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > > > This is very interesting work! Do you have any data about the overhead >

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Roman Gushchin
On Wed, Aug 31, 2022 at 01:56:08PM -0700, Yosry Ahmed wrote: > On Wed, Aug 31, 2022 at 12:02 PM Kent Overstreet > wrote: > > > > On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: > > > On Wed 31-08-22 11:19:48, Mel Gorman wrote: > > > > Whatever asking for an explanation as to why equi

Re: [RFC PATCH 14/30] mm: prevent slabobj_ext allocations for slabobj_ext and kmem_cache objects

2022-09-01 Thread Roman Gushchin
On Tue, Aug 30, 2022 at 02:49:03PM -0700, Suren Baghdasaryan wrote: > Use __GFP_NO_OBJ_EXT to prevent recursions when allocating slabobj_ext > objects. Also prevent slabobj_ext allocations for kmem_cache objects. > > Signed-off-by: Suren Baghdasaryan Patches 12-14 look good to me. It's probably

Re: [RFC PATCH 16/30] mm: enable slab allocation tagging for kmalloc and friends

2022-09-01 Thread Roman Gushchin
On Tue, Aug 30, 2022 at 02:49:05PM -0700, Suren Baghdasaryan wrote: > Redefine kmalloc, krealloc, kzalloc, kcalloc, etc. to record allocations > and deallocations done by these functions. One particular case when this functionality might be very useful: in the past we've seen examples (at Fb) wher

Re: [RFC PATCH 00/30] Code tagging framework and applications

2022-09-01 Thread Roman Gushchin
On Thu, Sep 01, 2022 at 08:17:47PM -0400, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 03:53:57PM -0700, Roman Gushchin wrote: > > I'd suggest to run something like iperf on a fast hardware. And maybe some > > io_uring stuff too. These are two places which were historically

Re: [RFC PATCH 11/30] mm: introduce slabobj_ext to support slab object extensions

2022-09-01 Thread Roman Gushchin
On Tue, Aug 30, 2022 at 02:49:00PM -0700, Suren Baghdasaryan wrote: > Currently slab pages can store only vectors of obj_cgroup pointers in > page->memcg_data. Introduce slabobj_ext structure to allow more data > to be stored for each slab object. Wraps obj_cgroup into slabobj_ext > to support curr