On 8/7/19 3:22 AM, Paolo Bonzini wrote:
> On 07/08/19 10:32, tony.ngu...@bt.com wrote:
>> +#if defined(HOST_WORDS_BIGENDIAN)
>> + .endianness = MO_BE,
>> +#else
>> + .endianness = MO_LE,
>> +#endif
>
> Host endianness is just 0, isn't it?
Yes. Just leaving a comment to that effect here for
ot; operand into a "MemOp op".
> + */
> +return size;
> +}
> +
Return type should remain unsigned until patch 11.
Otherwise,
Reviewed-by: Richard Henderson
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
tlb.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
9 +
> memory.c | 7 +--
> 3 files changed, 23 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson
> +/* MemOp to size in bytes. */
> +static inline unsigned memop_size(MemOp op)
> +{
> +return 1 << ((op) & MO_SIZE);
&
ith
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
>
> Signed-off-by: Tony Nguyen
> ---
> target/mips/op_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
___
ith
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
>
> Signed-off-by: Tony Nguyen
> ---
> hw/s390x/s390-pci-inst.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
___
ith
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
>
> Signed-off-by: Tony Nguyen
> ---
> memory_ldst.inc.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson
r~
___
2 files changed, 13 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote:
> + &serial_mm_ops[end == DEVICE_LITTLE_ENDIAN ? 0 :
> 1],
This is of course "end != DEVICE_LITTLE_ENDIAN".
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lis
On 8/7/19 8:59 AM, Richard Henderson wrote:
> On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote:
>> + &serial_mm_ops[end == DEVICE_LITTLE_ENDIAN ? 0 :
>> 1],
>
> This is of course "end != DEVICE_LITTLE_ENDIAN".
And by th
On 8/7/19 1:31 AM, tony.ngu...@bt.com wrote:
> Simplify endianness comparisons with consistent use of the more
> expressive MemOp.
>
> Suggested-by: Richard Henderson
> Signed-off-by: Tony Nguyen ---
Reviewed-by: Richard Henderson
r~
On 8/7/19 1:32 AM, tony.ngu...@bt.com wrote:
> device_endian has been made redundant by MemOp.
>
> Signed-off-by: Tony Nguyen
> ---
> include/exec/cpu-common.h | 8
> 1 file changed, 8 deletions(-)
Reviewed-by: Rich
On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote:
> @@ -1246,7 +1246,7 @@ typedef uint64_t FullLoadHelper(CPUArchState *env,
> target_ulong addr,
>
> static inline uint64_t __attribute__((always_inline))
> load_helper(CPUArchState *env, target_ulong addr, TCGMemOpIdx oi,
> -uintptr_t ret
On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote:
> @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy,
> hwaddr addr,
> /* As length is under guest control, handle illegal values. */
> return;
> }
> +/* FIXME: memory_region_dispatch_write ignores MO_BS
On 8/7/19 11:00 AM, Paolo Bonzini wrote:
> On 07/08/19 19:49, Richard Henderson wrote:
>> On 8/7/19 1:33 AM, tony.ngu...@bt.com wrote:
>>> @@ -551,6 +551,7 @@ void virtio_address_space_write(VirtIOPCIProxy *proxy,
>>> hwaddr addr,
>>> /* As length is
On 8/16/19 7:28 AM, tony.ngu...@bt.com wrote:
> Tony Nguyen (42):
> configure: Define TARGET_ALIGNED_ONLY in configure
> tcg: TCGMemOp is now accelerator independent MemOp
> memory: Introduce size_memop
> target/mips: Access MemoryRegion with MemOp
> hw/s390x: Access MemoryRegion with Mem
On 8/16/19 8:38 AM, tony.ngu...@bt.com wrote:
> Preparation for collapsing the two byte swaps adjust_endianness and
> handle_bswap into the former.
>
> Call memory_region_dispatch_{read|write} with endianness encoded into
> the "MemOp op" operand.
>
> This patch does not change any behaviour as
>
dr, val, oi, retaddr, 1, false);
> +store_helper(env, addr, val, oi, retaddr, MO_8);
> }
MO_UB.
Otherwise,
Reviewed-by: Richard Henderson
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 8/16/19 8:38 AM, tony.ngu...@bt.com wrote:
> +static void adjust_endianness(MemoryRegion *mr, uint64_t *data, MemOp op)
> {
> +if ((op & MO_BSWAP) != mr->ops->endianness) {
> +switch (op & MO_SIZE) {
You'll want to use devend_memop() here, as previously discussed.
> @@ -2331,7 +23
On 8/19/19 11:29 AM, Paolo Bonzini wrote:
> On 19/08/19 20:28, Paolo Bonzini wrote:
>> On 16/08/19 12:12, Thomas Huth wrote:
>>> This patch is *huge*, more than 800kB. It keeps being stuck in the the
>>> filter of the qemu-s390x list each time you send it. Please:
>>>
>>> 1) Try to break it up in m
On 12/13/18 4:37 PM, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
Acked-by: Richard Henderson
r~
___
Xen-devel mailing lis
On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote:
> xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename
> \"%s\","
> - " size %" PRId64 " (%" PRId64 " MB)\n",
> + " size %" PRId64 " (%llu MB)\n",
>blkdev->type, blkdev->fi
On 06/12/2018 11:04 AM, Eric Blake wrote:
> On 06/12/2018 03:51 PM, Richard Henderson wrote:
>> On 06/10/2018 03:14 PM, Philippe Mathieu-Daudé wrote:
>>> xen_pv_printf(xendev, 1, "type \"%s\", fileproto \"%s\", filename
>>> \"%s\&quo
On 06/13/2018 02:13 AM, Eric Blake wrote:
> Or spell it UINT64_C(1) if you don't want a cast.
Not unsigned is what I want most.
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 9/20/20 4:44 AM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (2):
> qdev: Document qbus_realize() and qbus_unrealize()
> qdev: Let BusRealize() return a boolean value to indicate error
Reviewed-by: Richard Henderson
r~
ove unnecessary CPU() cast
> various: Remove unnecessary OBJECT() cast
> hw: Remove unnecessary DEVICE() cast
Reviewed-by: Richard Henderson
r~
peter.mayd...@linaro.org>
Reviewed-by: Richard Henderson
r~
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
On 2/18/20 10:59 AM, Stefan Weil wrote:
> Personally I like the way how the standard C library handles such
> pointers for functions like memcpy, fread, fwrite and others.
>
> Therefore I suggest to use `const void *` and `void *` and to avoid type
> casts.
Seconded.
r~
__
0bfff (prio 0, ram): ram
> c000- (prio 0, i/o): max_ram
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/arm/aspeed.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
ippe Mathieu-Daudé
> ---
> hw/pci-host/prep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
eu-Daudé
> ---
> hw/pci/pci_bridge.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
pci-host/versatile.c | 5 +++--
> 3 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/pci/pci_bridge.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/xen/xen-hvm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/hppa/dino.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
On 6/1/20 7:29 AM, Philippe Mathieu-Daudé wrote:
> IEC binary prefixes ease code review: the unit is explicit.
>
> Reviewed-by: Peter Maydell
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
On 11/1/21 6:08 PM, Juan Quintela wrote:
The following changes since commit af531756d25541a1b3b3d9a14e72e7fedd941a2e:
Merge remote-tracking branch 'remotes/philmd/tags/renesas-20211030' into
staging (2021-10-30 11:31:41 -0700)
are available in the Git repository at:
https://github.com/j
On 2/27/23 10:12, Michael S. Tsirkin wrote:
On Mon, Feb 27, 2023 at 11:50:07AM +, Daniel P. Berrangé wrote:
I feel like we should have separate deprecation entries for the
i686 host support, and for qemu-system-i386 emulator binary, as
although they're related they are independant features w
On 2/27/23 01:50, Daniel P. Berrangé wrote:
On Mon, Feb 27, 2023 at 12:10:49PM +0100, Thomas Huth wrote:
Hardly anybody still uses 32-bit x86 hosts today, so we should
start deprecating them to finally have less test efforts.
With regards to 32-bit KVM support in the x86 Linux kernel,
the develo
On 2/27/23 23:00, Michael S. Tsirkin wrote:
On Mon, Feb 27, 2023 at 10:21:14AM -1000, Richard Henderson wrote:
Removing support for building on 32 bit systems seems like a pity - it's
one of a small number of ways to run 64 bit binaries on 32 bit systems,
and the maintainance overhead is
On 6/10/22 02:20, Gerd Hoffmann wrote:
The following changes since commit 9cc1bf1ebca550f8d90f967ccd2b6d2e00e81387:
Merge tag 'pull-xen-20220609' of
https://xenbits.xen.org/git-http/people/aperard/qemu-dm into staging
(2022-06-09 08:25:17 -0700)
are available in the Git repository at:
On 6/13/22 04:36, Gerd Hoffmann wrote:
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac:
Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging
(2022-06-11 21:13:27 -0700)
are available in the Git repository at:
git://git.kraxel.org/qemu tags
On 6/13/22 08:52, Richard Henderson wrote:
On 6/13/22 04:36, Gerd Hoffmann wrote:
The following changes since commit dcb40541ebca7ec98a14d461593b3cd7282b4fac:
Merge tag 'mips-20220611' of https://github.com/philmd/qemu into staging (2022-06-11
21:13:27 -0700)
are available
On 6/14/22 05:15, Gerd Hoffmann wrote:
The following changes since commit debd0753663bc89c86f5462a53268f2e3f680f60:
Merge tag 'pull-testing-next-140622-1' of https://github.com/stsquad/qemu
into staging (2022-06-13 21:10:57 -0700)
are available in the Git repository at:
git://git.kraxel
On 3/6/23 00:46, Thomas Huth wrote:
+continuous to be supported on 32-bit arm hosts, too)
"continues"
Acked-by: Richard Henderson
r~
/nvmm.h | 2 ++
include/sysemu/tcg.h | 2 ++
include/sysemu/whpx.h | 2 ++
include/sysemu/xen.h | 2 ++
6 files changed, 12 insertions(+)
Acked-by: Richard Henderson
r~
| 3 ---
3 files changed, 10 deletions(-)
Reviewed-by: Richard Henderson
r~
insertions(+)
Reviewed-by: Richard Henderson
r~
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
All accelerators will share a single opaque context
in CPUState. Start by renaming 'hax_vcpu' as 'accelCPUState'.
Pasto in 'accel' here.
Reviewed-by: Richard Henderson
r~
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
We want all accelerators to share the same opaque pointer in
CPUState. Start with the HAX context, renaming its forward
declarated structure 'hax_vcpu_state' as 'AccelvCPUState'.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h
-accel-ops.c | 2 +-
target/i386/hax/hax-all.c | 2 +-
target/i386/hax/hax-windows.c | 2 +-
5 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
+struct AccelvCPUState;
Missing typedef?
r~
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
-struct qemu_vcpu *qcpu = get_qemu_vcpu(cpu);
+struct AccelvCPUState *qcpu = get_qemu_vcpu(cpu);
With the typedef in hw/core/cpu.h, you can drop the 'struct' at the same time.
Otherwise,
Reviewed-by: Richard Henderson
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
No need for this helper to access the CPUState::accel field.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/nvmm/nvmm-all.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
Reviewed-by: Richard
cpu)
+static struct AccelvCPUState *get_whpx_vcpu(CPUState *cpu)
{
-return (struct whpx_vcpu *)cpu->accel;
+return (struct AccelvCPUState *)cpu->accel;
Same comment about removing 'struct'.
Reviewed-by: Richard Henderson
-vcpu = g_new0(struct whpx_vcpu, 1);
+vc
On 4/5/23 03:18, Philippe Mathieu-Daudé wrote:
No need for this helper to access the CPUState::accel field.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/whpx/whpx-all.c | 29 ++---
1 file changed, 10 insertions(+), 19 deletions(-)
Reviewed-by: Richard
0() by g_new0() for readability.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 3 --
include/sysemu/hvf_int.h | 2 +-
accel/hvf/hvf-accel-ops.c | 16 -
target/arm/hvf/hvf.c | 70 +++
4 files changed, 44 insertions(+)
| 3 +++
target/i386/hax/hax-all.c | 1 +
2 files changed, 4 insertions(+)
Reviewed-by: Richard Henderson
r~
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote:
|+ struct AccelvCPUState *accel;|
...
+typedef struct AccelCPUState {
hax_fd fd;
int vcpu_id;
struct hax_tunnel *tunnel;
unsigned char *iobuf;
-};
+} hax_vcpu_state;
Discussed face to face, but for the record:
Put the typed
1 file changed, 4 deletions(-)
Reviewed-by: Richard Henderson
r~
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote:
g_new0() can not fail. Remove the unreachable error path.
https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description
Reported-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Daudé
I would have chosen 'cs', since 'cpu' is often used for ArchCPU. But ok.
Acked-by: Richard Henderson
r~
target/i386/hax/hax-posix.c | 4 ++--
target/i386/hax/hax-windows.c | 4 ++--
target/i386/nvmm/nvmm-all.c | 2 +-
target/i386/whpx/whpx-all.c | 2 +-
8 files changed, 22 insertions(+), 21 deletions(-)
Reviewed-by: Richard Henderson
r~
: Richard Henderson
r~
arch_hvm.h | 4 ++--
hw/arm/xen_arm.c | 4 ++--
hw/i386/xen/xen-hvm.c | 6 +++---
hw/xen/xen-hvm-common.c| 4 ++--
5 files changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Richard Henderson
r~
iles changed, 6 insertions(+), 28 deletions(-)
delete mode 100644 include/hw/arm/xen_arch_hvm.h
delete mode 100644 include/hw/i386/xen_arch_hvm.h
delete mode 100644 include/hw/xen/arch_hvm.h
Reviewed-by: Richard Henderson
r~
On 11/13/23 07:21, Philippe Mathieu-Daudé wrote:
diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c
index c028c1b541..03f9417e7e 100644
--- a/hw/xen/xen-hvm-common.c
+++ b/hw/xen/xen-hvm-common.c
@@ -426,10 +426,7 @@ static void handle_ioreq(XenIOState *state, ioreq_t *req)
trac
(-)
Reviewed-by: Richard Henderson
r~
-common.h" *common* header.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 1 -
hw/arm/xen_arm.c| 1 +
hw/i386/xen/xen-hvm.c | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
+#ifndef CONFIG_USER_ONLY
static inline bool cpu_handle_halt(CPUState *cpu)
{
Hmm, slightly better to move the ifdef just inside here,
@@ -607,6 +608,7 @@ static inline bool cpu_handle_halt(CPUState *cpu)
and here,
return false
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
cpu_has_work() is only called from system emulation code.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h | 32
1 file changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Richard Henderson
changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
r~
(+)
Reviewed-by: Richard Henderson
r~
+-
2 files changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
-accel-ops.c | 6 ++
2 files changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Richard Henderson
r~
| 12
2 files changed, 16 insertions(+)
Reviewed-by: Richard Henderson
r~
alpha; it's always true.
Otherwise,
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/arm/cpu.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
e *cs)
No CONFIG_TCG or CONFIG_USER_ONLY test for avr.
Otherwise,
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
+#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
static bool cris_cpu_has_work(CPUState *cs)
No CONFIG_TCG for cris. Otherwise,
Reviewed-by: Richard Henderson
r~
(-)
Reviewed-by: Richard Henderson
r~
s)
No CONFIG_TCG, otherwise
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/i386/cpu.c | 6 --
target/i386/tcg/tcg-cpu.c | 8 +++-
2 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson
r~
Reviewed-by: Richard Henderson
r~
u_has_work(CPUState *cs)
No CONFIG_TCG, otherwise,
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/mips/cpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
, otherwise,
Reviewed-by: Richard Henderson
r~
e *cs)
No CONFIG_TCG, otherwise,
Reviewed-by: Richard Henderson
r~
On 9/3/21 10:34 PM, Philippe Mathieu-Daudé wrote:
Drop CONFIG_TCG for alpha; it's always true.
What is the rational? "Old" architectures (with no active /
official hw development) are unlikely to add hardware
acceleration, so TCG is the single one possible? Thus no
need to clutter the code with
On 9/3/21 2:50 AM, David Gibson wrote:
On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daudé wrote:
Each POWER cpu has its own has_work() implementation. Instead of
overloading CPUClass on each PowerPCCPUClass init, register the
generic ppc_cpu_has_work() handler, and have it call the
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
The common ppc_cpu_has_work() handler already checks for cs->halted,
so we can simplify all callees.
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/cpu_init.c | 294 --
1 file changed, 138 insertion
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/riscv/cpu.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote:
Restrict has_work() to TCG sysemu.
Signed-off-by: Philippe Mathieu-Daudé
---
target/ppc/cpu_init.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson
r~
/target/rx/cpu.c
+++ b/target/rx/cpu.c
@@ -41,11 +41,13 @@ static void rx_cpu_synchronize_from_tb(CPUState *cs,
cpu->env.pc = tb->pc;
}
+#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY)
static bool rx_cpu_has_work(CPUState *cs)
No CONFIG_TCG, otherwise,
Review
w/core/cpu-common.c | 6 --
softmmu/cpus.c| 9 ++---
target/i386/hax/hax-accel-ops.c | 6 ++
target/i386/nvmm/nvmm-accel-ops.c | 6 ++
8 files changed, 32 insertions(+), 15 deletions(-)
Reviewed-by: Richard Henderson
r~
On 9/11/21 3:31 PM, Philippe Mathieu-Daudé wrote:
On 9/3/21 11:11 PM, Philippe Mathieu-Daudé wrote:
On 9/3/21 10:42 PM, Richard Henderson wrote:
On 9/3/21 2:50 AM, David Gibson wrote:
On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daudé wrote:
Each POWER cpu has its own has_work
On 8/31/23 06:25, Markus Armbruster wrote:
+#define PASTE(a, b) a##b
We already have glue() in qemu/compiler.h.
The rest of it looks quite sensible.
r~
On 2/26/21 8:40 AM, Philippe Mathieu-Daudé wrote:
> +++ b/include/hw/core/cpu-system-ops.h
> @@ -0,0 +1,89 @@
> +/*
> + * CPU operations specific to system emulation
> + *
> + * Copyright (c) 2012 SUSE LINUX Products GmbH
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 o
On 12/16/24 00:14, CLEMENT MATHIEU--DRIF wrote:
Hi Rihard.
Good idea, LGTM.
Just out of curiosity, what was the motivation for such a patch?
It it simply about cleaning the code or is it intended to solve a deeper
problem.
Simply cleaning the code, prompted by a change to core QAPI code for R
On 12/17/24 09:13, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (3):
hw/xen: Remove unnecessary 'exec/cpu-common.h' header
system/numa: Remove unnecessary 'exec/cpu-common.h' header
system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header
1 - 100 of 131 matches
Mail list logo
