Re: [PATCH 0/4] xen/arm: Unbreak ACPI

2020-09-29 Thread Rahul Singh
Hello, > On 26 Sep 2020, at 9:55 pm, Julien Grall wrote: > > From: Julien Grall > > Hi all, > > Xen on ARM has been broken for quite a while on ACPI systems. This > series aims to fix it. We also observed the panic after enabling the ACPI for ARM N1SDP board earlier. (XEN) Xen call trace: (

Re: [PATCH 1/4] xen/acpi: Rework acpi_os_map_memory() and acpi_os_unmap_memory()

2020-09-29 Thread Rahul Singh
he arch-helper for unmap is basically a no-op so it only > returns whether the mapping was arch specific. But this will change > in the future. > > Note that the x86 version of acpi_os_map_memory() was already able to > able the 1MB region. Hence why there is no addition of new code.

Re: [PATCH 2/4] xen/arm: acpi: The fixmap area should always be cleared during failure/unmap

2020-09-29 Thread Rahul Singh
ping whether the fixmap region is big >enough for the mapping. >- It will fail if the fixmap is always inuse. > > The function __acpi_os_unmap_table() will now call clear_fixmap(). > > Reported-by: Wei Xu > Signed-off-by: Julien Grall Reviewed-by: Rahul Singh Tested-by: R

Re: [PATCH 3/4] xen/arm: Check if the platform is not using ACPI before initializing Dom0less

2020-09-29 Thread Rahul Singh
when using ACPI. > > This will lead to a crash during boot. > > Given the complexity to setup dom0less with ACPI (for instance how to > assign device?), we should skip any code related to Dom0less when using > ACPI. > > Signed-off-by: Julien Grall Reviewed-by: Rahul Sing

[XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-20 Thread Rahul Singh
dated. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/Kconfig | 10 + xen/drivers/passthrough/arm/Makefile |1 + xen/drivers/passthrough/arm/smmu-v3.c | 2847 + 3 files changed, 2858 insertions(+) create mode 100644 xen/drivers/passthrough/arm/smmu

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-21 Thread Rahul Singh
yet, but I wanted to provide feedback on the > commit message. > > On 20/10/2020 16:25, Rahul Singh wrote: >> Add support for ARM architected SMMUv3 implementations. It is based on >> the Linux SMMUv3 driver. >> Major differences between the Linux driver are as follows: &g

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-23 Thread Rahul Singh
Hello, > On 23 Oct 2020, at 1:02 am, Stefano Stabellini wrote: > > On Thu, 22 Oct 2020, Julien Grall wrote: >>>> On 20/10/2020 16:25, Rahul Singh wrote: >>>>> Add support for ARM architected SMMUv3 implementations. It is based on >>>>> the L

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-23 Thread Rahul Singh
Hello Julien, > On 22 Oct 2020, at 9:32 am, Julien Grall wrote: > > > > On 21/10/2020 12:25, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 20 Oct 2020, at 6:03 pm, Julien Grall wrote: >>> >>> Hi Rahul, >>>

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-23 Thread Rahul Singh
Hello Julien, > On 23 Oct 2020, at 2:00 pm, Julien Grall wrote: > > > > On 23/10/2020 12:35, Rahul Singh wrote: >> Hello, >>> On 23 Oct 2020, at 1:02 am, Stefano Stabellini >>> wrote: >>> >>> On Thu, 22 Oct 2020, Julien G

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-26 Thread Rahul Singh
Hello Julien, > On 23 Oct 2020, at 4:19 pm, Julien Grall wrote: > > > > On 23/10/2020 15:27, Rahul Singh wrote: >> Hello Julien, >>> On 23 Oct 2020, at 2:00 pm, Julien Grall wrote: >>> >>> >>> >>> On 23/10/2020 12:3

[PATCH v1 0/4] xen/arm: Make PCI passthrough code non-x86 specific

2020-10-26 Thread Rahul Singh
This patch series is preparatory work to make PCI passthrough code non-x86 specific. Rahul Singh (4): xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled. xen/pci: Introduce new CONFIG_HAS_PCI_ATS flag for PCI ATS functionality. xen/pci: Move x86 specific code to

[PATCH v1 2/4] xen/pci: Introduce new CONFIG_HAS_PCI_ATS flag for PCI ATS functionality.

2020-10-26 Thread Rahul Singh
-by: Rahul Singh --- xen/arch/x86/Kconfig | 1 + xen/drivers/passthrough/ats.h| 24 xen/drivers/passthrough/vtd/x86/Makefile | 2 +- xen/drivers/passthrough/x86/Makefile | 2 +- xen/drivers/pci/Kconfig | 3 +++ 5

[PATCH v1 4/4] xen/pci: solve compilation error when memory paging is not enabled.

2020-10-26 Thread Rahul Singh
d->vm_event_paging struct is defined under CONFIG_HAS_MEM_PAGING in sched.h but referenced in passthrough/pci.c directly. If CONFIG_HAS_MEM_PAGING is not enabled for architecture, compiler will throws an error. No functional change. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/pc

[PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-26 Thread Rahul Singh
passthrough/pci.c file is common for all architecture, but there is x86 sepcific code in this file. Move x86 specific code to the x86 directory to avoid compilation error for other architecture. No functional change. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/pci.c| 75

[PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.

2020-10-26 Thread Rahul Singh
ARM platforms does not support ns16550 PCI support. When CONFIG_HAS_PCI is enabled for ARM a compilation error is observed. Fixed compilation error after introducing new kconfig option CONFIG_HAS_NS16550_PCI for x86 platforms to support ns16550 PCI. No functional change. Signed-off-by: Rahul

Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.

2020-10-28 Thread Rahul Singh
Hello Stefano, > On 27 Oct 2020, at 11:32 pm, Stefano Stabellini > wrote: > > On Mon, 26 Oct 2020, Rahul Singh wrote: >> ARM platforms does not support ns16550 PCI support. When CONFIG_HAS_PCI >^ do Ok I will fix that in next version. > >> is

Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.

2020-10-28 Thread Rahul Singh
Hello Jan, > On 28 Oct 2020, at 7:18 am, Jan Beulich wrote: > > On 28.10.2020 00:32, Stefano Stabellini wrote: >> On Mon, 26 Oct 2020, Rahul Singh wrote: >>> --- a/xen/drivers/char/Kconfig >>> +++ b/xen/drivers/char/Kconfig >>> @@ -4,6 +4,13 @@ conf

Re: [PATCH v1 4/4] xen/pci: solve compilation error when memory paging is not enabled.

2020-10-28 Thread Rahul Singh
Hello Jan, > On 28 Oct 2020, at 11:56 am, Jan Beulich wrote: > > On 26.10.2020 18:17, Rahul Singh wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -1419,13 +1419,15 @@ static int assign_device(struct domain *d, u16 seg, &g

Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-10-28 Thread Rahul Singh
Hello Jan, > On 28 Oct 2020, at 11:51 am, Jan Beulich wrote: > > On 26.10.2020 18:17, Rahul Singh wrote: >> passthrough/pci.c file is common for all architecture, but there is x86 >> sepcific code in this file. > > The code you move doesn't look to be x86 speci

Re: [PATCH v1 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.

2020-10-28 Thread Rahul Singh
Hello Julen, > On 28 Oct 2020, at 11:32 am, Julien Grall wrote: > > Hi, > > On 28/10/2020 10:41, Rahul Singh wrote: >>> On 28 Oct 2020, at 7:18 am, Jan Beulich wrote: >>> >>> On 28.10.2020 00:32, Stefano Stabellini wrote: >>>> On Mon, 2

Re: [PATCH v1 4/4] xen/pci: solve compilation error when memory paging is not enabled.

2020-10-29 Thread Rahul Singh
Hello Jan, > On 28 Oct 2020, at 3:13 pm, Rahul Singh wrote: > > Hello Jan, > >> On 28 Oct 2020, at 11:56 am, Jan Beulich wrote: >> >> On 26.10.2020 18:17, Rahul Singh wrote: >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthro

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-30 Thread Rahul Singh
Hello Stefano, > On 29 Oct 2020, at 8:17 pm, Stefano Stabellini wrote: > > On Thu, 29 Oct 2020, Bertrand Marquis wrote: >>> On 28 Oct 2020, at 19:12, Julien Grall wrote: >>> On 26/10/2020 11:03, Rahul Singh wrote: >>>> Hello Julien, >>>&g

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-30 Thread Rahul Singh
Hello Julien, > On 30 Oct 2020, at 9:21 am, Julien Grall wrote: > > Hi, > > On 30/10/2020 08:46, Rahul Singh wrote: >> Ok Yes when I ported the driver I port the command queue operation from the >> previous commit where atomic operations is not used and rest a

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-30 Thread Rahul Singh
Hello Julien, > On 30 Oct 2020, at 10:05 am, Julien Grall wrote: > > > > On 30/10/2020 09:45, Rahul Singh wrote: >> Hello Julien, >>> On 30 Oct 2020, at 9:21 am, Julien Grall wrote: >>> >>> Hi, >>> >>> On 30/10/2020 08:46,

Re: [PATCH v1 4/4] xen/pci: solve compilation error when memory paging is not enabled.

2020-10-30 Thread Rahul Singh
Hello Jan, > On 29 Oct 2020, at 5:16 pm, Jan Beulich wrote: > > On 29.10.2020 17:58, Rahul Singh wrote: >>> On 28 Oct 2020, at 3:13 pm, Rahul Singh wrote: >>>> On 28 Oct 2020, at 11:56 am, Jan Beulich wrote: >>>> On 26.10.2020 18:17, Rahul Singh

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-10-30 Thread Rahul Singh
Hello Oleksandr, > On 30 Oct 2020, at 10:44 am, Oleksandr Andrushchenko > wrote: > > Hi, Rahul! > > On 10/20/20 6:25 PM, Rahul Singh wrote: >> Add support for ARM architected SMMUv3 implementations. It is based on >> the Linux SMMUv3 driver. >> >>

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-11-02 Thread Rahul Singh
>>> >>> On 10/30/20 7:18 PM, Julien Grall wrote: >>>> Hi Oleksandr, >>>> >>>> On 30/10/2020 10:44, Oleksandr Andrushchenko wrote: >>>>> On 10/20/20 6:25 PM, Rahul Singh wrote: >>>>>> Add support for ARM architected

[PATCH v2 2/4] xen/pci: Introduce new CONFIG_PCI_ATS flag for PCI ATS functionality.

2020-11-03 Thread Rahul Singh
-by: Rahul Singh --- Changes in v2: - Fixed return value of PCI ATS related functions when PCI_ATS is not enabled. - Make PCI_ATS user selectable kconfig option. --- xen/drivers/passthrough/ats.h| 26 ++ xen/drivers/passthrough/x86/Makefile | 2 +- xen/drivers

[PATCH v2 0/4] xen/arm: Make PCI passthrough code non-x86 specific

2020-11-03 Thread Rahul Singh
This patch series is v2 of preparatory work to make PCI passthrough code non-x86 specific. Rahul Singh (4): xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled. xen/pci: Introduce new CONFIG_PCI_ATS flag for PCI ATS functionality. xen/pci: Move x86 specific code to

[PATCH v2 4/4] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-03 Thread Rahul Singh
If mem-sharing, mem-paging and log-dirty functionality is not enabled for architecture when HAS_PCI is enabled, compiler will throw an error. Move code to x86 specific directory to fix compilation error. No functional change. Signed-off-by: Rahul Singh --- Changes in v2: - Move mem-sharing

[PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-03 Thread Rahul Singh
passthrough/pci.c file is common for all architecture, but there is x86 sepcific code in this file. Move x86 specific code to the x86 directory to avoid compilation error for other architecture. No functional change. Signed-off-by: Rahul Singh --- Changes is v2: - fixed comments. - rename

[PATCH v2 1/4] xen/ns16550: solve compilation error on ARM with CONFIG_HAS_PCI enabled.

2020-11-03 Thread Rahul Singh
default. For ARM platforms it is disabled by default, once we have proper support for NS16550 PCI for ARM we can enable it. No functional change. Signed-off-by: Rahul Singh --- Changes in v2: - Silently enable the HAS_NS16550_PCI for x86 by default. --- xen/drivers/char/Kconfig | 7

Re: [PATCH v2 3/4] xen/pci: Move x86 specific code to x86 directory.

2020-11-06 Thread Rahul Singh
Hello Jan, > On 6 Nov 2020, at 9:09 am, Jan Beulich wrote: > > On 03.11.2020 16:59, Rahul Singh wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -14,7 +14,6 @@ >> * this program; If not, see <http://www.gnu.org

Re: [PATCH v2 4/4] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-06 Thread Rahul Singh
Hello Jan, > On 6 Nov 2020, at 9:21 am, Jan Beulich wrote: > > On 03.11.2020 16:59, Rahul Singh wrote: >> If mem-sharing, mem-paging and log-dirty functionality is not enabled >> for architecture when HAS_PCI is enabled, compiler will throw an error. > > Nit: Is it

Re: [PATCH v2 2/4] xen/pci: Introduce new CONFIG_PCI_ATS flag for PCI ATS functionality.

2020-11-06 Thread Rahul Singh
Hello Jan, > On 4 Nov 2020, at 3:49 pm, Jan Beulich wrote: > > On 04.11.2020 16:43, Jan Beulich wrote: >> On 03.11.2020 16:59, Rahul Singh wrote: >>> --- a/xen/drivers/pci/Kconfig >>> +++ b/xen/drivers/pci/Kconfig >>> @@ -1,3 +1,12 @@ >>>

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-11-06 Thread Rahul Singh
>>> >>> On 10/30/20 7:18 PM, Julien Grall wrote: >>>> Hi Oleksandr, >>>> >>>> On 30/10/2020 10:44, Oleksandr Andrushchenko wrote: >>>>> On 10/20/20 6:25 PM, Rahul Singh wrote: >>>>>> Add support for ARM architected

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-11-06 Thread Rahul Singh
Hello Oleksandr, > On 6 Nov 2020, at 1:00 pm, Oleksandr Andrushchenko > wrote: > > Hello, Rahul! > > On 11/6/20 2:48 PM, Rahul Singh wrote: >> Hello Oleksandr, >> >>> On 2 Nov 2020, at 10:12 am, Oleksandr Andrushchenko >>> wrote: >>>

Re: [XEN PATCH v1] xen/arm : Add support for SMMUv3 driver

2020-11-06 Thread Rahul Singh
Hello Oleksandr, > On 6 Nov 2020, at 2:22 pm, Oleksandr Andrushchenko > wrote: > > Hi, Rahul! > > On 11/6/20 3:58 PM, Rahul Singh wrote: >> Hello Oleksandr, >> >>> On 6 Nov 2020, at 1:00 pm, Oleksandr Andrushchenko >>> wrote: >>> &

[PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-16 Thread Rahul Singh
X86 platforms it is enabled by default. For ARM platforms it is disabled by default, once we have proper support for NS16550 PCI for ARM we can enable it. No functional change. Signed-off-by: Rahul Singh --- Changes in v3: - remove help text from the Kconfig file because of prompt-less option

[PATCH v3 3/3] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-16 Thread Rahul Singh
to make code more optimized. No functional change. Signed-off-by: Rahul Singh --- Changes in v3: - rename arch_iommu_usable() to arch_iommu_use_permitted() - fixed comments. --- xen/drivers/passthrough/pci.c | 8 +--- xen/drivers/passthrough/x86/iommu.c | 12 xen

[PATCH v3 2/3] xen/pci: Move x86 specific code to x86 directory.

2020-11-16 Thread Rahul Singh
rename it to hvm.c. No functional change. Signed-off-by: Rahul Singh --- Changes in v3: - fixed typo - As per suggestion move the code to the file io.c and move that file to x86 directory and rename it hvm.c --- xen/drivers/passthrough/Makefile| 3 - xen/drivers/passthrough/pci.c

[PATCH v3 0/3] xen/arm: Make PCI passthrough code non-x86 specific

2020-11-16 Thread Rahul Singh
This patch series is v3 of preparatory work to make PCI passthrough code non-x86 specific. Rahul Singh (3): xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled. xen/pci: Move x86 specific code to x86 directory. xen/pci: solve compilation error on ARM with HAS_PCI enabled

Re: [PATCH v3 2/3] xen/pci: Move x86 specific code to x86 directory.

2020-11-17 Thread Rahul Singh
Hello Stefano, > On 17 Nov 2020, at 1:20 am, Stefano Stabellini wrote: > > On Mon, 16 Nov 2020, Rahul Singh wrote: >> passthrough/pci.c file is common for all architecture, but there is x86 >> specific code in this file. >> >> Move x86 specific code to the

Re: [PATCH v3 3/3] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-17 Thread Rahul Singh
Hello Jan, > On 17 Nov 2020, at 11:12 am, Jan Beulich wrote: > > On 16.11.2020 13:25, Rahul Singh wrote: >> If mem-sharing, mem-paging, or log-dirty functionality is not enabled >> for non-x86 architecture when HAS_PCI is enabled, the compiler will >> throw an err

Re: [PATCH v3 2/3] xen/pci: Move x86 specific code to x86 directory.

2020-11-17 Thread Rahul Singh
Hello Jan, > On 17 Nov 2020, at 11:03 am, Jan Beulich wrote: > > On 16.11.2020 13:25, Rahul Singh wrote: >> passthrough/pci.c file is common for all architecture, but there is x86 >> specific code in this file. > > In how far is ... > >> @@ -

Re: Xen data from meta-virtualization layer

2020-11-18 Thread Rahul Singh
Hello Stefano, > On 17 Nov 2020, at 11:53 pm, Stefano Stabellini > wrote: > > Adding Bertrand, Oleksandr, Julien, and others -- they have a more > recent experience with GICv3 ITS than me and might be able to help. > I am attaching the device tree Leo sent a few days ago for reference. > > >

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-18 Thread Rahul Singh
Hello Jan, > On 17 Nov 2020, at 10:55 am, Jan Beulich wrote: > > On 16.11.2020 13:25, Rahul Singh wrote: >> NS16550 driver has PCI support that is under HAS_PCI flag. When HAS_PCI >> is enabled for ARM, compilation error is observed for ARM architecture >> because ARM

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-19 Thread Rahul Singh
Hello, > On 19 Nov 2020, at 10:16 am, Julien Grall wrote: > > > > On 19/11/2020 09:53, Jan Beulich wrote: >> On 19.11.2020 10:21, Julien Grall wrote: >>> Hi Jan, >>> >>> On 19/11/2020 09:05, Jan Beulich wrote: >>>> On 18.11.2020

Re: Xen data from meta-virtualization layer

2020-11-23 Thread Rahul Singh
Hello , > On 22 Nov 2020, at 10:55 pm, Leo Krueger wrote: > > Hi Julien, > > finally I could try out what you suggested, please find my answers inline. > >> -Ursprüngliche Nachricht- >> Von: Julien Grall >> Gesendet: Mittwoch, 18. November 2020 13:24 >> An: Stefano Stabellini ; Leo Kr

Re: [PATCH v3 1/3] xen/ns16550: Make ns16550 driver usable on ARM with HAS_PCI enabled.

2020-11-23 Thread Rahul Singh
Hello Jan, > On 20 Nov 2020, at 12:14 am, Stefano Stabellini > wrote: > > On Thu, 19 Nov 2020, Julien Grall wrote: >> On Thu, 19 Nov 2020, 23:38 Stefano Stabellini, >> wrote: >> On Thu, 19 Nov 2020, Rahul Singh wrote: >>>> On 19/11/2020 09:53,

Re: [PATCH v2 1/3] ns16550: move PCI arrays next to the function using them

2020-11-24 Thread Rahul Singh
Hello , > On 24 Nov 2020, at 12:02 am, Stefano Stabellini > wrote: > > On Mon, 23 Nov 2020, Jan Beulich wrote: >> Pure code motion; no functional change intended. >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Stefano Stabellini > Re

Re: [PATCH v2 2/3] ns16550: "com=" command line options are x86-specific

2020-11-24 Thread Rahul Singh
Signed-off-by: Jan Beulich > > Great cleanup > > Reviewed-by: Stefano Stabellini Reviewed-by: Rahul Singh Regards, Rahul > > >> --- >> v2: Re-base over new earlier patch. >> >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen

Re: [PATCH v2 3/3] ns16550: drop stray "#ifdef CONFIG_HAS_PCI"

2020-11-24 Thread Rahul Singh
nally available. >> >> Reported-by: Julien Grall >> Signed-off-by: Jan Beulich > > Reviewed-by: Stefano Stabellini > Reviewed-by: Rahul Singh > >> --- a/xen/drivers/char/ns16550.c >> +++ b/xen/drivers/char/ns16550.c >> @@ -662,9 +662,7

Re: [PATCH] xen/arm: Add workaround for Cortex-A55 erratum #1530923

2020-11-24 Thread Rahul Singh
values might > be allocated. > The ARM64_WORKAROUND_AT_SPECULATE workaround is used as for erratum > 1165522 on Cortex A76 or Neoverse N1. > > This change is also introducing the MIDR identifier for the Cortex-A55. > > Signed-off-by: Bertrand Marquis Reviewed-by: Rahul Singh

[PATCH v4 0/3] xen/arm: Make PCI passthrough code non-x86 specific

2020-11-25 Thread Rahul Singh
This patch series is v4 of preparatory work to make PCI passthrough code non-x86 specific. Rahul Singh (3): xen/pci: Move x86 specific code to x86 directory. xen/pci: solve compilation error on ARM with HAS_PCI enabled. ns16550: Gate all PCI code with CONFIG_X86 xen/drivers/char/ns16550.c

[PATCH v4 1/3] xen/pci: Move x86 specific code to x86 directory.

2020-11-25 Thread Rahul Singh
rename it to hvm.c. No functional change intended. Signed-off-by: Rahul Singh --- Changes in v4: - fixed compilation error when CONFIG_HVM is disabled - remove iommu_update_ire_from_msi from the patch will send another patch to fix. --- xen/drivers/passthrough/Makefile| 3 - xen

[PATCH v4 2/3] xen/pci: solve compilation error on ARM with HAS_PCI enabled.

2020-11-25 Thread Rahul Singh
more optimized. No functional change intended. Signed-off-by: Rahul Singh --- Changes in v4: - fixed minor comments --- xen/drivers/passthrough/pci.c | 8 +--- xen/drivers/passthrough/x86/iommu.c | 13 + xen/include/xen/iommu.h | 2 ++ 3 files changed, 16

[PATCH v4 3/3] ns16550: Gate all PCI code with CONFIG_X86

2020-11-25 Thread Rahul Singh
6 flag with CONFIG_X86. No functional change intended. Signed-off-by: Rahul Singh --- Changes in v4: - As per the discussion guard all remaining PCI code with CONFIG_X86 --- xen/drivers/char/ns16550.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/d

Re: [PATCH v4 3/3] ns16550: Gate all PCI code with CONFIG_X86

2020-11-25 Thread Rahul Singh
Hello Julien, > On 25 Nov 2020, at 6:16 pm, Rahul Singh wrote: > > The NS16550 driver is assuming that NS16550 PCI card are usable if the > architecture supports PCI (i.e. CONFIG_HAS_PCI=y). However, the code is > very x86 focus and will fail to build on Arm (/!\ it is not a

Re: [PATCH v4 08/11] xen/compiler: import 'fallthrough' keyword from linux

2021-01-15 Thread Rahul Singh
Hello, > On 14 Jan 2021, at 11:47 pm, Stefano Stabellini > wrote: > > On Thu, 14 Jan 2021, Jan Beulich wrote: >> On 13.01.2021 00:30, Stefano Stabellini wrote: >>> On Tue, 12 Jan 2021, Jan Beulich wrote: >>>> On 08.01.2021 15:46, Rahul Singh wrote: &g

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-15 Thread Rahul Singh
Hello Oleksandr, > On 12 Jan 2021, at 8:59 pm, Oleksandr wrote: > > > On 12.01.21 11:41, Rahul Singh wrote: > > Hi Rahul > > >> >>>> -static int arm_smmu_of_xlate(struct device *dev, struct of_phandle_args >>>> *args)

Re: [PATCH v4 07/11] xen/arm: bitops: Implement a ffsll function

2021-01-18 Thread Rahul Singh
Hello Julien, > On 15 Jan 2021, at 12:16 pm, Julien Grall wrote: > > Hi Rahul, > > On 08/01/2021 14:46, Rahul Singh wrote: >> Implement the ffsll based on built-in function "__builtin_ffsll()" >> ffsll will return one plus the index of the least sign

Re: [PATCH v4 09/11] xen/arm: smmuv3: Use fallthrough pseudo-keyword

2021-01-18 Thread Rahul Singh
Hello Julien, > On 15 Jan 2021, at 12:18 pm, Julien Grall wrote: > > Hi Rahul, > > On 08/01/2021 14:46, Rahul Singh wrote: >> Merge the patch from linux to use fallthrough pseudo-keyword. > > Please add more information about the patch you are backporting. Is it a

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-18 Thread Rahul Singh
Hello Oleksandr, > On 11 Jan 2021, at 4:39 pm, Oleksandr wrote: > > > Hi Rahul > > >>> - >>> static int arm_smmu_device_probe(struct platform_device *pdev) >>> { >>> int irq, ret; >>> -struct resource *res; >>> -resource_size_t ioaddr; >>> +paddr_t ioaddr, iosize; >>>

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-18 Thread Rahul Singh
Hello Oleksandr, > On 18 Jan 2021, at 4:20 pm, Oleksandr wrote: > > > On 18.01.21 17:33, Rahul Singh wrote: >> Hello Oleksandr, >> >>> On 11 Jan 2021, at 4:39 pm, Oleksandr wrote: >>> >>> >>> Hi Rahul > > Hi Rahul >

Re: [PATCH v4 11/11] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-19 Thread Rahul Singh
Hello Oleksandr, > On 19 Jan 2021, at 2:43 pm, Oleksandr wrote: > > > On 18.01.21 18:57, Rahul Singh wrote: >> Hello Oleksandr, > > Hi Rahul > > >> >>> On 18 Jan 2021, at 4:20 pm, Oleksandr wrote: >>> >>> >>> On 18

[PATCH v5 00/10] xen/arm: Add support for SMMUv3 driver

2021-01-20 Thread Rahul Singh
Changes since v4: [PATCH v5 10/1]: - Replace the ffsll() with ffs64() function. - Add code to free resources when probe failed. [PATCH v5 08/10]: - Add more information about the merged patch in commit message. Rahul Singh (10): xen/arm: smmuv3: Import the SMMUv3 driver from Linux xen/arm

[PATCH v5 01/10] xen/arm: smmuv3: Import the SMMUv3 driver from Linux

2021-01-20 Thread Rahul Singh
nux 5.9.12 and Linux 5.8.18 SMMUv3 driver is the use of the "fallthrough" keyword. This patch will be merged once "fallthrough" keyword implementation is available in XEN. It's a copy of the Linux SMMUv3 driver. Xen specific code has not been added yet and code has not b

[PATCH v5 02/10] xen/arm: Revert atomic operation related command-queue insertion patch

2021-01-20 Thread Rahul Singh
7379fd010ff25d2a984. 7. "iommu/arm-smmu-v3: Reduce contention during command-queue insertion" commit 587e6c10a7ce89a5924fdbeff2ec524fbd6a124b. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes since v2: - Added consequences of reverting this patch in commit messa

[PATCH v5 03/10] xen/arm: smmuv3: Revert patch related to XArray

2021-01-20 Thread Rahul Singh
for XEN. Once XArray is implemented in XEN this patch can be added in XEN if XEN supports Stage-1 translation. Reverted the commit 0299a1a81ca056e79c1a7fb751f936ec0d5c7afe Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes since v2: - Added consequences of reverting this patch in

[PATCH v5 04/10] xen/arm: smmuv3: Remove support for Stage-1 translation on SMMUv3.

2021-01-20 Thread Rahul Singh
Linux SMMUv3 driver supports both Stage-1 and Stage-2 translations. As of now only Stage-2 translation support has been tested. Once Stage-1 translation support is tested this patch can be added. Signed-off-by: Rahul Singh Acked-by: Stefano Stabellini --- Changes since v2: No changes Changes

[PATCH v5 05/10] xen/arm: smmuv3: Remove Linux specific code that is not usable in XEN

2021-01-20 Thread Rahul Singh
. iommu_device_sysfs_add, iommu_device_register, iommu_device_set_fwnode Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Reviewed-by: Stefano Stabellini --- Changes since v2: - Commit message is updated to add more detail what is removed in this patch. - remove instances of io_pgtable_cfg

[PATCH v5 06/10] xen/device-tree: Add dt_property_match_string helper

2021-01-20 Thread Rahul Singh
Import the Linux helper of_property_match_string. This function searches a string list property and returns the index of a specific string value. Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Reviewed-by: Stefano Stabellini --- Changes since v2: - This patch is introduce in this

[PATCH v5 07/10] xen/compiler: import 'fallthrough' keyword from linux

2021-01-20 Thread Rahul Singh
iler version (any version less than gcc 7) does not support the attribute. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Changes since v3: - This patch is introduce in this version. Changes since v4: No changes --- --- xen/include/xen/compiler.h

[PATCH v5 08/10] xen/arm: smmuv3: Use fallthrough pseudo-keyword

2021-01-20 Thread Rahul Singh
it is the case. Signed-off-by: Rahul Singh --- Changes since v3: - This patch is introduce in this version. Changes since v4: - Add more information about the merged patch in commit message. --- --- xen/drivers/passthrough/arm/smmu-v3.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletion

[PATCH v5 09/10] xen/arm: smmuv3: Replace linux functions with xen functions.

2021-01-20 Thread Rahul Singh
Replace all Linux device tree handling function with the XEN functions. Replace all Linux ktime function with the XEN time functions. Signed-off-by: Rahul Singh Reviewed-by: Stefano Stabellini Reviewed-by: Bertrand Marquis --- Changes since v2: - This patch is introduce in this version

[PATCH v5 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-20 Thread Rahul Singh
de is guarded by the flag CONFIG_PCI_ATS. 8. MSI interrupts are not supported as there is no support available in XEN to request MSI interrupts. Code is not tested and compiled. Code is guarded by the flag CONFIG_MSI. Signed-off-by: Rahul Singh --- Changes since v2: - added return statemen

Re: [PATCH v5 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-21 Thread Rahul Singh
Hello Stefano, > On 20 Jan 2021, at 8:31 pm, Stefano Stabellini wrote: > > On Wed, 20 Jan 2021, Rahul Singh wrote: >> Add support for ARM architected SMMUv3 implementation. It is based on >> the Linux SMMUv3 driver. >> >> Driver is currently supported as Tech

Re: [PATCH v5 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-21 Thread Rahul Singh
Hello Oleksandr, > On 20 Jan 2021, at 9:33 pm, Oleksandr wrote: > > > On 20.01.21 16:52, Rahul Singh wrote: > > Hi Rahul > >> Add support for ARM architected SMMUv3 implementation. It is based on >> the Linux SMMUv3 driver. >> >> Driver is curr

Re: [PATCH v5 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-21 Thread Rahul Singh
Hello Julien, > On 21 Jan 2021, at 6:31 pm, Julien Grall wrote: > > On 21/01/2021 17:18, Rahul Singh wrote: >> Hello Oleksandr, > > Hi, > >>> On 20 Jan 2021, at 9:33 pm, Oleksandr wrote: >>> >>> >>> On 20.01.21 16:52, Rahul

Re: [PATCH v5 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-21 Thread Rahul Singh
Hello Julien, > On 21 Jan 2021, at 6:43 pm, Julien Grall wrote: > > Hi Rahul, > > Please try to trim the e-mail when quoting, otherwise it is quite difficult > to find the only couple of answer you wrote. > > On 21/01/2021 17:10, Rahul Singh wrote: >>> On

[PATCH v6 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-22 Thread Rahul Singh
de is guarded by the flag CONFIG_PCI_ATS. 8. MSI interrupts are not supported as there is no support available in XEN to request MSI interrupts. Code is not tested and compiled. Code is guarded by the flag CONFIG_MSI. Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis --- Changes sin

Re: [PATCH v6 10/10] xen/arm: smmuv3: Add support for SMMUv3 driver

2021-01-25 Thread Rahul Singh
Hello Julien, > On 23 Jan 2021, at 11:55 am, Julien Grall wrote: > > Hi Rahul > > On 22/01/2021 11:37, Rahul Singh wrote: >> Add support for ARM architected SMMUv3 implementation. It is based on >> the Linux SMMUv3 driver. >> Driver is currently supported as T

Re: more randconfig failures

2021-01-27 Thread Rahul Singh
Hello Julien, > On 27 Jan 2021, at 9:25 pm, Julien Grall wrote: > > Hi, > > On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini > wrote: >> >> Hi all, >> >> These are two recent randconfig build failures reported by gitlab (the >> two patches that triggered the CI-loop are two patches to the >

Re: more randconfig failures

2021-01-28 Thread Rahul Singh
Hello Julien, > On 28 Jan 2021, at 4:34 pm, Julien Grall wrote: > > On 27/01/2021 23:11, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 27 Jan 2021, at 9:25 pm, Julien Grall wrote: >>> >>> Hi, >>> >>> On Wed

[PATCH] xen/arm: smmuv3: Disable the SMMUv3 driver when ACPI is enabled.

2021-01-29 Thread Rahul Singh
SMMUv3 driver does not support ACPI device probe.If APCI is enabled with SMMUv3 driver compiler will throw an error. Disable SMMUv3 driver when ACPI is enabled in kconfig to fix compilation error. Signed-off-by: Rahul Singh --- xen/drivers/passthrough/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH v3 1/3] arm,smmu: switch to using iommu_fwspec functions

2021-02-02 Thread Rahul Singh
enabling generic device tree > bindings in the SMMU driver much cleaner. > > Signed-off-by: Brian Woods > Signed-off-by: Stefano Stabellini Reviewed-by: Rahul Singh Tested-by: Rahul Singh Regards, Rahul > --- > Changes in v3: > - add a comment in iommu_add

Re: [PATCH v3 0/3] Generic SMMU Bindings

2021-02-02 Thread Rahul Singh
Hello Stefano, > On 26 Jan 2021, at 10:58 pm, Stefano Stabellini > wrote: > > Hi all, > > This series introduces support for the generic SMMU bindings to > xen/drivers/passthrough/arm/smmu.c. > > The last version of the series was > https://marc.info/?l=xen-devel&m=159539053406643 > > I real

Re: [PATCH v3 3/3] arm,smmu: add support for generic DT bindings. Implement add_device and dt_xlate.

2021-02-02 Thread Rahul Singh
ric bindings are present in > device tree, the legacy bindings are the ones that are used. > > Signed-off-by: Brian Woods > Signed-off-by: Stefano Stabellini Reviewed-by: Rahul Singh Tested-by: Rahul Singh Regards, Rahul > --- > Changes in v3: > - split patch > - make

Re: [PATCH v3 2/3] arm,smmu: restructure code in preparation to new bindings support

2021-02-02 Thread Rahul Singh
with just modifying the chosen field to > enable Xen. > > Signed-off-by: Brian Woods > Signed-off-by: Stefano Stabellini Reviewed-by: Rahul Singh Tested-by: Rahul Singh Regards, Rahul > --- > Changes in v3: > - split patch > --- > xen/drivers/passthrough/arm/

Re: [PATCH v3 0/3] Generic SMMU Bindings

2021-02-03 Thread Rahul Singh
Hello Stefano, > On 2 Feb 2021, at 5:44 pm, Stefano Stabellini wrote: > > On Tue, 2 Feb 2021, Rahul Singh wrote: >> Hello Stefano, >> >>> On 26 Jan 2021, at 10:58 pm, Stefano Stabellini >>> wrote: >>> >>> Hi all, >>> &

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Rahul Singh
Hello Stefano, > On 6 Feb 2021, at 12:38 am, Stefano Stabellini wrote: > > Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. > The offending chunk is: > > #define gnttab_need_iommu_mapping(d)\ > -(is_domain_direct_mapped(d) && need_iommu(d)) > +(is_domain_di

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-08 Thread Rahul Singh
Hello Julien, > On 8 Feb 2021, at 6:11 pm, Julien Grall wrote: > > > > On 08/02/2021 18:06, Rahul Singh wrote: >>> On 6 Feb 2021, at 12:38 am, Stefano Stabellini >>> wrote: >>> >>> Commit 91d4eca7add broke gnttab_need_iommu_mapping o

Re: [PATCH] xen/arm: fix gnttab_need_iommu_mapping

2021-02-09 Thread Rahul Singh
Hello Julien, > On 8 Feb 2021, at 6:49 pm, Julien Grall wrote: > > > > On 08/02/2021 18:19, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 8 Feb 2021, at 6:11 pm, Julien Grall wrote: >>> >>> >>> >>&g

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-09 Thread Rahul Singh
Hello Stefano, > On 8 Feb 2021, at 6:49 pm, Stefano Stabellini wrote: > > Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. > The offending chunk is: > > #define gnttab_need_iommu_mapping(d)\ > -(is_domain_direct_mapped(d) && need_iommu(d)) > +(is_domain_dir

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Rahul Singh
Hello Stefano, > On 9 Feb 2021, at 8:36 pm, Stefano Stabellini wrote: > > On Tue, 9 Feb 2021, Rahul Singh wrote: >>> On 8 Feb 2021, at 6:49 pm, Stefano Stabellini >>> wrote: >>> >>> Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM.

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Rahul Singh
Hello Julien, > On 10 Feb 2021, at 5:34 pm, Julien Grall wrote: > > Hi, > > On 10/02/2021 15:06, Rahul Singh wrote: >>> On 9 Feb 2021, at 8:36 pm, Stefano Stabellini >>> wrote: >>> >>> On Tue, 9 Feb 2021, Rahul Singh wrote: >>>&g

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-11 Thread Rahul Singh
Hello Stefano, > On 10 Feb 2021, at 9:13 pm, Stefano Stabellini wrote: > > On Wed, 10 Feb 2021, Rahul Singh wrote: >>> On 9 Feb 2021, at 8:36 pm, Stefano Stabellini >>> wrote: >>> On Tue, 9 Feb 2021, Rahul Singh wrote: >>>>> On 8 Feb

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-11 Thread Rahul Singh
Hello Julien, > On 10 Feb 2021, at 7:52 pm, Julien Grall wrote: > > > > On 10/02/2021 18:08, Rahul Singh wrote: >> Hello Julien, >>> On 10 Feb 2021, at 5:34 pm, Julien Grall wrote: >>> >>> Hi, >>> >>> On 10/02/2021

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-11 Thread Rahul Singh
Hello Julien, > On 11 Feb 2021, at 1:52 pm, Julien Grall wrote: > > > > On 11/02/2021 13:20, Rahul Singh wrote: >> Hello Julien, > > Hi Rahul, > >>> On 10 Feb 2021, at 7:52 pm, Julien Grall wrote: >>> >>> >>> >>>

  1   2   3   4   5   6   7   8   >