[PATCH 01/13] PCI: Prepare removing devres from pci_intx()

-by: Philipp Stanner Reviewed-by: Damien Le Moal --- drivers/pci/devres.c | 24 +++- drivers/pci/pci.c| 28 include/linux/pci.h | 2 ++ 3 files changed, 33 insertions(+), 21 deletions(-) diff --git a/drivers/pci/devres.c b/drivers/pci

[PATCH 04/13] net/ethernet: Use never-managed version of pci_intx()

, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/brocade/bna/bnad.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 00/13] Remove implicit devres from pci_intx()

s sure that each checked out commit should provide correct behavior, not just the entire series as a whole. Merge plan for this is to enter through the PCI tree. [1] https://lore.kernel.org/all/20241009083519.10088-1-pstan...@redhat.com/ Regards, P. Philipp Stanner (13): PCI: Prepare rem

[PATCH 06/13] misc: Use never-managed version of pci_intx()

(). Thus, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader/rtsx_pcr.c | 2 +- drivers/misc/tifm_7xx1.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc

[PATCH 03/13] drivers/xen: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Acked-by: Juergen Gross --- drivers/xen/xen-pciback/conf_space_header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen

[PATCH 02/13] ALSA: hda_intel: Use always-managed version of pcim_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- sound/pci/hda/hda_intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index b4540c5cd2a6..b44ca7b6e54f 100644 --- a/sound/pci/hda

[PATCH 09/13] ata: Use always-managed version of pci_intx()

the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- drivers/ata/ahci.c | 2 +- drivers/ata/ata_piix.c | 2 +- drivers/ata/pata_rdc.c | 2 +- drivers/ata/sata_sil24.c | 2 +- drivers/ata/sata_sis.c | 2 +- drivers/ata/sata_uli.c | 2

[PATCH 08/13] PCI: MSI: Use never-managed version of pci_intx()

-managed version pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/pci/msi/api.c | 2 +- drivers/pci/msi/msi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c index b956ce591f96..c95e2e7dc9ab 100644 --- a/drivers

[PATCH 05/13] net/ntb: Use never-managed version of pci_intx()

the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Acked-by: Shyam Sundar S K #for ntb_hw_amd.c --- drivers/ntb/hw/amd/ntb_hw_amd.c| 4 ++-- drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions

[PATCH 10/13] wifi: qtnfmac: use always-managed version of pcim_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c b/drivers/net/wireless/quantenna

[PATCH 07/13] vfio/pci: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/vfio/pci/vfio_pci_core.c | 2 +- drivers/vfio/pci/vfio_pci_intrs.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio

[PATCH 12/13] Remove devres from pci_intx()

(). Consequently, pci_intx_unmanaged() is now redundant, because pci_intx() itself is now unmanaged. Remove the devres functionality from pci_intx(). Have all users of pci_intx_unmanaged() call pci_intx(). Remove pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader

[PATCH 11/13] HID: amd_sfh: Use always-managed version of pcim_intx()

(), which is why the driver needs the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Acked-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c| 4 ++-- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 +- 2 files changed, 3

[PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx()

place. Signed-off-by: Philipp Stanner --- drivers/pci/devres.c | 5 - drivers/pci/pci.c| 5 - 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pci/devres.c b/drivers/pci/devres.c index 6f8f712fe34e..4c76fc063104 100644 --- a/drivers/pci/devres.c +++ b/drivers/pci

Re: [RFC PATCH 01/13] PCI: Prepare removing devres from pci_intx()

On Fri, 2024-10-11 at 16:50 +0300, Andy Shevchenko wrote: > On Fri, Oct 11, 2024 at 02:16:06PM +0200, Philipp Stanner wrote: > > On Thu, 2024-10-10 at 17:40 +0300, Andy Shevchenko wrote: > > > On Wed, Oct 09, 2024 at 10:35:07AM +0200, Philipp Stanner wrote: > > > > p

[RFC PATCH 12/13] HID: amd_sfh: Use always-managed version of pcim_intx()

(), which is why the driver needs the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c| 4 ++-- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[RFC PATCH 09/13] ata: Use always-managed version of pci_intx()

the always-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/ata/ahci.c | 2 +- drivers/ata/ata_piix.c | 2 +- drivers/ata/pata_rdc.c | 2 +- drivers/ata/sata_sil24.c | 2 +- drivers/ata/sata_sis.c | 2 +- drivers/ata/sata_uli.c

[RFC PATCH 11/13] wifi: qtnfmac: use always-managed version of pcim_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c b/drivers/net/wireless/quantenna

[RFC PATCH 13/13] Remove devres from pci_intx()

(). Consequently, pci_intx_unmanaged() is now redundant, because pci_intx() itself is now unmanaged. Remove the devres functionality from pci_intx(). Remove pci_intx_unmanaged(). Have all users of pci_intx_unmanaged() call pci_intx(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader

[RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- drivers/staging/rts5208/rtsx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c index c4f54c311d05..4831eb035bf7 100644 --- a

[RFC PATCH 03/13] drivers/xen: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/xen/xen-pciback/conf_space_header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen-pciback/conf_space_header.c

[RFC PATCH 01/13] PCI: Prepare removing devres from pci_intx()

-by: Philipp Stanner --- drivers/pci/devres.c | 24 +++- drivers/pci/pci.c| 26 ++ include/linux/pci.h | 2 ++ 3 files changed, 31 insertions(+), 21 deletions(-) diff --git a/drivers/pci/devres.c b/drivers/pci/devres.c index b133967faef8

[RFC PATCH 02/13] ALSA: hda: hda_intel: Use always-managed version of pcim_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner --- sound/pci/hda/hda_intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index b4540c5cd2a6..b44ca7b6e54f 100644 --- a/sound/pci/hda

[RFC PATCH 04/13] net/ethernet: Use never-managed version of pci_intx()

, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/brocade/bna/bnad.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[RFC PATCH 00/13] Remove implicit devres from pci_intx()

he general idea behind the RFC. Regards, P. Philipp Stanner (13): PCI: Prepare removing devres from pci_intx() ALSA: hda: hda_intel: Use always-managed version of pcim_intx() drivers/xen: Use never-managed version of pci_intx() net/ethernet: Use never-managed version of pci_intx() net

[RFC PATCH 08/13] PCI: MSI: Use never-managed version of pci_intx()

-managed version pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- This MSI part here is probably the part of the series that needs most attention. --- drivers/pci/msi/api.c | 2 +- drivers/pci/msi/msi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi

[RFC PATCH 07/13] vfio/pci: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/vfio/pci/vfio_pci_core.c | 2 +- drivers/vfio/pci/vfio_pci_intrs.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio

[RFC PATCH 06/13] misc: Use never-managed version of pci_intx()

(). Thus, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader/rtsx_pcr.c | 2 +- drivers/misc/tifm_7xx1.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc

[RFC PATCH 05/13] net/ntb: Use never-managed version of pci_intx()

the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/ntb/hw/amd/ntb_hw_amd.c| 4 ++-- drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b

Re: [RFC PATCH 03/13] drivers/xen: Use never-managed version of pci_intx()

On Wed, 2024-10-09 at 10:51 +0200, Juergen Gross wrote: > On 09.10.24 10:35, Philipp Stanner wrote: > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. To remove this hybrid nature from pci_intx(), it is > > necessary to > &g

Re: [RFC PATCH 09/13] ata: Use always-managed version of pci_intx()

On Wed, 2024-10-09 at 17:51 +0900, Damien Le Moal wrote: > On 10/9/24 17:35, Philipp Stanner wrote: > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. To remove this hybrid nature from pci_intx(), it is > > necessary to > &g

Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx()

On Thu, 2024-10-10 at 11:03 +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 10, 2024 at 10:03:30AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > > > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > > > On Wed, Oct 09, 202

Re: [RFC PATCH 01/13] PCI: Prepare removing devres from pci_intx()

On Thu, 2024-10-10 at 11:43 -0600, Alex Williamson wrote: > On Wed,  9 Oct 2024 10:35:07 +0200 > Philipp Stanner wrote: > > > pci_intx() is a hybrid function which sometimes performs devres > > operations, depending on whether pcim_enable_device() has been used > >

Re: [RFC PATCH 13/13] Remove devres from pci_intx()

On Thu, 2024-10-10 at 11:43 -0600, Alex Williamson wrote: > On Thu, 10 Oct 2024 11:11:36 +0200 > Philipp Stanner wrote: > > > On Thu, 2024-10-10 at 11:50 +0300, Dan Carpenter wrote: > > > On Wed, Oct 09, 2024 at 10:35:19AM +0200, Philipp Stanner wrote:  > > >

Re: [RFC PATCH 01/13] PCI: Prepare removing devres from pci_intx()

On Thu, 2024-10-10 at 17:40 +0300, Andy Shevchenko wrote: > On Wed, Oct 09, 2024 at 10:35:07AM +0200, Philipp Stanner wrote: > > pci_intx() is a hybrid function which sometimes performs devres > > operations, depending on whether pcim_enable_device() has been used > > to &

Re: [RFC PATCH 02/13] ALSA: hda: hda_intel: Use always-managed version of pcim_intx()

On Thu, 2024-10-10 at 17:46 +0300, Andy Shevchenko wrote: > On Wed, Oct 09, 2024 at 10:35:08AM +0200, Philipp Stanner wrote: > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. To remove this hybrid nature from pci_intx(), it is >

Re: [PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx()

On Tue, 2024-10-15 at 13:53 -0600, Alex Williamson wrote: > On Tue, 15 Oct 2024 20:51:23 +0200 > Philipp Stanner wrote: > > > pci_intx() and its managed counterpart pcim_intx() only exist for > > older > > drivers which have not been ported yet for various reasons

Re: [PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx()

On Wed, 2024-10-16 at 10:43 +0200, Heiner Kallweit wrote: > On 16.10.2024 08:57, Philipp Stanner wrote: > > On Tue, 2024-10-15 at 13:53 -0600, Alex Williamson wrote: > > > On Tue, 15 Oct 2024 20:51:23 +0200 > > > Philipp Stanner wrote: > > > > >

Re: [PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx()

On Fri, 2024-10-18 at 18:45 -0500, Bjorn Helgaas wrote: > On Wed, Oct 16, 2024 at 10:53:16AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-16 at 10:43 +0200, Heiner Kallweit wrote: > > > On 16.10.2024 08:57, Philipp Stanner wrote: > > > > On Tue, 2024-10-15 a

Re: [RFC PATCH 13/13] Remove devres from pci_intx()

On Thu, 2024-10-10 at 11:50 +0300, Dan Carpenter wrote: > On Wed, Oct 09, 2024 at 10:35:19AM +0200, Philipp Stanner wrote: > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. This hybrid nature is undesirable. > > > > Sinc

Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx()

On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > On Wed, Oct 09, 2024 at 10:35:16AM +0200, Philipp Stanner wrote: > > > pci_intx() is a hybrid function which can sometimes be managed > > > through > >

Re: [RFC PATCH 00/13] Remove implicit devres from pci_intx()

On Wed, 2024-10-09 at 20:32 +0200, Heiner Kallweit wrote: > On 09.10.2024 10:35, Philipp Stanner wrote: > > Hi all, > > > > this series removes a problematic feature from pci_intx(). That > > function > > sometimes implicitly uses devres for automatic cleanup.

Re: [PATCH 02/13] ALSA: hda_intel: Use always-managed version of pcim_intx()

On Wed, 2024-10-23 at 17:03 +0200, Takashi Iwai wrote: > On Wed, 23 Oct 2024 15:50:09 +0200, > Philipp Stanner wrote: > > > > On Tue, 2024-10-22 at 16:08 +0200, Takashi Iwai wrote: > > > On Tue, 15 Oct 2024 20:51:12 +0200, > > > Philipp Stanner wrote: >

Re: [PATCH 01/13] PCI: Prepare removing devres from pci_intx()

On Thu, 2024-10-31 at 14:45 +0100, Thomas Gleixner wrote: > On Tue, Oct 15 2024 at 20:51, Philipp Stanner wrote: > > +/** > > + * pci_intx - enables/disables PCI INTx for device dev, unmanaged > > version > > mismatch vs. actual function name. ACK, will fix > &g

Re: [PATCH 02/13] ALSA: hda_intel: Use always-managed version of pcim_intx()

On Thu, 2024-10-24 at 17:43 +0200, Takashi Iwai wrote: > On Thu, 24 Oct 2024 10:02:59 +0200, > Philipp Stanner wrote: > > > > On Wed, 2024-10-23 at 17:03 +0200, Takashi Iwai wrote: > > > On Wed, 23 Oct 2024 15:50:09 +0200, > > > Philipp Stanner wrote: > >

Re: [PATCH 02/13] ALSA: hda_intel: Use always-managed version of pcim_intx()

On Tue, 2024-10-22 at 16:08 +0200, Takashi Iwai wrote: > On Tue, 15 Oct 2024 20:51:12 +0200, > Philipp Stanner wrote: > > > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. To remove this hybrid nature from pci_intx(), it is &

[PATCH v2 10/11] HID: amd_sfh: Use always-managed version of pcim_intx()

(), which is why the driver needs the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Acked-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c| 4 ++-- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 +- 2 files changed, 3

[PATCH v2 04/11] net/ntb: Use never-managed version of pci_intx()

the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Acked-by: Shyam Sundar S K #for ntb_hw_amd.c --- drivers/ntb/hw/amd/ntb_hw_amd.c| 4 ++-- drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions

[PATCH v2 00/11] Remove implicit devres from pci_intx()

rrect behavior, not just the entire series as a whole. Merge plan for this is to enter through the PCI tree. [1] https://lore.kernel.org/all/20241009083519.10088-1-pstan...@redhat.com/ Regards, P. Philipp Stanner (11): PCI: Prepare removing devres from pci_intx() drivers/xen: Use never-

[PATCH v2 02/11] drivers/xen: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Acked-by: Juergen Gross --- drivers/xen/xen-pciback/conf_space_header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen

[PATCH v2 11/11] Remove devres from pci_intx()

(). Consequently, pci_intx_unmanaged() is now redundant, because pci_intx() itself is now unmanaged. Remove the devres functionality from pci_intx(). Have all users of pci_intx_unmanaged() call pci_intx(). Remove pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader

[PATCH v2 01/11] PCI: Prepare removing devres from pci_intx()

-by: Philipp Stanner Reviewed-by: Damien Le Moal --- drivers/pci/devres.c | 24 +++- drivers/pci/pci.c| 29 + include/linux/pci.h | 2 ++ 3 files changed, 34 insertions(+), 21 deletions(-) diff --git a/drivers/pci/devres.c b/drivers/pci

[PATCH v2 09/11] wifi: qtnfmac: use always-managed version of pcim_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Acked-by: Kalle Valo --- drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c b/drivers/net

[PATCH v2 07/11] PCI: MSI: Use never-managed version of pci_intx()

-managed version pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/pci/msi/api.c | 2 +- drivers/pci/msi/msi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c index b956ce591f96..c95e2e7dc9ab 100644 --- a/drivers

[PATCH v2 03/11] net/ethernet: Use never-managed version of pci_intx()

, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/brocade/bna/bnad.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 08/11] ata: Use always-managed version of pci_intx()

the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Reviewed-by: Sergey Shtylyov Acked-by: Niklas Cassel --- drivers/ata/ahci.c | 2 +- drivers/ata/ata_piix.c | 2 +- drivers/ata/pata_rdc.c | 2 +- drivers/ata/sata_sil24.c | 2 +- drivers/ata

[PATCH v2 06/11] vfio/pci: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/vfio/pci/vfio_pci_core.c | 2 +- drivers/vfio/pci/vfio_pci_intrs.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio

[PATCH v2 05/11] misc: Use never-managed version of pci_intx()

(). Thus, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader/rtsx_pcr.c | 2 +- drivers/misc/tifm_7xx1.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc

Re: [PATCH v2 01/11] PCI: Prepare removing devres from pci_intx()

On Wed, 2024-11-13 at 17:04 +0100, Thomas Gleixner wrote: > On Wed, Nov 13 2024 at 13:41, Philipp Stanner wrote: > > +/** > > + * pci_intx_unmanaged - enables/disables PCI INTx for device dev, > > + * unmanaged version > > + * @pdev: the PCI device to operate on > &

Re: [PATCH 00/13] Remove implicit devres from pci_intx()

On Thu, 2024-10-31 at 10:19 +0100, Takashi Iwai wrote: > On Wed, 30 Oct 2024 23:17:37 +0100, > Bjorn Helgaas wrote: > > > > On Tue, Oct 15, 2024 at 08:51:10PM +0200, Philipp Stanner wrote: > > > @Driver-Maintainers: Your driver might be touched by patch > > >

Re: [PATCH v2 11/11] Remove devres from pci_intx()

On Fri, 2024-11-15 at 01:46 +0100, Thomas Gleixner wrote: > On Thu, Nov 14 2024 at 10:05, Philipp Stanner wrote: > > On Wed, 2024-11-13 at 17:22 +0100, Thomas Gleixner wrote: > > > On Wed, Nov 13 2024 at 13:41, Philipp Stanner wrote: > > > > pci_intx() is a hybrid f

Re: [PATCH v2 11/11] Remove devres from pci_intx()

On Wed, 2024-11-13 at 17:22 +0100, Thomas Gleixner wrote: > On Wed, Nov 13 2024 at 13:41, Philipp Stanner wrote: > > pci_intx() is a hybrid function which can sometimes be managed > > through > > devres. This hybrid nature is undesirable. > > > > Since all use

[PATCH v3 09/11] wifi: qtnfmac: use always-managed version of pcim_intx()

-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Acked-by: Kalle Valo --- drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c b/drivers/net

[PATCH v3 05/11] misc: Use never-managed version of pci_intx()

(). Thus, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader/rtsx_pcr.c | 2 +- drivers/misc/tifm_7xx1.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc

[PATCH v3 08/11] ata: Use always-managed version of pci_intx()

the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Reviewed-by: Sergey Shtylyov Acked-by: Niklas Cassel --- drivers/ata/ahci.c | 2 +- drivers/ata/ata_piix.c | 2 +- drivers/ata/pata_rdc.c | 2 +- drivers/ata/sata_sil24.c | 2 +- drivers/ata

[PATCH v3 01/11] PCI: Prepare removing devres from pci_intx()

-by: Philipp Stanner Reviewed-by: Damien Le Moal --- drivers/pci/devres.c | 24 +++- drivers/pci/pci.c| 29 + include/linux/pci.h | 2 ++ 3 files changed, 34 insertions(+), 21 deletions(-) diff --git a/drivers/pci/devres.c b/drivers/pci

[PATCH v3 00/11] Remove implicit devres from pci_intx()

t each checked out commit should provide correct behavior, not just the entire series as a whole. Merge plan for this is to enter through the PCI tree. [1] https://lore.kernel.org/all/20241009083519.10088-1-pstan...@redhat.com/ Regards, P. Philipp Stanner (11): PCI: Prepare removing devres

[PATCH v3 04/11] net/ntb: Use never-managed version of pci_intx()

the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Acked-by: Shyam Sundar S K #for ntb_hw_amd.c Acked-by: Dave Jiang # for ntb_hw_gen1.c --- drivers/ntb/hw/amd/ntb_hw_amd.c| 4 ++-- drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +- 2 files

[PATCH v3 06/11] vfio/pci: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/vfio/pci/vfio_pci_core.c | 2 +- drivers/vfio/pci/vfio_pci_intrs.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio

[PATCH v3 03/11] net/ethernet: Use never-managed version of pci_intx()

, they need the never-managed version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/brocade/bna/bnad.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v3 02/11] drivers/xen: Use never-managed version of pci_intx()

version. Replace pci_intx() with pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Acked-by: Juergen Gross --- drivers/xen/xen-pciback/conf_space_header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/xen-pciback/conf_space_header.c b/drivers/xen/xen

[PATCH v3 10/11] HID: amd_sfh: Use always-managed version of pcim_intx()

(), which is why the driver needs the always-managed version. Replace pci_intx() with pcim_intx(). Signed-off-by: Philipp Stanner Acked-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/amd_sfh_pcie.c| 4 ++-- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 +- 2 files changed, 3

[PATCH v3 07/11] PCI: MSI: Use never-managed version of pci_intx()

-managed version pci_intx_unmanaged(). Signed-off-by: Philipp Stanner Reviewed-by: Thomas Gleixner --- drivers/pci/msi/api.c | 2 +- drivers/pci/msi/msi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c index b956ce591f96

[PATCH v3 11/11] Remove devres from pci_intx()

(). Consequently, pci_intx_unmanaged() is now redundant, because pci_intx() itself is now unmanaged. Remove the devres functionality from pci_intx(). Have all users of pci_intx_unmanaged() call pci_intx(). Remove pci_intx_unmanaged(). Signed-off-by: Philipp Stanner --- drivers/misc/cardreader