etPageOffline(pages[i]);
> balloon_append(pages[i]);
didn't you forget {} there? ;-)
> }
>
> --
> 2.17.2
>
--
Oscar Salvador
SUSE L3
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
David,
I would like to review this but I am on vacation, so I will not be able to get
to it
soon.
I plan to do it once I am back.
Thanks
--
Oscar Salvador
SUSE L3
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.or
this is only called from the boot stage.
And what about the prefetch operations?
I saw that you removed them in your previous patch and that had some benefits
[1].
Should we remove them here as well?
[1] https://patchwork.kernel.org/patch/10613359/
Thanks
--
Oscar Sal
On Thu, Sep 27, 2018 at 11:25:51AM +0200, David Hildenbrand wrote:
> Reviewed-by: Pavel Tatashin
> Reviewed-by: Rashmica Gupta
> Signed-off-by: David Hildenbrand
Reviewed-by: Oscar Salvador
--
Oscar Salvador
SUSE L3
___
Xen-devel mailing
On Thu, Sep 27, 2018 at 11:25:54AM +0200, David Hildenbrand wrote:
> Cc: Jonathan Corbet
> Cc: Michal Hocko
> Cc: Andrew Morton
> Reviewed-by: Pavel Tatashin
> Reviewed-by: Rashmica Gupta
> Signed-off-by: David Hildenbrand
Reviewed-by: Oscar Salvador
--
Osca
On Thu, Sep 27, 2018 at 11:25:49AM +0200, David Hildenbrand wrote:
> Reviewed-by: Pavel Tatashin
> Reviewed-by: Rafael J. Wysocki
> Reviewed-by: Rashmica Gupta
> Signed-off-by: David Hildenbrand
Reviewed-by: Oscar Salvador
--
Oscar Salv
On Thu, Sep 27, 2018 at 11:25:50AM +0200, David Hildenbrand wrote:
> Reviewed-by: Pavel Tatashin
> Reviewed-by: Rafael J. Wysocki
> Reviewed-by: Rashmica Gupta
> Signed-off-by: David Hildenbrand
Reviewed-by: Oscar Salvador
--
Oscar Salv
1 ms, hence
> improving the hot add latency by 60%. Modify external
> providers of online callback to align with the change.
>
> Signed-off-by: Arun KS
Looks good to me.
Reviewed-by: Oscar Salvador
Just one thing below:
> @@ -1331,7 +1331,7 @@ void __init __free_page
1 ms, hence
> improving the hot add latency by 60%. Modify external
> providers of online callback to align with the change.
Hi Arun, out of curiosity:
could you please explain how exactly did you mesure the speed
improvement?
Thanks
--
Osca
= online_pages_blocks(start_pfn, nr_pages);
> + t2 = local_clock();
> + trace_printk("time spend = %llu us\n", (t2-t1)/(1000));
>
> online_mem_sections(start_pfn, start_pfn + nr_pages);
Thanks ;-)
--
Oscar Salvador
SUSE L3
On Fri, 2018-11-23 at 13:37 +0100, David Hildenbrand wrote:
> Signed-off-by: David Hildenbrand
Thanks ;-)
Reviewed-by: Oscar Salvador
--
Oscar Salvador
SUSE L3
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.
r the type - should
> be good enough for internal purposes.
>
> Cc: Andrew Morton
> Cc: Alexander Duyck
> Cc: Mel Gorman
> Cc: Michal Hocko
> Cc: Dave Hansen
> Cc: Vlastimil Babka
> Cc: Wei Yang
> Cc: Oscar Salvador
> Cc: Mike Rapoport
> Signed-off-by: Davi
bserve a degradation due to the changed page isolation
> behavior (which I doubt), we can always make this configurable by the
> instance triggering undo of isolation (e.g., alloc_contig_range(),
> memory onlining, memory offlining).
>
> Cc: Andrew Morton
> Cc: Alexander Duyck
>
t; Cc: Alexander Duyck
> Cc: Mel Gorman
> Cc: Michal Hocko
> Cc: Dave Hansen
> Cc: Vlastimil Babka
> Cc: Wei Yang
> Cc: Oscar Salvador
> Cc: Mike Rapoport
> Cc: Scott Cheloha
> Cc: Michael Ellerman
> Signed-off-by: David Hildenbrand
LGTM.
Feel the same way ab
with page's refcount
(two before this patch).
Why do we have this dance in place?
Thanks
--
Oscar Salvador
SUSE L3
;s refcount to be 1 for the
put_page_testzero to trigger (and since you are decrementing it anyways),
I think it would be much clear for those two to be gone.
But not strong, so:
Reviewed-by: Oscar Salvador
--
Oscar Salvador
SUSE L3
c: Jason Wang
> Cc: Boris Ostrovsky
> Cc: Juergen Gross
> Cc: Stefano Stabellini
> Cc: Pankaj Gupta
> Cc: Michal Hocko
> Cc: Oscar Salvador
> Cc: Anshuman Khandual
> Cc: Wei Yang
> Cc: linux-hyp...@vger.kernel.org
> Cc: virtualizat...@lists.linux-foundation.org
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: David Hildenbrand
Reviewed-by: Oscar Salvador
--
Oscar Salvador
SUSE L3
d it
is
achieved by a little amount of extra code mostly in page_owner.c/ and
lib/stackdepot.
Of course, your works seems to be more complete wrt. the information you get.
I CCed you in case you want to have a look
[1] https://lkml.org/lkml/2022/9/1/36
Thanks
--
Oscar Salvador
SUSE Labs
arly()
totalram_pages_add(pages);
but that is not ahead, it looks like it is upading __after__ sending
them to buddy?
--
Oscar Salvador
SUSE Labs
We usually skip PageReserved pages in walkers because are pages we cannot deal
with for those purposes, but with this change, we will leak
PageVmemmapSelfHosted, and I am not sure whether are ready for that.
Moreover, boot memmap pages are marked as PageReserved, which would be
now inconsistent with those added during hotplug operations.
All in all, I feel uneasy about this change.
--
Oscar Salvador
SUSE Labs
can get rid of that hack,
> and document the situation.
>
> Signed-off-by: David Hildenbrand
Acked-by: Oscar Salvador
--
Oscar Salvador
SUSE Labs
On Mon, Jun 10, 2024 at 10:38:05AM +0200, David Hildenbrand wrote:
> On 10.06.24 06:03, Oscar Salvador wrote:
> > On Fri, Jun 07, 2024 at 11:09:36AM +0200, David Hildenbrand wrote:
> > > In preparation for further changes, let's teach __free_pages_core()
> > >
ry gets removed.
Ok, just wanted to convince myself that there will no be surprises.
Thanks David for claryfing.
--
Oscar Salvador
SUSE Labs
; PageOffline() pages is 1.
>
> Update virtio-mem, HV-balloon and XEN-balloon code to be aware that
> hotplugged pages are now PageOffline() instead of PageReserved() before
> they are handed over to the buddy.
>
> We'll leave the ZONE_DEVICE case alone for now.
>
> S
24 matches
Mail list logo
