Michael Tokarev writes:
> 21.01.2019 18:17, Peter Maydell wrote:
>> On Mon, 21 Jan 2019 at 14:49, Anthony PERARD
>> wrote:
>>>
>>> When Xen is detected via pkg-config, it isn't necessary to modify
>>> LDFLAGS as modifying libs_softmmu is enough.
>>>
>>> Reported-by: Peter Maydell
>>> Signed-of
Patch created mechanically by rerunning:
$ spatch --sp-file scripts/coccinelle/qobject.cocci \
--macro-file scripts/cocci-macro-file.h \
--dir hw/block --in-place
Signed-off-by: Markus Armbruster
---
hw/block/xen-block.c | 4 ++--
1 file changed, 2 insertions
Kevin Wolf writes:
> Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
>> Patch created mechanically by rerunning:
>>
>> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
>> --macro-file scripts/cocci-macro-file.h \
>>
Anthony PERARD writes:
> On Thu, Mar 14, 2019 at 08:04:00PM +0100, Markus Armbruster wrote:
>> Kevin Wolf writes:
>>
>> > Am 13.03.2019 um 18:44 hat Markus Armbruster geschrieben:
>> >> Patch created mechanically by rerunning:
>> >>
Markus Armbruster writes:
> Dear board code maintainers,
>
> This is a (rather late) follow-up to the last QEMU summit. Minutes[*]:
>
> * Deprecating unmaintained features (devices, targets, backends) in QEMU
>
>QEMU has a mechanism to deprecate features but there rema
Anthony PERARD writes:
> On Tue, Mar 19, 2019 at 07:34:45PM +0100, Markus Armbruster wrote:
>> = hw/xenpv/xen_machine_pv.c =
>> Stefano Stabellini (supporter:X86)
>> Anthony Perard (supporter:X86)
>> Paul Durrant (supporter:X86)
>> xen
Please accept my sincere apologies for taking so long to reply. A few
thoughts before I dig deeper.
Vladimir Sementsov-Ogievskiy writes:
> Hi all!
>
> At the request of Markus: full version of errp propagation. Let's look
> at it. Cover as much as possible, except inserting macro invocation
> w
Vladimir Sementsov-Ogievskiy writes:
> 28.11.2019 11:54, Markus Armbruster wrote:
>> Please accept my sincere apologies for taking so long to reply. A few
>> thoughts before I dig deeper.
>>
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Hi all!
>
olo Bonzini
> CC: Stefan Hajnoczi
> CC: Fam Zheng
> CC: Stefan Weil
> CC: Ronnie Sahlberg
> CC: Peter Lieven
> CC: Eric Blake
> CC: "Denis V. Lunev"
> CC: Markus Armbruster
> CC: Alberto Garcia
> CC: Jason Dillaman
> CC: Wen Congyang
> CC: Xie C
Vladimir Sementsov-Ogievskiy writes:
> 04.12.2019 17:59, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of
>>> functions with errp OUT parameter.
>>>
>>
Vladimir Sementsov-Ogievskiy writes:
> 05.12.2019 17:58, Vladimir Sementsov-Ogievskiy wrote:
>> 05.12.2019 15:36, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy writes:
>>>
>>>> 04.12.2019 17:59, Markus Armbruster wrote:
>>>>> V
Olaf Hering writes:
> On Fri, Nov 02, Kevin Wolf wrote:
>
>> A while ago, a downstream patch review found out that there are some QMP
>> commands that would immediately crash if a xen_disk device were present
>> because of the lacking qdevification. This is not the code quality
>> standard I envi
Thomas Huth writes:
> The last user of blk_attach_dev_legacy() is the code in xen_disk.c.
> It passes a pointer to a XenBlkDev as second parameter. XenBlkDev
> is derived from XenDevice which in turn is derived from DeviceState
> since commit 3a6c9172ac5951e ("xen: create qdev for each backend de
ps would be ineffective (ii) given only a uid we don't
> know what gid we ought to use (since uids may eppear in multiple
> passwd file entries with different gids).
>
> Signed-off-by: Ian Jackson
> Reviewed-by: Anthony PERARD
> CC: Paolo Bonzini
> CC: Markus Armbru
Ian Jackson writes:
> Thanks for the review. Taking your comments out of order slightly:
>
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide
> new -runas : facility"):
>> [change_process_uid] is the only user of @user_pwd, @user_uid
Ian Jackson writes:
> Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 08/12] os-posix: Provide
> new -runas : facility"):
>> Ian Jackson writes:
>> > That would defer the getpwnam from argument parsing to os_setup_post.
>> > I think that's un
$ ./configure --help | grep -C 3 xen-pci-passthrough
virtfs VirtFS
mpath Multipath persistent reservation passthrough
xen xen backend driver support
xen-pci-passthrough
brlapi BrlAPI (Braile)
curlcurl connectivity
membarrier mem
ps would be ineffective (ii) given only a uid we don't
> know what gid we ought to use (since uids may eppear in multiple
> passwd file entries with different gids).
>
> Signed-off-by: Ian Jackson
> Reviewed-by: Anthony PERARD
> CC: Paolo Bonzini
> CC: Markus Armbruster
Philippe Mathieu-Daudé writes:
> On 04/19/2018 01:45 PM, Ian Jackson wrote:
>> perror() is defined to fprintf(stderr,...). HACKING says
>> fprintf(stderr,...) is wrong. So perror() is too.
>>
>> Signed-off-by: Ian Jackson
>> CC: Paolo Bonzini
>>
Ping?
Markus Armbruster writes:
> $ ./configure --help | grep -C 3 xen-pci-passthrough
> virtfs VirtFS
> mpath Multipath persistent reservation passthrough
> xen xen backend driver support
> xen-pci-passthrough
> brlapi BrlAPI
32_t writable_mask = 0;
> uint32_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
> pcibus_t r_size = 0;
Reviewed-by: Markus Armbruster
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Philippe Mathieu-Daudé writes:
> Nothing exciting here, patches created mechanically
> (common after soft freeze).
Cc: qemu-trivial
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
Marc-André Lureau writes:
> This is mostly for readability of the code. Let's make it clear which
> callers can create an implicit monitor when the chardev is muxed.
>
> This will also enforce a safer behaviour, as we don't really support
> creating monitor anywhere/anytime at the moment.
>
> The
Marc-André Lureau writes:
> Hi
> On Fri, Aug 24, 2018 at 9:37 AM Markus Armbruster wrote:
>>
>> Marc-André Lureau writes:
>>
>> > This is mostly for readability of the code. Let's make it clear which
>> > callers can create an implicit monitor
Paul Durrant writes:
>> -Original Message-
>> From: Kevin Wolf [mailto:kw...@redhat.com]
>> Sent: 02 November 2018 11:04
>> To: Tim Smith
>> Cc: xen-devel@lists.xenproject.org; qemu-de...@nongnu.org; qemu-
>> bl...@nongnu.org; Anthony Perard ; Paul Durrant
>> ; Stefano Stabellini ;
>> Ma
Philippe Mathieu-Daudé writes:
> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize()
> with the ability to return a boolean value if an error occured,
> thus the caller does not need to check if the Error* pointer is
> set.
> Provide the same ability to the BusRealize type.
>
> Signed
Philippe Mathieu-Daudé writes:
> On 9/21/20 10:19 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize()
>>> with the ability to return a boolean value if an error occured,
>>&
Philippe Mathieu-Daudé writes:
> Reduce the machine code pulled into qemu-storage-daemon.
I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
Juan for PATCH 5. David already ACKed.
Can do the pull request.
Paolo Bonzini writes:
> On 05/10/20 10:01, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Reduce the machine code pulled into qemu-storage-daemon.
>> I'm leaving review to Eduardo and Marcel for PATCH 1-4, and to David and
>&g
The other users of qmp_object_add() passes an initialised
> 'ret_data', so we should do the same I think.
Since the QMP core does it, other callers should do it, too.
For QAPI commands that don't return anything, the marshaller should not
use @ret_data, let alone store through it. qmp_object_add() complies.
Thus, assert(!ret_data) would do. qobject_unref(ret_data) is also
correct.
Reviewed-by: Markus Armbruster
e, i.e. when we're in undefined behavior country.
Preferably with this argument worked into your commit message:
Reviewed-by: Markus Armbruster
There are many similar macros. Should they get the same treatment?
.
Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Markus Armbruster
---
hw/xen/xen_pt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xen/xen_pt.c b
.
Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Markus Armbruster
Reviewed-by: Paul Durrant
---
hw/xen/xen_pt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff
ixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Gerd Hoffmann
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Markus Armbruster
---
hw/usb/xen-usb.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/hw/usb/xen-usb.c b/hw/usb
Paul Durrant writes:
>> -Original Message-
>> From: Markus Armbruster
>> Sent: 24 April 2020 20:20
>> To: qemu-de...@nongnu.org
>> Cc: Stefano Stabellini ; Anthony Perard
>> ; Paul
>> Durrant ; Gerd Hoffmann ;
>> xen-devel@lists.xenpr
.
Fixes: 5a11d0f7549e24a10e178a9dc8ff5e698031d9a6
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Markus Armbruster
Reviewed-by: Paul Durrant
Message-Id: <20200422130719.28225-10-arm...@redhat.com>
---
hw/xen/xen_pt.
ixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Gerd Hoffmann
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Markus Armbruster
---
hw/usb/xen-usb.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/hw/usb/xen-usb.c b/hw/usb
we already know the
> pointer is of DeviceState type.
>
> Patch created mechanically using spatch with this script:
>
> @@
> typedef DeviceState;
> DeviceState *s;
> @@
> - DEVICE(s)
> + s
>
> Acked-by: David Gibson
> Acked-by: Paul Durrant
&g
y using spatch with this script:
>
> @@
> typedef CPUState;
> CPUState *s;
> @@
> - CPU(s)
> + s
>
> Acked-by: David Gibson
> Reviewed-by: Cédric Le Goater
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
d-off-by: Philippe Mathieu-Daudé
> ---
> v2: Reword (Markus)
My rewording suggestion applied to PATCH 3, not to this one.
With v2's commit message;
Reviewed-by: Markus Armbruster
;
> @@
> typedef Object;
> Object *o;
> @@
> - OBJECT(o)
> + o
>
> Acked-by: Cornelia Huck
> Acked-by: Corey Minyard
> Acked-by: John Snow
> Reviewed-by: Richard Henderson
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Markus Armbruster
Philippe Mathieu-Daudé writes:
> Remove unnecessary casts using coccinelle scripts.
>
> The CPU()/OBJECT() patches don't introduce logical change,
> The DEVICE() one removes various OBJECT_CHECK() calls.
Queued, thanks!
Managing expecations: I'm not a QOM maintainer, I don't want to become
one,
Paolo Bonzini writes:
> On 15/05/20 07:58, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Remove unnecessary casts using coccinelle scripts.
>>>
>>> The CPU()/OBJECT() patches don't introduce logical change,
>>&g
Cédric Le Goater writes:
> On 5/18/20 3:17 PM, Markus Armbruster wrote:
>> Paolo Bonzini writes:
>>
>>> On 15/05/20 07:58, Markus Armbruster wrote:
>>>> Philippe Mathieu-Daudé writes:
>>>>
>>>>> Remove unnecessary casts using c
eu-Daudé"
> CC: Laszlo Ersek
> CC: Gerd Hoffmann
> CC: Stefan Berger
> CC: Markus Armbruster
> CC: Michael Roth
> CC: qemu-bl...@nongnu.org
> CC: xen-devel@lists.xenproject.org
>
> include/qapi/error.h | 26 ++
> 1 file changed, 26
d-by: Eric Blake
> ---
>
> CC: Eric Blake
> CC: Kevin Wolf
> CC: Max Reitz
> CC: Greg Kurz
> CC: Stefano Stabellini
> CC: Anthony Perard
> CC: Paul Durrant
> CC: Stefan Hajnoczi
> CC: "Philippe Mathieu-Daudé"
> CC: Laszlo Ersek
>
Vladimir Sementsov-Ogievskiy writes:
> 21.02.2020 12:19, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of
>>> functions with an errp OUT parameter.
>>>
>>
Vladimir Sementsov-Ogievskiy writes:
> 21.02.2020 10:38, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Add functions to clean Error **errp: call corresponding Error *err
>>> cleaning function an set pointer to NULL.
>>>
Vladimir Sementsov-Ogievskiy writes:
> 21.02.2020 19:34, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 21.02.2020 10:38, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy writes:
>>>>
>>>>> Add
> CC: Stefano Stabellini
> CC: Anthony Perard
> CC: Paul Durrant
> CC: Stefan Hajnoczi
> CC: "Philippe Mathieu-Daudé"
> CC: Laszlo Ersek
> CC: Gerd Hoffmann
> CC: Stefan Berger
> CC: Markus Armbruster
> CC: Michael Roth
&g
Vladimir Sementsov-Ogievskiy writes:
> 23.02.2020 11:55, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
>>> does corresponding changes in code (look for de
Vladimir Sementsov-Ogievskiy writes:
> 25.02.2020 15:52, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 23.02.2020 11:55, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy writes:
>>>>
>>>>> Scr
Hi Vladimir,
I've come to rather like your ERRP_AUTO_PROPAGATE() idea. What I
wouldn't like is a protracted conversion.
Once we're happy with PATCH 1-3, it's a matter of running Coccinelle and
reviewing its output. I'm confident we can converge on PATCH 1-3.
It's two weeks until soft freeze.
Vladimir Sementsov-Ogievskiy writes:
> 23.02.2020 11:55, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
>>> does corresponding changes in code (look for de
Alexey Kirillov writes:
> Add a qmp command that provides information about currently attached
> network devices and their configuration.
Closes a gap in QMP; appreciated!
> Signed-off-by: Alexey Kirillov
[...]
> diff --git a/qapi/net.json b/qapi/net.json
> index 1cb9a7d782..4f329a1de0 100644
Vladimir Sementsov-Ogievskiy writes:
> File with errp-cleaning APIs dropped for two reasons:
>
> 1. I'm tired after a 3-days war with coccinelle, and don't want to add more
>patches here.
Oww. In my experience, Coccinelle is both awesome and terrible. I hope
you didn't do all that work jus
t; Cc: Stefan Hajnoczi
> Cc: "Philippe Mathieu-Daudé"
> Cc: Laszlo Ersek
> Cc: Gerd Hoffmann
> Cc: Stefan Berger
> Cc: Markus Armbruster
> Cc: Michael Roth
> Cc: qemu-bl...@nongnu.org
> Cc: qemu-de...@nongnu.org
> Cc: xen-devel@lists.xenproject.org
>
>
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>> Suggest
>>
>> scripts: Coccinelle script to use auto-propagated errp
>>
>> or
>>
>> scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
>>
>
Vladimir Sementsov-Ogievskiy writes:
> 10.03.2020 18:47, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 09.03.2020 12:56, Markus Armbruster wrote:
>>>> Suggest
>>>>
>>>> scripts: Coccinelle script to u
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>>> +
>>> +// Convert error clearing functions
>> Suggest: Ensure @local_err is cleared on free
>
> But there is no local_err after conversion
True. Hmm. What about this:
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>> Suggest
>>
>> scripts: Coccinelle script to use auto-propagated errp
>>
>> or
>>
>> scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE
I think a v9 makes sense now.
If any of the improvement ideas should turn into time sinks for you,
let's talk. We don't need perfection, we only need to get to the point
where we trust the script to do what we believe it does, understand its
limitations, and know how to compensate for them.
Righ
Vladimir Sementsov-Ogievskiy writes:
> 11.03.2020 12:38, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 09.03.2020 12:56, Markus Armbruster wrote:
>>>> Suggest
>>>>
>>>> scripts: Coccinelle script to u
Vladimir Sementsov-Ogievskiy writes:
> 11.03.2020 17:41, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 11.03.2020 12:38, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy writes:
>>>>
>>>>
Vladimir Sementsov-Ogievskiy writes:
> v9
> 01: A lot of rewordings [thanks to Eric]
> Still, keep all r-b marks, assuming that they are mostly about macro
> definition
> 02: significant changes are:
> 1. Do not match double propagation pattern in ERRP_AUTO_PROPAGATE-adding
> rule
>
in Wolf
> Cc: Max Reitz
> Cc: Greg Kurz
> Cc: Christian Schoenebeck
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: Stefan Hajnoczi
> Cc: "Philippe Mathieu-Daudé"
> Cc: Laszlo Ersek
> Cc: Gerd Hoffmann
> Cc: Stefan Berg
Vladimir Sementsov-Ogievskiy writes:
[...]
> +// Warn several Error * definitions.
> +@check1 disable optional_qualifier exists@
> +identifier fn = rule1.fn, local_err, local_err2;
> +@@
> +
> + fn(..., Error ** , ...)
> + {
> + ...
> + Error *local_err = NULL;
> + ... when any
>
I tried this script on the whole tree. Observations:
* $ git-diff --shortstat \*.[ch]
333 files changed, 3480 insertions(+), 4586 deletions(-)
* Twelve functions have "several definitions of Error * local variable".
Eight declare such a variable within a loop. Reported because
Coccinell
Vladimir Sementsov-Ogievskiy writes:
> 13.03.2020 10:50, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>> [...]
>>> +// Warn several Error * definitions.
>>> +@check1 disable optional_qualifier exists@
>>>
Vladimir Sementsov-Ogievskiy writes:
> 12.03.2020 19:36, Markus Armbruster wrote:
>> I may have a second look tomorrow with fresher eyes, but let's get this
>> out now as is.
>>
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Script adds ERRP_AUTO_P
Vladimir Sementsov-Ogievskiy writes:
> 13.03.2020 18:42, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 12.03.2020 19:36, Markus Armbruster wrote:
>>>> I may have a second look tomorrow with fresher eyes, but let's get th
Eric Blake writes:
> On 3/13/20 4:54 PM, Markus Armbruster wrote:
>
>>
>> I append my hacked up version of auto-propagated-errp.cocci. It
>> produces the same patch as yours for the complete tree.
>>
>>
>>
>> // Use ERRP_AUTO_PROPAGATE (see
Vladimir Sementsov-Ogievskiy writes:
> On 14.03.2020 00:54, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 13.03.2020 18:42, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy writes:
>>>>
>>>>>
Vladimir Sementsov-Ogievskiy writes:
> 03.03.2020 11:01, Markus Armbruster wrote:
>> Hi Vladimir,
>>
>> I've come to rather like your ERRP_AUTO_PROPAGATE() idea. What I
>> wouldn't like is a protracted conversion.
>>
>> Once we're happy w
Vladimir Sementsov-Ogievskiy writes:
> 16.03.2020 11:21, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> On 14.03.2020 00:54, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy writes:
>>>>
>>>>
Vladimir Sementsov-Ogievskiy writes:
> 14.03.2020 0:54, Markus Armbruster wrote:
[...]
>> // Match functions with propagation of local error to errp.
>> // We want to refer these functions in several following rules, but I
>> // don't know a proper way to inherit a f
Vladimir Sementsov-Ogievskiy writes:
> 17.03.2020 13:39, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 16.03.2020 11:21, Markus Armbruster wrote:
>>>> Vladimir Sementsov-Ogievskiy writes:
>>>>
>>>>>
Vladimir Sementsov-Ogievskiy writes:
> 19.03.2020 13:45, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
[...]
>>> So, understanding that there no such cases in the whole tree, and even
>>> if your patch works faster on the whole tree, I still don
efan Hajnoczi
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: "Philippe Mathieu-Daudé"
> Cc: Laszlo Ersek
> Cc: Gerd Hoffmann
> Cc: Stefan Berger
> Cc: Markus Armbruster
> Cc: Michael Roth
> Cc: qemu-de...@nongnu.org
> Cc: q
Vladimir Sementsov-Ogievskiy writes:
> 20.03.2020 16:58, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
[...]
>>> I will not be surprised, if we missed some more interesting cases :)
>>> But we should proceed. What is our plan? Will you queue v10 for
Vladimir Sementsov-Ogievskiy writes:
> Markus, what about this? Should I respin?
I still haven't looked at this, must be frustrating for you, sorry!
I've been under water ever since my Christmas vacation... If you rather
want me to look at a v7 that addresses the review comments from others,
th
Daniel P. Berrangé writes:
> On Thu, Jul 16, 2020 at 02:37:04PM +0200, Philippe Mathieu-Daudé wrote:
>> Let blk_attach_dev() take an Error* object to return helpful
>> information. Adapt the callers.
>>
>> $ qemu-system-arm -M n800
>> qemu-system-arm: sd_init failed: cannot attach blk 'sd0'
ixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2
Cc: Stefano Stabellini
Cc: Anthony Perard
Cc: Paul Durrant
Cc: Gerd Hoffmann
Cc: xen-devel@lists.xenproject.org
Signed-off-by: Markus Armbruster
Message-Id: <20200505101908.6207-3-arm...@redhat.com>
Acked-by: Paul Durrant
---
hw/usb/xen-usb.c | 19 +--
1 fi
Roman Kagan writes:
> Several block device properties related to blocksize configuration must
> be in certain relationship WRT each other: physical block must be no
> smaller than logical block; min_io_size, opt_io_size, and
> discard_granularity must be a multiple of a logical block.
>
> To ensu
Greg Kurz writes:
> On Tue, 17 Mar 2020 18:16:17 +0300
> Vladimir Sementsov-Ogievskiy wrote:
>
>> Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of
>> functions with an errp OUT parameter.
>>
>> It has three goals:
>>
>> 1. Fix issue with error_fatal and error_prepend/error_app
Jason Andryuk writes:
> On Mon, Jun 22, 2020 at 5:17 PM Mark Cave-Ayland
> wrote:
>>
>> On 22/06/2020 21:33, Jason Andryuk wrote:
>>
>> > Hi,
>> >
>> > Running qemu devel for a Xen VM is failing an assert after the recent
>> > "qdev: Rework how we plug into the parent bus" sysbus changes.
>> >
>
Greg Kurz writes:
> On Mon, 15 Jun 2020 07:21:03 +0200
> Markus Armbruster wrote:
>
>> Greg Kurz writes:
>>
>> > On Tue, 17 Mar 2020 18:16:17 +0300
>> > Vladimir Sementsov-Ogievskiy wrote:
>> >
>> >> Introduce a new ERRP_AUTO_PRO
Anthony PERARD writes:
> On Wed, Jun 24, 2020 at 01:18:41PM +0100, Paul Durrant wrote:
>> From: Paul Durrant
>>
>> The generic pc_machine_initfn() calls pc_system_flash_create() which creates
>> 'system.flash0' and 'system.flash1' devices. These devices are then realized
>> by pc_system_flash_m
Philippe Mathieu-Daudé writes:
> On 6/30/20 5:44 PM, Paul Durrant wrote:
>>> -Original Message-
>>> From: Philippe Mathieu-Daudé
>>> Sent: 30 June 2020 16:26
>>> To: Paul Durrant ; xen-devel@lists.xenproject.org;
>>> qemu-de...@nongnu.org
>>> Cc: Eduardo Habkost ; Michael S. Tsirkin
>>
Jason Andryuk writes:
> On Wed, Jul 1, 2020 at 3:03 AM Paul Durrant wrote:
>>
>> > -Original Message-
>> > From: Philippe Mathieu-Daudé
>> > Sent: 30 June 2020 18:27
>> > To: p...@xen.org; xen-devel@lists.xenproject.org; qemu-de...@nongnu.org
>> > Cc: 'Eduardo Habkost' ; 'Michael S. Tsi
ewed-by: Greg Kurz
> Reviewed-by: Eric Blake
> ---
>
> Cc: Eric Blake
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: Greg Kurz
> Cc: Christian Schoenebeck
> Cc: Stefan Hajnoczi
> Cc: Stefano Stabellini
> Cc: Anthony Perard
> Cc: Paul Durrant
> Cc: "Phili
Philippe Mathieu-Daudé writes:
> On 7/3/20 11:08 AM, Vladimir Sementsov-Ogievskiy wrote:
>> If we want to add some info to errp (by error_prepend() or
>> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.
>> Otherwise, this info will not be added when errp == &error_fatal
>> (the pr
To speed things up, I'm taking the liberty to respin Vladimir's series
with my documentation amendments.
After my documentation work, I'm very much inclined to rename
ERRP_AUTO_PROPAGATE() to ERRP_GUARD(). The fact that it propagates
below the hood is detail. What matters to its users is that it
Wolf
Reported-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/nvram/fw_cfg.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/
Signed-off-by: Vladimir Sementsov-Ogievskiy
Acked-by: Greg Kurz
Reviewed-by: Christian Schoenebeck
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/9pfs/9p-local.c | 12 +---
hw/9pfs/9p.c | 1 +
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw
ed for clarity. Put ERRP_AUTO_PROPAGATE()
before its helpers, and touch up style. Commit message tweaked.]
Signed-off-by: Markus Armbruster
---
include/qapi/error.h | 160 ++-
1 file changed, 141 insertions(+), 19 deletions(-)
diff --git a/include/qapi/er
-macro-file.h --in-place --no-show-diff \
--max-width 80 FILES...
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
scripts/coccinelle/auto-propagated-errp.cocci | 337 ++
include/qapi/error.h
rted-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/sd/sdhci-pci.c | 7 +++
hw/sd/sdhci.c | 21 +
hw/sd/ssi-sd.c| 10 +-
3 files changed, 17 inserti
Wolf
Reported-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/block/pflash_cfi01.c | 7 +++
hw/block/pflash_cfi02.c | 7 +++
2 files changed, 6 insertions(+), 8 deletions(-)
diff
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Philippe Mathieu-Daudé
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
hw/block/dataplane/xen-block.c | 17 +++---
hw/block/xen-block.c | 102 ++---
hw/pci-host/xen_igd_pt.c |
1 - 100 of 184 matches
Mail list logo
