[PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD)

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 321a13e519..44691010bc 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -496,

[PATCH 09/24] Use xen/xenio.h on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/call/private.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libs/call/private.h b/tools/libs/call/private.h index 21f992b37e..96922e03d5 100644 --- a/tools/libs/call/private.h +++ b/tools/libs/call/private.h @@ -7,13 +7,19 @@ #include #includ

[PATCH 10/24] Make libs/evtchn build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/evtchn/netbsd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c index 8b8545d2f9..6d4ce28011 100644 --- a/tools/libs/evtchn/netbsd.c +++ b/tools/libs/evtchn/netbsd.c @@ -25,10 +25,10 @@ #include

[PATCH 11/24] Implement foreignmemory on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/foreignmemory/Makefile | 2 +- tools/libs/foreignmemory/netbsd.c | 76 ++ tools/libs/foreignmemory/private.h | 10 +++- 3 files changed, 75 insertions(+), 13 deletions(-) diff --git a/tools/libs/foreignmemory/Makefile b/tools/libs/foreignmemory/Makef

[PATCH 01/24] Fix lock directory path for NetBSD

2020-12-14 Thread Manuel Bouyer
--- m4/paths.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/paths.m4 b/m4/paths.m4 index 89d3bb8312..1c107b1a61 100644 --- a/m4/paths.m4 +++ b/m4/paths.m4 @@ -142,7 +142,7 @@ AC_SUBST(XEN_SCRIPT_DIR) case "$host_os" in *freebsd*) XEN_LOCK_DIR=$localstatedir/lib ;; -*

[PATCH 22/24] If PTHREAD_STACK_MIN is not defined, use DEFAULT_THREAD_STACKSIZE

2020-12-14 Thread Manuel Bouyer
--- tools/libs/store/xs.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c index 4ac73ec317..8e646b98d6 100644 --- a/tools/libs/store/xs.c +++ b/tools/libs/store/xs.c @@ -811,9 +811,13 @@ bool xs_watch(struct xs_handle *h, const char *path, cons

[PATCH 17/24] Make libs/light build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_uuid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_uuid.c b/tools/libs/light/libxl_uuid.c index dadb79bad8..a8ee5f253e 100644 --- a/tools/libs/light/libxl_uuid.c +++ b/tools/libs/light/libxl_uuid.c @@ -82,7 +82,7 @@ void

[PATCH 02/24] NetBSD doens't need xenbackendd with xl toolstack

2020-12-14 Thread Manuel Bouyer
--- tools/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/Makefile b/tools/Makefile index ed71474421..757a560be0 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -18,7 +18,6 @@ SUBDIRS-$(CONFIG_X86) += firmware SUBDIRS-y += console SUBDIRS-y += xenmon SUBDIRS-y += xentop -S

[PATCH 19/24] errno may not be a gobal R/W variable, use a local variable instead (fix build on NetBSD)

2020-12-14 Thread Manuel Bouyer
--- tools/xenpaging/xenpaging.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 33098046c2..39c8c83b4b 100644 --- a/tools/xenpaging/xenpaging.c +++ b/tools/xenpaging/xenpaging.c @@ -180,10 +180,11 @@ static in

[PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID

2020-12-14 Thread Manuel Bouyer
Pass bridge name to qemu When starting qemu, set an environnement variable XEN_DOMAIN_ID, to be used by qemu helper scripts --- tools/libs/light/libxl_dm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 3da83259c0..5

[PATCH 08/24] Make libs/call build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/call/netbsd.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/libs/call/netbsd.c b/tools/libs/call/netbsd.c index a5502da377..1a771e9928 100644 --- a/tools/libs/call/netbsd.c +++ b/tools/libs/call/netbsd.c @@ -19,12 +19,14 @@ * Split f

[PATCH 24/24] Fix error: array subscript has type 'char' [-Werror=char-subscripts]

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_qmp.c | 2 +- tools/xentrace/xentrace.c| 2 +- xen/tools/symbols.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_qmp.c b/tools/libs/light/libxl_qmp.c index c394000ea9..9b638e6f54 100644 --- a/tools/libs/light

[PATCH 16/24] Switch NetBSD to QEMU_XEN (!traditional)

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_netbsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_netbsd.c b/tools/libs/light/libxl_netbsd.c index e66a393d7f..31334f932c 100644 --- a/tools/libs/light/libxl_netbsd.c +++ b/tools/libs/light/libxl_netbsd.c @@ -110,7 +110,7

[PATCH 18/24] xeneventchn_stubs.c doens't need xen/sys/evtchn.h (NetBSD fix)

2020-12-14 Thread Manuel Bouyer
--- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index ba40078d09..f889a7a2e4 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/oc

[PATCH 06/24] Handle the case where vifname is not present in xenstore.

2020-12-14 Thread Manuel Bouyer
--- tools/hotplug/NetBSD/vif-bridge | 5 - tools/hotplug/NetBSD/vif-ip | 4 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/hotplug/NetBSD/vif-bridge b/tools/hotplug/NetBSD/vif-bridge index b58e922601..cd428b5936 100644 --- a/tools/hotplug/NetBSD/vif-bridge +++ b/t

[PATCH 21/24] Fix unused functions/variables error

2020-12-14 Thread Manuel Bouyer
--- tools/libs/stat/xenstat_netbsd.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tools/libs/stat/xenstat_netbsd.c b/tools/libs/stat/xenstat_netbsd.c index 6e9d6aee10..64eda9e1ae 100644 --- a/tools/libs/stat/xenstat_netbsd.c +++ b/tools/libs/stat/xenstat_netbsd.c @@ -55,11 +55,6

[PATCH 23/24] Use xen/xenio.h on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/ctrl/xc_private.h | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/ctrl/xc_private.h b/tools/libs/ctrl/xc_private.h index f0b5f83ac8..68e388f488 100644 --- a/tools/libs/ctrl/xc_private.h +++ b/tools/libs/ctrl/xc_private.h @@ -39,7 +39,11 @@ #include #include

Re: [PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID

2020-12-15 Thread Manuel Bouyer
On Mon, Dec 14, 2020 at 05:36:13PM +0100, Manuel Bouyer wrote: > Pass bridge name to qemu > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > to be used by qemu helper scripts This one is not NetBSD related, I should have sent is as a separate git mail ... I guess

Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 12:29:09PM +0100, Roger Pau Monné wrote: > I think you want tot CC the tools dev on this one, specially Ian who > knows how the Linux one is implemented and can likely give valuable > input. > > On Mon, Dec 14, 2020 at 05:36:04PM +0100, Manu

Re: [PATCH 06/24] Handle the case where vifname is not present in xenstore.

2021-01-04 Thread Manuel Bouyer
vifname is not always set. It may depend on the Xen version ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH 07/24] Remove NetBSD's system headers. We'll use the system-provided ones, which are up to date.

2021-01-04 Thread Manuel Bouyer
gate the newly > added code to only be built when the headers are available. I prefer to have the build fail if the system isn't new enough, than have it build and then fail to run. We already have version requirements for e.g. bug fixes. -- Manuel Bouyer NetBSD: 26 ans d'e

Re: [PATCH 10/24] Make libs/evtchn build on NetBSD

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 12:52:43PM +0100, Roger Pau Monné wrote: > On Mon, Dec 14, 2020 at 05:36:09PM +0100, Manuel Bouyer wrote: > > --- > > tools/libs/evtchn/netbsd.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/tools/

Re: [PATCH 12/24] Implement gnttab on NetBSD

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 12:16:01PM +0100, Roger Pau Monné wrote: > Might need some kind of log message, and will also required your > Signed-off-by (or from the original author of the patch). > > On Mon, Dec 14, 2020 at 05:36:11PM +0100, Manuel Bouyer wrote: > > --- >

Re: [PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD)

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 03:02:15PM +0100, Roger Pau Monné wrote: > On Mon, Dec 14, 2020 at 05:36:12PM +0100, Manuel Bouyer wrote: > > --- > > tools/libs/light/libxl_create.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git

Re: [PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 04:19:58PM +0100, Roger Pau Monné wrote: > On Mon, Dec 14, 2020 at 05:36:13PM +0100, Manuel Bouyer wrote: > > Pass bridge name to qemu > > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > > to be used by qemu helper scripts > >

Re: [PATCH 16/24] Switch NetBSD to QEMU_XEN (!traditional)

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 03:19:14PM +0100, Roger Pau Monné wrote: > On Mon, Dec 14, 2020 at 05:36:15PM +0100, Manuel Bouyer wrote: > > --- > > tools/libs/light/libxl_netbsd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools

Re: [PATCH 19/24] errno may not be a gobal R/W variable, use a local variable instead (fix build on NetBSD)

2021-01-04 Thread Manuel Bouyer
On Tue, Dec 29, 2020 at 03:38:53PM +0100, Roger Pau Monné wrote: > On Mon, Dec 14, 2020 at 05:36:18PM +0100, Manuel Bouyer wrote: > > --- > > tools/xenpaging/xenpaging.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/to

Re: [PATCH 20/24] If FILENAME_MAX is defined, use it instead of arbitrary value (fix format-truncation errors with GCC >= 7)

2021-01-04 Thread Manuel Bouyer
max and the paths above are 26 maximum > I think (27 with the nul character). On NetBSD d_name is 512 ... I guess this is why gcc complains. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH 11/24] Implement foreignmemory on NetBSD

2021-01-04 Thread Manuel Bouyer
pes are the dummy implementations > of osdep_xenforeignmemory_restrict, > osdep_xenforeignmemory_map_resource and > osdep_xenforeignmemory_unmap_resource. I think you at least need to > modify the condition below so that on NetBSD the dummy inlines are not > used? This is !defined(__NetBSD__) so it should not be used ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH 19/24] errno may not be a gobal R/W variable, use a local variable instead (fix build on NetBSD)

2021-01-04 Thread Manuel Bouyer
On Mon, Jan 04, 2021 at 11:56:14AM +0100, Manuel Bouyer wrote: > On Tue, Dec 29, 2020 at 03:38:53PM +0100, Roger Pau Monné wrote: > > On Mon, Dec 14, 2020 at 05:36:18PM +0100, Manuel Bouyer wrote: > > > --- > > > tools/xenpaging/xenpaging.c | 5 +++-- > > >

Re: [PATCH 07/24] Remove NetBSD's system headers. We'll use the system-provided ones, which are up to date.

2021-01-04 Thread Manuel Bouyer
Or just assume that version X of Xen needs version Y of NetBSD. This is already the case, because of bug fixes. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH 1/5] x86/vPCI: tolerate (un)masking a disabled MSI-X entry

2021-01-04 Thread Manuel Bouyer
On Mon, Jan 04, 2021 at 05:35:23PM +0100, Jan Beulich wrote: > Thanks. > > > Manuel, can we get confirmation that this fixes your issue? > > I'll give it some time before committing for him to confirm, > but I guess I'd like to time out by the end of the week. Y

Re: [PATCH 10/24] Make libs/evtchn build on NetBSD

2021-01-10 Thread Manuel Bouyer
On Mon, Jan 04, 2021 at 06:15:24PM +0100, Roger Pau Monné wrote: > On Mon, Jan 04, 2021 at 11:26:45AM +0100, Manuel Bouyer wrote: > > On Tue, Dec 29, 2020 at 12:52:43PM +0100, Roger Pau Monné wrote: > > > On Mon, Dec 14, 2020 at 05:36:09PM +0100, Manuel Bouyer wrote: > >

Re: [PATCH 12/24] Implement gnttab on NetBSD

2021-01-10 Thread Manuel Bouyer
On Mon, Jan 04, 2021 at 06:24:11PM +0100, Roger Pau Monné wrote: > On Mon, Jan 04, 2021 at 11:29:51AM +0100, Manuel Bouyer wrote: > > On Tue, Dec 29, 2020 at 12:16:01PM +0100, Roger Pau Monné wrote: > > > Might need some kind of log message, and will also required your > >

new (mostly) NetBSD patches

2021-01-12 Thread Manuel Bouyer
s, so the required fields will hopefully be there. I threat all of them as independant (which they are), so that I can work on the problematic ones without the need to resend the whole set. Roger, as this is from a new git repo, I didn't add any Reviewed-by tag as they're not strictly the sa

[PATCH] NetBSD: Fix lock directory path

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD the lock directory is in /var/run/ Signed-off-by: Manuel Bouyer --- m4/paths.m4 | 2 +- tools/configure | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/paths.m4 b/m4/paths.m4 index 89d3bb8312..1c107b1a61 100644 --- a/m4/paths.m4

[PATCH] NetBSD hotplug: Introduce locking functions

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD, some block device configuration requires serialisation. Introcuce locking functions, and use them in the block script where appropriate. Signed-off-by: Manuel Bouyer --- tools/hotplug/NetBSD/Makefile | 1 + tools/hotplug/NetBSD/block | 5 ++- tools

[PATCH] NetBSD hotplug: fix block unconfigure on destroy

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer When a domain is destroyed, xparams may not be available any more when the block script is called to unconfigure the vnd. Check xparam only at configure time, and just unconfigure any vnd present in the xenstore. Signed-off-by: Manuel Bouyer --- tools/hotplug/NetBSD/block

[PATCH] Fix error: array subscript has type 'char'

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Use unsigned char variable, or cast to (unsigned char), for tolower()/islower() and friends. Fix compiler error array subscript has type 'char' [-Werror=char-subscripts] Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_qmp.c | 2 +- tools/xentrace/xentrac

[PATCH] NetBSD hotplug: handle case where vifname is not present

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Some Xen version didn't set the vifname in xenstore; just build one if not present. Signed-off-by: Manuel Bouyer --- tools/hotplug/NetBSD/vif-bridge | 5 - tools/hotplug/NetBSD/vif-ip | 4 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/

[PATCH] NetBSD: remove xenbackendd

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer NetBSD doens't need xenbackendd with xl toolstack so don't build it. Remove now unused xenbackendd directory/files. Signed-off-by: Manuel Bouyer --- tools/Makefile | 1 - tools/xenbackendd/Makefile | 45 - tools/xenbackendd/xenbacken

[PATCH] NetBSD: use system-provided headers

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD use the system-provided headers for ioctl and related definitions, they are up to date and have more chances to match the kernel's idea of the ioctls and structures. Remove now-unused NetBSD/evtchn.h and NetBSD/privcmd.h. Don't fail install if xen/sys/*

[PATCH] libs/light: pass some infos to qemu

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Pass bridge name to qemu as command line option When starting qemu, set an environnement variable XEN_DOMAIN_ID, to be used by qemu helper scripts Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_dm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools

[PATCH] xenpaging.c: include errno.h

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer writable definition of errno on NetBSD. Signed-off-by: Manuel Bouyer --- tools/xenpaging/xenpaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenpaging/xenpaging.c b/tools/xenpaging/xenpaging.c index 33098046c2..6e5490315d 100644 --- a/tools/xenpaging

[PATCH] libs/light: fix uuid on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer NetBSD uses the same uuid library as FreeBSD. As this is in a __FreeBSD__ || __NetBSD__ block, just drop the #ifdef __FreeBSD__ and dead code. Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_uuid.c | 21 - 1 file changed, 21 deletions(-) diff

[PATCH] libs/light: Switch NetBSD to QEMU_XEN

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Switch NetBSD to QEMU_XEN. All 3 versions of libxl__default_device_model() now return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN, so remove it and just set b_info->device_model_version to LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN in libxl__domain_build_info_setdefault(). Signed-off

[PATCH] libs/gnttab: implement on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Implement gnttab interface on NetBSD. The kernel interface is different from FreeBSD so we can't use the FreeBSD version Signed-off-by: Manuel Bouyer --- tools/libs/gnttab/Makefile | 2 +- tools/libs/gnttab/netbsd.c | 267 + 2

[PATCH] libs/foreignmemory: Implement on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Implement foreignmemory interface on NetBSD. The compat interface is now used only on __sun__ Signed-off-by: Manuel Bouyer --- tools/libs/foreignmemory/Makefile | 2 +- tools/libs/foreignmemory/netbsd.c | 75 ++ tools/libs/foreignmemory

[PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD xen/sys/evtchn.h is not available any more. Just remove it as it's not needed. Signed-off-by: Manuel Bouyer --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs

[PATCH] libs/call: fix build on NetBSD

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Define PAGE_* if not already defined Catch up with osdep interface change. Signed-off-by: Manuel Bouyer --- tools/libs/call/netbsd.c | 19 +++ tools/libs/call/private.h | 6 -- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/tools

[PATCH] libs/evtchn: fix build on NetBSD.

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer use xenio3.h for ioctl definitions read_exact/write_exact seems to not be available here, which cause a gcc error. Use plain read/write, the xenevtchn interface won't do partial read/write on NetBSD anyway so it should be safe. Signed-off-by: Manuel Bouyer

[PATCH] gdbsx: use right path for privcmd

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD the privcmd interface node is /kern/xen/privcmd Signed-off-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg

[PATCH] xenstat_netbsd: remove usused code

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer remove PROCNETDEV_HEADER[] and read_attributes_vbd(), gcc complains that they are unused Signed-off-by: Manuel Bouyer --- tools/libs/stat/xenstat_netbsd.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/tools/libs/stat/xenstat_netbsd.c b/tools/libs/stat

[PATCH] libs/light: make it build without setresuid()

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer NetBSD doesn't have setresuid(). Add a configure check for it, and use plain setuid() if !HAVE_SETRESUID Signed-off-by: Manuel Bouyer --- tools/configure | 13 + tools/configure.ac | 3 +++ tools/libs/light/libxl_dm.c | 10

[PATCH] xenpmd.c: use dynamic allocation

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD, d_name is larger than 256, so file_name[284] may not be large enough (and gcc emits a format-truncation error). Use asprintf() instead of snprintf() on a static on-stack buffer. Signed-off-by: Manuel Bouyer --- tools/xenpmd/xenpmd.c | 8 1 file changed

[PATCH] libs/light: fix tv_sec printf format

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer Don't assume tv_sec is a unsigned long, it is 64 bits on NetBSD 32 bits. Use %jd and cast to (intmax_t) instead Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/

[PATCH] libs/store: make build without PTHREAD_STACK_MIN

2021-01-12 Thread Manuel Bouyer
From: Manuel Bouyer On NetBSD, PTHREAD_STACK_MIN is not available. Just use DEFAULT_THREAD_STACKSIZE if PTHREAD_STACK_MIN is not available. Signed-off-by: Manuel Bouyer --- tools/libs/store/xs.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs/store

Re: [PATCH] ocaml/libs/eventchn: drop unneeded evtchn.h

2021-01-13 Thread Manuel Bouyer
On Wed, Jan 13, 2021 at 09:22:38AM +, Christian Lindig wrote: > Acked-by: Christian Lindig thanks. What should I do now, submit a new patch with this tag, or just wait for it to be commited ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] Fix error: array subscript has type 'char'

2021-01-14 Thread Manuel Bouyer
On Thu, Jan 14, 2021 at 11:53:20AM +0100, Jan Beulich wrote: > On 12.01.2021 19:12, Manuel Bouyer wrote: > > From: Manuel Bouyer > > > > Use unsigned char variable, or cast to (unsigned char), for > > tolower()/islower() and friends. Fix compiler error > &g

Re: [PATCH] Fix error: array subscript has type 'char'

2021-01-14 Thread Manuel Bouyer
On Thu, Jan 14, 2021 at 02:25:05PM +0100, Jan Beulich wrote: > On 14.01.2021 13:29, Manuel Bouyer wrote: > > On Thu, Jan 14, 2021 at 11:53:20AM +0100, Jan Beulich wrote: > >> On 12.01.2021 19:12, Manuel Bouyer wrote: > >>> From: Manuel Bouyer > >>> &g

Re: [PATCH 4/6] CHANGELOG.md: NetBSD lib/gnttab support

2021-03-25 Thread Manuel Bouyer
On Thu, Mar 25, 2021 at 10:13:11AM +0100, Roger Pau Monné wrote: > On Wed, Mar 24, 2021 at 04:44:05PM +, George Dunlap wrote: > > Signed-off-by: George Dunlap > > LGTM, maybe Manuel has something else to add. no, it's OK for me too -- Manuel Bouyer NetBSD: 26 ans

<    1   2   3