[PATCH v2] NetBSD: use system-provided headers

2021-01-26 Thread Manuel Bouyer
ned-off-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 4 + tools/include/Makefile | 2 + tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - tools/libs/call/private.h

[PATCH v2] libs/store: make build without PTHREAD_STACK_MIN

2021-01-26 Thread Manuel Bouyer
On NetBSD, PTHREAD_STACK_MIN is not available. If PTHREAD_STACK_MIN is not defined, define it to 0 so that we fallback to DEFAULT_THREAD_STACKSIZE Signed-off-by: Manuel Bouyer --- tools/libs/store/xs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/libs/store/xs.c b/tools/libs

[PATCH v2] libs/light: fix uuid on NetBSD

2021-01-26 Thread Manuel Bouyer
NetBSD uses the same uuid library as FreeBSD. As this is in a __FreeBSD__ || __NetBSD__ block, just drop the #ifdef __FreeBSD__ and dead code. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/light/libxl_uuid.c | 21 - 1 file changed, 21 deletions

[PATCH v2] libs/gnttab: implement on NetBSD

2021-01-26 Thread Manuel Bouyer
Implement gnttab interface on NetBSD. The kernel interface is different from FreeBSD so we can't use the FreeBSD version Signed-off-by: Manuel Bouyer --- tools/libs/gnttab/Makefile | 2 +- tools/libs/gnttab/netbsd.c | 267 + 2 files changed, 268 inser

[PATCH v2] libs/light: fix tv_sec printf format

2021-01-26 Thread Manuel Bouyer
Don't assume tv_sec is a unsigned long, it is 64 bits on NetBSD 32 bits. Use %jd and cast to (intmax_t) instead Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/light/libxl_create.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools

[PATCH v2] NetBSD hotplug: fix block unconfigure on destroy

2021-01-26 Thread Manuel Bouyer
When a domain is destroyed, xparams may not be available any more when the block script is called to unconfigure the vnd. Check xparam only at configure time, and just unconfigure any vnd present in the xenstore. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/hotplug

[PATCH v2] libs/light: make it build without setresuid()

2021-01-26 Thread Manuel Bouyer
NetBSD doesn't have setresuid(). introcuce libxl__setresuid(), which on NetBSD assert() that it's never called (it should not be called when dm restriction is off, and NetBSD doesn't support dm restriction at this time). On linux and FreeBSD it just calls setresuid(). Signed-off-by

[PATCH v2] libs/call: fix build on NetBSD

2021-01-26 Thread Manuel Bouyer
Define PAGE_* if not already defined Catch up with osdep interface change. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/call/netbsd.c | 19 +++ tools/libs/call/private.h | 4 +++- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a

[PATCH v2] libs/light: Switch NetBSD to QEMU_XEN

2021-01-26 Thread Manuel Bouyer
Switch NetBSD to QEMU_XEN. All 3 versions of libxl__default_device_model() now return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN, so remove it and just set b_info->device_model_version to LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN in libxl__domain_build_info_setdefault(). Signed-off-by: Manuel Bouyer Revie

[PATCH v2] libs/light: pass some infos to qemu

2021-01-26 Thread Manuel Bouyer
tl to rename network interfaces implemented, and thus cannot rename the interface from tapX to vifX.Y-emu. Only qemu knowns the tap interface name, so we need to use the qemu script from qemu itself. Signed-off-by: Manuel Bouyer --- tools/libs/light/libxl_dm.c | 6 ++ 1 file changed, 6 inser

Re: [PATCH] NetBSD hotplug: fix block unconfigure on destroy

2021-01-27 Thread Manuel Bouyer
> > As said I think fetching vnd on detach is fine because there's no need > to fetch the other nodes, but this seems to be masking some kind of > error elsewhere. My priority is to get the patches in at this point. Each round takes me hours to get them in shape. -- Man

Re: [PATCH] libs/light: pass some infos to qemu

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 10:06:43AM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:42:23PM +0100, Manuel Bouyer wrote: > > On Mon, Jan 18, 2021 at 09:36:42AM +0100, Roger Pau Monné wrote: > > > [...] > > > > > > Note also that there are networki

Re: [PATCH] NetBSD hotplug: Introduce locking functions

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 03:57:06PM +, Ian Jackson wrote: > Manuel Bouyer writes ("[PATCH] NetBSD hotplug: Introduce locking functions"): > > From: Manuel Bouyer > > > > On NetBSD, some block device configuration requires serialisation. > > Introcuce l

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-27 Thread Manuel Bouyer
On Wed, Jan 27, 2021 at 04:03:04PM +, Ian Jackson wrote: > Ian Jackson writes ("Re: [PATCH] libs/light: make it build without > setresuid()"): > > Manuel Bouyer writes ("Re: [PATCH] libs/light: make it build without > > setresuid()"): > > >

Re: [PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-29 Thread Manuel Bouyer
mmap(fres->addr, fres->nr_frames << PAGE_SHIFT, >fres->prot, fres->flags | MAP_ANON | MAP_SHARED, -1, > 0); What happens if fres->addr is not NULL and nr_frames is 0 ? Is it supposed to happen ? Should we assert that fres->addr is NULL when

Re: [PATCH v2] libs/store: make build without PTHREAD_STACK_MIN

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 11:08:08AM +, Andrew Cooper wrote: > On 28/01/2021 10:57, Roger Pau Monné wrote: > > On Tue, Jan 26, 2021 at 11:47:59PM +0100, Manuel Bouyer wrote: > >> On NetBSD, PTHREAD_STACK_MIN is not available. > >> If PTHREAD_STACK_MIN is not defined

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:58PM +0100, Manuel Bouyer wrote: > > Pass bridge name to qemu as command line option > > When starting qemu, set an environnement variable XEN_DOMAIN_ID, > > to be used by qemu h

Re: [PATCH v2] libs/foreignmemory: Implement on NetBSD

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 11:42:45AM +, Andrew Cooper wrote: > FAOD I've committed a fixed up version of this patch as discussed. thanks ! -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] NetBSD: use system-provided headers

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 12:21:33PM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:50PM +0100, Manuel Bouyer wrote: > > On NetBSD use the system-provided headers for ioctl and related definitions, > > they are up to date and have more chances to match the kernel&#x

Re: [PATCH v2] NetBSD hotplug: fix block unconfigure on destroy

2021-01-29 Thread Manuel Bouyer
On Thu, Jan 28, 2021 at 12:45:09PM +0100, Roger Pau Monné wrote: > On Tue, Jan 26, 2021 at 11:47:49PM +0100, Manuel Bouyer wrote: > > When a domain is destroyed, xparams may not be available any more when > > the block script is called to unconfigure the vnd. > > Check xpa

Re: [PATCH v4] tools/foreignmem: Support querying the size of a resource

2021-01-29 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 03:09:30PM +, Andrew Cooper wrote: > On 29/01/2021 14:59, Roger Pau Monné wrote: > > On Fri, Jan 29, 2021 at 11:38:43AM +0100, Manuel Bouyer wrote: > >> On Thu, Jan 28, 2021 at 12:01:52PM +, Andrew Cooper wrote: > >>> With the Xen side

[PATCH v2] NetBSD: use system-provided headers

2021-01-29 Thread Manuel Bouyer
ned-off-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 4 + tools/include/Makefile | 2 + tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - tools/libs/call/private.h

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Manuel Bouyer
ject/people/andyhhp/xen/-/jobs/996140268 It looks like I don't have access to this page, could you share the content ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] NetBSD: use system-provided headers

2021-01-29 Thread Manuel Bouyer
Sorry I forgot to change the Subject. It should have been [PATCH v3] -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-29 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 11:05:24PM +, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this > >> serie

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-30 Thread Manuel Bouyer
is patch makes qemu-xen call the script with the same parameters, and add the XEN_DOMAIN_ID environnement variable. Is it OK to keep the script from qemu-xen-traditional (and installed as part of qemu-xen-traditional) for now ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] libs/light: make it build without setresuid()

2021-01-30 Thread Manuel Bouyer
incremental commits and then have git format-patch output something sensible. I nerver understood how git branches and merge were supposed to work (for example syncing a local repo with upstream, while keeping local changes). -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

[PATCH v3 2/2] define GNU_SOURCE for asprintf()

2021-01-30 Thread Manuel Bouyer
#define _GNU_SOURCE to get for asprintf() prototype on Linux. Harmless on NetBSD. Signed-off-by: Manuel Bouyer --- tools/xenpmd/xenpmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index e432aad856..8e783181e1 100644 --- a/tools/xenpmd

[PATCH v3 1/2] xenpmd.c: use dynamic allocation

2021-01-30 Thread Manuel Bouyer
On NetBSD, d_name is larger than 256, so file_name[284] may not be large enough (and gcc emits a format-truncation error). Use asprintf() instead of snprintf() on a static on-stack buffer. Signed-off-by: Manuel Bouyer Reviewed-by: Ian Jackson --- tools/xenpmd/xenpmd.c | 8 1 file

Re: [PATCH v2] libs/light: make it build without setresuid()

2021-01-30 Thread Manuel Bouyer
On Fri, Jan 29, 2021 at 11:05:24PM +, Andrew Cooper wrote: > On 29/01/2021 23:01, Manuel Bouyer wrote: > > On Fri, Jan 29, 2021 at 10:51:14PM +, Andrew Cooper wrote: > >> Given the freeze, and discussions on IRC, I have committed most of this > >> serie

[PATCH v3 1/2] libs/light: pass some infos to qemu

2021-01-30 Thread Manuel Bouyer
tl to rename network interfaces implemented, and thus cannot rename the interface from tapX to vifX.Y-emu. Only qemu knowns the tap interface name, so we need to use the qemu script from qemu itself. Signed-off-by: Manuel Bouyer Reviewed-by: Roger Pau Monné --- tools/libs/light/libxl_dm.c | 6

[PATCH v3 2/2] Document qemu-ifup on NetBSD

2021-01-30 Thread Manuel Bouyer
Document that on NetBSD, the tap interface will be configured by the qemu-ifup script. Document the arguments, and XEN_DOMAIN_ID environnement variable. --- docs/man/xl-network-configuration.5.pod | 4 1 file changed, 4 insertions(+) diff --git a/docs/man/xl-network-configuration.5.pod b/do

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-01-30 Thread Manuel Bouyer
a v3, with a patch to xl-network-configuration.5.pod -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH v3 2/2] Document qemu-ifup on NetBSD

2021-02-01 Thread Manuel Bouyer
On Mon, Feb 01, 2021 at 09:21:58AM +0100, Roger Pau Monné wrote: > On Sun, Jan 31, 2021 at 12:03:00AM +0100, Manuel Bouyer wrote: > > Document that on NetBSD, the tap interface will be configured by the > > qemu-ifup script. Document the arguments, and XEN_DOMAIN_ID environneme

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-02-01 Thread Manuel Bouyer
On Mon, Feb 01, 2021 at 09:06:13AM +0100, Roger Pau Monné wrote: > On Sat, Jan 30, 2021 at 12:50:13PM +0100, Manuel Bouyer wrote: > > On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote: > > > [...] > > > Also, the qemu-ifup script doesn't seem to be

Re: [PATCH v2] libs/light: pass some infos to qemu

2021-02-01 Thread Manuel Bouyer
ummary > > I would remove it from qemu-trad and then only install from > hotplug/NetBSD if it's not already there? Or maybe just force-install > it from hotplug/NetBSD even if it's already present? OK will try that -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

xenstored file descriptor leak

2021-02-02 Thread Manuel Bouyer
ection alive */ + talloc_free(conn); } static void handle_output(struct connection *conn) what do you think ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: xenstored file descriptor leak

2021-02-02 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 07:18:51AM +0100, Jürgen Groß wrote: > On 02.02.21 19:37, Manuel Bouyer wrote: > > Hello, > > on NetBSD I'm tracking down an issue where xenstored never closes its > > file descriptor to /var/run/xenstored/socket and instead loops at 100% &g

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
, as we want to keep the domain > > > in question to be known to xenstored. > > > > > > For socket connections this should be okay, though. > > > > What are "non-socket connections" BTW ? I don't think I've seen one > > in my test. &g

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
cal modification of the XSA-115 fixes for sockets while > keeping the desired effect for domain connections. Hello here's an updated patch which works for me. Does anyone see a problem with it ? If not I will submit it for commit. -- Manuel Bouyer NetBSD: 26 ans d'expe

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote: > On 03.02.21 12:48, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 09:21:32AM +0100, Jürgen Groß wrote: > > > [...] > > > This shouldn't happen in case we are closing the socket actively. > > &

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 01:13:53PM +0100, Jürgen Groß wrote: > On 03.02.21 13:03, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote: > > > On 03.02.21 12:48, Manuel Bouyer wrote: > > > > On Wed, Feb 03, 2021 at 09:21

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
closed, xenstored will flag it as an error and switch the connection to ignored. But on some OSes (e.g. NetBSD), poll(2) will return only POLLIN in this case, so sockets in ignored state will stay open forever in xenstored (and it will loop with CPU 100% busy). -- Manuel B

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
d not go through sevreral iterations with this protocol. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
On Wed, Feb 03, 2021 at 01:58:19PM +0100, Jürgen Groß wrote: > On 03.02.21 13:47, Manuel Bouyer wrote: > > On Wed, Feb 03, 2021 at 01:42:12PM +0100, Jürgen Groß wrote: > > > Uh, this is no regular patch. > > > > I though by regular patch, you meants a plain diff -u

Re: xenstored file descriptor leak

2021-02-03 Thread Manuel Bouyer
y. thanks. When I started, I looked at the wiki for instructions about patches, but didn't find any ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

[PATCH] add a qemu-ifup script on NetBSD

2021-02-03 Thread Manuel Bouyer
On NetBSD, qemu-xen will use a qemu-ifup script to setup the tap interfaces (as qemu-xen-traditional used to). Copy the script from qemu-xen-traditional, and install it on NetBSD. While there document parameters and environnement variables. Signed-off-by: Manuel Bouyer --- tools/hotplug/NetBSD

[PATCH] xenstored: close socket connections on error

2021-02-03 Thread Manuel Bouyer
will stay open forever in xenstored (and it will loop with CPU 100% busy). Signed-off-by: Manuel Bouyer Fixes: d2fa370d3ef9cbe22d7256c608671cdcdf6e0083 --- tools/xenstore/xenstored_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/xenstore/xenstored_core.c b/tools/xen

[PATCH v3] Document qemu-ifup on NetBSD

2021-02-03 Thread Manuel Bouyer
Document that on NetBSD, the tap interface will be configured by the qemu-ifup script. Signed-off-by: Manuel Bouyer Release-Acked-by: Ian Jackson --- docs/man/xl-network-configuration.5.pod | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/man/xl-network-configuration.5.pod b/docs

[PATCH v3] NetBSD: use system-provided headers

2021-02-03 Thread Manuel Bouyer
ned-off-by: Manuel Bouyer --- tools/debugger/gdbsx/xg/xg_main.c | 4 + tools/include/Makefile | 2 + tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - tools/libs/call/private.h

Re: [PATCH] xenstored: close socket connections on error

2021-02-03 Thread Manuel Bouyer
ific. Perhaps > we could have a pointer or two, but everyone has their own pet methods > and tooling so the result would perhaps be more confusing than > helpful. a howto is alwaus helpfull. Even if it's not the one and only way to do, at last it gives a start point. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] xenstored: close socket connections on error

2021-02-04 Thread Manuel Bouyer
On Thu, Feb 04, 2021 at 12:11:02PM +0100, Jürgen Groß wrote: > On 03.02.21 17:54, Manuel Bouyer wrote: > > On error, don't keep socket connection in ignored state but close them. > > When the remote end of a socket is closed, xenstored will flag it as an > > error an

qemu-xen and bridge (xen 4.11)

2020-08-24 Thread Manuel Bouyer
issue dealt with on other OSes ? I can't believe I'm the only one with multiple bridges in the dom0 ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: qemu-xen and bridge (xen 4.11)

2020-08-24 Thread Manuel Bouyer
On Mon, Aug 24, 2020 at 11:24:06AM -0700, Roman Shaposhnik wrote: > On Mon, Aug 24, 2020 at 11:12 AM Manuel Bouyer wrote: > > > > Hello, > > with the recent XSA about qemu, I'm trying to switch the NetBSD port from > > qemu-xen-traditional to qemu-xen (in Xen 4.1

HVM BIOS ROM and modules

2020-08-24 Thread Manuel Bouyer
(it does for PVH but not for HVM, AFAIK). Is qemu supposed to setup modules params in info, or should xl do it ? If the former, where does it happens in qemu-xen sources ? If the later, how does it know which rom to load ? thanks, -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: qemu-xen and bridge (xen 4.11)

2020-08-27 Thread Manuel Bouyer
On Mon, Aug 24, 2020 at 11:24:06AM -0700, Roman Shaposhnik wrote: > On Mon, Aug 24, 2020 at 11:12 AM Manuel Bouyer wrote: > > > > Hello, > > with the recent XSA about qemu, I'm trying to switch the NetBSD port from > > qemu-xen-traditional to qemu-xen (in Xen 4.1

patches for Xen 4.13

2020-05-27 Thread Manuel Bouyer
Hello, I got Xen 4.13 working with NetBSD. Now I'd like to get the patches back in the Xen sources. What is the best way to submit the patches ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
g 0 to the real domain id for pvshim, but there may be a better way to do this. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference -- --- drivers/char/console.c.orig 2023-10-18 12:24:57.221891748 +0200 +++ drivers/char/console.c 2023-10-18 12:30:26.072844802 +

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 12:38:57PM +0200, Manuel Bouyer wrote: > Hello, > With Xen 4.18, a PV domain running under pvshim doesn't get console input. > This is because the domain id in pvshim isn't 0 (and on x86 max_init_domid is > hardwired to 0), so console_input_domain()

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 11:44:22AM +0100, Andrew Cooper wrote: > On 18/10/2023 11:38 am, Manuel Bouyer wrote: > > Hello, > > With Xen 4.18, a PV domain running under pvshim doesn't get console input. > > This is because the domain id in pvshim isn't 0 (an

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 03:24:22PM +0200, Jan Beulich wrote: > On 18.10.2023 13:20, Manuel Bouyer wrote: > > On Wed, Oct 18, 2023 at 11:44:22AM +0100, Andrew Cooper wrote: > >> On 18/10/2023 11:38 am, Manuel Bouyer wrote: > >>> Hello, > >>> With Xen 4.18

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 03:29:08PM +0200, Jan Beulich wrote: > On 18.10.2023 12:38, Manuel Bouyer wrote: > > Hello, > > With Xen 4.18, a PV domain running under pvshim doesn't get console input. > > This is because the domain id in pvshim isn't 0 (and on x86 max_init

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 03:51:54PM +0200, Jan Beulich wrote: > On 18.10.2023 15:36, Manuel Bouyer wrote: > > On Wed, Oct 18, 2023 at 03:24:22PM +0200, Jan Beulich wrote: > >> On 18.10.2023 13:20, Manuel Bouyer wrote: > >>> On Wed, Oct 18, 2023 at 11:44:22AM +0100, And

Re: Xen 4.18 pvshim console issue (with patch)

2023-10-18 Thread Manuel Bouyer
On Wed, Oct 18, 2023 at 04:18:26PM +0200, Michal Orzel wrote: > Hi, > > On 18/10/2023 15:29, Jan Beulich wrote: > > > > > > On 18.10.2023 12:38, Manuel Bouyer wrote: > >> Hello, > >> With Xen 4.18, a PV domain running under pvshim doesn't get co

Re: [PATCH] public: add RING_NR_UNCONSUMED_*() macros to ring.h

2021-11-26 Thread Manuel Bouyer
the new > RING_NR_UNCONSUMED_*() macros when using this version of ring.h. AFAIK NetBSD is using RING_HAS_UNCONSUMED as a booleanm so it should be fine with this change -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-26 Thread Manuel Bouyer
On Thu, Nov 26, 2020 at 02:34:44PM +0100, Roger Pau Monné wrote: > On Tue, Nov 24, 2020 at 05:09:14PM +0100, Manuel Bouyer wrote: > > On Tue, Nov 24, 2020 at 04:49:17PM +0100, Roger Pau Monné wrote: > > > Could you also give a try with ioapic_ack=new on the Xen command line? &g

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-26 Thread Manuel Bouyer
pply this patch, so to make sure we're in sync I attached the diff from my sources -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference -- diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index 38ac5fb6c7..9db3dcc957 100644 --- a/xen/arch/x86/hvm/irq.c

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
ven get into > hvm_do_IRQ_dpci, so I've added some more debug info. > > Here is the new patch, sorry for so many rounds of testing. No problem, it's expected for this kind of debug :) http://www-soc.lip6.fr/~bouyer/xen-log11.txt -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
On Fri, Nov 27, 2020 at 12:21:23PM +0100, Jan Beulich wrote: > On 27.11.2020 12:19, Manuel Bouyer wrote: > > On Fri, Nov 27, 2020 at 11:59:48AM +0100, Roger Pau Monné wrote: > >>> > >>> I had to restart from a clean source tree to apply this patch, so to make &g

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
uppressed > some de-assert call. Yes, I have some of the previous patches (otherwise Xen panics). Attached is the diffs I currently have -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference -- diff --git a/xen/arch/x86/hvm/irq.c b/xen/arch/x86/hvm/irq.c index

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
On Fri, Nov 27, 2020 at 02:14:55PM +0100, Jan Beulich wrote: > Ah yes. In your respective mail the link said 9 though instead of 10. Ops, sorry. I forgot to update the link I guess ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
On Fri, Nov 27, 2020 at 02:18:54PM +0100, Jan Beulich wrote: > On 27.11.2020 14:13, Manuel Bouyer wrote: > > On Fri, Nov 27, 2020 at 12:29:35PM +0100, Jan Beulich wrote: > >> On 27.11.2020 11:59, Roger Pau Monné wrote: > >>> --- a/xen/arch/x86/hvm/irq.c >

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
On Fri, Nov 27, 2020 at 02:40:22PM +0100, Jan Beulich wrote: > On 27.11.2020 14:31, Manuel Bouyer wrote: > > On Fri, Nov 27, 2020 at 02:18:54PM +0100, Jan Beulich wrote: > >> On 27.11.2020 14:13, Manuel Bouyer wrote: > >>> On Fri, Nov 27, 2020 at 12:29:35PM +0100

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-27 Thread Manuel Bouyer
out. thanks the trace is at http://www-soc.lip6.fr/~bouyer/xen-log13.txt -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-28 Thread Manuel Bouyer
attached a further > debug patch, in case the fix turns out to be wrong. Please test the > fix first, as the debug patch will end up triggering a panic when the > buffer is full. Yes, fix.patch does make the system boot as expected ! thanks ! -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-29 Thread Manuel Bouyer
On Sat, Nov 28, 2020 at 06:14:30PM +0100, Manuel Bouyer wrote: > On Sat, Nov 28, 2020 at 03:53:11PM +0100, Roger Pau Monné wrote: > > > the trace is at > > > http://www-soc.lip6.fr/~bouyer/xen-log13.txt > > > > Thanks! I think I've found the issue and I

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-30 Thread Manuel Bouyer
On Mon, Nov 30, 2020 at 11:00:23AM +0100, Jan Beulich wrote: > On 28.11.2020 18:14, Manuel Bouyer wrote: > > On Sat, Nov 28, 2020 at 03:53:11PM +0100, Roger Pau Monné wrote: > >>> the trace is at > >>> http://www-soc.lip6.fr/~bouyer/xen-log13.txt > >> >

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-30 Thread Manuel Bouyer
On Mon, Nov 30, 2020 at 11:00:23AM +0100, Jan Beulich wrote: > On 28.11.2020 18:14, Manuel Bouyer wrote: > > On Sat, Nov 28, 2020 at 03:53:11PM +0100, Roger Pau Monné wrote: > >>> the trace is at > >>> http://www-soc.lip6.fr/~bouyer/xen-log13.txt > >> >

Re: NetBSD dom0 PVH: hardware interrupts stalls

2020-11-30 Thread Manuel Bouyer
On Mon, Nov 30, 2020 at 12:44:23PM +0100, Jan Beulich wrote: > On 30.11.2020 12:35, Manuel Bouyer wrote: > > On Mon, Nov 30, 2020 at 11:00:23AM +0100, Jan Beulich wrote: > >> On 28.11.2020 18:14, Manuel Bouyer wrote: > >>> On Sat, Nov 28, 2020 at 03:53:11P

dom0 PV looping on search_pre_exception_table()

2020-12-08 Thread Manuel Bouyer
looks like a fault in the guest is not handled at it should, and the userland process keeps faulting on the same address. Any idea what to look at ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-09 Thread Manuel Bouyer
On Wed, Dec 09, 2020 at 09:39:49AM +0100, Jan Beulich wrote: > On 08.12.2020 19:13, Andrew Cooper wrote: > > On 08/12/2020 17:57, Manuel Bouyer wrote: > >> Hello, > >> for the first time I tried to boot a xen kernel from devel with > >> a NetBSD PV dom0.

Re: dom0 PV looping on search_pre_exception_table()

2020-12-09 Thread Manuel Bouyer
On Tue, Dec 08, 2020 at 06:13:46PM +, Andrew Cooper wrote: > On 08/12/2020 17:57, Manuel Bouyer wrote: > > Hello, > > for the first time I tried to boot a xen kernel from devel with > > a NetBSD PV dom0. The kernel boots, but when the first userland prcess > > is la

Re: dom0 PV looping on search_pre_exception_table()

2020-12-09 Thread Manuel Bouyer
(XEN) (XEN) 0000 (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-09 Thread Manuel Bouyer
0 (XEN) (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-09 Thread Manuel Bouyer
0 (XEN) (XEN) 0000 0000 (XEN) (XEN) Hardware Dom0 crashed: rebooting machine in 5 seconds. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-09 Thread Manuel Bouyer
On Wed, Dec 09, 2020 at 06:08:53PM +, Andrew Cooper wrote: > On 09/12/2020 16:30, Manuel Bouyer wrote: > > On Wed, Dec 09, 2020 at 04:00:02PM +, Andrew Cooper wrote: > >> [...] > >>>> I wonder if the LDT is set up correctly. > >>> I guess it i

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Manuel Bouyer
rax 0 0 [ 7.6617663] cs 0x47 ds 0x23 es 0x23 fs gs ss 0x3f [ 7.7345663] fsbase 00 gsbase 00 so it looks like something resets %fs to 0 ... Anyway the fault address 0xbd80a040 is in the hypervisor's range, isn't

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Manuel Bouyer
sually get it wrong the first time I go back to it. AFAIK, in the Xen PV case, a page is allocated an mapped in kernel space, and registered to Xen with MMUEXT_SET_LDT. >From what I found, in the common case the LDT is the same for all processes. Does it make sense ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-10 Thread Manuel Bouyer
But I don't have a linux dom0 to test. If you have a Xen setup you can test with http://ftp.netbsd.org/pub/NetBSD/NetBSD-9.1/amd64/binary/kernel/netbsd-INSTALL_XEN3_DOMU.gz note that this won't boot as a dom0 kernel. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-11 Thread Manuel Bouyer
gt; [...] > > Presumably you've got no Meltdown mitigations going on within the NetBSD > kernel?  (I suspect not, seeing as changing Xen changes the behaviour, > but it is worth asking). No, there's no Meltdown mitigations for PV in NetBSD. as I see it, for amd64 at last, the Xen kernel has to do it anyway, so it's not usefull to implement it in the guest's kernel. Did I miss something ? -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: dom0 PV looping on search_pre_exception_table()

2020-12-11 Thread Manuel Bouyer
ed set for XSA-286. > We mustn't avoid the switching of page tables as long as > guest_get_eff{,_kern}_l1e() makes use of the linear page tables. Yes, reverting this commit also makes the dom0 boot. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --

Re: [PATCH] x86/PV: guest_get_eff_kern_l1e() may still need to switch page tables

2020-12-14 Thread Manuel Bouyer
gt; > Fixes: 9ff970564764 ("x86/mm: drop guest_get_eff_l1e()") > Reported-by: Manuel Bouyer > Signed-off-by: Jan Beulich > Reviewed-by: Andrew Cooper > --- > Manuel, could you test this again, just to be on the safe side > before we throw it in (at which point we could then

[PATCH 05/24] Introduce locking functions for block device setup on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/hotplug/NetBSD/Makefile | 1 + tools/hotplug/NetBSD/block | 5 ++- tools/hotplug/NetBSD/locking.sh | 72 + 3 files changed, 77 insertions(+), 1 deletion(-) create mode 100644 tools/hotplug/NetBSD/locking.sh diff --git a/tools/hotplug/NetBSD/Make

[PATCH 03/24] Fix lock directory path for NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/configure b/tools/configure index 8a708e9baa..131112c41e 100755 --- a/tools/configure +++ b/tools/configure @@ -4030,7 +4030,7 @@ XEN_SCRIPT_DIR=$XEN_CONFIG_DIR/scripts case "$host_os" in *freebsd*) X

[PATCH 07/24] Remove NetBSD's system headers. We'll use the system-provided ones, which are up to date.

2020-12-14 Thread Manuel Bouyer
--- tools/include/Makefile | 2 +- tools/include/xen-sys/NetBSD/evtchn.h | 86 tools/include/xen-sys/NetBSD/privcmd.h | 106 - 3 files changed, 1 insertion(+), 193 deletions(-) delete mode 100644 tools/include/xen-sys/NetBSD/evtchn.

[PATCH 15/24] Make libs/light build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/light/libxl_dm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c index 5948ace60d..c93bdf2cc9 100644 --- a/tools/libs/light/libxl_dm.c +++ b/tools/libs/light/libxl_dm.c @@ -3659,6 +3659,14 @@ static int kill_dev

[PATCH 00/24] NetBSD fixes

2020-12-14 Thread Manuel Bouyer
Hello, here is a set of 24 patches, which are needed to build and run the tools on NetBSD. They are extracted from NetBSD's pkgsrc repository for Xen 4.13, and ported to 4.15. Manuel Bouyer (24): Fix lock directory path for NetBSD NetBSD doens't need xenbackendd with xl toolstack

[PATCH 04/24] Make xg_main.c build on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/debugger/gdbsx/xg/xg_main.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/debugger/gdbsx/xg/xg_main.c b/tools/debugger/gdbsx/xg/xg_main.c index a4e8653168..fa2741ccf8 100644 --- a/tools/debugger/gdbsx/xg/xg_main.c +++ b/tools/debugger/gdbsx/xg/xg_main.c @@ -49,7

[PATCH 20/24] If FILENAME_MAX is defined, use it instead of arbitrary value (fix format-truncation errors with GCC >= 7)

2020-12-14 Thread Manuel Bouyer
--- tools/xenpmd/xenpmd.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/xenpmd/xenpmd.c b/tools/xenpmd/xenpmd.c index 12b82cf43e..cfd22e64e3 100644 --- a/tools/xenpmd/xenpmd.c +++ b/tools/xenpmd/xenpmd.c @@ -101,7 +101,11 @@ FILE *get_next_battery_file(DIR *battery_dir, { FIL

[PATCH 12/24] Implement gnttab on NetBSD

2020-12-14 Thread Manuel Bouyer
--- tools/libs/gnttab/Makefile | 2 +- tools/libs/gnttab/netbsd.c | 267 + 2 files changed, 268 insertions(+), 1 deletion(-) create mode 100644 tools/libs/gnttab/netbsd.c diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile index d86c49d243..

<    1   2   3   >