On Thu, 16 May 2024 18:48, "Edgar E. Iglesias" wrote:
From: "Edgar E. Iglesias"
Add a second mapcache for grant mappings. The mapcache for
grants needs to work with XC_PAGE_SIZE granularity since
we can't map larger ranges than what has been granted to us.
Like with foreign mappings (xen_memo
me, if the community deems them useful
with your corrections applied I hope someone else picks them up in the
future.
Thanks again,
--
Manos Pitsidianakis, Virtualization Engineer at Linaro
licable to single register load/stores
so add some verification steps before to weed out unexpected accesses.
While at it update the Arm ARM references to the latest version of the
documentation.
Signed-off-by: Alex Bennée
Cc: Manos Pitsidianakis
Move the CC line after --- so that it's not
On Thu, 07 Mar 2024 12:43, Michal Orzel wrote:
On 07/03/2024 11:02, Manos Pitsidianakis wrote:
Hi Michal, Alex,
I'm responding to Michel but also giving my own review comments here.
On Thu, 07 Mar 2024 10:40, Michal Orzel wrote:
Hi Alex,
NIT: RFC tag is no longer needed.
On
size = TARGET_PAGE_ALIGN(size);
+size = ROUND_UP(size, TARGET_PAGE_SIZE);
if (add) {
if (!memory_region_is_rom(section->mr)) {
--
2.41.0
Reviewed-by: Manos Pitsidianakis
dr(start, length);
+start = xen_phys_offset_to_gaddr(start, length, TARGET_PAGE_MASK);
if (length == 0) {
length = TARGET_PAGE_SIZE;
--
2.41.0
Reviewed-by: Manos Pitsidianakis
type(xen_domid, mem_type,
- start_addr >> TARGET_PAGE_BITS,
- size >> TARGET_PAGE_BITS)) {
+ start_addr >> target_page_bits,
+ size >> target_page_bits)) {
DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n",
start_addr);
}
--
2.41.0
Reviewed-by: Manos Pitsidianakis
ryListener xen_memory_listener = {
+const MemoryListener xen_memory_listener = {
.name = "xen-memory",
.region_add = xen_region_add,
.region_del = xen_region_del,
--
2.41.0
Reviewed-by: Manos Pitsidianakis
)
{
XenPhysmap *physmap = NULL;
unsigned int len, num, i;
@@ -573,7 +573,7 @@ static void xen_read_physmap(XenIOState *state)
free(entries);
}
#else
-static void xen_read_physmap(XenIOState *state)
+void xen_read_physmap(XenIOState *state)
{
}
#endif
--
2.41.0
Reviewed-by: Manos
_notifier;
--
2.41.0
Reviewed-by: Manos Pitsidianakis
irty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA);
-hvmmem_type_t mem_type;
-
-if (!memory_region_is_ram(section->mr)) {
-return;
-}
-
-if (log_dirty != add) {
-return;
-}
-
-trace_xen_client_set_memory(start_addr, size, log_dirty);
-
-start_addr &= page_mask;
-size = ROUND_UP(size, page_size);
-
-if (add) {
-if (!memory_region_is_rom(section->mr)) {
-xen_add_to_physmap(state, start_addr, size,
- section->mr, section->offset_within_region);
-} else {
-mem_type = HVMMEM_ram_ro;
-if (xen_set_mem_type(xen_domid, mem_type,
- start_addr >> target_page_bits,
- size >> target_page_bits)) {
-DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n",
-start_addr);
-}
-}
-} else {
-if (xen_remove_from_physmap(state, start_addr, size) < 0) {
-DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n",
start_addr);
-}
-}
-}
-
void xen_arch_handle_ioreq(XenIOState *state, ioreq_t *req)
{
switch (req->type) {
diff --git a/hw/i386/xen/meson.build b/hw/i386/xen/meson.build
index 3f0df8bc07..d38759cfe4 100644
--- a/hw/i386/xen/meson.build
+++ b/hw/i386/xen/meson.build
@@ -1,6 +1,7 @@
i386_ss.add(when: 'CONFIG_XEN', if_true: files(
'xen_apic.c',
'xen_pvdevice.c',
+ 'xen-hvm-common.c',
))
i386_ss.add(when: ['CONFIG_XEN', xen], if_true: files(
'xen-hvm.c',
--
2.41.0
Reviewed-by: Manos Pitsidianakis
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
hw/i386/xen/xen-hvm-common.c content is target agnostic,
and should be common to all targets. Merge both files.
Remove the now unnecessary xen_register_framebuffer() stub.
ARM targets now inherit the common xen_memory_listener.
Signed-of
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
xen_arch_set_memory() is not arch-specific anymore. Being
called once, inline it in xen_set_memory().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 3 -
hw/xen/xen-hvm-common.c | 104 +++
This patch series proposes converting the compile-time define
LIBXL_DEVICE_MODEL_START_TIMEOUT value to an optionally overridden by
environment variable value, just like the current behavior for
LIBXL_BOOTLOADER_TIMEOUT is.
Manos Pitsidianakis (2):
libs/light: add device model start timeout
Various timeout values that depend on the device model should also
respect the device model start timeout setting. This commit adds the
__libxl_device_model_start_timeout() value to those time outs without
changing their default values.
Signed-off-by: Manos Pitsidianakis
---
tools/libs/light
LIBXL_DEVICE_MODEL_START_TIMEOUT to configure the timeout value and
otherwise fall back to the default 60.
Signed-off-by: Manos Pitsidianakis
---
docs/man/xl.1.pod.in | 11 +++
tools/libs/light/libxl_9pfs.c| 2 +-
tools/libs/light/libxl_device.c | 2 +-
tools/libs/light
On Wed, 10 Apr 2024 at 18:53, Anthony PERARD wrote:
>
> On Wed, Apr 10, 2024 at 02:43:13PM +0300, Manos Pitsidianakis wrote:
> > This patch series proposes converting the compile-time define
> > LIBXL_DEVICE_MODEL_START_TIMEOUT value to an optionally overridden by
> > en
On Thu, 11 Apr 2024 at 14:24, Anthony PERARD wrote:
>
> On Thu, Apr 11, 2024 at 01:23:07PM +0300, Manos Pitsidianakis wrote:
> > Hello Anthony,
> >
> > I do know about that, in fact I used it and it did not output your
> > email. Here's what the `get_maint
LIBXL_DEVICE_MODEL_START_TIMEOUT to configure the timeout value and
otherwise fall back to the default 60.
Signed-off-by: Manos Pitsidianakis
---
docs/man/xl.1.pod.in | 11 +++
tools/libs/light/libxl_9pfs.c| 2 +-
tools/libs/light/libxl_device.c | 2 +-
tools/libs/light
to old git version, no
other changes
Manos Pitsidianakis (2):
libs/light: add device model start timeout env var
libs/light: expand device model start timeout use
docs/man/xl.1.pod.in | 11 +++
tools/libs/light/libxl_9pfs.c| 2 +-
tools/libs/li
Various timeout values that depend on the device model should also
respect the device model start timeout setting. This commit adds the
__libxl_device_model_start_timeout() value to those time outs without
changing their default values.
Signed-off-by: Manos Pitsidianakis
---
tools/libs/light
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..1b748dba09 100644
--- a/h
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xen-mapcache.c | 5 ++---
2 files ch
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 1b748dba09..dd5b5a7f35 100644
--- a/hw/xen/
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xe
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 10 +-
hw/xen/xen-hvm-common.c | 35 ++-
2 files changed, 27 insertions(+), 18 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index a65dc0e55f..d1b27f6c11 100644
--- a/hw/xen/
d-off-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..a65dc0e55f 100644
--- a/h
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +-
include/hw/xen/interface/arch-x86/xen.h| 2 +-
include/hw/xen/interface/event_channel.h
--- a/hw/arm/xen-pvh.c
> +++ b/hw/arm/xen-pvh.c
> @@ -10,7 +10,6 @@
> #include "hw/boards.h"
> #include "system/system.h"
> #include "hw/xen/xen-pvh-common.h"
> -#include "hw/xen/arch_hvm.h"
>
> #define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh")
>
> --
> 2.49.0
>
>
Reviewed-by: Manos Pitsidianakis
29 matches
Mail list logo
