Re: [Xen-devel] [PATCH 06/10] Expose gicv3_ich_read/write_lr

2018-02-01 Thread Manish Jaggi
On 01/25/2018 10:22 PM, Julien Grall wrote: Hi, On 16/01/18 15:43, mja...@caviumnetworks.com wrote: From: Manish Jaggi gicv3_ich_read/write_lr functions are static in gic-v3.c This patch creates wrapper functions which can be used from outside the file. Signed-off-by: Manish Jaggi

Re: [Xen-devel] [PATCH 03/10] arm64: Add ICV_BPR1_EL1 handler

2018-02-01 Thread Manish Jaggi
On 01/25/2018 10:14 PM, Julien Grall wrote: Hi Manish, On 16/01/18 15:42, mja...@caviumnetworks.com wrote: From: Manish Jaggi Add a handler for reading/writing the guest's view of the ICC_BPR1_EL1 register, which is located in the ICH_VMCR_EL2.BPR1 field. This commit (and likel

Re: [Xen-devel] [PATCH 0/7] xen/arm: PSCI 1.1 and SMCCC-1.1 support and XSA-254 variant 2 update

2018-02-08 Thread Manish Jaggi
Hi Julien, On 02/05/2018 06:50 PM, Julien Grall wrote: Hi all, Arm has recently published a SMC Calling Convention (SMCCC) specification update [1] that provides an optimised calling convention and optional, discoverable support for mitigating CVE-2017-5715 (XSA-254 variant 2). ARM Trusted Fir

Re: [Xen-devel] [RFC PATCH 01/10] Add CONFIG_VGIC_ERRATA

2018-02-21 Thread Manish Jaggi
Hi Julien, On 01/25/2018 07:18 PM, Julien Grall wrote: Hi Manish, On 16/01/18 15:42, mja...@caviumnetworks.com wrote: From: Manish Jaggi Add a config option to enable VGIC Errata Code in Xen. Platforms which do not have this errta can compile out this feature. s/errta/errata/ Signed

Re: [Xen-devel] [RFC PATCH 02/10] arm64: Add hook to handle guest GICv3 sysreg accesses

2018-02-25 Thread Manish Jaggi
On 02/01/2018 04:24 PM, Julien Grall wrote: Hi Manish, On 01/02/18 08:51, Manish Jaggi wrote: On 01/25/2018 11:37 PM, Julien Grall wrote: Hi, I forgot to mention one thing about the placement of do_fixup_vgic_errata. On 16/01/18 15:42, mja...@caviumnetworks.com wrote: diff --git a/xen

Re: [Xen-devel] [RFC PATCH 02/10] arm64: Add hook to handle guest GICv3 sysreg accesses

2018-02-25 Thread Manish Jaggi
On 02/26/2018 12:12 PM, Manish Jaggi wrote: On 02/01/2018 04:24 PM, Julien Grall wrote: Hi Manish, On 01/02/18 08:51, Manish Jaggi wrote: On 01/25/2018 11:37 PM, Julien Grall wrote: Hi, I forgot to mention one thing about the placement of do_fixup_vgic_errata. On 16/01/18 15:42, mja

[Xen-devel] [RFC 00/11] acpi: arm: IORT Support for Xen

2018-01-02 Thread manish . jaggi
From: Manish Jaggi This patch aims to add the support of IORT in Xen. Below is the list of major components which this patchset provides. a. Add support for parsing the IORT b. Provides API to populate/query requesterid - streamID mappings and reuqesterid - deviceid mappings c. The

[Xen-devel] [RFC 03/11] acpi: arm: Code to generate Hardware Domains IORT

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Singed-off-by: Manish Jaggi --- xen/arch/arm/domain_build.c | 28 + xen/drivers/acpi/arm/gen-iort.c | 253 +++- xen/include/acpi/gen-iort.h | 1 + xen/include/asm-arm/acpi.h | 1 + 4 files changed, 282 insertions

[Xen-devel] [RFC 01/11] acpi: arm: Public API for populating and query based on requesterid

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Public API to populate and query map between requester id and streamId/DeviceID. IORT is parsed one time (outside this patch) and two lists are created one for mapping between reuesterId and streamid and another between requesterID and deviceID. These lists eliminate the

[Xen-devel] [RFC 02/11] acpi: arm: API to query estimated size of hardware domain's IORT

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Code to query estimated IORT size for hardware domain. IORT for hardware domain is generated using the requesterId and deviceId map. Signed-off-by: Manish Jaggi --- xen/arch/arm/domain_build.c | 12 - xen/drivers/acpi/arm/Makefile | 1 + xen/drivers/acpi/arm

[Xen-devel] [RFC 09/11] Xen IORT Changes

2018-01-02 Thread manish . jaggi
From: Manish Jaggi This patch adds xen specific changes to iort.c Signed-off-by: Manish Jaggi --- xen/arch/arm/setup.c |2 + xen/drivers/acpi/arm/Makefile |1 + xen/drivers/acpi/arm/iort.c | 1040 +++-- xen/include/acpi/acpi_iort.h

[Xen-devel] [RFC 06/11] fwnode xen spacific changes

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Merge few more changes from linux kernel code (v4.14) into iommu.c Modify code specifc to xen. Signed-off-by: Manish Jaggi --- xen/drivers/passthrough/iommu.c | 75 + xen/include/asm-arm/device.h| 11 -- xen/include/xen

[Xen-devel] [RFC 07/11] Add kernel helper functions

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Add kalloc kfree functions from linux kernel. Signed-off-by: Manish Jaggi --- xen/include/xen/kernel.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h index 548b64da9f..78517f6caa 100644 --- a/xen/include

[Xen-devel] [RFC 11/11] Add to_pci_dev macro

2018-01-02 Thread manish . jaggi
From: Manish Jaggi This patch adds to_pci_dev macro Signed-off-by: Manish Jaggi --- xen/include/xen/pci.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 43f21251a5..4c7ff4dd10 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen

[Xen-devel] [RFC 08/11] Add ACPI_IORT config

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Add ACPI_IORT config Singed-off-by: Manish Jaggi --- xen/arch/arm/Kconfig | 5 + xen/drivers/acpi/Kconfig | 3 +++ 2 files changed, 8 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index f58019d6ed..d4767d6ea3 100644 --- a/xen/arch/arm

[Xen-devel] [RFC 10/11] IORT parsing functions to prepare requesterId maps

2018-01-02 Thread manish . jaggi
From: Manish Jaggi This patch adds functions to parse the IORT and use the requesterID public API to update the maps. Signed-off-by: Manish jaggi --- xen/drivers/acpi/arm/iort.c | 200 1 file changed, 200 insertions(+) diff --git a/xen/drivers

[Xen-devel] [RFC 04/11] Import iort.c and acpi_iort.h

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Import iort.c and acpi_iort.h from linux kernel tag v4.14 Signed-off-by: Manish Jaggi --- xen/drivers/acpi/arm/iort.c | 1279 ++ xen/include/acpi/acpi_iort.h | 57 ++ 2 files changed, 1336 insertions(+) diff --git a/xen/drivers

[Xen-devel] [RFC 05/11] Import fwnode.h from linux

2018-01-02 Thread manish . jaggi
From: Manish Jaggi Import fwnode.h from linux kernel tag v4.14 Signed-off-by: Manish Jaggi --- xen/include/xen/fwnode.h | 125 +++ 1 file changed, 125 insertions(+) diff --git a/xen/include/xen/fwnode.h b/xen/include/xen/fwnode.h new file mode

Re: [Xen-devel] [RFC v4 8/8] drivers/passthrough/arm: Refactor code for arm smmu drivers

2018-01-02 Thread Manish Jaggi
Hi Sameer, On 12/19/2017 08:47 AM, Sameer Goel wrote: Pull common defines for SMMU drivers in a local header. Signed-off-by: Sameer Goel --- xen/drivers/passthrough/arm/arm_smmu.h | 113 + xen/drivers/passthrough/arm/smmu-v3.c | 96 ++--

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-02 Thread Manish Jaggi
Hi Sameer, Comments on this patch are only for nomenclature... On 12/19/2017 08:47 AM, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced to bridge the API calls. - Called Linux

Re: [Xen-devel] Xen 4.11 Development Update

2018-01-05 Thread Manish Jaggi
guest (RFC v4) > - XEN-45 > - Haozhong Zhang > > * SMMUv3 driver (RFC v4) > - Sameer Goel > > == Grub2 == > > * Support PVH guest boot (v1) > - Juergen Gross > > Please add arm: IORT support for Xen as a

Re: [Xen-devel] [RFC v4 6/8] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2018-01-16 Thread Manish Jaggi
Hi Julien, On 01/16/2018 02:04 AM, Julien Grall wrote: On 01/03/2018 05:47 AM, Manish Jaggi wrote: Hi Sameer, Hi Manish, + +/* Xen: Type definitions for iommu_domain */ +#define IOMMU_DOMAIN_UNMANAGED 0 +#define IOMMU_DOMAIN_DMA 1 +#define IOMMU_DOMAIN_IDENTITY 2 + +/* Xen: Dummy

Re: [Xen-devel] [RFC v4 8/8] drivers/passthrough/arm: Refactor code for arm smmu drivers

2018-01-16 Thread Manish Jaggi
Hi Julien, On 01/16/2018 02:11 AM, Julien Grall wrote: On 01/03/2018 05:34 AM, Manish Jaggi wrote: Hi Sameer, Hi Manish, +    unsigned int    type; + +    /* Dummy compatibility defines */ +    unsigned long pgsize_bitmap; +    struct iommu_domain_geometry geometry

Re: [Xen-devel] [RFC v4 8/8] drivers/passthrough/arm: Refactor code for arm smmu drivers

2018-01-16 Thread Manish Jaggi
On 01/16/2018 06:44 PM, Julien Grall wrote: On 16/01/18 12:40, Manish Jaggi wrote: Hi Julien, Hi, On 01/16/2018 02:11 AM, Julien Grall wrote: On 01/03/2018 05:34 AM, Manish Jaggi wrote: Hi Sameer, Hi Manish, +    unsigned int    type; + +    /* Dummy compatibility

Re: [Xen-devel] [RFC v4 8/8] drivers/passthrough/arm: Refactor code for arm smmu drivers

2018-01-16 Thread Manish Jaggi
On 01/16/2018 07:10 PM, Julien Grall wrote: Hi Manish, On 16/01/18 13:27, Manish Jaggi wrote: On 01/16/2018 06:44 PM, Julien Grall wrote: On 16/01/18 12:40, Manish Jaggi wrote: Hi Julien, Hi, On 01/16/2018 02:11 AM, Julien Grall wrote: On 01/03/2018 05:34 AM, Manish Jaggi wrote

Re: [Xen-devel] [RFC PATCH] arm64: vgic-v3: Add ITS doorbell region in Dom0 stage-2

2018-01-18 Thread Manish Jaggi
On 01/18/2018 10:22 PM, Julien Grall wrote: Hi Manish, Hi Julien, On 18/01/18 06:15, mja...@caviumnetworks.com wrote: From: Manish Jaggi This patch introduces a function vgic_map_translation_space for mapping ITS 64K translater space for doorbells in dom0 stage-2. It is required as dom0

Re: [Xen-devel] [RFC 01/11] acpi: arm: Public API for populating and query based on requesterid

2018-01-18 Thread Manish Jaggi
On 01/17/2018 12:01 AM, Julien Grall wrote: Hi Manish, Hi Julien, Thanks for reviewing the patch. I sent the previous e-mail too soon. On 02/01/18 09:27, manish.ja...@linaro.org wrote: From: Manish Jaggi   Public API to populate and query map between requester id and   streamId/DeviceID

Re: [Xen-devel] [RFC 02/11] acpi: arm: API to query estimated size of hardware domain's IORT

2018-01-18 Thread Manish Jaggi
On 01/17/2018 12:22 AM, Julien Grall wrote: Hi Manish, Hi Julien, Thanks for reviewing this patch. On 02/01/18 09:28, manish.ja...@linaro.org wrote: From: Manish Jaggi   Code to query estimated IORT size for hardware domain. Please avoid indenting the commit message. ok.   IORT for

Re: [Xen-devel] [RFC] ARM PCI Passthrough design document

2018-01-19 Thread Manish Jaggi
Hi Roger/Vikram/Stefano, On 07/08/2017 01:04 PM, Roger Pau Monné wrote: On Fri, Jul 07, 2017 at 02:50:01PM -0700, Stefano Stabellini wrote: On Fri, 7 Jul 2017, Roger Pau Monné wrote: On Thu, Jul 06, 2017 at 03:55:28PM -0500, Vikram Sethi wrote: AER: Will PCIe non-fatal and fatal errors (seco

Re: [Xen-devel] [RFC 01/11] acpi: arm: Public API for populating and query based on requesterid

2018-01-22 Thread Manish Jaggi
On 01/19/2018 05:33 PM, Julien Grall wrote: On 19/01/18 06:05, Manish Jaggi wrote: On 01/17/2018 12:01 AM, Julien Grall wrote: Hi Manish, Hi Julien, Thanks for reviewing the patch. I sent the previous e-mail too soon. On 02/01/18 09:27, manish.ja...@linaro.org wrote: From: Manish

Re: [Xen-devel] [RFC] ARM PCI Passthrough design document

2018-01-22 Thread Manish Jaggi
On 05/26/2017 10:44 PM, Julien Grall wrote: Hi all, Hi Julien, General consolidated comments first: Review Comments: a. The document talks about high level design and does not go into the implementation details  and detailed code flows. So this is missing if adding such detail is intended

<    1   2