try;
> -DEBUG ((EFI_D_WARN, "XenStore: WatchEvents is not empty, cleaning
> up..."));
> +DEBUG ((DEBUG_WARN, "XenStore: WatchEvents is not empty, cleaning
> up...\n"));
> Entry = GetFirstNode (&xs.WatchEvents);
> while (!IsNull (&xs.WatchEvents, Entry)) {
>XENSTORE_MESSAGE *Message = XENSTORE_MESSAGE_FROM_LINK (Entry);
>
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
ENSTORE_WATCH_SIGNATURE);
>
> - AsciiSPrint (Token, sizeof (Token), "%p", (VOID *) Watch);
> - if (XenStoreFindWatch (Token) == NULL) {
> + if (XenStoreFindWatch (Watch) == NULL) {
> return;
>}
>
> @@ -1393,6 +1394,7 @@ Xen
file changed, 35 insertions(+), 90 deletions(-)
This looks a bit more complex than what I can allocate time for now, so
I'll trust you on it -- it only modifies XenStore.c. Feedback from other
reviewers is encouraged.
Acked-by: Laszlo Ersek
Thanks
Laszlo
_
XENSTORE_STATUS_EINVAL;
> + }
>
> - return Status;
> + return XenStoreWrite (Transaction, DirectoryPath, Node, Buf);
> }
>
> XENSTORE_STATUS
>
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
atus;
> }
> @@ -1226,7 +1240,7 @@ XenStoreTransactionStart (
>XENSTORE_STATUS Status;
>
>Status = XenStoreSingle (XST_NIL, XS_TRANSACTION_START, "", NULL,
> - (VOID **) &IdStr);
> +NULL, (VOID **) &IdStr);
(5) Indentation.
>if (Status == XENSTORE_STATUS_SUCCESS) {
> Transaction->Id = (UINT32)AsciiStrDecimalToUintn (IdStr);
> FreePool (IdStr);
> @@ -1246,7 +1260,7 @@ XenStoreTransactionEnd (
>AbortStr[0] = Abort ? 'F' : 'T';
>AbortStr[1] = '\0';
>
> - return XenStoreSingle (Transaction, XS_TRANSACTION_END, AbortStr, NULL,
> NULL);
> + return XenStoreSingle (Transaction, XS_TRANSACTION_END, AbortStr, NULL,
> NULL, NULL);
> }
>
> XENSTORE_STATUS
>
With the above addressed:
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
190
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg/XenBusDxe/XenStore.c | 297 +++
> 1 file changed, 130 insertions(+), 167 deletions(-)
Sorry, too big for a detailed review, and I'd like to go through the
series today. So, based on the diffstat,
Ac
On 09/16/19 17:39, Laszlo Ersek wrote:
> On 09/13/19 16:50, Anthony PERARD wrote:
>> When doing an action with a path and subpath in the xenstore,
>> XenStoreJoin is called to generate "$path/$subpath". But this function
>> do an allocation of memory which i
On 09/13/19 16:50, Anthony PERARD wrote:
> We will use a buffer on the stack instead of allocating memory for
> internal functions that are expecting a reply from xenstore.
>
> The external interface XENBUS_PROTOCOL isn't changed yet, so
> allocation are made for XsRead and XsBackendRead.
>
> Ref:
his value" with
"XENSTORE_PAYLOAD_MAX").
Other than that, I'm going to have to ACK this after a brief skim only.
Acked-by: Laszlo Ersek
Thanks
Laszlo
> typedef enum {
>XENSTORE_STATUS_SUCCESS = 0,
>XENSTORE_STATUS_FAIL,
> @@ -64,19 +70,17 @@ typedef enum {
On 09/13/19 16:50, Anthony PERARD wrote:
> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid
> using the Memory Allocation Services.
>
> This comes with a new interface named RegisterExitCallback so that PV
> drivers can disconnect from the backend before XenBusDxe is teared
> down
On 09/16/19 20:36, Andrew Fish wrote:
>
>
>> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote:
>>
>> On 09/13/19 16:50, Anthony PERARD wrote:
>>> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid
>>> using the Memory Allocation Service
On 07/26/19 18:06, Anthony PERARD wrote:
> On Wed, Jul 10, 2019 at 04:05:02PM +0200, Laszlo Ersek wrote:
>> On 07/04/19 16:42, Anthony PERARD wrote:
>>> + if (State == NULL) {
>>> +Status = EFI_OUT_OF_RESOURCES;
>>> +goto Error;
>>> + }
&g
, "OvmfPkg: raise DXEFV size to 11 MB"
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - rebased
> - Update Maintainers.
EfiFirmwareVolumeTopFileGuid).
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - Update Maintainers.txt
>
> v3:
> - Added gEfiFirmwareVolumeTo
ntainers.txt
> index 34bdb275b4..42ec8d54af 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -379,6 +379,7 @@ F: OvmfPkg/PlatformPei/Xen.*
> F: OvmfPkg/SmbiosPlatformDxe/*Xen.c
> F: OvmfPkg/XenBusDxe/
> F: OvmfPkg/XenIoPciDxe/
> +F: OvmfPkg/XenPlatformPei/
> F: OvmfPkg/XenPvBlkDxe/
> F: OvmfPkg/XenResetVector/
> R: Anthony Perard
>
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
header, but this will be a manual step.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - fix top-level comment style
> - Update Maintainers.txt
>
&g
on't seems to be
> useful. This is the entry point used by HVM guest (hvmloader).
>
> [1] UefiCpuPkg/ResetVector/Vtf0/Ia16/ResetVectorVtf0.asm
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> --
; ResetSystemRuntimeDxe is calling the TimerLib API at runtime to do the
> operation "EfiResetCold", so this may never complete if the OS have
> disabled the Local APIC Timer.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
>
by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - fix top-level comment style
> - Update Maintainers.txt
>
> v3:
> - use SPDX
> - add XenPlatformLib.h to [LibraryClasses] in OvmfPkg.dec
> - fix typos
&g
is supposed to have sane default. MTRR will need
> to be done properly but keeping what's already been done by programmes
> that has runned before OVMF will do for now.
(1) s/programmes that has runned/programs that have run/
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?
On 07/30/19 13:45, Laszlo Ersek wrote:
> On 07/29/19 17:39, Anthony PERARD wrote:
>> When running as a Xen PVH guest, there is no CMOS to read the memory
>> size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can
>> work without CMOS by reading the e82
can work on
> both a Xen PVH guest and an HVM one.
>
> Based on the "OvmfPkg/8254TimerDxe" implementation.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
e.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - instead of creating a new XEN_CONSOLE_DEVICE_PATH, use the existing
> VENDOR_UART_DEVICE_PATH. And explain why VENDOR_UART_DEVICE_PATH
>
On 07/29/19 17:39, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v4
>
> Changes in v4:
> - patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has
> run" was removed, and ins
om/4badd535-c23d-c64d-7bb3-fb42bbbf538a@redhat.com>
I didn't realize we'd be introducing the PcdLib dependency anew.
(1) However, in that case, we should list PcdLib in the [LibraryClasses]
section of the INF file as well.
With (1) fixed:
Reviewed-by: Laszlo Ersek
There is no nee
!= NULL) {
> +FreePages (Allocation, FixedPcdGet32 (PcdXenGrantFrames));
> + }
> + return Status;
> +}
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 78e9f889ab..79defd13bf 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -382,6
.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v4:
> - Update Maintainers.txt
>
> v3:
> - fix the commit message body
>
> ArmVirtPkg/ArmVirtXen.dsc | 2
Hi Anthony,
On 07/29/19 17:39, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v4
>
> Changes in v4:
> - patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has
> run" was rem
On 08/08/19 15:44, Roger Pau Monné wrote:
> On Thu, Aug 08, 2019 at 02:28:32PM +0100, Anthony PERARD wrote:
>> On Wed, Aug 07, 2019 at 05:54:51PM +0200, Roger Pau Monné wrote:
>>> On Mon, Jul 29, 2019 at 04:39:38PM +0100, Anthony PERARD wrote:
PcdFSBClock is used by SecPeiDxeTimerLibCpu, the T
On 08/12/19 17:12, Anthony PERARD wrote:
> On Tue, Jul 30, 2019 at 03:10:13PM +0200, Laszlo Ersek wrote:
>> Hi Anthony,
>>
>> On 07/29/19 17:39, Anthony PERARD wrote:
>>> Patch series available in this git branch:
>>> https://xenbits.xen.org/git-http/peopl
On 08/13/19 13:31, Anthony PERARD wrote:
> XenPvhDetected() can be used to figure out if OVMF has started via the
> Xen PVH entry point.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
>
rcall which would give the same result.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - fix commit message, the hypercall *can* be made several time, but we
&
is supposed to have sane default. MTRR will need
> to be done properly but keeping what's already been done by programs
> that have run before OVMF will do for now.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked
core.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - fix typos in commit message.
Thanks for those fixes, my R-b stands.
Laszlo
> v4:
> - instead of creating a new XEN_CONSOLE_DEVICE_PA
gt; Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - add missing PcdLib to [LibraryClasses]
Yes, that's for
365f2b95-b6c9-03cf-5346-5e1192bfa437@redhat.com">http://mid.mail-archive.com/365f2b95-b6c9-03cf-5346-5e1192bfa43
en platform device which would start the XenIoPciDxe and allocate
> the space for the Grant Tables.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Reviewed-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - add m
On 08/15/19 11:40, Laszlo Ersek wrote:
> On 08/13/19 13:31, Anthony PERARD wrote:
>> Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow
>> the same value to be used in a different module.
>>
>> The reason for the number of page to be 4 doesn't ex
On 08/13/19 13:30, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v5
>
> Changes in v5:
> - patch 23 got a rework of the lapic range skipping
> - small fixups in patch 20, 22, 23, 31, 32, 33.
> s
On 08/15/19 13:03, Laszlo Ersek wrote:
> On 08/13/19 13:30, Anthony PERARD wrote:
>> Patch series available in this git branch:
>> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
>> br.platform-xen-pvh-v5
>>
>> Changes in v5:
>> - patch 23 g
:
> Add a extra parameter to indicate where to start the search for the
> boot firmware volume.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v3:
> - rebased, S
On 03/06/19 13:40, Igor Druzhinin wrote:
> On Xen, hvmloader firmware leaves address decoding enabled for
> enumerated PCI device before jumping into OVMF. OVMF seems to
> expect it to be disabled and tries to size PCI BARs in several places
> without disabling it which causes BAR64, for example, b
On 03/06/19 15:26, Igor Druzhinin wrote:
> On 06/03/2019 13:22, Laszlo Ersek wrote:
>> On 03/06/19 13:40, Igor Druzhinin wrote:
>>> On Xen, hvmloader firmware leaves address decoding enabled for
>>> enumerated PCI device before jumping into OVMF. OVMF seems to
>&
On 03/19/19 15:03, Anthony PERARD wrote:
> On Thu, Mar 14, 2019 at 07:45:56PM +, Igor Druzhinin wrote:
>> On 14/03/2019 17:41, Anthony PERARD wrote:
>>> Hi,
>>>
>>> On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote:
This aperture doesn't exist in OVMF and trying to use it caus
On 03/22/19 09:33, Roger Pau Monné wrote:
> On Wed, Mar 06, 2019 at 12:40:54PM +, Igor Druzhinin wrote:
>> This aperture doesn't exist in OVMF and trying to use it causes
>> failing assertions later in cases there are prefetchable and
>> non-prefetchable BARs following each other. This configur
On 04/08/19 16:23, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v2
>
> Hi,
>
> I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc
> with the goal to make it work on both Xen H
On 04/09/19 05:12, Igor Druzhinin wrote:
> On Xen, hvmloader firmware leaves address decoding enabled for
> enumerated PCI device before jumping into OVMF. OVMF seems to
> expect it to be disabled and tries to size PCI BARs in several places
> without disabling it which causes BAR64, for example, b
Hi Igor,
On 04/09/19 05:12, Igor Druzhinin wrote:
> Igor Druzhinin (3):
> OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge
> aperture
> OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64
> OvmfPkg/XenSupport: turn off address decoding before BAR sizing
>
On 04/08/19 17:50, Laszlo Ersek wrote:
> On 04/08/19 16:23, Anthony PERARD wrote:
>> Patch series available in this git branch:
>> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
>> br.platform-xen-pvh-v2
>>
>> Hi,
>>
>> I've sta
.c
> @@ -17,11 +17,10 @@
> #include
> #include
> #include
> +#include
> #include
> #include
>
> -#include
> -
> VOID
> AcpiPmControl (
>UINTN SuspendType
>
Hm, the duplicated #include is my fault, from commit 1466b76f9385
("OvmfPkg: d
On 04/09/19 13:08, Anthony PERARD wrote:
> This is a copy of OvmfX64, removing VirtIO and some SMM.
>
> This new platform will be changed to make it works on two types of Xen
> guest: HVM and PVH.
>
> Compare to OvmfX64, this patch:
>
> - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITIO
(1) Yes, please mention "gEfiFirmwareVolumeTopFileGuid" here.
With that commit message update:
Reviewed-by: Laszlo Ersek
Thanks,
Laszlo
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Anthony PERARD
> ---
> OvmfPkg/XenOvmf.dsc
> -if (!EFI_ERROR (GetNamedFwCfgBoolean ( \
> - "opt/ovmf/" #TokenName, &Setting))) { \
> - PcdStatus = PcdSetBoolS (TokenName, Setting); \
> - ASSERT_RETURN_ERROR (PcdStatus);
ten
Cc: Julien Grall
Cc: Lars Kurth
Cc: xen-devel@lists.xenproject.org
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1654
Signed-off-by: Laszlo Ersek
---
OvmfPkg/License.txt | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/License.txt b/OvmfPkg/Licen
icense
blocks with the corresponding SPDX License IDs.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Lars Kurth
Cc: xen-devel@lists.xenproject.org
Thanks,
Laszlo
Laszlo Ersek (4):
OvmfPkg/License.txt: remove XenPvBlkDxe from the MIT licensed dir list
OvmfPk
roject.org
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1654
Signed-off-by: Laszlo Ersek
---
OvmfPkg/XenBusDxe/XenStore.h | 18 +-
OvmfPkg/XenBusDxe/XenBus.c | 18 +-
OvmfPkg/XenBusDxe/XenStore.c | 18 +-
3 files changed, 3 insertions(
ore.org/show_bug.cgi?id=1654
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h| 18
+-
OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 18
+-
OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h
lists.xenproject.org
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1654
Signed-off-by: Laszlo Ersek
---
OvmfPkg/License.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/OvmfPkg/License.txt b/OvmfPkg/License.txt
index 0666e1bac65e..a2e02a1796aa 100644
--- a/OvmfPkg/License.txt
+++ b
On 04/10/19 11:48, Jordan Justen wrote:
> On 2019-04-09 04:08:15, Anthony PERARD wrote:
>> This is a copy of OvmfX64, removing VirtIO and some SMM.
>>
>> This new platform will be changed to make it works on two types of Xen
>> guest: HVM and PVH.
>>
>> Compare to OvmfX64, this patch:
>>
>> - chang
On 04/10/19 20:37, Jordan Justen wrote:
> On 2019-04-10 07:27:15, Laszlo Ersek wrote:
>> On 04/10/19 11:48, Jordan Justen wrote:
>>> On 2019-04-09 04:08:15, Anthony PERARD wrote:
>>>> This is a copy of OvmfX64, removing VirtIO and some SMM.
>>>>
>>
On 04/09/19 13:08, Anthony PERARD wrote:
> This header replace the embedded variable store.
>
> The ELF header explain to a loader to load the binary at the address
> 1MB, then jump to the PVH entry point which will be created in a later
> patch.
>
> That patch include generate_elf_header.c which
DX IDs, but the copies you created earlier don't, and that will
present itself as a difference with --find-copies-harder.)
With the above two formalities fixed:
Acked-by: Laszlo Ersek
Thanks
Laszlo
> @@ -27,9 +29,23 @@ ALIGN 16
> ; located just below 0x1 (4GB) in the firmw
tr|0x0|UINT32|0x30
> + gUefiOvmfPkgTokenSpaceGuid.PcdXenStartOfDayStructPtrSize|0x0|UINT32|0x31
> +
(2) calling these PcdXenPvh* rather than just PcdXen*
(my understanding is that they are specific to PVH)
(3) Please use token values 0x17 and 0x28. That should decrease
ctor}/Ia32/SearchForBfvBase.asm | 19 +
> OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm
> | 30 ++--
> 4 files changed, 66 insertions(+), 11 deletions(-)
(4) For the subject line: please drop the word "to".
With th
gt;
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
(1) I suggest simplifying this patch by:
- deleting all TimerLib resolutions except the one
On 04/11/19 13:25, Laszlo Ersek wrote:
> On 04/09/19 13:08, Anthony PERARD wrote:
>> ACPI Timer does not work in a PVH guest, but local APIC works on both
>> PVH and HVM.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Anthony PERAR
(CHAR8 *) &Info->Signature, sizeof (Info->Signature));
(3) This should be indented as:
AsciiStrnCpyS (
Sig,
sizeof (Sig),
(CHAR8 *) &Info->Signature,
sizeof (Info->Signature)
);
or:
AsciiStrnCpyS (Sig, sizeof (Sig), (CHAR8 *) &Info->
On 04/11/19 13:47, Laszlo Ersek wrote:
> On 04/09/19 13:08, Anthony PERARD wrote:
>> This struct is only useful to retrieve the E820 table. The
>
> (1) please replace "this struct" with the name of the struct.
>
>> mXenHvmloaderInfo isn't used yet
return EFI_SUCCESS;
>}
>
> - ASSERT (Info->E820 < MAX_ADDRESS);
> - *Entries = (EFI_E820_ENTRY64 *)(UINTN) Info->E820;
> - *Count = Info->E820EntriesCount;
> -
> - return EFI_SUCCESS;
> + return EFI_NOT_FOUND;
> }
>
> /**
>
Acked-b
e information from the start of day structure if we have
> + // booted via the PVH entry point.
> + //
> +
> + PVHResetVectorData = (VOID *)(UINTN) PcdGet32(PcdXenStartOfDayStructPtr);
(2) missing space after PcdGet32
> + //
> + // That magic value is "XPVH", and it is written in
>
On 04/09/19 13:08, Anthony PERARD wrote:
> The purpose of XenPlatformPei is to regroup the few functions that are
(1) did you mean XenPlatformLib here?
> used in several places to detect if Xen is detected, and to get the
> XenInfo HOB.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
On 04/09/19 13:08, Anthony PERARD wrote:
> If the firmware have been started via the PVH entry point, a RSDP
> pointer would have been provided. Use it.
>
> Also, use XenDetect() from the new XenPlatformLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Anthony PERA
On 04/11/19 14:20, Laszlo Ersek wrote:
> On 04/09/19 13:08, Anthony PERARD wrote:
>> If the firmware have been started via the PVH entry point, a RSDP
>> pointer would have been provided. Use it.
>>
>> Also, use XenDetect() from the new XenPlatformLib.
>>
On 04/11/19 14:23, Laszlo Ersek wrote:
> On 04/11/19 14:20, Laszlo Ersek wrote:
>> On 04/09/19 13:08, Anthony PERARD wrote:
>>> If the firmware have been started via the PVH entry point, a RSDP
>>> pointer would have been provided. Use it.
>>>
>>> Also
On 04/09/19 13:08, Anthony PERARD wrote:
> Allow to use Xen hypercalls earlier, during the PEIM stage, but
> XenHypercallLibReInit() must be called once the XenInfo HOB is created
> with the HyperPage setup.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Anthony PERAR
mPei/Xen.c
> @@ -202,6 +202,13 @@ XenDetect (
>return FALSE;
> }
>
> +BOOLEAN
> +XenHvmloaderDetected (
> + VOID
> + )
> +{
> + return (mXenHvmloaderInfo != NULL);
> +}
>
> VOID
> XenPublishRamRegions (
>
(1) Please add least one se
leBusEnumeration, TRUE);
>ASSERT_RETURN_ERROR (PcdStatus);
>
(1) please fix the subject: s/as runned/has run/
(2) please write a nonempty commit message body.
With that:
Acked-by: Laszlo Ersek
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
ot;Detected Xen version %d.%d\n",
>XenVersion >> 16, XenVersion & 0x));
>mXenInfo.VersionMajor = (UINT16)(XenVersion >> 16);
> @@ -265,12 +272,6 @@ InitializeXen (
> {
>RETURN_STATUS PcdStatus;
>
> - if (mXenLeaf == 0) {
> -return EFI_NOT_
+ ASSERT (mXenInfo.VersionMajor != 0);
> +
> + return mXenHvmloaderInfo == NULL;
> +}
> +
> VOID
> XenPublishRamRegions (
>VOID
>
(1) Please write a nonempty commit message body.
with that
Acked-by: Laszlo Ersek
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io L
On 04/09/19 13:08, Anthony PERARD wrote:
> This is copied over from the public header of the Xen Project, with the
(1) Please expand "This".
with that,
Acked-by: Laszlo Ersek
Thanks
Laszlo
> type name modified to build on OVMF.
>
> Contributed-under: TianoCore Cont
tries[Index].BaseAddr) {
> +TmpEntry = E820Entries[Index];
> +E820Entries[Index] = E820Entries[Index - 1];
> +E820Entries[Index - 1] = TmpEntry;
> + }
> +}
> + }
> +
> + *Count = E820EntriesCount;
> + *Entries = E820Entries;
> +
> + return EFI_SU
On 04/10/19 14:58, Laszlo Ersek wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch: ovmf_spdx_mit
>
> For <https://bugzilla.tianocore.org/show_bug.cgi?id=1373>, we replaced
> open-coded license text blocks with "SPDX-License-Identifier"s, almost
>
he Reserve type and explain
> about the ACPI type. MTRR settings aren't modified anymore, on HVM, it's
> already done by hvmloader, on PVH it is supposed to have sane default.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Anthony PERARD
> -
On 04/09/19 13:08, Anthony PERARD wrote:
> Linux panic if this region isn't reserved.
Please expand "this" (just copy from the subject).
with that,
Acked-by: Laszlo Ersek
Thanks
Laszlo
>
> When Linux is booted on EFI system, it expects the memory at 0xa to
> _
On 04/09/19 13:08, Anthony PERARD wrote:
> When the device ID of the host bridge is unknown, check if we are
> running as a PVH guest as there is no PCI bus in that case.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Anthony PERARD
> ---
>
> Notes:
> v2:
>
On 04/15/19 15:29, Laszlo Ersek wrote:
> On 04/09/19 13:08, Anthony PERARD wrote:
>> When the device ID of the host bridge is unknown, check if we are
>> running as a PVH guest as there is no PCI bus in that case.
>>
>> Contributed-under: TianoCore Contribution Agr
, 0, 0x6b), 0x0b); // H
>break;
> +case XEN_PVH_PCI_HOST_BRIDGE_DEVICE_ID:
> + //
> + // There are no PCI bus in this case.
(1) s/are/is/, please
with that:
Reviewed-by: Laszlo Ersek
Thanks
Laszlo
> + //
> + return;
> default:
>DEBUG ((EFI_D_ER
On 04/15/19 15:33, Laszlo Ersek wrote:
> On 04/09/19 13:08, Anthony PERARD wrote:
>> When running on PVH without PCI bus, the XenPlatformPei will set
>> PcdOvmfHostBridgePciDevId to XEN_PVH_PCI_HOST_BRIDGE_DEVICE_ID.
>>
>> Contributed-under: TianoCore Contribution Agr
On 04/09/19 13:08, Anthony PERARD wrote:
> That value is used by SecPeiDxeTimerLibCpu, the TimerLib implementation.
> It will also be used by XenTimerDxe.
(1) please expand "that value".
with that,
Acked-by: Laszlo Ersek
Thanks
Laszlo
>
> Contributed-under: TianoCore
On 04/09/19 13:08, Anthony PERARD wrote:
> "PcAtChipsetPkg/8254TimerDxe" is replaced with a Xen-specific
> EFI_TIMER_ARCH_PROTOCOL implementation. Also remove
> 8259InterruptControllerDxe as it is not used anymore.
>
> This Timer uses the local APIC timer as time source as it can work on
> both a
On 04/09/19 13:08, Anthony PERARD wrote:
> On a Xen PVH guest, none of the existing serial or console interface
> works, so we add a new one, based on XenConsoleSerialPortLib, and
> implemeted via SerialDxe.
>
> That a simple console implementation that can works on both PVH guest
(1) ITYM "that *
On 04/15/19 16:40, Anthony PERARD wrote:
> On Mon, Apr 15, 2019 at 03:49:25PM +0200, Laszlo Ersek wrote:
>> On 04/15/19 15:33, Laszlo Ersek wrote:
>>> On 04/09/19 13:08, Anthony PERARD wrote:
>>>> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlat
On 04/09/19 13:08, Anthony PERARD wrote:
> This "device" use XenIoMmioLib to reserve some space to be use by the
> Grant Tables.
(1) can we replace "this device" with "XenIoPvhDxe"?
>
> The call is only done if it is necessary, we simply detect if the guest
> is probably PVH, as in this case the
On 04/09/19 13:08, Anthony PERARD wrote:
> So it can be used from the OvmfPkg by the following patch,
> "OvmfPkg/XenOvmf: use RealTimeClockRuntimeDxe from EmbeddedPkg"
(1) Please make the commit message self-contained.
with that,
Reviewed-by: Laszlo Ersek
Thanks
Laszlo
>
rtXen.dsc", that is, please resolve the
RealTimeClockLib class to XenRealTimeClockLib.inf globally, under
[LibraryClasses].
With that,
Acked-by: Laszlo Ersek
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#39160): https:
SET)
> + );
> +
>for (Offset = BarOffsetBase; Offset < BarOffsetEnd; Offset += sizeof
> (UINT32)) {
> PcatPciRootBridgeBarExisted (
>PCI_LIB_ADDRESS (Bus, Device, Function, Offset),
>
Acked-by: Laszlo Ersek
Someone from the Xen community please ACK this t
On 04/30/19 18:35, Anthony PERARD wrote:
> On Fri, Apr 26, 2019 at 08:15:07PM +0200, Laszlo Ersek wrote:
>> On 04/25/19 22:23, Igor Druzhinin wrote:
>>> On Xen, hvmloader firmware leaves address decoding enabled for
>>> enumerated PCI device before jumping into OVMF. OVM
On 11/20/18 17:33, Igor Mammedov wrote:
> On Wed, 7 Nov 2018 16:36:40 +0400
> Marc-André Lureau wrote:
>
>> Interfaces don't have instance, let's make the interface type really
>> abstract to avoid confusion.
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> include/hw/acpi/acpi_dev_interface.h
On 01/29/20 13:12, Anthony PERARD wrote:
> To avoid nasm generating a warning, replace the macro by the value
> expected to be stored in eax.
> Ia32/XenPVHMain.asm:76: warning: dword data exceeds bounds
>
> Reported-by: Laszlo Ersek
> Signed-off-by: Anthony PERARD
to configure X86 Processor FSB clock.
> + # @Prompt FSB Clock.
> + gEfiMdePkgTokenSpaceGuid.PcdFSBClock|2|UINT32|0x000c
> +
> [UserExtensions.TianoCore."ExtraFiles"]
>MdePkgExtra.uni
>
Looks good to me:
Reviewed-by: Laszlo Ersek
Mike or Liming will
};
> #ifndef __XEN__
> typedef struct shared_info shared_info_t;
> +typedef struct shared_info XEN_SHARED_INFO;
> #endif
>
> /* Turn a plain number into a C UINTN constant. */
>
Assuming the OVMF platforms continue to build at this stage into the
series, and provided that (1) and (2) are fixed:
Reviewed-by: Laszlo Ersek
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
1 - 100 of 156 matches
Mail list logo
