Re: [PATCH 17/24] rbd: use set_capacity_and_notify

2020-11-09 Thread Ilya Dryomov
set_capacity(rbd_dev->disk, size); > - revalidate_disk_size(rbd_dev->disk, true); > + set_capacity_and_notify(rbd_dev->disk, size); > } > } > > -- > 2.28.0 > Acked-by: Ilya Dryomov Thanks, Ilya

Re: [PATCH 17/24] rbd: use set_capacity_and_notify

2020-11-11 Thread Ilya Dryomov
On Wed, Nov 11, 2020 at 9:27 AM Christoph Hellwig wrote: > > Use set_capacity_and_notify to set the size of both the disk and block > device. This also gets the uevent notifications for the resize for free. > > Signed-off-by: Christoph Hellwig > Acked-by: Jack Wang > --- > drivers/block/rbd.c

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Ilya Dryomov
On Wed, May 29, 2024 at 7:05 AM Christoph Hellwig wrote: > > The soft max_sectors limit is normally capped by the hardware limits and > an arbitrary upper limit enforced by the kernel, but can be modified by > the user. A few drivers want to increase this limit (nbd, rbd) or > adjust it up or dow

Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors

2024-05-30 Thread Ilya Dryomov
On Fri, May 31, 2024 at 7:54 AM Christoph Hellwig wrote: > > On Thu, May 30, 2024 at 09:48:06PM +0200, Ilya Dryomov wrote: > > For rbd, this change effectively lowers max_sectors from 4M to 64K or > > less and that is definitely not desirable. From previous interactions >

Re: [PATCH 03/14] rbd: increase io_opt again

2024-05-31 Thread Ilya Dryomov
.io_opt = objset_bytes, > .io_min = rbd_dev->opts->alloc_size, > - .io_opt = rbd_dev->opts->alloc_size, > .max_segments = USHRT_MAX, > .max_segment_size = UINT_MAX, > }; > -- > 2.43.0 > Acked-by: Ilya Dryomov Thanks, Ilya

Re: [PATCH 04/14] block: take io_opt and io_min into account for max_sectors

2024-05-31 Thread Ilya Dryomov
and sd. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Bart Van Assche > Reviewed-by: Damien Le Moal > --- > block/blk-settings.c | 7 +++ > drivers/block/nbd.c | 2 +- For rbd > drivers/block/rbd.c | 1 - Acked-by: Ilya Dryomov Thanks, Ilya

Re: [PATCH 6/7] block: Clean up local variable shadowing

2023-09-11 Thread Ilya Dryomov
gt; else rename variables. For rbd > block/rbd.c | 2 +- Acked-by: Ilya Dryomov Thanks, Ilya