Re: [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

multipath device will _not_ change if there is a change on the underlying devices. While personally I would _love_ to have this patch, we should at least document this by making it a separate patch. And we possibly should check if both sizes are the same, and think of what we should be doin

Re: [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

On 11/9/20 9:53 AM, Christoph Hellwig wrote: On Mon, Nov 09, 2020 at 08:53:58AM +0100, Hannes Reinecke wrote: index 376096bfc54a83..4e86c9aafd88a7 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2053,7 +2053,7 @@ static void nvme_update_disk_info(struct gendisk *disk

Re: [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

EN for _all_ paths, but rather one AEN per path. Which will be processed separately, leading to the issue described above. Not sure how this is different than what we have today... Oh, that is a problem even today. So we should probably move it to a different thread... Cheers, Hannes -- Dr.

Re: [PATCH 01/24] block: remove the call to __invalidate_device in check_disk_size_change

only reason this hasn't been a major issue is because so many people use partitions, for which no invalidation was performed anyway. Signed-off-by: Christoph Hellwig --- fs/block_dev.c | 6 -- 1 file changed, 6 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hanne

Re: [PATCH 02/24] loop: remove loop_set_size

+++-- 1 file changed, 7 insertions(+), 30 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809

Re: [PATCH 03/24] nvme: let set_capacity_revalidate_and_notify update the bdev size

On 11/11/20 9:26 AM, Christoph Hellwig wrote: There is no good reason to call revalidate_disk_size separately. Signed-off-by: Christoph Hellwig --- drivers/nvme/host/core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [PATCH 05/24] block: remove the update_bdev parameter from set_capacity_revalidate_and_notify

| 3 +-- 7 files changed, 16 insertions(+), 22 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB

Re: [PATCH 04/24] sd: update the bdev size in sd_revalidate_disk

+++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Hannes Reinecke Cheers. Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG

Re: [PATCH 06/24] block: add a return value to set_capacity_and_notify

On 11/11/20 9:26 AM, Christoph Hellwig wrote: Return if the function ended up sending an uevent or not. Signed-off-by: Christoph Hellwig --- block/genhd.c | 7 +-- include/linux/genhd.h | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Hannes Reinecke

Re: [PATCH 13/24] dm: use set_capacity_and_notify

deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 15/24] nvme: use set_capacity_and_notify in nvme_set_queue_dying

+ 1 file changed, 1 insertion(+), 12 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG

Re: [PATCH 20/24] dm-raid: use set_capacity_and_notify

deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix

Re: [PATCH 30/78] block: don't call into the driver for BLKROSET

deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 31/78] loop: use set_disk_ro

; - set_device_ro(bdev, (lo->lo_flags & LO_FLAGS_READ_ONLY) != 0); + set_disk_ro(lo->lo_disk, (lo->lo_flags & LO_FLAGS_READ_ONLY) != 0); lo->use_dio = lo->lo_flags & LO_FLAGS_DIRECT_IO; lo->lo_device = bdev; Reviewed-by: Hannes Reinecke Cheers,

Re: [PATCH 32/78] block: remove set_device_ro

struct block_device *bdget_disk(struct gendisk *disk, int partno); -extern void set_device_ro(struct block_device *bdev, int flag); extern void set_disk_ro(struct gendisk *disk, int flag); static inline int get_disk_ro(struct gendisk *disk) Reviewed-by: Hannes Reinecke Cheers, H

Re: [PATCH 33/78] block: remove __blkdev_driver_ioctl

| 5 - include/linux/blkdev.h | 2 -- 5 files changed, 16 insertions(+), 27 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions

Re: [PATCH 34/78] block: propagate BLKROSET to all partitions

) return ret; } - bdev->bd_part->policy = n; + if (bdev_is_partition(bdev)) + bdev->bd_part->policy = n; + else + set_disk_ro(bdev->bd_disk, n); return 0; } Reviewed-by: Hannes Reinecke

Re: [PATCH 53/78] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats

;iostat.cur, &tmp); u64_stats_update_end(&blkg->iostat.sync); } + disk_put_part(part); } } Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688

Re: [PATCH 54/78] block: remove a duplicate __disk_get_part prototype

tic inline void disk_put_part(struct hd_struct *part) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809

Re: [PATCH 55/78] block: change the hash used for looking up block devices

= S_IFBLK; inode->i_rdev = dev; inode->i_bdev = bdev; Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxf

Re: [PATCH 56/78] init: refactor name_to_dev_t

(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 57/78] init: refactor devt_from_partuuid

insertions(+), 37 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 58/78] init: cleanup match_dev_by_uuid and match_dev_by_label

Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 59/78] mtip32xx: remove the call to fsync_bdev on removal

deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 60/78] zram: remove the claim mechanism

be simplified as no I/O can be outstanding on a block device that is not open. Signed-off-by: Christoph Hellwig --- drivers/block/zram/zram_drv.c | 76 ++- 1 file changed, 21 insertions(+), 55 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [PATCH 61/78] zram: do not call set_blocksize

files changed, 1 insertion(+), 11 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG

Re: [PATCH 62/78] loop: do not call set_blocksize

Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 64/78] dm: simplify flush_bio initialization in __send_empty_flush

, ti->num_flush_bios, NULL); Ah, thought as much. I've stumbled across this while debugging blk-interposer. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Softw

Re: [PATCH 65/78] dm: remove the block_device reference in struct mapped_device

rozen_sb); + bdput(bdev); md->frozen_sb = NULL; clear_bit(DMF_FROZEN, &md->flags); } Yay. Just what I need for the blk-interposer code, where the ->bdev pointer is really getting in the way. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reineck

Re: [PATCH 66/78] block: keep a block_device reference for each hd_struct

| 28 +++--- fs/block_dev.c | 133 +++--- include/linux/blk-cgroup.h | 4 +- include/linux/blkdev.h | 3 + include/linux/genhd.h | 4 +- 9 files changed, 153 insertions(+), 286 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [PATCH 67/78] block: simplify the block device claiming interface

+++--- include/linux/blkdev.h | 6 ++-- 3 files changed, 38 insertions(+), 49 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5

Re: [PATCH 68/78] block: remove ->bd_contains

50 +-- include/linux/blk_types.h | 4 +++- 3 files changed, 20 insertions(+), 36 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 S

Re: [PATCH 69/78] block: remove the nr_sects field in struct hd_struct

files changed, 47 insertions(+), 189 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG

Re: [PATCH 70/78] block: replace bd_mutex with a per-gendisk mutex

+ fs/btrfs/volumes.c | 2 +- fs/super.c | 8 ++-- include/linux/blk_types.h | 1 - include/linux/genhd.h | 1 + 15 files changed, 80 insertions(+), 83 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [PATCH 71/78] block: add a bdev_kobj helper

/blk_types.h | 3 +++ 4 files changed, 9 insertions(+), 20 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 72/78] block: use disk_part_iter_exit in disk_part_iter_next

= NULL; + disk_part_iter_exit(piter); /* get part_tbl */ rcu_read_lock(); Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5,

Re: [PATCH 73/78] block: use put_device in put_disk

ev(disk)); } EXPORT_SYMBOL(put_disk); Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG N

Re: [PATCH 74/78] block: merge struct block_device and struct hd_struct

| 17 +- init/do_mounts.c | 20 +-- kernel/trace/blktrace.c| 54 ++- 33 files changed, 351 insertions(+), 642 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de

Re: [PATCH 01/45] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats

: Johannes Thumshirn Acked-by: Tejun Heo --- block/blk-cgroup.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solu

Re: [PATCH 02/45] filemap: consistently use ->f_mapping over ->i_mapping

e changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG

Re: [PATCH 03/45] fs: remove get_super_thawed and get_super_exclusive_thawed

++ include/linux/fs.h | 4 +--- 4 files changed, 29 insertions(+), 59 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH

Re: [PATCH 01/26] sd: fix sd_is_zoned

t;block: remove support for the host aware zone model") Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.h | 7 ++- drivers/scsi/sd_zbc.c | 7 +-- 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics

ce->type == TYPE_ZBC) Why not sd_is_zoned()? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd

insertions(+), 1 deletion(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I

Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits

ock/loop.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr.

Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O

: Christoph Hellwig --- drivers/block/loop.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911

Re: [PATCH 06/26] loop: also use the default block size from an underlying block device

: Christoph Hellwig --- drivers/block/loop.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software

Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits

changed, 4 insertions(+), 19 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode

+++-- 1 file changed, 3 insertions(+), 10 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG

Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size

(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail

+ 1 file changed, 9 insertions(+), 20 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg

Re: [PATCH 11/26] block: freeze the queue in queue_attr_store

--- block/blk-mq.c| 5 +++-- block/blk-sysfs.c | 9 ++--- 2 files changed, 5 insertions(+), 9 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software

Re: [PATCH 12/26] block: remove blk_flush_policy

Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

limits.features & BLK_FLAGS_WRITE_CACHE_DISABLED) Where is the difference between 'flags' and 'features'? Ie why is is named BLK_FEAT_FUA but BLK_FLAGS_WRITE_CACHE_DISABLED? And if the feature is the existence of a capability, and the flag is the setting of that capability,

Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail

--- drivers/block/xen-blkfront.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE

Re: [PATCH 03/26] sd: move zone limits setup out of sd_read_block_characteristics

| 9 + 2 files changed, 10 insertions(+), 20 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461

Re: [PATCH 13/26] block: move cache control settings out of queue->flags

ed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH 14/26] block: move the nonrot flag to queue_limits

: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH 15/26] block: move the add_random flag to queue_limits

anged, 10 insertions(+), 44 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits

+++-- drivers/md/md.c | 5 ++--- drivers/nvme/host/multipath.c | 2 +- include/linux/blkdev.h| 9 + 8 files changed, 26 insertions(+), 24 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h

Re: [PATCH 17/26] block: move the stable_writes flag to queue_limits

/iscsi_tcp.c | 8 include/linux/blkdev.h | 9 ++--- 12 files changed, 29 insertions(+), 77 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053

Re: [PATCH 18/26] block: move the synchronous flag to queue_limits

| 2 +- drivers/block/zram/zram_drv.c | 4 ++-- drivers/nvdimm/btt.c | 3 +-- drivers/nvdimm/pmem.c | 4 ++-- include/linux/blkdev.h| 7 --- 6 files changed, 10 insertions(+), 11 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [PATCH 19/26] block: move the nowait flag to queue_limits

+++--- drivers/md/md.c | 18 +- drivers/nvme/host/multipath.c | 3 +-- include/linux/blkdev.h| 9 + 8 files changed, 22 insertions(+), 42 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel

Re: [PATCH 20/26] block: move the dax flag to queue_limits

++-- drivers/nvdimm/pmem.c| 7 ++- drivers/s390/block/dcssblk.c | 2 +- include/linux/blkdev.h | 6 -- 5 files changed, 9 insertions(+), 11 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h

Re: [PATCH 21/26] block: move the poll flag to queue_limits

-sysfs.c | 4 +-- drivers/md/dm-table.c | 54 +-- drivers/nvme/host/multipath.c | 12 +--- include/linux/blkdev.h| 4 ++- 8 files changed, 45 insertions(+), 76 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [PATCH 22/26] block: move the zoned flag into the features field

/blkdev.h | 9 ++--- 10 files changed, 23 insertions(+), 19 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr

Re: [PATCH 23/26] block: move the zone_resetall flag to queue_limits

Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich

Re: [PATCH 24/26] block: move the pci_p2pdma flag to queue_limits

+++- include/linux/blkdev.h | 7 --- 3 files changed, 7 insertions(+), 9 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH

Re: [PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits

| 8 +--- include/linux/blkdev.h | 6 -- 3 files changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software

Re: [PATCH 26/26] block: move the bounce flag into the features field

+- include/linux/blkdev.h | 6 -- 4 files changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect h...@suse.de+49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr

Re: [PATCH v2 03/10] nvme-multipath: add error handling support for add_disk()

bit(NVME_NSHEAD_DISK_LIVE, &head->flags); nvme_add_ns_head_cdev(head); } Errm. Setting the same bit twice? And shouldn't you unset the bit if 'device_add_disk()' fails? Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de