Re: [Xen-devel] [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function

2018-09-20 Thread Grygorii Strashko
On 09/20/2018 07:32 AM, YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_t. > May

Re: [PATCH v5 1/3] xen/device-tree: Let DT reserve map entries overlap reserved-memory

2024-11-04 Thread Grygorii Strashko
Hi All, On 04.11.24 12:49, Michal Orzel wrote: On 27/09/2024 00:24, Shawn Anastasio wrote: Commit 53dc37829c31 ("xen/arm: Add DT reserve map regions to bootinfo.reserved_mem") changes the way reserve map regions are tracked, and as a result broke bootfdt's ability to handle device trees in

Re: [PATCH v5 1/3] xen/device-tree: Let DT reserve map entries overlap reserved-memory

2024-11-04 Thread Grygorii Strashko
On 04.11.24 14:39, Grygorii Strashko wrote: Hi All, On 04.11.24 12:49, Michal Orzel wrote: On 27/09/2024 00:24, Shawn Anastasio wrote: Commit 53dc37829c31 ("xen/arm: Add DT reserve map regions to bootinfo.reserved_mem") changes the way reserve map regions are tracked, and a

Re: [PATCH v5 1/3] xen/device-tree: Let DT reserve map entries overlap reserved-memory

2024-11-05 Thread Grygorii Strashko
On 05.11.24 12:42, Michal Orzel wrote: On 04/11/2024 13:39, Grygorii Strashko wrote: Hi All, On 04.11.24 12:49, Michal Orzel wrote: On 27/09/2024 00:24, Shawn Anastasio wrote: Commit 53dc37829c31 ("xen/arm: Add DT reserve map regions to bootinfo.reserved_mem") chang

Re: [PATCH v2 3/8] xen/arm: Add SCMI over SMC calls handling layer

2024-11-01 Thread Grygorii Strashko
Hi I'd be apprcieated if could consider my comments below. On 30.09.24 14:47, Andrei Cherechesu (OSS) wrote: From: Andrei Cherechesu Introduce the SCMI layer to have some basic degree of awareness about SMC calls that are based on the ARM System Control and Management Interface (SCMI) specifi

Re: [PATCH] xen/device-tree: Allow exact match for overlapping regions

2024-11-13 Thread Grygorii Strashko
Hi All, On 07.11.24 11:42, Grygorii Strashko wrote: On 06.11.24 17:16, Luca Fancellu wrote: Hi Michal, So we have 2 separate issues. I don't particularly like the concept of introducing MEMBANK_NONE and the changes below look a bit too much for me, given that for boot modules w

Re: [PATCH] xen/device-tree: Allow exact match for overlapping regions

2024-11-06 Thread Grygorii Strashko
allowing reserved-memory node ranges and boot modules to have an exact match with ranges from /memreserve/. While there, set a type for the memory recorded during ACPI boot. Fixes: 53dc37829c31 ("xen/arm: Add DT reserve map regions to bootinfo.reserved_mem") Reported-by: Shawn Anastasio Re

Re: [PATCH] xen/device-tree: Allow exact match for overlapping regions

2024-11-07 Thread Grygorii Strashko
On 06.11.24 17:16, Luca Fancellu wrote: Hi Michal, So we have 2 separate issues. I don't particularly like the concept of introducing MEMBANK_NONE and the changes below look a bit too much for me, given that for boot modules we can only have /memreserve/ matching initrd. Shawn patch fixes

Re: [PATCH] xen/device-tree: Allow exact match for overlapping regions

2024-11-14 Thread Grygorii Strashko
On 14.11.24 15:09, Julien Grall wrote: On 14/11/2024 12:22, Michal Orzel wrote: On 14/11/2024 13:04, Julien Grall wrote: Hi Michal, On 14/11/2024 11:48, Michal Orzel wrote: On 14/11/2024 11:31, Julien Grall wrote: Looking at the code, I think /memreserve/ and /reserved-memory are

Re: [PATCH v2] xen/device-tree: Allow region overlapping with /memreserve/ ranges

2024-11-14 Thread Grygorii Strashko
eserve map regions to bootinfo.reserved_mem") Reported-by: Shawn Anastasio Reported-by: Grygorii Strashko Signed-off-by: Luca Fancellu --- Changes from v1: - fixed commit message - used boolean to allow /memreserve/ overlap or not - now 'struct membanks *' have a type, while

[PATCH] device-tree: optimize dt_device_for_passthrough()

2025-02-11 Thread Grygorii Strashko
evice_node as passthrough while unflattening DT. This patch introduced new struct dt_device_node property "is_passthrough" which is filled if "xen,passthrough" property is present while unflattening DT and dt_device_for_passthrough() just return it's value. Signed-off-by:

Re: [PATCH] device-tree: optimize dt_device_for_passthrough()

2025-02-11 Thread Grygorii Strashko
On 11.02.25 14:32, Julien Grall wrote: On 11/02/2025 11:57, Orzel, Michal wrote: On 11/02/2025 12:18, Grygorii Strashko wrote: The dt_device_for_passthrough() is called many times during Xen initialization and Dom0 creation. On every call it traverses struct dt_device_node properties

Re: Coding Style Review and Automation

2025-02-12 Thread Grygorii Strashko
Hi On 12.02.25 11:14, Roger Pau Monné wrote: On Tue, Feb 11, 2025 at 02:33:08PM -0800, Stefano Stabellini wrote: Hi Oleksandr, This morning, we had a discussion among maintainers, and the suggested approach moving forward is as follows: - First, it would be helpful to see a sample of the prop

Re: [PATCH] device-tree: optimize dt_device_for_passthrough()

2025-02-12 Thread Grygorii Strashko
On 12.02.25 11:04, Julien Grall wrote: Hi, On 11/02/2025 15:14, Grygorii Strashko wrote: On 11.02.25 14:32, Julien Grall wrote: On 11/02/2025 11:57, Orzel, Michal wrote: On 11/02/2025 12:18, Grygorii Strashko wrote: The dt_device_for_passthrough() is called many times during Xen

[PATCH] device-tree: optimize size of struct dt_device_node

2025-02-12 Thread Grygorii Strashko
last cacheline: 4 bytes */ Signed-off-by: Michal Orzel Signed-off-by: Grygorii Strashko --- This patch follows discussion in [1] [1] https://patchwork.kernel.org/comment/26239672/ xen/include/xen/device_tree.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/

Re: [PATCH v2 3/8] xen/arm: Add SCMI over SMC calls handling layer

2024-12-10 Thread Grygorii Strashko
On 09.12.24 19:37, Andrei Cherechesu wrote: Hi Julien, Grygorii, On 11/11/2024 12:33, Julien Grall wrote: Hi, On 01/11/2024 15:22, Grygorii Strashko wrote: Hi I'd be apprcieated if could consider my comments below. On 30.09.24 14:47, Andrei Cherechesu (OSS) wrote: From: A

Re: [RFC PATCH] arm: dom0: allow static memory configuration

2025-02-13 Thread Grygorii Strashko
Hi Stefano, On 13.02.25 00:11, Stefano Stabellini wrote: On Wed, 12 Feb 2025, Grygorii Strashko wrote: The Arm Xen allocates memory to place Dom0 following the logic described in allocate_memory_11() function which is a bit complicated with major requirement to place Dom0 within the first

[RFC PATCH] arm: dom0: allow static memory configuration

2025-02-12 Thread Grygorii Strashko
ty to place Dom0 at fixed physical base address, by checking if "chosen" node contains property "xen,static-mem" and placs Dom0 exactly at the specified memory chunk. The implementation follows the same approach as for the static, direct-mapped guest domain in case of dom0less boot.

Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-14 Thread Grygorii Strashko
On 14.02.25 15:15, Julien Grall wrote: Hi, On 14/02/2025 12:55, Grygorii Strashko wrote: Now the following code in map_range_to_domain() res = iomem_permit_access(d, paddr_to_pfn(addr), paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); and res = rangeset_add_range(mr_data

[PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-14 Thread Grygorii Strashko
ill configure e6140 e6142 nr=3 instead. Note. paddr_to_pfn_aligned() has PAGE_ALIGN() inside. Fix it, by using paddr_to_pfn(addr + len - 1) in both places to get correct end address of the iomem_range. Signed-off-by: Grygorii Strashko --- Hi All, I have a question - the paddr_to_pfn_aligned() is

[PATCH] xen/iocap.h: add documentation

2025-02-24 Thread Grygorii Strashko
Change rangeset parameters to "start, last" as proposed in [1], and add documentation for public interface. No functional changes. [1] https://patchwork.kernel.org/comment/26251962/ Signed-off-by: Grygorii Strashko --- xen/include/xen/iocap.h | 134 +

[PATCH v2 1/2] xen/arm: fix iomem permissions cfg in map_range_to_domain()

2025-02-18 Thread Grygorii Strashko
the domain iomem_caps rangeset, but will add [e6140:e6142] (num_pages=3) instead. To fix it, drop PAGE_ALIGN() from the iomem range end address calculation formula. Fixes: 33233c2758345 ("arch/arm: domain build: let dom0 access I/O memory of mapped devices") Signed-off-by: Grygori

[PATCH v2 2/2] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-18 Thread Grygorii Strashko
struct map_range_data to add rangeset.") Signed-off-by: Grygorii Strashko --- xen/arch/arm/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/device.c b/xen/arch/arm/device.c index 97e613e06afa..5e1c1cc326ac 100644 --- a/xen/arch/arm/device.c +++ b/xen/arch/a

[PATCH v2 0/2] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-18 Thread Grygorii Strashko
-c, e6020, ... Changes in v2: - split on two patches - add "fixes" tags - rewording of commit messages v1: https://patchew.org/Xen/20250214125505.2862809-1-grygorii._5fstras...@epam.com/ Grygorii Strashko (2): xen/arm: fix iomem permissions cfg in map_rang

Re: [PATCH] xen/arm: fix iomem_ranges cfg in map_range_to_domain()

2025-02-18 Thread Grygorii Strashko
Hi Andrew, Julien, On 14.02.25 16:25, Andrew Cooper wrote: On 14/02/2025 2:10 pm, Grygorii Strashko wrote: For example, requested range:    00e614 - 00e6141004 should set e6140:e6141 nr=2, but will configure e6140 e6142 nr=3 instead. I am not sure what 'nr' is referri

Re: [PATCH 0/2] code style exercise: Drivers folder samples

2025-02-18 Thread Grygorii Strashko
On 16.02.25 12:21, Oleksandr Andrushchenko wrote: Hello, everybody! As agreed before [1] I am sending a series to show two samples of the formatting done with clang-format. The clang-format configuration can be found at [2]. It already has some notes on previous discussions when Luca presente

[RFC PATCH v3 4/7] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-03-11 Thread Grygorii Strashko
ess is not fully supported yet - move memcpy_fro/tomio in separate patch [1] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/firmware/arm,scmi.yaml [2] https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/de

Re: [PATCH v2 1/7] xen/arm: allow PCI host bridge to have private data

2025-03-11 Thread Grygorii Strashko
On 11.03.25 12:24, Mykyta Poturai wrote: From: Oleksandr Andrushchenko Some of the PCI host bridges require private data. Create a generic approach for that, so such bridges may request the private data to be allocated during initialization. Signed-off-by: Oleksandr Andrushchenko Signed-of

[RFC PATCH v3 2/7] xen/arm: scmi-smc: update to be used under sci subsystem

2025-03-11 Thread Grygorii Strashko
DT device; - convert to SCI Xen interface. Signed-off-by: Grygorii Strashko --- xen/arch/arm/firmware/Kconfig| 13 ++- xen/arch/arm/firmware/scmi-smc.c | 93 +++- xen/arch/arm/include/asm/firmware/scmi-smc.h | 41 - xen/arch/

[RFC PATCH v3 0/7] xen/arm: scmi: introduce SCI SCMI SMC multi-agent support

2025-03-11 Thread Grygorii Strashko
dev/ Renesas v4h: https://github.com/GrygiriiS/arm-trusted-firmware/commits/rcar_gen4_v2.7_v4x-scmi_upd/ base-commit: c3f5d1bb40b5 ("automation/cirrus-ci: introduce FreeBSD randconfig builds") Grygorii Strashko (2): xen/arm: scmi-smc: update to be used under sci subsystem xen/arm:

[RFC PATCH v3 5/7] libs: libxenhypfs - handle blob properties

2025-03-11 Thread Grygorii Strashko
From: Oleksii Moisieiev libxenhypfs will return blob properties as is. This output can be used to retrieve information from the hypfs. Caller is responsible for parsing property value. Signed-off-by: Oleksii Moisieiev Reviewed-by: Volodymyr Babchuk --- tools/libs/hypfs/core.c | 2 -- 1 file c

Re: [PATCH v2 1/2] xen/arm: fix iomem permissions cfg in map_range_to_domain()

2025-03-11 Thread Grygorii Strashko
Hi On 19.02.25 13:25, Julien Grall wrote: Hi Grygorii, On 18/02/2025 11:22, Grygorii Strashko wrote: Now the following code in map_range_to_domain() res = iomem_permit_access(d, paddr_to_pfn(addr), paddr_to_pfn(PAGE_ALIGN(addr + len - 1))); calculates the iomem

[RFC PATCH v3 1/7] xen/arm: add generic SCI subsystem

2025-03-11 Thread Grygorii Strashko
() - sci_relinquish_resources() called from domain_relinquish_resources() - sci_domain_destroy() called from arch_domain_destroy() - sci_handle_call() called from vsmccc_handle_call() - sci_dt_handle_node() sci_dt_finalize() called from handle_node() (Dom0 DT) Signed-off-by: Oleksii Moisieiev Signed-off-by: Grygorii

[RFC PATCH v3 6/7] xen/arm: Export host device-tree to hypfs

2025-03-11 Thread Grygorii Strashko
From: Oleksii Moisieiev If enabled, host device-tree will be exported to hypfs and can be accessed through /devicetree path. Exported device-tree has the same format, as the device-tree exported to the sysfs by the Linux kernel. This is useful when XEN toolstack needs an access to the host device

Re: [PATCH] xen/iocap.h: add documentation

2025-03-11 Thread Grygorii Strashko
Hi Jan, On 11.03.25 17:35, Jan Beulich wrote: On 11.03.2025 15:53, Grygorii Strashko wrote: On 05.03.25 12:37, Jan Beulich wrote: On 24.02.2025 12:38, Grygorii Strashko wrote: Change rangeset parameters to "start, last" as proposed in [1], and add documentation for public inte

Re: [PATCH] xen/iocap.h: add documentation

2025-03-11 Thread Grygorii Strashko
Hi Jan, On 05.03.25 12:37, Jan Beulich wrote: On 24.02.2025 12:38, Grygorii Strashko wrote: Change rangeset parameters to "start, last" as proposed in [1], and add documentation for public interface. No functional changes. [1] https://patchwork.kernel.org/comment/26251962/ Sig

[RFC PATCH v3 7/7] xen/arm: scmi: generate scmi dt node for DomUs

2025-03-11 Thread Grygorii Strashko
e taken from partial DT. - maps the SCMI shmem into DomU GUEST_SCI_SHMEM_BASE address. Signed-off-by: Oleksii Moisieiev Signed-off-by: Grygorii Strashko --- tools/include/xenctrl.h | 3 + tools/libs/ctrl/xc_domain.c | 18 ++ tools/libs/light/libxl_arm.c

Re: [PATCH v2 6/7] xen/arm: rcar4: add simple optimization to avoid ATU reprogramming

2025-03-12 Thread Grygorii Strashko
On 11.03.25 12:24, Mykyta Poturai wrote: From: Volodymyr Babchuk There are high chances that there will be a number of a consecutive accesses to configuration space of one device. To speed things up, we can program ATU only during first access. This is mostly beneficial taking into account