Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-19 Thread Gerd Hoffmann
Hi, > Adding a new command requires new feature flag (and maybe it should be in > the <0x1000 range instead) > > But I am not sure we need a new message at the virtio-gpu level. Gerd, wdyt? > > Maybe it's not a good place to reset all GPU resources during QEMU reset() > after all, if it's call

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-20 Thread Gerd Hoffmann
Hi, > > The guest driver should be able to restore resources after resume. > > Thank you for your suggestion! > As far as I know, resources are created on host side and guest has no backup, > if resources are destroyed, guest can't restore them. > Or do you mean guest driver need to send comma

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-21 Thread Gerd Hoffmann
On Tue, Jun 20, 2023 at 01:26:15PM +0100, Robert Beckett wrote: > > On 20/06/2023 10:41, Gerd Hoffmann wrote: > >Hi, > > > > > > The guest driver should be able to restore resources after resume. > > > Thank you for your suggestion! > > > As f

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-21 Thread Gerd Hoffmann
Hi, > As virtio drivers are by design paravirt drivers ,I think it is reasonable > to accept some knowledge with and cooperation with the host to manage > suspend/resume. Fair point. In any case this needs a feature flag, so guest and host can negotiate whenever this is supported or not. virt

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
> --- a/include/ui/console.h > +++ b/include/ui/console.h > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > int yoff; > uint32_t width; > uint32_t height; > +uint32_t refresh_rate; > } QemuUIInfo; > > /* cursor data format is 32bit RGBA */ > @@ -426,7 +427,6 @@ typ

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
On Thu, Jun 09, 2022 at 08:45:41PM +0900, Akihiko Odaki wrote: > On 2022/06/09 19:28, Gerd Hoffmann wrote: > > > --- a/include/ui/console.h > > > +++ b/include/ui/console.h > > > @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { > > > int

Re: [PATCH v3 2/3] ui: Deliver refresh rate via QemuUIInfo

2022-06-09 Thread Gerd Hoffmann
Hi, > > > > (1) add refresh_rate > > > > (2) update users one by one > > > > (3) finally drop update_interval when no user is left. > > > > > > > > thanks, > > > > Gerd > > > > > > > > > > I think 1 and 3 should have to be done once since refresh_rate and > > > update_interval would inter

[PULL 01/17] ui/gtk-gl-area: implement GL context destruction

2022-06-10 Thread Gerd Hoffmann
From: Volker Rümelin The counterpart function for gd_gl_area_create_context() is currently empty. Implement the gd_gl_area_destroy_context() function to avoid GL context leaks. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-1-vr_q...@t-online.de> Signed-off-by: Gerd Ho

[PULL 03/17] ui/cocoa: Fix poweroff request code

2022-06-10 Thread Gerd Hoffmann
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220529082508.89097-1-akihiko.od...@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m

[PULL 00/17] Kraxel 20220610 patches

2022-06-10 Thread Gerd Hoffmann
The following changes since commit 9cc1bf1ebca550f8d90f967ccd2b6d2e00e81387: Merge tag 'pull-xen-20220609' of https://xenbits.xen.org/git-http/people/aperard/qemu-dm into staging (2022-06-09 08:25:17 -0700) are available in the Git repository at: git://git.kraxel.org/qemu tags/kraxel-20220

[PULL 04/17] hw/audio/cs4231a: Const'ify global tables

2022-06-10 Thread Gerd Hoffmann
From: Bernhard Beschow The tables contain spcifically crafted constants for algorithms, so make them immutable. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220520180109.8224-3-shen...@gmail.com> Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231a

[PULL 02/17] ui/gtk-gl-area: create the requested GL context version

2022-06-10 Thread Gerd Hoffmann
;t have the latest OpenGL extensions fully implemented. An example for this is the Intel i965 driver on a Haswell processor. Signed-off-by: Volker Rümelin Message-Id: <20220605085131.7711-2-vr_q...@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 31 +++

[PULL 06/17] hw/usb/canokey: Add trace events

2022-06-10 Thread Gerd Hoffmann
From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c| 13 + hw/usb/trace-events | 16 2 files changed, 29 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canok

Re: [PATCH] virtio-gpu: Respect graphics update interval for EDID

2021-03-03 Thread Gerd Hoffmann
On Fri, Feb 26, 2021 at 01:47:38PM +0900, Akihiko Odaki wrote: > 2021年2月25日(木) 20:46 Gerd Hoffmann : > > > > Hi, > > > > > > Because of the wasted frames I'd like this to be an option you can > > > > enable when needed. For the majorit

Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID

2021-03-10 Thread Gerd Hoffmann
Hi, > -static void xenfb_update_interval(void *opaque, uint64_t interval) > +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) > -.update_interval = xenfb_update_interval, > +.ui_info = xenfb_ui_info, Hmm, I suspect xenfb really wants the actual refresh rate,

Re: [PATCH 0/9] hw/sysbus/platform-bus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE

2025-01-28 Thread Gerd Hoffmann
On Sat, Jan 25, 2025 at 07:13:34PM +0100, Philippe Mathieu-Daudé wrote: > Some SysBus devices can optionally be dynamically plugged onto > the sysbus-platform-bus (then virtual guests are aware of > mmio mapping and IRQs via device tree / ACPI rules). Do we have some sane way to have user-pluggabl

<    1   2