Re: [Xen-devel] [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 > gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() f

Re: [Xen-devel] [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 > gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() f

Re: [Xen-devel] [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()"

2019-10-22 Thread Esteban Bosse
q irq2); > > -/* Returns a new IRQ set which connects 1:1 to another IRQ set, > which > - * may be set later. > - */ > -qemu_irq *qemu_irq_proxy(qemu_irq **target, int n); > - > /* For internal use in qtest. Similar to qemu_irq_split, bu

Re: [Xen-devel] [PATCH v2 05/20] piix4: Rename PIIX4 object to piix4-isa

2019-10-22 Thread Esteban Bosse
hw/isa/isa.h > index 018ada4f6f..79f703fd6c 100644 > --- a/include/hw/isa/isa.h > +++ b/include/hw/isa/isa.h > @@ -147,4 +147,6 @@ static inline ISABus > *isa_bus_from_device(ISADevice *d) > return ISA_BUS(qdev_get_parent_bus(DEVICE(d))); > } > > +#define TYPE_PIIX4_PCI_

Re: [Xen-devel] [PATCH v2 06/20] piix4: Add a i8257 DMA Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
;hw/boards.h" > @@ -1430,7 +1429,6 @@ void mips_malta_init(MachineState *machine) > smbus = piix4_pm_init(pci_bus, piix4_devfn + 3, 0x1100, >isa_get_irq(NULL, 9), NULL, 0, NULL); > pit = i8254_pit_init(isa_bus, 0x40, 0, NULL); > -i8257_dma_init(isa_bus, 0); > mc146818_rtc_init(isa_bus, 2000, NULL); > > /* generate SPD EEPROM data */ Reviewed-by: Esteban Bosse ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create()

2019-10-22 Thread Esteban Bosse
> -PIIX_NUM_PIRQS); > -pci_bus_set_route_irq_fn(b, piix3_route_intx_pin_to_irq); > - } > +piix3 = piix3_create(b, isa_bus); > piix3->pic = pic; > -*isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > - > *piix3_devfn = piix3->dev.devfn; > > ram_size = ram_size / 8 / 1024 / 1024; Reviewed-by: Esteban Bosse ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues

2019-10-22 Thread Esteban Bosse
t; +/* > + * Return the global irq number corresponding to a given device irq > + * pin. We could also use the bus number to have a more precise > mapping. > + */ > static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > { > int slot_addend; Reviewed-by: Este

Re: [Xen-devel] [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-23 Thread Esteban Bosse
El mar, 22-10-2019 a las 10:42 +0100, Peter Maydell escribió: > On Tue, 22 Oct 2019 at 09:52, Esteban Bosse > wrote: > > El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé > > escribió: > > > +static void piix4_request_i8259_irq(void *opaqu

Re: [Xen-devel] [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-23 Thread Esteban Bosse
El mar, 22-10-2019 a las 11:35 +0200, Philippe Mathieu-Daudé escribió: > On 10/22/19 10:44 AM, Esteban Bosse wrote: > > El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé > > escribió: > > > From: Hervé Poussineau > > > > > > Add ISA irqs as p