On 9/23/19 3:05 PM, Eric Blake wrote:
> Does running this Coccinelle script 2 times in a row add a second
> ERRP_FUNCTION_BEGIN() line? We want it to be idempotent (no changes on
> a second run). (Admittedly, I did not actually test that yet). Also, I
> don't know if this
ype_uint64(v, name, &value, errp);
> +if (*errp) {
> } else if (value > max) {
> error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
> name ? name : "null", type);
Results in an empty if which looks funny. This one could be a manual
ration, so we're already on fuzzy ground).
We could make this macro expansion one line shorter and still be
correct, but I'm not going to insist (we'll see what consensus is,
and/or what Markus says).
> +
> +
> /*
> * Special error destination to abort on error.
&g
rrp);
> +|
> +-error_propagate(errp, local_err);
> +)
> + ...>
> + }
> +
> +@@
> +identifier rule1.fn;
> +identifier rule1.local_err;
> +@@
> +
> + fn(...)
> + {
> + <...
> +(
> +-&local_err
> ++errp
> +|
> +-local_err
h | 8
> ui/vnc.h | 2 +-
> monitor/hmp-cmds.c| 8
> ui/vnc.c | 10 +-
> util/error.c | 2 +-
> 6 files changed, 16 insertions(+), 16 deletions(-)
This is worthwhile, regardless of the fate of the rest of the series.
e the (fixed) 2-3 (to rely on the new
error_free_errp), or you could open-code the assignment of errp=NULL to
take this on its own, regardless of the hfate of the rest of the series.
Reviewed-by: Eric Blake
> diff --git a/hw/core/loader-fit.c b/hw/core/loader-fit.c
> index 953b16bc82..fe5bcc
b/util/error.c
> @@ -273,9 +273,9 @@ void error_free(Error *err)
>
> void error_free_or_abort(Error **errp)
> {
> -assert(errp && *errp);
> -error_free(*errp);
> -*errp = NULL;
> +assert(errp_in && *errp_in);
> +error_free(*errp_in);
> +
p;&
qemus_strtoul(...)) {
> error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
> "ipv6-prefixlen", "a number");
> goto out;
>
Either way,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engine
.h | 61 -
> target/ppc/kvm_ppc.h | 3 +
> target/s390x/cpu_models.h | 3 +
> ui/vnc.h | 2 +-
> vl.c | 13 +-
> scripts/co
rrp.cocci | 82 +++
>>> 319 files changed, 2729 insertions(+), 4245 deletions(-)
>>> create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci
>>
>> The diffstat is huge, but promising.
We also learned in reviews of 7/9 that the diffstat here is mislead
On 1/24/19 2:45 AM, Markus Armbruster wrote:
>> Signed-off-by: Michael Tokarev
>> Revieved-by: Michael Tokarev
>
> Typo in Reviewed-by.
Should we tighten checkpatch.pl to flag suspicious-looking 'xxx-by:'
tags, to catch instances of typos?
--
Eric Blake, Princip
On 1/24/19 12:29 PM, Peter Maydell wrote:
> On Thu, 24 Jan 2019 at 17:40, Eric Blake wrote:
>>
>> On 1/24/19 2:45 AM, Markus Armbruster wrote:
>>
>>>> Signed-off-by: Michael Tokarev
>>>> Revieved-by: Michael Tokarev
>>>
>>> Typ
gence to check callers I think its a win to be consistent
> with libc APIs in size_t usage for read/write.
And hopefully this exercise of making the conversion serves as a good
audit to help us gain confidence in our code and/or fix bugs it uncovers.
--
Eric Blake, Principal Software E
by: Markus Armbruster
> ---
> hw/block/xen-block.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake
Safe for 4.0 softfreeze in my opinion, but also harmless if it slips to 4.1.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-3
less rebasing needed if we can apply
the entire cleanup right as 5.0 development opens in a couple of weeks.
If no objections during a week, I'll start that plan, hope someone will support
it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virt
a
propagations
(in fact, error_propagate is called, but returns immediately on first if
(!local_err))
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
__
On 10/11/19 12:12 PM, Eric Blake wrote:
On 10/11/19 11:04 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
+@@
+identifier rule1.fn;
+identifier rule1.local_err;
+@@
+
+ fn(...)
+ {
+ <...
+(
+- error_free(local_err);
+- local_err = N
clients will reappear later)?
+@@
+identifier rule1.fn;
+identifier rule1.local_err;
+@@
+
+ fn(...)
+ {
+ <...
+(
+-&local_err
++errp
+|
+-local_err
++*errp
+)
+ ...>
+ }
+
+@@
+symbol errp;
+@@
+
+- *errp != NULL
++ *errp
Seems to make sense.
--
Eric Blak
e commit-per-subsystem.py, the overall series
appears to be a nice reduction in lines of code.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
___
Xen-devel mailing list
Xen-de
.h), so we'll just have to see what is possible.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproje
altogether
for &error_abort).
You are correct that any exit() will now happen during cleanup, but that
is an undetectable change (there is no stack trace present for
&error_fatal, so calling error_propagate at a later point in time does
not affect the observable end behavior).
--
Eric Bl
several existing files:
$ git grep -il 'all rights reserved' |wc
138 1383557
but we should be striving to clean those up, not adding to the mess.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
_
| 2 +-
NBD part:
Acked-by: Eric Blake
but I have patches that remove the line in question entirely as part of
adding 'qemu-nbd --list'.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.or
ary because syntax errors are not like set -e errors:
> they cause the shell process to exit.
See above - a well-quoted eval is sufficient to avoid a subshell.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signatu
s to many other useful extensions). It's rather telling that 'git
grep strerror_r' currently comes up empty.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital sig
On 04/24/2018 10:40 AM, Eric Blake wrote:
> On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote:
>
>>> - static void vreport(report_type type, const char *fmt, va_list ap)
>>> + static void vreport(report_type type, int errnoval, const char *fmt,
>>> va_list ap
positives from
checkpatch (although documenting it in the commit message and/or cover
letter never hurts, when you are intentionally ignoring a false positive).
But, as there has also been a recent patch to teach checkpatch about
glib types [1], your patch makes sense (any merge conflict between
_handle doesn't follow our usual
conventions for a type name. See commit 5ac067a if you want to add it
to the list of whitelisted exception type names, to silence messages
like this.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qe
A previous patch (5ac067a24a8) added xendevicemodel_handle to the list
of types. This patch changes that to xen\w+_handle such that it will
match all Xen stable API handles of the forms detailed above.
Nice use of a regex.
Signed-off-by: Paul Durrant
---
Cc: Eric Blake
Cc: Paolo Bonzini
Cc
ss any of these would work.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
other
alternatives that solve the real issue of stale generated files breaking
incremental builds.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
___
Xen-devel mailing list
Xen-de
not 100% sold on
it (as you say, it's now slightly more work for writers), but I'm not
coming up with any solid reasons why it should not be applied (at least,
for 2.13 - doing it during freeze for 2.12 is a bit harder to justify).
--
Eric Blake, Principal Software Engineer
Red
because it
thinks you are overriding its defaults?
I know that getting automake to add a dependency is not always trivial,
but that it should be possible (my strengths lie more on autoconf than
on automake).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
the value: use of
64-bit math is explicit based on the type of what else is being
multiplied by the macro. Potential downside: 32*32 assigned to a 64-bit
result may be botched (but hopefully Coverity will flag it).
So there's tradeoffs either way, and you at least need to document in
signed vs unsigned changes
than I am about width. But if we're going to force a 64-bit type, use
(int64_t)1 not 1LL. That way the type will match the existing PRId64 printf
markup.
Or spell it UINT64_C(1) if you don't want a cast.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
}
#endif
-chr = qemu_chr_new_noreplay("gdb", device);
+/*
+ * FIXME: it's a bit weird to allow using a mux chardev here
+ * and setup implicitely a monitor. We may want to break this.
s/setup implicitely/implicitly set up/
--
Eric Blake, Principal Software
arm...@redhat.com>
Reviewed-by: Eric Blake
Reviewed-by: Marc-André Lureau
Reviewed-by: Michael Roth
Signed-off-by: Eric Blake
---
docs/xen-save-devices-state.txt | 3 +--
qmp.c | 14 +++---
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/docs/xe
644
GIT binary patch
delta 102
zcmeBpue$8LYC{WS3sVbo3(FSPMGsgDQ*%q>w*wh6LJ;=!eV!
e4L)`&8@K>*RVYvZ
delta 66
zcmZ4XUbW-BYC{WS3sVbo3(FSPMGv+wf50juH2uUU)}nU%&#XYq2E^>!?LTwO&)NPs
Up0kK)dsGtVajxxZxttAL0Np
Does the result of sphinx still look good, as mentioned in this comment?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
(+)
Reviewed-by: Eric Blake
diff --git a/scripts/git.orderfile b/scripts/git.orderfile
index 1f747b583a..7cf22e0bf5 100644
--- a/scripts/git.orderfile
+++ b/scripts/git.orderfile
@@ -22,6 +22,9 @@ Makefile*
qapi/*.json
qga/*.json
+# semantic patches
+*.cocci
+
# headers
*.h
--
Eric
s->dma_as, entry_addr + 2,
-(uint8_t *)(&dscr->length), 2);
+dma_memory_read(s->dma_as, entry_addr, (&dscr->attr), 1);
+dma_memory_read(s->dma_as, entry_addr + 2, (&dscr->length), 2);
The () around &dscr->length are now pointless.
--
Eric Bla
the coccinelle script across multiple patches is actually
quite reviewable, and still easy to backport. Consider this series by
Philippe:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05554.html
which makes multiple additions to scripts/coccinelle/exec_rw_const.cocci
over the course of
mpiler, so declaration after
statement is supported by our compiler, even if our coding style
currently avoids it where possible), so as long as we support
statements, we might as well go with a legible statement instead of
insisting on the compact ?: form.
--
Eric Blake, Principa
where the error happened, not to error_propagate.
+ */
+#define ERRP_AUTO_PROPAGATE() \
+g_auto(ErrorPropagator) _auto_errp_prop = {.errp = errp}; \
+do { \
+if (!errp || errp == &error_fatal) { \
+errp = &_auto_errp_prop.local_err; \
+} \
+} while (0)
+
/*
*
ed by using this script are
reasonable, then this script was good enough.
+// Always use the same patter for checking error
pattern
+@@
+identifier rule1.fn;
+symbol errp;
+@@
+
+ fn(...)
+ {
+ <...
+-*errp != NULL
++*errp
+ ...>
+ }
--
Eric Blake, Principal Software E
errp
, ...)
{
...
}
Ultimately, the proof is in the pudding - if we are happy with the
conversion and the warnings produced by this script, and the amount of
manual touchup to address those warnings, then I'm happy to accept the
scr
errp: call corresponding Error *err cleaning
+ * function an set pointer to NULL
s/ an/, then/
Missing a '.' at the end of the sentence.
Otherwise,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qe
rop.local_err : errp)
+
/*
* Special error destination to abort on error.
* See error_setg() and error_propagate() for details.
The macro itself is fine, my comments are solely on the commit message
and comments. Depending on how much cleanup Markus is willing to do
rather than require a respi
not inherit from the first rule.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
blk: Acquire context while switching them on
> dataplane start" with "block: Honor blk_set_aio_context() context
> requirements" (Kevin Wolf)
> - Add "block: Avoid processing BDS twice in
> bdrv_set_aio_context_ignore()"
> - Add "block: Close block expo
blk_set_aio_context() makes use of this function, this rule also
applies to it.
Fix all occurrences where this rule wasn't honored.
Suggested-by: Kevin Wolf
Signed-off-by: Sergio Lopez
Message-Id: <20201214170519.223781-2-...@redhat.com>
Reviewed-by: Kevin Wolf
Signed-off-by: Eric Blake
--
Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
On 5/27/20 7:45 AM, Roman Kagan wrote:
Make it easier (more visible) to maintain the limits on the blocksize
properties in sync with the respective description, by using macros both
in the code and in the description.
Signed-off-by: Roman Kagan
---
Reviewed-by: Eric Blake
--
Eric Blake
Although 4 GiB is not quite the same as 4294967295, the exact byte value
next to the approximate size is not too bad. The mechanical fallout
from the change from int to size is fine to me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
tches the qcow2 cluster size limit.
Signed-off-by: Roman Kagan
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
split too far, so the real
tradeoff is whether it will cost you more time to split than what you
will save the next reviewer (including the maintainer that will merge
your patches, depending on whether the maintainer also reviews it or
just trusts my review), if you decide to go with a v7.
commit message is tweaked,
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
: Roman Kagan
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
e, I could envision a platform where it prints something funky like:
"exceed (2 * (32768) + 1) logical", based on however complex the
definition of UINT16_MAX is. You're better off printing this one with
%d than with stringify().
--
Eric Blake, Principal Software Engineer
-off-by: Roman Kagan
---
v6 -> v7:
- split out into separate patch [Eric]
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
t commit "error: Document Error
API usage rules", and edited for clarity. Put ERRP_AUTO_PROPAGATE()
before its helpers, and touch up style.
01-08: Commit messages tweaked
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
(solving 1) or which use
local_err+error_propagate to check errors, switching those
functions to use *errp instead (solving 2 and 3).
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Paul Durrant
Reviewed-by: Greg Kurz
Reviewed-by: Eric Blake
[Comments merged properly with recent com
umber of places we have already
improved after applying this script as-is and with Markus' cleanups in
place.
While I won't call myself a Coccinelle expert, it at least looks sane
enough that I'm comfortable if you add:
Reviewed-by: Eric Blake
--
Eric Blake, Principal Softwar
--no-show-diff --max-width 80
Reported-by: Kevin Wolf
Reported-by: Greg Kurz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Markus Armbruster
[Commit message tweaked]
Signed-off-by: Markus Armbruster
---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, In
-GIOChannel *c = g_malloc0(sizeof(GIOChannel));
> +GIOChannel *c = g_new0(GIOChannel, 1);
> __coverity_escape__(fd);
> return c;
> }
Our model has a definition of g_malloc0(), but I'm not sure whether
Coverity picks up the macro g_new0() in the same manner.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
mention 6.2, to
correctly match the release that will first have it. Such a followup
is safe during freeze, since it is doc-only.
> +#
> +##
> +{ 'struct': 'DirtyRateVcpu',
> + 'data': { 'id': 'int', 'dirty-rate': 'int64' } }
> +
> ##
> # @DirtyRateStatus:
> #
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
le:
> +
> +.. parsed-literal::
> +
> + |qemu_system| --accel kvm,xen-version=0x40011,kernel-irqchip=split \\
> + -chardev stdio,id=char0 -device xen-console,chardev=char0 \\
> + -display none -m 1G -kernel xen -initrd bzImage \\
> + -append "pv-shi
> The last time the value of buffer_alignment/guest_block_size was
> actually used was before commit 339064d50639 ("block: Don't use guest
> sector size for qemu_blockalign()").
>
> This value has not been used since 2013. Get rid of it.
>
> Cc: Xie Yongji
/virtio-scsi.h | 3 +-
> hw/scsi/virtio-scsi.c | 62 ++---
> 2 files changed, 43 insertions(+), 22 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
t; 1 file changed, 1 insertion(+), 66 deletions(-)
The rest of this series should not hold up 8.2.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
{
> -qemu_rec_mutex_unlock(&ctx->lock);
> + /* TODO remove this function */
> }
>
> QEMU_DEFINE_STATIC_CO_TLS(AioContext *, my_aiocontext)
> --
> 2.42.0
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
lock_ctx() becomes meaningless and they can be collapsed
> into one function.
>
> Signed-off-by: Stefan Hajnoczi
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
ails in CI and otherwise:
> - * don't run unless user opts in via environment variable.
> - */
> - if (getenv("QEMU_TEST_FLAKY_TESTS")) {
> -g_test_add_func("/blockjob/complete_in_standby",
> test_complete_in_standby);
> -}
Looks like you ripped out this entire test, because it is no longer
viable. I might have mentioned it in the commit message, or squashed
the removal of this test into the earlier 02/12 patch.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
hw/scsi/scsi-disk.c | 28
> hw/scsi/virtio-scsi.c | 18 --
> 4 files changed, 4 insertions(+), 58 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
> ---
> include/block/aio-wait.h | 16
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
hat allow the compiler to
> check whether the graph lock is being used correctly.
>
> And me, well, I'm just here to add some pizzazz to the QEMU multi-queue
> block layer :). Thank you to everyone who helped with this effort,
> including Eric Blake, code reviewer extraordinaire, and
-
> 1 file changed, 15 insertions(+), 30 deletions(-)
>
> diff --git a/docs/devel/multiple-iothreads.txt
> b/docs/devel/multiple-iothreads.txt
> index a3e949f6b3..4865196bde 100644
> --- a/docs/devel/multiple-iothreads.txt
Reviewed-by: Eric Blake
--
Eric Blake,
e the
> lock is unnecessary.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/scsi/scsi-disk.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
On Wed, Nov 29, 2023 at 02:55:52PM -0500, Stefan Hajnoczi wrote:
> The AioContext lock no longer exists.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> include/qemu/job.h | 20
> 1 file changed, 20 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blak
sion that
could lead to a bug; so I'm okay with your action there.
>
> Signed-off-by: Stefan Hajnoczi
> ---
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
SecurityPolicy:
> +#
> +# An enumeration of the actions taken when the security policy is tainted.
> +#
> +# @none: do nothing.
> +#
> +# @warn: display a warning.
> +#
> +# @strict: prohibit QEMU to start a VM.
s/to start/from starting/
> +#
> +# Since: 6.2
> +##
> +{ 'enum': 'SecurityPolicy',
> + 'data': [ 'none', 'warn', 'strict' ] }
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
//www.qemu.org/contribute/security-process/
> + */
> +bool secure_policy_supported;
> /*
> * Array of global properties that would be applied when specific
> * accelerator is chosen. It works like MachineClass.compat_props
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
if the driver is withing QEMU security policy boundary,
within
> + * %false otherwise. See:
> https://www.qemu.org/contribute/security-process/
> + */
> +bool (*bdrv_taints_security_policy)(BlockDriverState *bs);
>
> int coroutine_fn (*bdrv_co_create)(BlockdevCreateOption
it.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> block/io_uring.c | 6 ++
> block/linux-aio.c | 4
> hw/virtio/virtio.c | 11 ++-
> util/thread-pool.c | 5 +++++
> 4 files changed, 25 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
47 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
and breaking SHA
references is worse.
> Signed-off-by: Markus Armbruster
> ---
> migration/rdma.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
reachable")
> * have to open-code it. Sadly, Coverity is severely confused by the
> * constant variants, so we have to dumb things down there.
> */
> +#define PASTE(a, b) a##b
> +#define MIN_INTERNAL(a, b, l) \
> +({
you realize that you are passing in the
unique variable name(s) to be used as the temporary identifier(s),
rather than an integer that still needs to be glued, then separating
the task of generating name(s) (which is done once per name, instead
of repeated 3 times) makes sense to me. I also lik
, "name", qobject_ref(...))
>
> qdict_put() wraps its last argument in QOBJECT(), and the last
> argument here contains another QOBJECT().
>
> Use dark preprocessor sorcery to make the macros that give us this
> problem use different variable names on every call.
>
> Sign
;next); \
> +} while (0)
Please use QAPI_LIST_APPEND instead of re-coding it.
> +++ b/qapi/net.json
> @@ -714,3 +714,83 @@
> ##
> { 'event': 'FAILOVER_NEGOTIATED',
>'data': {'device-id': 'str'} }
> +
> +##
>
s of
> virtio_queue_aio_detach_host_notifier() so that the function can be
> called from any thread. This is in preparation for the next patch.
>
This mentions a next patch, but is 16/16 in the series. Am I missing
something?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
* @fn/@opaque pair has already been deferred, it will only be called once
> upon
> + * blk_io_unplug() so that accumulated calls are batched into a single call.
> + *
> + * The caller must ensure that @opaque is not be freed before @fn() is
> invoked.
s/be //
> + */
> +void b
t; block/nvme.c | 44
> 1 file changed, 12 insertions(+), 32 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
; block/blkio.c | 40 +---
> 1 file changed, 21 insertions(+), 19 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
0,14 +357,16 @@ static int luring_do_submit(int fd, LuringAIOCB
> *luringcb, LuringState *s,
Looks a bit like a stray hunk, but you are touching the function, so
it's okay.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
ue, it's also
fewer lines of code.
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
ock_int-common.h | 11 --
> block/io.c | 37
> 3 files changed, 51 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
96 matches
Mail list logo
