Re: [Xen-devel] [Qemu-devel] [qemu-s390x] [PATCH v7 33/42] exec: Replace device_endian with MemOp

2019-08-19 Thread Edgar E. Iglesias
On Mon, 19 Aug. 2019, 23:01 Richard Henderson, wrote: > On 8/19/19 11:29 AM, Paolo Bonzini wrote: > > On 19/08/19 20:28, Paolo Bonzini wrote: > >> On 16/08/19 12:12, Thomas Huth wrote: > >>> This patch is *huge*, more than 800kB. It keeps being stuck in the the > >>> filter of the qemu-s390x list

Re: [Xen-devel] [PATCH v2] xen/arm: Fix platform name to xilinx_zynqmp from xgene_storm

2018-03-18 Thread Edgar E. Iglesias
On Sun, Mar 18, 2018 at 02:50:26PM +0530, Amit Singh Tomar wrote: > Signed-off-by: Amit Singh Tomar Reviewed-by: Edgar E. Iglesias > --- > Changes since v1: > * Addressed Andre's comment. > --- > xen/arch/arm/platforms/xilinx-zynqmp.c | 2 +- > 1 file

Re: [Xen-devel] [RFC v2] xen/arm: Suspend to RAM Support in Xen for ARM

2018-03-26 Thread Edgar E. Iglesias
On Mon, Mar 26, 2018 at 09:51:40AM +, Peng Fan wrote: > Hi Mirela, > > Good to know that you are working suspend/resume support. Currently we are > also trying > to support this on i.MX8, just wonder do you have any open source available to > support suspend to ram? > > > + > > +Suspend to R

Re: [Xen-devel] [PATCH RFC 03/15] xen/arm: extend device tree based multiboot protocol

2018-07-03 Thread Edgar E. Iglesias
Hi, Sorry for the top post (I'm not managing todo in line reply with my phone). Yes, in the long run it there are some benefits if the format could be kept similar when possible. We could reuse some of the documentation and perhaps some of the code to parse. Allthough I'm guessing that most of the

Re: [Xen-devel] [PATCH RFC 00/15] dom0less step1: boot multiple domains from device tree

2018-06-14 Thread Edgar E. Iglesias
On Wed, Jun 13, 2018 at 03:15:09PM -0700, Stefano Stabellini wrote: > Hi all, > > This is first step toward "dom0less" as discussed in the various > certifications related threads and discussions. > > The goal of this series is to enable Xen to boot multiple domains in > parallel, in addition to

Re: [Xen-devel] [RFC v2] xen/arm: Suspend to RAM Support in Xen for ARM

2018-01-23 Thread Edgar E. Iglesias
On Tue, Jan 23, 2018 at 01:52:50PM +0200, Oleksandr Tyshchenko wrote: > Hi Mirela, > > Just some remarks regarding the scope of work: > > +In addition, the following have to be implemented: > +* Suspend/resume vCPU (triggered by vSYSTEM_SUSPEND call) > +* Suspend/resume Xen (triggered by vSYSTEM_

Re: [Xen-devel] [RFC v2] xen/arm: Suspend to RAM Support in Xen for ARM

2018-01-25 Thread Edgar E. Iglesias
On Wed, Jan 24, 2018 at 07:04:35PM +0100, Mirela Simonovic wrote: > Hi Oleksandr, Edgar, > > > Thanks, you're right. > > > On 01/23/2018 12:58 PM, Edgar E. Iglesias wrote: > >On Tue, Jan 23, 2018 at 01:52:50PM +0200, Oleksandr Tyshchenko wrote: > >

Re: [PULL v2 2/5] hw/xen: Expose handle_bufioreq in xen_register_ioreq

2024-10-08 Thread Edgar E. Iglesias
On Mon, Oct 07, 2024 at 04:42:49PM +0100, Peter Maydell wrote: > On Thu, 3 Oct 2024 at 19:57, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Expose handle_bufioreq in xen_register_ioreq(). > > This is to allow machines to

[PATCH v1 1/1] hw/xen: Avoid use of uninitialized bufioreq_evtchn

2024-10-07 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Avoid use of uninitialized bufioreq_evtchn. It should only be used if buffered IOREQs are enabled. Resolves: Coverity CID 1563383 Reported-by: Peter Maydell Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-hvm-common.c | 7 --- 1 file changed, 4 insert

[PATCH v1 0/1] hw/xen: Avoid Avoid use of uninitialized bufioreq_evtchn

2024-10-07 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This has a fix for Coverity CID 1563383 reported by Peter. Avoid use of uninitialized bufioreq_evtchn. It should only be used if buffered IOREQs are enabled. Cheers, Edgar Edgar E. Iglesias (1): hw/xen: Avoid use of uninitialized bufioreq_evtchn hw/x

[PULL v1 0/1] Xen Queue

2024-10-21 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit f1dd640896ee2b50cb34328f2568aad324702954: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-10-18 10:42:56 +0100) are available in the Git repository at: https://gitlab.com/edg

[PULL v1 1/1] hw/xen: Avoid use of uninitialized bufioreq_evtchn

2024-10-21 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Avoid use of uninitialized bufioreq_evtchn. It should only be used if buffered IOREQs are enabled. Resolves: Coverity CID 1563383 Reported-by: Peter Maydell Acked-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-hvm-common.c | 7

Re: [PULL v1 0/5] Xen Queue

2024-10-03 Thread Edgar E. Iglesias
On Thu, Oct 03, 2024 at 06:07:00PM +0100, Peter Maydell wrote: > On Thu, 3 Oct 2024 at 15:31, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: > >

[PULL v2 4/5] hw/xen: xenpvh: Add pci-intx-irq-base property

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Acked-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-pvh-common.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c index 76a9b2b945..218ac85

[PULL v2 2/5] hw/xen: Expose handle_bufioreq in xen_register_ioreq

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Expose handle_bufioreq in xen_register_ioreq(). This is to allow machines to enable or disable buffered ioreqs. No functional change since all callers still set it to HVM_IOREQSRV_BUFIOREQ_ATOMIC. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E

[PULL v2 0/5] Xen Queue

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2024-10-03 10:32:54 +0100) are available in the Git repository at:

[PULL v2 3/5] hw/xen: xenpvh: Disable buffered IOREQs for ARM

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a way to enable/disable buffered IOREQs for PVH machines and disable them for ARM. ARM does not support buffered IOREQ's nor the legacy way to map IOREQ info pages. See the following for more details: https://xenbits.xen.org/gitweb/?p=xen.git

[PULL v2 1/5] hw/xen: Remove deadcode

2024-10-03 Thread Edgar E. Iglesias
hem. Signed-off-by: Dr. David Alan Gilbert Acked-by: Anthony PERARD Reviewed-by: Thomas Huth Reviewed-by: Edgar E. Iglesias Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-legacy-backend.c | 18 -- hw/xen/xen_devconfig.c | 8 include/hw/xen/xe

[PULL v2 5/5] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable PCI support for the ARM Xen PVH machine. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/arm/xen-pvh.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c index 28af3910ea..

Re: [PATCH] hw/xen: Remove deadcode

2024-09-23 Thread Edgar E. Iglesias
"xen: remove the legacy 'xen_disk' backend") > > > > xen_config_dev_console is unused since 2018's > > 6d7c06c213 ("Remove broken Xen PV domain builder") > > > > Remove them. > > > > Signed-off-by: Dr. David Alan Gilbert > > Acked-by: Anthony PERARD > > Thanks, Reviewed-by: Edgar E. Iglesias Cheers, Edgar

[PATCH v2 1/4] hw/xen: Expose handle_bufioreq in xen_register_ioreq

2024-09-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Expose handle_bufioreq in xen_register_ioreq(). This is to allow machines to enable or disable buffered ioreqs. No functional change since all callers still set it to HVM_IOREQSRV_BUFIOREQ_ATOMIC. Signed-off-by: Edgar E. Iglesias --- hw/i386/xen

[PATCH v2 4/4] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-09-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable PCI support for the ARM Xen PVH machine. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/arm/xen-pvh.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c index 28af3910ea..

[PATCH v2 3/4] hw/xen: xenpvh: Add pci-intx-irq-base property

2024-09-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Acked-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-pvh-common.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c index 76a9b2b945..218ac85

[PATCH v2 2/4] hw/xen: xenpvh: Disable buffered IOREQs for ARM

2024-09-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a way to enable/disable buffered IOREQs for PVH machines and disable them for ARM. ARM does not support buffered IOREQ's nor the legacy way to map IOREQ info pages. See the following for more details: https://xenbits.xen.org/gitweb/?p=xen.git

[PATCH v2 0/4] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-09-23 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable PCI on the ARM PVH machine. First we add a way to control the use of buffered IOREQ's since those are not supported on Xen/ARM. Finally we enable the PCI support. I've published some instructions on how to try this including the work in prog

Re: [PATCH v1 1/6] xen/arm: Decrease size of the 2nd ram bank

2024-09-24 Thread Edgar E. Iglesias
On Tue, Sep 24, 2024 at 04:34:16PM -0700, Stefano Stabellini wrote: > On Tue, 24 Sep 2024, Julien Grall wrote: > > Hi Edgar, > > > > On 24/09/2024 17:23, Edgar E. Iglesias wrote: > > > From: "Edgar E. Iglesias" > > > > > > The

[PATCH v1 2/6] xen/arm: Reserve resources for virtio-pci

2024-09-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Reserve memory ranges and interrupt lines for an externally emulated PCI controller (e.g by QEMU) dedicated to hosting Virtio devices and potentially other emulated devices. Signed-off-by: Edgar E. Iglesias --- xen/include/public/arch-arm.h | 17 ++

[PATCH v1 0/6] xen/arm: Add Virtio-PCI for dom0less on ARM

2024-09-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This series adds support for Virtio-PCI for dom0less on ARM. Three parts: 1. Decrease size of second RAM bank to free up space in <40bit address range. 2. Add generation of virtio-pci FDT nodes for domU. 3. Add a background ECAM region always respondi

[PATCH v1 4/6] xen/arm: io: Add support for mmio background regions

2024-09-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for mmio background regions. These regions can be overlayed by IOREQ handlers and thus act as fallback handlers while IOREQ clients haven't registered. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/include/asm/mmio.h | 11 ++

[PATCH v1 5/6] xen/arm: io: Add a read-const writes-ignored mmio handler

2024-09-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a read-const writes-ignored mmio handler. This is useful to for example register background regions that return a fixed value instead of raising data aborts. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/include/asm/mmio.h | 2 ++ xen/arc

[PATCH v1 6/6] xen/arm: dom0less: Add a background PCI ECAM mmio region

2024-09-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a background PCI ECAM mmio region always reading as all ones. This indicates to the OS that there are no PCI devices on the bus. Once the device-model's IOREQ client connects, the OS can rescan the bus and find PV and emulated devices. This avoi

Re: [PATCH v1 2/6] xen/arm: Reserve resources for virtio-pci

2024-09-24 Thread Edgar E. Iglesias
On Tue, Sep 24, 2024 at 05:35:20PM +0100, Julien Grall wrote: > Hi Edgar, > > On 24/09/2024 17:23, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Reserve memory ranges and interrupt lines for an externally > > emulated PCI controller (e

[PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node

2024-09-24 Thread Edgar E. Iglesias
off-by: Stewart Hildebrand Signed-off-by: Edgar E. Iglesias --- docs/misc/arm/device-tree/booting.txt | 21 +++ xen/arch/arm/dom0less-build.c | 238 ++ xen/arch/arm/include/asm/kernel.h | 15 ++ 3 files changed, 274 insertions(+) diff --git a/docs/misc/arm/device-t

[PATCH v1 1/6] xen/arm: Decrease size of the 2nd ram bank

2024-09-24 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The address range between 4G (32bit) and 1TB (40bit) is fully allocated. There's no more room for devices on ARM systems with 40-bit physicall address width. This decreases the size of the second RAM bank to free up space in preparation for virtio-pci

Re: [PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node

2024-09-26 Thread Edgar E. Iglesias
On Tue, Sep 24, 2024 at 04:55:15PM -0700, Stefano Stabellini wrote: > On Tue, 24 Sep 2024, Edgar E. Iglesias wrote: > > From: Stewart Hildebrand > > > > When virtio-pci is specified in the dom0less domU properties, create a > > virtio-pci node in the guest's dev

Re: [PATCH v1 1/4] xen: Expose handle_bufioreq in xen_register_ioreq

2024-09-19 Thread Edgar E. Iglesias
On Mon, Sep 16, 2024 at 04:45:34PM -0700, Stefano Stabellini wrote: > On Mon, 16 Sep 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Expose handle_bufioreq in xen_register_ioreq(). > > This is to allow machines to enable or disable bu

Re: [PATCH v1 2/4] hw/xen: xenpvh: Disable buffered IOREQs for ARM

2024-09-19 Thread Edgar E. Iglesias
On Mon, Sep 16, 2024 at 04:47:43PM -0700, Stefano Stabellini wrote: > On Mon, 16 Sep 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add a way to enable/disable buffered IOREQs for PVH machines > > and disable them for ARM. ARM does not

Re: [PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node

2024-09-25 Thread Edgar E. Iglesias
On Wed, Sep 25, 2024 at 08:44:41AM +0100, Julien Grall wrote: > Hi, > Hi Julien, > On 24/09/2024 17:23, Edgar E. Iglesias wrote: > > From: Stewart Hildebrand > > > > When virtio-pci is specified in the dom0less domU properties, create a > > virtio-pci node i

Re: [PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node

2024-09-25 Thread Edgar E. Iglesias
On Wed, Sep 25, 2024 at 05:38:13PM +0100, Julien Grall wrote: > Hi Edgar, > > On 25/09/2024 17:34, Edgar E. Iglesias wrote: > > On Wed, Sep 25, 2024 at 08:44:41AM +0100, Julien Grall wrote: > > > Hi, > > > On 24/09/2024 17:23, Edgar E. Iglesias wrote:

Re: [PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node

2024-09-25 Thread Edgar E. Iglesias
On Wed, Sep 25, 2024 at 10:44 AM Edgar E. Iglesias wrote: > On Wed, Sep 25, 2024 at 05:38:13PM +0100, Julien Grall wrote: > > Hi Edgar, > > > > On 25/09/2024 17:34, Edgar E. Iglesias wrote: > > > On Wed, Sep 25, 2024 at 08:44:41AM +0100, Julien Grall wrote: > &

Re: [PATCH v1 3/6] xen/arm: create dom0less virtio-pci DT node

2024-09-25 Thread Edgar E. Iglesias
On Wed, Sep 25, 2024 at 06:45:19PM +0100, Julien Grall wrote: > Hi Edgar, > > On 25/09/2024 17:49, Edgar E. Iglesias wrote: > > On Wed, Sep 25, 2024 at 10:44 AM Edgar E. Iglesias > > wrote: > > > > > On Wed, Sep 25, 2024 at 05:38:13PM +0100,

[PULL v1 1/5] hw/xen: Remove deadcode

2024-10-03 Thread Edgar E. Iglesias
hem. Signed-off-by: Dr. David Alan Gilbert Acked-by: Anthony PERARD Reviewed-by: Thomas Huth Reviewed-by: Edgar E. Iglesias Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-legacy-backend.c | 18 -- hw/xen/xen_devconfig.c | 8 include/hw/xen/xe

[PULL v1 5/5] hw/arm: xenpvh: Enable PCI for ARM PVH

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Enable PCI support for the ARM Xen PVH machine. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/arm/xen-pvh.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c index 28af3910ea..

[PULL v1 3/5] hw/xen: xenpvh: Disable buffered IOREQs for ARM

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a way to enable/disable buffered IOREQs for PVH machines and disable them for ARM. ARM does not support buffered IOREQ's nor the legacy way to map IOREQ info pages. See the following for more details: https://xenbits.xen.org/gitweb/?p=xen.git

[PULL v1 0/5] Xen Queue

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2024-10-03 10:32:54 +0100) are available in the Git repository at:

[PULL v1 4/5] hw/xen: xenpvh: Add pci-intx-irq-base property

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Acked-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-pvh-common.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/xen/xen-pvh-common.c b/hw/xen/xen-pvh-common.c index 76a9b2b945..218ac85

[PULL v1 2/5] hw/xen: Expose handle_bufioreq in xen_register_ioreq

2024-10-03 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Expose handle_bufioreq in xen_register_ioreq(). This is to allow machines to enable or disable buffered ioreqs. No functional change since all callers still set it to HVM_IOREQSRV_BUFIOREQ_ATOMIC. Reviewed-by: Stefano Stabellini Signed-off-by: Edgar E

Re: [PATCH] xen/arm32: SPSR_hyp/SPSR

2021-06-09 Thread Edgar E. Iglesias
> > Please provide a reference to the spec. This helps reviewer and/or future > developper to figure out quickly where this comes from. > > > > > This fixes booting Xen/arm32 on QEMU. > > > > Signed-off-by: Stefano Stabellini > > With the reference added:

Re: [PATCH v8 2/8] xen: mapcache: Unmap first entries in buckets

2024-07-01 Thread Edgar E. Iglesias
RCU_READ_LOCK_GUARD(); ram_addr = xen_ram_addr_from_mapcache(ptr); +if (ram_addr == RAM_ADDR_INVALID) { +return NULL; +} block = qemu_get_ram_block(ram_addr); if (block) { *offset = ram_addr - block->offset; > Cheers, > >

Re: [PATCH v8 2/8] xen: mapcache: Unmap first entries in buckets

2024-07-01 Thread Edgar E. Iglesias
On Mon, Jul 1, 2024 at 3:58 PM Edgar E. Iglesias wrote: > On Mon, Jul 1, 2024 at 2:55 PM Anthony PERARD > wrote: > >> Hi all, >> >> Following this commit, a test which install Debian in a guest with OVMF >> as firmware started to fail. QEMU exit with an err

Re: [PATCH v8 2/8] xen: mapcache: Unmap first entries in buckets

2024-07-01 Thread Edgar E. Iglesias
On Mon, Jul 1, 2024 at 4:30 PM Edgar E. Iglesias wrote: > > > On Mon, Jul 1, 2024 at 3:58 PM Edgar E. Iglesias > wrote: > >> On Mon, Jul 1, 2024 at 2:55 PM Anthony PERARD >> wrote: >> >>> Hi all, >>> >>> Following this commit, a te

Re: [PATCH v8 2/8] xen: mapcache: Unmap first entries in buckets

2024-07-01 Thread Edgar E. Iglesias
On Mon, Jul 1, 2024 at 6:21 PM Anthony PERARD wrote: > On Mon, Jul 01, 2024 at 04:34:53PM +0200, Edgar E. Iglesias wrote: > > On Mon, Jul 1, 2024 at 4:30 PM Edgar E. Iglesias < > edgar.igles...@gmail.com> > > wrote: > > > On Mon, Jul 1, 2024 at 3:58 PM

[PATCH v1 2/2] xen: mapcache: Fix unmapping of first entries in buckets

2024-07-01 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This fixes the clobbering of the entry->next pointer when unmapping the first entry in a bucket of a mapcache. Fixes: 123acd816d ("xen: mapcache: Unmap first entries in buckets") Reported-by: Anthony PERARD Signed-off-by: Edgar E. Iglesias ---

[PATCH v1 0/2] xen: mapcache: Fix unmapping of first the entry in a bucket

2024-07-01 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This fixes the unmapping of the first mapping in a bucket of a mapcache. We also add error handling to qemu_ram_block_from_host() to bail out when xen_ram_addr_from_mapcache() doesn't find an existing mapping. Cheers, Edgar Edgar E. Iglesias (2): ph

[PATCH v1 1/2] physmem: Bail out qemu_ram_block_from_host() for invalid ram addrs

2024-07-01 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Bail out in qemu_ram_block_from_host() when xen_ram_addr_from_mapcache() does not find an existing mapping. Signed-off-by: Edgar E. Iglesias --- system/physmem.c | 4 1 file changed, 4 insertions(+) diff --git a/system/physmem.c b/system/physm

Re: [PATCH v1 1/2] physmem: Bail out qemu_ram_block_from_host() for invalid ram addrs

2024-07-04 Thread Edgar E. Iglesias
On Thu, Jul 4, 2024 at 1:26 PM Alex Bennée wrote: > "Edgar E. Iglesias" writes: > > > From: "Edgar E. Iglesias" > > > > Bail out in qemu_ram_block_from_host() when > > xen_ram_addr_from_mapcache() does not find an existing >

Re: [PATCH v1 2/2] xen: mapcache: Fix unmapping of first entries in buckets

2024-07-04 Thread Edgar E. Iglesias
On Thu, Jul 04, 2024 at 05:44:52PM +0100, Alex Bennée wrote: > Anthony PERARD writes: > > > On Tue, Jul 02, 2024 at 12:44:21AM +0200, Edgar E. Iglesias wrote: > >> From: "Edgar E. Iglesias" > >> > >> This fixes the clobbering of the entry->n

Re: [PATCH v1 2/2] xen: mapcache: Fix unmapping of first entries in buckets

2024-07-05 Thread Edgar E. Iglesias
On Thu, Jul 4, 2024 at 9:48 PM Edgar E. Iglesias wrote: > On Thu, Jul 04, 2024 at 05:44:52PM +0100, Alex Bennée wrote: > > Anthony PERARD writes: > > > > > On Tue, Jul 02, 2024 at 12:44:21AM +0200, Edgar E. Iglesias wrote: > > >> From: "Edgar E

[PULL v1 3/3] xen: mapcache: Fix unmapping of first entries in buckets

2024-07-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This fixes the clobbering of the entry->next pointer when unmapping the first entry in a bucket of a mapcache. Fixes: 123acd816d ("xen: mapcache: Unmap first entries in buckets") Reported-by: Anthony PERARD Signed-off-by: Edgar E. Iglesias Revi

Re: [PATCH v1 1/1] xen/arm: smmuv3: Mark more init-only functions with __init

2024-08-09 Thread Edgar E. Iglesias
On Wed, Jun 5, 2024 at 11:55 AM Rahul Singh wrote: > Hi Edgar, > > > On 22 May 2024, at 2:28 PM, Edgar E. Iglesias > wrote: > > > > From: "Edgar E. Iglesias" > > > > Move more functions that are only called at init to > > the .init

[PATCH v1 01/10] MAINTAINERS: Add docs/system/arm/xenpvh.rst

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 10af212632..a24c2e14d9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -559,6 +559,7 @@ F: include/hw/xen/ F: include/sysem

[PATCH v1 03/10] hw/arm: xenpvh: Tweak machine description

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Tweak machine description to better express that this is a Xen PVH machine for ARM. Signed-off-by: Edgar E. Iglesias --- hw/arm/xen_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c index

[PATCH v1 05/10] hw/arm: xenpvh: Break out a common PVH module

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break out a common Xen PVH module in preparation for adding a x86 Xen PVH Machine. Signed-off-by: Edgar E. Iglesias --- hw/arm/trace-events | 5 - hw/arm/xen_arm.c| 154 ++ hw/xen/meson.build

[PATCH v1 00/10] xen: pvh: Partial QOM:fication with new x86 PVH machine

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This series breaks-out parts of the ARM PVH support into a reusable QOM module. There's a bit of refactoring and some bug-fixes along the way. Finally we add a new x86 xen-pvh machine using the new xen-pvh-common module. The corresponding changes Xen

[PATCH v1 07/10] hw/arm: xenpvh: Reverse virtio-mmio creation order

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" We've been creating the virtio-mmio devices in forwards order but since the qbus lists prepend (rather than append) entries, the virtio busses end up with decreasing base address order. Xen enables virtio-mmio nodes in forwards order so there's been

[PATCH v1 09/10] hw/i386/xen: Add a Xen PVH x86 machine

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This adds a Xen PVH x86 machine based on the PVH Common module used by the ARM PVH machine. Signed-off-by: Edgar E. Iglesias --- hw/i386/xen/meson.build | 1 + hw/i386/xen/xen-pvh.c | 196 2 files changed, 197

[PATCH v1 06/10] hw/arm: xenpvh: Rename xen_arm.c -> xen-pvh.c

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Rename xen_arm.c -> xen-pvh.c to better express that this is a PVH machine and to align with x86 HVM and future PVH machine filenames: hw/i386/xen/xen-hvm.c hw/i386/xen/xen-pvh.c (in preparation) No functional changes. Signed-off-by: Edgar E. Iglesias

[PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq servers to handle hotplug. Signed-off-by: Edgar E. Iglesias --- hw/arm/xen_arm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_a

[PATCH v1 02/10] hw/arm: xenpvh: Update file header to use SPDX

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Update file header to use SPDX and remove stray empty comment line. No functional changes. Signed-off-by: Edgar E. Iglesias --- hw/arm/xen_arm.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/hw/arm/xen_arm.

[PATCH v1 08/10] hw/xen: pvh-common: Add support for creating PCIe/GPEX

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for optionally creating a PCIe/GPEX controller. Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-pvh-common.c | 66 + include/hw/xen/xen-pvh-common.h | 10 - 2 files changed, 75 insertions(+), 1 deletio

[PATCH v1 10/10] docs/system/i386: xenpvh: Add a basic description

2024-08-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- MAINTAINERS | 1 + docs/system/i386/xenpvh.rst | 49 + docs/system/target-i386.rst | 1 + 3 files changed, 51 insertions(+) create mode 100644 docs/system/i386/xenpvh

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-13 Thread Edgar E. Iglesias
On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote: > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add SMP support for Xen PVH ARM guests. Create max_cpus ioreq > > servers to handle hotplug. >

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-14 Thread Edgar E. Iglesias
On Tue, Aug 13, 2024 at 03:52:32PM -0700, Stefano Stabellini wrote: > On Tue, 13 Aug 2024, Edgar E. Iglesias wrote: > > On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellini wrote: > > > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: > > > > From: "Edgar

Re: [PATCH v1 05/10] hw/arm: xenpvh: Break out a common PVH module

2024-08-14 Thread Edgar E. Iglesias
On Mon, Aug 12, 2024 at 06:47:51PM -0700, Stefano Stabellini wrote: > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Break out a common Xen PVH module in preparation for > > adding a x86 Xen PVH Machine. >

Re: [PATCH v1 08/10] hw/xen: pvh-common: Add support for creating PCIe/GPEX

2024-08-14 Thread Edgar E. Iglesias
On Mon, Aug 12, 2024 at 06:48:37PM -0700, Stefano Stabellini wrote: > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add support for optionally creating a PCIe/GPEX controller. > > > > Signed-off-by: Edgar E. Igl

Re: [PATCH v1 09/10] hw/i386/xen: Add a Xen PVH x86 machine

2024-08-14 Thread Edgar E. Iglesias
On Mon, Aug 12, 2024 at 06:48:52PM -0700, Stefano Stabellini wrote: > On Mon, 12 Aug 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > This adds a Xen PVH x86 machine based on the PVH Common > > module used by the ARM PVH machine. >

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-16 Thread Edgar E. Iglesias
On Thu, Aug 15, 2024 at 2:30 AM Stefano Stabellini wrote: > On Wed, 14 Aug 2024, Edgar E. Iglesias wrote: > > On Tue, Aug 13, 2024 at 03:52:32PM -0700, Stefano Stabellini wrote: > > > On Tue, 13 Aug 2024, Edgar E. Iglesias wrote: > > > > On Mon, Aug 12, 202

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-20 Thread Edgar E. Iglesias
On Sat, Aug 17, 2024 at 2:45 AM Jason Andryuk wrote: > On 2024-08-16 12:53, Stefano Stabellini wrote: > > On Fri, 16 Aug 2024, Edgar E. Iglesias wrote: > >> On Thu, Aug 15, 2024 at 2:30 AM Stefano Stabellini < > sstabell...@kernel.org> wrote: > >> On

[PATCH v2 01/12] MAINTAINERS: Add docs/system/arm/xenpvh.rst

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Acked-by: Stefano Stabellini --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3584d6a6c6..c2fb0c2f42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -559,6 +559,7 @@ F: incl

[PATCH v2 03/12] hw/arm: xenpvh: Tweak machine description

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Tweak machine description to better express that this is a Xen PVH machine for ARM. Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- hw/arm/xen_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xen_arm.

[PATCH v2 05/12] hw/arm: xenpvh: Remove double-negation in warning

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/arm/xen_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c index fda65d0d8d..16b3f00992 100644 --- a/hw/arm/xen_arm.c +++ b/hw/arm/xen_arm.c @@ -165,7 +165,7

[PATCH v2 07/12] hw/arm: xenpvh: Break out a common PVH machine

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Break out a common Xen PVH machine in preparation for adding a x86 Xen PVH machine. Signed-off-by: Edgar E. Iglesias --- hw/arm/trace-events | 5 - hw/arm/xen_arm.c| 198 +++ hw/xen/meson.build

[PATCH v2 02/12] hw/arm: xenpvh: Update file header to use SPDX

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Update file header to use SPDX and remove stray empty comment line. No functional changes. Signed-off-by: Edgar E. Iglesias Acked-by: Stefano Stabellini --- hw/arm/xen_arm.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff

[PATCH v2 09/12] hw/arm: xenpvh: Reverse virtio-mmio creation order

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" We've been creating the virtio-mmio devices in forwards order but since the qbus lists prepend (rather than append) entries, the virtio busses end up with decreasing base address order. Xen enables virtio-mmio nodes in forwards order so there's been

[PATCH v2 00/12] xen: pvh: Partial QOM:fication with new x86 PVH machine

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" This series breaks out parts of the ARM PVH support into an abstract machine that other targets can reuse.. There's a bit of refactoring and some bug-fixes along the way. Finally we add a new x86 xen-pvh machine. The corresponding changes in Xen for P

[PATCH v2 11/12] hw/i386/xen: Add a Xen PVH x86 machine

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add a Xen PVH x86 machine based on the abstract PVH Machine. Signed-off-by: Edgar E. Iglesias --- hw/i386/xen/meson.build | 1 + hw/i386/xen/xen-pvh.c | 121 2 files changed, 122 insertions(+) create mode 1006

[PATCH v2 04/12] hw/arm: xenpvh: Add support for SMP guests

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add SMP support for Xen PVH ARM guests. Create ms->smp.max_cpus ioreq servers to handle hotplug. Note that ms->smp.max_cpus will be passed to us by the user (Xen tools) set to the guests maxvcpus. The value in mc->max_cpus is an absolute maximum

[PATCH v2 06/12] hw/arm: xenpvh: Move stubbed functions to xen-stubs.c

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- hw/arm/meson.build | 5 - hw/arm/xen-stubs.c | 32 hw/arm/xen_arm.c | 20 3 files changed, 36 insertions(+), 21 deletions(-) create mode 100644 hw/arm/xen-stu

[PATCH v2 08/12] hw/arm: xenpvh: Rename xen_arm.c -> xen-pvh.c

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Rename xen_arm.c -> xen-pvh.c to better express that this is a PVH machine and to align with x86 HVM and future PVH machine filenames: hw/i386/xen/xen-hvm.c hw/i386/xen/xen-pvh.c (in preparation) No functional changes. Signed-off-by: Edgar E. Iglesias

[PATCH v2 10/12] hw/xen: pvh-common: Add support for creating PCIe/GPEX

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Add support for optionally creating a PCIe/GPEX controller. Signed-off-by: Edgar E. Iglesias --- hw/xen/xen-pvh-common.c | 76 + include/hw/xen/xen-pvh-common.h | 29 + 2 files changed, 105 insertions(+)

[PATCH v2 12/12] docs/system/i386: xenpvh: Add a basic description

2024-08-20 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias Reviewed-by: Stefano Stabellini --- MAINTAINERS | 1 + docs/system/i386/xenpvh.rst | 49 + docs/system/target-i386.rst | 1 + 3 files changed, 51 insertions(+) create m

Re: [PATCH v4 07/17] xen: mapcache: Refactor xen_replace_cache_entry_unlocked

2024-05-01 Thread Edgar E. Iglesias
On Wed, May 1, 2024 at 10:46 PM Stefano Stabellini wrote: > > On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Add MapCache argument to xen_replace_cache_entry_unlocked in > > preparation for supporting multiple

Re: [PATCH v4 15/17] xen: mapcache: Remove assumption of RAMBlock with 0 offset

2024-05-02 Thread Edgar E. Iglesias
On Wed, May 1, 2024 at 11:24 PM Stefano Stabellini wrote: > > On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > The current mapcache assumes that all memory is mapped > > in a single RAM MR (the first one with offset 0).

Re: [PATCH v4 13/17] softmmu: Pass RAM MemoryRegion and is_write xen_map_cache()

2024-05-02 Thread Edgar E. Iglesias
On Thu, May 2, 2024 at 9:24 AM David Hildenbrand wrote: > > On 30.04.24 18:49, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Propagate MR and is_write to xen_map_cache(). > > I'm pretty sure the patch subject is missing a "to&qu

Re: [PATCH v4 12/17] xen: mapcache: Unmap first entries in buckets

2024-05-02 Thread Edgar E. Iglesias
On Tue, Apr 30, 2024 at 6:50 PM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > When invalidating memory ranges, if we happen to hit the first > entry in a bucket we were never unmapping it. This was harmless > for foreign mappings but now that we'r

Re: [PATCH v2 1/1] xen/arm64: entry: Add missing code symbol annotations

2024-05-02 Thread Edgar E. Iglesias
On Fri, Apr 26, 2024 at 1:14 AM Stefano Stabellini wrote: > > On Tue, 16 Apr 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Use the generic xen/linkage.h macros when and add missing > ^ whe

[PATCH v3 0/9] xen/arm: arm64: Annotate code symbols

2024-05-02 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" On the way towards Xen safety certification we're evaluating the use of tools to collect code-coverage/profiling information from execution traces. Some tools rely on ELF symbols for code being declared with type FUNC and having a symbol size. We cur

[PATCH v3 4/9] xen/arm64: head: Add missing code symbol annotations

2024-05-02 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use the generic xen/linkage.h macros to annotate code symbols and add missing annotations. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/arm64/head.S | 50 --- 1 file changed, 26 insertions(+), 24 deletions(-) diff -

[PATCH v3 3/9] xen/arm64: sve: Add missing code symbol annotations

2024-05-02 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use the generic xen/linkage.h macros to annotate code symbols and add missing annotations. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/arm64/sve-asm.S | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/arm64/s

[PATCH v3 9/9] xen/arm64: lib: Use the generic xen/linkage.h macros

2024-05-02 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Use the generic xen/linkage.h macros to annotate code symbols. Signed-off-by: Edgar E. Iglesias --- xen/arch/arm/arm64/lib/memchr.S | 4 ++-- xen/arch/arm/arm64/lib/memcmp.S | 4 ++-- xen/arch/arm/arm64/lib/memcpy.S | 4 ++-- xen/arch/arm/arm64/lib/mem

  1   2   3   >