Re: [Xen-devel] [PATCH v8 2/4] add a domain_tot_pages() helper function

2020-01-31 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Durrant, Paul > Sent: 31 January 2020 15:19 > To: Jan Beulich ; Julien Grall > Cc: Stefano Stabellini ; Wei Liu ; > Konrad Rzeszutek Wilk ; George Dunlap > ; Andrew Cooper ; > Ian Jacks

Re: [Xen-devel] [PATCH] libxc: migrate migration stream definitions into Xen public headers

2020-02-01 Thread Durrant, Paul
> -Original Message- > From: David Woodhouse > Sent: 01 February 2020 00:40 > To: xen-devel > Cc: Ian Jackson ; Wei Liu ; Andrew > Cooper ; George Dunlap > ; Jan Beulich ; Julien > Grall ; Konrad Rzeszutek Wilk ; > Stefano Stabellini ; Gautam, Varad > ; Du

Re: [Xen-devel] [PATCH v4 7/7] xl: allow domid to be preserved on save/restore or migrate

2020-02-01 Thread Durrant, Paul
> -Original Message- > From: Wei Liu > Sent: 31 January 2020 16:08 > To: Andrew Cooper > Cc: Durrant, Paul ; Ian Jackson > ; Anthony Perard ; xen- > de...@lists.xenproject.org; Wei Liu > Subject: Re: [Xen-devel] [PATCH v4 7/7] xl: allow domid to be preserved on &

Re: [Xen-devel] [PATCH v5 5/7] libxl: allow creation of domains with a specified or random domid

2020-02-02 Thread Durrant, Paul
> -Original Message- > From: jandr...@gmail.com > Sent: 31 January 2020 17:23 > To: Durrant, Paul > Cc: xen-devel ; Ian Jackson > ; Wei Liu ; Anthony PERARD > ; Andrew Cooper ; > George Dunlap ; Jan Beulich > ; Julien Grall ; Konrad Rzeszutek Wilk > ; Ste

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Wei Liu > Sent: 31 January 2020 17:57 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/hyperv: setup h

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 February 2020 11:06 > To: Durrant, Paul > Cc: Wei Liu ; Xen Development List de...@lists.xenproject.org>; Michael Kelley ; Wei > Liu ; Andrew Cooper ; > Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/h

Re: [Xen-devel] [PATCH v6 10/11] x86: move viridian_page_msr to hyperv-tlfs.h

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 31 January 2020 17:49 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: [PATCH v6 10/11] x86

Re: [Xen-devel] [PATCH v6 11/11] x86/hyperv: setup VP assist page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 31 January 2020 17:50 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: [PATCH v6 11/11] x86/h

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 February 2020 11:34 > To: Durrant, Paul > Cc: Wei Liu ; Xen Development List de...@lists.xenproject.org>; Michael Kelley ; Wei > Liu ; Andrew Cooper ; > Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/h

Re: [Xen-devel] [PATCH v6 05/11] x86/hyperv: setup hypercall page

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 February 2020 11:39 > To: Durrant, Paul > Cc: Wei Liu ; Xen Development List de...@lists.xenproject.org>; Michael Kelley ; Wei > Liu ; Andrew Cooper ; > Roger Pau Monné > Subject: Re: [PATCH v6 05/11] x86/h

Re: [Xen-devel] [PATCH v4 1/7] SVM: drop asm/hvm/emulate.h inclusion from vmcb.h

2020-02-03 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 31 January 2020 16:42 > To: xen-devel@lists.xenproject.org > Cc: Petre Pircalabu ; Kevin Tian > ; Tamas K Lengyel ; Wei Liu > ; Paul Durrant ; George Dunlap > ; Andrew Cooper ; > Tim Deegan ; Jun Nakajima ; Alexandru

Re: [Xen-devel] XEN Qdisk Ceph rbd support broken?

2020-02-04 Thread Durrant, Paul
De-htmling... --- From: Xen-devel On Behalf Of Jules Sent: 03 February 2020 17:35 To: xen-devel@lists.xenproject.org Cc: oleksandr_gryt...@epam.com; w...@xen.org Subject: [Xen-devel] XEN Qdisk Ceph rbd support broken? Hey, I don’t know if it was this or a previous change in qdisk driver, but ca

Re: [Xen-devel] [PATCH v2 2/2] xen/x86: hap: Clean-up and harden hap_enable()

2020-02-04 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of > Julien Grall > Sent: 04 February 2020 13:06 > To: xen-devel@lists.xenproject.org > Cc: jul...@xen.org; Wei Liu ; George Dunlap > ; Andrew Cooper ; > Grall, Julien ; Jan Beulich ; Roger > Pau Monné > Subject: [Xen-devel] [PATCH v2 2/2]

Re: [Xen-devel] [PATCH] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Durrant, Paul
> -Original Message- > From: Anthony PERARD > Sent: 05 February 2020 10:47 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Ian Jackson > ; Wei Liu ; Roger Pau Monné > > Subject: Re: [PATCH] libxl: fix assertion failure in stub domain creation > >

Re: [Xen-devel] [PATCH v7 05/10] x86/hyperv: setup hypercall page

2020-02-05 Thread Durrant, Paul
> -Original Message- > From: Wei Liu On Behalf Of Wei Liu > Sent: 04 February 2020 15:37 > To: Xen Development List > Cc: Durrant, Paul ; Michael Kelley > ; Wei Liu ; Wei Liu > ; Jan Beulich ; Andrew Cooper > ; Roger Pau Monné > Subject: [PATCH v7 05/10] x86/h

Re: [Xen-devel] [PATCH v9 0/4] purge free_shared_domheap_page()

2020-02-06 Thread Durrant, Paul
AFAICT these patches have the necessary A-b/R-b-s, or are there some missing that I need to chase? Paul > -Original Message- > From: Paul Durrant > Sent: 03 February 2020 10:57 > To: xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Andrew Cooper > ; George Dunl

Re: [Xen-devel] [PATCH v9 0/4] purge free_shared_domheap_page()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 06 February 2020 08:46 > To: Durrant, Paul > Cc: xen-devel@lists.xenproject.org; Stefano Stabellini > ; Julien Grall ; Wei Liu > ; Konrad Rzeszutek Wilk ; Andrew > Cooper ; Ian Jackson > ; George Dunlap ;

Re: [Xen-devel] [PATCH v9 3/4] mm: make pages allocated with MEMF_no_refcount safe to assign

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 06 February 2020 10:04 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Jan Beulich ; Andrew Cooper > ; George Dunlap ; > Ian Jackson ; Konrad Rzeszutek Wilk > ; Stefano Stabellini ; Wei > Liu ; Volo

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 06 February 2020 10:39 > To: xen-devel@lists.xenproject.org > Cc: jul...@xen.org; Durrant, Paul ; Grall, Julien > > Subject: [PATCH v2] xen/mm: Avoid assuming the page is inuse in > assign_pages() > > F

Re: [Xen-devel] [PATCH v2] xen/mm: Avoid assuming the page is inuse in assign_pages()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Julien Grall > Sent: 06 February 2020 11:17 > To: Durrant, Paul ; xen-devel@lists.xenproject.org > Cc: Grall, Julien > Subject: Re: [PATCH v2] xen/mm: Avoid assuming the page is inuse in > assign_pages() > > Hi Paul, > > O

Re: [Xen-devel] [PATCH v4 3/7] x86/HVM: introduce "curr" into hvmemul_rep_{mov, sto}s()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 31 January 2020 16:43 > To: xen-devel@lists.xenproject.org > Cc: George Dunlap ; Andrew Cooper > ; Roger Pau Monné ; Wei > Liu ; Paul Durrant > Subject: [Xen-devel] [PATCH v4 3/7] x86/HVM: introduce "curr" into > hv

Re: [Xen-devel] [PATCH v4 7/7] x86/HVM: reduce scope of pfec in hvm_emulate_init_per_insn()

2020-02-06 Thread Durrant, Paul
> -Original Message- > From: Xen-devel On Behalf Of Jan > Beulich > Sent: 31 January 2020 16:46 > To: xen-devel@lists.xenproject.org > Cc: George Dunlap ; Andrew Cooper > ; Roger Pau Monné ; Wei > Liu ; Paul Durrant > Subject: [Xen-devel] [PATCH v4 7/7] x86/HVM: reduce scope of pfec in >

RE: [PATCH 1/6] x86/iommu: re-arrange arch_iommu to separate common fields...

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:14 > To: p...@xen.org > Cc: 'Andrew Cooper' ; > xen-devel@lists.xenproject.org; Durrant, Paul > ; 'Lukasz Hawrylko' ; > 'Wei Liu' ; > 'Roger Pau Monné'

RE: [PATCH 2/6] x86/iommu: add common page-table allocator

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 24 July 2020 19:24 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Kevin Tian > ; Wei Liu ; Roger Pau Monné > > Subject: RE: [EXTERNAL] [PATCH 2/6] x86/iommu: add

RE: [PATCH 3/6] iommu: remove iommu_lookup_page() and the lookup_page() method...

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:28 > To: p...@xen.org > Cc: 'Andrew Cooper' ; > xen-devel@lists.xenproject.org; Durrant, Paul > ; 'Kevin Tian' > Subject: RE: [EXTERNAL] [PATCH 3/6] iommu: remove iommu_l

RE: [PATCH 6/6] iommu: stop calling IOMMU page tables 'p2m tables'

2020-07-27 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 24 July 2020 20:09 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Kevin Tian > > Subject: RE: [EXTERNAL] [PATCH 6/6] iommu: stop calling IOMMU page tables > 

RE: [PATCH 4/6] remove remaining uses of iommu_legacy_map/unmap

2020-07-29 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:36 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George > Dunlap ; Ian Jackson ; > Julien Grall > ;

RE: [PATCH 5/6] iommu: remove the share_p2m operation

2020-07-29 Thread Durrant, Paul
> -Original Message- > From: Andrew Cooper > Sent: 24 July 2020 20:01 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > George Dunlap > ; Wei Liu ; Roger Pau Monné > ; Kevin Tian > > Subject: RE: [EXTERNAL] [PATCH 5/

RE: [PATCH 5/6] iommu: remove the share_p2m operation

2020-07-29 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 26 July 2020 09:50 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Andrew Cooper > ; George Dunlap ; Wei > Liu ; Roger Pau > Monné ; Kevin Tian > Subject: RE: [EXTERNAL] [PATCH 5/

RE: [PATCH v2 08/10] remove remaining uses of iommu_legacy_map/unmap

2020-07-31 Thread Durrant, Paul
> -Original Message- > From: Paul Durrant > Sent: 30 July 2020 15:29 > To: xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Andrew Cooper > ; Wei Liu ; Roger Pau Monné > ; George > Dunlap ; Ian Jackson ; > Julien Grall > ;

RE: [PATCH v2 2/2] x86/hvm: simplify 'mmio_direct' check in epte_get_entry_emt()

2020-07-31 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 31 July 2020 14:41 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > 'Andrew Cooper' > ; 'Wei Liu' ; 'Roger Pau Monné' > > Subject: RE: [EXTERNAL] [

RE: [PATCH v3 1/2] x86/hvm: set 'ipat' in EPT for special pages

2020-07-31 Thread Durrant, Paul
> -Original Message- > From: Paul Durrant > Sent: 31 July 2020 15:26 > To: xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich ; > Andrew Cooper > ; Wei Liu ; Roger Pau Monné > > Subject: [EXTERNAL] [PATCH v3 1/2] x86/hvm: set 'i

RE: [PATCH 3/4] public/io/netif: specify MTU override node

2020-08-03 Thread Durrant, Paul
> -Original Message- > From: Jürgen Groß > Sent: 03 August 2020 06:09 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul > Subject: RE: [EXTERNAL] [PATCH 3/4] public/io/netif: specify MTU override node > > On 30.07.20 21:48, Paul Durra

RE: [PATCH v3 02/11] x86/iommu: add common page-table allocator

2020-08-03 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 03 August 2020 16:59 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Andrew Cooper > ; Wei Liu ; Roger Pau Monné > > Subject: RE: [EXTERNAL] [PATCH v3 02/11] x86/iommu: add com

RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore

2020-08-05 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 05 August 2020 10:31 > To: p...@xen.org > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > 'Wei Liu' > Subject: RE: [EXTERNAL] [PATCH v2 4/4] tools/hotplug: modify set_mtu() to > inform the frontend

RE: [PATCH v2 4/4] tools/hotplug: modify set_mtu() to inform the frontend via xenstore

2020-08-05 Thread Durrant, Paul
> -Original Message- > From: Ian Jackson > Sent: 05 August 2020 11:13 > To: Durrant, Paul > Cc: p...@xen.org; xen-devel@lists.xenproject.org; 'Wei Liu' > Subject: RE: [EXTERNAL] [PATCH v2 4/4] tools/hotplug: modify set_mtu() to > inform the frontend vi

RE: [PATCH v4 07/14] iommu: make map, unmap and flush all take both an order and a count

2020-08-11 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 06 August 2020 10:57 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Jun Nakajima > ; Kevin Tian ; Andrew Cooper > ; George Dunlap ; Wei > Liu ; Roger Pau > Monné ; Ian Jackson

RE: [PATCH v4 12/14] vtd: use a bit field for root_entry

2020-08-12 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 06 August 2020 13:34 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Kevin Tian > > Subject: RE: [EXTERNAL] [PATCH v4 12/14] vtd: use a bit field for root_entry > > CAUTION: This

RE: [PATCH] x86 / viridian: remove the viridian_vcpu msg_pending bit mask

2020-08-13 Thread Durrant, Paul
> -Original Message- > From: Roger Pau Monné > Sent: 13 August 2020 11:16 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Wei Liu ; Jan > Beulich ; Andrew Cooper > Subject: RE: [EXTERNAL] [PATCH] x86 / viridian: remove the viridian

RE: [PATCH v4 03/14] x86/iommu: convert VT-d code to use new page table allocator

2020-08-14 Thread Durrant, Paul
> -Original Message- [snip] > > -static void iommu_free_page_table(struct page_info *pg) > > -{ > > -unsigned int i, next_level = PFN_ORDER(pg) - 1; > > -u64 pt_maddr = page_to_maddr(pg); > > -struct dma_pte *pt_vaddr, *pte; > > - > > -PFN_ORDER(pg) = 0; > > -pt_vaddr =

RE: [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() or iommu_unmap() fail

2020-08-14 Thread Durrant, Paul
> -Original Message- > From: Tian, Kevin > Sent: 14 August 2020 07:53 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Durrant, Paul ; Jan Beulich > Subject: RE: [EXTERNAL] [PATCH v4 06/14] iommu: flush I/O TLB if iommu_map() > or iommu_unmap() fail >

RE: [ANNOUNCE] Call for agenda items for 3 September Community Call @ 15:00 UTC

2020-08-28 Thread Durrant, Paul
> -Original Message- > From: George Dunlap > Sent: 28 August 2020 11:48 > To: Tamas K Lengyel ; intel-...@intel.com; > daniel.ki...@oracle.com; Roger > Pau Monne ; Sergey Dyasli ; > Christopher Clark > ; Rich Persaud ; Kevin > Pearson > ; Juergen Gross ;

RE: [PATCH v3 0/8] tools: propogate MTU to vif frontends

2020-08-28 Thread Durrant, Paul
> -Original Message- > From: Wei Liu > Sent: 27 August 2020 10:58 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Andrew Cooper > ; Anthony PERARD ; > George Dunlap > ; Ian Jackson ; Jan > Beulich ; > Julien Grall ; Stefano S

RE: [xen-unstable test] 153154: regressions - trouble: broken/fail/pass

2020-09-01 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 31 August 2020 15:26 > To: Roger Pau Monné > Cc: Jürgen Groß ; osstest service owner > ; xen- > de...@lists.xenproject.org; Durrant, Paul > Subject: RE: [EXTERNAL] [xen-unstable test] 153154: regressions - trou

RE: [PATCH v5 1/5] xen/common: introduce a new framework for save/restore of 'domain' context

2020-05-22 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 22 May 2020 15:25 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Julien Grall > ; Andrew Cooper ; George Dunlap > ; > Ian Jackson ; Stefano Stabellini > ; Wei Liu > ; Volod

RE: [PATCH v5 4/5] common/domain: add a domain context record for shared_info...

2020-05-22 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 22 May 2020 15:34 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Ian Jackson > ; Wei Liu ; Andrew Cooper > ; George > Dunlap ; Julien Grall ; Stefano > Stabellini > > S

RE: [PATCH v6 4/5] common/domain: add a domain context record for shared_info...

2020-05-28 Thread Durrant, Paul
> -Original Message- > From: Jan Beulich > Sent: 28 May 2020 10:42 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org; Durrant, Paul ; > Ian Jackson > ; Wei Liu ; Andrew Cooper > ; George > Dunlap ; Julien Grall ; Stefano > Stabellini > > S

Re: [PATCH] IOMMU: make domctl handler tolerate NULL domain

2022-04-19 Thread Durrant, Paul
On 19/04/2022 10:39, Jan Beulich wrote: Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed here, when the domctl was passed DOMID_INVALID. Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate

Re: [PATCH v2 1/2] PCI: replace stray uses of PCI_{DEVFN,BDF}2()

2022-04-21 Thread Durrant, Paul
On 21/04/2022 15:26, Jan Beulich wrote: There's no good reason to use these when we already have a pci_sbdf_t type object available. This extends to the use of PCI_BUS() in pci_ecam_map_bus() as well. No change to generated code (with gcc11 at least, and I have to admit that I didn't expect comp

Re: [PATCH v2 2/2] PCI: replace "secondary" flavors of PCI_{DEVFN,BDF,SBDF}()

2022-04-21 Thread Durrant, Paul
On 21/04/2022 15:27, Jan Beulich wrote: At their use sites the numeric suffixes are at least odd to read, first and foremost for PCI_DEVFN2() where the suffix doesn't even match the number of arguments. Make use of count_args() such that a single flavor each suffices (leaving aside helper macros,

Re: Ping: [PATCH v2 3/3] AMD/IOMMU: consider hidden devices when flushing device I/O TLBs

2021-10-11 Thread Durrant, Paul
On 11/10/2021 09:04, Jan Beulich wrote: On 17.09.2021 13:00, Jan Beulich wrote: Hidden devices are associated with DomXEN but usable by the hardware domain. Hence they need flushing as well when all devices are to have flushes invoked. While there drop a redundant ATS-enabled check and constify

Re: [PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()

2021-10-18 Thread Durrant, Paul
On 18/10/2021 11:42, Ian Jackson wrote: Jan Beulich writes ("[PATCH] x86/HVM: correct cleanup after failed viridian_vcpu_init()"): This happens after nestedhvm_vcpu_initialise(), so its effects also need to be undone. Fixes: 40a4a9d72d16 ("viridian: add init hooks") Signed-off-by: Jan Beulich

Re: [PATCH 1/3] x86/Viridian: fix error code use

2021-11-18 Thread Durrant, Paul
On 18/11/2021 13:13, Jan Beulich wrote: Both the wrong use of HV_STATUS_* and the return type of hv_vpset_to_vpmask() can lead to viridian_hypercall()'s ASSERT_UNREACHABLE() triggering when translating error codes from Xen to Viridian representation. Fixes: b4124682db6e ("viridian: add ExProcess

Re: [PATCH 2/3] x86/Viridian: drop dead variable updates

2021-11-18 Thread Durrant, Paul
On 18/11/2021 13:14, Jan Beulich wrote: Both hvcall_flush_ex() and hvcall_ipi_ex() update "size" without subsequently using the value; future compilers may warn about such. Alongside dropping the updates, shrink the variables' scopes to demonstrate that there are no outer scope uses. Signed-off-

Re: [PATCH 3/3] x86/Viridian: fold duplicate vpset retrieval code

2021-11-18 Thread Durrant, Paul
On 18/11/2021 13:14, Jan Beulich wrote: hvcall_{flush,ipi}_ex() use more almost identical code than what was isolated into hv_vpset_to_vpmask(). Move that code there as well, to have just one instance of it. This way all of HV_GENERIC_SET_SPARSE_4K processing now happens in a single place. Signe

Re: [PATCH] x86/hvm: Remove callback from paging->flush_tlb() hook

2021-11-18 Thread Durrant, Paul
On 18/11/2021 11:19, Andrew Cooper wrote: On 18/11/2021 10:45, Jan Beulich wrote: On 17.11.2021 19:26, Andrew Cooper wrote: TLB flushing is a hotpath, and function pointer calls are expensive (especially under repoline) for what amounts to an identity transform on the data. Just pass the vcpu_

Re: [PATCH v2] x86/hvm: Remove callback from paging->flush_tlb() hook

2021-11-18 Thread Durrant, Paul
On 18/11/2021 18:48, Andrew Cooper wrote: TLB flushing is a hotpath, and function pointer calls are expensive (especially under repoline) for what amounts to an identity transform on the data. Just pass the vcpu_bitmap bitmap directly. As we use NULL for all rather than none, introduce a flush_

Re: [PATCH v2] xen-mapcache: Avoid entry->lock overflow

2022-01-25 Thread Durrant, Paul
On 24/01/2022 10:44, Ross Lagerwall wrote: In some cases, a particular mapcache entry may be mapped 256 times causing the lock field to wrap to 0. For example, this may happen when using emulated NVME and the guest submits a large scatter-gather write. At this point, the entry map be remapped cau

Re: [PATCH] libxl: force netback to wait for hotplug execution before connecting

2022-01-25 Thread Durrant, Paul
On 24/01/2022 16:02, Roger Pau Monne wrote: By writing an empty "hotplug-status" xenstore node in the backend path libxl can force Linux netback to wait for hotplug script execution before proceeding to the 'connected' state. This is required so that netback doesn't skip state 2 (InitWait) and t

Re: [PATCH] x86emul: recognize CLDEMOTE

2022-01-25 Thread Durrant, Paul
On 25/01/2022 15:08, Jan Beulich wrote: On 25.01.2022 15:22, Jan Beulich wrote: We claim to support the insn, but so far the emulator has been handling it as a NOP. Signed-off-by: Jan Beulich I'm sorry, I should have Cc-ed Paul here as well. Acked-by: Paul Durrant Jan --- While handl

Re: [PATCH] xen-hvm: Allow disabling buffer_io_timer

2022-01-26 Thread Durrant, Paul
On 26/01/2022 13:43, Jason Andryuk wrote: On Tue, Dec 14, 2021 at 8:40 AM Durrant, Paul wrote: On 10/12/2021 11:34, Jason Andryuk wrote: commit f37f29d31488 "xen: slightly simplify bufioreq handling" hard coded setting req.count = 1 during initial field setup before the main l

Re: [PATCH v2 1/4] IOMMU/x86: switch to alternatives-call patching in further instances

2022-01-28 Thread Durrant, Paul
On 27/01/2022 14:47, Jan Beulich wrote: This is, once again, to limit the number of indirect calls as much as possible. The only hook invocation which isn't sensible to convert is setup(). And of course Arm-only use sites are left alone as well. Note regarding the introduction / use of local var

Re: [PATCH v2 2/4] VT-d / x86: re-arrange cache syncing

2022-01-28 Thread Durrant, Paul
On 27/01/2022 14:48, Jan Beulich wrote: The actual function should always have lived in core x86 code; move it there, replacing get_cache_line_size() by readily available (except very early during boot; see the code comment) data. Also rename the function. Drop the respective IOMMU hook, (re)int

Re: [PATCH v2 3/4] VT-d: replace flush_all_cache()

2022-01-28 Thread Durrant, Paul
On 27/01/2022 14:49, Jan Beulich wrote: Let's use infrastructure we have available instead of an open-coded wbinvd() invocation. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: [PATCH v2 4/4] IOMMU/PCI: propagate get_device_group_id() failure

2022-01-28 Thread Durrant, Paul
On 27/01/2022 14:49, Jan Beulich wrote: The VT-d hook can indicate an error, which shouldn't be ignored. Convert the hook's return value to a proper error code, and let that bubble up. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant

Re: tools: propogate MTU to vif frontends (backporting)

2022-02-14 Thread Durrant, Paul
On 14/02/2022 10:48, James Dingwall wrote: Hi, I've been backporting this series to xen 4.14 and everything relating to the backend seems to be working well. For the frontend I can see the mtu value published to xenstore but it does't appear to be consumed to set the matching mtu in the guest.

Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators

2022-02-16 Thread Durrant, Paul
On 16/02/2022 10:30, Roger Pau Monne wrote: Introduce a new arch specific field to report whether an emulator supports the Extended Destination ID field, so that the hypervisor can refrain from exposing the feature if one of the emulators doesn't support it. Signed-off-by: Roger Pau Monné --- C

Re: [PATCH v2 RFC 4/5] x86/ioreq: report extended destination ID support by emulators

2022-02-16 Thread Durrant, Paul
On 16/02/2022 11:32, Roger Pau Monné wrote: On Wed, Feb 16, 2022 at 10:53:58AM +, Durrant, Paul wrote: On 16/02/2022 10:30, Roger Pau Monne wrote: Introduce a new arch specific field to report whether an emulator supports the Extended Destination ID field, so that the hypervisor can

Re: [PATCH v2 1/2] Revert "xen-netback: remove 'hotplug-status' once it has served its purpose"

2022-02-23 Thread Durrant, Paul
On 22/02/2022 00:18, Marek Marczykowski-Górecki wrote: This reverts commit 1f2565780e9b7218cf92c7630130e82dcc0fe9c2. The 'hotplug-status' node should not be removed as long as the vif device remains configured. Otherwise the xen-netback would wait for re-running the network script even if it was

Re: [PATCH v2 2/2] Revert "xen-netback: Check for hotplug-status existence before watching"

2022-02-23 Thread Durrant, Paul
On 22/02/2022 00:18, Marek Marczykowski-Górecki wrote: This reverts commit 2afeec08ab5c86ae21952151f726bfe184f6b23d. The reasoning in the commit was wrong - the code expected to setup the watch even if 'hotplug-status' didn't exist. In fact, it relied on the watch being fired the first time - to

Re: [PATCH 2/2] hw/i386/xen/xen-hvm: Inline xen_piix_pci_write_config_client() and remove it

2022-06-27 Thread Durrant, Paul
On 26/06/2022 10:46, Bernhard Beschow wrote: xen_piix_pci_write_config_client() is implemented in the xen sub tree and uses PIIX constants internally, thus creating a direct dependency on PIIX. Now that xen_set_pci_link_route() is stubbable, the logic of xen_piix_pci_write_config_client() can be

Re: [PATCH 1/2] hw/i386/xen/xen-hvm: Allow for stubbing xen_set_pci_link_route()

2022-06-27 Thread Durrant, Paul
On 26/06/2022 10:46, Bernhard Beschow wrote: The only user of xen_set_pci_link_route() is xen_piix_pci_write_config_client() which implements PIIX-specific logic in the xen namespace. This makes xen-hvm depend on PIIX which could be avoided if xen_piix_pci_write_config_client() was implemented in

Re: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb()

2022-07-13 Thread Durrant, Paul
On 13/07/2022 09:48, Juergen Gross wrote: xenvif_rx_next_skb() is expecting the rx queue not being empty, but in case the loop in xenvif_rx_action() is doing multiple iterations, the availability of another skb in the rx queue is not being checked. This can lead to crashes: [40072.537261] BUG:

Re: [PATCH v7 01/14] iommu: add preemption support to iommu_{un,}map()

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:43, Jan Beulich wrote: From: Roger Pau Monné The loop in iommu_{,un}map() can be arbitrary large, and as such it needs to handle preemption. Introduce a new flag that signals whether the function should do preemption checks, returning the number of pages that have been process

Re: [PATCH v7 02/14] IOMMU/x86: perform PV Dom0 mappings in batches

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:44, Jan Beulich wrote: For large page mappings to be easily usable (i.e. in particular without un-shattering of smaller page mappings) and for mapping operations to then also be more efficient, pass batches of Dom0 memory to iommu_map(). In dom0_construct_pv() and its helpers (co

Re: [PATCH v7 03/14] IOMMU/x86: support freeing of pagetables

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:44, Jan Beulich wrote: For vendor specific code to support superpages we need to be able to deal with a superpage mapping replacing an intermediate page table (or hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is needed to free individual page tables while

Re: [PATCH v7 04/14] IOMMU/x86: new command line option to suppress use of superpage mappings

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:45, Jan Beulich wrote: Before actually enabling their use, provide a means to suppress it in case of problems. Note that using the option can also affect the sharing of page tables in the VT-d / EPT combination: If EPT would use large page mappings but the option is in effect, pa

Re: [PATCH v7 05/14] AMD/IOMMU: allow use of superpage mappings

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:45, Jan Beulich wrote: No separate feature flags exist which would control availability of these; the only restriction is HATS (establishing the maximum number of page table levels in general), and even that has a lower bound of 4. Thus we can unconditionally announce 2M and 1G m

Re: [PATCH v7 06/14] VT-d: allow use of superpage mappings

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:46, Jan Beulich wrote: ... depending on feature availability (and absence of quirks). Also make the page table dumping function aware of superpages. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant

Re: [PATCH v7 07/14] x86: introduce helper for recording degree of contiguity in page tables

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:47, Jan Beulich wrote: This is a re-usable helper (kind of a template) which gets introduced without users so that the individual subsequent patches introducing such users can get committed independently of one another. See the comment at the top of the new file. To demonstrate

Re: [PATCH v7 08/14] IOMMU/x86: prefill newly allocate page tables

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:47, Jan Beulich wrote: Page tables are used for two purposes after allocation: They either start out all empty, or they are filled to replace a superpage. Subsequently, to replace all empty or fully contiguous page tables, contiguous sub-regions will be recorded within individual

Re: [PATCH v7 09/14] AMD/IOMMU: free all-empty page tables

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:47, Jan Beulich wrote: When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers()

Re: [PATCH v7 10/14] VT-d: free all-empty page tables

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:48, Jan Beulich wrote: When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers()

Re: [PATCH v7 11/14] AMD/IOMMU: replace all-contiguous page tables by superpage mappings

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:48, Jan Beulich wrote: When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. Signed-off-by: Jan Beulich Reviewed-by:

Re: [PATCH v7 12/14] VT-d: replace all-contiguous page tables by superpage mappings

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:48, Jan Beulich wrote: When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. The adjustment to LEVEL_MASK is merely to

Re: [PATCH v7 13/14] IOMMU/x86: add perf counters for page table splitting / coalescing

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:49, Jan Beulich wrote: Signed-off-by: Jan Beulich Reviewed-by: Kevin tian Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant

Re: [PATCH v7 14/14] VT-d: fold dma_pte_clear_one() into its only caller

2022-07-22 Thread Durrant, Paul
On 05/07/2022 13:49, Jan Beulich wrote: This way intel_iommu_unmap_page() ends up quite a bit more similar to intel_iommu_map_page(). No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant

RE: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-05-11 Thread Durrant, Paul
> -Original Message- > From: Marek Marczykowski-Górecki > Sent: 10 May 2021 20:43 > To: Michael Brown ; p...@xen.org > Cc: p...@xen.org; xen-devel@lists.xenproject.org; net...@vger.kernel.org; > wei@kernel.org; Durrant, > Paul > Subject: RE: [EXTERNAL] [PATCH

RE: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-05-11 Thread Durrant, Paul
> -Original Message- > From: Marek Marczykowski-Górecki > Sent: 11 May 2021 11:45 > To: Durrant, Paul > Cc: Michael Brown ; p...@xen.org; > xen-devel@lists.xenproject.org; > net...@vger.kernel.org; wei@kernel.org > Subject: RE: [EXTERNAL] [PATCH] xen-ne

Re: Ping: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}()

2023-08-03 Thread Durrant, Paul
On 03/08/2023 12:46, Jan Beulich wrote: On 27.07.2023 20:41, Stefano Stabellini wrote: On Thu, 27 Jul 2023, Jan Beulich wrote: In the latter case the variable altogether is then unused and hence gets dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly introduced both assign

Re: [PATCH] ns16550c: avoid crash in ns16550_endboot in PV shim mode

2023-10-20 Thread Durrant, Paul
On 20/10/2023 14:37, David Woodhouse wrote: [snip] [0] https://elixir.bootlin.com/linux/latest/source/drivers/tty/hvc/hvc_xen.c#L258 I'm not convinced I believe what the comment says there about evtchn 0 being theoretically valid. I don't believe zero is a valid evtchn#, is it? gfn 0 might

Re: [PATCH v3 05/28] hw/xen: fix XenStore watch delivery to guest

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse When fire_watch_cb() found the response buffer empty, it would call deliver_watch() to generate the XS_WATCH_EVENT message in the response buffer and send an event channel notification to the guest… without actually *copying* the

Re: [PATCH v3 06/28] hw/xen: take iothread mutex in xen_evtchn_reset_op()

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse The xen_evtchn_soft_reset() function requires the iothread mutex, but is also called for the EVTCHNOP_reset hypercall. Ensure the mutex is taken in that case. Fixes: a15b10978fe6 ("hw/xen: Implement EVTCHNOP_reset") Signed-off-b

Re: [PATCH v3 07/28] hw/xen: use correct default protocol for xen-block on x86

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse Even on x86_64 the default protocol is the x86-32 one if the guest doesn't specifically ask for x86-64. Fixes: b6af8926fb85 ("xen: add implementations of xen-block connect and disconnect functions...") Signed-off-by: David Wood

Re: [PATCH v3 08/28] i386/xen: Ignore VCPU_SSHOTTMR_future flag in set_singleshot_timer()

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse Upstream Xen now ignores this flag¹, since the only guest kernel ever to use it was buggy. ¹ https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=19c6cbd909 Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- t

Re: [PATCH v3 13/28] hw/xen: automatically assign device index to block devices

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse There's no need to force the user to assign a vdev. We can automatically assign one, starting at xvda and searching until we find the first disk name that's unused. This means we can now allow '-drive if=xen,file=xxx' to work wi

Re: [PATCH v3 14/28] hw/xen: add get_frontend_path() method to XenDeviceClass

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse The primary Xen console is special. The guest's side is set up for it by the toolstack automatically and not by the standard PV init sequence. Accordingly, its *frontend* doesn't appear in …/device/console/0 either; instead it a

Re: [PATCH v3 17/28] hw/xen: add support for Xen primary console in emulated mode

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse The primary console is special because the toolstack maps a page into the guest for its ring, and also allocates the guest-side event channel. The guest's grant table is even primed to export that page using a known grant ref#. A

Re: [PATCH v3 18/28] hw/xen: only remove peers of PCI NICs on unplug

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse When the Xen guest asks to unplug *emulated* NICs, it's kind of unhelpful also to unplug the peer of the *Xen* PV NIC. Signed-off-by: David Woodhouse --- hw/i386/xen/xen_platform.c | 9 +++-- 1 file changed, 7 insertions

Re: [PATCH v3 19/28] hw/xen: update Xen PV NIC to XenDevice model

2023-10-27 Thread Durrant, Paul
On 25/10/2023 15:50, David Woodhouse wrote: From: David Woodhouse This allows us to use Xen PV networking with emulated Xen guests, and to add them on the command line or hotplug. Signed-off-by: David Woodhouse --- hw/net/meson.build| 2 +- hw/net/trace-events | 11 + hw/

<    1   2   3   4   5   >