lude "hw/timer/i8254_internal.h"
> > -#include "migration/qemu-file-types.h"
> > #include "migration/vmstate.h"
> > /* val must be 0 or 1 */
> > @@ -202,43 +201,6 @@ static const VMStateDescription vmstate_
a false positive; libvixl is written in C++ !
Dave
> > total: 1 errors, 0 warnings, 56 lines checked
> >
> > Patch 4/4 has style problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
xen-stub.c
> index 7ba0b697f4..7054965c48 100644
> --- a/accel/stubs/xen-stub.c
> +++ b/accel/stubs/xen-stub.c
> @@ -7,7 +7,7 @@
>
> #include "qemu/osdep.h"
> #include "sysemu/xen.h"
> -#include "qapi/qapi-commands-misc.h"
> +#include "qapi/qapi-commands-migration.h"
>
> bool xen_allowed;
>
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index f3ababf33b..9519c33c09 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -24,7 +24,7 @@
> #include "hw/xen/xen-bus.h"
> #include "hw/xen/xen-x86.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands-misc.h"
> +#include "qapi/qapi-commands-migration.h"
> #include "qemu/error-report.h"
> #include "qemu/main-loop.h"
> #include "qemu/range.h"
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 34e4b71052..1fdf3f76c2 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -42,7 +42,6 @@
> #include "postcopy-ram.h"
> #include "qapi/error.h"
> #include "qapi/qapi-commands-migration.h"
> -#include "qapi/qapi-commands-misc.h"
> #include "qapi/qmp/qerror.h"
> #include "qemu/error-report.h"
> #include "sysemu/cpus.h"
> --
> 2.26.2
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
O. I'm not sure how performance sensitive the COLO
> code is, and I haven't measured anything.
COLO snapshots are potentially quite sensitive; although we've got a
load of other things we could do with speeding up, we could do without
making them noticably heavier.
Dave
> Does anyone have thoughts or opinions on the subject?
>
> Thanks,
> Jason
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
t
> start, ram_addr_t len)
> }
>
> struct RAMSrcPageRequest *new_entry =
> - g_malloc0(sizeof(struct RAMSrcPageRequest));
> +g_new0(struct RAMSrcPageRequest, 1);
> new_entry->rb = ramblock;
> new_entry->offset = start;
> new_entry->len = len;
For migration:
Acked-by: Dr. David Alan Gilbert
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
ULL, NULL, opaque);
> > +aio_set_fd_handler(ctx, rioc->rdmaout->recv_comp_channel->fd,
> > io_read,
> > + io_write, NULL, NULL, opaque);
> > +aio_set_fd_handler(ctx, rioc->rdmaout->send_comp_channel->fd,
> >
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> Signed-off-by: Daniel P. Berrangé
Yes, although I'm a little surprised this hasn't thrown up any warnings.
Reviewed-by: Dr. David Alan Gilbert
> ---
> tools/virtiofsd/fuse_log.c | 1 +
> tools/virtiofs
nk that's OK; this is an imported file, but we've already
mangled it into QEMU's style and added includes etc.
Reviewed-by: Dr. David Alan Gilbert
> ---
> tools/virtiofsd/fuse_common.h | 11 +--
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> di
