On 9/3/20 7:17 PM, Ian Jackson wrote:
> Jan Beulich writes ("Re: [xen-unstable test] 153602: regressions - FAIL"):
>> On 03.09.2020 12:24, osstest service owner wrote:
>>> flight 153602 xen-unstable real [real]
>>> http://logs.test-lab.xenproject.org/osstest/logs/153602/
>>>
>>> Regressions :-(
>>>
since it would reference a dynamically allocated string.
Signed-off-by: Costin Lupu
---
stubdom/grub/mini-os.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/stubdom/grub/mini-os.c b/stubdom/grub/mini-os.c
index 4fc052a255..b33dbf02fb 100644
--- a/stubdom/grub/mini-os.c
also removes passing
>> the ip parameter because (a) it is not used anywhere and (b) it wastes
>> memory since it would reference a dynamically allocated string.
>>
>> Signed-off-by: Costin Lupu
>
> Reviewed-by: Samuel Thibault
>
>> ---
>> stubdom/grub/mini
since it would reference a dynamically allocated string.
Signed-off-by: Costin Lupu
---
stubdom/grub/mini-os.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/stubdom/grub/mini-os.c b/stubdom/grub/mini-os.c
index 4fc052a255..b33dbf02fb 100644
--- a/stubdom/grub/mini-os.c
On 8/27/20 7:07 PM, Jan Beulich wrote:
> On 27.08.2020 17:49, osstest service owner wrote:
>> flight 152898 xen-unstable-smoke real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/152898/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which c
Hi Julien,
On 7/8/21 8:33 PM, Julien Grall wrote:
> Hi Costin,
>
> On 08/06/2021 13:35, Costin Lupu wrote:
>> If PAGE_SIZE is already defined in the system (e.g. in
>> /usr/include/limits.h
>> header) then gcc will trigger a redefinition error because of -Werror.
>
Hi Jan,
First of all sorry for breaking the stubdom build. Please see inline.
On 7/13/21 9:47 AM, Jan Beulich wrote:
> On 08.06.2021 14:35, Costin Lupu wrote:
>> --- a/tools/libs/foreignmemory/private.h
>> +++ b/tools/libs/foreignmemory/private.h
>> @@ -1,
Hi guys,
On 7/13/21 4:00 PM, Julien Grall wrote:
>
>
> On 13/07/2021 13:39, Andrew Cooper wrote:
>> On 13/07/2021 12:53, Julien Grall wrote:
>>> Hi Andrew,
>>>
>>> On 13/07/2021 12:23, Andrew Cooper wrote:
On 13/07/2021 12:21, Julien Grall wrote:
> Hi Andrew,
>
> On 13/07/2021 1
On 7/13/21 6:20 PM, Juergen Gross wrote:
> On 13.07.21 17:15, Julien Grall wrote:
>> Hi Juergen,
>>
>> On 13/07/2021 16:09, Juergen Gross wrote:
>>> On 13.07.21 16:38, Julien Grall wrote:
Hi Juergen,
On 13/07/2021 15:23, Juergen Gross wrote:
> On 13.07.21 16:19, Julien Grall wrot
On 7/27/21 4:36 PM, Andrew Cooper wrote:
> On 16/07/2021 19:28, Costin Lupu wrote:
>> On 7/13/21 6:20 PM, Juergen Gross wrote:
>>> On 13.07.21 17:15, Julien Grall wrote:
>>>> Hi Juergen,
>>>>
>>>> On 13/07/2021 16:09, Juergen Gross wrote:
Messages printed with PERROR() do not need explicit newlines (\n)
because they are added implicitly.
Signed-off-by: Costin Lupu
---
tools/libs/ctrl/xc_vm_event.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/libs/ctrl/xc_vm_event.c b/tools/libs/ctrl
toolstack component that doesn't need a dependency to xenctrl library.
Costin Lupu (4):
public: Add page related definitions for accessing guests memory
libs/ctrl: Use Xen values for XC_PAGE_* definitions
libs/foreignmemory: Use XEN_PAGE_* definitions
libs/gnttab: Use XEN_
We use the values provided by the Xen public interface for defining the
XC_PAGE_* macros.
Signed-off-by: Costin Lupu
---
tools/include/xenctrl.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index 14adaa0c10
use them it also
had to add a dependency for the xenctrl library.
For this patch we set the same values for both x86 and ARM architectures.
Signed-off-by: Costin Lupu
---
xen/include/public/arch-arm/page.h | 34 ++
xen/include/public/arch-x86/page.h | 34
These changes refine the changes in d1b32abd which added a dependency to
xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_*
definitions and therefore we get rid of the unnecessary dependency.
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/freebsd.c | 20
These changes refine the changes in 0dbb4be7 which added a dependency to
xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_*
definitions and therefore we get rid of the unnecessary dependency.
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory/core.c| 2
We use the values provided by the Xen public interface for defining the
XC_PAGE_* macros.
Signed-off-by: Costin Lupu
---
tools/include/xenctrl.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index b77726eab7
toolstack component that doesn't need a dependency to xenctrl library.
Changes since v1:
- Use same page definitions for both x86_64 and ARM (i.e. a single page.h file)
- Introduce xen_mk_long()
Costin Lupu (4):
public: Add page related definitions for accessing guests memory
libs/ctrl: Us
use them it also
had to add a dependency for the xenctrl library.
This patch also introduces xen_mk_long() macrodefinition for defining long
constants both for C and assembler code.
Signed-off-by: Costin Lupu
---
xen/include/public/page.h | 36
xen/include
These changes refine the changes in d1b32abd which added a dependency to
xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_*
definitions and therefore we get rid of the unnecessary dependency.
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/freebsd.c | 20
These changes refine the changes in 0dbb4be7 which added a dependency to
xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_*
definitions and therefore we get rid of the unnecessary dependency.
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory/core.c| 2
Hi Jan,
Thanks for your comments. I've just sent a v2.
Cheers,
Costin
On 8/10/21 9:41 AM, Jan Beulich wrote:
> On 09.08.2021 16:47, Costin Lupu wrote:
>> These changes introduce the page related definitions needed for mapping and
>> accessing guests memory. These values are
Hi Jan,
Please see inline.
On 8/20/21 9:52 AM, Jan Beulich wrote:
> On 19.08.2021 19:50, Costin Lupu wrote:
>> These changes introduce the page related definitions needed for mapping and
>> accessing guests memory. These values are intended to be used by any
>> toolstack
&g
use them it also
had to add a dependency for the xenctrl library.
This patch also introduces xen_mk_long() macrodefinition for defining long
constants both for C and assembler code.
Signed-off-by: Costin Lupu
---
xen/include/public/arch-arm.h | 8
xen/include/public/arch-x86/xen.h | 8
We use the values provided by the Xen public interface for defining the
XC_PAGE_* macros.
Signed-off-by: Costin Lupu
---
tools/include/xenctrl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h
index b77726eab7
xen.h headers
Costin Lupu (4):
public: Add page related definitions for accessing guests memory
libs/ctrl: Use Xen values for XC_PAGE_* definitions
libs/foreignmemory: Use XEN_PAGE_* definitions
libs/gnttab: Use XEN_PAGE_* definitions
tools/include/xenctrl.h| 6 +++---
tools
These changes refine the changes in d1b32abd which added a dependency to
xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_*
definitions and therefore we get rid of the unnecessary dependency.
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/Makefile | 2 ++
tools/libs
These changes refine the changes in 0dbb4be7 which added a dependency to
xenctrl library. We use the XEN_PAGE_* definitions instead of the XC_PAGE_*
definitions and therefore we get rid of the unnecessary dependency.
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory/Makefile | 2
Hi guys,
On 8/23/21 8:16 PM, Julien Grall wrote:
> Hi Jan,
>
> On 20/08/2021 10:26, Jan Beulich wrote:
>> On 20.08.2021 11:08, Julien Grall wrote:
>>> On 20/08/2021 08:44, Costin Lupu wrote:
>>>> On 8/20/21 9:52 AM, Jan Beulich wrote:
>>>>>>
When tboot is disabled via menuconfig we get undefined reference error for
g_tboot_shared. This patch fixes that by disabling the causing source code
when tboot is disabled.
Signed-off-by: Costin Lupu
---
xen/arch/x86/acpi/power.c | 4
1 file changed, 4 insertions(+)
diff --git a/xen/arch
On 4/29/21 3:40 PM, Jan Beulich wrote:
> On 29.04.2021 14:11, Costin Lupu wrote:
>> When tboot is disabled via menuconfig we get undefined reference error for
>> g_tboot_shared. This patch fixes that by disabling the causing source code
>> when tboot is disabled.
>
>
re defined.
Changes since v1:
- Use XC_PAGE_* macros instead of PAGE_* macros
Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error
tools/libfsimage: Fix PATH_MAX redefinition error
tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error
tools/libs/gnttab: Fix PAGE_SIZE re
If PATH_MAX is already defined in the system (e.g. in /usr/include/limits.h
header) then gcc will trigger a redefinition error because of -Werror.
Signed-off-by: Costin Lupu
Reviewed-by: Julien Grall
---
tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++
tools/libfsimage/reiserfs
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Signed-off-by: Costin Lupu
---
tools/debugger/kdd/kdd-xen.c | 15 ++-
tools/debugger/kdd/kdd.c | 21 ++---
2 files changed, 16 insertions(+), 20 deletions(-)
diff --git a/tools
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/freebsd.c | 28 +---
tools/libs/gnttab/linux.c | 28 +---
tools/libs/gnttab/netbsd.c | 23 ++-
3
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Same issue applies for redefinitions of Val_none and Some_val macros which
can be already defined in the OCaml system headers (e.g.
/usr/lib/ocaml/caml/mlvalues.h).
Signed-off-by: Costin Lupu
---
tools/ocaml/libs/xc
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory/core.c| 2 +-
tools/libs/foreignmemory/freebsd.c | 10 +-
tools/libs/foreignmemory/linux.c | 23 ---
tools/libs/foreignmemory
@Christian: This version is slightly changed, it uses XC_PAGE_* macros
instead of PAGE_* macros and that's why I didn't add your ack.
Cheers,
Costin
On 4/30/21 2:28 PM, Costin Lupu wrote:
> If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h
> heade
Hi Tim,
On 4/29/21 10:58 PM, Tim Deegan wrote:
> Hi,
>
> At 15:05 +0300 on 27 Apr (1619535916), Costin Lupu wrote:
>> If PAGE_SIZE is already defined in the system (e.g. in
>> /usr/include/limits.h header) then gcc will trigger a redefinition error
>> because o
On 4/30/21 9:45 PM, Tim Deegan wrote:
> At 14:36 +0300 on 30 Apr (1619793419), Costin Lupu wrote:
>> Hi Tim,
>>
>> On 4/29/21 10:58 PM, Tim Deegan wrote:
>>> Hi,
>>>
>>> At 15:05 +0300 on 27 Apr (1619535916), Costin Lupu wrote:
>>>> If P
re defined.
Changes since v1:
- Use XC_PAGE_* macros instead of PAGE_* macros
Changes since v2:
- Define KDD_PAGE_* macros for changes in debugger/kdd/
Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error
tools/libfsimage: Fix PATH_MAX redefinition error
tools/libs/foreignm
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory/core.c| 2 +-
tools/libs/foreignmemory/freebsd.c | 10 +-
tools/libs/foreignmemory/linux.c | 23 ---
tools/libs/foreignmemory
-by: Costin Lupu
---
tools/debugger/kdd/kdd-xen.c | 15 ++-
tools/debugger/kdd/kdd.c | 19 ---
tools/debugger/kdd/kdd.h | 7 +++
3 files changed, 21 insertions(+), 20 deletions(-)
diff --git a/tools/debugger/kdd/kdd-xen.c b/tools/debugger/kdd/kdd-xen.c
index
If PATH_MAX is already defined in the system (e.g. in /usr/include/limits.h
header) then gcc will trigger a redefinition error because of -Werror.
Signed-off-by: Costin Lupu
Reviewed-by: Julien Grall
---
tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++
tools/libfsimage/reiserfs
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/freebsd.c | 28 +---
tools/libs/gnttab/linux.c | 28 +---
tools/libs/gnttab/netbsd.c | 23 ++-
3
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Same issue applies for redefinitions of Val_none and Some_val macros which
can be already define in the OCaml system headers (e.g.
/usr/lib/ocaml/caml/mlvalues.h).
Signed-off-by: Costin Lupu
---
tools/ocaml/libs/xc
re defined.
Changes since v1:
- Use XC_PAGE_* macros instead of PAGE_* macros
Changes since v2:
- Define KDD_PAGE_* macros for changes in debugger/kdd/
Changes since v3:
- Use sysconf(_SC_PAGESIZE) instead of getpagesize()
Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error
tools/
-by: Costin Lupu
Reviewed-by: Tim Deegan
---
tools/debugger/kdd/kdd-xen.c | 15 ++-
tools/debugger/kdd/kdd.c | 19 ---
tools/debugger/kdd/kdd.h | 7 +++
3 files changed, 21 insertions(+), 20 deletions(-)
diff --git a/tools/debugger/kdd/kdd-xen.c b/tools
If PATH_MAX is already defined in the system (e.g. in /usr/include/limits.h
header) then gcc will trigger a redefinition error because of -Werror.
Signed-off-by: Costin Lupu
Reviewed-by: Julien Grall
---
tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++
tools/libfsimage/reiserfs
* definitions) and
guest domain page granularity.
The exception is in osdep_xenforeignmemory_map() where we need the system page
size to check whether the PFN array should be allocated with mmap() or with
dynamic allocation.
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory/core.c| 2 +-
tools
* definitions) and
guest domain page granularity.
The exception is in osdep_xenforeignmemory_map() where we need the system page
size to check whether the PFN array should be allocated with mmap() or with
dynamic allocation.
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/freebsd.c | 28
* definitions) and
guest domain page granularity (which is what we are dealing with here).
Same issue applies for redefinitions of Val_none and Some_val macros which
can be already define in the OCaml system headers (e.g.
/usr/lib/ocaml/caml/mlvalues.h).
Signed-off-by: Costin Lupu
Reviewed-by: Julien Grall
Hi Julien,
On 5/17/21 9:12 PM, Julien Grall wrote:
> Hi Costin,
>
> On 10/05/2021 09:35, Costin Lupu wrote:
>> @@ -168,7 +168,7 @@ void
>> *osdep_xenforeignmemory_map(xenforeignmemory_handle *fmem,
>> size_t i;
>> int rc;
>> - addr = mm
Hi Julien,
On 5/17/21 9:16 PM, Julien Grall wrote:
> Hi Costin,
>
> On 10/05/2021 09:35, Costin Lupu wrote:
>> If PAGE_SIZE is already defined in the system (e.g. in
>> /usr/include/limits.h
>> header) then gcc will trigger a redefinition error because of -Werror.
>
number of VMs (~1000 instances) running on the host.
Signed-off-by: Costin Lupu
---
tools/libs/light/libxl_create.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
index 0c64268f66..43e9ba9c63 100644
re defined.
Costin Lupu (5):
tools/debugger: Fix PAGE_SIZE redefinition error
tools/libfsimage: Fix PATH_MAX redefinition error
tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error
tools/libs/gnttab: Fix PAGE_SIZE redefinition error
tools/ocaml: Fix redefinition errors
tools/debugg
If PAGE_SIZE is already defined in the system (e.g. in
/usr/include/limits.h header) then gcc will trigger a redefinition error
because of -Werror. This commit also protects PAGE_SHIFT definitions for
keeping consistency.
Signed-off-by: Costin Lupu
---
tools/debugger/kdd/kdd-xen.c | 4
If PAGE_SIZE is already defined in the system (e.g. in
/usr/include/limits.h header) then gcc will trigger a redefinition error
because of -Werror. This commit also protects PAGE_SHIFT and PAGE_MASK
definitions for keeping consistency.
Signed-off-by: Costin Lupu
---
tools/libs/gnttab/linux.c
If PAGE_SIZE is already defined in the system (e.g. in
/usr/include/limits.h header) then gcc will trigger a redefinition error
because of -Werror. This commit also protects PAGE_SHIFT and PAGE_MASK
definitions for keeping consistency.
Signed-off-by: Costin Lupu
---
tools/libs/foreignmemory
macros which
can be already define in the OCaml system headers (e.g.
/usr/lib/ocaml/caml/mlvalues.h).
Signed-off-by: Costin Lupu
---
tools/ocaml/libs/xc/xenctrl_stubs.c| 8
tools/ocaml/libs/xentoollog/xentoollog_stubs.c | 4
tools/ocaml/libs/xl/xenlight_stubs.c
If PATH_MAX is already defined in the system (e.g. in /usr/include/limits.h
header) then gcc will trigger a redefinition error because of -Werror.
Signed-off-by: Costin Lupu
---
tools/libfsimage/ext2fs/fsys_ext2fs.c | 2 ++
tools/libfsimage/reiserfs/fsys_reiserfs.c | 2 ++
2 files changed
Hi Julien,
On 4/28/21 12:03 PM, Julien Grall wrote:
> Hi Costin,
>
> On 27/04/2021 13:05, Costin Lupu wrote:
>> tools/libs/foreignmemory/private.h | 6 --
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/libs/foreignmemory/privat
On 4/28/21 12:04 PM, Julien Grall wrote:
>
>
> On 27/04/2021 13:05, Costin Lupu wrote:
>> If PATH_MAX is already defined in the system (e.g. in
>> /usr/include/limits.h
>> header) then gcc will trigger a redefinition error because of -Werror.
>>
>> Signed
On 4/28/21 3:34 PM, Christian Lindig wrote:
>
>
>> On 27 Apr 2021, at 13:05, Costin Lupu > <mailto:costin.l...@cs.pub.ro>> wrote:
>>
>> For replication I used gcc 10.3 on an Alpine system. In order to
>> replicate the
>> redefinition error for P
64 matches
Mail list logo
