Re: [Xen-devel] [RFC XEN PATCH v4 01/41] x86_64/mm: fix the PDX group check in mem_hotadd_check()

2018-01-03 Thread Chao Peng
On Thu, 2017-12-07 at 18:09 +0800, Haozhong Zhang wrote: > The current check refuses the hot-plugged memory that falls in one > unused PDX group, which should be allowed. > Reviewed-by: Chao Peng > Signed-off-by: Haozhong Zhang > --- > Cc: Jan Beulich > Cc: Andrew Coop

Re: [Xen-devel] [RFC XEN PATCH v4 02/41] x86_64/mm: avoid cleaning the unmapped frame table

2018-01-03 Thread Chao Peng
On Thu, 2017-12-07 at 18:09 +0800, Haozhong Zhang wrote: > cleanup_frame_table() initializes the entire newly added frame table > to all -1's. If it's called after extend_frame_table() failed to map > the entire frame table, the initialization will hit a page fault. > > Move the cleanup of partial

Re: [Xen-devel] [RFC XEN PATCH v4 03/41] hvmloader/util: do not compare characters after '\0' in strncmp

2018-01-03 Thread Chao Peng
r]); > + > +if (!s1[ctr]) Coding style, but, the original code above has issue too. Besides this, Reviewed-by: Chao Peng > +break; > +} > + >  return 0; >  } >   ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel