Re: [PATCH 05/12] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2020-11-04 Thread Andrew Lunn
Cc: Jesper Dangaard Brouer > Cc: John Fastabend > Cc: Rusty Russell > Cc: xen-devel@lists.xenproject.org > Cc: net...@vger.kernel.org > Cc: b...@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks

2020-11-04 Thread Andrew Lunn
en-netfront.c:2313: warning: Function parameter or member > 'backend_state' not described in 'netback_changed' > commit 8ed7ec1386b646130d80d017ecd4716f866ea570 Author: Andrew Lunn Date: Sat Oct 31 19:04:35 2020 +0100 drivers: net: xen-netfront: Fixed W=1 set but unused warnings Already in net-next. Andrew

Re: [PATCH 2/8] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers

2020-11-29 Thread Andrew Lunn
Cc: Jesper Dangaard Brouer > Cc: John Fastabend > Cc: Rusty Russell > Cc: xen-devel@lists.xenproject.org > Cc: net...@vger.kernel.org > Cc: b...@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-12 Thread Andrew Lunn
On Thu, Mar 11, 2021 at 10:59:44PM +, ChiaHao Hsu wrote: > In order to support live migration of guests between kernels > that do and do not support 'feature-ctrl-ring', we add a > module parameter that allows the feature to be disabled > at run time, instead of using hardcode value. > The defa

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-12 Thread Andrew Lunn
On Fri, Mar 12, 2021 at 04:18:02PM +0100, Hsu, Chiahao wrote: > > Andrew Lunn 於 2021/3/12 15:52 寫道: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know >

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-21 Thread Andrew Lunn
> > At the end, it will be more granular module parameter that user still > > will need to guess. > I believe users always need to know any parameter or any tool's flag before > they use it. > For example, before user try to set/clear this ctrl_ring_enabled, they > should already have basic knowled