[Xen-devel] [PATCH 3/3] xen/rwlock: Include lib.h

2019-05-15 Thread Alistair Francis
Include lib.h to ensure that ASSERT() is defined. Signed-off-by: Alistair Francis --- xen/include/xen/rwlock.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/xen/rwlock.h b/xen/include/xen/rwlock.h index 35657c56c4..131537348e 100644 --- a/xen/include/xen/rwlock.h +++ b/xen

[Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs

2019-05-15 Thread Alistair Francis
Make the asm/vpl011.h dependent on the ARM architecture. Signed-off-by: Alistair Francis --- xen/drivers/char/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 9bbcb0f57a..f840d999bc 100644 --- a/xen

[Xen-devel] [PATCH 1/3] config.sub: Update config.sub to latest version

2019-05-15 Thread Alistair Francis
Signed-off-by: Alistair Francis --- config.sub | 2522 ++-- 1 file changed, 1269 insertions(+), 1253 deletions(-) diff --git a/config.sub b/config.sub index 6205f8423d..f53af5a2da 100755 --- a/config.sub +++ b/config.sub @@ -1,36 +1,31 @@ #! /bin

Re: [Xen-devel] [PATCH 1/3] config.sub: Update config.sub to latest version

2019-05-16 Thread Alistair Francis
On Thu, May 16, 2019 at 6:30 AM Wei Liu wrote: > > On Thu, May 16, 2019 at 03:18:19PM +0200, Olaf Hering wrote: > > Am Thu, 16 May 2019 12:39:02 +0100 > > schrieb Wei Liu : > > > > > autotools shipped in all the distros we care about > > > > I see autoconf 2.69 is available practically everywhere,

Re: [Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs

2019-05-16 Thread Alistair Francis
On Thu, May 16, 2019 at 3:32 AM Jan Beulich wrote: > > >>> On 16.05.19 at 02:02, wrote: > > Make the asm/vpl011.h dependent on the ARM architecture. > > But we only have x86 and Arm right now. A word more about > your motivation would help. As the code currently is no one can add another archite

Re: [Xen-devel] [PATCH 1/3] config.sub: Update config.sub to latest version

2019-05-16 Thread Alistair Francis
On Thu, May 16, 2019 at 3:31 AM Jan Beulich wrote: > > >>> On 16.05.19 at 02:02, wrote: > > Signed-off-by: Alistair Francis > > At least to me it is far from obvious why we would want/need to > do this update, or where the canonical "latest version" liv

Re: [Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs

2019-05-17 Thread Alistair Francis
On Fri, May 17, 2019 at 1:46 AM Julien Grall wrote: > > > > On 16/05/2019 20:30, Alistair Francis wrote: > > On Thu, May 16, 2019 at 3:32 AM Jan Beulich wrote: > >> > >>>>> On 16.05.19 at 02:02, wrote: > >>> Make the asm/vpl011.h dependen

Re: [Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs

2019-05-17 Thread Alistair Francis
On Thu, May 16, 2019 at 11:26 PM Jan Beulich wrote: > > >>> On 16.05.19 at 21:30, wrote: > > On Thu, May 16, 2019 at 3:32 AM Jan Beulich wrote: > >> > >> >>> On 16.05.19 at 02:02, wrote: > >> > Make the asm/vpl011.h dependent on the ARM architecture. > >> > >> But we only have x86 and Arm right

Re: [Xen-devel] [PATCH 1/3] config.sub: Update config.sub to latest version

2019-05-17 Thread Alistair Francis
On Fri, May 17, 2019 at 9:38 AM Wei Liu wrote: > > On Thu, May 16, 2019 at 12:27:19PM -0700, Alistair Francis wrote: > > On Thu, May 16, 2019 at 6:30 AM Wei Liu wrote: > > > > > > On Thu, May 16, 2019 at 03:18:19PM +0200, Olaf Hering wrote: > > &g

Re: [Xen-devel] [PATCH v2 2/2] autotools: Remove the configure script and just use autoconf

2019-05-20 Thread Alistair Francis
On Mon, May 20, 2019 at 1:05 AM Jan Beulich wrote: > > >>> On 18.05.19 at 00:31, wrote: > > Don't hardcode old versions of configure in the source code, instead > > let's just use autoconf to generate them. > > > > Signed-off-by: Alistair Francis

[Xen-devel] [PATCH v2] xen/drivers/char: Don't require vpl011 for all non-x86 archs

2019-05-20 Thread Alistair Francis
Make the asm/vpl011.h dependent on the CONFIG_SBSA_VUART_CONSOLE define. Signed-off-by: Alistair Francis --- xen/drivers/char/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 9bbcb0f57a..24287e59cb 100644

[Xen-devel] [PATCH v3] xen/drivers/char: Protect the asm/vpl011.h include

2019-05-21 Thread Alistair Francis
The only use of asm/vpl011.h is protected by the CONFIG_SBSA_VUART_CONSOLE define so lets protect the include as well. Signed-off-by: Alistair Francis --- v3: - Rework commit title and message - Split it into a seperate ifdef xen/drivers/char/console.c | 3 ++- 1 file changed, 2

[Xen-devel] [PATCH] gitignore: Ignore xen.lds and asm-offsets.s for all archs

2019-05-23 Thread Alistair Francis
Instead of ignoring xen.lds and asm-offsets.s for every specific arch, let's instead just use gitignore's wildcard feature to ignore them for all archs. Signed-off-by: Alistair Francis --- .gitignore | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.g

Re: [Xen-devel] [PATCH v3 14/41] hw/display: Use the BYTE-based definitions

2018-04-16 Thread Alistair Francis
ned-off-by: Philippe Mathieu-Daudé > Reviewed-by: Gerd Hoffmann Reviewed-by: Alistair Francis Alistair > --- > include/hw/display/xlnx_dp.h | 5 +++-- > hw/display/cirrus_vga.c | 10 +- > hw/display/g364fb.c | 3 ++- > hw/display/qxl.c |

Re: [Xen-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report

2018-04-24 Thread Alistair Francis
C: Michael Tokarev > CC: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > v7: New patch > --- > os-posix.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/os-posix.c b/os-posix.c

Re: [Xen-devel] [RFC XEN PATCH 00/23] xen: beginning support for RISC-V

2020-01-23 Thread Alistair Francis
On Wed, 2020-01-22 at 14:57 +, Andrew Cooper wrote: > On 22/01/2020 01:58, Bobby Eshleman wrote: > > Hey everybody, > > > > This is an RFC patchset for the very beginnings of adding RISC-V > > support > > to Xen. This RFC is really just to start a dialogue about > > supporting > > RISC-V and

Re: [PATCH v2 5/7] docs: move generic-loader documentation into the main manual

2021-02-12 Thread Alistair Francis
nnée > Message-Id: <20201105175153.30489-6-alex.ben...@linaro.org> Reviewed-by: Alistair Francis Alistair > > --- > v2 > - fix whitespace > - update MAINTAINERS > --- > docs/generic-loader.txt| 92 -- > docs/system/generic-loader.

Re: [PATCH v2 6/7] docs: add some documentation for the guest-loader

2021-02-12 Thread Alistair Francis
On Thu, Feb 11, 2021 at 9:20 AM Alex Bennée wrote: > > Signed-off-by: Alex Bennée > Message-Id: <20201105175153.30489-7-alex.ben...@linaro.org> Reviewed-by: Alistair Francis Alistair > > --- > v2 > - add docs and MAINTAINERS > --- >

Re: [RFC XEN PATCH 00/23] xen: beginning support for RISC-V

2020-06-15 Thread Alistair Francis
st, begin discussing > > what Xen > > on RISC-V may look like, receive feedback, and see if I'm heading > > in the > > right direction. > > > > My big questions are: > > Does the Xen project have interest in RISC-V? > > What can be done t

Re: [PATCH 08/26] hw/usb/hcd-dwc2: Restrict 'dwc2-regs.h' scope

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé wrote: > > We only use these register definitions in files under the > hw/usb/ directory. Keep that header local by moving it there. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair >

Re: [PATCH 01/26] hw/arm/sbsa-ref: Remove unused 'hw/usb.h' header

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:51 AM Philippe Mathieu-Daudé wrote: > > This file doesn't access anything from "hw/usb.h", remove its > inclusion. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/arm/sbsa-ref.c

Re: [PATCH 02/26] hw/ppc/sam460ex: Add missing 'hw/pci/pci.h' header

2020-07-06 Thread Alistair Francis
> ‘PCI_DEVFN’ [-Werror=implicit-function-declaration] > 397 | pci_create_simple(pci_bus, PCI_DEVFN(6, 0), "sm501"); > |^ > hw/ppc/sam460ex.c:397:32: error: nested extern declaration of ‘PCI_DEVFN’ > [-Werror=nested-externs] > &g

Re: [PATCH 03/26] hw/usb: Remove unused VM_USB_HUB_SIZE definition

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:50 AM Philippe Mathieu-Daudé wrote: > > Commit a5d2f7273c ("qdev/usb: make qemu aware of usb busses") > removed the last use of VM_USB_HUB_SIZE, 11 years ago. Time > to drop it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [PATCH 04/26] hw/usb: Reduce 'exec/memory.h' inclusion

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:52 AM Philippe Mathieu-Daudé wrote: > > "exec/memory.h" is only required by "hw/usb/hcd-musb.h". > Include it there directly. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > include/

Re: [PATCH 06/26] hw/usb/hcd-dwc2: Remove unnecessary includes

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé wrote: > > "qemu/error-report.h" and "qemu/main-loop.h" are not used. > Remove them. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/hcd-dwc

Re: [PATCH 05/26] hw/usb/desc: Add missing header

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:52 AM Philippe Mathieu-Daudé wrote: > > This header uses the USBPacket and USBDevice types which are > forward declared in "hw/usb.h". > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/de

Re: [PATCH 07/26] hw/usb/hcd-dwc2: Restrict some headers to source

2020-07-06 Thread Alistair Francis
ource file which is the only one requiring the > function declarations. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/hcd-dwc2.h | 3 --- > hw/usb/hcd-dwc2.c | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [PATCH 09/26] hw/usb/hcd-ehci: Remove unnecessary include

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:55 AM Philippe Mathieu-Daudé wrote: > > As "qemu/main-loop.h" is not used, remove it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/hcd-ehci.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH 11/26] hw/usb/hcd-xhci: Add missing header

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:54 AM Philippe Mathieu-Daudé wrote: > > This header uses the USBPort type which is forward declared > by "hw/usb.h". > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/hcd-xhci.h | 2 ++

Re: [PATCH 12/26] hw/usb/hcd-musb: Restrict header scope

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:56 AM Philippe Mathieu-Daudé wrote: > > "hcd-musb.h" is only required by USB device implementions. > As we keep these implementations in the hw/usb/ directory, > move the header there. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

Re: [PATCH 10/26] hw/usb/hcd-ehci: Move few definitions from header to source

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:53 AM Philippe Mathieu-Daudé wrote: > > Move definitions only useful for hcd-ehci.c to this source file. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/hcd-ehci.h | 11 --- > h

Re: [PATCH 13/26] hw/usb/desc: Reduce some declarations scope

2020-07-06 Thread Alistair Francis
ot; header a bit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/desc.h| 10 ++ > include/hw/usb.h | 10 -- > hw/usb/bus.c | 1 + > 3 files changed, 11 insertions(+), 10 deletions(-) > >

Re: [PATCH 14/26] hw/usb/quirks: Rename included source with '.inc.c' suffix

2020-07-06 Thread Alistair Francis
t; > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/quirks.c | 2 +- > hw/usb/{quirks.h => quirks.inc.c} | 5 - > 2 files changed, 1 insertion(+), 6 deletions(-) > rename hw/usb/{quirks.h => quirks.in

Re: [PATCH 15/26] hw/usb: Add new 'usb-quirks.h' local header

2020-07-06 Thread Alistair Francis
ned-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/usb-quirks.h | 27 +++ > include/hw/usb.h| 11 --- > hw/usb/quirks.c | 1 + > hw/usb/redirect.c | 1 + > 4 files changed, 29 insertions(+), 11

Re: [PATCH 17/26] hw/usb/bus: Rename usb_get_dev_path() as usb_get_full_dev_path()

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:58 AM Philippe Mathieu-Daudé wrote: > > If the device has USB_DEV_FLAG_FULL_PATH set, usb_get_dev_path() > returns the full port path. Rename the function accordingly. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair

Re: [PATCH 16/26] hw/usb/bus: Simplify usb_get_dev_path()

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 8:00 AM Philippe Mathieu-Daudé wrote: > > Simplify usb_get_dev_path() a bit. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > hw/usb/bus.c | 19 +-- > 1 file changed, 9 insertions(+), 10

Re: [PATCH 19/26] hw/ppc/spapr: Use usb_get_port_path()

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 7:59 AM Philippe Mathieu-Daudé wrote: > > To avoid to access the USBDevice internals, and use the > recently added usb_get_port_path() helper instead. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH 18/26] hw/usb/bus: Add usb_get_port_path()

2020-07-06 Thread Alistair Francis
On Sat, Jul 4, 2020 at 8:00 AM Philippe Mathieu-Daudé wrote: > > Refactor usb_get_full_dev_path() to take a 'want_full_path' > argument, and add usb_get_port_path() which returns a short > path. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis

Xen and RISC-V Design Session

2020-07-08 Thread Alistair Francis
Hey, I'm not sure if there is a better way to suggest a design session but can we have a Xen on RISC-V discussion tomorrow at the Xen Design Summit? Preferably in a later slot as the early slots are very early for me. Alistair

Re: Xen and RISC-V Design Session

2020-07-08 Thread Alistair Francis
On Wed, Jul 8, 2020 at 6:11 AM Roger Pau Monné wrote: > > Adding George in case he can help with the session placement. > > On Wed, Jul 08, 2020 at 05:55:06AM -0700, Alistair Francis wrote: > > Hey, > > > > I'm not sure if there is a better way to suggest a d

Re: Xen and RISC-V Design Session

2020-07-08 Thread Alistair Francis
On Wed, Jul 8, 2020 at 6:21 AM George Dunlap wrote: > > > > > On Jul 8, 2020, at 2:11 PM, Alistair Francis wrote: > > > > On Wed, Jul 8, 2020 at 6:11 AM Roger Pau Monné wrote: > >> > >> Adding George in case he can help with the session placement.

Re: Xen and RISC-V Design Session

2020-07-08 Thread Alistair Francis
On Wed, Jul 8, 2020 at 8:10 AM Stefano Stabellini wrote: > > On Wed, 8 Jul 2020, Bobby Eshleman wrote: > > On Wed, Jul 08, 2020 at 06:20:47AM -0700, Alistair Francis wrote: > > > > > > Thanks! Just submitted the proposal. > > > > > > It would be rea

Re: [RFC PATCH v2 02/16] qapi: Implement query-machine-phase QMP command

2021-10-12 Thread Alistair Francis
On Thu, Sep 23, 2021 at 2:20 AM Damien Hedde wrote: > > From: Mirela Grujic > > The command returns current machine initialization phase. > From now on, the MachineInitPhase enum is generated from the > QAPI schema. > > Signed-off-by: Mirela Grujic Acked-by: Ali

Re: [RFC PATCH v2 00/16] Initial support for machine creation via QMP

2021-10-12 Thread Alistair Francis
On Thu, Sep 23, 2021 at 2:22 AM Damien Hedde wrote: > > Hi, > > The goal of this work is to bring dynamic machine creation to QEMU: > we want to setup a machine without compiling a specific machine C > code. It would ease supporting highly configurable platforms (for > example resulting from an au

Re: [RFC PATCH v2 03/16] qapi: Implement x-machine-init QMP command

2021-10-12 Thread Alistair Francis
initialized phase and wait > for the QMP configuration. In future commits, we will add the possiblity > to create devices at this point. > > To exit the initialized phase use the x-exit-preconfig QMP command. > > Signed-off-by: Mirela Grujic Acked-by: Alistair Francis Al

Re: [RFC PATCH v2 06/16] qapi: Allow device_add to execute in machine initialized phase

2021-10-12 Thread Alistair Francis
s registered. > > Signed-off-by: Mirela Grujic Acked-by: Alistair Francis Alistair > --- > > The commit is fine, but we may add intermediate commits before this one > in order to add or change the condition for a device type to be accepted > in the 'initialized' st

Re: [RFC PATCH v2 08/16] qdev-monitor: Check sysbus device type before creating it

2021-10-12 Thread Alistair Francis
heck was done well after the device has > been created (in a machine init done notifier). We can now report > the error right away. > > Signed-off-by: Damien Hedde Reviewed-by: Alistair Francis Alistair > --- > softmmu/qdev-monitor.c | 11 +++ > 1 file changed, 11

Re: [RFC PATCH v2 09/16] hw/core/machine: Remove the dynamic sysbus devices type check

2021-10-12 Thread Alistair Francis
ese containers manually (eg in > machine C code), these will not be checked anymore. > This use case does not seem to appear apart from > hw/xen/xen-legacy-backend.c (it uses qdev_set_id() and in this case, > not for a sysbus device, so it's ok). > > Signed-off-by: Damien Hedde Ac

Re: [RFC PATCH v2 04/16] softmmu/qdev-monitor: add error handling in qdev_set_id

2021-10-13 Thread Alistair Francis
t parameter. > > Note that the id is, right now, guaranteed to be unique because > all ids came from the "device" QemuOptsList where the id is used > as key. This addition is a preparation for a future commit which > will relax the uniqueness. > > Signed-off-by: Damien

Re: [RFC PATCH v2 11/16] softmmu/memory: add memory_region_try_add_subregion function

2021-10-13 Thread Alistair Francis
; to do the simple memory_region_add_subregion() (with no overlap) by > setting the priority parameter to 0. > > This commit is a preparation to further use this function in the > context of qmp command which needs error handling support. > > Signed-off-by: Damien Hedde Revi

Re: [RFC PATCH v2 12/16] add x-sysbus-mmio-map qmp command

2021-10-13 Thread Alistair Francis
function and > requires the use of memory region aliases). I think as is this is a good start. This is a useful feature! > > Signed-off-by: Damien Hedde Acked-by: Alistair Francis > --- > > Note: this qmp command is required to be able to build a machine from > scratch as

Re: Arch-neutral name for hardware interrupt support

2021-11-02 Thread Alistair Francis
On Tue, Nov 2, 2021 at 6:33 AM Stefano Stabellini wrote: > > +Bertrand > > On Mon, 1 Nov 2021, Andrew Cooper wrote: > > Hello, > > > > On ARM, the GIC is a hard prerequisite for VMs. > > > > I can't remember what the state of RISCV is, but IIRC there is still > > some debate over how interrupts ar

Re: [PATCH 1/9] hw/riscv/sifive_e: Fix inheritance of SiFiveEState

2022-09-19 Thread Alistair Francis
eEState to inherit from MachineState since it is registered > as a machine. > > Signed-off-by: Bernhard Beschow Reviewed-by: Alistair Francis Alistair > --- > include/hw/riscv/sifive_e.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/hw

Re: [PATCH v4 2/4] xen/riscv: introduce sbi call to putchar to console

2023-01-17 Thread Alistair Francis
; > The patch introduces sbi_putchar() SBI call which is necessary > to implement initial early_printk. > > Signed-off-by: Bobby Eshleman > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V4: > - Nothing changed > --- > Changes

Re: [PATCH v4 4/4] automation: add RISC-V smoke test

2023-01-17 Thread Alistair Francis
On Tue, Jan 17, 2023 at 12:40 AM Oleksii Kurochko wrote: > > Add check if there is a message 'Hello from C env' presents > in log file to be sure that stack is set and C part of early printk > is working. > > Signed-off-by: Oleksii Kurochko > Acked-by: Stefano Sta

Re: [PATCH v5 2/5] xen/riscv: introduce asm/types.h header file

2023-01-19 Thread Alistair Francis
On Fri, Jan 20, 2023 at 12:07 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V5: > - Remove size_t from asm/types after rebase on top of the patch > "include/types: move stddef

Re: [PATCH v1 02/14] xen/riscv: add header

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:00 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/include/asm/asm.h | 54 > 1 file changed, 54 insertions(+) > create mode 100644 xen/

Re: [PATCH v1 03/14] xen/riscv: add

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:01 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/include/asm/riscv_encoding.h | 945 > 1 file changed, 945 insertions(+) > create mode 100644 xen/

Re: [PATCH v1 04/14] xen/riscv: add header

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:00 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/include/asm/csr.h | 82 > 1 file changed, 82 insertions(+) > create mode 100644 xen/

Re: [PATCH v1 07/14] xen/riscv: introduce exception handlers implementation

2023-01-22 Thread Alistair Francis
i Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/Makefile| 2 + > xen/arch/riscv/entry.S | 97 ++ > xen/arch/riscv/include/asm/traps.h | 13 > xen/arch/riscv/traps.c | 13 +++

Re: [PATCH v1 08/14] xen/riscv: introduce decode_cause() stuff

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:00 AM Oleksii Kurochko wrote: > > The patch introduces stuff needed to decode a reason of an > exception. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/traps.c | 88 ++

Re: [PATCH v1 09/14] xen/riscv: introduce do_unexpected_trap()

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:00 AM Oleksii Kurochko wrote: > > The patch introduces the function the purpose of which is to print > a cause of an exception and call "wfi" instruction. > > Signed-off-by: Oleksii Kurochko > --- > xen/arch/riscv/traps.c | 14 +- > 1 file changed, 13 insert

Re: [PATCH v1 10/14] xen/riscv: mask all interrupts

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:00 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/riscv64/head.S | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/xen/arch/riscv/riscv64/head.S b/x

Re: [PATCH v1 11/14] xen/riscv: introduce setup_trap_handler()

2023-01-22 Thread Alistair Francis
On Sat, Jan 21, 2023 at 1:00 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/setup.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/xen/arch/riscv/setup.c b/xen/arch/

Re: [RISC-V] Switch to H-mode

2023-01-23 Thread Alistair Francis
On Mon, 2023-01-23 at 18:56 +0200, Oleksii wrote: > Hi Alistair and community, > > I am working on RISC-V support upstream for Xen based on your and > Bobby > patches. > > Adding the RISC-V support I realized that Xen is ran in S-mode. > Output > of OpenSBI: >     ... >     Domain0 Next Mode 

Re: [RISC-V] Switch to H-mode

2023-01-23 Thread Alistair Francis
On Tue, Jan 24, 2023 at 9:09 AM Andrew Cooper wrote: > > On 19/01/2023 1:05 pm, Bobby Eshleman wrote: > > On Mon, Jan 23, 2023 at 06:56:19PM +0200, Oleksii wrote: > >> Hi Alistair and community, > >> > >> I am working on RISC-V support upstream for Xen based on your and Bobby > >> patches. > >> >

Re: [PATCH v2 04/14] xen/riscv: add header

2023-01-30 Thread Alistair Francis
bf0250de > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V2: > - Minor refactoring mentioned in the commit message, switch tabs to > spaces and refactor things around __asm__ __volatile__. > - Update the commit message a

Re: [PATCH v2 03/14] xen/riscv: add

2023-01-30 Thread Alistair Francis
t32_t > > Originally authored by Anup Patel > > Origin: https://github.com/riscv-software-src/opensbi.git c45992cc2b12 > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V2: > - Take the latest version of riscv_encoding.h from OpenSB

Re: [PATCH v2 01/14] xen/riscv: add _zicsr to CFLAGS

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > Work with some registers requires csr command which is part of > Zicsr. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V2: > - Nothing changed > --- &g

Re: [PATCH v2 02/14] xen/riscv: add header

2023-01-30 Thread Alistair Francis
On Fri, Jan 27, 2023 at 11:59 PM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V2: > - Nothing changed > --- > xen/arch/riscv/include/asm/asm.h | 54 > 1 fil

Re: [PATCH v2 05/14] xen/riscv: introduce empty

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > To include is required > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V2: > - is a new empty header which is required to include > > --- > xen/a

Re: [PATCH v2 06/14] xen/riscv: introduce empty

2023-01-30 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko wrote: > > To include is required > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V2: > - is a new empty header which is required to include > > --- > xen/

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: > > Hi Alistair, Bobby and community, > > I would like to ask your help with the following check: > +/* > + * early_*() can be called from head.S with MMU-off. > + * > + * The following requiremets should be honoured for early_*() to > + * work corre

Re: [PATCH v1 01/14] xen/riscv: add _zicsr to CFLAGS

2023-01-31 Thread Alistair Francis
On Mon, Jan 23, 2023 at 8:43 PM Oleksii wrote: > > On Fri, 2023-01-20 at 15:29 +, Andrew Cooper wrote: > > On 20/01/2023 2:59 pm, Oleksii Kurochko wrote: > > > Work with some registers requires csr command which is part of > > > Zicsr. > > > > > > Signed-off-by: Oleksii Kurochko > > > --- > >

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Alistair Francis
On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: > > > > On 31/01/2023 11:44, Alistair Francis wrote: > > On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: > >> > >> Hi Alistair, Bobby and community, > >> > >> I would like to ask your h

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-02-04 Thread Alistair Francis
On Thu, Feb 2, 2023 at 3:34 AM Bobby Eshleman wrote: > > On Wed, Feb 01, 2023 at 09:06:21AM +, Julien Grall wrote: > > Hi Andrew, > > > > On 01/02/2023 00:21, Andrew Cooper wrote: > > > On 31/01/2023 11:17 pm, Alistair Francis wrote: > > > >

Re: Ping: [PATCH] tools/symbols: drop asm/types.h inclusion

2023-02-06 Thread Alistair Francis
lude their entire bodies when __ASSEMBLY__ was defined. > > Hence, with no other assembly files including this header, we can at the > > same time get rid of those conditionals. > > > > Signed-off-by: Jan Beulich Reviewed-by: Alistair Francis Alistair > > May I please ask

Re: [PATCH v3 02/14] xen/riscv: add header

2023-02-08 Thread Alistair Francis
On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Nothing changed > --- > xen/arc

Re: [PATCH v3 04/14] xen/riscv: add header

2023-02-08 Thread Alistair Francis
x/kernel/git/torvalds/linux.git/ > d2d11f342b17 > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Update origin to https://git.kernel.org/... > --- > Changes in V2: > - Minor refactoring mentioned in the commit message, sw

Re: [PATCH v3 14/14] automation: modify RISC-V smoke test

2023-02-08 Thread Alistair Francis
On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > The patch modifies the grep pattern to reflect the usage of WARN. > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Update commit message > --- > Cha

Re: [PATCH v3 13/14] xen/riscv: test basic handling stuff

2023-02-08 Thread Alistair Francis
On Wed, Feb 8, 2023 at 12:47 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Nothing changed > --- > xen/arch/riscv/setup.c | 16

Re: [PATCH v3 07/14] xen/riscv: introduce exception context

2023-02-08 Thread Alistair Francis
02e > --- /dev/null > +++ b/xen/arch/riscv/include/asm/processor.h > @@ -0,0 +1,83 @@ > +/* SPDX-License-Identifier: MIT */ > +/** > + * > + * Copyright 2019 (C) Alistair Francis > + * Copyright 2021 (C) Bobby Eshleman > + * Copyright 2023 (C) Vates > + * > + */ > + > +#ifndef _AS

Re: [PATCH v10 1/2] xen/riscv: introduce early_printk basic stuff

2023-02-08 Thread Alistair Francis
ation > it is used temporarily now and will be removed or reworked after > real uart will be ready. > > Signed-off-by: Bobby Eshleman > Signed-off-by: Oleksii Kurochko > Reviewed-by: Bobby Eshleman Reviewed-by: Alistair Francis Alistair > --- > Changes in V10: >

Re: [PATCH] riscv: add temporary riscv64_defconfig alias

2023-02-09 Thread Alistair Francis
just like other arches have. > > Signed-off-by: Jan Beulich Acked-by: Alistair Francis Alistair > --- > xen/arch/riscv/configs/riscv64_defconfig | 1 + > 1 file changed, 1 insertion(+) > create mode 12 xen/arch/riscv/configs/riscv64_defconfig > > diff --git a/xen/ar

Re: [PATCH v3 08/14] xen/riscv: introduce exception handlers implementation

2023-02-09 Thread Alistair Francis
i Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Refactor entry.S to start using of defines introduced in asm_offsets.C > - Rename {__,}handle_exception to handle_trap() and do_trap() to

Re: [PATCH v3 09/14] xen/riscv: introduce decode_cause() stuff

2023-02-09 Thread Alistair Francis
On Wed, Feb 8, 2023 at 12:48 AM Oleksii Kurochko wrote: > > The patch introduces stuff needed to decode a reason of an > exception. > > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - Nothing changed > --- > Changes in V2: > - Make decode_trap_cause() more optimization friendly. >

Re: [PATCH] xen/riscv: Fix early_puts() newline handling

2023-03-15 Thread Alistair Francis
On Thu, Mar 16, 2023 at 5:03 AM Andrew Cooper wrote: > > OpenSBI already expands \n to \r\n. Don't repeat the expansion, as it doubles > the size of the resulting log with every other line being blank. > > Signed-off-by: Andrew Cooper Reviewed-by: Alistair Francis Alist

Re: [PATCH] ARM+RISC-V: BSS handling improvements

2023-04-04 Thread Alistair Francis
On Sat, Mar 25, 2023 at 8:25 AM Andrew Cooper wrote: > > * Correct comments in arm{32,64}/head.S > * Provide Linker assertions to check the safety of the zeroing loops > > Signed-off-by: Andrew Cooper Acked-by: Alistair Francis Alistair > --- > CC: Stefano Stabellin

Re: [XEN PATCH v6 31/31] build,riscv: tell the build system about riscv64/head.S

2021-07-01 Thread Alistair Francis
scv/riscv64/head.o > > Signed-off-by: Anthony PERARD Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/riscv64/Makefile | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 xen/arch/riscv/riscv64/Makefile > > diff --git a/xen/arch/riscv/riscv64/Makefi

Re: [XEN PATCH v1 1/4] arch/riscv: initial RISC-V support to build/run minimal Xen

2022-12-27 Thread Alistair Francis
On Mon, Dec 26, 2022 at 9:14 PM Oleksii wrote: > > Hi Julien, > > Thanks for your comments. > > On Fri, 2022-12-23 at 13:50 +, Julien Grall wrote: > > Hi Oleksii, > > > > + Anthony for the Makefile changes. > > > > On 23/12/2022 11:16, Oleksii Kurochko wrote: > > > The patch provides a minimal

Re: [XEN PATCH v1 4/4] automation: add RISC-V 64 cross-build tests for Xen

2022-12-27 Thread Alistair Francis
On Fri, Dec 23, 2022 at 9:17 PM Oleksii Kurochko wrote: > > Add build jobs to cross-compile Xen-only for RISC-V 64. > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > automation/gitlab-ci/build.yaml | 43 + >

[PATCH] xen: define PADDR_BITS for riscv

2022-12-27 Thread Alistair Francis
From: Alistair Francis Define PADDR_BITS and PAGE_SHIFT for the RISC-V 64-bit architecture. Signed-off-by: Alistair Francis --- xen/arch/riscv/include/asm/page-bits.h | 7 +++ 1 file changed, 7 insertions(+) create mode 100644 xen/arch/riscv/include/asm/page-bits.h diff --git a/xen/arch

Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-09 Thread Alistair Francis
On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko wrote: > > The patch introduces a basic stuff of early_printk functionality > which will be enough to print 'hello from C environment". > early_printk() function was changed in comparison with original as > common isn't being built now so there is n

Re: [PATCH v2 7/8] xen/riscv: print hello message from C env

2023-01-09 Thread Alistair Francis
On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > xen/arch/riscv/riscv64/head.S | 4 +--- > xen/arch/riscv/setup.c| 12 > 2 files changed, 13 insertions(+), 3 del

Re: [PATCH v2 6/8] xen/riscv: introduce early_printk basic stuff

2023-01-10 Thread Alistair Francis
On Tue, Jan 10, 2023 at 5:29 PM Bobby Eshleman wrote: > > > > On Mon, Jan 9, 2023 at 4:28 PM Alistair Francis wrote: >> >> On Tue, Jan 10, 2023 at 1:47 AM Oleksii Kurochko >> wrote: >> > >> > The patch introduces a basic stuff of early_printk

Re: [PATCH v3 3/6] xen/riscv: introduce stack stuff

2023-01-10 Thread Alistair Francis
On Wed, Jan 11, 2023 at 1:18 AM Oleksii Kurochko wrote: > > The patch introduces and sets up a stack in order to go to C environment > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V3: > - reorder headers in alphabetica

Re: [PATCH] xen: Remove the arch specific header init.h

2023-01-11 Thread Alistair Francis
n empty header. > > Suggested-by: Jan Beulich > Signed-off-by: Julien Grall Acked-by: Alistair Francis Alistair > > --- > cc: Oleksii Kurochko > --- > xen/arch/arm/arm32/asm-offsets.c | 1 + > xen/arch/arm/arm64/asm-offsets.c | 1 + > xen/arch/arm/include/asm/ini

Re: [PATCH v2 0/5] Minimal build for RISCV

2021-05-13 Thread Alistair Francis
On Fri, May 14, 2021 at 2:18 PM Connor Davis wrote: > > Hi all, > > This series introduces a minimal build for RISCV. It is based on Bobby's > previous work from last year[0]. I have worked to rebase onto current Xen, > as well as update the various header files borrowed from Linux. > > This serie

Re: [PATCH v3 1/5] xen/char: Default HAS_NS16550 to y only for X86 and ARM

2021-05-16 Thread Alistair Francis
On Sat, May 15, 2021 at 4:54 AM Connor Davis wrote: > > Defaulting to yes only for X86 and ARM reduces the requirements > for a minimal build when porting new architectures. > > Signed-off-by: Connor Davis Reviewed-by: Alistair Francis Alistair > --- > xen/drivers/cha

Re: [PATCH v4 3/4] xen: Add files needed for minimal riscv build

2021-06-03 Thread Alistair Francis
On Tue, Jun 1, 2021 at 12:26 PM Connor Davis wrote: > > > > On 5/25/21 12:13 PM, Bob Eshleman wrote: > > On 5/25/21 1:48 AM, Jan Beulich wrote: > >> On 24.05.2021 16:34, Connor Davis wrote: > >>> Add arch-specific makefiles and configs needed to build for > >>> riscv. Also add a minimal head.S tha

  1   2   >