Re: [Xen-devel] [PATCH v2 09/11] docs: Fix some broken references

2018-05-09 Thread Alan Stern
nel Documentation, if needed in the future, > without messing with local x non-local relative namespace. How about changing the relative references so that something like Documentation/recipes.txt becomes ./Documentation/recipes.txt? Alan Stern ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v0 00/42] notifiers: Return an error when callback is already registered

2021-11-08 Thread Alan Stern
blem occurs when a notifier callback is added twice, not when a caller fails to check the return code. Double-registration is not the sort of thing that can be detected at build time. Alan Stern > Due to the sheer volume of the patches, I have addressed the respective > patch and the last

Re: [PATCH v0 42/42] notifier: Return an error when callback is already registered

2021-11-08 Thread Alan Stern
ue. Given the current state of affairs, I vote in favor of 1 (plus a WARN or something similar to generate a stack dump in the callee, since double registration really is a bug). Alan Stern

Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control()

2023-08-06 Thread Alan Stern
t; case USB_PORT_FEAT_SUSPEND: > > > break; > > > case USB_PORT_FEAT_POWER: > > > r8a66597_port_power(r8a66597, port, 0); > > > break; > > > case USB_PORT_FEAT_C_ENABLE: > > > case USB_PORT_FEAT_C_SUSPEND: > > > case USB_PORT_FEAT_C_CONNECTION: > > > case USB_PORT_FEAT_C_OVER_CURRENT: > > > case USB_PORT_FEAT_C_RESET: > > > break; > > > default: > > > goto error; > > > } > > > rh->port &= ~(1 << wValue); > > > > Hi there. I apologize for reaching out once more. I'm feeling a bit puzzled > > about what my next step should be. I'm unsure whether I should rewrite this > > patch or attempt to address the issue at the caller level. > > Try addressing it at the caller level first please. If that somehow > does not work, then we will take a patch series that fixes all of the > host controller drivers at once. It's not feasible to fix all the callers, because the calls can come from userspace via usbfs. Alan Stern

Re: [PATCH] xen: fix potential shift out-of-bounds in xenhcd_hub_control()

2023-08-08 Thread Alan Stern
On Tue, Aug 08, 2023 at 10:26:38AM +0200, Greg KH wrote: > On Sun, Aug 06, 2023 at 11:15:51AM -0400, Alan Stern wrote: > > On Sun, Aug 06, 2023 at 04:27:27PM +0200, Greg KH wrote: > > > On Sun, Aug 06, 2023 at 10:11:43PM +0800, Zhang Shurong wrote: > > > > 在 202