Re: [PATCH] xen/netfront: Fix TX response spurious interrupts

2025-07-11 Thread Elliott Mitchell
On Fri, Jul 11, 2025 at 07:41:02AM +, Anthoine Bourgeois wrote: > On Thu, Jul 10, 2025 at 01:05:47PM -0700, Elliott Mitchell wrote: > >On Thu, Jul 10, 2025 at 04:11:15PM +, Anthoine Bourgeois wrote: > >> We found at Vates that there are lot of spurious interrupts when > >> benchmarking the

Re: [PATCH v2 12/17] xen/riscv: Implement p2m_free_entry() and related helpers

2025-07-11 Thread Oleksii Kurochko
On 7/1/25 4:23 PM, Jan Beulich wrote: On 10.06.2025 15:05, Oleksii Kurochko wrote: This patch introduces a working implementation of p2m_free_entry() for RISC-V based on ARM's implementation of p2m_free_entry(), enabling proper cleanup of page table entries in the P2M (physical-to-machine) mapp

Re: [PATCH v2 3/6] arm/mpu: Populate a new region in Xen MPU mapping table

2025-07-11 Thread Hari Limaye
Hi Michal, >> +int map_pages_to_xen(unsigned long virt, mfn_t mfn, unsigned long nr_mfns, >> + unsigned int flags) >> +{ >> +int rc = xen_mpumap_update(mfn_to_maddr(mfn), > What do you expect to be passed as virt? I would expect maddr which could save > you the conversion h

Re: [PATCH v2] xen/arm: fix arm_iommu_map_page after f9f6b22ab

2025-07-11 Thread Stewart Hildebrand
On 7/10/25 20:25, Stefano Stabellini wrote: > Up until f9f6b22ab "xen/arm: Map ITS doorbell register to IOMMU page > tables" the only caller of iommu_map on ARM was grant_table.c which has > a specific usage model and restrictions as described by the in-code > comment in arm_iommu_map_page. > > f9

Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5

2025-07-11 Thread Nicola Vetrini
On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote: MISRA C Rule 5.5 states that: "Identifiers shall be distinct from macro names". Update ECLAIR configuration to deviate: - clashes in 'xen/include/xen/bitops.h'; - clashes in 'xen/include/xen/irq.h'; - clashes in 'xen/common/grant_table.c'. Signed-o

Re: [MINI-OS PATCH 11/19] mini-os: config: add support for config items with numerical values

2025-07-11 Thread Jürgen Groß
On 11.07.25 08:24, Jan Beulich wrote: On 02.07.2025 10:12, Juergen Gross wrote: Add support for a Mini-OS config file containing config items with numerical values, e.g. CONFIG_FOO=7. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Albeit I'm puzzled by the use in the next patch. Bes

Re: [PATCH v7] xen/console: introduce domain_console struct

2025-07-11 Thread Roger Pau Monné
On Fri, Jul 11, 2025 at 12:40:11AM +, dm...@proton.me wrote: > From: Denis Mukhin > > Introduce domain_console for grouping data structures used for integrating > domain's diagnostic console with Xen's console driver. > > Group all pbuf-related data structures under domain_console. Rename t

[XEN PATCH v2] misra: address violation of MISRA C Rule 10.1

2025-07-11 Thread Dmytro Prokopchuk1
Rule 10.1: Operands shall not be of an inappropriate essential type The following are non-compliant: - unary minus on unsigned type; - boolean used as a numeric value. Precede unary '-' operator with casting to signed type. Replace numeric constant '-1UL' with '~0UL'. Replace numeric constant '-1

Re: [XEN PATCH v2] misra: address violation of MISRA C Rule 10.1

2025-07-11 Thread Dmytro Prokopchuk1
Hi All. In this 2nd version I made changes according to the https://patchew.org/Xen/d92cf08a64d8197a1d1a45f901e59183105d3da5.1752183472.git.dmytro._5fprokopch...@epam.com/ There are 0 violations on the ARM64 as you can see in the report: https://saas.eclairit.com:3787/fs/var/local/eclair/xen-proj

Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-11 Thread Jan Beulich
On 11.07.2025 09:25, dm...@proton.me wrote: > On Fri, Jul 11, 2025 at 07:59:27AM +0200, Jan Beulich wrote: >> On 11.07.2025 03:07, dm...@proton.me wrote: >>> On Thu, Jul 10, 2025 at 01:16:24PM +0200, Jan Beulich wrote: On 10.07.2025 03:35, dm...@proton.me wrote: > @@ -877,6 +873,16 @@ stru

Re: [MINI-OS PATCH 12/19] mini-os: kexec: add support for handing over some memory across kexec

2025-07-11 Thread Jürgen Groß
On 11.07.25 01:21, Jason Andryuk wrote: On 2025-07-02 04:12, Juergen Gross wrote: Especially for support of Xenstore-stubdom live update some memory must be handed over to the new kernel without moving it around: as the 9pfs device used for storing and retrieving the state of Xenstore needs to b

Re: [PATCH v6] xen/console: introduce domain_console struct

2025-07-11 Thread dmkhn
On Fri, Jul 11, 2025 at 07:59:27AM +0200, Jan Beulich wrote: > On 11.07.2025 03:07, dm...@proton.me wrote: > > On Thu, Jul 10, 2025 at 01:16:24PM +0200, Jan Beulich wrote: > >> On 10.07.2025 03:35, dm...@proton.me wrote: > >>> @@ -877,6 +873,16 @@ struct domain *domain_create(domid_t domid, > >>> >

Re: [PATCH] xen/netfront: Fix TX response spurious interrupts

2025-07-11 Thread Anthoine Bourgeois
On Thu, Jul 10, 2025 at 01:05:47PM -0700, Elliott Mitchell wrote: >On Thu, Jul 10, 2025 at 04:11:15PM +, Anthoine Bourgeois wrote: >> We found at Vates that there are lot of spurious interrupts when >> benchmarking the PV drivers of Xen. This issue appeared with a patch >> that addresses securi

Re: [XEN PATCH v2] misra: address violation of MISRA C Rule 10.1

2025-07-11 Thread Dmytro Prokopchuk1
On 7/11/25 15:03, Jan Beulich wrote: > On 11.07.2025 13:43, Dmytro Prokopchuk1 wrote: >> --- a/xen/common/memory.c >> +++ b/xen/common/memory.c >> @@ -773,7 +773,7 @@ static long >> memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) >> >> nrspin_lock(&d->page

Re: [PATCH v5] xen/efi: Update error flow for read_file function

2025-07-11 Thread Frediano Ziglio
On Sat, Jun 28, 2025 at 7:46 AM Frediano Ziglio wrote: > > Use more explicit goto statements to handle common error code > path instead of a lot of if/else. > > Signed-off-by: Frediano Ziglio > --- > Change since v4: > - fixed label indentation. > --- > xen/common/efi/boot.c | 80 +++

Re: [PATCH] xen/gntdev: remove struct gntdev_copy_batch from stack

2025-07-11 Thread Jürgen Groß
On 11.07.25 03:03, Stefano Stabellini wrote: On Wed, 9 Jul 2025, Jürgen Groß wrote: On 08.07.25 21:01, Stefano Stabellini wrote: On Thu, 3 Jul 2025, Juergen Gross wrote: When compiling the kernel with LLVM, the following warning was issued: drivers/xen/gntdev.c:991: warning: stack frame s

Re: RFC: Proposal for supporting EL1 MPU region context switch in Xen

2025-07-11 Thread Julien Grall
Hi Hari, On 08/07/2025 17:30, Hari Limaye wrote: # Proposal for supporting EL1 MPU region context switch in Xen This proposal will introduce the proposed design for supporting EL1 MPU region context switch for guests. ## Purpose We would like to be able to support the PMSAv8-64 translation re

[PATCH] libxl: allow to run non-HVM guest without any device model being available

2025-07-11 Thread Juergen Gross
When removing qemu-trad support, libxl__domain_build_info_setdefault() was modified to only allow qemu-xen as a device model. This change resulted in an error at domain creation when qemu-xen isn't there. As this is a perfectly fine situation for PV and PVH guests without any qemu based backends,

Re: [PATCH] xen/netfront: Fix TX response spurious interrupts

2025-07-11 Thread Teddy Astie
You also probably want to send this to linux kernel mailing list too. Le 10/07/2025 à 18:14, Anthoine Bourgeois a écrit : > We found at Vates that there are lot of spurious interrupts when > benchmarking the PV drivers of Xen. This issue appeared with a patch > that addresses security issue XSA-39

[MINI-OS PATCH] e820: fix e820_get_reserved_pfns() to reserve page aligned area

2025-07-11 Thread Juergen Gross
e820_get_reserved_pfns() needs to make sure to reserve only page aligned memory areas. Fixes: a7d27a7332ba ("mini-os: add memory map service functions") Signed-off-by: Juergen Gross --- e820.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e820.c b/e820.c index d8cfb1f4..1ff

Re: [XEN PATCH v2] misra: address violation of MISRA C Rule 10.1

2025-07-11 Thread Jan Beulich
On 11.07.2025 13:43, Dmytro Prokopchuk1 wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -773,7 +773,7 @@ static long > memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) > > nrspin_lock(&d->page_alloc_lock); > drop_dom_ref = (

Re: [MINI-OS PATCH] e820: fix e820_get_reserved_pfns() to reserve page aligned area

2025-07-11 Thread Jan Beulich
On 11.07.2025 14:03, Juergen Gross wrote: > e820_get_reserved_pfns() needs to make sure to reserve only page > aligned memory areas. > > Fixes: a7d27a7332ba ("mini-os: add memory map service functions") > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich

Re: [XEN PATCH v2] misra: address violation of MISRA C Rule 10.1

2025-07-11 Thread Dmytro Prokopchuk1
On 7/11/25 14:52, Dmytro Prokopchuk wrote: > Hi All. > > In this 2nd version I made changes according to the > https://patchew.org/Xen/ > d92cf08a64d8197a1d1a45f901e59183105d3da5.1752183472.git.dmytro._5fprokopch...@epam.com/ > > There are 0 violations on the ARM64 as you can see in the report

Re: [PATCH] xen/netfront: Fix TX response spurious interrupts

2025-07-11 Thread Juergen Gross
On 10.07.25 18:11, Anthoine Bourgeois wrote: We found at Vates that there are lot of spurious interrupts when benchmarking the PV drivers of Xen. This issue appeared with a patch that addresses security issue XSA-391 (see Fixes below). On an iperf benchmark, spurious interrupts can represent up t

Re: [PATCH] xen/netfront: Fix TX response spurious interrupts

2025-07-11 Thread Jürgen Groß
On 11.07.25 11:29, Teddy Astie wrote: You also probably want to send this to linux kernel mailing list too. Le 10/07/2025 à 18:14, Anthoine Bourgeois a écrit : We found at Vates that there are lot of spurious interrupts when benchmarking the PV drivers of Xen. This issue appeared with a patch t

Re: [PATCH] xen/netfront: Fix TX response spurious interrupts

2025-07-11 Thread Jürgen Groß
On 10.07.25 18:11, Anthoine Bourgeois wrote: We found at Vates that there are lot of spurious interrupts when benchmarking the PV drivers of Xen. This issue appeared with a patch that addresses security issue XSA-391 (see Fixes below). On an iperf benchmark, spurious interrupts can represent up t

Re: [XEN PATCH v2 3/3] eclair: add deviations of MISRA C Rule 5.5

2025-07-11 Thread Stefano Stabellini
On Fri, 11 Jul 2025, Nicola Vetrini wrote: > On 2025-07-09 23:38, Dmytro Prokopchuk1 wrote: > > MISRA C Rule 5.5 states that: "Identifiers shall > > be distinct from macro names". > > > > Update ECLAIR configuration to deviate: > > - clashes in 'xen/include/xen/bitops.h'; > > - clashes in 'xen/inc

Re: [PATCH v6 05/11] xen/dt: Move bootfdt functions to xen/bootfdt.h

2025-07-11 Thread Alejandro Vallejo
On Tue Jul 8, 2025 at 8:07 PM CEST, Alejandro Vallejo wrote: > From: Alejandro Vallejo > > Part of an unpicking process to extract bootfdt contents independent of > bootinfo > to a separate file for x86 to take. > > Move functions required for early FDT parsing from device_tree.h and arm's > setu

Re: [XEN PATCH v2] misra: address violation of MISRA C Rule 10.1

2025-07-11 Thread Stefano Stabellini
On Fri, 11 Jul 2025, Dmytro Prokopchuk1 wrote: > Hi All. > > In this 2nd version I made changes according to the > https://patchew.org/Xen/d92cf08a64d8197a1d1a45f901e59183105d3da5.1752183472.git.dmytro._5fprokopch...@epam.com/ > > There are 0 violations on the ARM64 as you can see in the report:

Re: [PATCH v7] xen/console: introduce domain_console struct

2025-07-11 Thread dmkhn
On Fri, Jul 11, 2025 at 12:54:11PM +0200, Roger Pau Monné wrote: > On Fri, Jul 11, 2025 at 12:40:11AM +, dm...@proton.me wrote: > > From: Denis Mukhin > > > > Introduce domain_console for grouping data structures used for integrating > > domain's diagnostic console with Xen's console driver. >

Re: [PATCH v2 3/5] xen/arm: Move make_resv_memory_node()

2025-07-11 Thread Stewart Hildebrand
On 7/9/25 03:58, Koichiro Den wrote: > On Tue, Jul 08, 2025 at 04:12:50PM -0400, Stewart Hildebrand wrote: >> On 7/5/25 10:27, Koichiro Den wrote: >>> The /reserved-memory node is inherently not specific to static-shmem. >>> Move it to a more generic domain build context. While at it, add an >>> em