Re: [PATCH v5 04/10] vpci: Refactor REGISTER_VPCI_INIT

2025-06-09 Thread Chen, Jiqian
On 2025/6/9 18:40, Roger Pau Monné wrote: > On Mon, Jun 09, 2025 at 10:18:42AM +, Chen, Jiqian wrote: >> On 2025/6/9 17:29, Roger Pau Monné wrote: >>> On Mon, Jun 09, 2025 at 07:50:21AM +, Chen, Jiqian wrote: On 2025/6/6 17:14, Roger Pau Monné wrote: > On Fri, Jun 06, 2025 at 09:05

Re: [REGRESSION] Linux 6.15.1 xen/dom0 domain_crash_sync called from entry.S

2025-06-09 Thread Jürgen Groß
On 10.06.25 00:43, Chuck Zmudzinski wrote: Hi, I am seeing the following regression between Linux 6.14.8 and 6.15.1. Kernel version 6.14.8 boots fine but version 6.15.1 crashes and reboots on Xen. I don't know if 6.14.9 or 6.14.10 is affected, or if 6.15 or the 6.15 release candidates are affec

[PATCH v6] xen/domain: rewrite emulation_flags_ok()

2025-06-09 Thread dmkhn
From: Denis Mukhin Rewrite emulation_flags_ok() to simplify future modifications. No functional change intended. Signed-off-by: Denis Mukhin --- Changes since v5: - optimized `configs[]` table - just one record for PV case - sorted entries in `configs[]` table by domain type: PV, then PVH, the

[REGRESSION] Linux 6.15.1 xen/dom0 domain_crash_sync called from entry.S

2025-06-09 Thread Chuck Zmudzinski
Hi, I am seeing the following regression between Linux 6.14.8 and 6.15.1. Kernel version 6.14.8 boots fine but version 6.15.1 crashes and reboots on Xen. I don't know if 6.14.9 or 6.14.10 is affected, or if 6.15 or the 6.15 release candidates are affected because I did not test them. Also, Linux

[PATCH] xen/arm: fix build with HAS_PCI

2025-06-09 Thread Stewart Hildebrand
In file included from ./include/xen/pci.h:72, from drivers/pci/pci.c:8: ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror] 131 | static inline int pci_sanitize_bar_

Re: [PATCH v3 2/2] tools/arm: exclude iomem from domU extended regions

2025-06-09 Thread Stewart Hildebrand
Thanks for taking a look! On 5/26/25 07:40, Anthony PERARD wrote: > On Tue, May 13, 2025 at 03:54:50PM -0400, Stewart Hildebrand wrote: >> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c >> index 75c811053c7c..8ae16a1726fc 100644 >> --- a/tools/libs/light/libxl_arm.c >> ++

Re: [PATCH v2 08/15] xen/dt: Move bootfdt functions to xen/bootfdt.h

2025-06-09 Thread Stefano Stabellini
On Mon, 9 Jun 2025, Alejandro Vallejo wrote: > On Fri Jun 6, 2025 at 9:59 PM CEST, Stefano Stabellini wrote: > > On Fri, 6 Jun 2025, Alejandro Vallejo wrote: > >> On Fri Jun 6, 2025 at 10:59 AM CEST, Michal Orzel wrote: > >> > > >> > > >> > On 05/06/2025 21:48, Alejandro Vallejo wrote: > >> >> Part

Re: [PATCH v2 07/15] x86: Replace boot_domain with bootdomain

2025-06-09 Thread Stefano Stabellini
On Mon, 9 Jun 2025, Alejandro Vallejo wrote: > On Sat Jun 7, 2025 at 1:28 AM CEST, Stefano Stabellini wrote: > > On Thu, 5 Jun 2025, Alejandro Vallejo wrote: > >> No functional change intended. > >> > >> Signed-off-by: Alejandro Vallejo > >> --- > >> v2: > >> * Replaces the previous patch in wh

Re: [PATCH v6 06/12] x86/hyperlaunch: obtain cmdline from device tree

2025-06-09 Thread Jason Andryuk
On 2025-04-29 08:36, Alejandro Vallejo wrote: From: "Daniel P. Smith" Add support to read the command line from the hyperlaunch device tree. The device tree command line is located in the "bootargs" property of the "multiboot,kernel" node. A boot loader command line, e.g. a grub module string

[PATCH v4 2/2] tools/arm: exclude iomem from domU extended regions

2025-06-09 Thread Stewart Hildebrand
When a device is passed through to a xl domU, the iomem ranges may overlap with the extended regions. Remove iomem from extended regions. Signed-off-by: Stewart Hildebrand --- Not sure if we need a Fixes: tag, but if we do: Fixes: 57f87857dc2d ("libxl/arm: Add handling of extended regions for Dom

[PATCH v4 1/2] xen/arm: exclude xen,reg from direct-map domU extended regions

2025-06-09 Thread Stewart Hildebrand
Similarly to fba1b0974dd8, when a device is passed through to a direct-map dom0less domU, the xen,reg ranges may overlap with the extended regions. Remove xen,reg from direct-map domU extended regions. Take the opportunity to update the comment ahead of find_memory_holes(). Signed-off-by: Stewart

[PATCH v4 0/2] arm: extended regions fixes

2025-06-09 Thread Stewart Hildebrand
v3->v4: * see individual patches v2->v3: * drop committed patches * add ("xen/arm: exclude xen,reg from direct-map domU extended regions") v1->v2: * rebase * address feedback Stewart Hildebrand (2): xen/arm: exclude xen,reg from direct-map domU extended regions tools/arm: exclude iomem from

Re: [PATCH v9 2/3] xen/domain: adjust domain ID allocation for Arm

2025-06-09 Thread Jan Beulich
On 06.06.2025 23:29, Julien Grall wrote: > Hi Denis, > > On 05/06/2025 23:05, Julien Grall wrote: >> Hi Denis, >> >> On 28/05/2025 23:50, dm...@proton.me wrote: >>> From: Denis Mukhin >>> >>> From: Denis Mukhin >>> >>> Remove the hardcoded domain ID 0 allocation for hardware domain and replace

Re: [PATCH v6 06/12] x86/hyperlaunch: obtain cmdline from device tree

2025-06-09 Thread Jan Beulich
On 09.06.2025 19:07, Jason Andryuk wrote: > On 2025-04-29 08:36, Alejandro Vallejo wrote: >> From: "Daniel P. Smith" >> >> Add support to read the command line from the hyperlaunch device tree. >> The device tree command line is located in the "bootargs" property of the >> "multiboot,kernel" node.

Re: [PATCH] xen/arm: fix build with HAS_PCI

2025-06-09 Thread Orzel, Michal
On 09/06/2025 22:54, Stewart Hildebrand wrote: > In file included from ./include/xen/pci.h:72, > from drivers/pci/pci.c:8: > ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared inside > parameter list will not be visible outside of this definition or declarat

Re: [PATCH] x86: remove memcmp calls non-compliant with Rule 21.16.

2025-06-09 Thread Jan Beulich
On 06.06.2025 22:49, Stefano Stabellini wrote: > On Fri, 6 Jun 2025, Nicola Vetrini wrote: > Signed-off-by: Alessandro Zucchelli Missing your own S-o-b. Also (nit) may I ask that you drop the full stop from the patch subject? >>> >>> I'll add the S-o-B and fix the subject >

Re: [PATCH v5 04/10] vpci: Refactor REGISTER_VPCI_INIT

2025-06-09 Thread Chen, Jiqian
On 2025/6/9 17:29, Roger Pau Monné wrote: > On Mon, Jun 09, 2025 at 07:50:21AM +, Chen, Jiqian wrote: >> On 2025/6/6 17:14, Roger Pau Monné wrote: >>> On Fri, Jun 06, 2025 at 09:05:48AM +0200, Jan Beulich wrote: On 06.06.2025 08:29, Chen, Jiqian wrote: > On 2025/6/5 20:50, Roger Pau Mo

Re: [PATCH v3] x86/hvmloader: select xenpci MMIO BAR UC or WB MTRR cache attribute

2025-06-09 Thread Oleksii Kurochko
On 6/6/25 3:41 PM, Roger Pau Monné wrote: On Thu, Jun 05, 2025 at 06:16:59PM +0200, Roger Pau Monne wrote: The Xen PCI device (vendor ID 0x5853) exposed to x86 HVM guests doesn't have the functionality of a traditional PCI device. The exposed MMIO BAR is used by some guests (including Linux) a

Re: [PATCH v2] x86/HVM: restrict use of pinned cache attributes as well as associated flushing

2025-06-09 Thread Roger Pau Monné
On Wed, Jun 04, 2025 at 11:48:00AM +0200, Jan Beulich wrote: > We don't permit use of uncachable memory types elsewhere unless a domain > meets certain criteria. Enforce this also during registration of pinned > cache attribute ranges. > > Furthermore restrict cache flushing to just uncachable ran

Re: [PATCH v5 04/10] vpci: Refactor REGISTER_VPCI_INIT

2025-06-09 Thread Roger Pau Monné
On Mon, Jun 09, 2025 at 10:18:42AM +, Chen, Jiqian wrote: > On 2025/6/9 17:29, Roger Pau Monné wrote: > > On Mon, Jun 09, 2025 at 07:50:21AM +, Chen, Jiqian wrote: > >> On 2025/6/6 17:14, Roger Pau Monné wrote: > >>> On Fri, Jun 06, 2025 at 09:05:48AM +0200, Jan Beulich wrote: > On 06.

Re: [PATCH v2 2/3] arm/mpu: Provide and populate MPU C data structures

2025-06-09 Thread Ayan Kumar Halder
Hi, On 09/06/2025 10:16, Ayan Kumar Halder wrote: On 09/06/2025 09:42, Julien Grall wrote: Hi Ayan, Hi Julien, On 09/06/2025 09:27, Ayan Kumar Halder wrote: On 09/06/2025 08:41, Orzel, Michal wrote: diff --git a/xen/arch/arm/include/asm/mpu/regions.inc b/xen/arch/arm/ include/asm/mpu/regi

Re: [PATCH v2 1/3] arm/mpu: Introduce MPU memory region map structure

2025-06-09 Thread Orzel, Michal
On 06/06/2025 18:48, Ayan Kumar Halder wrote: > Introduce pr_t typedef which is a structure having the prbar and prlar > members, > each being structured as the registers of the AArch32 Armv8-R architecture. > > Also, define MPU_REGION_RES0 to 0 as there are no reserved 0 bits beyond the > BAS

Re: [PATCH v2 2/3] arm/mpu: Provide and populate MPU C data structures

2025-06-09 Thread Orzel, Michal
On 06/06/2025 18:48, Ayan Kumar Halder wrote: > Modify Arm32 assembly boot code to reset any unused MPU region, initialise > 'max_mpu_regions' with the number of supported MPU regions and set/clear the > bitmap 'xen_mpumap_mask' used to track the enabled regions. > > Use the macro definition fo

Re: [PATCH v2 3/3] arm/mpu: Provide access to the MPU region from the C code

2025-06-09 Thread Orzel, Michal
On 06/06/2025 18:48, Ayan Kumar Halder wrote: > Enable the helper functions defined in mpu/mm.c and asm/mpu.h for ARM32. > Define the register definitions for HPRBAR{0..31} and HPRLAR{0..31}. > One can directly access the first 32 MPU regions using the above registers > without the use of PRSELR

Re: [PATCH v2 08/15] xen/dt: Move bootfdt functions to xen/bootfdt.h

2025-06-09 Thread Alejandro Vallejo
On Fri Jun 6, 2025 at 9:59 PM CEST, Stefano Stabellini wrote: > On Fri, 6 Jun 2025, Alejandro Vallejo wrote: >> On Fri Jun 6, 2025 at 10:59 AM CEST, Michal Orzel wrote: >> > >> > >> > On 05/06/2025 21:48, Alejandro Vallejo wrote: >> >> Part of an unpicking process to extract bootfdt contents indepe

Re: [PATCH v2 07/15] x86: Replace boot_domain with bootdomain

2025-06-09 Thread Alejandro Vallejo
On Sat Jun 7, 2025 at 1:28 AM CEST, Stefano Stabellini wrote: > On Thu, 5 Jun 2025, Alejandro Vallejo wrote: >> No functional change intended. >> >> Signed-off-by: Alejandro Vallejo >> --- >> v2: >> * Replaces the previous patch in which kernel_info replaced boot_domain >> --- >> xen/arch/x86/

Re: [PATCH v2 2/3] arm/mpu: Provide and populate MPU C data structures

2025-06-09 Thread Ayan Kumar Halder
On 09/06/2025 09:42, Julien Grall wrote: Hi Ayan, Hi Julien, On 09/06/2025 09:27, Ayan Kumar Halder wrote: On 09/06/2025 08:41, Orzel, Michal wrote: diff --git a/xen/arch/arm/include/asm/mpu/regions.inc b/xen/arch/arm/ include/asm/mpu/regions.inc index 6b8c233e6c..631b0b2b86 100644 --- a/

Re: [PATCH v2 3/3] arm/mpu: Provide access to the MPU region from the C code

2025-06-09 Thread Luca Fancellu
Oh sorry forgot one thing ... > >> /* >> * Armv8-R supports direct access and indirect access to the MPU regions >> through >> * registers: >> @@ -85,6 +87,7 @@ static void __init __maybe_unused build_assertions(void) >> */ >> static void prepare_selector(uint8_t *sel) >> { >> +#ifdef CONFIG_ARM_

Re: [PATCH v2 3/3] arm/mpu: Provide access to the MPU region from the C code

2025-06-09 Thread Ayan Kumar Halder
On 09/06/2025 09:37, Luca Fancellu wrote: Hi Ayan, Hi Luca, If I understand correctly Armv8-R AArch32 supports up to 255 regions, so I would expect ... /* * Armv8-R supports direct access and indirect access to the MPU regions through * registers: @@ -85,6 +87,7 @@ static void __init

Re: [PATCH v2 2/3] arm/mpu: Provide and populate MPU C data structures

2025-06-09 Thread Ayan Kumar Halder
Hi Michal, On 09/06/2025 08:41, Orzel, Michal wrote: On 06/06/2025 18:48, Ayan Kumar Halder wrote: Modify Arm32 assembly boot code to reset any unused MPU region, initialise 'max_mpu_regions' with the number of supported MPU regions and set/clear the bitmap 'xen_mpumap_mask' used to track the

Re: [PATCH v5 04/10] vpci: Refactor REGISTER_VPCI_INIT

2025-06-09 Thread Roger Pau Monné
On Mon, Jun 09, 2025 at 07:50:21AM +, Chen, Jiqian wrote: > On 2025/6/6 17:14, Roger Pau Monné wrote: > > On Fri, Jun 06, 2025 at 09:05:48AM +0200, Jan Beulich wrote: > >> On 06.06.2025 08:29, Chen, Jiqian wrote: > >>> On 2025/6/5 20:50, Roger Pau Monné wrote: > On Mon, May 26, 2025 at 05:

Re: [PATCH v2 2/3] arm/mpu: Provide and populate MPU C data structures

2025-06-09 Thread Julien Grall
Hi Ayan, On 09/06/2025 11:43, Ayan Kumar Halder wrote: Hi, On 09/06/2025 10:16, Ayan Kumar Halder wrote: On 09/06/2025 09:42, Julien Grall wrote: Hi Ayan, Hi Julien, On 09/06/2025 09:27, Ayan Kumar Halder wrote: On 09/06/2025 08:41, Orzel, Michal wrote: diff --git a/xen/arch/arm/include/

Re: [PATCH v2 2/3] arm/mpu: Provide and populate MPU C data structures

2025-06-09 Thread Julien Grall
Hi Ayan, On 09/06/2025 09:27, Ayan Kumar Halder wrote: On 09/06/2025 08:41, Orzel, Michal wrote: diff --git a/xen/arch/arm/include/asm/mpu/regions.inc b/xen/arch/arm/ include/asm/mpu/regions.inc index 6b8c233e6c..631b0b2b86 100644 --- a/xen/arch/arm/include/asm/mpu/regions.inc +++ b/xen/arch/a

Re: [PATCH v2 3/3] arm/mpu: Provide access to the MPU region from the C code

2025-06-09 Thread Luca Fancellu
Hi Ayan, If I understand correctly Armv8-R AArch32 supports up to 255 regions, so I would expect ... > /* > * Armv8-R supports direct access and indirect access to the MPU regions > through > * registers: > @@ -85,6 +87,7 @@ static void __init __maybe_unused build_assertions(void) > */ > sta

Re: [PATCH v5 04/10] vpci: Refactor REGISTER_VPCI_INIT

2025-06-09 Thread Chen, Jiqian
On 2025/6/6 17:14, Roger Pau Monné wrote: > On Fri, Jun 06, 2025 at 09:05:48AM +0200, Jan Beulich wrote: >> On 06.06.2025 08:29, Chen, Jiqian wrote: >>> On 2025/6/5 20:50, Roger Pau Monné wrote: On Mon, May 26, 2025 at 05:45:53PM +0800, Jiqian Chen wrote: > + }; \ > + static vpci_ca