Re: [XEN PATCH] eclair: allow and document use of GCC extension for label addresses

2025-05-23 Thread Andrew Cooper
On 23/05/2025 8:20 am, Nicola Vetrini wrote: > No functional change. > > Signed-off-by: Nicola Vetrini Ah, very nice and easy. Acked-by: Andrew Cooper Is this dependent on the updated Eclair, or can it go in now? ~Andrew

Re: [XEN PATCH] eclair: allow and document use of GCC extension for label addresses

2025-05-23 Thread Nicola Vetrini
On 2025-05-23 14:57, Andrew Cooper wrote: On 23/05/2025 8:20 am, Nicola Vetrini wrote: No functional change. Signed-off-by: Nicola Vetrini Ah, very nice and easy. Acked-by: Andrew Cooper Is this dependent on the updated Eclair, or can it go in now? Hi Andrew, it's independent on the u

Re: [PATCH v3 13/13] KVM: selftests: Add a KVM_IRQFD test to verify uniqueness requirements

2025-05-23 Thread Sean Christopherson
On Fri, May 23, 2025, Sairaj Kodilkar wrote: > On 5/23/2025 5:22 AM, Sean Christopherson wrote: > > > + > > +int main(int argc, char *argv[]) > > +{ > > + pthread_t racing_thread; > > + int r, i; > > + > > + /* Create "full" VMs, as KVM_IRQFD requires an in-kernel IRQ chip. */ > > + vm1 =

[PATCH] x86/vmx: Fix VMEntry failure on ADL/SPR with shadow guests

2025-05-23 Thread Andrew Cooper
Paging Writeable depends on EPT, so must disabled in non-EPT guests like the other EPT dependent features. Otherwise, VMEntry fails with bad control state. Drop a piece of trailing whitepsace in context. Fixes: ff10aa9d8f90 ("x86: Add Support for Paging-Write Feature") Signed-off-by: Andrew Coop

Re: [EXTERNAL] [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-23 Thread David Woodhouse
On Fri, 2025-05-23 at 16:01 +, Liam Merwick wrote: > When the '--enable-trace-backends=syslog' build option is configured, > the following compilation error is encountered. > > In file included from /usr/include/sys/syslog.h:207, > from /usr/include/syslog.h:1, >  

Re: [PATCH 6/6] automation/eclair: update configuration of D4.10

2025-05-23 Thread Federico Serafini
On 19/05/25 23:36, Stefano Stabellini wrote: On Mon, 19 May 2025, Federico Serafini wrote: Hi, On 17/05/25 01:57, Andrew Cooper wrote: +-config=MC3A2.D4.10,reports+={safe, "first_area(text(^/\\* Generated file, do not edit! \\*/$, begin-2))"} -config=MC3A2.D4.10,reports+={safe, "first_are

[PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-23 Thread Liam Merwick
When the '--enable-trace-backends=syslog' build option is configured, the following compilation error is encountered. In file included from /usr/include/sys/syslog.h:207, from /usr/include/syslog.h:1, from ./trace/trace-hw_xen.h:224, from ../hw/xe

Re: [PATCH v2 01/22] x86/include/asm/intel-txt.h: constants and accessors for TXT registers and heap

2025-05-23 Thread Sergii Dmytruk
On Wed, May 21, 2025 at 05:19:57PM +0200, Jan Beulich wrote: > > +/* > > + * The same set of registers is exposed twice (with different permissions) > > and > > + * they are allocated continuously with page alignment. > > + */ > > +#define NR_TXT_CONFIG_SIZE \ > > +(TXT_PUB_CONFIG_REGS_BASE -

[PATCH v6 4/6] arm/mpu: Provide access to the MPU region from the C code

2025-05-23 Thread Luca Fancellu
Implement some utility functions in order to access the MPU regions from the C world. Signed-off-by: Luca Fancellu Reviewed-by: Michal Orzel --- v6 changes: - add break to default in the switch - modify comment and style fixes - Add R-by Michal v5 changes: - move MPU_REGION_RES0 to arm64, fi

Re: [PATCH v3 13/13] KVM: selftests: Add a KVM_IRQFD test to verify uniqueness requirements

2025-05-23 Thread Sairaj Kodilkar
On 5/23/2025 5:22 AM, Sean Christopherson wrote: + +int main(int argc, char *argv[]) +{ + pthread_t racing_thread; + int r, i; + + /* Create "full" VMs, as KVM_IRQFD requires an in-kernel IRQ chip. */ + vm1 = vm_create(1); + vm2 = vm_create(1); + + WRITE_ONCE(

Re: [PATCH v2 1/4] x86/boot: print CPU and APIC ID in bring up failure

2025-05-23 Thread Roger Pau Monné
On Thu, May 22, 2025 at 06:22:19PM +0100, Andrew Cooper wrote: > On 22/05/2025 5:50 pm, Roger Pau Monné wrote: > > On Thu, May 22, 2025 at 03:39:57PM +0100, Andrew Cooper wrote: > >> On 22/05/2025 10:10 am, Jan Beulich wrote: > >>> On 22.05.2025 09:54, Roger Pau Monne wrote: > Print the CPU an

[PATCH v6 0/6] First chunk for Arm R82 and MPU support

2025-05-23 Thread Luca Fancellu
Hi all, This is the first chunk of work to support MPU and R82 on Xen, this serie reaches the early boot stages just before early_fdt_map(), just to give an idea about which stage of the boot is reached. v6: - general fixes listed on each patch v5: - dropped patch that touches page.h, it is not

[XEN PATCH] eclair: allow and document use of GCC extension for label addresses

2025-05-23 Thread Nicola Vetrini
No functional change. Signed-off-by: Nicola Vetrini --- This fixes the CI error for R1.1 on this patch that stems from using the label inside asm goto: https://lore.kernel.org/xen-devel/20250521143658.312514-1-andrew.coop...@citrix.com/ --- automation/eclair_analysis/ECLAIR/toolchain.ecl | 5 ++

Re: [PATCH] iommu/amd: Remove dead non-atomic update checking

2025-05-23 Thread Roger Pau Monné
On Thu, May 22, 2025 at 03:44:12PM +, Teddy Astie wrote: > When updating a DTE, amd_iommu_setup_domain_device checks if the update had > been > non-atomic (i.e rc > 0) and eventually throws a warning but since [1], rc can > no longer be positive, making this check never taken. > > [1] x86/iom

[PATCH v3 1/3] x86/boot: print CPU and APIC ID in bring up failure

2025-05-23 Thread Roger Pau Monne
Print the CPU and APIC ID that fails to respond to the init sequence, or that didn't manage to reach the "callin" state. Expand a bit the printed error messages. Otherwise the "Not responding." message is not easy to understand by users. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné

[PATCH v3 0/3] x86/boot: provide better diagnostics in AP boot failure

2025-05-23 Thread Roger Pau Monne
Hello, This series attempts to improve AP boot failure diagnosis by improving the printed failure messages (patch 1) and detecting AP getting stuck during bringup (patch 3). Patch 2 is preparatory changes for the work done in patch 3. They should be non-functional changes for systems working cor

[PATCH v3 3/3] x86/boot: attempt to print trace and panic on AP bring up stall

2025-05-23 Thread Roger Pau Monne
With the current AP bring up code, Xen can get stuck indefinitely if an AP freezes during boot after the 'callin' step. Introduce a 5s timeout while waiting for APs to finish startup. On failure of an AP to complete startup, send an NMI to trigger the printing of a stack backtrace on the stuck AP

[PATCH v3 2/3] x86/traps: split code to dump execution state to a separate helper

2025-05-23 Thread Roger Pau Monne
Split the code that triggers remote CPUs to dump stacks into a separate function. Also introduce a parameter that can be set by the caller of the newly introduced function to force CPUs to dump the full stack, rather than just dumping the current function name. No functional change intended. Sig

Re: [PATCH v1 2/6] xen/riscv: introduce things necessary for p2m initialization

2025-05-23 Thread Oleksii Kurochko
On 5/22/25 6:09 PM, Jan Beulich wrote: On 22.05.2025 17:53, Oleksii Kurochko wrote: On 5/20/25 3:37 PM, Jan Beulich wrote: On 09.05.2025 17:57, Oleksii Kurochko wrote: +static struct page_info *p2m_get_clean_page(struct domain *d) +{ +struct page_info *page; + +/* + * As mentioned

Re: [PATCH v1 3/6] xen/riscv: construct the P2M pages pool for guests

2025-05-23 Thread Oleksii Kurochko
On 5/20/25 4:38 PM, Jan Beulich wrote: On 09.05.2025 17:57, Oleksii Kurochko wrote: Implement p2m_set_allocation() to construct p2m pages pool for guests based on required number of pages. This is implemented by: - Adding a `struct paging_domain` which contains a freelist, a counter variabl

Re: [PATCH v3 00/13] KVM: Make irqfd registration globally unique

2025-05-23 Thread Peter Zijlstra
On Thu, May 22, 2025 at 04:52:10PM -0700, Sean Christopherson wrote: > sched/wait: Drop WQ_FLAG_EXCLUSIVE from add_wait_queue_priority() > sched/wait: Add a waitqueue helper for fully exclusive priority > waiters Acked-by: Peter Zijlstra (Intel)

Re: [PATCH v1 6/6] xen/riscv: implement p2m mapping functionality

2025-05-23 Thread Oleksii Kurochko
On 5/20/25 5:16 PM, Jan Beulich wrote: On 09.05.2025 17:57, Oleksii Kurochko wrote: These utilities are needed for building and managing RISC-V guest page tables and MMIO mappings by using functions map_regions_p2mt() and guest_physmap_add_entry(). To implement p2m mapping functionality the fo

Re: [PATCH v1 5/6] xen/riscv: add new p2m types and helper macros for type classification

2025-05-23 Thread Oleksii Kurochko
On 5/20/25 5:11 PM, Jan Beulich wrote: On 09.05.2025 17:57, Oleksii Kurochko wrote: --- a/xen/arch/riscv/include/asm/p2m.h +++ b/xen/arch/riscv/include/asm/p2m.h @@ -80,8 +80,36 @@ struct p2m_domain { typedef enum { p2m_invalid = 0,/* Nothing mapped here */ p2m_ram_rw,

Re: [PATCH v1 4/6] xen/riscv: define pt_t and pt_walk_t structures

2025-05-23 Thread Oleksii Kurochko
On 5/20/25 5:04 PM, Jan Beulich wrote: On 09.05.2025 17:57, Oleksii Kurochko wrote: Refactor pte_t to be a union which hold page table entry plus pt_t and pt_walk_t structures to simpilfy p2m functions. Is this really simplifying things? I really view ... Also, introduce some helpers which a

Re: [PATCH v3 1/3] x86/boot: print CPU and APIC ID in bring up failure

2025-05-23 Thread Andrew Cooper
On 23/05/2025 9:21 am, Roger Pau Monne wrote: > Print the CPU and APIC ID that fails to respond to the init sequence, or > that didn't manage to reach the "callin" state. Expand a bit the printed > error messages. Otherwise the "Not responding." message is not easy to > understand by users. > > R

Re: [PATCH v3 2/3] x86/traps: split code to dump execution state to a separate helper

2025-05-23 Thread Andrew Cooper
On 23/05/2025 9:21 am, Roger Pau Monne wrote: > Split the code that triggers remote CPUs to dump stacks into a separate > function. Also introduce a parameter that can be set by the caller of the > newly introduced function to force CPUs to dump the full stack, rather than > just dumping the curre

Re: [RFC PATCH v4 8/8] docs: arm: proposal to add separate SCMI node for Xen agent

2025-05-23 Thread Stefano Stabellini
On Mon, 19 May 2025, Oleksii Moisieiev wrote: > From: Grygorii Strashko > > Proposal description to add separate SCMI DT node for Xen management agent > under "chosen" or xen-config node, like Hyperlaunch "xen,config". I think it is OK to place a larger "xen,config" node under /chosen with more

Re: [RFC PATCH v4 6/8] xen/arm: scmi: introduce SCI SCMI SMC multi-agent driver

2025-05-23 Thread Stefano Stabellini
One question for Bertrand below On Mon, 19 May 2025, Oleksii Moisieiev wrote: > This patch introduces SCI driver to support for ARM EL3 Trusted Firmware-A > (TF-A) which provides SCMI interface with multi-agnet support, as shown > below. > > +-+ > |

Re: [PATCH v2 02/22] include/xen/slr-table.h: Secure Launch Resource Table definitions

2025-05-23 Thread Sergii Dmytruk
On Wed, May 21, 2025 at 05:45:04PM +0200, Jan Beulich wrote: > > +/* SPDX-License-Identifier: GPL-2.0 */ > > GPL-2.0-only is, I think, the one to use for new code. Right. > > +/* > > + * Copyright (c) 2025 Apertus Solutions, LLC > > + * Copyright (c) 2025 Oracle and/or its affiliates. > > + *