Re: [RFC PATCH 00/25] Introduce xenbindgen to autogen hypercall structs

2024-11-22 Thread Teddy Astie
Le 21/11/2024 à 18:46, Anthony PERARD a écrit : > Instead of creating your own IDL specification, did you look for > existing project that would do just that? That is been able to describe > the existing ABI in IDL and use an existing project to generate C and > Rust headers. > > I kind of look int

Re: [PATCH 1/2] x86/irq: fix calculation of max PV dom0 pIRQs

2024-11-22 Thread Jan Beulich
On 22.11.2024 09:01, Roger Pau Monné wrote: > On Thu, Nov 21, 2024 at 12:39:06PM +0100, Jan Beulich wrote: >> On 21.11.2024 12:04, Roger Pau Monné wrote: >>> On Thu, Nov 21, 2024 at 11:49:44AM +0100, Jan Beulich wrote: On 20.11.2024 12:35, Roger Pau Monne wrote: > The current calculation o

[PATCH v2 3/4] x86/boot: Move some settings to C

2024-11-22 Thread Frediano Ziglio
Initialise multiboot_ptr and pvh_start_info_pa from C code. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/build32.lds.S | 3 +++ xen/arch/x86/boot/head.S | 10 xen/arch/x86/boot/reloc.c | 28 ++- xen/arch/x86/include

[PATCH v2 1/4] Use an include/boot directory to override headers for boot code

2024-11-22 Thread Frediano Ziglio
Not all headers can be used by 32 bit boot code. Allows to override some headers, we don't want to mess up with main headers as most of the code is only 64 bit so the easy stuff should be done for 64 bit declarations. Boot headers should be 64 bit compatibles to avoid having multiple declarations.

[PATCH v2 4/4] x86/boot: Use external symbols from cmdline_parse_early

2024-11-22 Thread Frediano Ziglio
Move some assembly code to C. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/build32.lds.S | 1 + xen/arch/x86/boot/cmdline.c | 14 -- xen/arch/x86/boot/head.S| 9 + xen/arch/x86/boot/trampoline.S | 2 +- xen/arch/x86/incl

[PATCH v2 0/4] Move some boot code from assembly to C

2024-11-22 Thread Frediano Ziglio
As a continuation of this series start sorting out the issue of headers not compatible with 32 bit. Instead of having to change headers which are almost only used for 64 bit allows to override headers or move reusable definitions to new shared headers. This results in less changes. Changes since v

[PATCH v2 2/4] x86/boot: Use header to allows inclusion of public xen.h header

2024-11-22 Thread Frediano Ziglio
This allows to include other headers and avoid duplicated declarations. Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/boot/public/xen.h | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 xen/arch/x86/include/boot/public/xen.h diff --git a/xen/arch/x8

Re: [PATCH 1/2] x86/irq: fix calculation of max PV dom0 pIRQs

2024-11-22 Thread Roger Pau Monné
On Thu, Nov 21, 2024 at 12:39:06PM +0100, Jan Beulich wrote: > On 21.11.2024 12:04, Roger Pau Monné wrote: > > On Thu, Nov 21, 2024 at 11:49:44AM +0100, Jan Beulich wrote: > >> On 20.11.2024 12:35, Roger Pau Monne wrote: > >>> The current calculation of PV dom0 pIRQs uses: > >>> > >>> n = min(fls(n

Re: [PATCH v4] xen/common: Move gic_dt_preinit() to common code

2024-11-22 Thread oleksii . kurochko
On Thu, 2024-11-21 at 11:27 +0100, Michal Orzel wrote: > > > On 19/11/2024 15:56, Oleksii Kurochko wrote: > > > > > > Introduce intc_dt_preinit() in the common codebase, as it is not > > architecture-specific and can be reused by both PPC and RISC-V. > > This function identifies the node with t

Re: [RFC PATCH 00/25] Introduce xenbindgen to autogen hypercall structs

2024-11-22 Thread Alejandro Vallejo
On Thu Nov 21, 2024 at 5:47 PM GMT, Anthony PERARD wrote: Hi, > Hi Alejandro, > > Nice work :-). Cheers! And thanks for having a look. > > On Fri, Nov 15, 2024 at 11:51:29AM +, Alejandro Vallejo wrote: > > This series is the result of my "Interfacing Rust with Xen" talk in Xen > > Summit.

Re: [PATCH] 9p/xen: fix release of IRQ

2024-11-22 Thread Jürgen Groß
On 22.11.24 00:44, Dominique Martinet wrote: Alexander Merritt wrote on Thu, Nov 21, 2024 at 10:51:00PM +: From: Alex Zenla Kernel logs indicate an IRQ was double-freed. Nit: if you still have the log it'd be great to include it in the commit message, rather than paragraphing it. The ra

Re: [PATCH 4/6] tools/libs: add a new libxenmanage library

2024-11-22 Thread Anthony PERARD
Hi Juergen, On Wed, Oct 23, 2024 at 03:10:03PM +0200, Juergen Gross wrote: > In order to have a stable interface in user land for using stable > domctl and possibly later sysctl interfaces, add a new library > libxenmanage. What this new library could do? What sort of operation could be added in

Re: [RFC PATCH 00/25] Introduce xenbindgen to autogen hypercall structs

2024-11-22 Thread Alejandro Vallejo
On Fri Nov 22, 2024 at 10:52 AM GMT, Teddy Astie wrote: > Le 21/11/2024 à 18:46, Anthony PERARD a écrit : > > Instead of creating your own IDL specification, did you look for > > existing project that would do just that? That is been able to describe > > the existing ABI in IDL and use an existing

[PATCH 2/3] xen: arm: enable stack protector feature

2024-11-22 Thread Volodymyr Babchuk
Enable previously added CONFIG_STACK_PROTECTOR feature for ARM platform. Here we can call boot_stack_chk_guard_setup() in start_xen() function, because it never returns, so stack protector code will not be triggered because of changed canary. Signed-off-by: Volodymyr Babchuk --- xen/arch/arm/Kco

[PATCH 1/3] xen: common: add ability to enable stack protector

2024-11-22 Thread Volodymyr Babchuk
Both GCC and Clang support -fstack-protector feature, which add stack canaries to functions where stack corruption is possible. This patch makes general preparations to enable this feature on different supported architectures: - "-fno-stack-protector" is removed from global config - Added CONFIG

[PATCH 3/3] xen: riscv: enable stack protector feature

2024-11-22 Thread Volodymyr Babchuk
Enable previously added CONFIG_STACK_PROTECTOR feature for RISC-V platform. Here we can call boot_stack_chk_guard_setup() in start_xen() function, because it never returns, so stack protector code will not be triggered because of changed canary. Signed-off-by: Volodymyr Babchuk --- I tested thi

[PATCH 0/3] Add stack protector

2024-11-22 Thread Volodymyr Babchuk
Both GCC and Clang support -fstack-protector feature, which add stack canaries to functions where stack corruption is possible. This series makes possible to use this feature in Xen. I tested this on ARM64 and it is working as intended. Tested both with GCC and Clang. My aim was to enable it on x8

Re: [RFC PATCH 00/25] Introduce xenbindgen to autogen hypercall structs

2024-11-22 Thread Anthony PERARD
On Fri, Nov 22, 2024 at 01:12:24PM +, Alejandro Vallejo wrote: > On Thu Nov 21, 2024 at 5:47 PM GMT, Anthony PERARD wrote: > > On Fri, Nov 15, 2024 at 11:51:29AM +, Alejandro Vallejo wrote: > > > This series is the result of my "Interfacing Rust with Xen" talk in Xen > > > Summit. > > > It

Re: [PATCH] docs/sphinx: Refresh config for newer Sphinx

2024-11-22 Thread Stefano Stabellini
On Fri, 22 Nov 2024, Andrew Cooper wrote: > Sphinx 5.0 and newer objects to language = None. Switch to 'en'. > > Also update the copyright year. Use %Y to avoid this problem in the future, > and provide compatibility for versions of Sphinx prior to 8.1 which don't > support the syntax. > > Sign

Re: [PATCH] docs/sphinx: Fix FUSA indexing

2024-11-22 Thread Stefano Stabellini
+Ayan On Fri, 22 Nov 2024, Andrew Cooper wrote: > Sphinx complains: > > docs/fusa/index.rst:6: WARNING: toctree contains reference to nonexisting > document 'fusa/reqs' > docs/fusa/reqs/index.rst:6: WARNING: toctree contains reference to > nonexisting document 'fusa/reqs/market-reqs' > do

Re: [PATCH 0/3] Add stack protector

2024-11-22 Thread Andrew Cooper
On 22/11/2024 9:07 pm, Volodymyr Babchuk wrote: > Both GCC and Clang support -fstack-protector feature, which add stack > canaries to functions where stack corruption is possible. This series > makes possible to use this feature in Xen. I tested this on ARM64 and > it is working as intended. Tested

[PATCH] docs/sphinx: Fix FUSA indexing

2024-11-22 Thread Andrew Cooper
Sphinx complains: docs/fusa/index.rst:6: WARNING: toctree contains reference to nonexisting document 'fusa/reqs' docs/fusa/reqs/index.rst:6: WARNING: toctree contains reference to nonexisting document 'fusa/reqs/market-reqs' docs/fusa/reqs/index.rst:6: WARNING: toctree contains reference t

[PATCH] docs/sphinx: Refresh config for newer Sphinx

2024-11-22 Thread Andrew Cooper
Sphinx 5.0 and newer objects to language = None. Switch to 'en'. Also update the copyright year. Use %Y to avoid this problem in the future, and provide compatibility for versions of Sphinx prior to 8.1 which don't support the syntax. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Stefa

Re: [PATCH] 9p/xen: fix release of IRQ

2024-11-22 Thread Dominique Martinet
Jürgen Groß wrote on Fri, Nov 22, 2024 at 02:54:06PM +0100: > > (style) I don't recall seeing much `a = b = 0` in the kernel, and > > looking at it checkpatch seems to complain: > > CHECK: multiple assignments should be avoided > > #114: FILE: net/9p/trans_xen.c:290: > > + priv->rings[i].

Re: [PATCH 4/6] tools/libs: add a new libxenmanage library

2024-11-22 Thread Jürgen Groß
On 22.11.24 14:55, Anthony PERARD wrote: Hi Juergen, On Wed, Oct 23, 2024 at 03:10:03PM +0200, Juergen Gross wrote: In order to have a stable interface in user land for using stable domctl and possibly later sysctl interfaces, add a new library libxenmanage. What this new library could do? Wh

[PATCH v5] xen/common: Move gic_dt_preinit() to common code

2024-11-22 Thread Oleksii Kurochko
Introduce intc_dt_preinit() in the common codebase, as it is not architecture-specific and can be reused by both PPC and RISC-V. This function identifies the node with the interrupt-controller property in the device tree and calls device_init() to handle architecture-specific initialization of the