Re: [PATCH] Update deprecated SPDX license identifiers

2024-10-18 Thread Frediano Ziglio
On Fri, Oct 18, 2024 at 1:11 PM Julien Grall wrote: > > Hi Frediano, > > On 18/10/2024 13:07, Frediano Ziglio wrote: > > On Fri, Oct 4, 2024 at 9:08 AM Frediano Ziglio > > wrote: > >> > >> On Thu, Sep 26, 2024 at 10:51 AM Frediano Ziglio > >> wrote: > >>> > >>> As specified in LICENSES/GPL-2.0:

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Frediano Ziglio
On Fri, Oct 18, 2024 at 12:49 PM Roger Pau Monné wrote: > > On Fri, Oct 18, 2024 at 09:42:48AM +0100, Frediano Ziglio wrote: > > On Thu, Oct 17, 2024 at 6:13 PM Andrew Cooper > > wrote: > > > > > > On 17/10/2024 2:31 pm, Frediano Ziglio wrote: > > > > The current method to include 32 bit C boot

Re: [PATCH v1 1/5] xen/riscv: add stub for share_xen_page_with_guest()

2024-10-18 Thread Jan Beulich
On 18.10.2024 15:10, oleksii.kuroc...@gmail.com wrote: > On Thu, 2024-10-17 at 16:51 +0200, Jan Beulich wrote: >> On 16.10.2024 11:15, Oleksii Kurochko wrote: >>> To avoid the following linkage fail the stub for >>> share_xen_page_with_guest() >>> is introduced: >> >> What do you intend to express

Re: [PATCH] Update deprecated SPDX license identifiers

2024-10-18 Thread Frediano Ziglio
On Fri, Oct 18, 2024 at 1:54 PM Julien Grall wrote: > > Hi, > > On 18/10/2024 13:28, Frediano Ziglio wrote: > > On Fri, Oct 18, 2024 at 1:11 PM Julien Grall wrote: > >> > >> Hi Frediano, > >> > >> On 18/10/2024 13:07, Frediano Ziglio wrote: > >>> On Fri, Oct 4, 2024 at 9:08 AM Frediano Ziglio > >

Re: [PATCH] Update deprecated SPDX license identifiers

2024-10-18 Thread Frediano Ziglio
On Fri, Oct 4, 2024 at 9:08 AM Frediano Ziglio wrote: > > On Thu, Sep 26, 2024 at 10:51 AM Frediano Ziglio > wrote: > > > > As specified in LICENSES/GPL-2.0: > > - GPL-2.0 -> GPL-2.0-only; > > - GPL-2.0+ -> GPL-2.0-or-later. > > > > Signed-off-by: Frediano Ziglio > > ping > ping Frediano

[PATCH v2] Update deprecated SPDX license identifiers

2024-10-18 Thread Frediano Ziglio
As specified in LICENSES/GPL-2.0: - GPL-2.0 -> GPL-2.0-only; - GPL-2.0+ -> GPL-2.0-or-later. Signed-off-by: Frediano Ziglio Reviewed-by: Stefano Stabellini --- CODING_STYLE | 2 +- xen/arch/arm/alternative.c | 2 +- xen/arch/arm/arm32/mmu/mm.c

Re: [PATCH v3 2/6] xen/arm: mpu: Introduce choice between MMU and MPU

2024-10-18 Thread Julien Grall
Hi, On 10/10/2024 15:03, Ayan Kumar Halder wrote: There are features in the forthcoming patches which are dependent on MPU. For eg fixed start address. Also, some of the Xen features (eg STATIC_MEMORY) will be selected by the MPU configuration. Thus, this patch introduces a choice between MMU a

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Roger Pau Monné
On Fri, Oct 18, 2024 at 09:42:48AM +0100, Frediano Ziglio wrote: > On Thu, Oct 17, 2024 at 6:13 PM Andrew Cooper > wrote: > > > > On 17/10/2024 2:31 pm, Frediano Ziglio wrote: > > > The current method to include 32 bit C boot code is: > > > - compile each function we want to use into a separate o

Re: [PATCH v2] Update deprecated SPDX license identifiers

2024-10-18 Thread oleksii . kurochko
On Fri, 2024-10-18 at 14:57 +0100, Frediano Ziglio wrote: > As specified in LICENSES/GPL-2.0: > - GPL-2.0 -> GPL-2.0-only; > - GPL-2.0+ -> GPL-2.0-or-later. > > Signed-off-by: Frediano Ziglio > Reviewed-by: Stefano Stabellini For RISC-V: Reviewed-by: Oleksii Kurochko ~ Oleksii > --- >  CODING

Re: [PATCH v1 2/5] xen/riscv: implement maddr_to_virt()

2024-10-18 Thread oleksii . kurochko
On Thu, 2024-10-17 at 16:55 +0200, Jan Beulich wrote: > On 16.10.2024 11:15, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/mm.h > > +++ b/xen/arch/riscv/include/asm/mm.h > > @@ -25,8 +25,12 @@ > >   > >  static inline void *maddr_to_virt(paddr_t ma) > >  { > > -    BUG_ON("unimplemen

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Jan Beulich
On 18.10.2024 13:41, Roger Pau Monné wrote: > On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: >> @@ -25,14 +23,47 @@ $(obj32): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic >> $(obj)/%.32.o: $(src)/%.c FORCE >> $(call if_changed_rule,cc_o_c) >> >> +orphan-handling-$(call ld-option,-

Re: [PATCH v1 3/5] xen/riscv: introduce setup_mm()

2024-10-18 Thread oleksii . kurochko
On Thu, 2024-10-17 at 17:15 +0200, Jan Beulich wrote: > On 16.10.2024 11:15, Oleksii Kurochko wrote: > > > +    if ( map_pages_to_xen((vaddr_t)mfn_to_virt(0), > > +  _mfn(0), nr_mfns, > > +  PAGE_HYPERVISOR_RW) ) > > +    panic("Unable to setup t

RE: [PATCH] x86/mtrr: Rename mtrr_overwrite_state() to guest_force_mtrr_state()

2024-10-18 Thread Michael Kelley
From: Kirill A. Shutemov Sent: Wednesday, October 16, 2024 3:51 AM > > Rename the helper to better reflect its function. > > Signed-off-by: Kirill A. Shutemov > Suggested-by: Dave Hansen > --- > arch/x86/hyperv/ivm.c | 2 +- > arch/x86/include/asm/mtrr.h| 10 +-

[ovmf test] 188268: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188268 ovmf real [real] flight 188273 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188268/ http://logs.test-lab.xenproject.org/osstest/logs/188273/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [PATCH v3 3/6] xen/arm: mpu: Define Xen start address for MPU systems

2024-10-18 Thread Julien Grall
Hi, On 10/10/2024 15:03, Ayan Kumar Halder wrote: From: Wei Chen On Armv8-A, Xen has a fixed virtual start address (link address too) for all Armv8-A platforms. In an MMU based system, Xen can map its loaded address to this virtual start address. So, on Armv8-A platforms, the Xen start address

Re: [PATCH v3 4/6] xen/arm: mpu: Create boot-time MPU protection regions

2024-10-18 Thread Julien Grall
Hi Ayan, On 10/10/2024 15:03, Ayan Kumar Halder wrote: diff --git a/xen/arch/arm/arm64/mpu/Makefile b/xen/arch/arm/arm64/mpu/Makefile new file mode 100644 index 00..3340058c08 --- /dev/null +++ b/xen/arch/arm/arm64/mpu/Makefile @@ -0,0 +1 @@ +obj-y += head.o diff --git a/xen/arch/arm/arm

[xen-unstable-smoke test] 188244: tolerable all pass - PUSHED

2024-10-18 Thread osstest service owner
flight 188244 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188244/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v1 1/5] xen/riscv: add stub for share_xen_page_with_guest()

2024-10-18 Thread oleksii . kurochko
On Fri, 2024-10-18 at 15:27 +0200, Jan Beulich wrote: > On 18.10.2024 15:10, oleksii.kuroc...@gmail.com wrote: > > On Thu, 2024-10-17 at 16:51 +0200, Jan Beulich wrote: > > > On 16.10.2024 11:15, Oleksii Kurochko wrote: > > > > To avoid the following linkage fail the stub for > > > > share_xen_page

[ovmf test] 188275: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188275 ovmf real [real] flight 188278 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188275/ http://logs.test-lab.xenproject.org/osstest/logs/188278/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [PATCH v3 5/6] xen/arm: mpu: Enable MPU

2024-10-18 Thread Julien Grall
Hi, On 10/10/2024 15:03, Ayan Kumar Halder wrote: After the regions have been created, now we enable the MPU. For this we disable the background region so that the new memory map created for the regions take effect. Also, we treat all RW regions as non executable and the data cache is enabled.

Re: [PATCH v3 6/6] xen/arm: mpu: Implement a dummy enable_secondary_cpu_mm

2024-10-18 Thread Julien Grall
Hi Ayan, On 10/10/2024 15:03, Ayan Kumar Halder wrote: Secondary cpus initialization is not yet supported. Thus, we print an appropriate message and put the secondary cpus in WFE state. And we introduce to BUILD_BUG_ON to prevent users using from building Xen on multiprocessor based MPU systems.

[xen-unstable-smoke test] 188274: tolerable all pass - PUSHED

2024-10-18 Thread osstest service owner
flight 188274 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/188274/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 3/6] xen/arm: mpu: Define Xen start address for MPU systems

2024-10-18 Thread Julien Grall
On 15/10/2024 17:24, Ayan Kumar Halder wrote: Hi, Hi Ayan & Luca, On 14/10/2024 19:53, Luca Fancellu wrote: + Frediano for suggestion about header protection define name +++ b/xen/arch/arm/include/asm/mpu/layout.h @@ -0,0 +1,33 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef

Re: [PATCH v2] Update deprecated SPDX license identifiers

2024-10-18 Thread Julien Grall
Hi Oleksii, On 18/10/2024 15:35, oleksii.kuroc...@gmail.com wrote: On Fri, 2024-10-18 at 14:57 +0100, Frediano Ziglio wrote: As specified in LICENSES/GPL-2.0: - GPL-2.0 -> GPL-2.0-only; - GPL-2.0+ -> GPL-2.0-or-later. Signed-off-by: Frediano Ziglio Reviewed-by: Stefano Stabellini For RISC-V

Re: [PATCH v2] Update deprecated SPDX license identifiers

2024-10-18 Thread Julien Grall
Hi, On 18/10/2024 14:57, Frediano Ziglio wrote: As specified in LICENSES/GPL-2.0: - GPL-2.0 -> GPL-2.0-only; - GPL-2.0+ -> GPL-2.0-or-later. Signed-off-by: Frediano Ziglio Reviewed-by: Stefano Stabellini It is committed now. Cheers, -- Julien Grall

Re: [PATCH 13/13] PCI: Deprecate pci_intx(), pcim_intx()

2024-10-18 Thread Bjorn Helgaas
On Wed, Oct 16, 2024 at 10:53:16AM +0200, Philipp Stanner wrote: > On Wed, 2024-10-16 at 10:43 +0200, Heiner Kallweit wrote: > > On 16.10.2024 08:57, Philipp Stanner wrote: > > > On Tue, 2024-10-15 at 13:53 -0600, Alex Williamson wrote: > > > > On Tue, 15 Oct 2024 20:51:23 +0200 > > > > Philipp Sta

Re: [PATCH v2 0/8] xen/arm: Add support for S32CC platforms and LINFlexD UART

2024-10-18 Thread Julien Grall
Hi, On 30/09/2024 12:47, Andrei Cherechesu (OSS) wrote: Andrei Cherechesu (8): xen/arm: Add NXP LINFlexD UART Driver xen/arm: Add NXP LINFlexD UART early printk support I have committed the first two patches. Cheers, -- Julien Grall

Re: [PATCH] x86/io-apic: fix directed EOI when using AMd-Vi interrupt remapping

2024-10-18 Thread Marek Marczykowski-Górecki
On Fri, Oct 18, 2024 at 10:08:13AM +0200, Roger Pau Monne wrote: > When using AMD-VI interrupt remapping the vector field in the IO-APIC RTE is > repurposed to contain part of the offset into the remapping table. Previous > to > 2ca9fbd739b8 Xen had logic so that the offset into the interrupt rem

[xen-unstable test] 188248: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188248 xen-unstable real [real] flight 188280 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188248/ http://logs.test-lab.xenproject.org/osstest/logs/188280/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH v1 1/5] xen/riscv: add stub for share_xen_page_with_guest()

2024-10-18 Thread oleksii . kurochko
On Thu, 2024-10-17 at 16:51 +0200, Jan Beulich wrote: > On 16.10.2024 11:15, Oleksii Kurochko wrote: > > To avoid the following linkage fail the stub for > > share_xen_page_with_guest() > > is introduced: > > What do you intend to express with "is introduced"? Is there a > problem now? > Would the

[ovmf bisection] complete test-amd64-amd64-xl-qemuu-ovmf-amd64

2024-10-18 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ovmf-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xen

Re: [PATCH] Update deprecated SPDX license identifiers

2024-10-18 Thread Julien Grall
Hi Frediano, On 18/10/2024 13:07, Frediano Ziglio wrote: On Fri, Oct 4, 2024 at 9:08 AM Frediano Ziglio wrote: On Thu, Sep 26, 2024 at 10:51 AM Frediano Ziglio wrote: As specified in LICENSES/GPL-2.0: - GPL-2.0 -> GPL-2.0-only; - GPL-2.0+ -> GPL-2.0-or-later. Signed-off-by: Frediano Zigli

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Roger Pau Monné
On Fri, Oct 18, 2024 at 01:48:27PM +0100, Frediano Ziglio wrote: > On Fri, Oct 18, 2024 at 12:41 PM Roger Pau Monné wrote: > > > > On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > > > +#define DECLARE_IMPORT(name) name = . + (__LINE__ * MULT) > > > + > > > +ENTRY(dummy_start) > >

[ovmf test] 188253: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188253 ovmf real [real] flight 188264 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188253/ http://logs.test-lab.xenproject.org/osstest/logs/188264/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

[PATCH] docs: fusa: Add dom0less domain configuration requirements

2024-10-18 Thread Ayan Kumar Halder
From: Michal Orzel Add requirements for dom0less domain creation. Signed-off-by: Michal Orzel Signed-off-by: Ayan Kumar Halder --- .../arm64/dom0less_domain_config.rst | 267 ++ docs/fusa/reqs/market-reqs/reqs.rst | 15 + docs/fusa/reqs/product-reqs/arm64/r

[xen-unstable test] 188193: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188193 xen-unstable real [real] flight 188240 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188193/ http://logs.test-lab.xenproject.org/osstest/logs/188240/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [XEN PATCH v1 0/3] automation: add x86_64 test (linux argo)

2024-10-18 Thread Marek Marczykowski-Górecki
On Thu, Oct 17, 2024 at 08:25:57PM +0100, Andrew Cooper wrote: > I was thinking of experimenting with a separate top-level repo that does > nothing but has a few manual runs to populate artefacts, and having the > Xen tests pull artefacts from here rather than from earlier build jobs. This sounds

Re: [PATCH] Update deprecated SPDX license identifiers

2024-10-18 Thread Julien Grall
Hi, On 18/10/2024 13:28, Frediano Ziglio wrote: On Fri, Oct 18, 2024 at 1:11 PM Julien Grall wrote: Hi Frediano, On 18/10/2024 13:07, Frediano Ziglio wrote: On Fri, Oct 4, 2024 at 9:08 AM Frediano Ziglio wrote: On Thu, Sep 26, 2024 at 10:51 AM Frediano Ziglio wrote: As specified in LI

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Frediano Ziglio
On Fri, Oct 18, 2024 at 12:41 PM Roger Pau Monné wrote: > > On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > > The current method to include 32 bit C boot code is: > > - compile each function we want to use into a separate object file; > > - each function is compiled with -fpic o

[ovmf test] 188241: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188241 ovmf real [real] flight 188246 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188241/ http://logs.test-lab.xenproject.org/osstest/logs/188246/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Roger Pau Monné
On Fri, Oct 18, 2024 at 02:04:22PM +0200, Jan Beulich wrote: > On 18.10.2024 13:41, Roger Pau Monné wrote: > > On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > >> @@ -25,14 +23,47 @@ $(obj32): XEN_CFLAGS := $(CFLAGS_x86_32) -fpic > >> $(obj)/%.32.o: $(src)/%.c FORCE > >>$(cal

Re: [PATCH v6 14/44] x86/boot: introduce boot module interator

2024-10-18 Thread Jason Andryuk
On 2024-10-17 13:02, Daniel P. Smith wrote: Provide an iterator to go through boot module array searching based on type. Signed-off-by: Daniel P. Smith --- Changes since v5: - documented help next_boot_module_index - switch to unsigned int for next_boot_module_index - changes identified that BO

[linux-linus test] 188202: tolerable FAIL - PUSHED

2024-10-18 Thread osstest service owner
flight 188202 linux-linus real [real] flight 188261 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188202/ http://logs.test-lab.xenproject.org/osstest/logs/188261/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Roger Pau Monné
On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > The current method to include 32 bit C boot code is: > - compile each function we want to use into a separate object file; > - each function is compiled with -fpic option; > - convert these object files to binary files. This operati

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Frediano Ziglio
On Thu, Oct 17, 2024 at 5:00 PM Anthony PERARD wrote: > > On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > > +$(obj)/build32.base.lds: AFLAGS-y += -DGAP=$(text_gap) > > -DTEXT_DIFF=$(text_diff) > > +$(obj)/build32.offset.lds: AFLAGS-y += -DGAP=$(text_gap) > > -DTEXT_DIFF=$(text

[qemu-mainline bisection] complete test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict

2024-10-18 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tr

[ovmf test] 188251: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188251 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/188251/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 188152 build-amd64-xsm

Re: [PATCH v3 1/6] xen/arm: Skip initializing the BSS section when it is empty

2024-10-18 Thread Julien Grall
Hi Ayan, On 10/10/2024 15:03, Ayan Kumar Halder wrote: If the BSS section is empty, then the function can just return. This is more than "can", right? If we don't do it, we will end up to zero outside of BSS. This could be critical data... Also, I am tempted to suggest to add a Fixes tag be

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Frediano Ziglio
On Fri, Oct 18, 2024 at 1:59 PM Roger Pau Monné wrote: > > On Fri, Oct 18, 2024 at 01:48:27PM +0100, Frediano Ziglio wrote: > > On Fri, Oct 18, 2024 at 12:41 PM Roger Pau Monné > > wrote: > > > > > > On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote: > > > > +#define DECLARE_IMPORT

Re: [PATCH v3 2/6] xen/arm: mpu: Introduce choice between MMU and MPU

2024-10-18 Thread Julien Grall
On 14/10/2024 19:43, Luca Fancellu wrote: Hi Ayan, On 10 Oct 2024, at 15:03, Ayan Kumar Halder wrote: There are features in the forthcoming patches which are dependent on MPU. For eg fixed start address. Also, some of the Xen features (eg STATIC_MEMORY) will be selected by the MPU configur

[PATCH v6 1/3] x86/msi: harden stale pdev handling

2024-10-18 Thread Stewart Hildebrand
Dom0 normally informs Xen of PCI device removal via PHYSDEVOP_pci_device_remove, e.g. in response to SR-IOV disable or hot-unplug. We might find ourselves with stale pdevs if a buggy dom0 fails to report removal via PHYSDEVOP_pci_device_remove. In this case, attempts to access the config space of t

[PATCH v6 2/3] xen/pci: introduce PF<->VF links

2024-10-18 Thread Stewart Hildebrand
Add links between a VF's struct pci_dev and its associated PF struct pci_dev. Move the calls to pci_get_pdev()/pci_add_device() down to avoid dropping and re-acquiring the pcidevs_lock(). During PF removal, unlink VF from PF and mark the VF broken. As before, VFs may exist without a corresponding

[PATCH v6 3/3] x86/msi: fix locking for SR-IOV devices

2024-10-18 Thread Stewart Hildebrand
In commit 4f78438b45e2 ("vpci: use per-domain PCI lock to protect vpci structure") a lock was moved from allocate_and_map_msi_pirq() to the caller and changed from pcidevs_lock() to read_lock(&d->pci_lock). However, one call path wasn't updated to reflect the change, leading to a failed assertion o

[PATCH v6 0/3] xen: SR-IOV fixes

2024-10-18 Thread Stewart Hildebrand
A fix for handling of stale pdevs, and a fix for a regressiong related to a locking change. Stewart Hildebrand (3): x86/msi: harden stale pdev handling xen/pci: introduce PF<->VF links x86/msi: fix locking for SR-IOV devices xen/arch/x86/msi.c| 56 +-- xen/d

[PATCH] x86/io-apic: fix directed EOI when using AMd-Vi interrupt remapping

2024-10-18 Thread Roger Pau Monne
When using AMD-VI interrupt remapping the vector field in the IO-APIC RTE is repurposed to contain part of the offset into the remapping table. Previous to 2ca9fbd739b8 Xen had logic so that the offset into the interrupt remapping table would match the vector. Such logic was mandatory for end of

Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it

2024-10-18 Thread Frediano Ziglio
On Thu, Oct 17, 2024 at 6:13 PM Andrew Cooper wrote: > > On 17/10/2024 2:31 pm, Frediano Ziglio wrote: > > The current method to include 32 bit C boot code is: > > - compile each function we want to use into a separate object file; > > - each function is compiled with -fpic option; > > - convert t

Re: [XEN PATCH v1 2/3] ocaml/libs: Fill build failure due to unused variable in ocaml macro

2024-10-18 Thread Javi Merino
On Thu, Oct 17, 2024 at 06:47:44PM +0100, Andrew Cooper wrote: > On 17/10/2024 5:20 pm, Javi Merino wrote: > > On Fedora 40, the build fails with: > > > > gcc -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall > > -Wstrict-prototypes -Wno-unused-but-set-variable -Wno-unused-local-typedefs

[ovmf test] 188219: regressions - FAIL

2024-10-18 Thread osstest service owner
flight 188219 ovmf real [real] flight 188236 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/188219/ http://logs.test-lab.xenproject.org/osstest/logs/188236/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-

Re: [XEN PATCH v1 2/3] ocaml/libs: Fill build failure due to unused variable in ocaml macro

2024-10-18 Thread Andrew Cooper
On 18/10/2024 9:50 am, Javi Merino wrote: > On Thu, Oct 17, 2024 at 06:47:44PM +0100, Andrew Cooper wrote: >> On 17/10/2024 5:20 pm, Javi Merino wrote: >>> On Fedora 40, the build fails with: >>> >>> gcc -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall >>> -Wstrict-prototypes -Wno-unused-

Re: [XEN PATCH v1 2/3] ocaml/libs: Fill build failure due to unused variable in ocaml macro

2024-10-18 Thread Christian Lindig
> On 17 Oct 2024, at 18:47, Andrew Cooper wrote: > > > So, I think this is a better fix: > > @@ -69,6 +69,7 @@ static void Noreturn xsd_glue_failwith( > free(str); > > caml_raise_with_arg(*caml_named_value("xsg.error_v1"), msg); > + CAMLnoreturn; > } > #define xsd_g

Re: [PATCH v4] xen: Remove dependency between pciback and privcmd

2024-10-18 Thread Jürgen Groß
On 12.10.24 10:45, Jiqian Chen wrote: Commit 2fae6bb7be32 ("xen/privcmd: Add new syscall to get gsi from dev") adds a weak reverse dependency to the config XEN_PRIVCMD definition, that dependency causes xen-privcmd can't be loaded on domU, because dependent xen-pciback isn't always be loaded succ