Re: [PATCH] MAINTAINERS: minor file line updates

On 04.10.2024 11:55, Frediano Ziglio wrote: > "xen/arch/arm/include/asm/tee" is a directory and should be terminated > by a slash ("/"). > "xen/arch/*/include/asm/*/mem_access.h" did not match any files > from shell, all "mem_access.h" files are directly under "asm" directory. The latter is intent

Re: [PATCH] x86: Introduce X86_ET_* constants in x86-defns.h

On 04/10/2024 7:43 am, Jan Beulich wrote: > On 03.10.2024 19:04, Andrew Cooper wrote: >> The FRED spec architecturalises the Event Type encoding, previously exposed >> only in VMCB/VMCS fields. >> >> Introduce the constants in x86-defns.h, making them a bit more consice, and >> retire enum x86_even

[PATCH v2] MAINTAINERS: minor file line update

"xen/arch/arm/include/asm/tee" is a directory and should be terminated by a slash ("/"). Signed-off-by: Frediano Ziglio --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- Changes since v1: - removed second change, it was intentional. diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH] Update deprecated SPDX license identifiers

On Thu, Sep 26, 2024 at 10:51 AM Frediano Ziglio wrote: > > As specified in LICENSES/GPL-2.0: > - GPL-2.0 -> GPL-2.0-only; > - GPL-2.0+ -> GPL-2.0-or-later. > > Signed-off-by: Frediano Ziglio ping Frediano

[PATCH v3 02/19] xen: Update header guards - X86

Updated headers related to x86 architecture. Signed-off-by: Frediano Ziglio --- xen/arch/x86/boot/video.h | 6 +++--- xen/arch/x86/cpu/mcheck/barrier.h | 6 +++--- xen/arch/x86/cpu/mcheck/mcaction.h | 4 ++-- xen/arch/x86/cpu/mcheck/mc

[PATCH v3 07/19] xen: Update header guards - EFI

Updated headers related to EFI. Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/asm/x86_64/efibind.h | 4 ++-- xen/include/efi/efiapi.h | 4 ++-- xen/include/efi/eficapsule.h | 4 ++-- xen/include/efi/eficon.h | 4 ++-- xen/include/efi/efide

[PATCH v3 00/19] Update header guards bases on new coding style

With the help of some scripts and manual checking I updated header guards. As the changes are pretty large patch was split based on maintainers to reduce mail spamming. Excluded public headers from the update, they are API, software like Qemu will fail to compile if changed. Changes since v1: -

[XEN PATCH v1 0/3] configurable stdvga & pmtimer emulation

This series presents previously posted patches [1,2] with review comments addressed, Patches introduce build options for stdvga and ACPI PM timer emulation drivers to make them configurable with possibility to be disabled for finer-tuned setups that don't need this code. New config options are now

[XEN PATCH v1 1/3] x86/hvm: introduce config option for ACPI PM timer

Introduce config option X86_PMTIMER so that pmtimer emulation driver can later be made configurable and be disabled on systems that don't need it. As a first step the option is hidden from user, thus not making any functional changes here. Signed-off-by: Sergiy Kibrik CC: Jan Beulich --- xen/a

[XEN PATCH v1 2/3] x86/hvm: introduce config option for stdvga emulation

Introduce config option X86_STDVGA so that stdvga emulation driver can later be made configurable and be disabled on systems that don't need it. As a first step the option is hidden from user. No functional changes intended. Signed-off-by: Sergiy Kibrik CC: Jan Beulich --- xen/arch/x86/Kconfig

[PATCH v2 0/3] Register Xen's load address as a boot module

This patch series registers Xen's load address as a boot module and introduce virt_to_maddr(), and drops LINK_TO_LOAD() to use virt_to_maddr() instead. --- Changes in V2: - Update the commit message ( drop depency from "device tree mapping" patch series as it was merged to staging ) - Other c

[PATCH v2 2/3] xen/riscv: switch LINK_TO_LOAD() to virt_to_maddr()

Use virt_to_maddr() instead of LINK_TO_LOAD as virt_to_maddr() covers all the cases where LINK_TO_LOAD() is used. Signed-off-by: Oleksii Kurochko --- Changes in V2: - Drop the cast of virt_to_maddr() argument in remove_identity_mapping() as this cast is done inside virtu_to_maddr() wrapper ma

Re: [PULL v2 0/5] Xen Queue

On Thu, 3 Oct 2024 at 19:57, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > The following changes since commit 423be09ab9492735924e73a2d36069784441ebc6: > > Merge tag 'warn-pull-request' of https://gitlab.com/marcandre.lureau/qemu > into staging (2024-10-03 10:32:54 +0100) > > are

[PATCH v2 1/3] xen/riscv: implement virt_to_maddr()

Implement the virt_to_maddr() function to convert virtual addresses to machine addresses, including checks for address ranges such as the direct mapping area (DIRECTMAP_VIRT_START) and the Xen virtual address space. To implement this, the phys_offset variable is made accessible outside of riscv/mm.

[PATCH v2 3/3] xen/riscv: register Xen's load address as a boot module

Avoid using BOOTMOD_XEN region for other purposes or boot modules which could result in memory corruption or undefined behaviour. Signed-off-by: Oleksii Kurochko --- Changes in V2: - Drop local variable xen_bootmodule as it won't be used after initialization. - Drop unnecessary cast for the 3rd

Re: [PATCH v3 1/2] x86/fpu: Combine fpu_ctxt and xsave_area in arch_vcpu

Hi, On Thu Oct 3, 2024 at 8:38 PM BST, Andrew Cooper wrote: > On 13/08/2024 3:21 pm, Alejandro Vallejo wrote: > > @@ -299,44 +299,14 @@ void save_fpu_enable(void) > > /* Initialize FPU's context save area */ > > int vcpu_init_fpu(struct vcpu *v) > > { > > -int rc; > > - > > v->arch.ful

Re: [PATCH v2 5/8] xen/arm: platforms: Add NXP S32CC platform code

Hi Julien, Stefano, On 01/10/2024 13:01, Julien Grall wrote: > Hi Andrei, > > On 30/09/2024 12:47, Andrei Cherechesu (OSS) wrote: >> From: Andrei Cherechesu >> >> Add code for NXP S32CC platforms (S32G2, S32G3, S32R45). >> >> S32CC platforms use the NXP LINFlexD UART driver for >> console by defa

[xen-unstable-smoke test] 187966: tolerable all pass - PUSHED

flight 187966 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187966/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v3 17/19] xen: Update header guards - VM event, mem access, monitor

Updated headers related to VM event, mem access AND monitor. Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/asm/hvm/monitor.h | 6 +++--- xen/arch/x86/include/asm/hvm/vm_event.h | 6 +++--- xen/arch/x86/include/asm/mem_access.h | 6 +++--- xen/arch/x86/include/asm/monitor.h | 6

Re: [PATCH v2 2/7] tests/x86: Introduce a userspace test harness for x86_decode_lite()

On 02.10.2024 17:38, Andrew Cooper wrote: > On 02/10/2024 4:27 pm, Andrew Cooper wrote: >> Despite claiming full APX support in the 2.43 release, binutils trunk doesn't >> tolerate JMPABS at all. Clang-IAS like it but only when encoded as an >> immediate, despite the fact the operand should be a m

Re: [PATCH v2 00/19] Update header guards bases on new coding style

On Fri, Oct 4, 2024 at 7:23 AM Jan Beulich wrote: > > On 03.10.2024 19:59, Frediano Ziglio wrote: > > With the help of some scripts and manual checking I updated header guards. > > > > As the changes are pretty large patch was split based on maintainers > > to reduce mail spamming. > > > > Exclude

Re: [XEN PATCH v1 1/3] x86/hvm: introduce config option for ACPI PM timer

On 04.10.2024 15:09, Roger Pau Monné wrote: > On Fri, Oct 04, 2024 at 12:31:50PM +0300, Sergiy Kibrik wrote: >> --- a/xen/arch/x86/include/asm/domain.h >> +++ b/xen/arch/x86/include/asm/domain.h >> @@ -496,7 +496,8 @@ struct arch_domain >> >> #define has_vlapic(d) (!!((d)->arch.emulation_fl

Re: [XEN PATCH v1 2/3] x86/hvm: introduce config option for stdvga emulation

On 04.10.2024 11:33, Sergiy Kibrik wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -147,6 +147,9 @@ config INTEL_VMX > config X86_PMTIMER > def_bool HVM > > +config X86_STDVGA > + def_bool HVM For both if these I'd also question the naming: They way they're named

Re: [XEN PATCH v1 3/3] x86/hvm: make ACPI PM & stdvga emulation optional

On 04.10.2024 11:35, Sergiy Kibrik wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -742,11 +742,17 @@ int arch_sanitise_domain_config(struct > xen_domctl_createdomain *config) > > static bool emulation_flags_ok(const struct domain *d, uint32_t emflags) > { > +const

[xen-unstable test] 187955: tolerable FAIL - PUSHED

flight 187955 xen-unstable real [real] flight 187967 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/187955/ http://logs.test-lab.xenproject.org/osstest/logs/187967/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

Re: [PATCH] x86/boot: Further simplify CR4 handling in dom0_construct_pv()

On Fri, Oct 04, 2024 at 08:52:52AM +0200, Jan Beulich wrote: > On 03.10.2024 01:20, Andrew Cooper wrote: > > The logic would be more robust disabling SMAP based on its precense in CR4, > > rather than SMAP's accociation with a synthetic feature. > > It's hard to tell what's more robust without kno

Re: [PATCH 1/3] x86/APIC: Switch flat driver to use phys dst for ext ints

On Fri, Oct 04, 2024 at 08:48:05AM +0200, Jan Beulich wrote: > On 03.10.2024 12:51, Roger Pau Monné wrote: > > On Wed, Oct 02, 2024 at 04:17:24PM +0100, Matthew Barnes wrote: > > > > The commit needs a log, doesn't need to be extremely long, but it's > > important to note the reasoning behind usin

[PATCH v3 15/19] xen: Update header guards - RISC-V

Updated headers related to RISC-V. Signed-off-by: Frediano Ziglio --- xen/arch/riscv/include/asm/acpi.h | 6 +++--- xen/arch/riscv/include/asm/asm.h| 6 +++--- xen/arch/riscv/include/asm/atomic.h | 6 +++--- xen/arch/riscv/include/asm/bitops.h | 6 +++--- xe

[PATCH v3 08/19] xen: Update header guards - HYPFS

Updated headers related to HYPFS. Signed-off-by: Frediano Ziglio --- xen/include/xen/hypfs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/xen/hypfs.h b/xen/include/xen/hypfs.h index d8fcac23b4..d6f5725221 100644 --- a/xen/include/xen/hypfs.h +++ b/xen/inc

[PATCH v3 09/19] xen: Update header guards - Intel TXT

Updated headers related to Intel trusted execution technology. Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/asm/tboot.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/include/asm/tboot.h b/xen/arch/x86/include/asm/tboot.h index 818d5fa451..15479

[PATCH v3 01/19] xen: Update header guards - Generic

Updated headers not having specific maintainers. Signed-off-by: Frediano Ziglio --- Changes since v1: - excluded public headers, their guards is an API; - moved here changes needed to compile. --- tools/libs/guest/xg_dom_decompress_unsafe_zstd.c | 2 +- xen/arch/arm/include/asm/hypercall.h

[PATCH v3 05/19] xen: Update header guards - ARM

Updated headers related to ARM. Signed-off-by: Frediano Ziglio --- xen/arch/arm/arm32/lib/assembler.h | 6 +++--- xen/arch/arm/arm64/lib/assembler.h | 6 +++--- xen/arch/arm/decode.h | 6 +++--- xen/arch/arm/include/asm/

[PATCH v3 10/19] xen: Update header guards - I/O MMU

Updated headers related to I/O MMU. Signed-off-by: Frediano Ziglio --- xen/drivers/passthrough/amd/iommu-defs.h | 6 +++--- xen/drivers/passthrough/amd/iommu.h | 6 +++--- xen/drivers/passthrough/ats.h| 6 +++--- xen/drivers/passthrough/vtd/dmar.h | 6 +++--- xen/drivers/p

[PATCH v3 03/19] xen: Update header guards - ACPI

Updated headers related to ACPI. Signed-off-by: Frediano Ziglio --- xen/drivers/acpi/apei/apei-internal.h | 4 ++-- xen/include/acpi/acconfig.h | 6 +++--- xen/include/acpi/acexcep.h| 6 +++--- xen/include/acpi/acglobal.h | 6 +++--- xen/include/ac

[PATCH v3 16/19] xen: Update header guards - Scheduling

Updated headers related to scheduling. Signed-off-by: Frediano Ziglio --- xen/common/sched/private.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/common/sched/private.h b/xen/common/sched/private.h index c0e7c96d24..02ab905412 100644 --- a/xen/common/sched/privat

[PATCH v3 06/19] xen: Update header guards - Device tree

Updated headers related to device tree. Signed-off-by: Frediano Ziglio --- xen/common/libfdt/libfdt_internal.h | 6 +++--- xen/include/xen/bootfdt.h | 6 +++--- xen/include/xen/device_tree.h | 4 ++-- xen/include/xen/libfdt/fdt.h| 6 +++--- xen/include/xen/libfdt/libfdt-x

[PATCH v3 19/19] xen: Update header guards - XSM/Flask

Updated headers related to XSM/Flask. Signed-off-by: Frediano Ziglio --- xen/include/xsm/dummy.h | 6 +++--- xen/include/xsm/xsm.h | 4 ++-- xen/xsm/flask/include/avc.h | 6 +++--- xen/xsm/flask/include/avc_ss.h | 6 +++--- xen/xsm/flask/include/conditional

[PATCH v3 18/19] xen: Update header guards - VPCI

Updated headers related to VPCI. Signed-off-by: Frediano Ziglio --- xen/include/xen/vpci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 41e7c3bc27..d2d2905447 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xe

[PATCH v3 14/19] xen: Update header guards - PPC 64

Updated headers related to PPC 64. Signed-off-by: Frediano Ziglio --- xen/arch/ppc/include/asm/asm-defns.h | 6 +++--- xen/arch/ppc/include/asm/atomic.h| 6 +++--- xen/arch/ppc/include/asm/bitops.h| 6 +++--- xen/arch/ppc/include/asm/boot.h | 6 +++--- xen/arch/ppc/i

[PATCH v3 11/19] xen: Update header guards - Kconfig

Updated headers related to Kconfig. Signed-off-by: Frediano Ziglio --- xen/tools/kconfig/expr.h | 6 +++--- xen/tools/kconfig/images.h | 6 +++--- xen/tools/kconfig/list.h | 4 ++-- xen/tools/kconfig/lkc.h| 6 +++--- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/xen/to

[PATCH v3 13/19] xen: Update header guards - Live patch

Updated headers related to live patching. Signed-off-by: Frediano Ziglio --- xen/arch/x86/include/asm/livepatch.h | 6 +++--- xen/include/xen/livepatch.h | 6 +++--- xen/include/xen/livepatch_elf.h | 6 +++--- xen/include/xen/livepatch_payload.h | 6 +++--- 4 files changed, 12 ins

[PATCH v3 04/19] xen: Update header guards - ARGO

Updated headers related to ARGO. Signed-off-by: Frediano Ziglio --- xen/include/xen/argo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- Changes since v2: - exclude missing public headers. diff --git a/xen/include/xen/argo.h b/xen/include/xen/argo.h index fd4cfdd55c..3ef62dab19

[PATCH v3 12/19] xen: Update header guards - KEXEC

Updated headers related to KEXEC. Signed-off-by: Frediano Ziglio --- xen/include/xen/kexec.h | 6 +++--- xen/include/xen/kimage.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/include/xen/kexec.h b/xen/include/xen/kexec.h index e66eb6a8e5..d9d79902a9 100644 ---

[PATCH] MAINTAINERS: minor file line updates

"xen/arch/arm/include/asm/tee" is a directory and should be terminated by a slash ("/"). "xen/arch/*/include/asm/*/mem_access.h" did not match any files from shell, all "mem_access.h" files are directly under "asm" directory. Signed-off-by: Frediano Ziglio --- MAINTAINERS | 4 ++-- 1 file change

xenvbd driver modifies in-flight data?

Hi, I've got a bit worrying report[1], that using Windows PV block driver, together with backing file opened with O_DIRECT on BTRFS results in checksum errors. At this point it's unclear what exactly happens there, it could be some BTRFS issue, some xen-blkback issue, but since according to report

Re: [XEN PATCH v1 1/3] x86/hvm: introduce config option for ACPI PM timer

On Fri, Oct 04, 2024 at 12:31:50PM +0300, Sergiy Kibrik wrote: > Introduce config option X86_PMTIMER so that pmtimer emulation driver can later > be made configurable and be disabled on systems that don't need it. > > As a first step the option is hidden from user, thus not making any functional >

Re: [XEN PATCH v1 2/3] x86/hvm: introduce config option for stdvga emulation

On Fri, Oct 04, 2024 at 12:33:53PM +0300, Sergiy Kibrik wrote: > Introduce config option X86_STDVGA so that stdvga emulation driver can later > be > made configurable and be disabled on systems that don't need it. > > As a first step the option is hidden from user. No functional changes > intend

Re: [RFC PATCH 05/28] x86: Define the stack protector guard symbol explicitly

On Sat, 28 Sept 2024 at 15:41, Brian Gerst wrote: > > On Wed, Sep 25, 2024 at 2:33 PM Uros Bizjak wrote: > > > > On Wed, Sep 25, 2024 at 5:02 PM Ard Biesheuvel wrote: > > > > > > From: Ard Biesheuvel > > > > > > Specify the guard symbol for the stack cookie explicitly, rather than > > > positio

[XEN PATCH v1 3/3] x86/hvm: make ACPI PM & stdvga emulation optional

Make it possible to build a configuration without code for PM timer or stdvga drivers. This may help to reduce code's footprint a bit for systems that don't run HVM guests and also don't need these devices emulated. Introduced additional check of domain's emulation flags, to cover the case when us

Re: [PATCH v2 5/8] xen/arm: platforms: Add NXP S32CC platform code

On 04/10/2024 16:37, Andrei Cherechesu wrote: Hi Julien, Stefano, Hi Andrei, On 01/10/2024 13:01, Julien Grall wrote: Hi Andrei, On 30/09/2024 12:47, Andrei Cherechesu (OSS) wrote: From: Andrei Cherechesu Add code for NXP S32CC platforms (S32G2, S32G3, S32R45). S32CC platforms use t

Re: [PATCH] CI: Fix builds following qemu-xen update

On 04/10/2024 7:14 pm, Anthony PERARD wrote: > On Fri, Oct 04, 2024 at 06:27:23PM +0100, Andrew Cooper wrote: >> A recent update to qemu-xen has bumped the build requirements, with Python >> 3.8 >> being the new baseline but also needing the 'ensurepip' and 'tomllib/tomli' >> packages. >> >> * Ub

[linux-linus test] 187958: tolerable FAIL - PUSHED

flight 187958 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/187958/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 187948 test-amd64-amd64-xl-qemut-win7-amd64

[ovmf test] 187969: all pass - PUSHED

flight 187969 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187969/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c82bf392c58e60e3e656b13627e3076d709ab796 baseline version: ovmf 91d806917fd2be763f067

Re: [PATCH v2 5/6] dt-overlay: Ignore nodes that do not have __overlay__ as their subnode

On Fri, 4 Oct 2024, Michal Orzel wrote: > Assumption stated in the comments as if fdt_for_each_subnode() checks > for parent < 0 is utterly wrong. If parent is < 0, node offset is set to > 0 (i.e. the very first node in the tree) and the loop's body is executed. > This incorrect assumption causes o

Re: [PATCH v2 6/6] dt-overlay: Print overlay I/O memory ranges in hex

On Fri, 4 Oct 2024, Michal Orzel wrote: > Printing I/O memory rangeset ranges in decimal is not very helpful when > debugging, so switch to hex by adding RANGESETF_prettyprint_hex flag > for iomem_ranges rangeset. > > Signed-off-by: Michal Orzel Acked-by: Stefano Stabellini > --- > Changes in

Re: [PATCH v2 4/6] dt-overlay: Support target-path being root node

On Fri, 4 Oct 2024, Michal Orzel wrote: > Even though in most cases device nodes are not present directly under > the root node, it's a perfectly valid configuration (e.g. Qemu virt > machine dtb). At the moment, we don't handle this scenario which leads > to unconditional addition of extra leading

Re: [RFC PATCH 25/28] x86: Use PIE codegen for the core kernel

On 10/3/24 04:13, Ard Biesheuvel wrote: That said, doing changes like changing "mov $sym" to "lea sym(%rip)" I feel are a complete no-brainer and should be done regardless of any other code generation issues. Yes, this is the primary reason I ended up looking into this in the first place. Ear

Re: [XEN PATCH v1 1/3] x86/hvm: introduce config option for ACPI PM timer

On Fri, 4 Oct 2024, Jan Beulich wrote: > On 04.10.2024 15:09, Roger Pau Monné wrote: > > On Fri, Oct 04, 2024 at 12:31:50PM +0300, Sergiy Kibrik wrote: > >> --- a/xen/arch/x86/include/asm/domain.h > >> +++ b/xen/arch/x86/include/asm/domain.h > >> @@ -496,7 +496,8 @@ struct arch_domain > >> > >>

Re: [XEN PATCH v1 2/3] x86/hvm: introduce config option for stdvga emulation

On Fri, 4 Oct 2024, Roger Pau Monné wrote: > On Fri, Oct 04, 2024 at 12:33:53PM +0300, Sergiy Kibrik wrote: > > Introduce config option X86_STDVGA so that stdvga emulation driver can > > later be > > made configurable and be disabled on systems that don't need it. > > > > As a first step the opti

Re: [XEN PATCH v2 1/3] EFI: address a violation of MISRA C Rule 13.6

On Wed, Oct 02, 2024 at 05:36:47PM -0700, Stefano Stabellini wrote: > On Mon, 30 Sep 2024, Federico Serafini wrote: > > guest_handle_ok()'s expansion contains a sizeof() involving its > > first argument which is guest_handle_cast(). > > The expansion of the latter, in turn, contains a variable > >

[ovmf test] 187972: all pass - PUSHED

flight 187972 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187972/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf df884297fd57aac379d227925e27211e667974ee baseline version: ovmf c82bf392c58e60e3e656b

Re: [PATCH] x86/boot: Further simplify CR4 handling in dom0_construct_pv()

On 04/10/2024 7:52 am, Jan Beulich wrote: > On 03.10.2024 01:20, Andrew Cooper wrote: >> The logic would be more robust disabling SMAP based on its precense in CR4, >> rather than SMAP's accociation with a synthetic feature. > It's hard to tell what's more robust without knowing what future changes

[libvirt test] 187961: tolerable all pass - PUSHED

flight 187961 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/187961/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 187945 test-amd64-amd64-libvirt 15 migrate-s

Re: [XEN PATCH 10/12] efi: address violation of MISRA C Rule 16.3

On Tue, Sep 10, 2024 at 12:09:02PM +0200, Federico Serafini wrote: > Use agreed syntax for pseudo-keyword fallthrough to meet the > requirements to deviate a violation of MISRA C:2012 Rule 16.3: > "An unconditional `break' statement shall terminate every > switch-clause". > > No functional change.

[PATCH] CI: Fix builds following qemu-xen update

A recent update to qemu-xen has bumped the build requirements, with Python 3.8 being the new baseline but also needing the 'ensurepip' and 'tomllib/tomli' packages. * Ubuntu/Debian package 'ensurepip' separately, but it can be obtained by installing the python3-venv package. * 'tomllib' was

[ovmf test] 187973: all pass - PUSHED

flight 187973 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187973/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 54469a6918320591a3ec318eada60aed3c75334c baseline version: ovmf df884297fd57aac379d22

[ovmf test] 187977: all pass - PUSHED

flight 187977 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187977/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 80d9b4449182cd17484cae72269992e642095a00 baseline version: ovmf 8cce048d4834d6967a568

[xen-unstable-smoke test] 187975: tolerable all pass - PUSHED

flight 187975 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187975/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[xen-unstable test] 187968: tolerable FAIL - PUSHED

flight 187968 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/187968/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-qcow220 leak-check/checkfail blocked in 187955 test-amd64-amd64-xl-qemut-win7-amd64

[PATCH v2 1/6] dt-overlay: Fix NULL pointer dereference

Attempt to attach an overlay (xl dt-overlay attach) to a domain without first adding this overlay to Xen (xl dt-overlay add) results in an overlay track entry being NULL in handle_attach_overlay_nodes(). This leads to NULL pointer dereference and the following data abort crash: (XEN) Cannot find a

[PATCH v2 3/6] dt-overlay: Remove ASSERT_UNREACHABLE from add_nodes()

The assumption stated in the comment that the code will never get there is incorrect. In overlay_get_nodes_info() we manually combine path from target-path property with the node path by adding '/' as a separator. This can differ from a path obtained by libfdt due to more advanced logic used there

[PATCH v2 4/6] dt-overlay: Support target-path being root node

Even though in most cases device nodes are not present directly under the root node, it's a perfectly valid configuration (e.g. Qemu virt machine dtb). At the moment, we don't handle this scenario which leads to unconditional addition of extra leading '/' in the node full path. This makes the attem

[PATCH v2 5/6] dt-overlay: Ignore nodes that do not have __overlay__ as their subnode

Assumption stated in the comments as if fdt_for_each_subnode() checks for parent < 0 is utterly wrong. If parent is < 0, node offset is set to 0 (i.e. the very first node in the tree) and the loop's body is executed. This incorrect assumption causes overlay_node_count() to also count nodes that do

[PATCH v2 2/6] device-tree: Remove __init from unflatten_dt_alloc()

With CONFIG_OVERLAY_DTB=y, unflatten_dt_alloc() is used as part of unflatten_dt_node() used during runtime. In case of a binary compiled such as unflatten_dt_alloc() does not get inlined (e.g. using -Og), attempt to add an overlay to Xen (xl dt-overlay add) results in a crash. (XEN) Instruction Ab

[PATCH v2 6/6] dt-overlay: Print overlay I/O memory ranges in hex

Printing I/O memory rangeset ranges in decimal is not very helpful when debugging, so switch to hex by adding RANGESETF_prettyprint_hex flag for iomem_ranges rangeset. Signed-off-by: Michal Orzel --- Changes in v2: - New patch --- xen/common/dt-overlay.c | 3 ++- 1 file changed, 2 insertions(+)

[PATCH v2 0/6] xen/arm: dt overlay fixes

This series contains fixes and improvements after doing some tests with DT overlay support in Xen. I split the series so that each patch handles a separate issue. Michal Orzel (6): dt-overlay: Fix NULL pointer dereference device-tree: Remove __init from unflatten_dt_alloc() dt-overlay: Remov

Re: [RFC PATCH 05/28] x86: Define the stack protector guard symbol explicitly

On Wed, Sep 25, 2024 at 5:02 PM Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > Specify the guard symbol for the stack cookie explicitly, rather than > positioning it exactly 40 bytes into the per-CPU area. Doing so removes > the need for the per-CPU region to be absolute rather than relative

[xen-unstable-smoke test] 187971: tolerable all pass - PUSHED

flight 187971 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/187971/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 187974: all pass - PUSHED

flight 187974 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/187974/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8cce048d4834d6967a568f3a0adc1efcf97c80c7 baseline version: ovmf 54469a6918320591a3ec3

Re: [PATCH] CI: Fix builds following qemu-xen update

On Fri, Oct 04, 2024 at 06:27:23PM +0100, Andrew Cooper wrote: > A recent update to qemu-xen has bumped the build requirements, with Python 3.8 > being the new baseline but also needing the 'ensurepip' and 'tomllib/tomli' > packages. > > * Ubuntu/Debian package 'ensurepip' separately, but it can