On Tue, 2024-07-02 at 14:02 +0200, Jan Beulich wrote:
> On 02.07.2024 13:01, Oleksii Kurochko wrote:
> > Support for specifying "raw" insns was added only in 2.38.
> > To support older version it would be better switch to .insn
> > with operands.
> >
> > The following compilation error occurs:
> >
On 02.07.2024 13:01, Oleksii Kurochko wrote:
> The following generic functions were introduced:
> * test_bit
> * generic__test_and_set_bit
> * generic__test_and_clear_bit
> * generic__test_and_change_bit
>
> These functions and macros can be useful for architectures
> that don't have corresponding
On 02.07.2024 15:03, Alejandro Vallejo wrote:
> --- a/xen/include/xen/vmap.h
> +++ b/xen/include/xen/vmap.h
> @@ -1,34 +1,131 @@
> +/*
> + * Interface to map physical memory onto contiguous virtual memory areas.
> + *
> + * Two ranges of linear address space are reserved for this purpose: A
> gene
On Tue, Jul 02, 2024 at 11:52:04AM +0200, Jan Beulich wrote:
> PHYSDEVOP_pirq_eoi_gmfn_v accepting just a single GFN implies that no
> more than 32k pIRQ-s can be used by a domain on x86. Document this upper
> bound.
>
> To also enforce the limit, (ab)use both arch_hwdom_irqs() (changing its
> par
On Tue, Jul 02, 2024 at 11:52:38AM +0200, Jan Beulich wrote:
> PVH in particular has no (externally visible) notion of pIRQ-s. Mention
> that in the description of the respective command line option and have
> arch_hwdom_irqs() also reflect this (thus suppressing the log message
> there as well, as
On 03.07.2024 09:51, Roger Pau Monné wrote:
> On Tue, Jul 02, 2024 at 11:52:38AM +0200, Jan Beulich wrote:
>> PVH in particular has no (externally visible) notion of pIRQ-s. Mention
>> that in the description of the respective command line option and have
>> arch_hwdom_irqs() also reflect this (thu
On Wed, Jul 03, 2024 at 10:00:51AM +0200, Jan Beulich wrote:
> On 03.07.2024 09:51, Roger Pau Monné wrote:
> > On Tue, Jul 02, 2024 at 11:52:38AM +0200, Jan Beulich wrote:
> >> PVH in particular has no (externally visible) notion of pIRQ-s. Mention
> >> that in the description of the respective com
New patch 1 addresses late review comments raised by Roger for a change
that was already committed.
1: amend 'cmdline: document and enforce "extra_guest_irqs" upper bounds'
2: cmdline: "extra_guest_irqs" is inapplicable to PVH
Jan
Address late review comments for what is now commit 17f6d398f765:
- bound max_irqs right away against nr_irqs
- introduce a #define for a constant used twice
Signed-off-by: Jan Beulich
---
v5: New.
--- a/xen/arch/x86/io_apic.c
+++ b/xen/arch/x86/io_apic.c
@@ -2663,15 +2663,16 @@ void __init ioap
PVH in particular has no (externally visible) notion of pIRQ-s. Mention
that in the description of the respective command line option and have
arch_hwdom_irqs() also reflect this (thus suppressing the log message
there as well, as being pretty meaningless in this case anyway).
Suggested-by: Roger
On Wed, 2024-07-03 at 09:24 +0200, Jan Beulich wrote:
> On 02.07.2024 13:01, Oleksii Kurochko wrote:
> > The following generic functions were introduced:
> > * test_bit
> > * generic__test_and_set_bit
> > * generic__test_and_clear_bit
> > * generic__test_and_change_bit
> >
> > These functions and
On 03.07.2024 10:44, Jan Beulich wrote:
> Address late review comments for what is now commit 17f6d398f765:
> - bound max_irqs right away against nr_irqs
> - introduce a #define for a constant used twice
>
> Signed-off-by: Jan Beulich
Actually should also have added
Requested-by: Roger Pau Monn
On 03.07.2024 10:47, Oleksii wrote:
> On Wed, 2024-07-03 at 09:24 +0200, Jan Beulich wrote:
>> On 02.07.2024 13:01, Oleksii Kurochko wrote:
>>> The following generic functions were introduced:
>>> * test_bit
>>> * generic__test_and_set_bit
>>> * generic__test_and_clear_bit
>>> * generic__test_and_c
On Wed, Jul 03, 2024 at 10:47:36AM +0200, Jan Beulich wrote:
> On 03.07.2024 10:44, Jan Beulich wrote:
> > Address late review comments for what is now commit 17f6d398f765:
> > - bound max_irqs right away against nr_irqs
> > - introduce a #define for a constant used twice
> >
> > Signed-off-by: Ja
On Wed, Jul 03, 2024 at 10:45:41AM +0200, Jan Beulich wrote:
> PVH in particular has no (externally visible) notion of pIRQ-s. Mention
> that in the description of the respective command line option and have
> arch_hwdom_irqs() also reflect this (thus suppressing the log message
> there as well, as
flight 186637 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/186637/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 186625
test-amd64-amd64-libvirt 15 migrate-s
On Wed, 2024-07-03 at 10:43 +0200, Jan Beulich wrote:
> New patch 1 addresses late review comments raised by Roger for a
> change
> that was already committed.
>
> 1: amend 'cmdline: document and enforce "extra_guest_irqs" upper
> bounds'
> 2: cmdline: "extra_guest_irqs" is inapplicable to PVH
>
From: Shawn Anastasio
Arm's setup.c contains a collection of functions for parsing memory map
and other boot information from a device tree. Since these routines are
generally useful on any architecture that supports device tree booting,
move them into xen/common/device-tree.
Suggested-by: Julie
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/include/asm/config.h | 6 +
xen/arch/riscv/include/asm/mm.h | 2 ++
xen/arch/riscv/mm.c | 37 +
3 files changed, 40 insertions(+), 5 deletions(-)
diff --git a/xen/arch/riscv/include/asm/confi
Except mapping of FDT, it is also printing command line passed by
a DTB and initialize bootinfo from a DTB.
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/riscv64/head.S | 3 +++
xen/arch/riscv/setup.c| 21 +
2 files changed, 24 insertions(+)
diff --git a/xen/ar
Signed-off-by: Oleksii Kurochko
---
xen/arch/riscv/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/riscv/Kconfig b/xen/arch/riscv/Kconfig
index 74ad019fe7..1863a5d117 100644
--- a/xen/arch/riscv/Kconfig
+++ b/xen/arch/riscv/Kconfig
@@ -5,6 +5,7 @@ config RISCV
config RISCV_6
Current patch series introduces device tree mapping for RISC-V.
Also, it introduces common stuff for working with fdt which is
based on the patches from [1]:
[PATCH v4 2/6] xen/device-tree: Move Arm's setup.c bootinfo functions to
common
[PATCH v4 3/6] xen/common: Move Arm's bootfdt.c
All cha
From: Shawn Anastasio
Move Arm's bootfdt.c to xen/common so that it can be used by other
device tree architectures like PPC and RISCV.
Suggested-by: Julien Grall
Signed-off-by: Shawn Anastasio
Acked-by: Julien Grall
Signed-off-by: Oleksii Kurochko
---
Changes in v5:
- add guard #ifdef CONFI
Missed to write in the cover letter that this patch series is based on:
[PATCH for 4.20 v9 0/5] RISCV basic exception handling implementation
~ Oleksii
On Wed, 2024-07-03 at 12:42 +0200, Oleksii Kurochko wrote:
> Current patch series introduces device tree mapping for RISC-V.
>
> Also, it int
On Wed Jul 3, 2024 at 8:41 AM BST, Jan Beulich wrote:
> On 02.07.2024 15:03, Alejandro Vallejo wrote:
> > --- a/xen/include/xen/vmap.h
> > +++ b/xen/include/xen/vmap.h
> > @@ -1,34 +1,131 @@
> > +/*
> > + * Interface to map physical memory onto contiguous virtual memory areas.
> > + *
> > + * Two r
In it's current form it's rather cryptic for uninitiated, so this patch
documents everything in there to make it more palatable.
No functional change.
Signed-off-by: Alejandro Vallejo
---
v2:
* Removed Doxygen-style markers on comments.
* Added some missing documentations for the return type
Today Xen multicall debugging needs to be enabled via modifying a
define in a source file for getting debug data of multicall errors
encountered by users.
Switch multicall debugging to depend on a boot parameter "xen_mc_debug"
instead, enabling affected users to boot with the new parameter set in
On 03.07.2024 13:19, Alejandro Vallejo wrote:
> +/*
> + * Unmaps a range of virtually contiguous memory from one of the vmap regions
> + *
> + * The system remembers internally how wide the mapping is and unmaps it all.
Seeing this is still taken verbatim ...
> + * It also can determine the vmap
On 01.07.2024 15:36, Alessandro Zucchelli wrote:
> --- a/xen/include/xen/err.h
> +++ b/xen/include/xen/err.h
> @@ -1,5 +1,6 @@
> -#if !defined(__XEN_ERR_H__) && !defined(__ASSEMBLY__)
> -#define __XEN_ERR_H__
> +#ifndef INCLUDE_XEN_ERR_H
> +#define INCLUDE_XEN_ERR_H
There once was a document (or w
On 01.07.2024 13:10, Alessandro Zucchelli wrote:
> --- a/docs/misra/safe.json
> +++ b/docs/misra/safe.json
> @@ -68,6 +68,14 @@
> },
> {
> "id": "SAF-8-safe",
> +"analyser": {
> +"eclair": "MC3R1.D4.10"
> +},
> +"nam
On 01.07.2024 15:36, Alessandro Zucchelli wrote:
> --- a/docs/misra/safe.json
> +++ b/docs/misra/safe.json
> @@ -90,6 +90,14 @@
> "name": "Dir 4.10: direct inclusion guard before",
> "text": "Headers with just the direct inclusion guard before the
> inclusion guard are sa
On 01.07.2024 15:43, Alessandro Zucchelli wrote:
> From: Maria Celeste Cesario
>
> Modify creation rule for asm-offsets.h to conform to
> the new standard and to not generate conflicting guards
> between architectures (which is a violation of the directive).
> Modify generic-y creation rule to ge
On Wed Jul 3, 2024 at 12:58 PM BST, Jan Beulich wrote:
> On 03.07.2024 13:19, Alejandro Vallejo wrote:
> > +/*
> > + * Unmaps a range of virtually contiguous memory from one of the vmap
> > regions
> > + *
> > + * The system remembers internally how wide the mapping is and unmaps it
> > all.
>
>
On 01.07.2024 15:45, Alessandro Zucchelli wrote:
> From: Nicola Vetrini
>
> Signed-off-by: Nicola Vetrini
> Signed-off-by: Alessandro Zucchelli
So no description at all for a somewhat unobvious issue with, I think,
a pretty obvious (but entirely different) solution? And that (obvious)
alternat
On 01.07.2024 15:46, Alessandro Zucchelli wrote:
> From: Maria Celeste Cesario
>
> Edit inclusion guards in order to make them consistent with the
> estabilished naming conventions.
The code changes all look okay to me, but as before: Where did those
"established naming conventions" go? Grep-ing
On 01.07.2024 15:46, Alessandro Zucchelli wrote:
> --- a/xen/build.mk
> +++ b/xen/build.mk
> @@ -18,6 +18,8 @@ quiet_cmd_compile.h = UPD $@
> define cmd_compile.h
> if [ ! -r $@ -o -O $@ ]; then \
> cat .banner; \
> + echo '#ifndef INCLUDE_XEN_COMPILE_H' >> $(dot-target).tmp; \
On 01.07.2024 15:46, Alessandro Zucchelli wrote:
> This section explains which format should be followed by header
> inclusion guards via a drop-down list of rules.
Ah, so this answers my earlier question regarding where the naming
rules are spelled out. Yet why is this not much earlier in the ser
On Wed, 2024-07-03 at 13:58 +0200, Jan Beulich wrote:
> On 03.07.2024 13:19, Alejandro Vallejo wrote:
> > +/*
> > + * Unmaps a range of virtually contiguous memory from one of the
> > vmap regions
> > + *
> > + * The system remembers internally how wide the mapping is and
> > unmaps it all.
>
> Se
Minimum fixes to rebuild the containers, following the HEREDOC problems.
Unrelated to the HEREDOC problems, Archlinux and CentOS 7 need aditional
chagnes to rebuild.
There will be subsequent work to make some improvements to CI for 4.19, so in
particular we're testing with up-to-date LTS distros.
CentOS 7 is fully End-of-life as of 2024-06-30, and the Yum repo configuration
points at URLs which have become non-existent.
First, start by using a heredoc RUN for legibility. It's important to use
`set -e` to offset the fact that we're no longer chaining every command
together with an &&.
Als
As per:
https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#here-documents
For inline files, use COPY with a heredoc, rather than opencoding it through
/bin/sh.
No practical change.
Signed-off-by: Andrew Cooper
---
CC: Anthony PERARD
CC: Stefano Stabellini
C
Commit b5739330d7f4 introduced the use of heredocs in the jessie/stretch
dockerfiles.
It turns out this was introduced by BuildKit in 2018 along with a
standardisation of Dockerfile syntax, and has subsequently been adopted by the
docker community.
Annotate all dockerfiles with a statement of the
These packages have moved out of main to AUR, and are not easily accessable
any more. Drop them, because they're only needed for RomBIOS which is very
legacy these days.
Signed-off-by: Andrew Cooper
---
CC: Anthony PERARD
CC: Stefano Stabellini
CC: Doug Goldstein
CC: Roger Pau Monné
CC: Olek
On Wed, Jul 03, 2024 at 03:19:59PM +0100, Andrew Cooper wrote:
> Commit b5739330d7f4 introduced the use of heredocs in the jessie/stretch
> dockerfiles.
>
> It turns out this was introduced by BuildKit in 2018 along with a
> standardisation of Dockerfile syntax, and has subsequently been adopted b
On Wed, Jul 03, 2024 at 03:20:00PM +0100, Andrew Cooper wrote:
> As per:
>
>
> https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#here-documents
>
> For inline files, use COPY with a heredoc, rather than opencoding it through
> /bin/sh.
>
> No practical change.
On 03/07/2024 3:34 pm, Roger Pau Monné wrote:
> On Wed, Jul 03, 2024 at 03:19:59PM +0100, Andrew Cooper wrote:
>> Commit b5739330d7f4 introduced the use of heredocs in the jessie/stretch
>> dockerfiles.
>>
>> It turns out this was introduced by BuildKit in 2018 along with a
>> standardisation of Do
On Wed, Jul 03, 2024 at 03:20:01PM +0100, Andrew Cooper wrote:
> These packages have moved out of main to AUR, and are not easily accessable
^ accessible?
> any more. Drop them, because they're only needed for RomBIOS which is very
flight 186640 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/186640/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf ed07a2bb11b358fdece44a760fc193d56f22cfb2
baseline version:
ovmf 4f174696fd8fbd9cc29c9
On 03/07/2024 3:43 pm, Roger Pau Monné wrote:
> On Wed, Jul 03, 2024 at 03:20:01PM +0100, Andrew Cooper wrote:
>> These packages have moved out of main to AUR, and are not easily accessable
>^
> accessible?
Fixed.
>> any more.
On Wed, Jul 03, 2024 at 03:20:02PM +0100, Andrew Cooper wrote:
> CentOS 7 is fully End-of-life as of 2024-06-30, and the Yum repo configuration
> points at URLs which have become non-existent.
>
> First, start by using a heredoc RUN for legibility. It's important to use
> `set -e` to offset the f
On 01.07.2024 10:25, Sergiy Kibrik wrote:
> Transactional Synchronization Extensions are supported on certain Intel's
> CPUs only, hence can be put under CONFIG_INTEL build option.
>
> The whole TSX support, even if supported by CPU, may need to be disabled via
> options, by microcode or through s
On 01.07.2024 14:03, Sergiy Kibrik wrote:
> Separate ACPI driver from generic initialization cpufreq code.
> This way acpi-cpufreq can become optional in the future and be disabled
> from non-Intel builds.
>
> Other than acpi_register_driver() helper added and clean up a list of
> included headers
On 03/07/2024 3:55 pm, Roger Pau Monné wrote:
> On Wed, Jul 03, 2024 at 03:20:02PM +0100, Andrew Cooper wrote:
>> CentOS 7 is fully End-of-life as of 2024-06-30, and the Yum repo
>> configuration
>> points at URLs which have become non-existent.
>>
>> First, start by using a heredoc RUN for legibi
On 01.07.2024 14:19, Sergiy Kibrik wrote:
> --- a/xen/drivers/acpi/pmstat.c
> +++ b/xen/drivers/acpi/pmstat.c
> @@ -255,7 +255,7 @@ static int get_cpufreq_para(struct xen_sysctl_pm_op *op)
> strlcpy(op->u.get_para.scaling_driver, "Unknown", CPUFREQ_NAME_LEN);
>
> if ( !strncmp(op->u
On 03.07.2024 02:04, Milan Djokic wrote:
> Added riscv image header to enable boot from second stage bootloaders (e.g.
> uboot. Image header defined in riscv-image-header.h)
> Additionally, RISC-V xen image is extended with PE/COFF headers, introducing
> EFI application format.
> PE/COFF header i
On Wed, Jul 03, 2024 at 03:52:48PM +0100, Andrew Cooper wrote:
> Also, Archlinux is nonblocking because it's a rolling distro and
> periodically breaks older trees because of an updated GCC.
Correction: It should be nonblocking, it's not at the moment ;-).
Cheers,
--
Anthony Perard | Vates XCP
flight 186638 linux-linus real [real]
flight 186642 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/186638/
http://logs.test-lab.xenproject.org/osstest/logs/186642/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run
flight 186641 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/186641/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
flight 186644 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/186644/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
flight 186639 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/186639/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail pass in 186634
test-amd64-amd64-xl-qemut-debian
Prior to the split, "the clients" used tools/xenstored/Makefile.common whose
clean rule includes *.o whereas after the split, the removal of *.o was lost
by virtule of not including Makefile.common any more.
This is the bug behind the following build error:
make[2]: Entering directory '/local/x
From: Akihiko Odaki
romsize is an uint32_t variable. Specifying -1 as an uint32_t value is
obscure way to denote UINT32_MAX.
Worse, if int is wider than 32-bit, it will change the behavior of a
construct like the following:
romsize = -1;
if (romsize != -1) {
...
}
When -1 is assigned to rom
With Python 3.11, the following is emitted during a build:
tools/include/xen-foreign/mkheader.py:162: DeprecationWarning: invalid escape
sequence '\s'
regex = "#define\s+%s\\b" % define;
tools/include/xen-foreign/mkheader.py:177: DeprecationWarning: invalid escape
sequence '\*'
input
For 4.19? Noticed while staring at build logs. Low risk, as the build system
contains a cross-check that mkheader generates the same layout.
Not the end of the world if these fixes delay to 4.20.
Andrew Cooper (2):
build/mkheader: Remove C-isms from the code
build/mkheader: Fix Syntax/Depre
This was clearly written by a C programmer, rather than a python programmer.
Drop all the useless semi-colons.
The very final line of the script simply references f.close, rather than
calling the function. Switch to using a with: statement, as python does care
about unclosed files if you enable e
On 2024/7/2 16:44, Jan Beulich wrote:
> On 02.07.2024 05:15, Chen, Jiqian wrote:
>> On 2024/7/1 15:44, Jan Beulich wrote:
>>> On 30.06.2024 14:33, Jiqian Chen wrote:
If run Xen with PVH dom0 and hvm domU, hvm will map a pirq for
a passthrough device by using gsi, see qemu code
xen_pt
Hi Anthony,
On 2024/7/2 11:47, Chen, Jiqian wrote:
> On 2024/7/1 15:32, Jan Beulich wrote:
>> On 30.06.2024 14:33, Jiqian Chen wrote:
>>> --- a/tools/libs/ctrl/xc_physdev.c
>>> +++ b/tools/libs/ctrl/xc_physdev.c
>>> @@ -111,3 +111,38 @@ int xc_physdev_unmap_pirq(xc_interface *xch,
>>> return
flight 186645 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/186645/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 186620
Tests which are fai
On 04.07.24 00:36, Andrew Cooper wrote:
Prior to the split, "the clients" used tools/xenstored/Makefile.common whose
clean rule includes *.o whereas after the split, the removal of *.o was lost
by virtule of not including Makefile.common any more.
This is the bug behind the following build error
On 04.07.2024 04:56, Chen, Jiqian wrote:
> On 2024/7/2 16:44, Jan Beulich wrote:
>> On 02.07.2024 05:15, Chen, Jiqian wrote:
>>> On 2024/7/1 15:44, Jan Beulich wrote:
On 30.06.2024 14:33, Jiqian Chen wrote:
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -323,6 +
On 2024/7/4 14:38, Jan Beulich wrote:
> On 04.07.2024 04:56, Chen, Jiqian wrote:
>> On 2024/7/2 16:44, Jan Beulich wrote:
>>> On 02.07.2024 05:15, Chen, Jiqian wrote:
On 2024/7/1 15:44, Jan Beulich wrote:
> On 30.06.2024 14:33, Jiqian Chen wrote:
>> --- a/xen/arch/x86/physdev.c
>>
71 matches
Mail list logo