Re: [PATCH v7 01/14] xen/common: add cache coloring common code

On 21.03.2024 18:22, Carlo Nonato wrote: > Hi Jan, > > On Thu, Mar 21, 2024 at 4:53 PM Jan Beulich wrote: >> >> On 21.03.2024 16:03, Carlo Nonato wrote: >>> On Tue, Mar 19, 2024 at 3:58 PM Jan Beulich wrote: On 15.03.2024 11:58, Carlo Nonato wrote: > --- a/docs/misc/xen-command-line.pan

Re: [PATCH v7 04/14] xen/arm: add Dom0 cache coloring support

On 21.03.2024 18:31, Carlo Nonato wrote: > On Thu, Mar 21, 2024 at 4:57 PM Jan Beulich wrote: >> >> On 21.03.2024 16:04, Carlo Nonato wrote: >>> On Tue, Mar 19, 2024 at 4:30 PM Jan Beulich wrote: On 15.03.2024 11:58, Carlo Nonato wrote: > --- a/docs/misc/xen-command-line.pandoc > +++

[ovmf test] 185138: all pass - PUSHED

flight 185138 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/185138/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7f1ffba5de3d9840dbeeba20fba165f2fb724941 baseline version: ovmf 35f6a2780e5198315a9f1

Re: [PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

On 21.03.2024 18:47, Julien Grall wrote: > On 14/03/2024 22:15, Shawn Anastasio wrote: >> Arm's setup.c contains a collection of functions for parsing memory map >> and other boot information from a device tree. Since these routines are >> generally useful on any architecture that supports device t

Re: [PATCH v3 1/9] EFI: Introduce inline stub for efi_enabled on !X86 && !ARM

On 14.03.2024 23:15, Shawn Anastasio wrote: > --- a/xen/include/xen/efi.h > +++ b/xen/include/xen/efi.h > @@ -31,7 +31,15 @@ union compat_pf_efi_info; > struct xenpf_efi_runtime_call; > struct compat_pf_efi_runtime_call; > > +#if defined(CONFIG_X86) || defined(CONFIG_ARM) > bool efi_enabled(un

Re: [PATCH v3 4/9] xen/ppc: Update setup.h with required definitions for bootfdt

On 14.03.2024 23:15, Shawn Anastasio wrote: > --- a/xen/arch/ppc/include/asm/setup.h > +++ b/xen/arch/ppc/include/asm/setup.h > @@ -3,4 +3,116 @@ > > #define max_init_domid (0) > > +#include > +#include > +#include Besides this not matching our aimed-at ordering (at least asm/ after xen/),

Re: [XEN PATCH 1/2] automation/eclair: add deviation for MISRA C:2012 Rule 17.1

On 21/03/24 19:00, Stefano Stabellini wrote: On Thu, 21 Mar 2024, Jan Beulich wrote: On 21.03.2024 02:50, Stefano Stabellini wrote: On Wed, 20 Mar 2024, Jan Beulich wrote: On 20.03.2024 09:50, Simone Ballarin wrote: MISRA C:2012 Rule 17.1 states: The features of `' shall not be used The Xen

[PATCH v3 1/1] x86: Rename __{start,end}_init_task to __{start,end}_init_stack

The stack of a task has been separated from the memory of a task_struct struture for a long time on x86, as a result __{start,end}_init_task no longer mark the start and end of the init_task structure, but its stack only. Rename __{start,end}_init_task to __{start,end}_init_stack. Note other arch

Re: [XEN PATCH 2/2] xen: address violations of MISRA C Rule 17.1

On 21/03/24 02:47, Stefano Stabellini wrote: On Wed, 20 Mar 2024, Jan Beulich wrote: On 20.03.2024 09:51, Simone Ballarin wrote: MISRA C Rule 20.7 states: "The features of `' shall not be used" The Xen community wants to avoid using variadic functions except for specific circumstances where it

[XEN PATCH v2 1/2] automation/eclair: add deviation for MISRA C:2012 Rule 17.1

MISRA C:2012 Rule 17.1 states: The features of `' shall not be used The Xen community wants to avoid using variadic functions except for specific circumstances where it feels appropriate by strict code review. Add deviation for printf()-like functions. Signed-off-by: Simone Ballarin --- Change

[XEN PATCH v2 2/2] xen: address violations of MISRA C Rule 17.1

MISRA C Rule 20.7 states: "The features of `' shall not be used" The Xen community wants to avoid using variadic functions except for specific circumstances where it feels appropriate by strict code review. Functions hypercall_create_continuation and hypercall_xlat_continuation are internal helpe

[XEN PATCH v2 0/2] xen: address violations of MISRA C Rule 17.1

MISRA C Rule 20.7 states: "The features of `' shall not be used". The Xen community wants to avoid using variadic functions except for specific circumstances where it feels appropriate by strict code review. Functions hypercall_create_continuation and hypercall_xlat_continuation are internal help

Re: [XEN PATCH v2 1/2] automation/eclair: add deviation for MISRA C:2012 Rule 17.1

On 22.03.2024 09:46, Simone Ballarin wrote: > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl > @@ -382,6 +382,32 @@ explicit comment indicating the fallthrough intention is > present." > -config=MC3R1.R16.6,switch_clauses+={delibera

[xen-unstable test] 185137: tolerable FAIL - PUSHED

flight 185137 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185137/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 185117 test-armhf-armhf-libvirt 16 save

Re: [PATCH 08/11] xen/arm: Reduce struct membank size on static shared memory

Hi Luca, On 12/03/2024 14:03, Luca Fancellu wrote: > > > Currently the memory footprint of the static shared memory feature > is impacting all the struct meminfo instances with memory space > that is not going to be used. > > To solve this issue, rework the static shared memory extra > informat

Re: [PATCH v6 08/20] xen/riscv: introduce cmpxchg.h

On Thu, 2024-03-21 at 13:07 +0100, Jan Beulich wrote: > On 15.03.2024 19:06, Oleksii Kurochko wrote: > > The header was taken from Linux kernl 6.4.0-rc1. > > > > Addionally, were updated: > > * add emulation of {cmp}xchg for 1/2 byte types using 32-bit atomic > >   access. > > * replace tabs with

Re: [PATCH v6 08/20] xen/riscv: introduce cmpxchg.h

On 22.03.2024 11:32, Oleksii wrote: > On Thu, 2024-03-21 at 13:07 +0100, Jan Beulich wrote: >> On 15.03.2024 19:06, Oleksii Kurochko wrote: >>> The header was taken from Linux kernl 6.4.0-rc1. >>> >>> Addionally, were updated: >>> * add emulation of {cmp}xchg for 1/2 byte types using 32-bit atomic

Re: [PATCH v6 09/20] xen/riscv: introduce io.h

On Thu, 2024-03-21 at 13:27 +0100, Jan Beulich wrote: > On 15.03.2024 19:06, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/io.h > > @@ -0,0 +1,167 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* > > + *  The header taken form Linux 6.4.0-rc1 and is based

Re: [PATCH v6 09/20] xen/riscv: introduce io.h

On 22.03.2024 12:02, Oleksii wrote: > On Thu, 2024-03-21 at 13:27 +0100, Jan Beulich wrote: >> On 15.03.2024 19:06, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/io.h >>> @@ -0,0 +1,167 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +/* >>> + *  The header

Xen Summit Schedule announced!

Hi all, The much anticipated Xen Summit schedule is live! Check out what talks will be available. We also have plenty of slots for design sessions at the event for you to get involved in. *Don't forget to secure your early

Re: [PATCH v6 10/20] xen/riscv: introduce atomic.h

On Thu, 2024-03-21 at 14:03 +0100, Jan Beulich wrote: > On 15.03.2024 19:06, Oleksii Kurochko wrote: > > Initially the patch was introduced by Bobby, who takes the header > > from > > Linux kernel. > > > > The following changes were done on top of Linux kernel header: > >  - atomic##prefix##_*xchg

Re: [PATCH v6 15/20] xen/riscv: add minimal stuff to processor.h to build full Xen

On Thu, 2024-03-21 at 14:26 +0100, Jan Beulich wrote: > On 15.03.2024 19:06, Oleksii Kurochko wrote: > > The cpu_relax() function, introduced in this commit, is anticipated > > to > > support _zihintpause by the CPU. > > > > Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Thanks. >

Re: [PATCH v6 08/20] xen/riscv: introduce cmpxchg.h

On Fri, 2024-03-22 at 11:42 +0100, Jan Beulich wrote: > On 22.03.2024 11:32, Oleksii wrote: > > On Thu, 2024-03-21 at 13:07 +0100, Jan Beulich wrote: > > > On 15.03.2024 19:06, Oleksii Kurochko wrote: > > > > The header was taken from Linux kernl 6.4.0-rc1. > > > > > > > > Addionally, were updated

Re: [PATCH v6 09/20] xen/riscv: introduce io.h

On Fri, 2024-03-22 at 12:36 +0100, Jan Beulich wrote: > On 22.03.2024 12:02, Oleksii wrote: > > On Thu, 2024-03-21 at 13:27 +0100, Jan Beulich wrote: > > > On 15.03.2024 19:06, Oleksii Kurochko wrote: > > > > --- /dev/null > > > > +++ b/xen/arch/riscv/include/asm/io.h > > > > @@ -0,0 +1,167 @@ > >

Re: [PATCH v3 1/9] EFI: Introduce inline stub for efi_enabled on !X86 && !ARM

Hi Jan, On 22/03/2024 08:01, Jan Beulich wrote: On 14.03.2024 23:15, Shawn Anastasio wrote: --- a/xen/include/xen/efi.h +++ b/xen/include/xen/efi.h @@ -31,7 +31,15 @@ union compat_pf_efi_info; struct xenpf_efi_runtime_call; struct compat_pf_efi_runtime_call; +#if defined(CONFIG_X86) || d

Re: [PATCH v3 5/9] xen/device-tree: Move Arm's setup.c bootinfo functions to common

Hi Jan, On 22/03/2024 07:55, Jan Beulich wrote: On 21.03.2024 18:47, Julien Grall wrote: On 14/03/2024 22:15, Shawn Anastasio wrote: Arm's setup.c contains a collection of functions for parsing memory map and other boot information from a device tree. Since these routines are generally useful

Re: [PATCH] avoid UB in guest handle arithmetic

On 3/19/24 09:26, Jan Beulich wrote: > At least XENMEM_memory_exchange can have huge values passed in the > nr_extents and nr_exchanged fields. Adding such values to pointers can > overflow, resulting in UB. Cast respective pointers to "unsigned long" Why not uintptr_t?

Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines

On Fri, Mar 22, 2024 at 09:55:18AM +0800, Yong Huang wrote: > Indeed, for the GLOBAL_DIRTY_DIRTY_RATE and GLOBAL_DIRTY_LIMIT > dirty tracking, they should handle the failure path of logging start. > The work may be done once the current patchset is merged. Thanks for confirming this, Yong. I thin

Re: [XEN PATCH v2 1/2] automation/eclair: add deviation for MISRA C:2012 Rule 17.1

On 22/03/24 10:44, Jan Beulich wrote: On 22.03.2024 09:46, Simone Ballarin wrote: --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -382,6 +382,32 @@ explicit comment indicating the fallthrough intention is present." -config=MC3R1

Re: [XEN PATCH v2 1/2] automation/eclair: add deviation for MISRA C:2012 Rule 17.1

On 22.03.2024 14:44, Simone Ballarin wrote: > On 22/03/24 10:44, Jan Beulich wrote: >> On 22.03.2024 09:46, Simone Ballarin wrote: >>> --- a/automation/eclair_analysis/ECLAIR/deviations.ecl >>> +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl >>> @@ -382,6 +382,32 @@ explicit comment indicati

Re: [PATCH] avoid UB in guest handle arithmetic

On 22.03.2024 14:39, Stewart Hildebrand wrote: > On 3/19/24 09:26, Jan Beulich wrote: >> At least XENMEM_memory_exchange can have huge values passed in the >> nr_extents and nr_exchanged fields. Adding such values to pointers can >> overflow, resulting in UB. Cast respective pointers to "unsigned l

Re: [XEN PATCH v2 1/2] automation/eclair: add deviation for MISRA C:2012 Rule 17.1

On 22/03/24 15:12, Jan Beulich wrote: On 22.03.2024 14:44, Simone Ballarin wrote: On 22/03/24 10:44, Jan Beulich wrote: On 22.03.2024 09:46, Simone Ballarin wrote: --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -382,6 +382,32 @@

Re: [PATCH v3 3/3] x86/PVH: Support relocatable dom0 kernels

On 2024-03-21 09:45, Jason Andryuk wrote: On 2024-03-20 10:39, Jan Beulich wrote: On 19.03.2024 21:58, Jason Andryuk wrote: @@ -536,6 +565,10 @@ elf_errorstatus elf_xen_parse(struct elf_binary *elf,   parms->p2m_base = UNSET_ADDR;   parms->elf_paddr_offset = UNSET_ADDR;   parms->

Re: [PATCH v7 08/14] xen/page_alloc: introduce preserved page flags macro

Hi guys, On Thu, Mar 21, 2024 at 5:23 PM Jan Beulich wrote: > > On 21.03.2024 17:10, Julien Grall wrote: > > On 21/03/2024 16:07, Julien Grall wrote: > >> On 15/03/2024 10:58, Carlo Nonato wrote: > >>> PGC_static and PGC_extra needs to be preserved when assigning a page. > >>> Define a new macro

Re: [PATCH 09/11] xen/arm: remove shm holes for extended regions

Hi Luca, NIT: title s/for/from? On 12/03/2024 14:03, Luca Fancellu wrote: > > > From: Penny Zheng > > Static shared memory acts as reserved memory in guest, so it shall be > excluded from extended regions. > > Extended regions are taken care of under three different scenarios: > normal DomU,

[XEN PATCH 07/11] xen/page_alloc: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 11/11] x86/public: hvm: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 01/11] xen/list: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 10/11] x86/hvm: address violations of Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 03/11] xen/efi: efibind: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 05/11] xen: address MISRA C Rule 20.7 violation in generated hypercall

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 02/11] xen/xsm: add parentheses to comply with MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 08/11] x86/altcall: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 09/11] x86/msi: address violation of MISRA C Rule 20.7 and coding style

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 06/11] xen/efi: address violations of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[XEN PATCH 00/11] address some violations of MISRA C Rule 20.7

Hi all, this series aims to refactor some macros that cause violations of MISRA C Rule 20.7 ("Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses"). All the macros touched by these patches are in some way involved in violations, and the strategy adopted to

[XEN PATCH 04/11] xentrace: address violation of MISRA C Rule 20.7

MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter

[PATCH-for-9.1 v2 3/3] exec: Rename NEED_CPU_H -> COMPILING_PER_TARGET

'NEED_CPU_H' guard target-specific code; it is defined by meson altogether with the 'CONFIG_TARGET' definition. Rename NEED_CPU_H as COMPILING_PER_TARGET to clarify its meaning. Mechanical change running: $ sed -i s/NEED_CPU_H/COMPILING_PER_TARGET/g $(git grep -l NEED_CPU_H) then manually add a

Re: Serious AMD-Vi(?) issue

Hi Elliott, I hope you're well. I'm Kelly, the community manager at the Xen Project. I can see you've recently engaged with our community with some issues you'd like help with. We love the fact you are participating in our project, however, our developers aren't able to help if you do not provid

[linux-linus test] 185139: regressions - FAIL

flight 185139 linux-linus real [real] flight 185141 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/185139/ http://logs.test-lab.xenproject.org/osstest/logs/185141/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: Serious AMD-Vi(?) issue

On Fri, Mar 22, 2024 at 04:41:45PM +, Kelly Choi wrote: > > I can see you've recently engaged with our community with some issues you'd > like help with. > We love the fact you are participating in our project, however, our > developers aren't able to help if you do not provide the specific de

Re: [PATCH 09/11] xen/arm: remove shm holes for extended regions

> On 22 Mar 2024, at 15:09, Michal Orzel wrote: > > Hi Luca, > > NIT: title s/for/from? > > On 12/03/2024 14:03, Luca Fancellu wrote: >> >> >> From: Penny Zheng >> >> Static shared memory acts as reserved memory in guest, so it shall be >> excluded from extended regions. >> >> Extended r

Re: [XEN PATCH 02/11] xen/xsm: add parentheses to comply with MISRA C Rule 20.7

On 3/22/24 12:01, Nicola Vetrini wrote: MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with res

[xen-unstable test] 185140: tolerable FAIL

flight 185140 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/185140/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 13 guest-start fail pass in 185137 test-armhf-armhf-libvirt-vhd 17

[linux-linus test] 185142: regressions - FAIL

flight 185142 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/185142/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-buildfail REGR. vs. 185119 Tests which did not