[PATCH] OSStest: use CONFIG_X86_GENERIC for 32-bit x86 kernel

2023-12-07 Thread Juergen Gross
Today the cpu type for a 32-bit x86 kernel is not specified in the used kernel config, resulting in the M686 to be used. Instead of using the M686 which isn't even a 64-bit cpu (thus not capable to run a Xen guest), use the X86_GENERIC variant which is more appropriate. Signed-off-by: Juergen Gro

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Juergen Gross
On 21.11.23 12:40, Juergen Gross wrote: Remove some command line options which have no real use case. Changes in V2: - moved removal of "-N" into last patch of the series, as this is the only option which seems to have a use case (OTOH using it has some downsides as well). Juergen Gross (

Re: Clang-format configuration discussion - pt 2

2023-12-07 Thread Julien Grall
Hi, On 07/12/2023 07:28, Jan Beulich wrote: On 06.12.2023 18:55, Julien Grall wrote: On 06/12/2023 02:32, George Dunlap wrote: On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: On 05.12.2023 14:46, Luca Fancellu wrote: In my opinion, I don’t know of any tool that can address all the flexibi

[XEN PATCH v2 3/5] x86/mm: remove compat_subarch_memory_op()

2023-12-07 Thread Federico Serafini
Remove remove compat_subarch_memory_op() declaration: there is no definition and there are no calls to such function in the XEN project. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/mm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/

[XEN PATCH v2 1/5] x86/acpi: remove acpi_pic_sci_set_trigger()

2023-12-07 Thread Federico Serafini
Remove apci_pic_set_trigger() declaration: there is no definition and there are no calls to such function in the XEN project. Signed-off-by: Federico Serafini --- xen/arch/x86/include/asm/acpi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/inc

[XEN PATCH v2 2/5] xen/acpi: address violations of MISRA C:2012 Rule 8.2

2023-12-07 Thread Federico Serafini
Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - do not add parameters to acpi_pic_sci_set_trigger() (removed). --- xen/include/acpi/apei.h | 5 +++-- xen/include/acpi/cpufreq/cpufreq.h| 2 +- xen/include/acpi/

[XEN PATCH v2 5/5] AMD/IOMMU: address violations of MISRA C:2012 Rule 8.2

2023-12-07 Thread Federico Serafini
Add missing parameter names to address violations of MISRA C:2012 Rule 8.2. Remove trailing spaces and use C standard types to comply with XEN coding style. No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - use "enable" instead of "iommu_control" as parameter name. ---

[XEN PATCH v2 0/5] xen: add parameter names and remove function declarations

2023-12-07 Thread Federico Serafini
This patch series adds the missing parameter names and remove useless function declarations. No functional changes are introduced. Federico Serafini (5): x86/acpi: remove acpi_pic_sci_set_trigger() xen/acpi: address violations of MISRA C:2012 Rule 8.2 x86/mm: remove compat_subarch_memory_op(

[XEN PATCH v2 4/5] x86/mm: address violations of MISRA C:2012 Rule 8.2

2023-12-07 Thread Federico Serafini
Add missing parameter names. No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - do not add parameters to compat_subarch_memory_op() (removed). --- xen/arch/x86/include/asm/mm.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/a

Re: Clang-format configuration discussion - pt 2

2023-12-07 Thread Jan Beulich
On 07.12.2023 09:43, Julien Grall wrote: > On 07/12/2023 07:28, Jan Beulich wrote: >> On 06.12.2023 18:55, Julien Grall wrote: >>> On 06/12/2023 02:32, George Dunlap wrote: On Tue, Dec 5, 2023 at 2:07 PM Jan Beulich wrote: > On 05.12.2023 14:46, Luca Fancellu wrote: >> In my opinion,

[xen-4.17-testing test] 184007: tolerable FAIL - PUSHED

2023-12-07 Thread osstest service owner
flight 184007 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/184007/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 183842 test-armhf-armhf-libvirt 16

Re: [PATCH 1/3] xen/ppc: Enable Boot Allocator

2023-12-07 Thread Oleksii
On Wed, 2023-12-06 at 21:01 -0500, Daniel P. Smith wrote: > On 12/1/23 15:56, Julien Grall wrote: > > (+ Arm and RISC-V folks) > > > > Hi Shawn, > > > > On 01/12/2023 20:59, Shawn Anastasio wrote: > > > Adapt arm's earlyfdt parsing code to ppc64 and enable Xen's early > > > boot > > > allocator.

[XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3

2023-12-07 Thread Federico Serafini
MISRA C:2012 Rule 16.3 states that an unconditional break statement shall terminate every switch-clause. Update ECLAIR configuration to take into account: - continue, goto, return statements; - functions and macros that do not give the control back; - fallthrough comments and pseudo-keywords. Upd

Re: [XEN PATCH v2 1/5] x86/acpi: remove acpi_pic_sci_set_trigger()

2023-12-07 Thread Jan Beulich
On 07.12.2023 09:47, Federico Serafini wrote: > Remove apci_pic_set_trigger() declaration: there is no definition and there > are > no calls to such function in the XEN project. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich A reference to the offending commit would have been n

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Oleksii
On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > > > The patch also fixes the build script as conf util expects > > > > to have each config on separate line. > > > > The approach doesn't really scale (it's already odd that you add > > the >

Re: [PATCH] xen/xenbus: client: fix kernel-doc comments

2023-12-07 Thread Juergen Gross
On 06.12.23 19:17, Randy Dunlap wrote: Correct function kernel-doc notation to prevent warnings from scripts/kernel-doc. xenbus_client.c:134: warning: No description found for return value of 'xenbus_watch_path' xenbus_client.c:177: warning: No description found for return value of 'xenbus_wat

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Jan Beulich
On 07.12.2023 09:26, Juergen Gross wrote: > On 21.11.23 12:40, Juergen Gross wrote: >> Remove some command line options which have no real use case. >> >> Changes in V2: >> - moved removal of "-N" into last patch of the series, as this is the >>only option which seems to have a use case (OTOH u

Re: [PATCH v2 02/39] xen/riscv: use some asm-generic headers

2023-12-07 Thread Oleksii
On Tue, 2023-12-05 at 16:40 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > Some headers are the same as asm-generic verions of them > > so use them instead of arch-specific headers. > > > > Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich > assuming ... >

Re: [PATCH v5 04/11] xen/arm: introduce allocate_domheap_memory and guest_physmap_memory

2023-12-07 Thread Michal Orzel
Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: > > > We split the code of allocate_bank_memory into two parts, > allocate_domheap_memory and guest_physmap_memory. > > One is about allocating guest RAM from heap, which could be re-used later for > allocating static shared memory from heap whe

Re: [PATCH v2 06/39] xen/riscv: introduce fence.h

2023-12-07 Thread Oleksii
On Tue, 2023-12-05 at 16:56 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/fence.h > > @@ -0,0 +1,12 @@ > > +#ifndef _ASM_RISCV_FENCE_H > > +#define _ASM_RISCV_FENCE_H > > + > > +#ifdef CONFIG_SMP > > +#define RISCV_AC

RE: [PATCH v13 26/35] x86/fred: FRED entry/exit and dispatch code

2023-12-07 Thread Li, Xin3
> > In my opinion, cross-checking is the better approach, because it means that > > violations of the assumptions get noticed more quickly, and hopefully by > > whomever is working on the new feature which alters the assumptions. > > Yeah, I can make the change. Hi Andrew, Following is the upd

Re: [PATCH v2 06/39] xen/riscv: introduce fence.h

2023-12-07 Thread Jan Beulich
On 07.12.2023 10:42, Oleksii wrote: > On Tue, 2023-12-05 at 16:56 +0100, Jan Beulich wrote: >> On 24.11.2023 11:30, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/fence.h >>> @@ -0,0 +1,12 @@ >>> +#ifndef _ASM_RISCV_FENCE_H >>> +#define _ASM_RISCV_FENCE_H >>> + >>> +

xen | Failed pipeline for staging | dbe69e1c

2023-12-07 Thread GitLab
Pipeline #1098406925 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: dbe69e1c ( https://gitlab.com/xen-project/xen/-/commit/dbe69e1c8555b40a43cde482615501eb8515ab80 ) Commit Message: x86/DMI: adju

[PATCH 0/3] xen: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Add comparisons to avoid using enum consta

[PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Add comparisons to avoid using enum consta

[PATCH 1/3] AMD/IOMMU: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Add comparisons to avoid using enum consta

[PATCH 3/3] xen: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
From: Maria Celeste Cesario The xen sources contain violations of MISRA C:2012 Rule 14.4 whose headline states: "The controlling expression of an if statement and the controlling expression of an iteration-statement shall have essentially Boolean type". Struct domain member is_dying is an anonym

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Jan Beulich
On 07.12.2023 10:22, Oleksii wrote: > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: >>> On 24.11.2023 11:30, Oleksii Kurochko wrote: > The patch also fixes the build script as conf util expects > to have each config on separate line. >>> >>> The approach doesn't really scale (it's a

Re: [PATCH 1/3] AMD/IOMMU: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Jan Beulich
On 07.12.2023 10:48, Simone Ballarin wrote: > From: Maria Celeste Cesario > > The xen sources contain violations of MISRA C:2012 Rule 14.4 whose > headline states: > "The controlling expression of an if statement and the controlling > expression of an iteration-statement shall have essentially Bo

Re: [XEN PATCH v2 1/5] x86/acpi: remove acpi_pic_sci_set_trigger()

2023-12-07 Thread Federico Serafini
On 07/12/23 10:19, Jan Beulich wrote: On 07.12.2023 09:47, Federico Serafini wrote: Remove apci_pic_set_trigger() declaration: there is no definition and there are no calls to such function in the XEN project. Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich A reference to the off

[PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Michal Orzel
As a result of not checking the return code of device_tree_for_each_node() in boot_fdt_info(), any error occured during early FDT parsing does not stop Xen from booting. This can result in an unwanted behavior in later boot stages. Fix it by checking the return code and panicing on an error. Fixes

Re: [PATCH v5 02/11] xen/arm: avoid repetitive checking in process_shm_node

2023-12-07 Thread Penny Zheng
Hi Michal On 2023/12/6 19:35, Michal Orzel wrote: Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: Putting overlap and overflow checking in the loop is causing repetitive operation, so this commit extracts both checking outside the loop. Signed-off-by: Penny Zheng In general the patch lo

Re: [XEN PATCH v2 1/5] x86/acpi: remove acpi_pic_sci_set_trigger()

2023-12-07 Thread Jan Beulich
On 07.12.2023 11:09, Federico Serafini wrote: > On 07/12/23 10:19, Jan Beulich wrote: >> On 07.12.2023 09:47, Federico Serafini wrote: >>> Remove apci_pic_set_trigger() declaration: there is no definition and there >>> are >>> no calls to such function in the XEN project. >>> >>> Signed-off-by: Fe

[PATCH 0/2] build: tool option handling adjustments

2023-12-07 Thread Jan Beulich
The first is a fix for a latent issue (which became real with one of my pending changes), while the 2nd is merely cleanup noticed as possible / useful to do in the course of investigating. 1: x86/EFI: correct compiler probing 2: Kbuild: simplify as-insn a little Jan

[PATCH 1/2] x86/EFI: correct compiler probing

2023-12-07 Thread Jan Beulich
Passing in $(CFLAGS) means also requesting inclusion of certain headers (via -include command line options). That's particularly xen/config.h, which in turn requires generated/autoconf.h. This has not caused any problems so far only because arch.mk is processed twice, and the missing header on the

[PATCH 2/2] Kbuild: simplify as-insn a little

2023-12-07 Thread Jan Beulich
As of 732571959f17 ("xen/build: use new $(c_flags) and $(a_flags) instead of $(CFLAGS)") -M options aren't part of CFLAGS anymore, and c_flags isn't supposed to be passed to this macro. Drop the now dead part of filtering. Signed-off-by: Jan Beulich --- a/xen/scripts/Kbuild.include +++ b/xen/scr

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Jan Beulich
On 07.12.2023 10:48, Simone Ballarin wrote: > --- a/xen/arch/x86/hpet.c > +++ b/xen/arch/x86/hpet.c > @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch, > struct msi_msg *msg) > { > ch->msi.msg = *msg; > > -if ( iommu_intremap ) > +if ( iommu_intremap != i

[XEN PATCH v2 2/3] x86/viridian: make build_assertions static

2023-12-07 Thread Nicola Vetrini
This is consistent with other instances of the same function and also resolves a violation of MISRA C:2012 Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/arch/x86/hvm/viridian/synic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

2023-12-07 Thread Nicola Vetrini
Such declaration is needed to comply with MISRA C Rule 8.4, because a compatible declaration is not visible in xen/common/page_alloc.c, where the variable is defined. That variable can't yet be static because of the lack of support from ARM and PPC for NUMA. No functional change. Signed-off-by: N

[XEN PATCH v2 0/3] address some violations of MISRA C Rule 8.4

2023-12-07 Thread Nicola Vetrini
MISRA C:2012 Rule 8.4 states: "A compatible declaration shall be visible when an object or function with external linkage is defined". Changes from v1: - Patch 1/7 has been committed; - Patch 2/7 has been dropped, as the fix is already part of [1]; - Patch 3/7 drops the addition of asmlinkage on v

[XEN PATCH v2 1/3] xen/x86: add missing instances of asmlinkage attributes

2023-12-07 Thread Nicola Vetrini
No functional change. Signed-off-by: Nicola Vetrini --- Changes in v2: - The attribute on boot_gdtr and l1_fixmap_x has been dropped, as detailed in the cover letter. --- xen/arch/x86/efi/efi-boot.h | 5 +++-- xen/arch/x86/smpboot.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)

Re: [PATCH v5 10/11] xen/arm: fix duplicate /reserved-memory node in Dom0

2023-12-07 Thread Michal Orzel
Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: > > > In case there is a /reserved-memory node already present in the host dtb, > current Xen codes would create yet another /reserved-memory node specially > for the static shm in Dom0 Device Tree. Rational missing: This would result in an incor

[XEN PATCH] automation/eclair_analysis: file exclusion automation

2023-12-07 Thread Nicola Vetrini
The file exclude-list.json contains files that are classified as adopted code for MISRA compliance. Therefore, this file is used to automatically generate a suitable .ecl configuration for ECLAIR. As such, many entries in out_of_scope.ecl can be removed, as they would be duplicates. Signed-off-by

Re: [PATCH 1/6] system/cpus: rename qemu_mutex_lock_iothread() to qemu_bql_lock()

2023-12-07 Thread Stefan Hajnoczi
On Fri, Dec 01, 2023 at 10:42:43AM +0530, Harsh Prateek Bora wrote: > On 11/30/23 02:56, Stefan Hajnoczi wrote: > > diff --git a/hw/remote/mpqemu-link.c b/hw/remote/mpqemu-link.c > > index 9bd98e8219..ffb2c25145 100644 > > --- a/hw/remote/mpqemu-link.c > > +++ b/hw/remote/mpqemu-link.c > > @@ -33,7

Re: ARM: MISRA C:2012 Rule 5.6

2023-12-07 Thread Federico Serafini
On 07/12/23 12:43, Federico Serafini wrote: Hello everyone, Rule 5.6 states that a typedef name shall be a unique identifier. This is to avoid developer confusion. For ARM, the violations left [1] are generated by two definitions of the type phys_addr_t within two different files. I would like

Re: [PATCH v2 1/3] xen/sched: fix adding offline cpu to cpupool

2023-12-07 Thread George Dunlap
On Mon, Dec 4, 2023 at 4:55 PM Jan Beulich wrote: > > On 04.12.2023 16:23, Juergen Gross wrote: > > Trying to add an offline cpu to a cpupool can crash the hypervisor, > > as the probably non-existing percpu area of the cpu is accessed before > > the availability of the cpu is being tested. This c

Re: [PATCH v2 2/3] xen/sched: fix sched_move_domain()

2023-12-07 Thread George Dunlap
On Mon, Dec 4, 2023 at 4:56 PM Jan Beulich wrote: > > On 04.12.2023 16:23, Juergen Gross wrote: > > Do cleanup in sched_move_domain() in a dedicated service function, > > which is called either in error case with newly allocated data, or in > > success case with the old data to be freed. > > > > T

[xen-unstable-smoke test] 184022: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184022 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184022/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Julien Grall
Hi Jan, On 07/12/2023 09:30, Jan Beulich wrote: On 07.12.2023 09:26, Juergen Gross wrote: On 21.11.23 12:40, Juergen Gross wrote: Remove some command line options which have no real use case. Changes in V2: - moved removal of "-N" into last patch of the series, as this is the only option

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Julien Grall
Hi Michal, On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of device_tree_for_each_node() in boot_fdt_info(), any error occured during early FDT parsing does not stop Xen from booting. This can result in an unwanted behavior in later boot stages. Fix it by ch

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Jan Beulich
On 07.12.2023 13:14, Julien Grall wrote: > Hi Jan, > > On 07/12/2023 09:30, Jan Beulich wrote: >> On 07.12.2023 09:26, Juergen Gross wrote: >>> On 21.11.23 12:40, Juergen Gross wrote: Remove some command line options which have no real use case. Changes in V2: - moved removal o

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Michal Orzel
Hi Julien, On 07/12/2023 13:20, Julien Grall wrote: > > > Hi Michal, > > On 07/12/2023 10:14, Michal Orzel wrote: >> As a result of not checking the return code of device_tree_for_each_node() >> in boot_fdt_info(), any error occured during early FDT parsing does not >> stop Xen from booting. Th

Re: ARM: MISRA C:2012 Rule 5.6

2023-12-07 Thread Jan Beulich
On 07.12.2023 12:48, Federico Serafini wrote: > On 07/12/23 12:43, Federico Serafini wrote: >> Hello everyone, >> >> Rule 5.6 states that a typedef name shall be a unique identifier. >> This is to avoid developer confusion. >> >> For ARM, the violations left [1] are generated by two definitions >>

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Julien Grall
On 07/12/2023 12:39, Jan Beulich wrote: On 07.12.2023 13:14, Julien Grall wrote: Hi Jan, On 07/12/2023 09:30, Jan Beulich wrote: On 07.12.2023 09:26, Juergen Gross wrote: On 21.11.23 12:40, Juergen Gross wrote: Remove some command line options which have no real use case. Changes in V2:

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Julien Grall
Hi Michal, On 07/12/2023 12:39, Michal Orzel wrote: On 07/12/2023 13:20, Julien Grall wrote: Hi Michal, On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of device_tree_for_each_node() in boot_fdt_info(), any error occured during early FDT parsing does not

Re: ARM: MISRA C:2012 Rule 5.6

2023-12-07 Thread Julien Grall
On 07/12/2023 12:44, Jan Beulich wrote: On 07.12.2023 12:48, Federico Serafini wrote: On 07/12/23 12:43, Federico Serafini wrote: Hello everyone, Rule 5.6 states that a typedef name shall be a unique identifier. This is to avoid developer confusion. For ARM, the violations left [1] are gen

Re: [PATCH v2 3/3] xen/sched: do some minor cleanup of sched_move_domain()

2023-12-07 Thread George Dunlap
On Mon, Dec 4, 2023 at 3:23 PM Juergen Gross wrote: > > Do some minor cleanups: > > - Move setting of old_domdata and old_units next to each other > - Drop incrementing unit_idx in the final loop of sched_move_domain() > as it isn't used afterwards > - Rename new_p to new_cpu and unit_p to unit_

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Julien Grall
On 07/12/2023 12:20, Julien Grall wrote: Hi Michal, On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of device_tree_for_each_node() in boot_fdt_info(), any error occured during early FDT parsing does not stop Xen from booting. This can result in an unwant

Re: [PATCH v2 0/5] tools/xenstored: remove some command line options

2023-12-07 Thread Julien Grall
On 07/12/2023 08:26, Juergen Gross wrote: On 21.11.23 12:40, Juergen Gross wrote: Remove some command line options which have no real use case. Changes in V2: - moved removal of "-N" into last patch of the series, as this is the    only option which seems to have a use case (OTOH using it ha

Re: [PATCH v2] tools/libs/evtchn: replace assert()s in stubdom with proper locking

2023-12-07 Thread Jason Andryuk
On Thu, Dec 7, 2023 at 1:26 AM Juergen Gross wrote: > > In tools/libs/evtchn/minios.c there are assert()s for the current > thread being the main thread when binding an event channel. > > As Mini-OS is supporting multiple threads, there is no real reason > why the binding shouldn't be allowed to h

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Oleksii
On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: > On 07.12.2023 10:22, Oleksii wrote: > > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > > > > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > > > > > The patch also fixes the build script as conf util expects > > > > > > to have each

Re: [XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

2023-12-07 Thread Julien Grall
Hi, On 07/12/2023 11:11, Nicola Vetrini wrote: Such declaration is needed to comply with MISRA C Rule 8.4, because a compatible declaration is not visible in xen/common/page_alloc.c, where the variable is defined. That variable can't yet be static because of the lack of support from ARM and PPC

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
On 07/12/23 11:54, Jan Beulich wrote: On 07.12.2023 10:48, Simone Ballarin wrote: --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch, struct msi_msg *msg) { ch->msi.msg = *msg; -if ( iommu_intremap ) +

[PATCH 3/5] automation: Add the expect script with test case for FVP

2023-12-07 Thread Henry Wang
To interact with the FVP (for example entering the U-Boot shell and transferring the files by TFTP), we need to connect the corresponding port by the telnet first. Use an expect script to simplify the automation of the whole "interacting with FVP" stuff. The expect script will firstly detect the I

[PATCH 1/5] automation: Add a Dockerfile for running FVP_Base jobs

2023-12-07 Thread Henry Wang
Fixed Virtual Platforms (FVPs) are complete simulations of an Arm system, including processor, memory and peripherals. These are set out in a "programmer's view", which gives programmers a comprehensive model on which to build and test software. FVP can be configured to different setups by its cmdl

[PATCH 0/5] automation: Support running FVP Dom0 smoke test for Arm

2023-12-07 Thread Henry Wang
This series adds the support for running FVP Dom0 smoke test for Arm on the Arm64 GitLab CI runner. Detailed changes please refer to the commit message of each commit. An example test pipeline with these patches applied (with the docker registry changed to my own registry and unrelated job removed

[PATCH 2/5] automation: Add the Dockerfile to build TF-A and U-Boot for FVP

2023-12-07 Thread Henry Wang
Unlike the emulators that currently being used in the CI pipelines, the FVP must start at EL3. Therefore we need the firmware, i.e. the TrustedFirmware-A (TF-A), for corresponding functionality. There is a dedicated board (vexpress_fvp) in U-Boot (serve as the BL33 of the TF-A) for the FVP platfor

[PATCH 5/5] automation: Add the arm64 FVP build and Dom0 smoke test jobs

2023-12-07 Thread Henry Wang
Add a job in the build stage to export the TF-A, U-Boot and the device tree for the FVP platform from the test artifact container. Add a FVP smoke test job in the test stage to do the same test as the `qemu-smoke-dom0-arm64-gcc` job. Signed-off-by: Henry Wang --- Although it does not affect the

[PATCH 4/5] automation: Add the script for the FVP smoke test

2023-12-07 Thread Henry Wang
This commit adds the shell script for the FVP smoke test. Similarly as the QEMU jobs, the shell script will firstly prepare the DomU BusyBox image, use the ImageBuilder to arrange the binaries in memory and generate the U-Boot script, then start the test. To provide the TFTP service for the FVP, th

[ovmf test] 184023: all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184023 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184023/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 553dfb0f57ae8a666938873cf836a33549568c87 baseline version: ovmf ff4c49a5ee38d613384fb

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Jan Beulich
On 07.12.2023 14:44, Oleksii wrote: > On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: >> On 07.12.2023 10:22, Oleksii wrote: >>> On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >>> The patch also fixes the build script as conf util

Re: [XEN PATCH v2 3/3] xen/mm: add declaration for first_valid_mfn

2023-12-07 Thread Nicola Vetrini
On 2023-12-07 14:52, Julien Grall wrote: Hi, On 07/12/2023 11:11, Nicola Vetrini wrote: Such declaration is needed to comply with MISRA C Rule 8.4, because a compatible declaration is not visible in xen/common/page_alloc.c, where the variable is defined. That variable can't yet be static becau

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Jan Beulich
On 07.12.2023 14:53, Simone Ballarin wrote: > On 07/12/23 11:54, Jan Beulich wrote: >> On 07.12.2023 10:48, Simone Ballarin wrote: >>> --- a/xen/arch/x86/hpet.c >>> +++ b/xen/arch/x86/hpet.c >>> @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel >>> *ch, struct msi_msg *msg) >

Re: [PATCH v2 08/39] xen/riscv: introduce asm/cpufeature.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Acked-by: Jan Beulich Would have been nice ... > --- /dev/null > +++ b/xen/arch/riscv/include/asm/cpufeature.h > @@ -0,0 +1,22 @@ > +#ifndef __ASM_RISCV_CPUFEATURE_H > +#define __ASM_RISCV_CPUFEATURE_H > + > +#ifnde

Re: [PATCH v2 09/39] xen/riscv: introduce asm/guest_atomics.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/guest_atomics.h > @@ -0,0 +1,48 @@ > +#ifndef __ASM_RISCV_GUEST_ATOMICS_H > +#define __ASM_RISCV_GUEST_ATOMICS_H > + > +/* > + * TODO: implement guest atomics > + */ Along with this, wouldn't it be bett

Re: [PATCH v2 10/39] xen/riscv: introduce asm/iommu.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/iommu.h > @@ -0,0 +1,7 @@ > +#ifndef __ASM_RISCV_IOMMU_H__ > +#define __ASM_RISCV_IOMMU_H__ > + > +struct arch_iommu { > +}; > + > +#endif /* __ASM_IOMMU_H__ */ Instead of adding this header, didn't we

Re: [PATCH 2/3] xen/x86: address violations of MISRA C:2012 Rule 14.4

2023-12-07 Thread Simone Ballarin
On 07/12/23 15:15, Jan Beulich wrote: On 07.12.2023 14:53, Simone Ballarin wrote: On 07/12/23 11:54, Jan Beulich wrote: On 07.12.2023 10:48, Simone Ballarin wrote: --- a/xen/arch/x86/hpet.c +++ b/xen/arch/x86/hpet.c @@ -279,7 +279,7 @@ static int hpet_msi_write(struct hpet_event_channel *ch,

Re: [PATCH v2 08/39] xen/riscv: introduce asm/cpufeature.h

2023-12-07 Thread Jan Beulich
On 07.12.2023 15:19, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: >> Signed-off-by: Oleksii Kurochko > > Acked-by: Jan Beulich Actually - with an SPDX header added. I only now realize that I committed the earlier two patches without paying attention to this aspect. I'd appr

Re: [PATCH v2 11/39] xen/riscv: introduce asm/nospec.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/nospec.h > @@ -0,0 +1,25 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. */ > + > +#ifndef _ASM_RISCV_NOSPEC_H > +#define _ASM_R

Re: [PATCH v2 12/39] xen/riscv: introduce asm/setup.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko With at least SPDX header Acked-by: Jan Beulich

Re: [PATCH v2 00/39] Enable build of full Xen for RISC-V

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Bobby Eshleman (1): > xen/riscv: introduce asm/atomic.h > > Oleksii Kurochko (38): > xen/riscv: disable unnecessary configs > xen/riscv: use some asm-generic headers > xen/riscv:introduce asm/byteorder.h > xen/riscv: add public arch-riscv.h

Re: [PATCH] xen/arm: bootfdt: Check return code of device_tree_for_each_node()

2023-12-07 Thread Michal Orzel
On 07/12/2023 13:54, Julien Grall wrote: > > > Hi Michal, > > On 07/12/2023 12:39, Michal Orzel wrote: >> On 07/12/2023 13:20, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 07/12/2023 10:14, Michal Orzel wrote: As a result of not checking the return code of device_tree_for_each_n

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-07 Thread Julien Grall
Hi George, On 06/12/2023 16:22, George Dunlap wrote: On Wed, Dec 6, 2023 at 11:22 AM Julien Grall wrote: Hi, On 06/12/2023 11:19, Andrew Cooper wrote: On 06/12/2023 8:41 am, Jan Beulich wrote: On 06.12.2023 03:21, George Dunlap wrote: On Tue, Dec 5, 2023 at 6:12 PM Julien Grall wrote: F

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Oleksii
On Thu, 2023-12-07 at 15:11 +0100, Jan Beulich wrote: > On 07.12.2023 14:44, Oleksii wrote: > > On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: > > > On 07.12.2023 10:22, Oleksii wrote: > > > > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: > > > > > > On 24.11.2023 11:30, Oleksii Kuro

Re: [PATCH v2 13/39] xen/riscv: introduce asm/system.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/system.h > @@ -0,0 +1,79 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _ASM_RISCV_BARRIER_H > +#define _ASM_RISCV_BARRIER_H > + > +#include > + > +#ifndef __ASSEMBLY__ > + > +#define RISCV

[libvirt test] 184019: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184019 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/184019/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184003 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v2 01/39] xen/riscv: disable unnecessary configs

2023-12-07 Thread Jan Beulich
On 07.12.2023 15:51, Oleksii wrote: > On Thu, 2023-12-07 at 15:11 +0100, Jan Beulich wrote: >> On 07.12.2023 14:44, Oleksii wrote: >>> On Thu, 2023-12-07 at 11:00 +0100, Jan Beulich wrote: On 07.12.2023 10:22, Oleksii wrote: > On Tue, 2023-12-05 at 16:38 +0100, Jan Beulich wrote: >>> O

xen | Failed pipeline for staging | 02d0a615

2023-12-07 Thread GitLab
Pipeline #1098841648 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 02d0a615 ( https://gitlab.com/xen-project/xen/-/commit/02d0a615b32d03702f79807fa5e88f0cf78dde84 ) Commit Message: xen/arm: boot

Re: [PATCH v5 11/11] xen/arm: create another /memory node for static shm

2023-12-07 Thread Michal Orzel
Hi Penny, On 06/12/2023 10:06, Penny Zheng wrote: > > > Static shared memory region shall be described both under /memory and > /reserved-memory. > > We introduce export_shm_memory_node() to create another /memory node to > contain the static shared memory ranges. > > Signed-off-by: Penny Zhen

Re: [PATCH v2 14/39] xen/riscv: introduce bitops.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko So this looks to have been taken from Linux, which could do with saying (including which version or most recent commit). It may e.g. justify you using tab indentation here, albeit ... > --- /dev/null > +++ b/xen/arch/

Re: [PATCH v2 15/39] xen/riscv: introduce flushtlb.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko Again, with an SPDX header Acked-by: Jan Beulich

Re: [PATCH v2 16/39] xen/riscv: introduce asm/smp.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/smp.h > @@ -0,0 +1,23 @@ > +#ifndef __ASM_RISCV_SMP_H > +#define __ASM_RISCV_SMP_H > + > +#ifndef __ASSEMBLY__ > +#include > +#include > +#endif If you want this to be possible to include from assembl

[xen-unstable-smoke test] 184025: tolerable all pass - PUSHED

2023-12-07 Thread osstest service owner
flight 184025 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184025/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2 17/39] xen/riscv: introduce asm/atomic.h

2023-12-07 Thread Jan Beulich
On 24.11.2023 11:30, Oleksii Kurochko wrote: > From: Bobby Eshleman > > Signed-off-by: Oleksii Kurochko > --- > Changes in V2: > - Change an author of commit. I got this header from Bobby's old repo. Not sure how to deal with that when there's not also an S-o-b. > --- /dev/null > +++ b/xen/ar

[PATCH] MAINTAINERS: Hand over the release manager role to Oleksii Kurochko

2023-12-07 Thread Henry Wang
I've finished the opportunity to do two releases (4.17 and 4.18) and Oleksii Kurochko has volunteered to be the next release manager. Hand over the role to him by changing the maintainership of the CHANGELOG.md. Signed-off-by: Henry Wang --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3

2023-12-07 Thread Julien Grall
Hi Federico, On 07/12/2023 09:08, Federico Serafini wrote: MISRA C:2012 Rule 16.3 states that an unconditional break statement shall terminate every switch-clause. Update ECLAIR configuration to take into account: - continue, goto, return statements; - functions and macros that do not give the

Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3

2023-12-07 Thread Julien Grall
Hi again, On 07/12/2023 09:08, Federico Serafini wrote: MISRA C:2012 Rule 16.3 states that an unconditional break statement shall terminate every switch-clause. Update ECLAIR configuration to take into account: - continue, goto, return statements; - functions and macros that do not give the con

Re: [PATCH] xen/xenbus: client: fix kernel-doc comments

2023-12-07 Thread Randy Dunlap
On 12/7/23 01:27, Juergen Gross wrote: > On 06.12.23 19:17, Randy Dunlap wrote: >> Correct function kernel-doc notation to prevent warnings from >> scripts/kernel-doc. >> >> >> Signed-off-by: Randy Dunlap >> Cc: Juergen Gross >> Cc: Stefano Stabellini >> Cc: Oleksandr Tyshchenko >> Cc: xen-

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-07 Thread Julien Grall
Hi Stefano, On 05/12/2023 23:21, Stefano Stabellini wrote: On Tue, 5 Dec 2023, Julien Grall wrote: I agree that crashing a guest is bad, but is lying to the domain really better? The consequence here is not that bad and hopefully it would be fairly easy to find. But this is not always the case.

[RFC PATCH v1 1/1] xen/Makefile: introduce ARCH_FIXED_CONFIG for randconfig

2023-12-07 Thread Oleksii Kurochko
ARCH_FIXED_CONFIG is required in the case of randconfig and CI for configs that aren't ready or are not supposed to be implemented for specific architecture. These configs should always be disabled to prevent randconfig related tests from failing. Signed-off-by: Oleksii Kurochko --- xen/Makefile

  1   2   >