Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

2023-12-04 Thread Jan Beulich
On 04.12.2023 02:02, Elliott Mitchell wrote: > On Mon, Nov 27, 2023 at 09:27:18AM +0100, Roger Pau Monn >> On Fri, Nov 24, 2023 at 05:15:34PM -0800, Elliott Mitchell wrote: >>> On Thu, Nov 23, 2023 at 10:39:37AM +0100, Roger Pau Monn On Tue, Nov 21, 2023 at 04:56:47PM -0800, Elliott Mitchell w

Re: INFORMAL VOTE REQUIRED - DOCUMENTATION WORDING

2023-12-04 Thread Jan Beulich
On 04.12.2023 06:02, Kelly Choi wrote: > In the specific example above, it's difficult in the sense that informal > voting wasn't officially in the governance yet when the feedback was > raised. What I would recommend in this instance is that if George and > others feel very strongly about removing

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-12-04 Thread Thomas Gleixner
On Fri, Nov 24 2023 at 18:31, Jiqian Chen wrote: > diff --git a/drivers/xen/xen-pciback/pci_stub.c > b/drivers/xen/xen-pciback/pci_stub.c > index 5a96b6c66c07..b83d02bcc76c 100644 > --- a/drivers/xen/xen-pciback/pci_stub.c > +++ b/drivers/xen/xen-pciback/pci_stub.c > @@ -357,6 +357,7 @@ static int

Re: INFORMAL VOTE REQUIRED - DOCUMENTATION WORDING

2023-12-04 Thread Jan Beulich
On 01.12.2023 22:44, Stefano Stabellini wrote: > Replying here on a couple of different people on this thread. > > > On Thu, 30 Nov 2023, Tamas K Lengyel wrote: >> I think this form is bad and is not helpful. > > I agree with Tamas and (also Jan) that this form is not helpful. > > > On Fri, 1

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Jan Beulich
On 02.12.2023 03:56, Stefano Stabellini wrote: > On Fri, 1 Dec 2023, Roger Pau Monné wrote: >> On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: >>> @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( >>> bus = PCI_BUS(machine_sbdf); >>> devfn = PCI_DEVFN(machine_sbd

Re: [PATCH v11 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Jan Beulich
On 02.12.2023 02:27, Volodymyr Babchuk wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -695,6 +695,9 @@ struct domain *domain_create(domid_t domid, > radix_tree_init(&d->pirq_tree); > } > > +if ( !is_idle_domain(d) ) > +d->iomem_caps = rangeset_new(d,

Re: [PATCH v11 06/17] vpci/header: rework exit path in init_bars

2023-12-04 Thread Jan Beulich
On 02.12.2023 02:27, Volodymyr Babchuk wrote: > Introduce "fail" label in init_bars() function to have the centralized > error return path. This is the pre-requirement for the future changes > in this function. > > This patch does not introduce functional changes. > > Signed-off-by: Volodymyr Bab

Re: [XEN PATCH v2 1/3] automation/eclair: tag function calls to address violations of MISRA C:2012 Rule 13.1

2023-12-04 Thread Simone Ballarin
On 02/12/23 04:19, Stefano Stabellini wrote: On Fri, 24 Nov 2023, Simone Ballarin wrote: Rule 13.1: Initializer lists shall not contain persistent side effects Invocations of functions in initializer lists cause violations of rule 13.1 if the called functions are not tagged with __attribute_pur

Re: [PATCH v11 09/17] rangeset: add rangeset_empty() function

2023-12-04 Thread Jan Beulich
On 02.12.2023 02:27, Volodymyr Babchuk wrote: > This function can be used when user wants to remove all rangeset > entries but do not want to destroy rangeset itself. I have to admit that I'm not happy with the name: We're not consistently naming all predicate-like helpers is_...() (see e.g. cpuma

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-04 Thread Michal Orzel
Hi Ayan, On 01/12/2023 19:50, Ayan Kumar Halder wrote: > Currently if user enables HVC_DCC config option in Linux, it invokes > access to debug data transfer registers (ie DBGDTRTX_EL0 on arm64, > DBGDTRTXINT on arm32). As these registers are not emulated, Xen injects > an undefined exception to t

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Jan Beulich
On 01.12.2023 21:48, Oleksii Kurochko wrote: > Ifdef-ing inclusion of allows to avoid > generation of empty for cases when > CONFIG_GRANT_TABLE is not enabled. > > The following changes were done for Arm: > should be included directly because it contains > gnttab_dom0_frames() macros which is u

Re: [PATCH v5 6/7] xen/asm-generic: ifdef inclusion of

2023-12-04 Thread Jan Beulich
On 01.12.2023 21:48, Oleksii Kurochko wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -87,7 +87,7 @@ config MEM_ACCESS_ALWAYS_ON > config MEM_ACCESS > def_bool MEM_ACCESS_ALWAYS_ON > prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON > - depends on HVM

[PATCH 1/2] x86/xen: add CPU dependencies for 32-bit build

2023-12-04 Thread Arnd Bergmann
From: Arnd Bergmann Xen only supports modern CPUs even when running a 32-bit kernel, and it now requires a kernel built for a 64 byte (or larger) cache line: In file included from : In function 'xen_vcpu_setup', inlined from 'xen_vcpu_setup_restore' at arch/x86/xen/enlighten.c:111:3, inl

Re: [RFC KERNEL PATCH v2 1/3] xen/pci: Add xen_reset_device_state function

2023-12-04 Thread Chen, Jiqian
On 2023/12/4 15:58, Thomas Gleixner wrote: > On Fri, Nov 24 2023 at 18:31, Jiqian Chen wrote: >> When device on dom0 side has been reset, the vpci on Xen side >> won't get notification, so that the cached state in vpci is >> all out of date with the real device state. >> To solve that problem, thi

Re: xen | Failed pipeline for staging | 525c7c09

2023-12-04 Thread Jan Beulich
On 02.12.2023 22:00, GitLab wrote: > > > Pipeline #1092667236 has failed! > > Project: xen ( https://gitlab.com/xen-project/xen ) > Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) > > Commit: 525c7c09 ( > https://gitlab.com/xen-project/xen/-/commit/525c7c094b258e8a46b4

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD

2023-12-04 Thread Jan Beulich
On 03.12.2023 10:56, Sébastien Chaumat wrote: > Hello, > > Trying to get the Framework Laptop 13 AMD to work with QubesOS I hit the > following Xen issue : > > Xen version : 4.17.2 > Kernel : 6.5.12-300.fc39.x86_64 > CPU model name : AMD Ryzen 7 7840U w/ Radeon 780M Graphics > > The touchpad

Re: xen | Failed pipeline for staging | 525c7c09

2023-12-04 Thread Michal Orzel
On 04/12/2023 09:56, Jan Beulich wrote: > > > On 02.12.2023 22:00, GitLab wrote: >> >> >> Pipeline #1092667236 has failed! >> >> Project: xen ( https://gitlab.com/xen-project/xen ) >> Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) >> >> Commit: 525c7c09 ( >> https://

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread Jan Beulich
On 01.12.2023 21:12, Andrew Cooper wrote: > On 01/12/2023 7:59 pm, René Winther Højgaard wrote: >> If I set smt=off and try to configure cpupools with credit(1) as if >> all cores are available, I get the following crash.   >> >> The crash happens when I try to use xl cpupool-add-cpu on the disable

Improving conflict resolution inside the Xen Project

2023-12-04 Thread Charles-H. Schulz
Hello, Following up on the discussions on the use of certain terms and the way to handle disagreements that ultimately lead to conflicts, I would like to suggest certain mecanisms to more effectively handle such conflicts. This does not mean I'm against any informal or formal voting - I think it w

Re: Moving domain from credit2 to credit cpupool crash xen

2023-12-04 Thread Jan Beulich
On 01.12.2023 21:13, René Winther Højgaard wrote: > When I move a domain from pool0 with credit2 to any pool with credit(1) I get > the following crash. > > > Software: Xen-4.17.3 / Qubes OS 4.2.0-RC5 > Firmware: Dasharo 0.9.0 - Z790P > Hardware: 13900K > (XEN) Xen BUG at common/sched/credit.c:1

Re: [PATCH] Config.mk: drop -Wdeclaration-after-statement

2023-12-04 Thread Alexander Kanavin
On 12/1/23 20:14, Julien Grall wrote: So I agree that if we were to remove -Wdeclaration-after-statement then we should also update the CODING_STYLE. However, I am not entirely sure I would want to mix code and declaration in the hypervisor. Anyway, I think this is a separate discussion from

Re: Moving domain from credit2 to credit cpupool crash xen

2023-12-04 Thread Jan Beulich
On 04.12.2023 10:23, Jan Beulich wrote: > On 01.12.2023 21:13, René Winther Højgaard wrote: >> When I move a domain from pool0 with credit2 to any pool with credit(1) I >> get the following crash. >> >> >> Software: Xen-4.17.3 / Qubes OS 4.2.0-RC5 >> Firmware: Dasharo 0.9.0 - Z790P >> Hardware: 13

Re: [PATCH v5 6/7] xen/asm-generic: ifdef inclusion of

2023-12-04 Thread Oleksii
On Mon, 2023-12-04 at 09:46 +0100, Jan Beulich wrote: > On 01.12.2023 21:48, Oleksii Kurochko wrote: > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -87,7 +87,7 @@ config MEM_ACCESS_ALWAYS_ON > >  config MEM_ACCESS > >   def_bool MEM_ACCESS_ALWAYS_ON > >   prompt "Memory Access

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Jan Beulich
On 01.12.2023 19:49, Julien Grall wrote: > +Naming convention > +- > + > +'-' should be used to separate words in commandline options and filenames. > +E.g. timer-works. > + > +Note that some of the options and filenames are using '_'. This is now > +deprecated. I certainly appreci

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Oleksii
On Mon, 2023-12-04 at 09:41 +0100, Jan Beulich wrote: > On 01.12.2023 21:48, Oleksii Kurochko wrote: > > Ifdef-ing inclusion of allows to avoid > > generation of empty for cases when > > CONFIG_GRANT_TABLE is not enabled. > > > > The following changes were done for Arm: > > should be included d

[PATCH v2 2/6] amd-vi: set IOMMU page table levels based on guest reported paddr width

2023-12-04 Thread Roger Pau Monne
However take into account the minimum number of levels required by unity maps when setting the page table levels. The previous setting of the page table levels for PV guests based on the highest RAM address was bogus, as there can be other non-RAM regions past the highest RAM address that need to

[PATCH v2 5/6] x86/iommu: switch hwdom IOMMU to use a rangeset

2023-12-04 Thread Roger Pau Monne
The current loop that iterates from 0 to the maximum RAM address in order to setup the IOMMU mappings is highly inefficient, and it will get worse as the amount of RAM increases. It's also not accounting for any reserved regions past the last RAM address. Instead of iterating over memory addresse

[PATCH v2 4/6] x86/iommu: remove regions not to be mapped

2023-12-04 Thread Roger Pau Monne
Introduce the code to remove regions not to be mapped from the rangeset that will be used to setup the IOMMU page tables for the hardware domain. This change also introduces two new functions: remove_xen_ranges() and vpci_subtract_mmcfg() that copy the logic in xen_in_range() and vpci_is_mmcfg_add

[PATCH v2 1/6] iommu/vt-d: do not assume page table levels for quarantine domain

2023-12-04 Thread Roger Pau Monne
Like XSA-445, do not assume IOMMU page table levels on VT-d are always set based on DEFAULT_DOMAIN_ADDRESS_WIDTH and instead fetch the value set by intel_iommu_hwdom_init() from the domain iommu structure. This prevents changes to intel_iommu_hwdom_init() possibly getting the levels out of sync wi

[PATCH v2 0/6] x86/iommu: improve setup time of hwdom IOMMU

2023-12-04 Thread Roger Pau Monne
Hello, The aim of the series is to reduce boot time setup of IOMMU page tables for dom0. The first patch is completely unrelated leftover work from XSA-445, just included in the series because it's IOMMU code. Second patch is a pre-req, as further patches can end up attempting to create maps abo

[PATCH v2 3/6] x86/iommu: introduce a rangeset to perform hwdom IOMMU setup

2023-12-04 Thread Roger Pau Monne
This change just introduces the boilerplate code in order to use a rangeset when setting up the hardware domain IOMMU mappings. The rangeset is never populated in this patch, so it's a non-functional change as far as the mappings the domain gets established. Note there's a change for HVM domains

[PATCH v2 6/6] x86/iommu: cleanup unused functions

2023-12-04 Thread Roger Pau Monne
Remove xen_in_range() and vpci_is_mmcfg_address() now that hey are unused. Adjust comments to point to the new functions that replace the existing ones. No functional change. Signed-off-by: Roger Pau Monné --- Can be squashed with the previous patch if desired, split as a separate patch for cla

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Jan Beulich
On 04.12.2023 10:39, Oleksii wrote: > On Mon, 2023-12-04 at 09:41 +0100, Jan Beulich wrote: >> On 01.12.2023 21:48, Oleksii Kurochko wrote: >>> Ifdef-ing inclusion of allows to avoid >>> generation of empty for cases when >>> CONFIG_GRANT_TABLE is not enabled. >>> >>> The following changes were d

Re: [PATCH 1/3] xen/ppc: Enable Boot Allocator

2023-12-04 Thread Oleksii
Hi Julien and Shawn, On Fri, 2023-12-01 at 20:56 +, Julien Grall wrote: > (+ Arm and RISC-V folks) > > Hi Shawn, > > On 01/12/2023 20:59, Shawn Anastasio wrote: > > Adapt arm's earlyfdt parsing code to ppc64 and enable Xen's early > > boot > > allocator. Routines for parsing arm-specific dev

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread Juergen Gross
On 04.12.23 10:15, Jan Beulich wrote: On 01.12.2023 21:12, Andrew Cooper wrote: On 01/12/2023 7:59 pm, René Winther Højgaard wrote: If I set smt=off and try to configure cpupools with credit(1) as if all cores are available, I get the following crash. The crash happens when I try to use xl cpu

xen | Failed pipeline for staging | 525c7c09

2023-12-04 Thread GitLab
Pipeline #1093622286 has failed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 525c7c09 ( https://gitlab.com/xen-project/xen/-/commit/525c7c094b258e8a46b494488eef96f5670eb352 ) Commit Message: xen/arm: Move

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread Jan Beulich
On 04.12.2023 11:02, Juergen Gross wrote: > On 04.12.23 10:15, Jan Beulich wrote: >> On 01.12.2023 21:12, Andrew Cooper wrote: >>> On 01/12/2023 7:59 pm, René Winther Højgaard wrote: If I set smt=off and try to configure cpupools with credit(1) as if all cores are available, I get the fol

Re: Moving domain from credit2 to credit cpupool crash xen

2023-12-04 Thread Juergen Gross
On 04.12.23 10:31, Jan Beulich wrote: On 04.12.2023 10:23, Jan Beulich wrote: On 01.12.2023 21:13, René Winther Højgaard wrote: When I move a domain from pool0 with credit2 to any pool with credit(1) I get the following crash. Software: Xen-4.17.3 / Qubes OS 4.2.0-RC5 Firmware: Dasharo 0.9.0

Re: [RFC KERNEL PATCH v2 2/3] xen/pvh: Unmask irq for passthrough device in PVH dom0

2023-12-04 Thread Roger Pau Monné
On Fri, Dec 01, 2023 at 07:37:55PM -0800, Stefano Stabellini wrote: > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > On Thu, Nov 30, 2023 at 07:15:17PM -0800, Stefano Stabellini wrote: > > > On Thu, 30 Nov 2023, Roger Pau Monné wrote: > > > > On Wed, Nov 29, 2023 at 07:53:59PM -0800, Stefano Stabel

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-04 Thread Julien Grall
Hi Ayan, On 01/12/2023 18:50, Ayan Kumar Halder wrote: Currently if user enables HVC_DCC config option in Linux, it invokes access to debug data transfer registers (ie DBGDTRTX_EL0 on arm64, DBGDTRTXINT on arm32). As these registers are not emulated, Xen injects an undefined exception to the gue

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Oleksii
On Mon, 2023-12-04 at 10:46 +0100, Jan Beulich wrote: > On 04.12.2023 10:39, Oleksii wrote: > > On Mon, 2023-12-04 at 09:41 +0100, Jan Beulich wrote: > > > On 01.12.2023 21:48, Oleksii Kurochko wrote: > > > > Ifdef-ing inclusion of allows to avoid > > > > generation of empty for cases when > > >

Re: [XEN PATCH v2 2/3] xen/arm: add SAF deviation for debugging and logging effects

2023-12-04 Thread Simone Ballarin
On 28/11/23 09:42, Jan Beulich wrote: On 27.11.2023 18:34, Simone Ballarin wrote: On 27/11/23 16:09, Jan Beulich wrote: On 27.11.2023 15:35, Simone Ballarin wrote: On 27/11/23 11:46, Jan Beulich wrote: On 24.11.2023 18:29, Simone Ballarin wrote: --- a/docs/misra/safe.json +++ b/docs/misra/sa

Re: [PATCH v5 5/7] xen: ifdef inclusion of in

2023-12-04 Thread Jan Beulich
On 04.12.2023 11:34, Oleksii wrote: > If you ( or anyone else ) don't mind, I'll update the patch with an > introduction of HAS_GRANT_TABLE. I won't NAK such a patch, but unless convincing arguments appear I also won't ACK it. Jan

Re: INFORMAL VOTE REQUIRED - DOCUMENTATION WORDING

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 8:16 AM Jan Beulich wrote: > > I am in favor on moving faster and nitpicking less. Also, Andy put the > > effort to produce the patch so he should have the default choice in the > > wording. If the choice is taking the patch as is or rejecting it, I > > would take it as is.

[PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Jan Beulich
It is only in the error case that we want to clean up the new pool's scheduler data; in the success case it's rather the old scheduler's data which needs cleaning up. Reported-by: René Winther Højgaard Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross --- a/xen/common/sched/core.c +++ b/xe

Re: [PATCH v6 4/5] [FUTURE] xen/arm: enable vPCI for domUs

2023-12-04 Thread Roger Pau Monné
On Fri, Dec 01, 2023 at 06:56:32PM -0800, Stefano Stabellini wrote: > On Fri, 1 Dec 2023, Roger Pau Monné wrote: > > On Mon, Nov 13, 2023 at 05:21:13PM -0500, Stewart Hildebrand wrote: > > > @@ -1618,6 +1630,14 @@ int iommu_do_pci_domctl( > > > bus = PCI_BUS(machine_sbdf); > > > d

Re: [PATCH] x86/x2apic: introduce a mixed physical/cluster mode

2023-12-04 Thread Roger Pau Monné
On Sun, Dec 03, 2023 at 05:02:04PM -0800, Elliott Mitchell wrote: > On Mon, Nov 27, 2023 at 09:27:18AM +0100, Roger Pau Monn > > On Fri, Nov 24, 2023 at 05:15:34PM -0800, Elliott Mitchell wrote: > > > On Thu, Nov 23, 2023 at 10:39:37AM +0100, Roger Pau Monn > > > > On Tue, Nov 21, 2023 at 04:56:47P

Re: [RFC XEN PATCH v2 1/3] xen/vpci: Clear all vpci status of device

2023-12-04 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 06:57:03AM +, Chen, Jiqian wrote: > Hi Daniel P. Smith, > > On 2023/11/30 22:52, Roger Pau Monné wrote: > > On Thu, Nov 30, 2023 at 07:39:38AM -0500, Daniel P. Smith wrote: > >> On 11/30/23 07:25, Daniel P. Smith wrote: > >>> On 11/30/23 01:22, Chen, Jiqian wrote: > >>>

Re: [RFC XEN PATCH v2 3/3] tools: Add new function to get gsi from irq

2023-12-04 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 05:38:06AM +, Chen, Jiqian wrote: > On 2023/12/1 17:03, Roger Pau Monné wrote: > > On Thu, Nov 30, 2023 at 07:09:12PM -0800, Stefano Stabellini wrote: > >> On Thu, 30 Nov 2023, Roger Pau Monné wrote: > >>> On Wed, Nov 29, 2023 at 08:02:40PM -0800, Stefano Stabellini wrot

[PATCH] bump default SeaBIOS version to 1.16.3

2023-12-04 Thread Jan Beulich
Signed-off-by: Jan Beulich --- a/Config.mk +++ b/Config.mk @@ -229,7 +229,7 @@ MINIOS_UPSTREAM_URL ?= https://xenbits.x MINIOS_UPSTREAM_REVISION ?= b08019f0b2fbc30c75169a160acb9fd9af5d68f4 SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git -SEABIOS_UPSTREAM_REVISION ?= rel-1

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Luca Fancellu
> On 1 Dec 2023, at 18:49, Julien Grall wrote: > > > > On 01/12/2023 18:47, Julien Grall wrote: >> From: Julien Grall >> Several maintainers have expressed a stronger preference >> to use '-' when in filename and option that contains multiple >> words. >> So document it in CODING_STYLE. >> S

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Julien Grall
Hi Luca, On 04/12/2023 11:20, Luca Fancellu wrote: On 1 Dec 2023, at 18:49, Julien Grall wrote: On 01/12/2023 18:47, Julien Grall wrote: From: Julien Grall Several maintainers have expressed a stronger preference to use '-' when in filename and option that contains multiple words. So do

Re: [PATCH] CODING_STYLE: Add a section of the naming convention

2023-12-04 Thread Luca Fancellu
> On 4 Dec 2023, at 11:31, Julien Grall wrote: > > Hi Luca, > > On 04/12/2023 11:20, Luca Fancellu wrote: >>> On 1 Dec 2023, at 18:49, Julien Grall wrote: >>> >>> >>> >>> On 01/12/2023 18:47, Julien Grall wrote: From: Julien Grall Several maintainers have expressed a stronger pr

Re: [PATCH v9 2/2] xen/vpci: header: filter PCI capabilities

2023-12-04 Thread Jan Beulich
On 01.12.2023 16:45, Stewart Hildebrand wrote: > --- a/xen/drivers/pci/pci.c > +++ b/xen/drivers/pci/pci.c > @@ -39,31 +39,42 @@ unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, > unsigned int cap) > return 0; > } > > -unsigned int pci_find_next_cap(pci_sbdf_t sbdf, unsigned int pos, > -

Re: [PATCH] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3

2023-12-04 Thread Nicola Vetrini
On 2023-11-30 15:56, Jan Beulich wrote: On 30.11.2023 08:55, Jan Beulich wrote: The rule demands that all array elements be initialized (or dedicated initializers be used). Introduce a small set of macros to allow doing so without unduly affecting use sites (in particular in terms of how many

Re: [XEN PATCH 7/7] xen/page_alloc: deviate first_valid_mfn for MISRA C Rule 8.4

2023-12-04 Thread Nicola Vetrini
On 2023-12-04 08:44, Jan Beulich wrote: On 02.12.2023 04:03, Stefano Stabellini wrote: On Fri, 1 Dec 2023, Jan Beulich wrote: On 01.12.2023 03:47, Stefano Stabellini wrote: On Wed, 29 Nov 2023, Nicola Vetrini wrote: No functional change. Signed-off-by: Nicola Vetrini --- The preferred way t

[xen-unstable test] 183983: tolerable FAIL

2023-12-04 Thread osstest service owner
flight 183983 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183983/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 183971 test-amd64-amd64-xl-qemut-win7-amd64

Re: Trying add smt=off disabled cores to cpupool crash xen

2023-12-04 Thread Juergen Gross
On 04.12.23 11:13, Jan Beulich wrote: On 04.12.2023 11:02, Juergen Gross wrote: On 04.12.23 10:15, Jan Beulich wrote: On 01.12.2023 21:12, Andrew Cooper wrote: On 01/12/2023 7:59 pm, René Winther Højgaard wrote: If I set smt=off and try to configure cpupools with credit(1) as if all cores are

Re: [PATCH] x86/DMI: adjustments to comply with Misra C:2012 Rule 9.3

2023-12-04 Thread Jan Beulich
On 04.12.2023 12:52, Nicola Vetrini wrote: > On 2023-11-30 15:56, Jan Beulich wrote: >> On 30.11.2023 08:55, Jan Beulich wrote: >>> The rule demands that all array elements be initialized (or dedicated >>> initializers be used). Introduce a small set of macros to allow doing >>> so >>> without und

Re: [PATCH 06/12] scsi: remove AioContext locking

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > The AioContext lock no longer has any effect. Remove it. > > Signed-off-by: Stefan Hajnoczi > --- > include/hw/virtio/virtio-scsi.h | 14 -- > hw/scsi/scsi-bus.c | 2 -- > hw/scsi/scsi-disk.c | 28 +++

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > Protect the Task Management Function BH state with a lock. The TMF BH > runs in the main loop thread. An IOThread might process a TMF at the > same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh > must be protected by a lock

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > Protect the Task Management Function BH state with a lock. The TMF BH > runs in the main loop thread. An IOThread might process a TMF at the > same time as the TMF BH is running. Therefore tmf_bh_list and tmf_bh > must be protected by a lock

Re: [PATCH 02/12] tests: remove aio_context_acquire() tests

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > The aio_context_acquire() API is being removed. Drop the test case that > calls the API. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf

Re: [PATCH 1/2] x86/xen: add CPU dependencies for 32-bit build

2023-12-04 Thread Juergen Gross
On 04.12.23 09:47, Arnd Bergmann wrote: From: Arnd Bergmann Xen only supports modern CPUs even when running a 32-bit kernel, and it now requires a kernel built for a 64 byte (or larger) cache line: In file included from : In function 'xen_vcpu_setup', inlined from 'xen_vcpu_setup_restore'

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: > > It is only in the error case that we want to clean up the new pool's > scheduler data; in the success case it's rather the old scheduler's > data which needs cleaning up. > > Reported-by: René Winther Højgaard > Signed-off-by: Jan Beulich >

Re: [RFC PATCH] xen/arm: Add emulation of Debug Data Transfer Registers

2023-12-04 Thread Ayan Kumar Halder
On 04/12/2023 10:31, Julien Grall wrote: Hi Ayan, Hi Julien, On 01/12/2023 18:50, Ayan Kumar Halder wrote: Currently if user enables HVC_DCC config option in Linux, it invokes access to debug data transfer registers (ie DBGDTRTX_EL0 on arm64, DBGDTRTXINT on arm32). As these registers are no

Re: [PATCH] bump default SeaBIOS version to 1.16.3

2023-12-04 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 12:12:58PM +0100, Jan Beulich wrote: > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH 03/12] aio: make aio_context_acquire()/aio_context_release() a no-op

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > aio_context_acquire()/aio_context_release() has been replaced by > fine-grained locking to protect state shared by multiple threads. The > AioContext lock still plays the role of balancing locking in > AIO_WAIT_WHILE() and many functions in

Re: [PATCH v2] x86emul: avoid triggering event related assertions

2023-12-04 Thread Andrew Cooper
On 17/04/2023 1:23 pm, Jan Beulich wrote: > The assertion at the end of x86_emulate_wrapper() as well as the ones > in x86_emul_{hw_exception,pagefault}() can trigger if we ignore > X86EMUL_EXCEPTION coming back from certain hook functions. Squash > exceptions when merely probing MSRs, plus on SWAP

Re: [PATCH 04/12] graph-lock: remove AioContext locking

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > Stop acquiring/releasing the AioContext lock in > bdrv_graph_wrlock()/bdrv_graph_unlock() since the lock no longer has any > effect. > > The distinction between bdrv_graph_wrunlock() and > bdrv_graph_wrunlock_ctx() becomes meaningless and t

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 14:00, George Dunlap wrote: On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool's scheduler data; in the success case it's rather the old scheduler's data which needs cleaning up. Reported-by: René Winther Højgaard

xen | Successful pipeline for staging | 525c7c09

2023-12-04 Thread GitLab
Pipeline #1093622286 has passed! Project: xen ( https://gitlab.com/xen-project/xen ) Branch: staging ( https://gitlab.com/xen-project/xen/-/commits/staging ) Commit: 525c7c09 ( https://gitlab.com/xen-project/xen/-/commit/525c7c094b258e8a46b494488eef96f5670eb352 ) Commit Message: xen/arm: Move

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 1:47 PM Juergen Gross wrote: > > On 04.12.23 14:00, George Dunlap wrote: > > On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: > >> > >> It is only in the error case that we want to clean up the new pool's > >> scheduler data; in the success case it's rather the old schedu

Re: [PATCH v9 1/2] xen/vpci: header: status register handler

2023-12-04 Thread Roger Pau Monné
On Fri, Dec 01, 2023 at 10:45:49AM -0500, Stewart Hildebrand wrote: > Introduce a handler for the PCI status register, with ability to mask > the capabilities bit. The status register contains RsvdZ bits, > read-only bits, and write-1-to-clear bits. Additionally, we use RsvdP to > mask the capabili

Re: [PATCH v9 2/2] xen/vpci: header: filter PCI capabilities

2023-12-04 Thread Roger Pau Monné
On Mon, Dec 04, 2023 at 12:48:00PM +0100, Jan Beulich wrote: > On 01.12.2023 16:45, Stewart Hildebrand wrote: > > --- a/xen/drivers/pci/pci.c > > +++ b/xen/drivers/pci/pci.c > > @@ -39,31 +39,42 @@ unsigned int pci_find_cap_offset(pci_sbdf_t sbdf, > > unsigned int cap) > > return 0; > > } >

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 14:00, George Dunlap wrote: On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool's scheduler data; in the success case it's rather the old scheduler's data which needs cleaning up. Reported-by: René Winther Højgaard

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread George Dunlap
On Mon, Dec 4, 2023 at 2:10 PM Juergen Gross wrote: > > On 04.12.23 14:00, George Dunlap wrote: > > On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: > >> > >> It is only in the error case that we want to clean up the new pool's > >> scheduler data; in the success case it's rather the old schedu

Re: [PATCH 05/12] block: remove AioContext locking

2023-12-04 Thread Kevin Wolf
Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > This is the big patch that removes > aio_context_acquire()/aio_context_release() from the block layer and > affected block layer users. > > There isn't a clean way to split this patch and the reviewers are likely > the same group of people,

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Jan Beulich
On 04.12.2023 15:10, Juergen Gross wrote: > And I have again a third approach, making it crystal clear what is happening > with which data. No need to explain what is freed via which variables. See > attached patch (this time it should be really there). Looks more neat to me than George's. Just on

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Jan Beulich
On 04.12.2023 15:18, George Dunlap wrote: > On Mon, Dec 4, 2023 at 2:10 PM Juergen Gross wrote: >> >> On 04.12.23 14:00, George Dunlap wrote: >>> On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool's scheduler data;

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 15:38, Jan Beulich wrote: On 04.12.2023 15:10, Juergen Gross wrote: And I have again a third approach, making it crystal clear what is happening with which data. No need to explain what is freed via which variables. See attached patch (this time it should be really there). Looks mo

Re: [linux-linus test] 183981: regressions - FAIL

2023-12-04 Thread Anthony PERARD
On Mon, Dec 04, 2023 at 06:56:50AM +0100, Juergen Gross wrote: > On 04.12.23 00:51, osstest service owner wrote: > > flight 183981 linux-linus real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/183981/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > >

Re: [PATCH] sched: correct sched_move_domain()'s cleanup path

2023-12-04 Thread Juergen Gross
On 04.12.23 15:39, Jan Beulich wrote: On 04.12.2023 15:18, George Dunlap wrote: On Mon, Dec 4, 2023 at 2:10 PM Juergen Gross wrote: On 04.12.23 14:00, George Dunlap wrote: On Mon, Dec 4, 2023 at 10:57 AM Jan Beulich wrote: It is only in the error case that we want to clean up the new pool

Re: [linux-linus test] 183981: regressions - FAIL

2023-12-04 Thread Juergen Gross
On 04.12.23 15:42, Anthony PERARD wrote: On Mon, Dec 04, 2023 at 06:56:50AM +0100, Juergen Gross wrote: On 04.12.23 00:51, osstest service owner wrote: flight 183981 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183981/ Regressions :-( Tests which did not succeed an

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Stefan Hajnoczi
On Thu, Nov 30, 2023 at 09:25:52AM -0600, Eric Blake wrote: > On Wed, Nov 29, 2023 at 02:55:42PM -0500, Stefan Hajnoczi wrote: > > Protect the Task Management Function BH state with a lock. The TMF BH > > runs in the main loop thread. An IOThread might process a TMF at the > > same time as the TMF

Re: [PATCH v4 3/6] xen: decouple generic xen code from legacy backends codebase

2023-12-04 Thread Paul Durrant
On 02/12/2023 01:41, Volodymyr Babchuk wrote: In xen-all.c there are unneeded dependencies on xen-legacy-backend.c: - xen_init() uses xen_pv_printf() to report errors, but it does not provide a pointer to the struct XenLegacyDevice, so it is kind of useless, we can use standard error_repor

Re: [PATCH 01/12] virtio-scsi: replace AioContext lock with tmf_bh_lock

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 01:46:13PM +0100, Kevin Wolf wrote: > Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > > Protect the Task Management Function BH state with a lock. The TMF BH > > runs in the main loop thread. An IOThread might process a TMF at the > > same time as the TMF BH is run

Re: [XEN PATCH 1/2] x86/p2m: preparation work for xenmem_add_to_physmap_one()

2023-12-04 Thread Jan Beulich
On 30.11.2023 16:48, Federico Serafini wrote: > The objective is to use parameter name "gfn" for > xenmem_add_to_physmap_one(). > Since the name "gfn" is currently used as identifier for a local > variable, bad things could happen if new uses of such variable are > committed while a renaming patch

Re: [XEN PATCH 2/2] x86/p2m: address a violation of MISRA C:2012 Rule 8.3

2023-12-04 Thread Jan Beulich
On 30.11.2023 16:48, Federico Serafini wrote: > Make function declaration and definition consistent changing > parameter name from "gpfn" to "gfn". > For consistency, rename also "old_gpfn" to "old_gfn". > No functional change. > > Signed-off-by: Federico Serafini Reviewed-by: Jan Beulich > --

Re: [PATCH 05/12] block: remove AioContext locking

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 03:33:57PM +0100, Kevin Wolf wrote: > Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > > This is the big patch that removes > > aio_context_acquire()/aio_context_release() from the block layer and > > affected block layer users. > > > > There isn't a clean way to s

Re: [XEN PATCH 2/2] x86/p2m: address a violation of MISRA C:2012 Rule 8.3

2023-12-04 Thread Federico Serafini
On 04/12/23 15:54, Jan Beulich wrote: On 30.11.2023 16:48, Federico Serafini wrote: Make function declaration and definition consistent changing parameter name from "gpfn" to "gfn". For consistency, rename also "old_gpfn" to "old_gfn". No functional change. Signed-off-by: Federico Serafini R

[PATCH v2 1/3] xen/sched: fix adding offline cpu to cpupool

2023-12-04 Thread Juergen Gross
Trying to add an offline cpu to a cpupool can crash the hypervisor, as the probably non-existing percpu area of the cpu is accessed before the availability of the cpu is being tested. This can happen in case the cpupool's granularity is "core" or "socket". Fix that by testing the cpu to be online.

[PATCH v2 3/3] xen/sched: do some minor cleanup of sched_move_domain()

2023-12-04 Thread Juergen Gross
Do some minor cleanups: - Move setting of old_domdata and old_units next to each other - Drop incrementing unit_idx in the final loop of sched_move_domain() as it isn't used afterwards - Rename new_p to new_cpu and unit_p to unit_cpu Signed-off-by: Juergen Gross --- V2: - new patch --- xen/co

[PATCH v2 2/3] xen/sched: fix sched_move_domain()

2023-12-04 Thread Juergen Gross
Do cleanup in sched_move_domain() in a dedicated service function, which is called either in error case with newly allocated data, or in success case with the old data to be freed. This will at once fix some subtle bugs which sneaked in due to forgetting to overwrite some pointers in the error cas

[PATCH v2 0/3] xen/sched: fixes and cleanup related to cpupools

2023-12-04 Thread Juergen Gross
Fix 2 bugs related to cpupool handling and do some related cleanups. V2: - send out the fixes tagged properly as "PATCH" - add cleanup patch Juergen Gross (3): xen/sched: fix adding offline cpu to cpupool xen/sched: fix sched_move_domain() xen/sched: do some minor cleanup of sched_move_dom

Re: [PATCH 06/12] scsi: remove AioContext locking

2023-12-04 Thread Stefan Hajnoczi
On Mon, Dec 04, 2023 at 01:23:09PM +0100, Kevin Wolf wrote: > Am 29.11.2023 um 20:55 hat Stefan Hajnoczi geschrieben: > > The AioContext lock no longer has any effect. Remove it. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > include/hw/virtio/virtio-scsi.h | 14 -- > > hw/scsi/s

Re: [PATCH 05/12] block: remove AioContext locking

2023-12-04 Thread Stefan Hajnoczi
On Thu, Nov 30, 2023 at 03:31:37PM -0600, Eric Blake wrote: > On Wed, Nov 29, 2023 at 02:55:46PM -0500, Stefan Hajnoczi wrote: > > This is the big patch that removes > > aio_context_acquire()/aio_context_release() from the block layer and > > affected block layer users. > > > > There isn't a clean

Re: [XEN PATCH 1/2] x86/p2m: preparation work for xenmem_add_to_physmap_one()

2023-12-04 Thread Federico Serafini
On 04/12/23 15:51, Jan Beulich wrote: On 30.11.2023 16:48, Federico Serafini wrote: The objective is to use parameter name "gfn" for xenmem_add_to_physmap_one(). Since the name "gfn" is currently used as identifier for a local variable, bad things could happen if new uses of such variable are co

Re: [PATCH v11 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Stewart Hildebrand
On 12/4/23 03:29, Jan Beulich wrote: > On 02.12.2023 02:27, Volodymyr Babchuk wrote: >> --- a/xen/common/domain.c >> +++ b/xen/common/domain.c >> @@ -695,6 +695,9 @@ struct domain *domain_create(domid_t domid, >> radix_tree_init(&d->pirq_tree); >> } >> >> +if ( !is_idle_domain(d

[PATCH v11.1 16/17] xen/arm: vpci: permit access to guest vpci space

2023-12-04 Thread Stewart Hildebrand
Move iomem_caps initialization earlier (before arch_domain_create()). Signed-off-by: Stewart Hildebrand Signed-off-by: Volodymyr Babchuk --- Changes in v11: * move both iomem_caps and irq_caps initializations earlier, along with NULL check Changes in v10: * fix off-by-one * also permit access

  1   2   >