Re: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

On 30.08.2023 20:09, Andrew Cooper wrote: > On 30/08/2023 3:30 pm, Roger Pau Monné wrote: >> On Wed, Sep 12, 2018 at 03:09:35AM -0600, Jan Beulich wrote: >>> The function does two translations in one go for a single guest access. >>> Any failure of the first translation step (guest linear -> guest

[xen-unstable-smoke test] 182577: tolerable all pass - PUSHED

flight 182577 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182577/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

On 30.08.2023 16:30, Roger Pau Monné wrote: > On Wed, Sep 12, 2018 at 03:09:35AM -0600, Jan Beulich wrote: >> The function does two translations in one go for a single guest access. >> Any failure of the first translation step (guest linear -> guest >> physical), resulting in #PF, ought to take pre

Re: [XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device()

On 30/08/2023 19:48, Vikram Garhwal wrote: > Hi Michal, > On Tue, Aug 29, 2023 at 10:23:30AM +0200, Michal Orzel wrote: >> >> >> On 25/08/2023 10:02, Vikram Garhwal wrote: >>> Remove master device from the IOMMU. This will be helpful when removing the >>> overlay nodes using dynamic programming d

Re: [XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device()

On 31/08/2023 09:23, Michal Orzel wrote: > > > On 30/08/2023 19:48, Vikram Garhwal wrote: >> Hi Michal, >> On Tue, Aug 29, 2023 at 10:23:30AM +0200, Michal Orzel wrote: >>> >>> >>> On 25/08/2023 10:02, Vikram Garhwal wrote: Remove master device from the IOMMU. This will be helpful when re

[xen-unstable test] 182571: tolerable FAIL - PUSHED

flight 182571 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182571/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 182563 test-armhf-armhf-libvirt 16 save

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi

Thanks Roger, we will send a new series after the freezing time of Xen release 4.18. On 2023/8/23 16:57, Roger Pau Monné wrote: > On Mon, Jul 31, 2023 at 04:40:35PM +, Chen, Jiqian wrote: >> Hi, >> >> On 2023/3/18 04:55, Stefano Stabellini wrote: >>> On Fri, 17 Mar 2023, Roger Pau Monné wrote

Re: [PATCH] x86/HVM: correct hvmemul_map_linear_addr() for multi-page case

On Thu, Aug 31, 2023 at 09:03:18AM +0200, Jan Beulich wrote: > On 30.08.2023 20:09, Andrew Cooper wrote: > > On 30/08/2023 3:30 pm, Roger Pau Monné wrote: > >> On Wed, Sep 12, 2018 at 03:09:35AM -0600, Jan Beulich wrote: > >>> The function does two translations in one go for a single guest access.

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini wrote: > As Xen is gaining R52 and R82 support, it would be great to be able to > use QEMU for development and testing there as well, but I don't think > QEMU can emulate EL2 properly for the Cortex-R architecture. We would > need EL2 support in the

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

Hi Henry, On 28/08/2023 02:32, Henry Wang wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. Currently mmu_init_secondary_cpu() only enforces the page table should

Re: [PATCH v6 08/13] xen/arm: Fold mmu_init_secondary_cpu() to head.S

Hi Ayan, > On Aug 31, 2023, at 17:12, Ayan Kumar Halder wrote: > > Hi Henry, > > On 28/08/2023 02:32, Henry Wang wrote: >> >> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S >> index 33b038e7e0..39218cf15f 100644 >> --- a/xen/arch/arm/arm32/head.S >> +++ b/xen/arch/arm/arm32

Re: [XEN PATCH 05/13] automation/eclair: add deviation for usercopy.c

On 31.08.2023 03:56, Stefano Stabellini wrote: > On Wed, 30 Aug 2023, Simone Ballarin wrote: >> On 29/08/23 00:27, Stefano Stabellini wrote: >>> On Mon, 28 Aug 2023, Simone Ballarin wrote: >>> --- a/xen/arch/x86/usercopy.c >>> +++ b/xen/arch/x86/usercopy.c >>> @@ -1,3 +1,4 @@ >>> +/* SAF-1-safe */

Re: [PATCH v2] docs/misra: add 14.3

On 31.08.2023 03:53, Stefano Stabellini wrote: > @@ -332,6 +333,17 @@ maintainers if you want to suggest a change. > - A loop counter shall not have essentially floating type > - > > + * - `Rule 14.3 >

[QEMU PATCH v4 00/13] Support blob memory and venus on qemu

Hi all, Antonio Caggiano made the venus with QEMU on KVM platform last September[1]. This series are inherited from his original work to support the features of context init, hostmem, resource uuid, and blob resources for venus. At March of this year, we sent out the V1 version[2] for the review.

[QEMU PATCH v4 01/13] virtio: Add shared memory capability

From: "Dr. David Alan Gilbert" Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow defining shared memory regions with sizes and offsets of 2^32 and more. Multiple instances of the capability are allowed and distinguished by a device-specific 'id'. Signed-off-by: Dr. David A

[QEMU PATCH v4 02/13] virtio-gpu: CONTEXT_INIT feature

From: Antonio Caggiano The feature can be enabled when a backend wants it. Signed-off-by: Antonio Caggiano Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Akihiko Odaki Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Akihiko Odaki Signed-of

[QEMU PATCH v4 04/13] virtio-gpu: blob prep

From: Antonio Caggiano This adds preparatory functions needed to: - decode blob cmds - tracking iovecs Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko Signed-off-by: Gurchetan Singh Tested-by: Alyssa Ross Tested-by: Emmanouil Pitsidianakis Tested-by: Akihiko Odaki

[QEMU PATCH v4 03/13] virtio-gpu: hostmem

From: Gerd Hoffmann Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu. Signed-off-by: Antonio Caggiano Tested-by: Alyssa Ross Tested-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Reviewed-by: Akihiko Odaki Signed-off-by: Huang Rui --- This patch is already under review as part of t

[QEMU PATCH v4 05/13] virtio-gpu: Support context init feature with virglrenderer

Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. We would like to enable the feature with virglrenderer, so add to create virgl renderer context with flags using context_id when valid. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui --- New patch, resu

[QEMU PATCH v4 06/13] virtio-gpu: Configure context init for virglrenderer

Configure context init feature flag for virglrenderer. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui --- New patch, result of splitting [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature meson.build | 4 1 file changed, 4 insertions(+) diff --git a/meson.build b/meson.bu

[QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all of her references have gone away, via the object's free callback. However, currently, references to the memory region are held by

[QEMU PATCH v4 08/13] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled

From: Dmitry Osipenko The udmabuf usage is mandatory when virgl is disabled and blobs feature enabled in the Qemu machine configuration. If virgl and blobs are enabled, then udmabuf requirement is optional. Since udmabuf isn't widely supported by a popular Linux distros today, let's relax the udm

Re: [QEMU PATCH v4 06/13] virtio-gpu: Configure context init for virglrenderer

On 31/8/23 11:32, Huang Rui wrote: Configure context init feature flag for virglrenderer. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui --- New patch, result of splitting [RFC QEMU PATCH 04/18] virtio-gpu: CONTEXT_INIT feature meson.build | 4 1 file changed, 4 insertions(

[QEMU PATCH v4 11/13] virtio-gpu: Support Venus capset

From: Antonio Caggiano Add support for the Venus capset, which enables Vulkan support through the Venus Vulkan driver for virtio-gpu. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- hw/display/virtio-gpu-virgl.c | 21 + include/standard-headers/l

[QEMU PATCH v4 13/13] virtio-gpu: Enable virglrenderer render server flag for venus

Venus in virglrenderer has required render server support. Signed-off-by: Huang Rui --- New patch hw/display/virtio-gpu-virgl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index c5a62665bd..1ae3e458e2 100644

Re: [QEMU PATCH v4 05/13] virtio-gpu: Support context init feature with virglrenderer

On 31/8/23 11:32, Huang Rui wrote: Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. We would like to enable the feature with virglrenderer, so add to create virgl renderer context with flags using context_id when valid. Originally-by: Antonio Caggiano Signed-of

[QEMU PATCH v4 10/13] virtio-gpu: Resource UUID

From: Antonio Caggiano Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- v1->v2: - Separate declarations from code. hw/display/

[QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Dmitry Osipenko Signed-

[QEMU PATCH v4 12/13] virtio-gpu: Initialize Venus

From: Antonio Caggiano Request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- v1->v2: - Rebase to latest version hw/display/virtio-gpu-virgl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/vi

Re: [PATCH v3 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

On 30.08.2023 18:57, Oleksii Kurochko wrote: > asm/vm_event.h is common for ARM and RISC-V so it will be moved to > asm-generic dir. > > Original asm/vm_event.h from ARM was updated: > * use SPDX-License-Identifier. > * update comment messages of stubs. > * update #ifdef. > * change public/dom

Re: QEMU features useful for Xen development?

Peter Maydell writes: > On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini > wrote: >> As Xen is gaining R52 and R82 support, it would be great to be able to >> use QEMU for development and testing there as well, but I don't think >> QEMU can emulate EL2 properly for the Cortex-R architecture.

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 10:53, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini > > wrote: > >> As Xen is gaining R52 and R82 support, it would be great to be able to > >> use QEMU for development and testing there as well, but I don't think >

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

On 29/08/23 08:50, Jan Beulich wrote: On 28.08.2023 15:20, Simone Ballarin wrote: Add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Also C files, if included s

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

On 2023/08/31 18:32, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent and once all of her references have gone away, via the object's free callback. However, currently, ref

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano

[ANNOUNCE] Call for agenda items for 7 September Community Call @ 1500 UTC

Hi all, The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/s6D6t2vTjCkpfRIJXo8IVSWf/ and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the document. N

Re: QEMU features useful for Xen development?

Hi Peter/Alex, Appreciate your help. :) On 31/08/2023 11:03, Peter Maydell wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. On Thu, 31 Aug 2023 at 10:53, Alex Be

Re: [QEMU PATCH v4 10/13] virtio-gpu: Resource UUID

On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Enable resource UUID feature and implement command resource assign UUID. This is done by introducing a hash table to map resource IDs to their UUIDs. The hash table does not seem to be stored during migration. Signed-off-by: Anto

Re: [QEMU PATCH v4 12/13] virtio-gpu: Initialize Venus

Hi Huang, Thank you for pushing this forward! On 31/08/2023 11:32, Huang Rui wrote: From: Antonio Caggiano Request Venus when initializing VirGL. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- v1->v2: - Rebase to latest version hw/display/virtio-gpu-virgl.c | 2 ++

Re: [Xen-devel] [PATCH] x86/HVM: adjust hvm_interrupt_blocked()

On Fri, Oct 12, 2018 at 09:58:46AM -0600, Jan Beulich wrote: > First of all, hvm_intsrc_mce was not considered here at all, yet nothing > blocks #MC (other than an already in-progress #MC, but dealing with this > is not the purpose of this patch). > > Additionally STI-shadow only blocks maskable i

Re: [QEMU PATCH v4 11/13] virtio-gpu: Support Venus capset

On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Add support for the Venus capset, which enables Vulkan support through the Venus Vulkan driver for virtio-gpu. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui --- hw/display/virtio-gpu-virgl.c | 21

Re: QEMU features useful for Xen development?

Peter Maydell writes: > On Thu, 31 Aug 2023 at 10:53, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini >> > wrote: >> >> As Xen is gaining R52 and R82 support, it would be great to be able to >> >> use QEMU for development and testin

Re: [Xen-devel] [PATCH] x86/HVM: adjust hvm_interrupt_blocked()

On Thu, Aug 31, 2023 at 12:42:58PM +0200, Roger Pau Monné wrote: > On Fri, Oct 12, 2018 at 09:58:46AM -0600, Jan Beulich wrote: > > First of all, hvm_intsrc_mce was not considered here at all, yet nothing > > blocks #MC (other than an already in-progress #MC, but dealing with this > > is not the pu

[PATCH v1 1/2] xen/arm: Add macro XEN_VM_MAPPING

Xen maps the virtual memory space starting from L0 slot 4, so it's open coded for macros with the offset '4'. For more readable, add a new macro XEN_VM_MAPPING which defines the start slot for Xen virtual memory mapping, and all virtual memory regions are defined based on it. Signed-off-by: Leo Y

[PATCH v1 0/2] xen/arm: Enlarge identity map space

The latest Xen fails to boot on ADLink AVA platform. Alexey Klimov root caused the issue is related with the commit 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable"). This is because on ADLink AVA platform, it loads Xen hypervisor to the address above 2TB and hence causes

[PATCH v1 2/2] xen/arm: Enlarge identity map space to 127TiB

On some platforms, the memory regions could be: (XEN) MODULE[0]: 0807f6df - 0807f6f3e000 Xen (XEN) MODULE[1]: 0807f8054000 - 0807f8056000 Device Tree (XEN) MODULE[2]: fa834000 - fc5de1d5 Ramdisk (XEN) MODULE[3]: fc5df000 - ffb3f810 Kernel

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

On 31.08.2023 12:08, Simone Ballarin wrote: > On 29/08/23 08:50, Jan Beulich wrote: >> On 28.08.2023 15:20, Simone Ballarin wrote: >>> Add inclusion guards to address violations of >>> MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order >>> to prevent the contents of a header file bei

Re: QEMU features useful for Xen development?

On Thu, 31 Aug 2023 at 11:49, Alex Bennée wrote: > Peter Maydell writes: > > All our MPS2/MPS3 boards are M-profile. That means we have the > > device models for all the interesting devices on the board, but > > it would be simpler to write the an536 board model separately. > > (In particular, th

Re: [RFC PATCH v4 5/6] xen/vpci: support ro mask

On 28.08.2023 19:56, Stewart Hildebrand wrote: > Add support for a read-only bit mask for vPCI register handlers. > > Signed-off-by: Stewart Hildebrand > --- > v3->v4: > * new patch > > RFC: It seemed like a low-hanging fruit to add support for ro mask. Let me > know > what you think, and

Re: [PATCH v4 6/6] xen/vpci: header: filter PCI capabilities

On 28.08.2023 19:56, Stewart Hildebrand wrote: > Currently, Xen vPCI only supports virtualizing the MSI and MSI-X capabilities. > Hide all other PCI capabilities (including extended capabilities) from domUs > for > now, even though there may be certain devices/drivers that depend on being > able

Re: [XEN PATCH 12/13] xen: address violations of MISRA C:2012 Directive 4.10

On 29/08/23 00:51, Stefano Stabellini wrote: On Mon, 28 Aug 2023, Simone Ballarin wrote: Move or amended inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the contents of a header file being included more than once"). Inclusio

Re: [XEN PATCH 12/13] xen: address violations of MISRA C:2012 Directive 4.10

On 31.08.2023 14:18, Simone Ballarin wrote: > On 29/08/23 00:51, Stefano Stabellini wrote: >> On Mon, 28 Aug 2023, Simone Ballarin wrote: >>> Move or amended inclusion guards to address violations of >>> MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order >>> to prevent the contents o

Re: [PATCH v7 9/9] swiotlb: search the software IO TLB only if the device makes use of it

On Wed, Aug 09, 2023 at 03:20:43PM -0600, Jonathan Corbet wrote: > > spin_unlock_irqrestore(&dev->dma_io_tlb_lock, flags); > > > > - /* Pairs with smp_rmb() in swiotlb_find_pool(). */ > > - smp_wmb(); > > found: > > + dev->dma_uses_io_tlb = true; > > + /* Pairs with smp_rmb() in is_s

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

On 31/08/23 13:10, Jan Beulich wrote: On 31.08.2023 12:08, Simone Ballarin wrote: On 29/08/23 08:50, Jan Beulich wrote: On 28.08.2023 15:20, Simone Ballarin wrote: Add inclusion guards to address violations of MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order to prevent the con

[PULL 04/41] bulk: Do not declare function prototypes using 'extern' keyword

By default, C function prototypes declared in headers are visible, so there is no need to declare them as 'extern' functions. Remove this redundancy in a single bulk commit; do not modify: - meson.build (used to check function availability at runtime) - pc-bios/ - libdecnumber/ - tests/

[PULL 31/41] hw/usb: spelling fixes

From: Michael Tokarev Signed-off-by: Michael Tokarev Message-ID: <20230823065335.1919380-14-...@tls.msk.ru> Signed-off-by: Philippe Mathieu-Daudé --- hw/usb/quirks.h | 2 +- hw/usb/ccid-card-emulated.c | 2 +- hw/usb/hcd-ehci.c | 6 +++--- hw/usb/hcd-ohci.c | 2

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

On 31.08.2023 14:54, Simone Ballarin wrote: > On 31/08/23 13:10, Jan Beulich wrote: >> On 31.08.2023 12:08, Simone Ballarin wrote: >>> The danger of multi-inclusion also exists for .c files, why do you want >>> to avoid guards for them? >> >> Counter question: Why only add guards to some of them? (

Re: [PATCH v3 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

On Thu, 2023-08-31 at 11:46 +0200, Jan Beulich wrote: > On 30.08.2023 18:57, Oleksii Kurochko wrote: > > asm/vm_event.h is common for ARM and RISC-V so it will be moved to > > asm-generic dir. > > > > Original asm/vm_event.h from ARM was updated: > >  * use SPDX-License-Identifier. > >  * update c

[PATCH 7/7] qobject atomics osdep: Make a few macros more hygienic

Variables declared in macros can shadow other variables. Much of the time, this is harmless, e.g.: #define _FDT(exp) \ do { \ int ret = (exp);

[PATCH 3/7] ui: Clean up local variable shadowing

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster --- ui/gtk.c |

[PATCH 2/7] migration: Clean up local variable shadowing

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster --- migration/block.c | 4

[PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error

qemu_rdma_save_page() reports polling error with error_report(), then succeeds anyway. This is because the variable holding the polling status *shadows* the variable the function returns. The latter remains zero. Broken since day one, and duplicated more recently. Fixes: 2da776db4846 (rdma: cor

[PATCH 5/7] block/vdi: Clean up local variable shadowing

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster --- block/vdi.c | 7 +++

[PATCH 4/7] block/dirty-bitmap: Clean up local variable shadowing

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster --- block/monitor/bitmap-qmp

[PATCH 6/7] block: Clean up local variable shadowing

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Tracked down with -Wshadow=local. Clean up: delete inner declarations when they are actually redundant, else rename variables. Signed-off-by: Markus Armbruster --- block.c |

[PATCH 0/7] Steps towards enabling -Wshadow=local

Local variables shadowing other local variables or parameters make the code needlessly hard to understand. Bugs love to hide in such code. Evidence: PATCH 1. Enabling -Wshadow would prevent bugs like this one. But we'd have to clean up all the offenders first. We got a lot of them. Enabling -W

Re: [XEN PATCH 09/13] xen/common: address violations of MISRA C:2012 Directive 4.10

On 31/08/23 15:05, Jan Beulich wrote: On 31.08.2023 14:54, Simone Ballarin wrote: On 31/08/23 13:10, Jan Beulich wrote: On 31.08.2023 12:08, Simone Ballarin wrote: The danger of multi-inclusion also exists for .c files, why do you want to avoid guards for them? Counter question: Why only add

Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error

On Thu, Aug 31, 2023 at 03:25:40PM +0200, Markus Armbruster wrote: > qemu_rdma_save_page() reports polling error with error_report(), then > succeeds anyway. This is because the variable holding the polling > status *shadows* the variable the function returns. The latter > remains zero. > > Brok

Re: [PATCH v3 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

On Thu, 2023-08-31 at 11:46 +0200, Jan Beulich wrote: > On 30.08.2023 18:57, Oleksii Kurochko wrote: > > asm/vm_event.h is common for ARM and RISC-V so it will be moved to > > asm-generic dir. > > > > Original asm/vm_event.h from ARM was updated: > >  * use SPDX-License-Identifier. > >  * update c

[linux-5.4 test] 182575: regressions - FAIL

flight 182575 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/182575/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail REGR. vs. 182363 test-armhf-armhf-xl-m

Re: [PATCH 7/7] qobject atomics osdep: Make a few macros more hygienic

On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote: [This paragraph written last: Bear with my stream of consciousness review below, where I end up duplicating some of the conslusions you reached before the point where I saw where the patch was headed] > Variables declared in macro

Re: [PATCH 3/7] ui: Clean up local variable shadowing

On Thu, 31 Aug 2023 at 14:25, Markus Armbruster wrote: > > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename variables

Re: [QEMU PATCH v4 12/13] virtio-gpu: Initialize Venus

On 8/31/23 13:40, Antonio Caggiano wrote: > Hi Huang, > > Thank you for pushing this forward! > > On 31/08/2023 11:32, Huang Rui wrote: >> From: Antonio Caggiano >> >> Request Venus when initializing VirGL. >> >> Signed-off-by: Antonio Caggiano >> Signed-off-by: Huang Rui >> --- >> >> v1->v2:

Re: [PATCH 7/7] qobject atomics osdep: Make a few macros more hygienic

On 8/31/23 06:25, Markus Armbruster wrote: +#define PASTE(a, b) a##b We already have glue() in qemu/compiler.h. The rest of it looks quite sensible. r~

[ovmf test] 182582: all pass - PUSHED

flight 182582 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182582/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4c8144dd665619731b6c3c19f4f1ae664b69fa4b baseline version: ovmf c5753c3e38f3fde23eec9

Re: [PATCH v3 2/2] xen: move arm/include/asm/vm_event.h to asm-generic

On 31.08.2023 16:02, Oleksii wrote: > On Thu, 2023-08-31 at 11:46 +0200, Jan Beulich wrote: >> On 30.08.2023 18:57, Oleksii Kurochko wrote: >>> --- >>>  xen/arch/arm/include/asm/vm_event.h    | 66 -- >>> >>>  xen/include/asm-generic/asm/vm_event.h | 55 +

Re: [PATCH v2 3/8] xen/ppc: Implement atomic.h

On 8/29/23 8:43 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/atomic.h >> @@ -0,0 +1,390 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +/* >> + * PowerPC64 atomic operations >> + * >> + * Copyright (C) 2001 Paul M

[linux-linus test] 182576: regressions - FAIL

flight 182576 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182576/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 182531 test-amd64-amd64-xl

Re: [PATCH v1 2/2] xen/arm: Enlarge identity map space to 127TiB

On Thu, 31 Aug 2023 at 12:01, Leo Yan wrote: > > On some platforms, the memory regions could be: > > (XEN) MODULE[0]: 0807f6df - 0807f6f3e000 Xen > (XEN) MODULE[1]: 0807f8054000 - 0807f8056000 Device Tree > (XEN) MODULE[2]: fa834000 - fc5de1d5 Ramdisk >

Re: [PATCH 6/7] block: Clean up local variable shadowing

On Thu, Aug 31, 2023 at 03:25:45PM +0200, Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

Re: [PATCH 5/7] block/vdi: Clean up local variable shadowing

On Thu, Aug 31, 2023 at 03:25:44PM +0200, Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

Re: [PATCH 4/7] block/dirty-bitmap: Clean up local variable shadowing

On Thu, Aug 31, 2023 at 03:25:43PM +0200, Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

Re: [PATCH v2 3/8] xen/ppc: Implement atomic.h

On 8/31/23 12:47 PM, Shawn Anastasio wrote: > On 8/29/23 8:43 AM, Jan Beulich wrote: >> On 23.08.2023 22:07, Shawn Anastasio wrote: >>> +#define read_atomic(p) >>> \ >>> +({

Xens handling of MCE

We have been trying to find documentation on how to tell Xen to forward MCE information to the linux kernel in Dom0 in order to let a system administrator be able to get notified when his system has bad memory. However from what I can tell this has not been documented anywhere. If anyone knows

[libvirt test] 182579: tolerable all pass - PUSHED

flight 182579 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182579/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182562 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH v2 4/8] xen/ppc: Implement bitops.h

On 8/29/23 8:59 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> Implement bitops.h, based on Linux's implementation as of commit >> 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc. Though it is based off of >> Linux's implementation, this code diverges significantly in a number of

Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error

On Thu, Aug 31, 2023 at 03:25:40PM +0200, Markus Armbruster wrote: > qemu_rdma_save_page() reports polling error with error_report(), then > succeeds anyway. This is because the variable holding the polling > status *shadows* the variable the function returns. The latter > remains zero. > > Brok

Re: [PATCH 2/7] migration: Clean up local variable shadowing

On Thu, Aug 31, 2023 at 03:25:41PM +0200, Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=local. > Clean up: delete inner declarations when they are actually redundant, > else rename

RE: [EXT] Re: xen arm64 low power sleep support

On Thu, 30 Aug 2023, Stefano Stabellini wrote: > On Wed, 30 Aug 2023, Anthony Chan wrote: > > On Tue, 29 Aug 2023, Stefano Stabellini wrote: > > > On Tue, 29 Aug 2023, Anthony Chan wrote: > > > > Hi all, > > > > > > > > My name is Tony and I've been researching/developing using Xen > > > > for pote

Re: [PATCH v9 12/16] vpci: add initial support for virtual PCI bus topology

Hi Jan, Jan Beulich writes: > On 30.08.2023 01:19, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko >> >> Assign SBDF to the PCI devices being passed through with bus 0. >> The resulting topology is where PCIe devices reside on the bus 0 of the >> root complex itself (embedded endpo

Re: [PATCH v4 4/6] xen/vpci: header: status register handler

On 8/30/23 10:05, Jan Beulich wrote: > On 28.08.2023 19:56, Stewart Hildebrand wrote: >> --- a/xen/drivers/vpci/header.c >> +++ b/xen/drivers/vpci/header.c >> @@ -413,6 +413,18 @@ static void cf_check cmd_write( >> pci_conf_write16(pdev->sbdf, reg, cmd); >> } >> >> +static uint32_t cf_che

[ovmf test] 182586: all pass - PUSHED

flight 182586 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182586/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf beafabdae49c873adecdb7511dbebe9d4ff5c8f0 baseline version: ovmf 4c8144dd665619731b6c3

Re: [PATCH v2 5/8] xen/ppc: Define minimal stub headers required for full build

On 8/30/23 5:49 AM, Jan Beulich wrote: > On 23.08.2023 22:07, Shawn Anastasio wrote: >> --- /dev/null >> +++ b/xen/arch/ppc/include/asm/altp2m.h >> @@ -0,0 +1,25 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +#ifndef __ASM_PPC_ALTP2M_H__ >> +#define __ASM_PPC_ALTP2M_H__ >> + >> +#include >

[qemu-mainline test] 182584: regressions - FAIL

flight 182584 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182584/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 182570 Tests which did n

Re: [XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device()

On Thu, Aug 31, 2023 at 09:32:48AM +0200, Michal Orzel wrote: > > > On 31/08/2023 09:23, Michal Orzel wrote: > > > > > > On 30/08/2023 19:48, Vikram Garhwal wrote: > >> Hi Michal, > >> On Tue, Aug 29, 2023 at 10:23:30AM +0200, Michal Orzel wrote: > >>> > >>> > >>> On 25/08/2023 10:02, Vikram Ga

[xen-unstable test] 182581: regressions - FAIL

flight 182581 xen-unstable real [real] flight 182587 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182581/ http://logs.test-lab.xenproject.org/osstest/logs/182587/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH v4 6/6] xen/vpci: header: filter PCI capabilities

On 8/31/23 08:11, Jan Beulich wrote: > On 28.08.2023 19:56, Stewart Hildebrand wrote: >> Currently, Xen vPCI only supports virtualizing the MSI and MSI-X >> capabilities. >> Hide all other PCI capabilities (including extended capabilities) from domUs >> for >> now, even though there may be certai

[PATCH v5 0/5] vPCI capabilities filtering

This small series enables vPCI to filter which PCI capabilities we expose to a domU. This series adds vPCI register handlers within xen/drivers/vpci/header.c:init_bars(), along with some supporting functions. Note there are minor rebase conflicts with the in-progress vPCI series [1]. These conflic

[PATCH v5 1/5] xen/pci: convert pci_find_*cap* to pci_sbdf_t

Convert pci_find_*cap* functions and call sites to pci_sbdf_t, and remove some now unused local variables. Also change to more appropriate types on lines that are already being modified as a result of the pci_sbdf_t conversion. Signed-off-by: Stewart Hildebrand Reviewed-by: Jan Beulich --- I bui

[PATCH v5 2/5] x86/msi: rearrange read_pci_mem_bar slightly

Use pdev->sbdf instead of the PCI_SBDF macro in calls to pci_* functions where appropriate. Move NULL check earlier. Suggested-by: Jan Beulich Signed-off-by: Stewart Hildebrand Reviewed-by: Jan Beulich --- v4->v5: * add Jan's R-b v3->v4: * new patch Suggested-by tag added based on conversatio

  1   2   >