Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

On 02/08/2023 19:39, Julien Grall wrote: > > > Hi Luca, > > On 02/08/2023 16:05, Luca Fancellu wrote: >>> On 2 Aug 2023, at 15:48, Michal Orzel wrote: >>> >>> Hi, >>> >>> On 02/08/2023 16:42, Luca Fancellu wrote: > On 2 Aug 2023, at 15:26, Michal Orzel wrote: > > Hi Lu

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Hi, On 03/08/2023 08:15, Michal Orzel wrote: On 02/08/2023 19:39, Julien Grall wrote: Hi Luca, On 02/08/2023 16:05, Luca Fancellu wrote: On 2 Aug 2023, at 15:48, Michal Orzel wrote: Hi, On 02/08/2023 16:42, Luca Fancellu wrote: On 2 Aug 2023, at 15:26, Michal Orzel wrote: Hi Luca,

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

>> >> - UART enabled - >> - Boot CPU booting - >> - Current EL 0008 - >> - Initialize CPU - >> - Turning on paging - >> - Zero BSS - >> - Ready - >> (XEN) Checking for initrd in /chosen >> (XEN) RAM: 8000 - feff >> (X

Re: [XEN PATCH 1/4] x86/mce: address MISRA C:2012 Rule 5.3

On 03/08/2023 03:45, Stefano Stabellini wrote: On Wed, 2 Aug 2023, Nicola Vetrini wrote: Suitable mechanical renames are made to avoid shadowing, thus addressing violations of MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

On 03/08/2023 09:35, Julien Grall wrote: > > > Hi, > > On 03/08/2023 08:15, Michal Orzel wrote: >> On 02/08/2023 19:39, Julien Grall wrote: >>> >>> >>> Hi Luca, >>> >>> On 02/08/2023 16:05, Luca Fancellu wrote: > On 2 Aug 2023, at 15:48, Michal Orzel wrote: > > Hi, > > On

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Hi Michal, On 03/08/2023 09:07, Michal Orzel wrote: On 03/08/2023 09:35, Julien Grall wrote: On 03/08/2023 08:15, Michal Orzel wrote: On 02/08/2023 19:39, Julien Grall wrote: Hi Luca, On 02/08/2023 16:05, Luca Fancellu wrote: On 2 Aug 2023, at 15:48, Michal Orzel wrote: Hi, On 02/08/20

Re: [XEN PATCH 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3

On 03/08/2023 03:51, Stefano Stabellini wrote: On Wed, 2 Aug 2023, Nicola Vetrini wrote: Rename variables to avoid shadowing and thus address MISRA C:2012 Rule 5.3: "An identifier declared in an inner scope shall not hide an identifier declared in an outer scope" No functional changes. Signed-

[XEN PATCH v2] xen/string: add missing parameter names

Add missing parameter names to address violation of MISRA C:2012 rule 8.2 ("Function types shall be in prototype form with named parameters"). No functional changes. Signed-off-by: Federico Serafini --- Changes in v2: - memset() adjusted. --- xen/include/xen/string.h | 42

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

On 03/08/2023 09:04, Luca Fancellu wrote: There are so many things that can go wrong during early boot including the entire boofdt parsing and having earlycon would be so desirable. It is not clear what to take from your reply. Earlier you were concerned about the error not showing up in th

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

On 02.08.2023 17:33, Elliott Mitchell wrote: > Is there a freeze on that I'm unaware of? Is there so much traffic from > other developers that smaller output ones are being missed? I'm > wondering about the initial revision of this series not getting any > feedback: > https://lists.xenproject.org

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

> On 3 Aug 2023, at 09:29, Julien Grall wrote: > > > > On 03/08/2023 09:04, Luca Fancellu wrote: There are so many things that can go wrong during early boot including the entire boofdt parsing and having earlycon would be so desirable. >>> It is not clear what to take from yo

Re: [XEN PATCH 2/4] x86/mtrr: address MISRA C:2012 Rule 5.3

On 03.08.2023 03:51, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> --- a/xen/arch/x86/hvm/mtrr.c >> +++ b/xen/arch/x86/hvm/mtrr.c >> @@ -687,13 +687,13 @@ int hvm_set_mem_pinned_cacheattr(struct domain *d, >> uint64_t gfn_start, >> >> static int cf_check hvm_save_mtrr

Re: [XEN PATCH 3/4] x86/irq: rename variable to address MISRA C:2012 Rule 5.3

On 03.08.2023 04:00, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> The extern variable 'irq_desc' defined in 'irq.h' is shadowed by >> local variables in the changed file. To avoid this, the variable is >> renamed to 'irq_description'. >> >> No functional change. >> >> Si

Re: [PATCH] xen/x86: Constify the vCPU parameter for expand_xsave_states()

On 02.08.2023 17:47, Julien Grall wrote: > From: Julien Grall > > expand_xsave_states() is not meant to modify the vCPU. So the parameter > can be const. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich

Re: [XEN PATCH 01/11] x86/efi: move variable declaration to address MISRA C:2012 Rule 2.1

On 03.08.2023 04:08, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> The variable declaration is moved where it's actually used, rather >> than being declared in the switch before any clause, thus being >> classified as unreachable code. >> >> No functional changes. >> >> S

Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1

On 03.08.2023 04:13, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) >> >> switch ( action->ack_type ) >> { >> -cpumask_t *cpu_eoi_map; > > It is only used by case ACKTYPE_EOI

Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1

On 02.08.2023 16:38, Nicola Vetrini wrote: > Variable declarations between a switch statement guard and before > any case label are unreachable code, and hence violate Rule 2.1: > "A project shall not contain unreachable code". > > Therefore the declarations are moved in the smallest enclosing > s

Re: [XEN PATCH 04/11] x86emul: move variable definitions to address MISRA C:2012 Rule 2.1

On 03.08.2023 04:33, Stefano Stabellini wrote: > On Wed, 2 Aug 2023, Nicola Vetrini wrote: >> @@ -2289,16 +2289,15 @@ static int cf_check hvmemul_cache_op( >> struct hvm_emulate_ctxt *hvmemul_ctxt = >> container_of(ctxt, struct hvm_emulate_ctxt, ctxt); >> uint32_t pfec = PFEC_pag

Re: [XEN PATCH 07/11] xen: address MISRA C:2012 Rule 2.1

On 02.08.2023 16:38, Nicola Vetrini wrote: > Rule 2.1 states: "A project shall not contain unreachable code". > > The functions > - machine_halt > - maybe_reboot > - machine_restart > are not supposed to return, hence the following break statement > is marked as intentionally unreachable with the

Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1

On 02.08.2023 16:38, Nicola Vetrini wrote: > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -2233,6 +2233,7 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) > /* fallthrough */ > case TASKLET_enqueued|TASKLET_scheduled: > return true; > +AS

Address MISRA C:2012 Rule 8.4

The headline of Rule 8.4 is as follows: "A compatible declaration shall be visible when an object or function with external linkage is defined". Some functions reported in [1][2] are lacking a declaration in the respective header files; as remarked on xen-devel's IRC channel, this is ok since th

Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

On 02.08.2023 16:38, Nicola Vetrini wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > return subarch_memory_op(cmd, arg); > } > > +ASSERT_UNREACHABLE(); > return 0

Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

On 03/08/2023 11:20, Jan Beulich wrote: On 02.08.2023 16:38, Nicola Vetrini wrote: --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4879,6 +4879,7 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) return subarch_memory_op(cmd, arg); } +ASSERT_UNR

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Hi, On 03/08/2023 09:39, Luca Fancellu wrote: I would like to ask if you see this one going forwards or not (as it is), because I have a set of patches to isolate and Kconfig-out the dom0less code, that is depending on this one (for a small bit) and before sending them I need to understand if

[xen-4.15-testing test] 182106: tolerable FAIL - PUSHED

flight 182106 xen-4.15-testing real [real] flight 182162 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182106/ http://logs.test-lab.xenproject.org/osstest/logs/182162/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

Re: [PATCH v3 2/2] tools/xenstore: fix get_spec_node()

On 27.07.2023 09:55, Juergen Gross wrote: > On 27.07.23 09:53, Jan Beulich wrote: >> On 24.07.2023 12:33, Juergen Gross wrote: >>> In case get_spec_node() is being called for a special node starting >>> with '@' it won't set *canonical_name. This can result in a crash of >>> xenstored due to derefe

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Hi, On 02/08/2023 14:53, Luca Fancellu wrote: Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that depends on GICV2 or GICV3 and compiles the GICv2 emulation for guests, it is required only when using GIC

Re: [PATCH] xenctrl_stubs.c: fix NULL dereference

On 13.07.2023 10:30, Edwin Török wrote: > --- a/tools/ocaml/libs/xc/xenctrl_stubs.c > +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c > @@ -832,7 +832,7 @@ CAMLprim value physinfo_arch_caps(const xc_physinfo_t > *info) > > tag = 1; /* tag x86 */ > > - arch_obj = Tag_cons; > + arch_obj

Re: [PATCH v3 2/2] tools/xenstore: fix get_spec_node()

On 03.08.23 11:53, Jan Beulich wrote: On 27.07.2023 09:55, Juergen Gross wrote: On 27.07.23 09:53, Jan Beulich wrote: On 24.07.2023 12:33, Juergen Gross wrote: In case get_spec_node() is being called for a special node starting with '@' it won't set *canonical_name. This can result in a crash

[XEN PATCH 00/13] xen: address violations of MISRA C:2012 Rule 7.3

This series aims to address some violations ofMISRA C:2012 Rule 7.3: "The lowercase character 'l' shall not be used in a literal suffix". This patch replaces "l" suffixes with "L", to comply with the rule. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. Gianluca L

[XEN PATCH 01/13] AMD/IOMMU: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 04/13] x86/IOMMU: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 02/13] x86/svm: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 05/13] xen/ioreq: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 07/13] xen/vpci: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 08/13] xen/hvm: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 09/13] x86/mm: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 10/13] x86/viridian: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 11/13] xen/x86: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 12/13] xen/common: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

[XEN PATCH 13/13] xen: address violations of MISRA C:2012 Rule 7.3

From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the

Re: [XEN PATCH v2] xen/string: add missing parameter names

> On 3 Aug 2023, at 09:26, Federico Serafini > wrote: > > Add missing parameter names to address violation of MISRA C:2012 > rule 8.2 ("Function types shall be in prototype form with named > parameters"). > > No functional changes. > > Signed-off-by: Federico Serafini > --- > Changes in v2

[PATCH v2 0/2] Rebranding dom0less to hyperlaunch part 1

This is the first series of the proposal put forth on moving to have dom0less folded under and thus rebranded as a part of hyperlaunch. As laid out in the proposal, the series updates the hyperlaunch device tree documentation and applies the general refactoring of FDT parsing to make core logic com

[PATCH v2 1/2] docs: update hyperlaunch device tree

With on going development of hyperlaunch, changes to the device tree definitions has been necessary. This commit updates the specification for all current changes along with changes expected to be made in finalizing the capability. This commit also adds a HYPERLAUNCH section to the MAINTAINERS fi

[PATCH v2 2/2] fdt: make fdt handling reusable across arch

This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch. Signed-off-by: Daniel P. Smith --- MAINTAINERS

Re: [PATCH v2 1/2] docs: update hyperlaunch device tree

Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: > > > With on going development of hyperlaunch, changes to the device tree > definitions > has been necessary. This commit updates the specification for all current > changes > along with changes expected to be made in finalizing the capab

Re: [XEN PATCH v2] xen/string: add missing parameter names

Hi Luca, On 03/08/2023 11:28, Luca Fancellu wrote: On 3 Aug 2023, at 09:26, Federico Serafini wrote: Add missing parameter names to address violation of MISRA C:2012 rule 8.2 ("Function types shall be in prototype form with named parameters"). No functional changes. Signed-off-by: Federico

Ping: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}()

On 27.07.2023 20:41, Stefano Stabellini wrote: > On Thu, 27 Jul 2023, Jan Beulich wrote: >> In the latter case the variable altogether is then unused and hence gets >> dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly >> introduced both assignments in 57a57465daaf ("x86/HVM:

Re: [XEN PATCH v2] xen/string: add missing parameter names

> On 3 Aug 2023, at 12:46, Julien Grall wrote: > > Hi Luca, > > On 03/08/2023 11:28, Luca Fancellu wrote: >>> On 3 Aug 2023, at 09:26, Federico Serafini >>> wrote: >>> >>> Add missing parameter names to address violation of MISRA C:2012 >>> rule 8.2 ("Function types shall be in prototype fo

Re: [XEN PATCH v2] xen/string: add missing parameter names

On 03/08/2023 12:52 pm, Luca Fancellu wrote: > >> On 3 Aug 2023, at 12:46, Julien Grall wrote: >> >> Hi Luca, >> >> On 03/08/2023 11:28, Luca Fancellu wrote: On 3 Aug 2023, at 09:26, Federico Serafini wrote: Add missing parameter names to address violation of MISRA C:2012 >>>

Re: [XEN PATCH v2] xen/string: add missing parameter names

Hi, On 03/08/2023 12:52, Luca Fancellu wrote: On 3 Aug 2023, at 12:46, Julien Grall wrote: Hi Luca, On 03/08/2023 11:28, Luca Fancellu wrote: On 3 Aug 2023, at 09:26, Federico Serafini wrote: Add missing parameter names to address violation of MISRA C:2012 rule 8.2 ("Function types shall

[PATCH v7 1/6] xen/riscv: introduce temporary printk stuff

The patch introdcuces printk related stuff which should be deleted after Xen common code will be available. Signed-off-by: Oleksii Kurochko --- Changes in V7: - only rebase was done. --- Changes in V6: - the patch was introduced in the current patch series (V6) --- xen/arch/riscv/early_printk.

[PATCH v7 2/6] xen/riscv: introduce dummy

will be used in the patch "xen/riscv: introduce decode_cause() stuff" and requires Signed-off-by: Oleksii Kurochko --- Changes in V7: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed. Only rebase. --- Changes in V5: * the patch was introduced in the current patch series (

[PATCH v7 0/6] RISCV basic exception handling implementation

The patch series is based on: xen/riscv: introduce identity mapping [1] which haven't been merged yet. The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi" instructio

[PATCH v7 3/6] xen/riscv: introduce decode_cause() stuff

The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko --- Changes in V7: - Nothing changed. Only rebase. --- Changes in V6: - Remove usage of LINK_TO_LOAD() due to the MMU being enabled first. - Change early_printk() to printk() --- Changes in V5

[PATCH v7 6/6] xen/riscv: test basic handling stuff

Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V6: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed --- Changes in V5: - Nothing changed --- Changes in V4: - Add Acked-by: Alistair Francis --- Changes in V3: - Nothing changed --- Changes i

[PATCH v7 5/6] xen/riscv: introduce an implementation of macros from

The patch introduces macros: BUG(), WARN(), run_in_exception(), assert_failed. To be precise, the macros from generic bug implementation () will be used. The implementation uses "ebreak" instruction in combination with diffrent bug frame tables (for each type) which contains useful information. S

[PATCH v7 4/6] xen/riscv: introduce trap_init()

Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V7: - #define cast_to_bug_frame(addr) ((const struct bug_frame *)(addr)). - remove unnecessary comments in trap_init() function. --- Changes in V6: - trap_init() is now called after enabling the MMU. - Add additional

Re: [PATCH v2 1/2] docs: update hyperlaunch device tree

On 03.08.2023 12:44, Daniel P. Smith wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -332,6 +332,15 @@ M: Nick Rosbrook > S: Maintained > F: tools/golang > > +HYPERLAUNCH > +M: Daniel P. Smith > +M: Christopher Clark > +W: https://wiki.xenproject.org/wiki/Hyperlaunch > +S

Re: [PATCH v2 2/2] fdt: make fdt handling reusable across arch

Hi Daniel, On 03/08/2023 12:44, Daniel P. Smith wrote: > > > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is IIUC, you just try to untangle the code for fdt from dt (unflattened). CORE_DEVICE_TRE

Re: [PATCH] xenctrl_stubs.c: fix NULL dereference

On 03/08/2023 11:15 am, Jan Beulich wrote: > On 13.07.2023 10:30, Edwin Török wrote: >> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c >> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c >> @@ -832,7 +832,7 @@ CAMLprim value physinfo_arch_caps(const xc_physinfo_t >> *info) >> >> tag = 1; /* tag x86 */

Re: [PATCH] console: generalize the ability for domU access

On 8/2/23 07:01, Jan Beulich wrote: On 01.08.2023 18:06, Daniel P. Smith wrote: This patch reworks the console rotation logic to provide a general mechanism to incorporate domU in to the rotation. It does so by walking the domain list using the XSM console privlege check to determine if the doma

[xen-4.16-testing test] 182107: tolerable FAIL - PUSHED

flight 182107 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/182107/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182094 test-amd64-amd64-xl-qemut-win7-a

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Hi Julien, >> + >> config GICV3 >> bool "GICv3 driver" >> depends on !NEW_VGIC >> @@ -92,6 +100,11 @@ config HAS_ITS >> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED >> depends on GICV3 && !NEW_VGIC && !ARM_32 >> +config VGICV2 >> + bool "vGICv2 inter

Re: [PATCH] console: generalize the ability for domU access

On 8/2/23 19:58, Stefano Stabellini wrote: On Wed, 2 Aug 2023, Jan Beulich wrote: -for ( ; ; ) +if ( d == NULL ) This covers both Xen receiving input and the domain receiving input having gone away. Originally in the latter case the next sequential (in domid numbering) domain would

Re: [PATCH 2/2] fdt: make fdt handling reusable across arch

On 8/2/23 21:40, Henry Wang wrote: Hi Daniel, -Original Message- Subject: Re: [PATCH 2/2] fdt: make fdt handling reusable across arch make: *** [Makefile:183: __sub-make] Error 2 make: Leaving directory '/jenkins/workspace/ais-xenbits- xen/layers/xen/xen' The staging itself passe

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

> On 3 Aug 2023, at 14:03, Luca Fancellu wrote: > > Hi Julien, > >>> + >>> config GICV3 >>> bool "GICv3 driver" >>> depends on !NEW_VGIC >>> @@ -92,6 +100,11 @@ config HAS_ITS >>> bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED >>> depends on GICV3 && !NE

Re: [RFC 1/6] dom0: replace explict zero checks

On 8/1/23 20:24, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: A legacy concept is that the initial domain will have a domain id of zero. As a result there are places where a check that a domain is the inital domain is determined by an explicit check that the domid is zero

Re: [RFC 1/6] dom0: replace explict zero checks

On 8/2/23 03:46, Jan Beulich wrote: On 01.08.2023 22:20, Daniel P. Smith wrote: A legacy concept is that the initial domain will have a domain id of zero. As a result there are places where a check that a domain is the inital domain is determined by an explicit check that the domid is zero. It

Re: [RFC 1/6] dom0: replace explict zero checks

Hi Daniel, On 03/08/2023 14:33, Daniel P. Smith wrote: On 8/2/23 03:46, Jan Beulich wrote: On 01.08.2023 22:20, Daniel P. Smith wrote: A legacy concept is that the initial domain will have a domain id of zero. As a result there are places where a check that a domain is the inital domain is d

Re: [XEN PATCH 03/13] xen/arm: address violations of MISRA C:2012 Rule 7.3

> On 3 Aug 2023, at 11:22, Simone Ballarin wrote: > > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suffix, to

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

On 03/08/2023 14:03, Luca Fancellu wrote: Hi Julien, Hi, + config GICV3 bool "GICv3 driver" depends on !NEW_VGIC @@ -92,6 +100,11 @@ config HAS_ITS bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED depends on GICV3 && !NEW_VGIC && !ARM_32 +conf

Re: [RFC 2/6] roles: provide abstraction for the possible domain roles

On 8/1/23 20:54, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: The existing concepts such as unbounded domain, ie. all powerful, control domain and hardware domain are, effectively, roles the domains provide for the system. Currently, these are represented with booleans wi

Re: [RFC 2/6] roles: provide abstraction for the possible domain roles

On 8/2/23 03:51, Jan Beulich wrote: On 01.08.2023 22:20, Daniel P. Smith wrote: --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -340,6 +340,14 @@ static int late_hwdom_init(struct domain *d) setup_io_bitmap(dom0); #endif +/* + * "dom0" may have been created under the u

Re: [RFC 3/6] roles: add a role for xenstore domain

On 8/1/23 20:57, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: Expand the possible roles for a domain to include a role for the Xenstore domain. Signed-off-by: Daniel P. Smith Reviewed-by: Stefano Stabellini Thank you! --- xen/common/domain.c | 3 +++ xen/i

[PATCH 0/2] libxl: build fixes for recent CPUID work

1: avoid shadowing of index() 2: allow building with old gcc again Jan

[PATCH 1/2] libxl: avoid shadowing of index()

Because of -Wshadow the build otherwise fails with old enough glibc. While there also obey line length limits for msr_add(). Fixes: 6d21cedbaa34 ("libxl: add support for parsing MSR features") Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @

[PATCH 2/2] libxl: allow building with old gcc again

We can't use initializers of unnamed struct/union members just yet. Fixes: d638fe233cb3 ("libxl: use the cpuid feature names from cpufeatureset.h") Signed-off-by: Jan Beulich --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -316,12 +316,16 @@ int libxl_cpuid_parse_con

Re: [PATCH] libxenstat/Linux: pass nul-terminated string to strpbrk()

On 26.07.23 12:42, Jan Beulich wrote: While what "tmp" points to has been cleared at the end of the first iteration of parseNetDevLine()'s main loop, this is too late for the first iteration's invocation of strpbrk() (copying the interface name). Properly nul-terminate the string at population ti

Re: [XEN PATCH 02/11] x86: move declarations to address MISRA C:2012 Rule 2.1

On 03/08/2023 11:01, Jan Beulich wrote: On 03.08.2023 04:13, Stefano Stabellini wrote: On Wed, 2 Aug 2023, Nicola Vetrini wrote: @@ -1169,8 +1170,6 @@ static void cf_check irq_guest_eoi_timer_fn(void *data) switch ( action->ack_type ) { -cpumask_t *cpu_eoi_map; It is only

Re: [PATCH 0/2] libxl: build fixes for recent CPUID work

On 03.08.23 16:13, Jan Beulich wrote: 1: avoid shadowing of index() 2: allow building with old gcc again Jan For the series: Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

[PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional

Introduce Kconfig GICV2 to be able to compile the GICv2 driver only when needed, the option is active by default. Introduce Kconfig VGICV2 that compiles the Generic Interrupt Controller v2 emulation for domains, it is required only when using GICv2 driver, otherwise using the GICv3 driver it is op

[ovmf test] 182163: all pass - PUSHED

flight 182163 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182163/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7672d1cca58228b0cb7f099e8863aa3a44ae45db baseline version: ovmf fa789cc68a85a5781c18c

Call for agenda items for 03/08/23 Community Call @ 1500 UTC

Hi all, The proposed agenda is in this link and you can edit to add items. Alternatively, you can reply to this mail directly. Agenda items appreciated a few days before the call: please put your name besides items if you edit the d

Re: Call for agenda items for 03/08/23 Community Call @ 1500 UTC

On 03.08.2023 16:48, Kelly Choi wrote: > The proposed agenda is in this link > and you can > edit to add items. Alternatively, you can reply to this mail directly. Just to mention it: George has previously pointed at https://cryptpa

Re: [PATCH 0/2] libxl: build fixes for recent CPUID work

On 03/08/2023 3:32 pm, Juergen Gross wrote: > On 03.08.23 16:13, Jan Beulich wrote: >> 1: avoid shadowing of index() >> 2: allow building with old gcc again >> >> Jan > > For the series: > > Reviewed-by: Juergen Gross Acked-by: Andrew Cooper

Re: [RFC 4/6] capabilities: introduce console io as a domain capability

On 8/1/23 21:01, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: The field `is_console` suggests that the field represents a state of being or posession, not that it reflects the privilege to access the console. In this ^ possession Thank you for the catch. patch the

Re: [XEN PATCH 11/11] x86/mm: Add assertion to address MISRA C:2012 Rule 2.1

On 03.08.2023 11:30, Nicola Vetrini wrote: > On 03/08/2023 11:20, Jan Beulich wrote: >> On 02.08.2023 16:38, Nicola Vetrini wrote: >>> --- a/xen/arch/x86/mm/p2m-pod.c >>> +++ b/xen/arch/x86/mm/p2m-pod.c >>> @@ -1045,6 +1045,7 @@ p2m_pod_zero_check(struct p2m_domain *p2m, const >>> gfn_t *gfns, uns

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

On 8/1/23 21:06, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: Expresses the ability to attach a debugger as a capability that a domain can be provisioned. Signed-off-by: Daniel P. Smith --- xen/arch/x86/hvm/svm/svm.c | 8 xen/arch/x86/hvm/vmx/realmode.

Re: [PATCH] console: generalize the ability for domU access

On 03.08.2023 14:56, Daniel P. Smith wrote: > On 8/2/23 07:01, Jan Beulich wrote: >> On 01.08.2023 18:06, Daniel P. Smith wrote: >>> +if ( hardware_domain ) >>> +{ >>> +console_rx = hardware_domain->domain_id + 1; >>> +printk("*** Serial input to DOM%d", CON_

Re: [RFC 1/6] dom0: replace explict zero checks

On 8/3/23 09:36, Julien Grall wrote: Hi Daniel, Hey Julien, On 03/08/2023 14:33, Daniel P. Smith wrote: On 8/2/23 03:46, Jan Beulich wrote: On 01.08.2023 22:20, Daniel P. Smith wrote: A legacy concept is that the initial domain will have a domain id of zero. As a result there are places wh

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

On 03.08.2023 17:52, Daniel P. Smith wrote: > On 8/1/23 21:06, Stefano Stabellini wrote: >> On Tue, 1 Aug 2023, Daniel P. Smith wrote: >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -474,9 +474,8 @@ struct domain >>> uint8_t role; >>> #define CAP_CONSOLE

Re: [RFC 6/6] capabilities: convert attach debugger into a capability

On 8/3/23 11:59, Jan Beulich wrote: On 03.08.2023 17:52, Daniel P. Smith wrote: On 8/1/23 21:06, Stefano Stabellini wrote: On Tue, 1 Aug 2023, Daniel P. Smith wrote: --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -474,9 +474,8 @@ struct domain uint8_t role; #

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: > > Some of the patches looks to have been posted previously as a 7-patch > series. It would have been nice if therefore this one was marked as > v2, indicating in a revision log what the differences are. It appears > as if at least one

Re: [PATCH] console: generalize the ability for domU access

On 8/3/23 11:56, Jan Beulich wrote: On 03.08.2023 14:56, Daniel P. Smith wrote: On 8/2/23 07:01, Jan Beulich wrote: On 01.08.2023 18:06, Daniel P. Smith wrote: +if ( hardware_domain ) +{ +console_rx = hardware_domain->domain_id + 1; +printk("*** Serial i

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

Hi Elliott, On 03/08/2023 17:13, Elliott Mitchell wrote: On Thu, Aug 03, 2023 at 10:35:53AM +0200, Jan Beulich wrote: Some of the patches looks to have been posted previously as a 7-patch series. It would have been nice if therefore this one was marked as v2, indicating in a revision log what

Re: Ping: [PATCH] x86/HVM: drop dead assignments from hvmemul_rep_{movs,stos}()

On 03/08/2023 12:46, Jan Beulich wrote: On 27.07.2023 20:41, Stefano Stabellini wrote: On Thu, 27 Jul 2023, Jan Beulich wrote: In the latter case the variable altogether is then unused and hence gets dropped, eliminating a Misra Rule 5.3 violation. I'm afraid I mistakenly introduced both assign

Re: [PATCH] xen/x86: Constify the vCPU parameter for expand_xsave_states()

Hi Jan, On 03/08/2023 09:53, Jan Beulich wrote: On 02.08.2023 17:47, Julien Grall wrote: From: Julien Grall expand_xsave_states() is not meant to modify the vCPU. So the parameter can be const. Signed-off-by: Julien Grall Acked-by: Jan Beulich Thanks. I have committed the patch. Cheer

  1   2   >