[PATCH v2 00/18] tools/xenstore: drop TDB

2023-07-10 Thread Juergen Gross
Using TDB for storing the Xenstore nodes is adding more complexity instead of removing it. With keeping the data in memory only, the main reason for using TDB has disappeared. This series is replacing TDB with a hashlist referencing directly individually allocated Xenstore nodes. This in turn all

[PATCH v2 01/18] tools/xenstore: explicitly specify create or modify for tdb_store()

2023-07-10 Thread Juergen Gross
Instead of using TDB_REPLACE for either creating or modifying a TDB entry, use either TDB_INSERT or TDB_MODIFY when calling tdb_store(). At higher function levels use the abstract flag values NODE_CREATE and NODE_MODIFY. This is for preparing to get rid of TDB, even if it is beneficial while usin

[PATCH v2 02/18] tools/xenstore: replace key in struct node with data base name

2023-07-10 Thread Juergen Gross
Instead of storing the TDB key in struct node, only store the name of the node used to access it in the data base. Associated with that change replace the key parameter of access_node() with the equivalent db_name. This is in preparation to replace TDB with a more simple data storage. Signed-off

[PATCH v2 03/18] tools/xenstore: let transaction_prepend() return the name for access

2023-07-10 Thread Juergen Gross
Instead of setting the TDB key for accessing the node in the data base, let transaction_prepend() return the associated name instead. This is in preparation to replace TDB with a more simple data storage. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/xenstored_core.

[PATCH v2 04/18] tools/xenstore: rename do_tdb_delete() and change parameter type

2023-07-10 Thread Juergen Gross
Rename do_tdb_delete() to db_delete() and replace the key parameter with db_name specifying the name of the node in the data base. This is in preparation to replace TDB with a more simple data storage. Signed-off-by: Juergen Gross --- V2: - remove unrelated change (Julien Grall) --- tools/xenst

[PATCH v2 05/18] tools/xenstore: rename do_tdb_write() and change parameter type

2023-07-10 Thread Juergen Gross
Rename do_tdb_write() to db_write() and replace the key parameter with db_name specifying the name of the node in the data base, and the data parameter with a data pointer and a length. Do the same key parameter type change for write_node_raw(), too. This is in preparation to replace TDB with a m

[PATCH v2 07/18] tools/xenstore: add wrapper for tdb_fetch()

2023-07-10 Thread Juergen Gross
Add a wrapper function for tdb_fetch taking the name of the node in the data base as a parameter. Let it return a data pointer and the length of the data via a length pointer provided as additional parameter. Move logging of the TDB access from the callers into the wrapper. This enables to make s

[PATCH v2 06/18] tools/xenstore: switch get_acc_data() to use name instead of key

2023-07-10 Thread Juergen Gross
Eliminate further TDB_DATA usage by switching get_acc_data() and get_acc_domid() from a TDB key to the name of the node in the data base as a parameter. This is in preparation to replace TDB with a more simple data storage. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenst

[PATCH v2 08/18] tools/xenstore: make hashtable key and value parameters const

2023-07-10 Thread Juergen Gross
The key is never modified by hashtable code, so it should be marked as const. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/hashtable.c | 5 +++-- tools/xenstore/hashtable.h | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/xenstore/hasht

Re: [PATCH v2 1/2] x86/mm: add API for marking only part of a MMIO page read only

2023-07-10 Thread Jan Beulich
On 07.07.2023 13:02, Marek Marczykowski-Górecki wrote: > On Wed, Jul 05, 2023 at 10:23:53AM +0200, Jan Beulich wrote: >> On 01.07.2023 00:28, Marek Marczykowski-Górecki wrote: >>> On Tue, May 30, 2023 at 01:56:34PM +0200, Jan Beulich wrote: On 05.05.2023 23:25, Marek Marczykowski-Górecki wrote

[PATCH v2 13/18] tools/xenstore: let db_delete() return void

2023-07-10 Thread Juergen Gross
db_delete() only ever is returning 0. Switch it to return void and remove all the error handling dealing wit a non-zero return value. Suggested-by: Julien Grall Signed-off-by: Juergen Gross --- V2: - new patch --- tools/xenstore/xenstored_core.c| 11 --- tools/xenstore/xenstored

[PATCH v2 18/18] tools/xenstore: add nocopy flag to node read functions

2023-07-10 Thread Juergen Gross
Today when reading a node from the data base through read_node(), the node data is copied in order to avoid modifying the data base when preparing a node update, as otherwise an error might result in an inconsistent state. There are, however, many cases where such a copy operation isn't needed, as

[PATCH v2 10/18] tools/xenstore: add hashtable_replace() function

2023-07-10 Thread Juergen Gross
For an effective way to replace a hashtable entry add a new function hashtable_replace(). While at it let hashtable_add() fail if an entry with the specified key does already exist. This is in preparation to replace TDB with a more simple data storage. Signed-off-by: Juergen Gross --- tools/xe

[PATCH v2 09/18] tools/xenstore: let hashtable_add() fail in case of existing entry

2023-07-10 Thread Juergen Gross
Silently adding another entry with the same key to a hashtable is a perfect receipt for later failure with hard to diagnose symptoms. Let hashtable_add() fail in case another entry with the same key is already existing. Signed-off-by: Juergen Gross --- V2: - split off from next patch (Julien Gra

[PATCH v2 17/18] tools/xenstore: use struct node_hdr in struct node

2023-07-10 Thread Juergen Gross
Replace some individual fields in struct node with struct node_hdr. This allows to add a helper for calculating the accounted memory size of a node. Signed-off-by: Juergen Gross --- V2: - new patch --- tools/xenstore/xenstored_core.c| 108 - tools/xenstore/xensto

[PATCH v2 15/18] tools/xenstore: rework struct xs_tdb_record_hdr

2023-07-10 Thread Juergen Gross
Struct xs_tdb_record_hdr is used for nodes stored in the data base. When working on a node, struct node is being used, which is including the same information as struct xs_tdb_record_hdr, but in a different format. Rework struct xs_tdb_record_hdr in order to prepare including it in struct node. Do

[PATCH v2 16/18] tools/xenstore: don't use struct node_perms in struct node

2023-07-10 Thread Juergen Gross
Open code struct node_perms in struct node in order to prepare using struct node_hdr in struct node. Add two helpers to transfer permissions between struct node and struct node_perms. Signed-off-by: Juergen Gross --- V2: - new patch --- tools/xenstore/xenstored_core.c| 78 ++

[PATCH v2 14/18] tools/xenstore: move copying of node data out of db_fetch()

2023-07-10 Thread Juergen Gross
Today the node data is copied in db_fetch() on each data base read in order to avoid accidental data base modifications when working on a node. read_node() is the only caller of db_fetch() which isn't freeing the returned data area immediately after using it. The other callers don't modify the ret

[PATCH v2 11/18] tools/xenstore: drop use of tdb

2023-07-10 Thread Juergen Gross
Today all Xenstore nodes are stored in a TDB data base. This data base has several disadvantages: - It is using a fixed sized hash table, resulting in high memory overhead for small installations with only very few VMs, and a rather large performance hit for systems with lots of VMs due to man

[PATCH v2 12/18] tools/xenstore: remove tdb code

2023-07-10 Thread Juergen Gross
Now that TDB isn't used anymore, remove it. Signed-off-by: Juergen Gross Reviewed-by: Julien Grall --- tools/xenstore/Makefile.common |2 +- tools/xenstore/tdb.c | 1748 tools/xenstore/tdb.h | 132 --- 3 files changed, 1 insertion(+), 18

Re: [PATCH 04/10] x86 setup: porting dom0 construction logic to boot module structures

2023-07-10 Thread Jan Beulich
On 08.07.2023 21:15, Stefano Stabellini wrote: > On Sat, 1 Jul 2023, Christopher Clark wrote: >> @@ -1357,12 +1382,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) >> * respective reserve_e820_ram() invocation below. No need to >> * query efi_boot_mem_unused() here, t

Ping: [PATCH v2 0/2] new CONFIG_HAS_PIRQ and extra_guest_irqs adjustment

2023-07-10 Thread Jan Beulich
On 03.05.2023 17:31, Jan Beulich wrote: > The 1st patch (new in v2) has the effect of the 2nd one no longer > affecting Arm. > > 1: restrict concept of pIRQ to x86 > 2: cmdline: document and enforce "extra_guest_irqs" upper bounds REST- and Arm-maintainers, may I please ask for some feedback her

Re: [PATCH v2] mm/pdx: Add comments throughout the codebase for pdx

2023-07-10 Thread Jan Beulich
On 07.07.2023 17:55, Alejandro Vallejo wrote: > On Thu, Jul 06, 2023 at 11:50:58AM +0200, Jan Beulich wrote: >> On 22.06.2023 16:02, Alejandro Vallejo wrote: >>> @@ -57,9 +100,25 @@ uint64_t __init pdx_init_mask(uint64_t base_addr) >>> (uint64_t)1 << (MAX_ORDER + PAGE_SHIF

Re: [PATCH v2 2/6] xen/riscv: introduce reset_stack() function

2023-07-10 Thread Oleksii
On Fri, 2023-07-07 at 11:33 +0200, Jan Beulich wrote: > On 07.07.2023 11:08, Oleksii wrote: > > On Thu, 2023-07-06 at 13:17 +0200, Jan Beulich wrote: > > > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > > > --- a/xen/arch/riscv/riscv64/head.S > > > > +++ b/xen/arch/riscv/riscv64/head.S > > > > @@

Re: [PATCH v2 3/6] xen/riscv: introduce function for physical offset calculation

2023-07-10 Thread Oleksii
On Fri, 2023-07-07 at 10:17 +0100, Julien Grall wrote: > > > On 07/07/2023 10:12, Oleksii wrote: > > On Thu, 2023-07-06 at 13:18 +0200, Jan Beulich wrote: > > > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > > > --- a/xen/arch/riscv/riscv64/head.S > > > > +++ b/xen/arch/riscv/riscv64/head.S > >

Re: [PATCH v2 3/6] xen/riscv: introduce function for physical offset calculation

2023-07-10 Thread Oleksii
On Fri, 2023-07-07 at 11:35 +0200, Jan Beulich wrote: > On 07.07.2023 11:12, Oleksii wrote: > > On Thu, 2023-07-06 at 13:18 +0200, Jan Beulich wrote: > > > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > > > --- a/xen/arch/riscv/riscv64/head.S > > > > +++ b/xen/arch/riscv/riscv64/head.S > > > > @@

[xen-unstable test] 181747: tolerable FAIL

2023-07-10 Thread osstest service owner
flight 181747 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181747/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-raw 7 xen-install fail like 181741 test-armhf-armhf-libvirt 16 save

[PATCH v3 0/8] annotate entry points with type and size

2023-07-10 Thread Jan Beulich
The model introduced in patch 2 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like). 1: common: move a few macros out of xen/lib.h 2: common: assembly entry point type/size annotations 3: x86: annotate entry points with

[PATCH v3 1/8] common: move a few macros out of xen/lib.h

2023-07-10 Thread Jan Beulich
Introduce xen/macros.h for this purpose. For now xen/lib.h simply includes xen/macro.h, until consumers can be suitable cleaned up. Signed-off-by: Jan Beulich --- v3: New. --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -1,26 +1,7 @@ #ifndef __LIB_H__ #define __LIB_H__ -#define RO

[PATCH v3 2/8] common: assembly entry point type/size annotations

2023-07-10 Thread Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all arc

Re: [PATCH v2 4/6] xen/riscv: introduce identity mapping

2023-07-10 Thread Oleksii
On Fri, 2023-07-07 at 12:51 +0200, Jan Beulich wrote: > On 07.07.2023 12:37, Oleksii wrote: > > On Thu, 2023-07-06 at 13:35 +0200, Jan Beulich wrote: > > > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > > > --- a/xen/arch/riscv/include/asm/config.h > > > > +++ b/xen/arch/riscv/include/asm/config.

[PATCH v3 3/8] x86: annotate entry points with type and size

2023-07-10 Thread Jan Beulich
Use the generic framework in xen/linkage.h. For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints

[PATCH v3 4/8] x86: also mark assembler globals hidden

2023-07-10 Thread Jan Beulich
Let's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau

[PATCH v3 5/8] Arm: annotate entry points with type and size

2023-07-10 Thread Jan Beulich
Use the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones. Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the

[PATCH v3 6/8] RISC-V: annotate entry points with type and size

2023-07-10 Thread Jan Beulich
Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size. Signed-off-by: Jan Beulich --- Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any

[PATCH v3 7/8] PPC: switch entry point annotations to common model

2023-07-10 Thread Jan Beulich
Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbol changes to be a hidden one. Signed-off-by: Jan Beulich --- v3: New. --- a/xen/arch/ppc/include/asm/config.h +++ b/xen/arch/ppc/include/asm/config.h @@ -31,12 +31,7 @@ /* Linkage for P

[PATCH v3 8/8] tools/binfile: switch to common annotations model

2023-07-10 Thread Jan Beulich
Use DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding. Signed-off-by: Jan Beulich --- v3: New. --- a/xen/tools/binfile +++ b/xen/tools/binfile @@ -29,15 +29,10 @@ cat <$target .section $section.

Re: [PATCH v3 6/8] RISC-V: annotate entry points with type and size

2023-07-10 Thread Jan Beulich
On 10.07.2023 10:56, Jan Beulich wrote: > Use the generic framework in xen/linkage.h. No change in generated code > except of course the converted symbols change to be hidden ones and gain > a valid size. > > Signed-off-by: Jan Beulich I'm sorry, the Cc list was incomplete here. Adding back the

Re: [PATCH v3 2/8] common: assembly entry point type/size annotations

2023-07-10 Thread Jan Beulich
On 10.07.2023 10:52, Jan Beulich wrote: > Recent gas versions generate minimalistic Dwarf debug info for items > annotated as functions and having their sizes specified [1]. Furthermore > generating live patches wants items properly annotated. "Borrow" Arm's > END() and (remotely) derive other anno

Re: [PATCH v2 4/6] xen/riscv: introduce identity mapping

2023-07-10 Thread Jan Beulich
On 10.07.2023 10:53, Oleksii wrote: > On Fri, 2023-07-07 at 12:51 +0200, Jan Beulich wrote: >> On 07.07.2023 12:37, Oleksii wrote: >>> On Thu, 2023-07-06 at 13:35 +0200, Jan Beulich wrote: On 19.06.2023 15:34, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/mm.c > +++ b/xen/arch/riscv/m

Re: [PATCH v3 4/7] swiotlb: if swiotlb is full, fall back to a transient memory pool

2023-07-10 Thread Petr Tesařík
On Sat, 8 Jul 2023 15:18:32 + "Michael Kelley (LINUX)" wrote: > From: Petr Tesařík Sent: Friday, July 7, 2023 3:22 AM > > > > On Fri, 7 Jul 2023 10:29:00 +0100 > > Greg Kroah-Hartman wrote: > > > > > On Thu, Jul 06, 2023 at 02:22:50PM +, Michael Kelley (LINUX) wrote: > > > > From:

[PATCH] xenoprof: default to off

2023-07-10 Thread Jan Beulich
This being x86-only right now, and its x86 bits being heavily outdated, let's no longer enable this by default. While there also adjust the "help" keyword spelling. Signed-off-by: Jan Beulich --- The adjustment to pvshim_defconfig of course isn't strictly necessary, but I think the file would be

Re: [PATCH v1] xen/drivers: ns16550: Fix the return logic for pci_uart_config()

2023-07-10 Thread Jan Beulich
On 07.07.2023 13:35, Ayan Kumar Halder wrote: > --- a/xen/drivers/char/ns16550.c > +++ b/xen/drivers/char/ns16550.c > @@ -1342,13 +1342,9 @@ pci_uart_config(struct ns16550 *uart, bool_t skip_amt, > unsigned int idx) > } > } > > -if ( !skip_amt ) > -return -1; This spec

Re: [PATCH] iommu/amd-vi: avoid pointless flushes in invalidate_all_domain_pages()

2023-07-10 Thread Jan Beulich
On 07.07.2023 15:59, Roger Pau Monne wrote: > Fix invalidate_all_domain_pages() to only attempt to flush the domains > that have IOMMU enabled, otherwise the flush is pointless. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich

Re: [PATCH] x86/ioapic: sanitize IO-APIC pins before enabling the local APIC

2023-07-10 Thread Jan Beulich
On 07.07.2023 11:53, Roger Pau Monne wrote: > The current logic to init the local APIC and the IO-APIC does init the > former first before doing any kind of sanitation on the IO-APIC pin > configuration. It's already noted on enable_IO_APIC() that Xen > shouldn't trust the IO-APIC being empty at b

Re: [PATCH v5 01/15] cpufreq: Allow restricting to internal governors only

2023-07-10 Thread Jan Beulich
On 06.07.2023 20:54, Jason Andryuk wrote: > For hwp, the standard governors are not usable, and only the internal > one is applicable. Add the cpufreq_governor_internal boolean to > indicate when an internal governor, like hwp, will be used. This is set > during presmp_initcall, and governor regi

Re: [PATCH v5 04/15] xen/sysctl: Nest cpufreq scaling options

2023-07-10 Thread Jan Beulich
On 06.07.2023 20:54, Jason Andryuk wrote: > Add a union and struct so that most of the scaling variables of struct > xen_get_cpufreq_para are within in a binary-compatible layout. This > allows cppc_para to live in the larger union and use uint32_ts - struct > xen_cppc_para will be 10 uint32_t's.

Re: [PATCH v5 05/15] pmstat&xenpm: Re-arrage for cpufreq union

2023-07-10 Thread Jan Beulich
On 06.07.2023 20:54, Jason Andryuk wrote: > Rearrange code now that xen_sysctl_pm_op's get_para fields has the > nested union and struct. In particular, the scaling governor > information like scaling_available_governors is inside the union, so it > is not always available. Move those fields (op-

Re: [RFC PATCH 0/3] x86/paravirt: Get rid of paravirt patching

2023-07-10 Thread Juergen Gross
Any comments? On 08.06.23 16:03, Juergen Gross wrote: This is a small series getting rid of paravirt patching by switching completely to alternative patching for the same functionality. The basic idea is to add the capability to switch from indirect to direct calls via a special alternative pat

Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver

2023-07-10 Thread Jan Beulich
On 06.07.2023 20:54, Jason Andryuk wrote: > @@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not supported > by all Dom0 kernels. > * `` and `` are integers which represent max and min > processor frequencies >respectively. > * `verbose` option can be included as a string or a

Re: [PATCH v3 1/2] tools/console: Add escape argument to configure escape character

2023-07-10 Thread Anthony PERARD
On Thu, Jun 22, 2023 at 03:12:47PM +0100, Peter Hoyes wrote: > From: Peter Hoyes > > Dom0 may be accessed via telnet, meaning the default escape character > (which is the same as telnet's) cannot be directly used to exit the > console. It would be helpful to make the escape character customizable

[PATCH] cmdline: only set ask mode if vga= is present

2023-07-10 Thread Roger Pau Monne
Commit 9473d9a24182 set the ASK mode without checking if there was a `vga` option provided in the command line. This breaks existing behavior, so exit early without changes if `vga` is not present in the command line. Fixes: 9473d9a24182 ('cmdline: parse multiple instances of the vga option') Sig

[xen-unstable-smoke test] 181750: tolerable all pass - PUSHED

2023-07-10 Thread osstest service owner
flight 181750 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181750/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[XEN PATCH] x86/emul: fix violations of MISRA C:2012 Rule 8.3 on parameter names

2023-07-10 Thread Federico Serafini
The headline of MISRA C:2012 Rule 8.3 states that: "All declarations of an object or function shall use the same names and type qualifiers". Change parameter names to meet the following requirements: 1) keep consistency between declarations and the corresponding definitions thus fixing violatio

[ovmf test] 181751: all pass - PUSHED

2023-07-10 Thread osstest service owner
flight 181751 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181751/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 63923a5642e86f386a5c719a90cfc6a929ea9cb0 baseline version: ovmf 96d691166f07b7ed422f9

Re: [PATCH] x86/ioapic: sanitize IO-APIC pins before enabling the local APIC

2023-07-10 Thread Roger Pau Monné
On Mon, Jul 10, 2023 at 12:56:27PM +0200, Jan Beulich wrote: > On 07.07.2023 11:53, Roger Pau Monne wrote: > > The current logic to init the local APIC and the IO-APIC does init the > > former first before doing any kind of sanitation on the IO-APIC pin > > configuration. It's already noted on ena

Re: [PATCH v3 2/2] xl: Add escape character argument to xl console

2023-07-10 Thread Anthony PERARD
On Thu, Jun 22, 2023 at 03:12:48PM +0100, Peter Hoyes wrote: > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index cac641a7eb..c513c39483 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -1958,7 +1958,8 @@ int libxl_vncviewer_exec(libxl_ctx *ctx, uint32_t > do

Re: [PATCH v5 06/15] cpufreq: Add Hardware P-State (HWP) driver

2023-07-10 Thread Jason Andryuk
On Mon, Jul 10, 2023 at 9:13 AM Jan Beulich wrote: > > On 06.07.2023 20:54, Jason Andryuk wrote: > > @@ -510,6 +510,22 @@ choice of `dom0-kernel` is deprecated and not > > supported by all Dom0 kernels. > > * `` and `` are integers which represent max and min > > processor frequencies > >re

Re: [PATCH] xenoprof: default to off

2023-07-10 Thread Roger Pau Monné
On Mon, Jul 10, 2023 at 11:48:09AM +0200, Jan Beulich wrote: > This being x86-only right now, and its x86 bits being heavily outdated, > let's no longer enable this by default. > > While there also adjust the "help" keyword spelling. > > Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné Th

Re: [XEN PATCH v2 12/13] xen/x86: fix violations of MISRA C:2012 Rule 7.2

2023-07-10 Thread Simone Ballarin
Il giorno ven 7 lug 2023 alle ore 23:53 Stefano Stabellini < sstabell...@kernel.org> ha scritto: > On Fri, 7 Jul 2023, Jan Beulich wrote: > > On 07.07.2023 10:04, Simone Ballarin wrote: > > > Il giorno ven 7 lug 2023 alle ore 09:04 Jan Beulich > ha > > > scritto: > > > > > >> On 07.07.2023 08:50,

Re: [PATCH v2] mm/pdx: Add comments throughout the codebase for pdx

2023-07-10 Thread Alejandro Vallejo
On Mon, Jul 10, 2023 at 09:43:34AM +0200, Jan Beulich wrote: > This is ... > >>> [snip] > >>> + * This is where compression becomes useful. The idea is to note that if > >>> + * you have several big chunks of memory sufficiently far apart you can > >>> + * ignore the middle part of the address beca

Re: [PATCH] cmdline: only set ask mode if vga= is present

2023-07-10 Thread Jan Beulich
On 10.07.2023 16:12, Roger Pau Monne wrote: > Commit 9473d9a24182 set the ASK mode without checking if there was a > `vga` option provided in the command line. This breaks existing > behavior, so exit early without changes if `vga` is not present in the > command line. > > Fixes: 9473d9a24182 ('c

Re: [PATCH v2] mm/pdx: Add comments throughout the codebase for pdx

2023-07-10 Thread Jan Beulich
On 10.07.2023 18:12, Alejandro Vallejo wrote: > On Mon, Jul 10, 2023 at 09:43:34AM +0200, Jan Beulich wrote: >> This is ... > [snip] > + * This is where compression becomes useful. The idea is to note that if > + * you have several big chunks of memory sufficiently far apart you can >>>

[PATCH] tools/utils: move XLU_Operation to libxlu_internal.h

2023-07-10 Thread Elliott Mitchell
This enumerated value is never used outside of the configuration parser. As such, move to the internal header. Signed-off-by: Elliott Mitchell --- tools/include/libxlutil.h | 5 - tools/libs/util/libxlu_internal.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --gi

[linux-linus test] 181749: regressions - FAIL

2023-07-10 Thread osstest service owner
flight 181749 linux-linus real [real] flight 181753 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181749/ http://logs.test-lab.xenproject.org/osstest/logs/181753/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[xen-unstable-smoke test] 181754: tolerable all pass - PUSHED

2023-07-10 Thread osstest service owner
flight 181754 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/181754/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [QEMU PATCH v2 1/1] virtgpu: do not destroy resources when guest suspend

2023-07-10 Thread Michael S. Tsirkin
On Fri, Jun 30, 2023 at 03:00:16PM +0800, Jiqian Chen wrote: > After suspending and resuming guest VM, you will get > a black screen, and the display can't come back. > > This is because when guest did suspending, it called > into qemu to call virtio_gpu_gl_reset. In function > virtio_gpu_gl_reset

[PATCH v2] docs/misra: add Rule 7.4 and 9.4

2023-07-10 Thread Stefano Stabellini
From: Stefano Stabellini Rule 9.4 is non-controversial and we have no violations. Rule 7.4 is considered a good idea with the caveat that assigning a string literal to const void is allowed. I added a note to specify it. Signed-off-by: Stefano Stabellini --- Changes in v2: - improve rule 7.4 n

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-10 Thread Julien Grall
Hi, On 04/05/2023 09:21, Jan Beulich wrote: On 04.05.2023 10:13, Roger Pau Monné wrote: On Thu, May 04, 2023 at 09:50:27AM +0200, Jan Beulich wrote: On 04.05.2023 09:44, Roger Pau Monné wrote: On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote: --- a/xen/include/xen/sched.h +++ b/xe

Re: [PATCH v2 1/2] restrict concept of pIRQ to x86

2023-07-10 Thread Julien Grall
Hi Jan, On 03/05/2023 16:33, Jan Beulich wrote: ... by way of a new arch-selectable Kconfig control. Note that some smaller pieces of code are left without #ifdef, to keep things better readable. Hence items like ECS_PIRQ, nr_static_irqs, or domain_pirq_to_irq() remain uniformly. Signed-off-by

Re: [XEN PATCH] x86/emul: fix violations of MISRA C:2012 Rule 8.3 on parameter names

2023-07-10 Thread Stefano Stabellini
On Mon, 10 Jul 2023, Federico Serafini wrote: > The headline of MISRA C:2012 Rule 8.3 states that: > "All declarations of an object or function shall use the same names and > type qualifiers". > > Change parameter names to meet the following requirements: > 1) keep consistency between declarations

[xen-unstable test] 181752: tolerable FAIL - PUSHED

2023-07-10 Thread osstest service owner
flight 181752 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181752/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 181727 test-amd64-amd64-xl-qcow221 gues

Branch name transition plan?

2023-07-10 Thread Elliott Mitchell
Is there any sort of plan to move to an alternative name for the "master" branch? I am not personally offended, but enough people are that this really should get some attention. I am concerned about potential for reputational harm from associating with a project which has been sluggish in moving

[RFC PATCH] pci: introduce per-domain PCI rwlock

2023-07-10 Thread Volodymyr Babchuk
Add per-domain d->pci_lock that protects access to d->pdev_list. Purpose of this lock is to give guarantees to VPCI code that underlying pdev will not disappear under feet. Later it will also protect pdev->vpci structure and pdev access in modify_bars(). Suggested-by: Roger Pau Monné Suggested-by

Re: [RFC PATCH] xen/arm: Rebranding dom0less feature

2023-07-10 Thread Daniel P. Smith
On 7/8/23 14:08, Stefano Stabellini wrote: > On Sat, 8 Jul 2023, Rich Persaud wrote: >> On Jul 8, 2023, at 03:29, Luca Fancellu wrote: >>>  >> >> Instead, the use case configurations should themselves be describable. > > Thanks Christopher, Daniel and all! > > So if I u

Re: [QEMU PATCH v2 1/1] virtgpu: do not destroy resources when guest suspend

2023-07-10 Thread Chen, Jiqian
Hi, On 2023/7/11 04:28, Michael S. Tsirkin wrote: > On Fri, Jun 30, 2023 at 03:00:16PM +0800, Jiqian Chen wrote: >> After suspending and resuming guest VM, you will get >> a black screen, and the display can't come back. >> >> This is because when guest did suspending, it called >> into qemu to ca

[PATCH 2/3] locking/x86: Wire up sync_try_cmpxchg

2023-07-10 Thread Uros Bizjak
Implement target specific support for sync_try_cmpxchg. Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Signed-off-by: Uros Bizjak --- arch/x86/include/asm/cmpxchg.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ar

[PATCH 3/3] xen: Illustrate the transition to sync_try_cmpxchg

2023-07-10 Thread Uros Bizjak
This patch illustrates the transition to sync_try_cmpxchg. It is not intended to be merged as-is. Cc: Peter Zijlstra Cc: Juergen Gross Cc: Stefano Stabellini Cc: Oleksandr Tyshchenko Signed-off-by: Uros Bizjak --- drivers/xen/events/events_fifo.c | 26 -- drivers/xen/

[PATCH 1/3] locking/generic: Add generic support for sync_try_cmpxchg and its falback

2023-07-10 Thread Uros Bizjak
Provide the generic sync_try_cmpxchg function from the raw_ prefixed version, also adding explicit instrumentation. Cc: Will Deacon Cc: Peter Zijlstra Cc: Boqun Feng Cc: Mark Rutland Signed-off-by: Uros Bizjak --- include/linux/atomic/atomic-arch-fallback.h | 15 +- include/linux/ato

[ovmf test] 181757: all pass - PUSHED

2023-07-10 Thread osstest service owner
flight 181757 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/181757/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 964a4f032dcd15d7b0d9246625b13b71182e4eae baseline version: ovmf 63923a5642e86f386a5c7

[linux-linus test] 181755: regressions - FAIL

2023-07-10 Thread osstest service owner
flight 181755 linux-linus real [real] flight 181758 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181755/ http://logs.test-lab.xenproject.org/osstest/logs/181758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run