Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
Re-reading the whole thread again ... On 29.06.23 03:00, Stefano Stabellini wrote: On Wed, 21 Jun 2023, Oleksandr Tyshchenko wrote: On 21.06.23 16:12, Petr Pavlu wrote: Hello Petr When attempting to run Xen on a QEMU/KVM virtual machine with virtio devices (all x86_64), dom0 tries to estab

Re: [XEN PATCH v2 12/13] xen/x86: fix violations of MISRA C:2012 Rule 7.2

2023-07-07 Thread Jan Beulich
On 07.07.2023 08:50, Simone Ballarin wrote: > Il giorno gio 6 lug 2023 alle ore 18:22 Jan Beulich ha > scritto: > >> On 06.07.2023 18:08, Simone Ballarin wrote: >>> Il giorno gio 6 lug 2023 alle ore 10:26 Jan Beulich >> ha >>> scritto: >>> On 05.07.2023 17:26, Simone Ballarin wrote: > -

[xen-unstable test] 181727: tolerable FAIL - PUSHED

2023-07-07 Thread osstest service owner
flight 181727 xen-unstable real [real] flight 181730 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/181727/ http://logs.test-lab.xenproject.org/osstest/logs/181730/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 26.06.23 15:17, Petr Pavlu wrote: On 6/21/23 19:58, Oleksandr Tyshchenko wrote: On 21.06.23 16:12, Petr Pavlu wrote: When attempting to run Xen on a QEMU/KVM virtual machine with virtio devices (all x86_64), dom0 tries to establish a grant for itself which eventually results in a hang during

Re: Detecting whether dom0 is in a VM

2023-07-07 Thread Jan Beulich
On 06.07.2023 17:35, zithro wrote: > On 06 Jul 2023 09:02, Jan Beulich wrote: >> On 05.07.2023 18:20, zithro wrote: >>> So I'm wondering, isn't that path enough for correct detection ? >>> I mean, if "/sys/class/dmi/id/sys_vendor" reports Xen (or KVM, or any >>> other known hypervisor), it's nested

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Oleksandr Tyshchenko
On 07.07.23 10:04, Juergen Gross wrote: Hello Juergen > Re-reading the whole thread again ... > > On 29.06.23 03:00, Stefano Stabellini wrote: >> On Wed, 21 Jun 2023, Oleksandr Tyshchenko wrote: >>> On 21.06.23 16:12, Petr Pavlu wrote: >>> >>> >>> Hello Petr >>> >>> When attempting to ru

Re: [XEN PATCH v2 12/13] xen/x86: fix violations of MISRA C:2012 Rule 7.2

2023-07-07 Thread Simone Ballarin
Il giorno ven 7 lug 2023 alle ore 09:04 Jan Beulich ha scritto: > On 07.07.2023 08:50, Simone Ballarin wrote: > > Il giorno gio 6 lug 2023 alle ore 18:22 Jan Beulich > ha > > scritto: > > > >> On 06.07.2023 18:08, Simone Ballarin wrote: > >>> Il giorno gio 6 lug 2023 alle ore 10:26 Jan Beulich

Re: [PATCH v2 1/3] xen/arm: pci: introduce PCI_PASSTHROUGH Kconfig option

2023-07-07 Thread Julien Grall
Hi Jan, On 07/07/2023 07:55, Jan Beulich wrote: On 07.07.2023 03:47, Stewart Hildebrand wrote: --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -190,6 +190,15 @@ config STATIC_SHM help This option enables statically shared memory on a dom0less system. +config PCI_PA

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 07.07.23 10:00, Oleksandr Tyshchenko wrote: On 07.07.23 10:04, Juergen Gross wrote: Hello Juergen Re-reading the whole thread again ... On 29.06.23 03:00, Stefano Stabellini wrote: On Wed, 21 Jun 2023, Oleksandr Tyshchenko wrote: On 21.06.23 16:12, Petr Pavlu wrote: Hello Petr Wh

Re: [XEN PATCH v2 07/13] x86/vmx: fix violations of MISRA C:2012 Rule 7.2

2023-07-07 Thread Simone Ballarin
Il giorno gio 6 lug 2023 alle ore 10:04 Jan Beulich ha scritto: > On 05.07.2023 17:26, Simone Ballarin wrote: > > --- a/xen/arch/x86/hvm/vmx/vvmx.c > > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > > @@ -257,14 +257,14 @@ uint64_t get_vvmcs_virtual(void *vvmcs, uint32_t > vmcs_encoding) > > > > switch

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Oleksandr Tyshchenko
On 07.07.23 11:11, Juergen Gross wrote: Hello Juergen > On 07.07.23 10:00, Oleksandr Tyshchenko wrote: >> >> >> On 07.07.23 10:04, Juergen Gross wrote: >> >> Hello Juergen >> >> >>> Re-reading the whole thread again ... >>> >>> On 29.06.23 03:00, Stefano Stabellini wrote: On Wed, 21 Jun 2

Re: [PATCH v2 1/3] xen/arm: pci: introduce PCI_PASSTHROUGH Kconfig option

2023-07-07 Thread Julien Grall
Hi, On 07/07/2023 02:47, Stewart Hildebrand wrote: From: Rahul Singh Setting CONFIG_PCI_PASSTHROUGH=y will enable PCI passthrough on ARM, even though the feature is not yet complete in the current upstream codebase. The purpose of this is to make it easier to enable the necessary configs (HAS_

Re: [PATCH v2 2/3] xen/arm: make has_vpci depend on CONFIG_HAS_VPCI

2023-07-07 Thread Julien Grall
Hi, On 07/07/2023 02:47, Stewart Hildebrand wrote: From: Oleksandr Andrushchenko VPCI is disabled on ARM. Make it depend on CONFIG_HAS_VPCI to test the PCI passthrough support. Also make it depend on is_hardware_domain for now. The is_hardware_domain check should be removed when vPCI is upstre

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Julien Grall
Hi, On 07/07/2023 02:47, Stewart Hildebrand wrote: Remove is_hardware_domain check in has_vpci, and select HAS_VPCI_GUEST_SUPPORT in Kconfig. [1] https://lists.xenproject.org/archives/html/xen-devel/2023-06/msg00863.html Signed-off-by: Stewart Hildebrand --- As the tag implies, this patch is

Re: [PATCH v2 2/6] xen/riscv: introduce reset_stack() function

2023-07-07 Thread Oleksii
On Thu, 2023-07-06 at 13:17 +0200, Jan Beulich wrote: > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/riscv64/head.S > > +++ b/xen/arch/riscv/riscv64/head.S > > @@ -27,8 +27,16 @@ ENTRY(start) > > add t3, t3, __SIZEOF_POINTER__ > > bltu    t3, t4, .L_cl

Re: [PATCH v2 3/6] xen/riscv: introduce function for physical offset calculation

2023-07-07 Thread Oleksii
On Thu, 2023-07-06 at 13:18 +0200, Jan Beulich wrote: > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/riscv64/head.S > > +++ b/xen/arch/riscv/riscv64/head.S > > @@ -29,6 +29,8 @@ ENTRY(start) > >   > > jal reset_stack > >   > > +    jal calc_phys_offset

Re: [PATCH v2 3/6] xen/riscv: introduce function for physical offset calculation

2023-07-07 Thread Julien Grall
On 07/07/2023 10:12, Oleksii wrote: On Thu, 2023-07-06 at 13:18 +0200, Jan Beulich wrote: On 19.06.2023 15:34, Oleksii Kurochko wrote: --- a/xen/arch/riscv/riscv64/head.S +++ b/xen/arch/riscv/riscv64/head.S @@ -29,6 +29,8 @@ ENTRY(start) jal reset_stack +    jal c

Re: [PATCH v3 4/7] swiotlb: if swiotlb is full, fall back to a transient memory pool

2023-07-07 Thread Greg Kroah-Hartman
On Thu, Jul 06, 2023 at 02:22:50PM +, Michael Kelley (LINUX) wrote: > From: Greg Kroah-Hartman Sent: Thursday, July 6, > 2023 1:07 AM > > > > On Thu, Jul 06, 2023 at 03:50:55AM +, Michael Kelley (LINUX) wrote: > > > From: Petr Tesarik Sent: Tuesday, June 27, > > > 2023 > > 2:54 AM > >

Re: [PATCH v2 2/6] xen/riscv: introduce reset_stack() function

2023-07-07 Thread Jan Beulich
On 07.07.2023 11:08, Oleksii wrote: > On Thu, 2023-07-06 at 13:17 +0200, Jan Beulich wrote: >> On 19.06.2023 15:34, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/riscv64/head.S >>> +++ b/xen/arch/riscv/riscv64/head.S >>> @@ -27,8 +27,16 @@ ENTRY(start) >>> add t3, t3, __SIZEOF_POINT

Re: [PATCH v2 3/6] xen/riscv: introduce function for physical offset calculation

2023-07-07 Thread Jan Beulich
On 07.07.2023 11:12, Oleksii wrote: > On Thu, 2023-07-06 at 13:18 +0200, Jan Beulich wrote: >> On 19.06.2023 15:34, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/riscv64/head.S >>> +++ b/xen/arch/riscv/riscv64/head.S >>> @@ -29,6 +29,8 @@ ENTRY(start) >>>   >>> jal reset_stack >>>  

Re: [XEN PATCH v2 12/13] xen/x86: fix violations of MISRA C:2012 Rule 7.2

2023-07-07 Thread Jan Beulich
On 07.07.2023 10:04, Simone Ballarin wrote: > Il giorno ven 7 lug 2023 alle ore 09:04 Jan Beulich ha > scritto: > >> On 07.07.2023 08:50, Simone Ballarin wrote: >>> Il giorno gio 6 lug 2023 alle ore 18:22 Jan Beulich >> ha >>> scritto: >>> On 06.07.2023 18:08, Simone Ballarin wrote: > I

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: > On 06.07.23 23:49, Stefano Stabellini wrote: > > On Thu, 6 Jul 2023, Roger Pau Monné wrote: > > > On Wed, Jul 05, 2023 at 03:41:10PM -0700, Stefano Stabellini wrote: > > > > On Wed, 5 Jul 2023, Roger Pau Monné wrote: > > > > > On Tue,

Re: Detecting whether dom0 is in a VM

2023-07-07 Thread George Dunlap
On Fri, Jul 7, 2023 at 9:00 AM Jan Beulich wrote: > On 06.07.2023 17:35, zithro wrote: > > On 06 Jul 2023 09:02, Jan Beulich wrote: > >> On 05.07.2023 18:20, zithro wrote: > >>> So I'm wondering, isn't that path enough for correct detection ? > >>> I mean, if "/sys/class/dmi/id/sys_vendor" report

[PATCH] x86/ioapic: sanitize IO-APIC pins before enabling the local APIC

2023-07-07 Thread Roger Pau Monne
The current logic to init the local APIC and the IO-APIC does init the former first before doing any kind of sanitation on the IO-APIC pin configuration. It's already noted on enable_IO_APIC() that Xen shouldn't trust the IO-APIC being empty at bootup. At XenServer we have a system where the IO-A

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 10:00:51AM +0100, Julien Grall wrote: > On 07/07/2023 02:47, Stewart Hildebrand wrote: > > Note that CONFIG_HAS_VPCI_GUEST_SUPPORT is not currently used in the > > upstream > > code base. It will be used by the vPCI series [1]. This patch is intended > > to be > > merged a

Re: [PATCH v4 1/3] multiboot2: parse vga= option when setting GOP mode

2023-07-07 Thread Roger Pau Monné
On Thu, Jul 06, 2023 at 12:41:58PM +0200, Jan Beulich wrote: > On 05.07.2023 13:47, Roger Pau Monne wrote: > > --- a/xen/arch/x86/efi/efi-boot.h > > +++ b/xen/arch/x86/efi/efi-boot.h > > @@ -795,7 +795,30 @@ static bool __init > > efi_arch_use_config_file(EFI_SYSTEM_TABLE *SystemTable) > > > >

Re: [PATCH v4 3/3] cmdline: parse multiple instances of the vga option

2023-07-07 Thread Roger Pau Monné
On Thu, Jul 06, 2023 at 12:45:41PM +0200, Jan Beulich wrote: > On 05.07.2023 13:47, Roger Pau Monne wrote: > > Parse all instances of the vga= option on the command line, in order > > to always enforce the last selection on the command line. > > > > Note that it's not safe to parse just the last o

Re: Detecting whether dom0 is in a VM

2023-07-07 Thread Jan Beulich
On 07.07.2023 11:52, George Dunlap wrote: > On Fri, Jul 7, 2023 at 9:00 AM Jan Beulich wrote: > >> On 06.07.2023 17:35, zithro wrote: >>> On 06 Jul 2023 09:02, Jan Beulich wrote: On 05.07.2023 18:20, zithro wrote: > So I'm wondering, isn't that path enough for correct detection ? > I

Re: [PATCH v3 4/7] swiotlb: if swiotlb is full, fall back to a transient memory pool

2023-07-07 Thread Petr Tesařík
On Fri, 7 Jul 2023 10:29:00 +0100 Greg Kroah-Hartman wrote: > On Thu, Jul 06, 2023 at 02:22:50PM +, Michael Kelley (LINUX) wrote: > > From: Greg Kroah-Hartman Sent: Thursday, July > > 6, 2023 1:07 AM > > > > > > On Thu, Jul 06, 2023 at 03:50:55AM +, Michael Kelley (LINUX) wrote: >

Re: [PATCH v4 1/3] multiboot2: parse vga= option when setting GOP mode

2023-07-07 Thread Jan Beulich
On 07.07.2023 12:13, Roger Pau Monné wrote: > On Thu, Jul 06, 2023 at 12:41:58PM +0200, Jan Beulich wrote: >> On 05.07.2023 13:47, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/efi/efi-boot.h >>> +++ b/xen/arch/x86/efi/efi-boot.h >>> @@ -795,7 +795,30 @@ static bool __init >>> efi_arch_use_config_

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Julien Grall
Hi, On 07/07/2023 11:06, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 10:00:51AM +0100, Julien Grall wrote: On 07/07/2023 02:47, Stewart Hildebrand wrote: Note that CONFIG_HAS_VPCI_GUEST_SUPPORT is not currently used in the upstream code base. It will be used by the vPCI series [1]. This pat

Re: [PATCH v2 4/6] xen/riscv: introduce identity mapping

2023-07-07 Thread Oleksii
On Thu, 2023-07-06 at 13:35 +0200, Jan Beulich wrote: > On 19.06.2023 15:34, Oleksii Kurochko wrote: > > Since it is not easy to keep track where the identity map was > > mapped, > > so we will look for the top-level entry exclusive to the identity > > map and remove it. > > I think you mean "top-

Re: [PATCH v4 1/3] multiboot2: parse vga= option when setting GOP mode

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 12:24:10PM +0200, Jan Beulich wrote: > On 07.07.2023 12:13, Roger Pau Monné wrote: > > On Thu, Jul 06, 2023 at 12:41:58PM +0200, Jan Beulich wrote: > >> On 05.07.2023 13:47, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/efi/efi-boot.h > >>> +++ b/xen/arch/x86/efi/efi-boot.

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 11:33:14AM +0100, Julien Grall wrote: > Hi, > > On 07/07/2023 11:06, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 10:00:51AM +0100, Julien Grall wrote: > > > On 07/07/2023 02:47, Stewart Hildebrand wrote: > > > > Note that CONFIG_HAS_VPCI_GUEST_SUPPORT is not currentl

Re: [PATCH v2 4/6] xen/riscv: introduce identity mapping

2023-07-07 Thread Jan Beulich
On 07.07.2023 12:37, Oleksii wrote: > On Thu, 2023-07-06 at 13:35 +0200, Jan Beulich wrote: >> On 19.06.2023 15:34, Oleksii Kurochko wrote: >>> --- a/xen/arch/riscv/include/asm/config.h >>> +++ b/xen/arch/riscv/include/asm/config.h >>> @@ -1,3 +1,5 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only *

Re: [PATCH v2 1/2] x86/mm: add API for marking only part of a MMIO page read only

2023-07-07 Thread Marek Marczykowski-Górecki
On Wed, Jul 05, 2023 at 10:23:53AM +0200, Jan Beulich wrote: > On 01.07.2023 00:28, Marek Marczykowski-Górecki wrote: > > On Tue, May 30, 2023 at 01:56:34PM +0200, Jan Beulich wrote: > >> On 05.05.2023 23:25, Marek Marczykowski-Górecki wrote: > >>> --- a/xen/arch/x86/hvm/hvm.c > >>> +++ b/xen/arch/

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Rahul Singh
Hi Stewart, > On 7 Jul 2023, at 2:47 am, Stewart Hildebrand > wrote: > > Remove is_hardware_domain check in has_vpci, and select HAS_VPCI_GUEST_SUPPORT > in Kconfig. > > [1] https://lists.xenproject.org/archives/html/xen-devel/2023-06/msg00863.html > > Signed-off-by: Stewart Hildebrand > --- >

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Julien Grall
On 07/07/2023 11:47, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 11:33:14AM +0100, Julien Grall wrote: Hi, On 07/07/2023 11:06, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 10:00:51AM +0100, Julien Grall wrote: On 07/07/2023 02:47, Stewart Hildebrand wrote: Note that CONFIG_HAS_VPCI_

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

2023-07-07 Thread Christoph Hellwig
On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote: > > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > > void *holder, const struct blk_holder_ops *hops); > > void bdev_release(struct bdev_handle *handle); > > I'd maybe use bdev_close() instead of bdev_releas

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 12:16:46PM +0100, Julien Grall wrote: > > > On 07/07/2023 11:47, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 11:33:14AM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 07/07/2023 11:06, Roger Pau Monné wrote: > > > > On Fri, Jul 07, 2023 at 10:00:51AM +0100, Ju

[PATCH v1] xen/drivers: ns16550: Fix the return logic for pci_uart_config()

2023-07-07 Thread Ayan Kumar Halder
pci_uart_config() should return 0 when it probes the correct uart device and sets the properties of "struct ns16550". Else, it should return -ENODEV. Also before returning -ENODEV, it should restore the value of uart->io_base. The callers should check if pci_uart_config() has returned 0 (for succe

Re: [XEN v4 04/11] xen/drivers: ns16550: Use paddr_t for io_base/io_size

2023-07-07 Thread Ayan Kumar Halder
Hi Jan, On 30/03/2023 07:55, Jan Beulich wrote: On 29.03.2023 16:35, Ayan Kumar Halder wrote: Please let me know if the below patch looks fine. Apart from the comments below there may be formatting issues, which I can't sensibly comment on when the patch was mangled by your mailer anyway. (Whi

Re: Detecting whether dom0 is in a VM

2023-07-07 Thread Jan Beulich
On 07.07.2023 12:16, Jan Beulich wrote: > On 07.07.2023 11:52, George Dunlap wrote: >> On Fri, Jul 7, 2023 at 9:00 AM Jan Beulich wrote: >> >>> On 06.07.2023 17:35, zithro wrote: On 06 Jul 2023 09:02, Jan Beulich wrote: > On 05.07.2023 18:20, zithro wrote: >> So I'm wondering, isn't t

[linux-linus test] 181729: regressions - FAIL

2023-07-07 Thread osstest service owner
flight 181729 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181729/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Julien Grall
Hi, On 07/07/2023 12:34, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 12:16:46PM +0100, Julien Grall wrote: On 07/07/2023 11:47, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 11:33:14AM +0100, Julien Grall wrote: Hi, On 07/07/2023 11:06, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 1

Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions

2023-07-07 Thread Jan Kara
On Fri 07-07-23 04:28:41, Christoph Hellwig wrote: > On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote: > > > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > > > void *holder, const struct blk_holder_ops *hops); > > > void bdev_release(struct bdev_handle *handle

Re: Detecting whether dom0 is in a VM

2023-07-07 Thread George Dunlap
On Fri, Jul 7, 2023 at 11:17 AM Jan Beulich wrote: > On 07.07.2023 11:52, George Dunlap wrote: > > On Fri, Jul 7, 2023 at 9:00 AM Jan Beulich wrote: > > > >> On 06.07.2023 17:35, zithro wrote: > >>> On 06 Jul 2023 09:02, Jan Beulich wrote: > On 05.07.2023 18:20, zithro wrote: > > So I'm

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 01:09:40PM +0100, Julien Grall wrote: > Hi, > > On 07/07/2023 12:34, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 12:16:46PM +0100, Julien Grall wrote: > > > > > > > > > On 07/07/2023 11:47, Roger Pau Monné wrote: > > > > On Fri, Jul 07, 2023 at 11:33:14AM +0100, Ju

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Julien Grall
Hi, On 07/07/2023 14:13, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 01:09:40PM +0100, Julien Grall wrote: Hi, On 07/07/2023 12:34, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 12:16:46PM +0100, Julien Grall wrote: On 07/07/2023 11:47, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 1

Re: [PATCH v2 3/3] [FUTURE] xen/arm: enable vPCI for domUs

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 02:27:17PM +0100, Julien Grall wrote: > Hi, > > On 07/07/2023 14:13, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 01:09:40PM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 07/07/2023 12:34, Roger Pau Monné wrote: > > > > On Fri, Jul 07, 2023 at 12:16:46PM +0100,

[PATCH] iommu/amd-vi: avoid pointless flushes in invalidate_all_domain_pages()

2023-07-07 Thread Roger Pau Monne
Fix invalidate_all_domain_pages() to only attempt to flush the domains that have IOMMU enabled, otherwise the flush is pointless. Signed-off-by: Roger Pau Monné --- xen/drivers/passthrough/amd/iommu_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthr

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 07.07.23 11:50, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: On 06.07.23 23:49, Stefano Stabellini wrote: On Thu, 6 Jul 2023, Roger Pau Monné wrote: On Wed, Jul 05, 2023 at 03:41:10PM -0700, Stefano Stabellini wrote: On Wed, 5 Jul 2023, Roger Pau Mo

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 07.07.23 16:10, Juergen Gross wrote: On 07.07.23 11:50, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: On 06.07.23 23:49, Stefano Stabellini wrote: On Thu, 6 Jul 2023, Roger Pau Monné wrote: On Wed, Jul 05, 2023 at 03:41:10PM -0700, Stefano Stabellini

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 04:10:14PM +0200, Juergen Gross wrote: > On 07.07.23 11:50, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: > > > On 06.07.23 23:49, Stefano Stabellini wrote: > > > > On Thu, 6 Jul 2023, Roger Pau Monné wrote: > > > > > On Wed, Jul 0

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 04:27:59PM +0200, Juergen Gross wrote: > On 07.07.23 16:10, Juergen Gross wrote: > > On 07.07.23 11:50, Roger Pau Monné wrote: > > > On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: > > > > On 06.07.23 23:49, Stefano Stabellini wrote: > > > > > On Thu, 6 Jul 20

Re: Detecting whether dom0 is in a VM

2023-07-07 Thread George Dunlap
On Fri, Jul 7, 2023 at 12:45 PM Jan Beulich wrote: > On 07.07.2023 12:16, Jan Beulich wrote: > > On 07.07.2023 11:52, George Dunlap wrote: > >> On Fri, Jul 7, 2023 at 9:00 AM Jan Beulich wrote: > >> > >>> On 06.07.2023 17:35, zithro wrote: > On 06 Jul 2023 09:02, Jan Beulich wrote: > >

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 07.07.23 16:42, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 04:10:14PM +0200, Juergen Gross wrote: On 07.07.23 11:50, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: On 06.07.23 23:49, Stefano Stabellini wrote: On Thu, 6 Jul 2023, Roger Pau Monné wr

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Roger Pau Monné
On Fri, Jul 07, 2023 at 05:01:38PM +0200, Juergen Gross wrote: > On 07.07.23 16:42, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 04:10:14PM +0200, Juergen Gross wrote: > > > On 07.07.23 11:50, Roger Pau Monné wrote: > > > > On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: > > >

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 07.07.23 16:48, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 04:27:59PM +0200, Juergen Gross wrote: On 07.07.23 16:10, Juergen Gross wrote: On 07.07.23 11:50, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: On 06.07.23 23:49, Stefano Stabellini wrote

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Juergen Gross
On 07.07.23 17:14, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 05:01:38PM +0200, Juergen Gross wrote: On 07.07.23 16:42, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 04:10:14PM +0200, Juergen Gross wrote: On 07.07.23 11:50, Roger Pau Monné wrote: On Fri, Jul 07, 2023 at 06:38:48AM +0200,

Re: [PATCH v2] mm/pdx: Add comments throughout the codebase for pdx

2023-07-07 Thread Alejandro Vallejo
On Thu, Jul 06, 2023 at 11:50:58AM +0200, Jan Beulich wrote: > On 22.06.2023 16:02, Alejandro Vallejo wrote: > > @@ -57,9 +100,25 @@ uint64_t __init pdx_init_mask(uint64_t base_addr) > > (uint64_t)1 << (MAX_ORDER + PAGE_SHIFT)) - 1); > > } > > > > -u64 __init pdx_region

[PATCH v3] mm/pdx: Add comments throughout the codebase for pdx

2023-07-07 Thread Alejandro Vallejo
Document the behaviour of the pdx machinery in Xen. Some logic is fairly opaque and hard to follow without it being documented anywhere. This explains the rationale behind compression and its relationship to frametable indexing and directmap management. While modifying the file: * Convert u64 ->

[xen-unstable test] 181731: tolerable FAIL

2023-07-07 Thread osstest service owner
flight 181731 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/181731/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 181727 pass in 181731 test-amd64-i386-xl-vhd 21 guest-

Re: [PATCH v7 10/12] vpci: add initial support for virtual PCI bus topology

2023-07-07 Thread Oleksandr Tyshchenko
On 21.06.23 15:06, Jan Beulich wrote: Hello all On 13.06.2023 12:32, Volodymyr Babchuk wrote: @@ -121,6 +124,62 @@ int vpci_add_handlers(struct pci_dev *pdev) } #ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT +static int add_virtual_device(struct pci_dev *pdev) +{ +struct domain *d = pdev

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023: > On 07.07.23 16:42, Roger Pau Monné wrote: > > On Fri, Jul 07, 2023 at 04:10:14PM +0200, Juergen Gross wrote: > > > On 07.07.23 11:50, Roger Pau Monné wrote: > > > > On Fri, Jul 07, 2023 at 06:38:48AM +0200, Juergen Gross wrote: > > > > > On 06.07.23 23:49, Stefano Stabellini w

[linux-linus test] 181732: regressions - trouble: broken/fail/pass

2023-07-07 Thread osstest service owner
flight 181732 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181732/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-pvshim broken test-amd64-amd64-xl-pvshim5 host-insta

Re: [PATCH 2/2] xen/virtio: Avoid use of the dom0 backend in dom0

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023, Juergen Gross wrote: > On 26.06.23 15:17, Petr Pavlu wrote: > > On 6/21/23 19:58, Oleksandr Tyshchenko wrote: > > > On 21.06.23 16:12, Petr Pavlu wrote: > > > > When attempting to run Xen on a QEMU/KVM virtual machine with virtio > > > > devices (all x86_64), dom0 tries to estab

Re: [RFC PATCH] xen/arm: Rebranding dom0less feature

2023-07-07 Thread Christopher Clark
+CC members of the Hyperlaunch Working Group + participants on earlier Hyperlaunch threads On Thu, Jul 6, 2023 at 2:39 PM Stefano Stabellini < stefano.stabell...@amd.com> wrote: > On Thu, 6 Jul 2023, George Dunlap wrote: > > On Wed, Jul 5, 2023 at 11:14 PM Stefano Stabellini < > stefano.stabell..

Re: [PATCH] docs/misra: add Rule 7.4 and 9.4

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023, Jan Beulich wrote: > On 07.07.2023 00:46, Stefano Stabellini wrote: > > --- a/docs/misra/rules.rst > > +++ b/docs/misra/rules.rst > > @@ -203,6 +203,13 @@ maintainers if you want to suggest a change. > > - The lowercase character l shall not be used in a literal suffix > >

Re: [XEN PATCH v2] x86: make function declarations consistent with definitions

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023, Jan Beulich wrote: > On 07.07.2023 00:29, Stefano Stabellini wrote: > > On Thu, 6 Jul 2023, Jan Beulich wrote: > >> On 06.07.2023 01:22, Stefano Stabellini wrote: > >>> On Tue, 4 Jul 2023, Jan Beulich wrote: > On 04.07.2023 12:23, Federico Serafini wrote: > > Change mec

Re: [XEN PATCH v2 12/13] xen/x86: fix violations of MISRA C:2012 Rule 7.2

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023, Jan Beulich wrote: > On 07.07.2023 10:04, Simone Ballarin wrote: > > Il giorno ven 7 lug 2023 alle ore 09:04 Jan Beulich ha > > scritto: > > > >> On 07.07.2023 08:50, Simone Ballarin wrote: > >>> Il giorno gio 6 lug 2023 alle ore 18:22 Jan Beulich > >> ha > >>> scritto: > >>>

Python in Domain Configurations

2023-07-07 Thread Elliott Mitchell
There is a distinct weakness in Xen which ends up dragging in domain configuration limitations. I was thinking of using Python for parsing extra data out of domain configuration files. Only to find sample domain configuration files were in fact fully valid Python. Having experimented, it appears

Re: [RFC PATCH] xen/arm: Rebranding dom0less feature

2023-07-07 Thread Christopher Clark
+CC openxt, Jason, Marek On Fri, Jul 7, 2023 at 2:06 PM Christopher Clark < christopher.w.cl...@gmail.com> wrote: > +CC members of the Hyperlaunch Working Group + participants on earlier > Hyperlaunch threads > > On Thu, Jul 6, 2023 at 2:39 PM Stefano Stabellini < > stefano.stabell...@amd.com> wr

Re: [RFC PATCH] xen/arm: Rebranding dom0less feature

2023-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2023, Christopher Clark wrote: > +CC openxt, Jason, Marek > > On Fri, Jul 7, 2023 at 2:06 PM Christopher Clark > wrote: > +CC members of the Hyperlaunch Working Group + participants on earlier > Hyperlaunch threads > > On Thu, Jul 6, 2023 at 2:39 PM Stefano Stabellini > w

Re: [RFC PATCH] xen/arm: Rebranding dom0less feature

2023-07-07 Thread Rich Persaud
On Jul 7, 2023, at 21:17, Stefano Stabellini wrote: > > On Fri, 7 Jul 2023, Christopher Clark wrote: >> +CC openxt, Jason, Marek >> >> On Fri, Jul 7, 2023 at 2:06 PM Christopher Clark >> wrote: >> +CC members of the Hyperlaunch Working Group + participants on earlier >> Hyperlaunch thre

[linux-linus test] 181735: regressions - FAIL

2023-07-07 Thread osstest service owner
flight 181735 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/181735/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 180278 test-amd64