Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-22 Thread Jan Beulich
On 19.05.2023 16:38, Andrew Cooper wrote: > On 19/05/2023 7:00 am, Jan Beulich wrote: >> On 17.05.2023 18:35, Andrew Cooper wrote: >>> On 17/05/2023 3:47 pm, Jan Beulich wrote: On 16.05.2023 16:53, Andrew Cooper wrote: > @@ -401,6 +400,8 @@ static void __init print_details(enum ind_thunk

Re: [PATCH 3/6] x86/cpu-policy: Infrastructure for MSR_ARCH_CAPS

2023-05-22 Thread Jan Beulich
On 19.05.2023 17:36, Andrew Cooper wrote: > On 16/05/2023 1:02 pm, Jan Beulich wrote: >> On 15.05.2023 16:42, Andrew Cooper wrote: >>> Bits through 24 are already defined, meaning that we're not far off needing >>> the second word. Put both in right away. >>> >>> The bool bitfield names in the arc

Re: [PATCH 6/6] x86/boot: Expose MSR_ARCH_CAPS data in guest max policies

2023-05-22 Thread Jan Beulich
On 19.05.2023 17:52, Andrew Cooper wrote: > On 17/05/2023 10:20 am, Jan Beulich wrote: >> On 16.05.2023 21:31, Andrew Cooper wrote: >>> On 16/05/2023 3:53 pm, Jan Beulich wrote: I guess that's no different from other max-only features with dependents, but I wonder whether that's good

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Jan Beulich
On 19.05.2023 16:46, Julien Grall wrote: > On 19/05/2023 15:26, Luca Fancellu wrote: >>> On 18 May 2023, at 10:35, Julien Grall wrote: +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */ + +#include +#include +#include +#includ

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-22 Thread Petr Tesařík
Hi Christoph, On Sat, 20 May 2023 08:21:03 +0200 Christoph Hellwig wrote: > On Fri, May 19, 2023 at 02:58:57PM +0200, Christoph Hellwig wrote: > > On Fri, May 19, 2023 at 01:49:46PM +0100, Andrew Cooper wrote: > > > > The alternative would be to finally merge swiotlb-xen into swiotlb, in > > >

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-22 Thread Petr Tesařík
On Fri, 19 May 2023 12:10:26 +0200 Marek Marczykowski-Górecki wrote: > On Fri, May 19, 2023 at 06:04:05AM +0200, Christoph Hellwig wrote: > > On Thu, May 18, 2023 at 08:18:39PM +0200, Marek Marczykowski-Górecki wrote: > > > > > On Thu, May 18, 2023 at 03:42:51PM +0200, Christoph Hellwig wrote:

Re: [PATCH 2/3] docs: document ~/control/feature-balloon

2023-05-22 Thread Yann Dirson
On 5/11/23 11:21, Jan Beulich wrote: > On 10.05.2023 16:20, Yann Dirson wrote: >> --- a/docs/misc/xenstore-paths.pandoc >> +++ b/docs/misc/xenstore-paths.pandoc >> @@ -509,6 +509,12 @@ This may be initialized to "" by the toolstack and may >> then be set >> to 0 or 1 by a guest to indicate wh

Re: [PATCH 2/4] x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-05-22 Thread Juergen Gross
On 19.05.23 12:10, Marek Marczykowski-Górecki wrote: On Fri, May 19, 2023 at 06:04:05AM +0200, Christoph Hellwig wrote: On Thu, May 18, 2023 at 08:18:39PM +0200, Marek Marczykowski-Górecki wrote: On Thu, May 18, 2023 at 03:42:51PM +0200, Christoph Hellwig wrote: Remove the dangerous late initi

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Luca Fancellu
> On 22 May 2023, at 08:50, Jan Beulich wrote: > > On 19.05.2023 16:46, Julien Grall wrote: >> On 19/05/2023 15:26, Luca Fancellu wrote: On 18 May 2023, at 10:35, Julien Grall wrote: > +/* > + * Arm SVE feature code > + * > + * Copyright (C) 2022 ARM Ltd. > + */ >

Re: [PATCH v2 1/2] build: shorten macro references

2023-05-22 Thread Jan Beulich
On 08.05.2023 14:58, Jan Beulich wrote: > Presumably by copy-and-paste we've accumulated a number of instances of > $(@D)/$(@F), which really is nothing else than $@. The split form only > needs using when we want to e.g. insert a leading . at the beginning of > the file name portion of the full na

Re: [PATCH v1] xen/sched/null: avoid crash after failed domU creation

2023-05-22 Thread Dario Faggioli
On Thu, 2023-05-18 at 17:27 -0400, Stewart Hildebrand wrote: > On 5/5/23 01:59, Juergen Gross wrote: > > > > > > Signed-off-by: Stewart Hildebrand > > > > Reviewed-by: Juergen Gross > > Thanks for the review. Does this still need a maintainer ack? > Acked-by: Dario Faggioli Regards -- Dario

Re: [PATCH] maintainers: add regex matching for xsm

2023-05-22 Thread Jan Beulich
On 19.05.2023 13:48, Daniel P. Smith wrote: > XSM is a subsystem where it is equally important of how and where its hooks > are > called as is the implementation of the hooks. The people best suited for > evaluating the how and where are the XSM maintainers and reviewers. This > creates a challeng

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Julien Grall
Hi, On 22/05/2023 09:43, Luca Fancellu wrote: On 22 May 2023, at 08:50, Jan Beulich wrote: On 19.05.2023 16:46, Julien Grall wrote: On 19/05/2023 15:26, Luca Fancellu wrote: On 18 May 2023, at 10:35, Julien Grall wrote: +/* + * Arm SVE feature code + * + * Copyright (C) 2022 ARM Ltd. + */

Re: [PATCH v6 01/12] xen/arm: enable SVE extension for Xen

2023-05-22 Thread Luca Fancellu
> On 22 May 2023, at 10:30, Julien Grall wrote: > > Hi, > > On 22/05/2023 09:43, Luca Fancellu wrote: >>> On 22 May 2023, at 08:50, Jan Beulich wrote: >>> >>> On 19.05.2023 16:46, Julien Grall wrote: On 19/05/2023 15:26, Luca Fancellu wrote: >> On 18 May 2023, at 10:35, Julien Grall

Re: [PATCH v6 05/12] arm/sve: save/restore SVE context switch

2023-05-22 Thread Luca Fancellu
> On 18 May 2023, at 19:30, Julien Grall wrote: > > Hi Luca, > > One more remark. > > On 24/04/2023 07:02, Luca Fancellu wrote: >> #else /* !CONFIG_ARM64_SVE */ >> @@ -46,6 +50,15 @@ static inline unsigned int get_sys_vl_len(void) >> return 0; >> } >> +static inline int sve_context_i

Re: [PATCH] maintainers: add regex matching for xsm

2023-05-22 Thread Julien Grall
Hi, On 22/05/2023 10:23, Jan Beulich wrote: On 19.05.2023 13:48, Daniel P. Smith wrote: XSM is a subsystem where it is equally important of how and where its hooks are called as is the implementation of the hooks. The people best suited for evaluating the how and where are the XSM maintainers a

[PATCH] x86/apic: Fix use of X{,2}APIC_ENABLE in asm with older binutils

2023-05-22 Thread Andrew Cooper
"x86/smpboot: Support parallel startup of secondary CPUs" adds the first use of X2APIC_ENABLE in assembly, but older binutils don't tolerate the UL suffix. Switch to using BIT() instead. Fixes: 7e75178a0950 ("x86/smpboot: Support parallel startup of secondary CPUs") Reported-by: Jeffrey Hugo Tes

[qemu-mainline test] 180887: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180887 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180887/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

Re: [PATCH] x86/apic: Fix use of X{,2}APIC_ENABLE in asm with older binutils

2023-05-22 Thread Russell King (Oracle)
Hi, Please can you tell me what the relevance of this patch is to me, and thus why I'm included in the Cc list? I have never touched this file, not in its current path nor a previous path according to git. Thanks. On Mon, May 22, 2023 at 11:57:38AM +0100, Andrew Cooper wrote: > "x86/smpboot: Sup

[xen-unstable test] 180884: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180884 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180884/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 180839 Tests which are fa

[PATCH v8 5/5] xen/riscv: remove dummy_bss variable

2023-05-22 Thread Oleksii Kurochko
After introduction of initial pagetables there is no any sense in dummy_bss variable as bss section will not be empty anymore. Signed-off-by: Oleksii Kurochko --- Changes in V8: - Nothing changed. Only rebase --- Changes in V7: - Nothing changed. Only rebase --- Changes in V6: - Nothing change

[PATCH v8 4/5] xen/riscv: setup initial pagetables

2023-05-22 Thread Oleksii Kurochko
The patch does two thing: 1. Setup initial pagetables. 2. Enable MMU which end up with code in cont_after_mmu_is_enabled() Signed-off-by: Oleksii Kurochko --- Changes in V8: - Nothing changed. Only rebase --- Changes in V7: - Nothing changed. Only rebase --- Changes in V6: - Nothing changed

[PATCH v8 2/5] xen/riscv: introduce setup_initial_pages

2023-05-22 Thread Oleksii Kurochko
The idea was taken from xvisor but the following changes were done: * Use only a minimal part of the code enough to enable MMU * rename {_}setup_initial_pagetables functions * add an argument for setup_initial_mapping to have an opportunity to make set PTE flags. * update setup_initial_pagetables

[PATCH v8 1/5] xen/riscv: add VM space layout

2023-05-22 Thread Oleksii Kurochko
Also it was added explanation about ignoring of top VA bits Signed-off-by: Oleksii Kurochko --- Changes in V8: - Add "#ifdef RV_STAGE1_MODE == SATP_MODE_SV39" instead of "#ifdef SV39" in the comment to VM layout description. - Update the upper bound of direct map area in VM layout descriptio

[PATCH v8 0/5] enable MMU for RISC-V

2023-05-22 Thread Oleksii Kurochko
The patch series introduces the following things: 1. Functionality to build the page tables for Xen that map link-time to physical-time location. 2. Check that Xen is less then page size. 3. Check that load addresses don't overlap with linker addresses. 4. Prepare things for proper switch to vir

[PATCH v8 3/5] xen/riscv: align __bss_start

2023-05-22 Thread Oleksii Kurochko
bss clear cycle requires proper alignment of __bss_start. ALIGN(PAGE_SIZE) before "*(.bss.page_aligned)" in xen.lds.S was removed as any contribution to "*(.bss.page_aligned)" have to specify proper aligntment themselves. Fixes: cfa0409f7cbb ("xen/riscv: initialize .bss section") Signed-off-by: O

Re: [PATCH v6 05/12] arm/sve: save/restore SVE context switch

2023-05-22 Thread Jan Beulich
On 22.05.2023 12:20, Luca Fancellu wrote: > > >> On 18 May 2023, at 19:30, Julien Grall wrote: >> >> Hi Luca, >> >> One more remark. >> >> On 24/04/2023 07:02, Luca Fancellu wrote: >>> #else /* !CONFIG_ARM64_SVE */ >>> @@ -46,6 +50,15 @@ static inline unsigned int get_sys_vl_len(void) >>>

Re: [PATCH v6 05/12] arm/sve: save/restore SVE context switch

2023-05-22 Thread Luca Fancellu
> On 22 May 2023, at 13:41, Jan Beulich wrote: > > On 22.05.2023 12:20, Luca Fancellu wrote: >> >> >>> On 18 May 2023, at 19:30, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> One more remark. >>> >>> On 24/04/2023 07:02, Luca Fancellu wrote: #else /* !CONFIG_ARM64_SVE */ @@ -46,6

Re: [PATCH v3 10/14 RESEND] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op

2023-05-22 Thread Jason Andryuk
On Mon, May 8, 2023 at 7:27 AM Jan Beulich wrote: > > On 01.05.2023 21:30, Jason Andryuk wrote: > > @@ -531,6 +533,100 @@ int get_hwp_para(const struct cpufreq_policy *policy, > > return 0; > > } > > > > +int set_hwp_para(struct cpufreq_policy *policy, > > + struct xen_set_hw

Re: [PATCH v8 1/5] xen/riscv: add VM space layout

2023-05-22 Thread Jan Beulich
On 22.05.2023 14:18, Oleksii Kurochko wrote: > --- a/xen/arch/riscv/include/asm/config.h > +++ b/xen/arch/riscv/include/asm/config.h > @@ -4,6 +4,42 @@ > #include > #include > > +/* > + * RISC-V64 Layout: > + * > + * #ifdef RV_STAGE1_MODE == SATP_MODE_SV39 Nit: #if please, not #ifdef. Also m

Re: [PATCH v3 13/14 RESEND] xenpm: Add set-cpufreq-hwp subcommand

2023-05-22 Thread Jason Andryuk
On Mon, May 8, 2023 at 7:56 AM Jan Beulich wrote: > > On 01.05.2023 21:30, Jason Andryuk wrote: > > @@ -67,6 +68,27 @@ void show_help(void) > > " set-max-cstate|'unlimited' > > [|'unlimited']\n" > > " set the C-State > > limit

Re: [RFC] Xen crashes on ASSERT on suspend/resume, suggested fix

2023-05-22 Thread Jan Beulich
On 19.05.2023 01:44, Stefano Stabellini wrote: > Hi all, > > After many PVH Dom0 suspend/resume cycles we are seeing the following > Xen crash (it is random and doesn't reproduce reliably): > > (XEN) [555.042981][] R > arch/x86/irq.c#_clear_irq_vector+0x214/0x2bd > (XEN) [555.042986][] F destroy

Re: [PATCH v3 10/14 RESEND] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op

2023-05-22 Thread Jan Beulich
On 22.05.2023 14:45, Jason Andryuk wrote: > On Mon, May 8, 2023 at 7:27 AM Jan Beulich wrote: >> >> On 01.05.2023 21:30, Jason Andryuk wrote: >>> @@ -531,6 +533,100 @@ int get_hwp_para(const struct cpufreq_policy *policy, >>> return 0; >>> } >>> >>> +int set_hwp_para(struct cpufreq_policy *p

Re: [PATCH v3 13/14 RESEND] xenpm: Add set-cpufreq-hwp subcommand

2023-05-22 Thread Jan Beulich
On 22.05.2023 14:59, Jason Andryuk wrote: > On Mon, May 8, 2023 at 7:56 AM Jan Beulich wrote: >> On 01.05.2023 21:30, Jason Andryuk wrote: >>> +static int parse_hwp_opts(xc_set_hwp_para_t *set_hwp, int *cpuid, >>> + int argc, char *argv[]) >>> +{ >>> +int i = 0; >>> +

Re: [PATCH 6/6] x86/boot: Expose MSR_ARCH_CAPS data in guest max policies

2023-05-22 Thread Andrew Cooper
On 22/05/2023 8:31 am, Jan Beulich wrote: > On 19.05.2023 17:52, Andrew Cooper wrote: >> On 17/05/2023 10:20 am, Jan Beulich wrote: >>> On 16.05.2023 21:31, Andrew Cooper wrote: On 16/05/2023 3:53 pm, Jan Beulich wrote: > I guess that's no > different from other max-only features with

Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-22 Thread Andrew Cooper
On 22/05/2023 8:10 am, Jan Beulich wrote: > On 19.05.2023 16:38, Andrew Cooper wrote: >> On 19/05/2023 7:00 am, Jan Beulich wrote: >>> On 17.05.2023 18:35, Andrew Cooper wrote: On 17/05/2023 3:47 pm, Jan Beulich wrote: > On 16.05.2023 16:53, Andrew Cooper wrote: >> @@ -401,6 +400,8 @@

Re: [PATCH v6 00/16] x86/mtrr: fix handling with PAT but without MTRR

2023-05-22 Thread Juergen Gross
On 11.05.23 18:32, Borislav Petkov wrote: On Wed, May 10, 2023 at 05:53:15PM +0200, Juergen Gross wrote: Urgh, yes, there is something missing: diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 031f7ea8e72b..9544e7d13bb3 100644 --- a/arch/x86/kernel/cpu

Re: [PATCH] MAINTAINERS: add more xenstore files

2023-05-22 Thread Juergen Gross
On 17.05.23 17:19, Jan Beulich wrote: On 28.04.2023 15:27, Juergen Gross wrote: Xenstore consists of more files than just the tools/xenstore directory. Add them to the XENSTORE block. Suggested-by: Andrew Cooper Signed-off-by: Juergen Gross --- MAINTAINERS | 5 + 1 file changed, 5 ins

Re: [PATCH v8 2/5] xen/riscv: introduce setup_initial_pages

2023-05-22 Thread Jan Beulich
On 22.05.2023 14:18, Oleksii Kurochko wrote: > The idea was taken from xvisor but the following changes > were done: > * Use only a minimal part of the code enough to enable MMU > * rename {_}setup_initial_pagetables functions > * add an argument for setup_initial_mapping to have > an opportunity

Re: [PATCH v8 1/5] xen/riscv: add VM space layout

2023-05-22 Thread Oleksii
On Mon, 2023-05-22 at 14:47 +0200, Jan Beulich wrote: > On 22.05.2023 14:18, Oleksii Kurochko wrote: > > --- a/xen/arch/riscv/include/asm/config.h > > +++ b/xen/arch/riscv/include/asm/config.h > > @@ -4,6 +4,42 @@ > >  #include > >  #include > >   > > +/* > > + * RISC-V64 Layout: > > + * > > + *

Re: [PATCH v3 1/6] xen/arm: Move is_protected flag to struct device

2023-05-22 Thread Michal Orzel
Hi Stewart, On 18/05/2023 23:06, Stewart Hildebrand wrote: > > > From: Oleksandr Tyshchenko > > This flag will be re-used for PCI devices by the subsequent > patches. > > Signed-off-by: Oleksandr Tyshchenko > Signed-off-by: Stewart Hildebrand > --- > v2->v3: > * no change > > v1->v2: > * n

Re: [PATCH 4/4] x86/spec-ctrl: Remove opencoded MSR_ARCH_CAPS check

2023-05-22 Thread Jan Beulich
On 22.05.2023 16:14, Andrew Cooper wrote: > On 22/05/2023 8:10 am, Jan Beulich wrote: >> On 19.05.2023 16:38, Andrew Cooper wrote: >>> On 19/05/2023 7:00 am, Jan Beulich wrote: On 17.05.2023 18:35, Andrew Cooper wrote: > On 17/05/2023 3:47 pm, Jan Beulich wrote: >> On 16.05.2023 16:53,

Re: [PATCH v3 10/14 RESEND] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op

2023-05-22 Thread Jason Andryuk
On Mon, May 22, 2023 at 9:11 AM Jan Beulich wrote: > > On 22.05.2023 14:45, Jason Andryuk wrote: > > On Mon, May 8, 2023 at 7:27 AM Jan Beulich wrote: > >> > >> On 01.05.2023 21:30, Jason Andryuk wrote: > >>> +if ( set_hwp->activity_window & ~XEN_SYSCTL_HWP_ACT_WINDOW_MASK ) > >>> +re

Re: [PATCH v3 2/6] iommu/arm: Add iommu_dt_xlate()

2023-05-22 Thread Michal Orzel
Hi Stewart, On 18/05/2023 23:06, Stewart Hildebrand wrote: > > > From: Oleksandr Tyshchenko > > Move code for processing DT IOMMU specifier to a separate helper. > This helper will be re-used for adding PCI devices by the subsequent > patches as we will need exact the same actions for processi

Re: [PATCH] docs/misra: adds Mandatory rules

2023-05-22 Thread Bertrand Marquis
Hi Stefano, > On 12 May 2023, at 01:22, Stefano Stabellini wrote: > > From: Stefano Stabellini > > Add the Mandatory rules agreed by the MISRA C working group to > docs/misra/rules.rst. > > Signed-off-by: Stefano Stabellini Acked-by: Bertrand Marquis Cheers Bertrand > --- > docs/misra/r

Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

2023-05-22 Thread Bernhard Beschow
Am 15. Mai 2023 20:52:40 UTC schrieb Stefano Stabellini : >On Sat, 13 May 2023, Bernhard Beschow wrote: >> Am 21. April 2023 07:38:10 UTC schrieb "Michael S. Tsirkin" >> : >> >On Mon, Apr 03, 2023 at 09:41:17AM +0200, Bernhard Beschow wrote: >> >> There is currently a dedicated PIIX3 device mo

Re: [PATCH RFC] build: respect top-level .config also for out-of-tree hypervisor builds

2023-05-22 Thread Anthony PERARD
On Mon, May 08, 2023 at 08:23:43AM +0200, Jan Beulich wrote: > On 05.05.2023 18:08, Anthony PERARD wrote: > > On Wed, Mar 15, 2023 at 03:58:59PM +0100, Jan Beulich wrote: > >> With in-tree builds Config.mk includes a .config file (if present) from > >> the top-level directory. Similar functionality

[PATCH] MAINTAINERS: remove xenstore related files from LIBS

2023-05-22 Thread Juergen Gross
There is no need to have the Xenstore headers listed in the LIBS section now that they have been added to the XENSTORE section. Suggested-by: Jan Beulich Signed-off-by: Juergen Gross --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f2f1881b32.

Re: [PATCH v2 00/10] x86: support AVX512-FP16

2023-05-22 Thread Andrew Cooper
On 03/04/2023 3:56 pm, Jan Beulich wrote: > While I (quite obviously) don't have any suitable hardware, Intel's > SDE allows testing the implementation. And since there's no new > state (registers) associated with this ISA extension, this should > suffice for integration. I've given this a spin on

Re: [XEN PATCH] tools/xendomains: Don't auto save/restore/migrate on Arm*

2023-05-22 Thread Peter Hoyes
On 19/05/2023 17:24, Anthony PERARD wrote: Saving, restoring and migrating domains are not currently supported on arm and arm64 platforms, so xendomains prints the warning: An error occurred while saving domain: command not implemented when attempting to run `xendomains stop`. It otherwis

[xen-unstable-smoke test] 180897: tolerable all pass - PUSHED

2023-05-22 Thread osstest service owner
flight 180897 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180897/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] maintainers: add regex matching for xsm

2023-05-22 Thread Daniel P. Smith
On 5/22/23 05:23, Jan Beulich wrote: On 19.05.2023 13:48, Daniel P. Smith wrote: XSM is a subsystem where it is equally important of how and where its hooks are called as is the implementation of the hooks. The people best suited for evaluating the how and where are the XSM maintainers and revie

[PATCH v2] maintainers: add regex matching for xsm

2023-05-22 Thread Daniel P. Smith
XSM is a subsystem where it is equally important of how and where its hooks are called as is the implementation of the hooks. The people best suited for evaluating the how and where are the XSM maintainers and reviewers. This creates a challenge as the hooks are used throughout the hypervisor for w

Re: [XEN PATCH] tools/xendomains: Don't auto save/restore/migrate on Arm*

2023-05-22 Thread Julien Grall
Hi Anthony, On 19/05/2023 17:24, Anthony PERARD wrote: Saving, restoring and migrating domains are not currently supported on arm and arm64 platforms, so xendomains prints the warning: An error occurred while saving domain: command not implemented when attempting to run `xendomains stop`

Re: [PATCH] maintainers: add regex matching for xsm

2023-05-22 Thread Daniel P. Smith
On 5/22/23 06:27, Julien Grall wrote: Hi, On 22/05/2023 10:23, Jan Beulich wrote: On 19.05.2023 13:48, Daniel P. Smith wrote: XSM is a subsystem where it is equally important of how and where its hooks are called as is the implementation of the hooks. The people best suited for evaluating the

[qemu-mainline test] 180894: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180894 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180894/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

Re: [patch V4 33/37] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE

2023-05-22 Thread Mark Brown
2C20%2C2%2C0%2C9905 Other boards I've checked (including some with multiple CPU clusters) seem to be bringing up all their CPUs so it doesn't seem to just be general breakage. Log from my bisect: git bisect start # bad: [9f258af06b6268be8e960f63c3f66e88bdbbbdb0

Re: [patch V4 33/37] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE

2023-05-22 Thread Thomas Gleixner
On Mon, May 22 2023 at 20:45, Mark Brown wrote: > On Fri, May 12, 2023 at 11:07:50PM +0200, Thomas Gleixner wrote: >> From: Thomas Gleixner >> >> There is often significant latency in the early stages of CPU bringup, and >> time is wasted by waking each CPU (e.g. with SIPI/INIT/INIT on x86) and >

Re: PVH Dom0 related UART failure

2023-05-22 Thread Stefano Stabellini
On Sat, 20 May 2023, Roger Pau Monné wrote: > diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c > index ec2e978a4e6b..0ff8e940fa8d 100644 > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -289,6 +289,13 @@ static int modify_bars(const struct pci_dev *pdev, >

Re: [patch V4 33/37] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE

2023-05-22 Thread Mark Brown
On Mon, May 22, 2023 at 11:04:17PM +0200, Thomas Gleixner wrote: > That does not make any sense at all and my tired brain does not help > either. > Can you please apply the below debug patch and provide the output? Here's the log, a quick glance says the if (!--ncpus) b

Re: [patch V4 33/37] cpu/hotplug: Allow "parallel" bringup up to CPUHP_BP_KICK_AP_STATE

2023-05-22 Thread Thomas Gleixner
On Mon, May 22 2023 at 23:27, Mark Brown wrote: > On Mon, May 22, 2023 at 11:04:17PM +0200, Thomas Gleixner wrote: > >> That does not make any sense at all and my tired brain does not help >> either. > >> Can you please apply the below debug patch and provide the output? > > Here's the log, a quick

[qemu-mainline bisection] complete build-armhf

2023-05-22 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job build-armhf testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu https://gitlab.com/qemu-project/qemu.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduc

[linux-linus test] 180890: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180890 linux-linus real [real] flight 180905 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180890/ http://logs.test-lab.xenproject.org/osstest/logs/180905/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

[qemu-mainline test] 180902: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180902 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180902/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

[qemu-mainline test] 180906: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180906 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180906/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

[ovmf test] 180908: all pass - PUSHED

2023-05-22 Thread osstest service owner
flight 180908 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180908/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5ce29ae84db340244c3c3299f84713a88dec5171 baseline version: ovmf c5cf7f69c98baed40754c

[qemu-mainline test] 180909: regressions - FAIL

2023-05-22 Thread osstest service owner
flight 180909 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/180909/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 180691 build-amd64

RE: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-22 Thread Henry Wang
Hi Jan, > -Original Message- > Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device > tree NUMA distance map > > > +/* The default value in node_distance_map is > >> NUMA_NO_DISTANCE > */ > > +if ( opposite == NUMA_NO_DISTANCE ) > > >

Re: [XEN PATCH v8 03/22] tools: add Arm FF-A mediator

2023-05-22 Thread Jens Wiklander
On Thu, May 18, 2023 at 4:35 PM Anthony PERARD wrote: > > On Thu, Apr 13, 2023 at 09:14:05AM +0200, Jens Wiklander wrote: > > Adds a new "ffa" value to the Enumeration "tee_type" to indicate if a > > guest is trusted to use FF-A. > > Is "ffa" working yet in the hypervisor? (At this point in the pa

Re: [PATCH v2 00/10] x86: support AVX512-FP16

2023-05-22 Thread Jan Beulich
On 22.05.2023 18:25, Andrew Cooper wrote: > On 03/04/2023 3:56 pm, Jan Beulich wrote: >> While I (quite obviously) don't have any suitable hardware, Intel's >> SDE allows testing the implementation. And since there's no new >> state (registers) associated with this ISA extension, this should >> suf

Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device tree NUMA distance map

2023-05-22 Thread Jan Beulich
On 23.05.2023 08:31, Henry Wang wrote: >> -Original Message- >> Subject: Re: [PATCH v4 09/17] xen/arm: introduce a helper to parse device >> tree NUMA distance map >> >>> +/* The default value in node_distance_map is NUMA_NO_DISTANCE >> */ >>> +if ( opposite

Re: PVH Dom0 related UART failure

2023-05-22 Thread Jan Beulich
On 23.05.2023 00:20, Stefano Stabellini wrote: > On Sat, 20 May 2023, Roger Pau Monné wrote: >> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c >> index ec2e978a4e6b..0ff8e940fa8d 100644 >> --- a/xen/drivers/vpci/header.c >> +++ b/xen/drivers/vpci/header.c >> @@ -289,6 +289,13 @@

Re: [PATCH RFC] build: respect top-level .config also for out-of-tree hypervisor builds

2023-05-22 Thread Jan Beulich
On 22.05.2023 17:49, Anthony PERARD wrote: > On Mon, May 08, 2023 at 08:23:43AM +0200, Jan Beulich wrote: >> On 05.05.2023 18:08, Anthony PERARD wrote: >>> On Wed, Mar 15, 2023 at 03:58:59PM +0100, Jan Beulich wrote: With in-tree builds Config.mk includes a .config file (if present) from